Re: [PULL 00/23] QEMU changes for 7.0 soft freeze

2022-03-09 Thread Thomas Huth
On 09/03/2022 17.07, Paolo Bonzini wrote: On 3/9/22 10:46, Thomas Huth wrote: That one also drops the progress report of non-failed tests, so I'm not sure it's an improvement. That only works here anyway if I don't run "make check" with the "-jX" option ... which I hardly do, since it then

[PATCH v4] tests: Do not treat the iotests as separate meson test target anymore

2022-03-09 Thread Thomas Huth
If there is a failing iotest, the output is currently not logged to the console anymore. To get this working again, we need to run the meson test runner with "--print-errorlogs" (and without "--verbose" due to a current meson bug that will be fixed here:

Re: [PULL 00/23] QEMU changes for 7.0 soft freeze

2022-03-09 Thread Thomas Huth
On 09/03/2022 19.44, Peter Maydell wrote: On Wed, 9 Mar 2022 at 09:47, Thomas Huth wrote: Since the fix is not available in any meson release yet and we're in QEMU softfreeze now, I'm now also not quite sure anymore whether we really should go forward with the TAP approach right now... maybe

Re: [RFC PATCH] hw/i386/e820: remove legacy reserved entries for e820

2022-03-09 Thread Ani Sinha
On Mon, Feb 28, 2022 at 8:56 PM Ani Sinha wrote: > > e820 reserved entries were used before the dynamic entries with fw config > files > were intoduced into qemu with the following change: > 7d67110f2d9a6("pc: add etc/e820 fw_cfg file") > > Identical support was introduced into seabios as well

Re: [PATCH v2] tests: add (riscv virt) machine mapping to testenv

2022-03-09 Thread laokz
On Wed, Mar 09, 2022 at 15:56 +0100,Hanna Reitz wrote: > On 08.03.22 05:33, laokz wrote: > > Some qemu-iotests(040 etc) use PCI disk to do test. Without the > > mapping, RISC-V flavor use spike as default machine which has no > > PCI bus, causing test failure. > > > > Resolves:

[PATCH] aspeed: sbc: Correct default reset values

2022-03-09 Thread Joel Stanley
In order to correctly report secure boot running firmware, these values must be set. They are taken from a running machine when secure boot is enabled. We don't yet have documentation from ASPEED on what they mean. Set the raw values for now, and in the future improve the model with properties to

[PULL V2 13/15] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ

2022-03-09 Thread Jason Wang
From: Eugenio Pérez This is needed to achieve migration, so the destination can restore its index. Setting base as last used idx, so destination will see as available all the entries that the device did not use, including the in-flight processing ones. This is ok for networking, but other

[PULL V2 11/15] vhost: Add VhostIOVATree

2022-03-09 Thread Jason Wang
From: Eugenio Pérez This tree is able to look for a translated address from an IOVA address. At first glance it is similar to util/iova-tree. However, SVQ working on devices with limited IOVA space need more capabilities, like allocating IOVA chunks or performing reverse translations (qemu

[PULL V2 10/15] util: add iova_tree_find_iova

2022-03-09 Thread Jason Wang
From: Eugenio Pérez This function does the reverse operation of iova_tree_find: To look for a mapping that match a translated address so we can do the reverse. This have linear complexity instead of logarithmic, but it supports overlapping HVA. Future developments could reduce it. Acked-by:

[PULL V2 09/15] util: Add iova_tree_alloc_map

2022-03-09 Thread Jason Wang
From: Eugenio Pérez This iova tree function allows it to look for a hole in allocated regions and return a totally new translation for a given translated address. It's usage is mainly to allow devices to access qemu address space, remapping guest's one into a new iova space where qemu can add

[PULL V2 15/15] vdpa: Expose VHOST_F_LOG_ALL on SVQ

2022-03-09 Thread Jason Wang
From: Eugenio Pérez SVQ is able to log the dirty bits by itself, so let's use it to not block migration. Also, ignore set and clear of VHOST_F_LOG_ALL on set_features if SVQ is enabled. Even if the device supports it, the reports would be nonsense because SVQ memory is in the qemu region. The

Re: [PULL 00/15] Net patches

2022-03-09 Thread Jason Wang
On Thu, Mar 10, 2022 at 4:01 AM Peter Maydell wrote: > On Tue, 8 Mar 2022 at 13:35, Jason Wang wrote: > > > > The following changes since commit > f45cc81911adc7726e8a2801986b6998b91b816e: > > > > Merge remote-tracking branch > 'remotes/cschoenebeck/tags/pull-9p-20220307' into staging

[PULL V2 12/15] vdpa: Add custom IOTLB translations to SVQ

2022-03-09 Thread Jason Wang
From: Eugenio Pérez Use translations added in VhostIOVATree in SVQ. Only introduce usage here, not allocation and deallocation. As with previous patches, we use the dead code paths of shadow_vqs_enabled to avoid commiting too many changes at once. These are impossible to take at the moment.

[PULL V2 14/15] vdpa: Never set log_base addr if SVQ is enabled

2022-03-09 Thread Jason Wang
From: Eugenio Pérez Setting the log address would make the device start reporting invalid dirty memory because the SVQ vrings are located in qemu's memory. Acked-by: Michael S. Tsirkin Signed-off-by: Eugenio Pérez Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 3 ++- 1 file changed,

[PULL V2 06/15] virtio: Add vhost_svq_get_vring_addr

2022-03-09 Thread Jason Wang
From: Eugenio Pérez It reports the shadow virtqueue address from qemu virtual address space. Since this will be different from the guest's vaddr, but the device can access it, SVQ takes special care about its alignment & lack of garbage data. It assumes that IOMMU will work in host_page_size

[PULL V2 08/15] vhost: Shadow virtqueue buffers forwarding

2022-03-09 Thread Jason Wang
From: Eugenio Pérez Initial version of shadow virtqueue that actually forward buffers. There is no iommu support at the moment, and that will be addressed in future patches of this series. Since all vhost-vdpa devices use forced IOMMU, this means that SVQ is not usable at this point of the

[PULL V2 07/15] vdpa: adapt vhost_ops callbacks to svq

2022-03-09 Thread Jason Wang
From: Eugenio Pérez First half of the buffers forwarding part, preparing vhost-vdpa callbacks to SVQ to offer it. QEMU cannot enable it at this moment, so this is effectively dead code at the moment, but it helps to reduce patch size. Acked-by: Michael S. Tsirkin Signed-off-by: Eugenio Pérez

[PULL V2 05/15] vhost: Add vhost_svq_valid_features to shadow vq

2022-03-09 Thread Jason Wang
From: Eugenio Pérez This allows SVQ to negotiate features with the guest and the device. For the device, SVQ is a driver. While this function bypasses all non-transport features, it needs to disable the features that SVQ does not support when forwarding buffers. This includes packed vq layout,

[PULL V2 01/15] virtio-net: fix map leaking on error during receive

2022-03-09 Thread Jason Wang
Commit bedd7e93d0196 ("virtio-net: fix use after unmap/free for sg") tries to fix the use after free of the sg by caching the virtqueue elements in an array and unmap them at once after receiving the packets, But it forgot to unmap the cached elements on error which will lead to leaking of mapping

[PULL V2 04/15] vhost: Add Shadow VirtQueue call forwarding capabilities

2022-03-09 Thread Jason Wang
From: Eugenio Pérez This will make qemu aware of the device used buffers, allowing it to write the guest memory with its contents if needed. Acked-by: Michael S. Tsirkin Signed-off-by: Eugenio Pérez Signed-off-by: Jason Wang --- hw/virtio/vhost-shadow-virtqueue.c | 38

[PULL V2 03/15] vhost: Add Shadow VirtQueue kick forwarding capabilities

2022-03-09 Thread Jason Wang
From: Eugenio Pérez At this mode no buffer forwarding will be performed in SVQ mode: Qemu will just forward the guest's kicks to the device. Host memory notifiers regions are left out for simplicity, and they will not be addressed in this series. Acked-by: Michael S. Tsirkin Signed-off-by:

[PULL V2 02/15] vhost: Add VhostShadowVirtqueue

2022-03-09 Thread Jason Wang
From: Eugenio Pérez Vhost shadow virtqueue (SVQ) is an intermediate jump for virtqueue notifications and buffers, allowing qemu to track them. While qemu is forwarding the buffers and virtqueue changes, it is able to commit the memory it's being dirtied, the same way regular qemu's VirtIO

[PULL V2 00/15] Net patches

2022-03-09 Thread Jason Wang
The following changes since commit d9ccf33f9479201e5add8db0af68ca9ca8da358b: Merge remote-tracking branch 'remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request' into staging (2022-03-09 20:01:17 +) are available in the git repository at: https://github.com/jasowang/qemu.git

Re: Lost patch

2022-03-09 Thread Patrick Venture
On Wed, Mar 9, 2022 at 4:16 PM Philippe Mathieu-Daudé < philippe.mathieu.da...@gmail.com> wrote: > On 10/3/22 00:12, Patrick Venture wrote: > > Corey and Peter; > > > > I was about to submit a fix to the at24c-eeprom device and noticed that > > my v2 patch appears to have been lost to time. Is

Re: Lost patch

2022-03-09 Thread Philippe Mathieu-Daudé
On 10/3/22 00:12, Patrick Venture wrote: Corey and Peter; I was about to submit a fix to the at24c-eeprom device and noticed that my v2 patch appears to have been lost to time.  Is there any way we can get this pulled into 7.0?

Re: [RFC v4 04/21] vfio-user: add region cache

2022-03-09 Thread Alex Williamson
On Tue, 11 Jan 2022 16:43:40 -0800 John Johnson wrote: > diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c > index 0cf69a8..223bd02 100644 > --- a/hw/vfio/pci-quirks.c > +++ b/hw/vfio/pci-quirks.c > @@ -1601,16 +1601,14 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice > *vdev, Error

Lost patch

2022-03-09 Thread Patrick Venture
Corey and Peter; I was about to submit a fix to the at24c-eeprom device and noticed that my v2 patch appears to have been lost to time. Is there any way we can get this pulled into 7.0? https://lists.gnu.org/archive/html/qemu-devel/2021-12/msg03485.html Thanks, Patrick

Re: [RFC v4 01/21] vfio-user: introduce vfio-user protocol specification

2022-03-09 Thread Alex Williamson
On Tue, 11 Jan 2022 16:43:37 -0800 John Johnson wrote: > +VFIO region info cap sparse mmap > + > + > ++--++--+ > +| Name | Offset | Size | > ++==++==+ > +| nr_areas | 0 | 4| > ++--++--+ > +|

Re: propagating vmgenid outward and upward

2022-03-09 Thread Jason A. Donenfeld
Hi Alex, On Wed, Mar 9, 2022 at 3:10 AM Alexander Graf wrote: > > The vmgenid driver basically works, though it is racy, because that ACPI > > notification can arrive after the system is already running again. This > > > I believe enough people already pointed out that this assumption is >

Re: [PULL 0/3] Linux user for 7.0 patches

2022-03-09 Thread Peter Maydell
On Tue, 8 Mar 2022 at 15:14, Laurent Vivier wrote: > > The following changes since commit f45cc81911adc7726e8a2801986b6998b91b816e: > > Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20220307' > into staging (2022-03-08 09:06:57 +) > > are available in the Git repository

QEMU, UEFI and Windows with Bitlocker encryption

2022-03-09 Thread Jostein Kjønigsen
Dear QEMU developers. I’m having some issues with one of my QEMU VMs. I’m not sure if the mailing list is the best place to get help, and if it’s a complete miss, feel free to direct me towards more appropriate venues. My case in short: I have a Windows 11 VM with BitLocker encryption which

Re: [RFC PATCH] tests/tcg: drop -cpu max from s390x sha512-mvx invocation

2022-03-09 Thread Richard Henderson
On 3/9/22 01:22, Alex Bennée wrote: With -cpu max we get a warning: qemu-s390x: warning: 'msa5-base' requires 'kimd-sha-512'. But dropping the -cpu max and it still runs fine. Signed-off-by: Alex Bennée Cc: Thomas Huth --- tests/tcg/s390x/Makefile.target | 2 -- 1 file changed, 2

Re: [PULL 00/15] Net patches

2022-03-09 Thread Peter Maydell
On Tue, 8 Mar 2022 at 13:35, Jason Wang wrote: > > The following changes since commit f45cc81911adc7726e8a2801986b6998b91b816e: > > Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20220307' > into staging (2022-03-08 09:06:57 +) > > are available in the git repository at: >

Re: [PULL 00/11] aspeed queue

2022-03-09 Thread Peter Maydell
On Tue, 8 Mar 2022 at 12:22, Cédric Le Goater wrote: > > The following changes since commit b49872aa8fc0f3f5a3036cc37aa2cb5c92866f33: > > Merge remote-tracking branch > 'remotes/hreitz-gitlab/tags/pull-block-2022-03-07' into staging (2022-03-07 > 17:14:09 +) > > are available in the Git

Re: How to backtrace an separate stack?

2022-03-09 Thread Tom Tromey
>> Yes, the infamous "previous frame inner to this frame" error message. I >> think this is primarily intended to detect stack trashing, but maybe it >> also serves to work around bad debuginfo or bugs in the unwinders. Florian> Is there a user-level command to disable the check manually? I

[PATCH] target/ppc: fix ISI fault cause for Radix MMU

2022-03-09 Thread Leandro Lupori
Fix Instruction Storage Interrupt (ISI) fault cause for Radix MMU, when caused by missing PAGE_EXEC permission, to be SRR1_NOEXEC_GUARD instead of DSISR_PROTFAULT. This matches POWER9 hardware behavior. Fixes: d5fee0bbe68 ("target/ppc: Implement ISA V3.00 radix page fault handler") Signed-off-by:

[PATCH 4/6] 9pfs: refactor 'name_idx' -> 'nvalid' in v9fs_walk()

2022-03-09 Thread Christian Schoenebeck
The local variable 'name_idx' is used in two loops in function v9fs_walk(). Let the first loop use its own variable 'nvalid' instead, which we will use in subsequent patches as the number of (requested) path components successfully retrieved/walked by background I/O thread. Signed-off-by:

[PATCH 5/6] 9pfs: fix 'Twalk' to only send error if no component walked

2022-03-09 Thread Christian Schoenebeck
Current implementation of 'Twalk' request handling always sends an 'Rerror' response if any error occured. The 9p2000 protocol spec sais though: " If the first element cannot be walked for any reason, Rerror is returned. Otherwise, the walk will return an Rwalk message containing nwqid qids

[PATCH 3/6] tests/9pfs: compare QIDs in fs_walk_none() test

2022-03-09 Thread Christian Schoenebeck
Extend previously added fs_walk_none() test by comparing the QID of the root fid with the QID of the cloned fid. They should be equal. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 70 1 file changed, 70 insertions(+) diff --git

[PATCH 2/6] tests/9pfs: Twalk with nwname=0

2022-03-09 Thread Christian Schoenebeck
Send Twalk request with nwname=0. In this case no QIDs should be returned by 9p server; this is equivalent to walking to dot. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[PATCH 6/6] tests/9pfs: guard recent 'Twalk' behaviour fix

2022-03-09 Thread Christian Schoenebeck
Previous 9p patch fixed 'Twalk' request handling, which was previously not behaving as specified by the 9p2000 protocol spec. This patch adds a new test case which guards the new 'Twalk' behaviour in question. More specifically: it sends a 'Twalk' request where the 1st path component is valid,

[PATCH 1/6] tests/9pfs: walk to non-existent dir

2022-03-09 Thread Christian Schoenebeck
Expect ENOENT Rlerror response when trying to walk to a non-existent directory. Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c

[PATCH 0/6] 9pfs: fix 'Twalk' protocol violation

2022-03-09 Thread Christian Schoenebeck
Currently the implementation of 'Twalk' does not behave exactly as specified by the 9p2000 protocol specification. Actual fix is patch 5; see the description of that patch for details of what this overall fix and series is about. Patch 4 is a preparatory (pure) refactoring change to make patch 5

Re: [RFC PATCH 1/2] spapr: Report correct GTSE support via ov5

2022-03-09 Thread Daniel Henrique Barboza
On 3/8/22 22:23, Fabiano Rosas wrote: QEMU reports MMU support to the guest via the ibm,architecture-vec-5 property of the /chosen node. Byte number 26 specifies Radix Table Expansions, currently only GTSE (Guest Translation Shootdown Enable). This feature determines whether the tlbie

Re: bad virsh save /dev/null performance (600 MiB/s max)

2022-03-09 Thread Dr. David Alan Gilbert
* Claudio Fontana (cfont...@suse.de) wrote: > On 3/9/22 7:39 PM, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >> On Wed, Mar 09, 2022 at 07:27:12PM +0100, Claudio Fontana wrote: > >>> > >>> One difference I could see looking at the qmp commands issued by

Re: bad virsh save /dev/null performance (600 MiB/s max)

2022-03-09 Thread Claudio Fontana
On 3/9/22 7:39 PM, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: >> On Wed, Mar 09, 2022 at 07:27:12PM +0100, Claudio Fontana wrote: >>> >>> One difference I could see looking at the qmp commands issued by libvirt in >>> the "virsh save" case, >>> is

Re: bad virsh save /dev/null performance (600 MiB/s max)

2022-03-09 Thread Daniel P . Berrangé
On Wed, Mar 09, 2022 at 06:37:42PM +, Daniel P. Berrangé wrote: > On Wed, Mar 09, 2022 at 07:27:12PM +0100, Claudio Fontana wrote: > > > > One difference I could see looking at the qmp commands issued by libvirt in > > the "virsh save" case, > > is "detach:true" in the migration command

Re: [PULL 00/23] QEMU changes for 7.0 soft freeze

2022-03-09 Thread Peter Maydell
On Wed, 9 Mar 2022 at 09:47, Thomas Huth wrote: > Since the fix is not available in any meson release yet and we're in QEMU > softfreeze now, I'm now also not quite sure anymore whether we really should > go forward with the TAP approach right now... maybe it's indeed better to > revert the

Re: bad virsh save /dev/null performance (600 MiB/s max)

2022-03-09 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Mar 09, 2022 at 07:27:12PM +0100, Claudio Fontana wrote: > > > > One difference I could see looking at the qmp commands issued by libvirt in > > the "virsh save" case, > > is "detach:true" in the migration command (which seems to have

Re: bad virsh save /dev/null performance (600 MiB/s max)

2022-03-09 Thread Daniel P . Berrangé
On Wed, Mar 09, 2022 at 07:27:12PM +0100, Claudio Fontana wrote: > > One difference I could see looking at the qmp commands issued by libvirt in > the "virsh save" case, > is "detach:true" in the migration command (which seems to have no effect in > qemu), That is a bug in libvirt - it should

Re: bad virsh save /dev/null performance (600 MiB/s max)

2022-03-09 Thread Claudio Fontana
On 3/9/22 3:22 PM, Claudio Fontana wrote: > On 3/9/22 12:51 PM, Daniel P. Berrangé wrote: >> On Wed, Mar 09, 2022 at 11:43:48AM +, Dr. David Alan Gilbert wrote: >>> * Claudio Fontana (cfont...@suse.de) wrote: On 3/7/22 1:28 PM, Dr. David Alan Gilbert wrote: > * Claudio Fontana

Re: [RFC PATCH] docs/devel: start documenting writing VirtIO devices

2022-03-09 Thread Cornelia Huck
On Wed, Mar 09 2022, Alex Bennée wrote: > While writing my own VirtIO devices I've gotten confused with how > things are structured and what sort of shared infrastructure there is. > If we can document how everything is supposed to work we can then > maybe start cleaning up inconsistencies in

Re: [PULL 0/1] qemu-openbios queue 20220308

2022-03-09 Thread Peter Maydell
On Tue, 8 Mar 2022 at 08:16, Mark Cave-Ayland wrote: > > The following changes since commit b49872aa8fc0f3f5a3036cc37aa2cb5c92866f33: > > Merge remote-tracking branch > 'remotes/hreitz-gitlab/tags/pull-block-2022-03-07' into staging (2022-03-07 > 17:14:09 +) > > are available in the Git

Re: [PATCH v4 24/33] target/nios2: Introduce shadow register sets

2022-03-09 Thread Richard Henderson
On 3/9/22 04:02, Amir Gonnen wrote: How does "cpu_crs_R" work? ...> Otherwise, each gpr access would be indirect. I'm probably missing something here. They are indirect, but with some optimization. +TCGv_ptr crs = tcg_global_mem_new_ptr(cpu_env, +

Re: [PATCH 2/4] block/block-copy: block_copy(): add timeout_ns parameter

2022-03-09 Thread Vladimir Sementsov-Ogievskiy
02.03.2022 19:24, Vladimir Sementsov-Ogievskiy wrote: Add possibility to limit block_copy() call in time. To be used in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-copy.h | 2 +- block/block-copy.c | 28 2 files

Re: QEMU device refcounting when device creates a container MR

2022-03-09 Thread Peter Maydell
On Wed, 9 Mar 2022 at 16:21, Paolo Bonzini wrote: > > On 3/9/22 11:33, Peter Maydell wrote: > > Hi; does anybody know how device reference counting is supposed > > to work when the device creates a "container" MemoryRegion which > > it then puts some of its own subregions in to? > > > > As far as

[RFC PATCH 0/2] Add dirty page rate limit qtest

2022-03-09 Thread huangy81
From: Hyman Huang(黄勇) This patchset is dirtylimit qtest and plan to be a supplement for patch series "support dirty restraint on vCPU". Dirtylimit qtest use the existing bootsect in tests/migration/i386 to start test vm. The x86.bootsect repeatedly increments the first byte of each page in a

Re: [PULL 00/22] q800-updates-for-7.0 queue 20220309

2022-03-09 Thread Laurent Vivier
/mcayland/qemu.git tags/q800-updates-for-7.0-20220309 for you to fetch changes up to a7a2208862bee2bc4fe55adfd947dc4a15ad0216: esp: recreate ESPState current_req after migration (2022-03-09 09:29:10 +) q800-updates-for-7.0

Re: [PATCH] tests/qemu-iotests: Use GNU sed in two more spots where it is necessary

2022-03-09 Thread Philippe Mathieu-Daudé
On 9/3/22 11:16, Thomas Huth wrote: These two spots have been missed in commit 9086c7639822 ("Rework the checks and spots using GNU sed") - they need GNU sed, too, since they are using the "+" address form. Signed-off-by: Thomas Huth --- tests/qemu-iotests/common.filter | 4 ++-- 1 file

Re: QEMU device refcounting when device creates a container MR

2022-03-09 Thread Peter Maydell
On Wed, 9 Mar 2022 at 16:53, Peter Maydell wrote: > > On Wed, 9 Mar 2022 at 16:21, Paolo Bonzini wrote: > > > > On 3/9/22 11:33, Peter Maydell wrote: > > > Hi; does anybody know how device reference counting is supposed > > > to work when the device creates a "container" MemoryRegion which > > >

[RFC PATCH] docs/devel: start documenting writing VirtIO devices

2022-03-09 Thread Alex Bennée
While writing my own VirtIO devices I've gotten confused with how things are structured and what sort of shared infrastructure there is. If we can document how everything is supposed to work we can then maybe start cleaning up inconsistencies in the code. Based-on:

Re: QEMU device refcounting when device creates a container MR

2022-03-09 Thread Paolo Bonzini
On 3/9/22 11:33, Peter Maydell wrote: Hi; does anybody know how device reference counting is supposed to work when the device creates a "container" MemoryRegion which it then puts some of its own subregions in to? As far as I can see when you do memory_region_add_subregion it increases the

Re: [PULL 00/23] QEMU changes for 7.0 soft freeze

2022-03-09 Thread Paolo Bonzini
On 3/9/22 10:46, Thomas Huth wrote: That one also drops the progress report of non-failed tests, so I'm not sure it's an improvement. That only works here anyway if I don't run "make check" with the "-jX" option ... which I hardly do, since it then takes forever to finish the testing. So

[RFC PATCH 1/2] migration-test: Export migration-test util funtions

2022-03-09 Thread huangy81
From: Hyman Huang(黄勇) Dirtylimit qtest can reuse the mechanisms that have been implemented by migration-test to start a vm, so export the relevant util functions. Signed-off-by: Hyman Huang(黄勇) --- tests/qtest/migration-helpers.c | 95 +

[RFC PATCH 2/2] tests: Add dirty page rate limit test

2022-03-09 Thread huangy81
From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring, create a standalone file to implement the test case. Signed-off-by: Hyman Huang(黄勇) --- tests/qtest/dirtylimit-test.c | 288 ++ tests/qtest/meson.build | 2 + 2

Re: [PULL 00/15] NBD patches for 7.0-rc0

2022-03-09 Thread Peter Maydell
On Tue, 8 Mar 2022 at 01:49, Eric Blake wrote: > > The following changes since commit b49872aa8fc0f3f5a3036cc37aa2cb5c92866f33: > > Merge remote-tracking branch > 'remotes/hreitz-gitlab/tags/pull-block-2022-03-07' into staging (2022-03-07 > 17:14:09 +) > > are available in the Git

Re: [PATCH 2/3] block/copy-before-write: add on-cbw-error open parameter

2022-03-09 Thread Vladimir Sementsov-Ogievskiy
01.03.2022 23:59, Vladimir Sementsov-Ogievskiy wrote: @@ -273,9 +311,9 @@ cbw_co_snapshot_block_status(BlockDriverState *bs, assert(ret & BDRV_BLOCK_ALLOCATED); } -cbw_snapshot_read_unlock(bs, req); +ret2 = cbw_snapshot_read_unlock(bs, req); -return ret; +

Re: [PATCH v2 0/6] Support exporting BDSs via VDUSE

2022-03-09 Thread Stefan Hajnoczi
On Tue, Feb 15, 2022 at 06:59:37PM +0800, Xie Yongji wrote: > Hi all, > > Last few months ago, VDUSE (vDPA Device in Userspace) [1] has > been merged into Linux kernel as a framework that make it > possible to emulate a vDPA device in userspace. This series > aimed at implementing a VDUSE block

Re: [PATCH v2] tests: add (riscv virt) machine mapping to testenv

2022-03-09 Thread Hanna Reitz
On 08.03.22 05:33, laokz wrote: Some qemu-iotests(040 etc) use PCI disk to do test. Without the mapping, RISC-V flavor use spike as default machine which has no PCI bus, causing test failure. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894 Signed-off-by: Kai Zhang --- Thanks for

Re: bad qemu savevm to /dev/null performance (600 MiB/s max) (Was: Re: starting to look at qemu savevm performance, a first regression detected)

2022-03-09 Thread Claudio Fontana
On 3/9/22 12:51 PM, Daniel P. Berrangé wrote: > On Wed, Mar 09, 2022 at 11:43:48AM +, Dr. David Alan Gilbert wrote: >> * Claudio Fontana (cfont...@suse.de) wrote: >>> On 3/7/22 1:28 PM, Dr. David Alan Gilbert wrote: * Claudio Fontana (cfont...@suse.de) wrote: > On 3/7/22 1:20 PM,

Re: [PATCH V7 08/29] memory: flat section iterator

2022-03-09 Thread Marc-André Lureau
Hi On Thu, Dec 23, 2021 at 12:17 AM Steve Sistare wrote: > Add an iterator over the sections of a flattened address space. > > Signed-off-by: Steve Sistare > --- > include/exec/memory.h | 31 +++ > softmmu/memory.c | 20 > 2 files changed,

Re: [PATCH V7 12/29] vl: helper to request re-exec

2022-03-09 Thread Marc-André Lureau
On Wed, Dec 22, 2021 at 11:52 PM Steve Sistare wrote: > Add a qemu_system_exec_request() hook that causes the main loop to exit and > re-exec qemu using the specified arguments. > > Signed-off-by: Steve Sistare > --- > include/sysemu/runstate.h | 1 + > softmmu/runstate.c| 21

Re: [PATCH V7 11/29] qapi: list utility functions

2022-03-09 Thread Marc-André Lureau
Hi On Wed, Dec 22, 2021 at 11:42 PM Steve Sistare wrote: > Generalize strList_from_comma_list() to take any delimiter character, > rename > as strList_from_string(), and move it to qapi/util.c. Also add > strv_from_strList() and QAPI_LIST_LENGTH(). > Looks like you could easily split, and add

Re: [PATCH 1/1] target/riscv: misa to ISA string conversion fix

2022-03-09 Thread Frank Chang
Tsukasa OI 於 2022年2月12日 週六 下午10:55寫道: > Some bits in RISC-V `misa' CSR should not be reflected in the ISA > string. For instance, `S' and `U' (represents existence of supervisor > and user mode, respectively) in `misa' CSR must not be copied since > neither `S' nor `U' are valid single-letter

RE: [PATCH v4 24/33] target/nios2: Introduce shadow register sets

2022-03-09 Thread Amir Gonnen
Hi Richard, How does "cpu_crs_R" work? In your version you hold a pointer to the current register set instead of copying registers back and forth like I did, which makes sense. But how does TCG know which set to refer to when it generates code? It looks like it's always accessing the same

Re: [PATCH] tests/qemu-iotests: Use GNU sed in two more spots where it is necessary

2022-03-09 Thread Eric Blake
On Wed, Mar 09, 2022 at 11:16:26AM +0100, Thomas Huth wrote: > These two spots have been missed in commit 9086c7639822 ("Rework the > checks and spots using GNU sed") - they need GNU sed, too, since they > are using the "+" address form. > > Signed-off-by: Thomas Huth > --- >

[RFC PATCH] docs/devel: try and impose some organisation

2022-03-09 Thread Alex Bennée
We have a growing set of developer docs but the index is currently in order of when stuff was added. Try and make things a bit easier to find my adding sub indexes and organising into themes. Signed-off-by: Alex Bennée --- docs/devel/index-api.rst | 15 +++

Re: [RFC PATCH 2/5] introduce BDRV_POLL_WHILE_UNLOCKED

2022-03-09 Thread Eric Blake
On Tue, Mar 01, 2022 at 09:21:10AM -0500, Emanuele Giuseppe Esposito wrote: > Same as BDRV_POLL_WHILE, but uses AIO_WAIT_WHILE_UNLOCKED. > See doc comment for more info. This sentence implies there is a doc comment... > > Signed-off-by: Emanuele Giuseppe Esposito > --- > include/block/block.h

Re: [PATCH v4] target/riscv: Add isa extenstion strings to the device tree

2022-03-09 Thread Frank Chang
Atish Patra 於 2022年3月9日 週三 上午8:53寫道: > The Linux kernel parses the ISA extensions from "riscv,isa" DT > property. It used to parse only the single letter base extensions > until now. A generic ISA extension parsing framework was proposed[1] > recently that can parse multi-letter ISA extensions

Re: [PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run

2022-03-09 Thread Philippe Mathieu-Daudé
On 9/3/22 14:09, Peter Maydell wrote: On Wed, 9 Mar 2022 at 13:02, Daniel P. Berrangé wrote: On Wed, Mar 09, 2022 at 01:50:34PM +0100, Philippe Mathieu-Daudé wrote: Not sure which job to choose yet. Per the first google hits we still want to cover Catalina first:

Re: [PATCH 05/11] edk2: add microvm build

2022-03-09 Thread Ani Sinha
On Wed, Mar 9, 2022 at 5:43 PM Gerd Hoffmann wrote: > > On Wed, Mar 09, 2022 at 11:55:26AM +, Alex Bennée wrote: > > > > Gerd Hoffmann writes: > > > > > Signed-off-by: Gerd Hoffmann > > > > Out of interest how do you usually trigger these builds? > > make -C roms efi Ah good to know. I

Re: [RFC PATCH 0/5] Removal of AioContext lock, bs->parents and ->children: proof of concept

2022-03-09 Thread Emanuele Giuseppe Esposito
Am 02/03/2022 um 12:07 schrieb Vladimir Sementsov-Ogievskiy: > 01.03.2022 17:21, Emanuele Giuseppe Esposito wrote: >> This serie tries to provide a proof of concept and a clear explanation >> on why we need to use drains (and more precisely subtree_drains) >> to replace the aiocontext lock,

Re: [RFC PATCH 0/5] Removal of AioContext lock, bs->parents and ->children: proof of concept

2022-03-09 Thread Emanuele Giuseppe Esposito
Am 02/03/2022 um 10:47 schrieb Stefan Hajnoczi: > On Tue, Mar 01, 2022 at 09:21:08AM -0500, Emanuele Giuseppe Esposito wrote: >> This serie tries to provide a proof of concept and a clear explanation >> on why we need to use drains (and more precisely subtree_drains) >> to replace the

Re: [PATCH v2] block/nbd.c: Fixed IO request coroutine not being wakeup when kill NBD server

2022-03-09 Thread Vladimir Sementsov-Ogievskiy
09.03.2022 10:48, Rao Lei wrote: During the IO stress test, the IO request coroutine has a probability that is can't be awakened when the NBD server is killed. The GDB stack is as follows: (gdb) bt 0 0x7f2ff990cbf6 in __ppoll (fds=0x55575de85000, nfds=1, timeout=, sigmask=0x0) at

Re: bad qemu savevm to /dev/null performance (600 MiB/s max) (Was: Re: starting to look at qemu savevm performance, a first regression detected)

2022-03-09 Thread Claudio Fontana
On 3/9/22 12:43 PM, Dr. David Alan Gilbert wrote: > * Claudio Fontana (cfont...@suse.de) wrote: >> On 3/7/22 1:28 PM, Dr. David Alan Gilbert wrote: >>> * Claudio Fontana (cfont...@suse.de) wrote: On 3/7/22 1:20 PM, Daniel P. Berrangé wrote: > On Mon, Mar 07, 2022 at 01:09:55PM +0100,

Re: [PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run

2022-03-09 Thread Peter Maydell
On Wed, 9 Mar 2022 at 13:02, Daniel P. Berrangé wrote: > > On Wed, Mar 09, 2022 at 01:50:34PM +0100, Philippe Mathieu-Daudé wrote: > > Not sure which job to choose yet. Per the first google hits we > > still want to cover Catalina first: > >

Re: [PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run

2022-03-09 Thread Daniel P . Berrangé
On Wed, Mar 09, 2022 at 01:50:34PM +0100, Philippe Mathieu-Daudé wrote: > On 9/3/22 13:33, Daniel P. Berrangé wrote: > > On Wed, Mar 09, 2022 at 12:58:42PM +0100, Thomas Huth wrote: > > > > Basically fine for me, but can we really run additional cirrus-ci jobs by > > > default? IIRC the parallel

Re: [PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run

2022-03-09 Thread Daniel P . Berrangé
On Wed, Mar 09, 2022 at 01:52:15PM +0100, Thomas Huth wrote: > On 09/03/2022 13.50, Philippe Mathieu-Daudé wrote: > > > Would it be beneficial to have a 1 per OS job during PR, and > > other jobs run nightly (once a day, not per PR)? > > Is there a way to trigger nightly runs in gitlab? Yes, in

Re: [PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run

2022-03-09 Thread Thomas Huth
On 09/03/2022 13.50, Philippe Mathieu-Daudé wrote: Would it be beneficial to have a 1 per OS job during PR, and other jobs run nightly (once a day, not per PR)? Is there a way to trigger nightly runs in gitlab? Thomas

Re: [PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run

2022-03-09 Thread Philippe Mathieu-Daudé
On 9/3/22 13:33, Daniel P. Berrangé wrote: On Wed, Mar 09, 2022 at 12:58:42PM +0100, Thomas Huth wrote: Basically fine for me, but can we really run additional cirrus-ci jobs by default? IIRC the parallel execution of those were quite limited for the free tier, so did you look close that we

Re: [PATCH v5 13/15] hw/nvme: Add support for the Virtualization Management command

2022-03-09 Thread Łukasz Gieryk
On Tue, Mar 01, 2022 at 02:07:08PM +0100, Klaus Jensen wrote: > On Feb 17 18:45, Lukasz Maniak wrote: > > From: Łukasz Gieryk > > > > With the new command one can: > > - assign flexible resources (queues, interrupts) to primary and > >secondary controllers, > > - toggle the online/offline

Re: [PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run

2022-03-09 Thread Daniel P . Berrangé
On Wed, Mar 09, 2022 at 12:58:42PM +0100, Thomas Huth wrote: > On 09/03/2022 11.24, Philippe Mathieu-Daudé wrote: > > Hi Alex, Thomas, Daniel, > > > > Could you ack this patch? > > Basically fine for me, but can we really run additional cirrus-ci jobs by > default? IIRC the parallel execution of

Re: [PATCH 05/11] edk2: add microvm build

2022-03-09 Thread Philippe Mathieu-Daudé
On 9/3/22 13:12, Gerd Hoffmann wrote: On Wed, Mar 09, 2022 at 11:55:26AM +, Alex Bennée wrote: Gerd Hoffmann writes: Signed-off-by: Gerd Hoffmann Out of interest how do you usually trigger these builds? make -C roms efi (try "make -C roms help" for all firmware build targets).

Re: [PATCH 10/11] edk2/docker: use ubuntu 18.04

2022-03-09 Thread Alex Bennée
Gerd Hoffmann writes: > Upstream CI uses ubuntu 18.04 too, so pick > that version (instead of something newer). > > Signed-off-by: Gerd Hoffmann Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 05/11] edk2: add microvm build

2022-03-09 Thread Gerd Hoffmann
On Wed, Mar 09, 2022 at 11:55:26AM +, Alex Bennée wrote: > > Gerd Hoffmann writes: > > > Signed-off-by: Gerd Hoffmann > > Out of interest how do you usually trigger these builds? make -C roms efi (try "make -C roms help" for all firmware build targets). HTH, Gerd

Re: [PATCH 09/11] edk2/docker: install python3

2022-03-09 Thread Alex Bennée
Gerd Hoffmann writes: > python2 is not supported any more, > so go install python3 instead. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run

2022-03-09 Thread Thomas Huth
On 09/03/2022 11.24, Philippe Mathieu-Daudé wrote: Hi Alex, Thomas, Daniel, Could you ack this patch? Basically fine for me, but can we really run additional cirrus-ci jobs by default? IIRC the parallel execution of those were quite limited for the free tier, so did you look close that we

Re: [PATCH 05/11] edk2: add microvm build

2022-03-09 Thread Alex Bennée
Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann Out of interest how do you usually trigger these builds? ➜ make pc-bios/edk2-x86_64-microvm.fd GIT ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc capstone slirp make: *** No rule to make

Re: bad qemu savevm to /dev/null performance (600 MiB/s max) (Was: Re: starting to look at qemu savevm performance, a first regression detected)

2022-03-09 Thread Daniel P . Berrangé
On Wed, Mar 09, 2022 at 11:43:48AM +, Dr. David Alan Gilbert wrote: > * Claudio Fontana (cfont...@suse.de) wrote: > > On 3/7/22 1:28 PM, Dr. David Alan Gilbert wrote: > > > * Claudio Fontana (cfont...@suse.de) wrote: > > >> On 3/7/22 1:20 PM, Daniel P. Berrangé wrote: > > >>> On Mon, Mar 07,

Re: [PATCH 03/11] edk2: switch to release builds

2022-03-09 Thread Alex Bennée
Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann Reviewed-by: Alex Bennée -- Alex Bennée

  1   2   >