Re: [PATCH qemu v3] ppc/spapr: Implement H_WATCHDOG

2022-06-21 Thread Cédric Le Goater
On 6/22/22 07:10, Alexey Kardashevskiy wrote: The new PAPR 2.12 defines a watchdog facility managed via the new H_WATCHDOG hypercall. This adds H_WATCHDOG support which a proposed driver for pseries uses: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=303120 This was tested by

[PATCH qemu v2] spapr/ddw: Reset DMA when the last non-default window is removed

2022-06-21 Thread Alexey Kardashevskiy
PAPR+/LoPAPR says: === The platform must restore the default DMA window for the PE on a call to the ibm,remove-pe-dma-window RTAS call when all of the following are true: a. The call removes the last DMA window remaining for the PE. b. The DMA window being removed is not the default window ===

Re: [PATCH 4/4] hw/riscv: use qemu_fdt_setprop_strings() in sifive_u.c

2022-06-21 Thread Alistair Francis
On Tue, Jun 21, 2022 at 8:54 PM Ben Dooks wrote: > > On Mon, Jun 20, 2022 at 04:47:44PM +1000, Alistair Francis wrote: > > On Sun, Jun 19, 2022 at 6:14 AM Ben Dooks wrote: > > > > > > Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify > > > the code. > > > > > > Signed-off-by: Ben Dooks

[PATCH qemu v3] ppc/spapr: Implement H_WATCHDOG

2022-06-21 Thread Alexey Kardashevskiy
The new PAPR 2.12 defines a watchdog facility managed via the new H_WATCHDOG hypercall. This adds H_WATCHDOG support which a proposed driver for pseries uses: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=303120 This was tested by running QEMU with a debug kernel and command

[PATCH qemu v2] ppc: Define SETFIELD for the ppc target

2022-06-21 Thread Alexey Kardashevskiy
It keeps repeating, move it to the header. This uses __builtin_ffsl() to allow using the macros in #define. This is not using the QEMU's FIELD macros as this would require changing all such macros found in skiboot (the PPC PowerNV firmware). Signed-off-by: Alexey Kardashevskiy --- Changes: v2:

Re: [RESOLVED] aarch64 edk2 + linux kernel crash with gicv4

2022-06-21 Thread Alex Bennée
Richard Henderson writes: > Hi Luis, > > Cc'ing qemu-devel just in case someone else runs into this problem: > > The symptom is an early-ish crash booting the linux kernel -- without > earlycon there is no output at all. Reproducing it requires both > -bios QEMU_EFI.fd and -kernel Image.gz.

Re: [PATCH qemu] spapr/ddw: Reset DMA when the last non-default window is removed

2022-06-21 Thread Alexey Kardashevskiy
On 6/21/22 23:54, Daniel Henrique Barboza wrote: On 6/20/22 05:01, Alexey Kardashevskiy wrote: PAPR+/LoPAPR says: === The platform must restore the default DMA window for the PE on a call to the ibm,remove-pe-dma-window RTAS call when all of the following are true:   a. The call removes

Re: [PULL 00/25] Migration 20220621 patches

2022-06-21 Thread Richard Henderson
at: https://gitlab.com/juan.quintela/qemu.git tags/migration-20220621-pull-request for you to fetch changes up to 720eceaa316f2a75a7930085bb305850831a065f: migration: remove the QEMUFileOps abstraction (2022-06-21 18:06:55 +0200

[PATCH] softmmu/physmem: Fix input parameters for flatview_access_allowed()

2022-06-21 Thread Zhenzhong Duan
The comment of flatview_access_allowed() suggests to pass address within that memory region, this isn't ture in some call sites. This makes qemu log in flatview_access_allowed() confusing and potential risk if the input parameter will be checked in the future. Fixes: 3ab6fdc91b72

Re: [PATCH v3 23/51] target/arm: Implement SME RDSVL, ADDSVL, ADDSPL

2022-06-21 Thread Richard Henderson
On 6/21/22 10:23, Peter Maydell wrote: +static bool trans_RDSVL(DisasContext *s, arg_RDSVL *a) +{ +if (!dc_isar_feature(aa64_sme, s)) { +return false; +} +if (sme_enabled_check(s)) { +TCGv_i64 reg = cpu_reg(s, a->rd); +tcg_gen_movi_i64(reg, a->imm * s->svl); +

[PATCH v4] docs: mention devices with VBE on Root Complex

2022-06-21 Thread Kevin Locke
Mention devices which support VESA BIOS Extensions (VBE) specifically in the list item of the Root Bus section discussing devices placed on the Root Complex. VESA BIOS Extensions (VBE) present a particular challenge not currently noted in the recommendations: ioport access to VBE registers is

[PULL 25/25] migration: remove the QEMUFileOps abstraction

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé Now that all QEMUFile callbacks are removed, the entire concept can be deleted. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/qemu-file-channel.h | 32

[PULL 20/25] migration: remove the QEMUFileOps 'set_blocking' callback

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé This directly implements the set_blocking logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/qemu-file.h | 5 -

[PULL 24/25] migration: remove the QEMUFileOps 'get_return_path' callback

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé This directly implements the get_return_path logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/qemu-file.h | 6 --

[PULL 17/25] migration: introduce new constructors for QEMUFile

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé Prepare for the elimination of QEMUFileOps by introducing a pair of new constructors. This lets us distinguish between an input and output file object explicitly rather than via the existance of specific callbacks. Reviewed-by: Dr. David Alan Gilbert Signed-off-by:

[PULL 22/25] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé This directly implements the get_buffer logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/qemu-file.h | 9 -

[PULL 23/25] migration: remove the QEMUFileOps 'writev_buffer' callback

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé This directly implements the writev_buffer logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/qemu-file.h | 9

[PULL 19/25] migration: remove the QEMUFileOps 'shut_down' callback

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé This directly implements the shutdown logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/qemu-file.h | 10 --

[PULL 21/25] migration: remove the QEMUFileOps 'close' callback

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé This directly implements the close logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/qemu-file.h | 10 --

[PULL 18/25] migration: remove unused QEMUFileGetFD typedef / qemu_get_fd method

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/qemu-file.h | 5 - 1 file changed, 5 deletions(-) diff --git a/migration/qemu-file.h b/migration/qemu-file.h index

[PULL 11/25] migration: rename qemu_update_position to qemu_file_credit_transfer

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé The qemu_update_position method name gives the misleading impression that it is changing the current file offset. Most of the files are just streams, however, so there's no concept of a file offset in the general case. What this method is actually used for is to report

[PULL 16/25] migration: hardcode assumption that QEMUFile is backed with QIOChannel

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé The only callers of qemu_fopen_ops pass 'true' for the 'has_ioc' parameter, so hardcode this assumption in QEMUFile, by passing in the QIOChannel object as a non-opaque parameter. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan

[PULL 15/25] migration: stop passing 'opaque' parameter to QEMUFile hooks

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé The only user of the hooks is RDMA which provides a QIOChannel backed impl of QEMUFile. It can thus use the qemu_file_get_ioc() method. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela ---

[PULL 13/25] migration: introduce a QIOChannel impl for BlockDriverState VMState

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé Introduce a QIOChannelBlock class that exposes the BlockDriverState VMState region for I/O. This is kept in the migration/ directory rather than io/, to avoid a mutual dependancy between block/ <-> io/ directories. Also the VMState should only be used by the migration

[PULL 08/25] migration: rename rate limiting fields in QEMUFile

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé This renames the following QEMUFile fields * bytes_xfer -> rate_limit_used * xfer_limit -> rate_limit_max The intent is to make it clear that 'bytes_xfer' is specifically related to rate limiting of data and applies to data queued, which need not have been

[PULL 10/25] migration: rename qemu_ftell to qemu_file_total_transferred

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé The name 'ftell' gives the misleading impression that the QEMUFile objects are seekable. This is not the case, as in general we just have an opaque stream. The users of this method are only interested in the total bytes processed. This switches to a new name that

[PULL 14/25] migration: convert savevm to use QIOChannelBlock for VMState

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé With this change, all QEMUFile usage is backed by QIOChannel at last. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/savevm.c | 42

[PULL 06/25] migration: switch to use QIOChannelNull for dummy channel

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé This removes one further custom impl of QEMUFile, in favour of a QIOChannel based impl. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/ram.c | 7 --- 1 file changed, 4

[PULL 05/25] io: add a QIOChannelNull equivalent to /dev/null

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé This is for code which needs a portable equivalent to a QIOChannelFile connected to /dev/null. Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- include/io/channel-null.h | 55 +++ io/channel-null.c

[PULL 09/25] migration: rename 'pos' field in QEMUFile to 'bytes_processed'

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé The field name 'pos' gives the misleading impression that the QEMUFile objects are seekable. This is not the case, as in general we just have an opaque stream. The users of this method are only interested in the total bytes processed. This switches to a new name that

[PULL 07/25] migration: remove unreachble RDMA code in save_hook impl

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé The QEMUFile 'save_hook' callback has a 'size_t size' parameter. The RDMA impl of this has logic that takes different actions depending on whether the value is zero or non-zero. It has commented out logic that would have taken further actions if the value was negative.

[PULL 12/25] migration: rename qemu_file_update_transfer to qemu_file_acct_rate_limit

2022-06-21 Thread Juan Quintela
From: Daniel P. Berrangé The qemu_file_update_transfer name doesn't give a clear guide on what its purpose is, and how it differs from the qemu_file_credit_transfer method. The latter is specifically for accumulating for total migration traffic, while the former is specifically for accounting in

[PULL 03/25] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-21 Thread Juan Quintela
From: Leonardo Bras Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial part of the flushing mechanism got missing: incrementing zero_copy_queued. Without that, the flushing interface becomes a no-op, and there is no guarantee the buffer is really sent. This can go as bad

[PULL 02/25] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability

2022-06-21 Thread Juan Quintela
From: Leonardo Bras During implementation of MSG_ZEROCOPY feature, a lot of #ifdefs were introduced, particularly at qio_channel_socket_writev(). Rewrite some of those changes so it's easier to read. Also, introduce an assert to help detect incorrect zero-copy usage is when it's disabled on

[PULL 04/25] migration: Change zero_copy_send from migration parameter to migration capability

2022-06-21 Thread Juan Quintela
From: Leonardo Bras When originally implemented, zero_copy_send was designed as a Migration paramenter. But taking into account how is that supposed to work, and how the difference between a capability and a parameter, it only makes sense that zero-copy-send would work better as a capability.

[PULL 00/25] Migration 20220621 patches

2022-06-21 Thread Juan Quintela
/qemu.git tags/migration-20220621-pull-request for you to fetch changes up to 720eceaa316f2a75a7930085bb305850831a065f: migration: remove the QEMUFileOps abstraction (2022-06-21 18:06:55 +0200) Migration Pull request Hi

[PULL 01/25] migration: Remove RDMA_UNREGISTRATION_EXAMPLE

2022-06-21 Thread Juan Quintela
Nobody has ever showed up to unregister individual pages, and another set of patches written by Daniel P. Berrangé just remove qemu_rdma_signal_unregister() function needed here. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 41

Re: [PATCH v7 02/14] migration: Postcopy preemption preparation on channel creation

2022-06-21 Thread Juan Quintela
Peter Xu wrote: > Create a new socket for postcopy to be prepared to send postcopy requested > pages via this specific channel, so as to not get blocked by precopy pages. > > A new thread is also created on dest qemu to receive data from this new > channel > based on the ram_load_postcopy()

Re: [PULL 0/9] tcg patch queue for 2022-06-21

2022-06-21 Thread Richard Henderson
repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20220621 for you to fetch changes up to c79a8e840c435bc26a251e34b043318e8b2081db: util/cacheflush: Optimize flushing when ppc host has coherent icache (2022-06-21 09:28:41 -0700

[RESOLVED] aarch64 edk2 + linux kernel crash with gicv4

2022-06-21 Thread Richard Henderson
Hi Luis, Cc'ing qemu-devel just in case someone else runs into this problem: The symptom is an early-ish crash booting the linux kernel -- without earlycon there is no output at all. Reproducing it requires both -bios QEMU_EFI.fd and -kernel Image.gz. Using only one of the two options works.

Re: AIX 7.2 guest, Windows 10 host, networking, qemu 6.0.50.

2022-06-21 Thread Daniel Henrique Barboza
Hi Paul, I'm CC'ing the overall QEMU mailing list as well to increase the chance of finding someone that runs QEMU on Windows. On 6/21/22 13:00, Paul Dembry wrote: I have AIX 7.2 installed and running fine however I cannot get any access to it via my LAN. I have tried multiple variations of

Re: [PATCH 3/3] target/ppc: Check page dir/table base alignment

2022-06-21 Thread Fabiano Rosas
Leandro Lupori writes: > Check if each page dir/table base address is properly aligned and > log a guest error if not, as real hardware behave incorrectly in > this case. > > These checks are only performed when DEBUG_MMU is defined, to avoid > hurting the performance. > > Signed-off-by: Leandro

Re: [PATCH 2/3] target/ppc: Improve Radix xlate level validation

2022-06-21 Thread Fabiano Rosas
Leandro Lupori writes: > Check if the number and size of Radix levels are valid on > POWER9/POWER10 CPUs, according to the supported Radix Tree > Configurations described in their User Manuals. > > Signed-off-by: Leandro Lupori > --- > target/ppc/mmu-radix64.c | 36

Re: [PATCH v7 01/14] migration: Add postcopy-preempt capability

2022-06-21 Thread Juan Quintela
Peter Xu wrote: > Firstly, postcopy already preempts precopy due to the fact that we do > unqueue_page() first before looking into dirty bits. > > However that's not enough, e.g., when there're host huge page enabled, when > sending a precopy huge page, a postcopy request needs to wait until the

[PULL 8/9] util/cacheflush: Merge aarch64 ctr_el0 usage

2022-06-21 Thread Richard Henderson
Merge init_ctr_el0 into arch_cache_info. In flush_idcache_range, use the pre-computed line sizes from the global variables. Use CONFIG_DARWIN in preference to __APPLE__. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id:

[PULL 1/9] tcg/ppc: implement rem[u]_i{32,64} with mod[su][wd]

2022-06-21 Thread Richard Henderson
From: Matheus Kowalczuk Ferst Power ISA v3.0 introduced mod[su][wd] insns that can be used to implement rem[u]_i{32,64}. Signed-off-by: Matheus Ferst Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.h | 4 ++-- tcg/ppc/tcg-target.c.inc | 22 ++ 2 files

[PULL 9/9] util/cacheflush: Optimize flushing when ppc host has coherent icache

2022-06-21 Thread Richard Henderson
From: Nicholas Piggin On linux, the AT_HWCAP bit PPC_FEATURE_ICACHE_SNOOP indicates that we can use a simplified 3 instruction flush sequence. Signed-off-by: Nicholas Piggin Message-Id: <20220519141131.29839-1-npig...@gmail.com> [rth: update after merging cacheflush.c and cacheinfo.c]

[PULL 4/9] accel/tcg: Reorganize tcg_accel_ops_init()

2022-06-21 Thread Richard Henderson
From: Philippe Mathieu-Daudé Reorg TCG AccelOpsClass initialization to emphasis icount mode share more code with single-threaded TCG. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20220323171751.78612-7-philippe.mathieu.da...@gmail.com> Signed-off-by:

[PULL 2/9] target/avr: Drop avr_cpu_memory_rw_debug()

2022-06-21 Thread Richard Henderson
From: Bin Meng CPUClass::memory_rw_debug() holds a callback for GDB memory access. If not provided, cpu_memory_rw_debug() is used by the GDB stub. Drop avr_cpu_memory_rw_debug() which does nothing special. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 7/9] util: Merge cacheflush.c and cacheinfo.c

2022-06-21 Thread Richard Henderson
Combine the two files into cacheflush.c. There's a couple of bits that would be helpful to share between the two, and combining them seems better than exporting the bits. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id:

[PULL 3/9] accel/tcg: Init TCG cflags in vCPU thread handler

2022-06-21 Thread Richard Henderson
From: Philippe Mathieu-Daudé Move TCG cflags initialization to thread handler. Remove the duplicated assert checks. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20220323171751.78612-6-philippe.mathieu.da...@gmail.com> Signed-off-by: Richard Henderson --- accel/tcg/tcg-accel-ops-mttcg.c

[PULL 5/9] qemu-timer: Skip empty timer lists before locking in qemu_clock_deadline_ns_all

2022-06-21 Thread Richard Henderson
From: Idan Horowitz This decreases qemu_clock_deadline_ns_all's share from 23.2% to 13% in a profile of icount-enabled aarch64-softmmu. Signed-off-by: Idan Horowitz Reviewed-by: Richard Henderson Message-Id: <20220114004358.299534-2-idan.horow...@gmail.com> Signed-off-by: Richard Henderson

[PULL 6/9] softmmu: Always initialize xlat in address_space_translate_for_iotlb

2022-06-21 Thread Richard Henderson
The bug is an uninitialized memory read, along the translate_fail path, which results in garbage being read from iotlb_to_section, which can lead to a crash in io_readx/io_writex. The bug may be fixed by writing any value with zero in ~TARGET_PAGE_MASK, so that the call to iotlb_to_section using

[PULL 0/9] tcg patch queue for 2022-06-21

2022-06-21 Thread Richard Henderson
/qemu.git tags/pull-tcg-20220621 for you to fetch changes up to c79a8e840c435bc26a251e34b043318e8b2081db: util/cacheflush: Optimize flushing when ppc host has coherent icache (2022-06-21 09:28:41 -0700) Speed empty timer list

[PATCH] build: improve -fsanitize-coverage-allowlist check

2022-06-21 Thread Alexander Bulekov
The sancov filter check still fails when unused arguments are treated as errors. To work around that, add a SanitizerCoverage flag to the build-check. Fixes: aa4f3a3b88 ("build: fix check for -fsanitize-coverage-allowlist") Signed-off-by: Alexander Bulekov --- meson.build | 3 ++- 1 file

[PATCH v4] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-21 Thread Iris Chen
From: Iris Chen Signed-off-by: Iris Chen --- Fixed .needed for subsection and suggestions from Francisco hw/block/m25p80.c | 82 ++- 1 file changed, 67 insertions(+), 15 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index

Re: [PATCH v3 09/51] target/arm: Add the SME ZA storage to CPUARMState

2022-06-21 Thread Peter Maydell
On Mon, 20 Jun 2022 at 18:52, Richard Henderson wrote: > > Place this late in the resettable section of the structure, > to keep the most common element offsets from being > 64k. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > + > +/* > + * SME ZA storage -- 256 x

Re: [PATCH v3 24/51] target/arm: Implement SME ZERO

2022-06-21 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:23, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sme.h| 2 ++ > target/arm/translate-a64.h | 1 + > target/arm/sme.decode | 4 > target/arm/sme_helper.c| 25 + >

Re: misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-21 Thread Patrick Venture
On Tue, Jun 21, 2022 at 10:17 AM Peter Foley wrote: > The upstream fixes in > https://gitlab.freedesktop.org/slirp/libslirp/-/commit/6489ebbc691f5d97221ad154d570a231e30fb369 > and > https://gitlab.freedesktop.org/slirp/libslirp/-/commit/cc20d9ac578aec5502dcb26557765d3e9433cb26 > resolved the

Re: [RFC PATCH v3 04/11] qapi: net: add stream and dgram netdevs

2022-06-21 Thread Laurent Vivier
On 21/06/2022 10:49, Markus Armbruster wrote: Laurent Vivier writes: On 20/06/2022 17:21, Markus Armbruster wrote: Laurent Vivier writes: Copied from socket netdev file and modified to use SocketAddress to be able to introduce new features like unix socket. "udp" and "mcast" are squashed

Re: [PULL 00/15] ppc queue

2022-06-21 Thread Richard Henderson
repository at: https://gitlab.com/danielhb/qemu.git tags/pull-ppc-20220621 for you to fetch changes up to 609b1c866925049f22a79623021076192f7a6595: target/ppc: cpu_init: Clean up stop state on cpu reset (2022-06-20 08:38:59 -0300

Re: [PATCH v3] linux-user: Adjust child_tidptr on set_tid_address() syscall

2022-06-21 Thread Laurent Vivier
Le 28/05/2022 à 12:52, Helge Deller a écrit : Keep track of the new child tidptr given by a set_tid_address() syscall. Do not call the host set_tid_address() syscall because we are emulating the behaviour of writing to child_tidptr in the exit() path. Signed-off-by: Helge Deller Reviewed-by:

Re: [PULL 20/33] configure: handle host compiler in probe_target_compiler

2022-06-21 Thread Richard Henderson
On 6/21/22 09:58, Paolo Bonzini wrote: On 6/20/22 18:41, Matheus Kowalczuk Ferst wrote: On 17/06/2022 07:12, Paolo Bonzini wrote: Hi Matheus, could you please test the tests-tcg-next branch at https://gitlab.com/bonzini/qemu? At be6090bcac10, it works if no BE toolchain is present.

Re: [PATCH v3] linux-user: Adjust child_tidptr on set_tid_address() syscall

2022-06-21 Thread Laurent Vivier
Le 28/05/2022 à 12:52, Helge Deller a écrit : Keep track of the new child tidptr given by a set_tid_address() syscall. Do not call the host set_tid_address() syscall because we are emulating the behaviour of writing to child_tidptr in the exit() path. Signed-off-by: Helge Deller Reviewed-by:

Re: [PATCH v2] linux-user: Add partial support for MADV_DONTNEED

2022-06-21 Thread Laurent Vivier
Le 21/06/2022 à 16:42, Ilya Leoshkevich a écrit : Currently QEMU ignores madvise(MADV_DONTNEED), which break apps that rely on this for zeroing out memory [1]. Improve the situation by doing a passthrough when the range in question is a host-page-aligned anonymous mapping. This is based on the

Re: [RFC PATCH] linux-user: un-parent OBJECT(cpu) when closing thread

2022-06-21 Thread Laurent Vivier
Le 10/06/2022 à 16:38, Alex Bennée a écrit : While forcing the CPU to unrealize by hand does trigger the clean-up code we never fully free resources because refcount never reaches zero. This is because QOM automatically added objects without an explicit parent to /unattached/, incrementing the

Re: [PATCH] linux-user/x86_64: Fix ELF_PLATFORM

2022-06-21 Thread Laurent Vivier
Le 03/06/2022 à 23:38, Richard Henderson a écrit : We had been using the i686 platform string for x86_64. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1041 Signed-off-by: Richard Henderson --- linux-user/elfload.c | 30 +- 1 file changed, 17

[PATCH v3 8/8] ppc/pnv: remove 'INTERFACE_PCIE_DEVICE' from phb4 root bus

2022-06-21 Thread Daniel Henrique Barboza
It's unneeded. No other PCIE_BUS implements this interface. Reviewed-by: Frederic Barrat Fixes: 4f9924c4d4cf ("ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge") Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb4.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH v3 6/8] ppc/pnv: make pnv_chip_power8_pic_print_info() use chip8->phbs[]

2022-06-21 Thread Daniel Henrique Barboza
It's inneficient to scroll all child objects when we have all PHBs available in chip8->phbs[]. pnv_chip_power8_pic_print_info_child() ended up folded into pic_print_info() for simplicity. Reviewed-by: Frederic Barrat Signed-off-by: Daniel Henrique Barboza --- hw/ppc/pnv.c | 22

[PATCH v3 5/8] ppc/pnv: make pnv_ics_resend() use chip8->phbs[]

2022-06-21 Thread Daniel Henrique Barboza
pnv_ics_resend() is scrolling through all the child objects of the chip to search for the PHBs. It's faster and simpler to just use the phbs[] array. pnv_ics_resend_child() was folded into pnv_ics_resend() since it's too simple to justify its own function. Reviewed-by: Cédric Le Goater

[PATCH v3 4/8] ppc/pnv: make pnv_ics_get() use the chip8->phbs[] array

2022-06-21 Thread Daniel Henrique Barboza
The function is working today by getting all the child objects of the chip, interacting with each of them to check whether the child is a PHB, and then doing what needs to be done. We have all the chip PHBs in the phbs[] array so interacting with all child objects is unneeded. Open code

[PATCH v3 7/8] ppc/pnv: remove 'INTERFACE_PCIE_DEVICE' from phb3 root bus

2022-06-21 Thread Daniel Henrique Barboza
It's unneeded. No other PCIE_BUS implements this interface. Reviewed-by: Frederic Barrat Fixes: 9ae1329ee2fe ("ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge") Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb3.c | 4 1 file changed, 4 deletions(-) diff --git

Re: [PATCH v2 2/2] target/arm: Catch invalid kvm state also for hvf

2022-06-21 Thread Peter Maydell
On Tue, 21 Jun 2022 at 12:41, Peter Maydell wrote: > > On Mon, 20 Jun 2022 at 20:22, Alexander Graf wrote: > > > > Some features such as running in EL3 or running M profile code are > > incompatible with virtualization as QEMU implements it today. To prevent > > users from picking invalid

[PATCH v3 3/8] ppc/pnv: assign pnv-phb-root-port chassis/slot earlier

2022-06-21 Thread Daniel Henrique Barboza
It is not advisable to execute an object_dynamic_cast() to poke into bus->qbus.parent and follow it up with a C cast into the PnvPHB type we think we got. In fact this is not needed. There is nothing sophisticated being done with the PHB object retrieved during root_port_realize() for both PHB3

[PATCH v3 0/8] pnv-phb related cleanups

2022-06-21 Thread Daniel Henrique Barboza
This version present changes in patch 03. We're now setting chassis and slot in pnv_phb_attach_root_port(), avoiding all the hassle of having to access the PHB object via bus->qbus.parent inside root_port_realize(). changes from v2: - patch 03: - set chassis and slot outside of

[PATCH v3 1/8] ppc/pnv: move root port attach to pnv_phb4_realize()

2022-06-21 Thread Daniel Henrique Barboza
Creating a root port is something related to the PHB, not the PEC. It also makes the logic more in line with what pnv-phb3 does. Reviewed-by: Frederic Barrat Reviewed-by: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb4.c | 4

[PATCH v3 2/8] ppc/pnv: attach phb3/phb4 root ports in QOM tree

2022-06-21 Thread Daniel Henrique Barboza
At this moment we leave the pnv-phb3(4)-root-port unattached in QOM: /unattached (container) (...) /device[2] (pnv-phb3-root-port) /bus master container[0] (memory-region) /bus master[0] (memory-region) /pci_bridge_io[0] (memory-region) /pci_bridge_io[1]

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-21 Thread Vladimir Sementsov-Ogievskiy
On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*nop* job_lock/unlock placed, rename the static functions that are always under job_mutex, adding "_locked" suffix. List of functions that get this suffix: job_txn_refjob_txn_del_job job_txn_apply

Re: [PATCH v3 23/51] target/arm: Implement SME RDSVL, ADDSVL, ADDSPL

2022-06-21 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:13, Richard Henderson wrote: > > These SME instructions are nominally within the SVE decode space, > so we add them to sve.decode and translate-sve.c. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.h | 1 + > target/arm/sve.decode | 5

Re: [RFC PATCH RESEND] scripts/checkpatch.pl: Change line limit warning

2022-06-21 Thread Lucas Mateus Martins Araujo e Castro
On 09/06/2022 10:56, Peter Maydell wrote: On Mon, 6 Jun 2022 at 15:34, Lucas Mateus Castro(alqotel) wrote: --- Currently there's a disagreement between the checkpatch code and the documentation, this RFC just changes the checkpatch to match the documentation. But there was a discussion in

Re: misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-21 Thread Peter Foley
The upstream fixes in https://gitlab.freedesktop.org/slirp/libslirp/-/commit/6489ebbc691f5d97221ad154d570a231e30fb369 and https://gitlab.freedesktop.org/slirp/libslirp/-/commit/cc20d9ac578aec5502dcb26557765d3e9433cb26 resolved the failure we were seeing in our internal test-case. Thanks! On Tue,

Re: [PATCH v3 17/51] target/arm: Add cpu properties for SME

2022-06-21 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:08, Richard Henderson wrote: > > Mirror the properties for SVE. The main difference is > that any arbitrary set of powers of 2 may be supported, > and not the stricter constraints that apply to SVE. > > Include a property to control FEAT_SME_FA64, as failing > to

Re: [PATCH v7 06/18] jobs: protect jobs with job_lock/unlock

2022-06-21 Thread Vladimir Sementsov-Ogievskiy
On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: } @@ -1939,7 +1943,9 @@ static void blockdev_backup_abort(BlkActionState *common) aio_context = bdrv_get_aio_context(state->bs); aio_context_acquire(aio_context); -job_cancel_sync(>job->job, true); +

Re: [PATCH 11/11] target/ppc: Implement slbiag

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:20, Lucas Coutinho wrote: Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: [PULL 20/33] configure: handle host compiler in probe_target_compiler

2022-06-21 Thread Paolo Bonzini
On 6/20/22 18:41, Matheus Kowalczuk Ferst wrote: On 17/06/2022 07:12, Paolo Bonzini wrote: Hi Matheus, could you please test the tests-tcg-next branch at https://gitlab.com/bonzini/qemu? At be6090bcac10, it works if no BE toolchain is present. Otherwise, the script probes

Re: [PATCH 10/11] target/ppc: Move slbsync to decodetree

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:20, Lucas Coutinho wrote: Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: [PATCH 08/11] target/ppc: Move slbmfee to decodetree

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:20, Lucas Coutinho wrote: Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: [PATCH 09/11] target/ppc: Move slbfee to decodetree

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:20, Lucas Coutinho wrote: Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: [PATCH 07/11] target/ppc: Move slbmfev to decodetree

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:20, Lucas Coutinho wrote: Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: [PATCH 06/11] target/ppc: Move slbmte to decodetree

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:20, Lucas Coutinho wrote: Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: [PATCH 05/11] target/ppc: Move slbia to decodetree

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:20, Lucas Coutinho wrote: Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-21 Thread Patrick Venture
On Fri, Jun 17, 2022 at 7:37 AM Alexander Bulekov wrote: > On 220617 1217, Thomas Huth wrote: > > On 16/06/2022 21.03, Alexander Bulekov wrote: > > > On 220616 0930, Patrick Venture wrote: > > > > On Thu, Jun 16, 2022 at 6:31 AM Alexander Bulekov > wrote: > > > > > > > > > Is this an

Re: [PATCH v7 06/18] jobs: protect jobs with job_lock/unlock

2022-06-21 Thread Vladimir Sementsov-Ogievskiy
On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: Introduce the job locking mechanism through the whole job API, Not the whole, I think? As next patches introduces locking in more and more places.. -- Best regards, Vladimir

Re: [PATCH 03/11] target/ppc: Move slbie to decodetree

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:19, Lucas Coutinho wrote: Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: [PATCH 04/11] target/ppc: Move slbieg to decodetree

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:19, Lucas Coutinho wrote: Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: [PATCH 01/11] target/ppc: receive DisasContext explicitly in GEN_PRIV

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:19, Lucas Coutinho wrote: From: Matheus Ferst GEN_PRIV and related CHK_* macros just assumed that variable named "ctx" would be in scope when they are used, and that it would be a pointer to DisasContext. Change these macros to receive the pointer explicitly. Signed-off-by:

Re: [PATCH 02/11] target/ppc: add macros to check privilege level

2022-06-21 Thread Leandro Lupori
On 6/15/22 16:19, Lucas Coutinho wrote: From: Matheus Ferst Equivalent to CHK_SV and CHK_HV, but can be used in decodetree methods. Signed-off-by: Matheus Ferst Signed-off-by: Lucas Coutinho --- Reviewed-by: Leandro Lupori Thanks, Leandro

Re: [PATCH 0/6] Fix support for biarch compilers and cross cflags

2022-06-21 Thread Matheus Kowalczuk Ferst
On 21/06/2022 04:51, Paolo Bonzini wrote: > This series fixes two bugs with configure's cross compilation detection: > > - first, --cross-cflags is not obeyed by pc-bios/ compilation > > - second, on a ppc64le machine, the host compiler can be used for ppc64 >tests/tcg; That may be true for

Re: [PATCH v2 2/2] ui/gtk: a new array param monitor to specify the target displays

2022-06-21 Thread Dongwon Kim
Hi Markus, On Mon, Jun 20, 2022 at 09:07:04AM +0200, Markus Armbruster wrote: > Dongwon Kim writes: > > > New integer array parameter, 'monitor' is for specifying the target > > displays where individual QEMU windows are placed upon launching. > > > > The array contains a series of numbers

Re: [PATCH 2/2] qemu-timer: Skip empty timer lists before locking in qemu_clock_deadline_ns_all

2022-06-21 Thread Richard Henderson
On 6/19/22 01:54, Idan Horowitz wrote: On Wed, 26 Jan 2022 at 23:43, Richard Henderson wrote: Reviewed-by: Richard Henderson r~ Hey, I believe this patch might have accidentally been missed? Oops, yes. Got 1/2 but not 2/2. Queued to tcg-next. r~

  1   2   3   >