Fix image inflation when offset in BAT is out of image.
Replace whole BAT syncing by flushing only dirty blocks.
Move all the checks outside the main check function in
separate functions
Use WITH_QEMU_LOCK_GUARD for simplier code.
v4 changes:
Move s->data_end fixing to parallels_co_check().
data_end field in BDRVParallelsState is set to the biggest offset present
in BAT. If this offset is outside of the image, any further write will create
the cluster at this offset and/or the image will be truncated to this
offset on close. This is definitely not correct.
Raise an error in parallels_
Make sure env->nested_state is cleaned up when a vCPU is reset, it may
be stale after an incoming migration, kvm_arch_put_registers() may
end up failing or putting vCPU in a weird state.
Reviewed-by: Maxim Levitsky
Signed-off-by: Vitaly Kuznetsov
---
target/i386/kvm/kvm.c | 37 +
On Thu, 18 Aug 2022, Cédric Le Goater wrote:
Daniel,
On 8/17/22 17:08, BALATON Zoltan wrote:
Hello,
This is based on gitlab.com/danielhb/qemu/tree/ppc-7.2
This series contains the rest of Cédric's OOM'ify patches modified
according my review comments and some other clean ups I've noticed
alon
Changes since RFC:
- Call kvm_put_msr_feature_control() before kvm_put_sregs2() to achieve
the same result [Paolo].
- Add Maxim's R-b to PATCH1.
It was discovered that Windows 11 with WSL2 (Hyper-V) enabled guests fail
to reboot when QEMU's 'system_reset' command is issued. The problem appears
to
kvm_put_sregs2() fails to reset 'locked' CR4/CR0 bits upon vCPU reset when
it is in VMX root operation. Do kvm_put_msr_feature_control() before
kvm_put_sregs2() to (possibly) kick vCPU out of VMX root operation. It also
seems logical to do kvm_put_msr_feature_control() before
kvm_put_nested_state()
On Mon, 15 Aug 2022 at 22:35, Hao Wu wrote:
>
> Add cortex A35 core and enable it for virt board.
>
> Signed-off-by: Hao Wu
> Reviewed-by: Joe Komlodi
> +static void aarch64_a35_initfn(Object *obj)
> +{
> +ARMCPU *cpu = ARM_CPU(obj);
> +
> +cpu->dtb_compatible = "arm,cortex-a35";
> +
If it is a pcie device, check that all devices on the path from
the device to the root complex have ACS enabled, and then the
device will become an iommu_group.
pci_acs_path_enabled, this function in the Linux kernel, it means
that if the device is a PCIe device, check the path from the
device to
On Montag, 18. Juli 2022 16:02:31 CEST Christian Schoenebeck wrote:
> On Montag, 18. Juli 2022 15:10:55 CEST Christian Schoenebeck wrote:
> > There are currently 4 different functions for sending a 9p 'Twalk'
> > request. They are all doing the same thing, just in a slightly different
> > way and w
On Thu, 18 Aug 2022 at 15:07, Christian Schoenebeck
wrote:
>
> On Mittwoch, 17. August 2022 17:55:24 CEST Peter Maydell wrote:
> > On Wed, 17 Aug 2022 at 15:49, Nikita Ivanov wrote:
> > > Well...
> > >
> > > What exactly is still under discussion? In my perspective, the main
> > > pitfalls have b
On Mittwoch, 17. August 2022 17:55:24 CEST Peter Maydell wrote:
> On Wed, 17 Aug 2022 at 15:49, Nikita Ivanov wrote:
> > Well...
> >
> > What exactly is still under discussion? In my perspective, the main
> > pitfalls have been resolved:
> >
> > 0. All possible places where TFR() macro could be
On Thu, 18 Aug 2022 at 05:20, Alistair Francis wrote:
>
> On Tue, Aug 16, 2022 at 5:11 AM Peter Maydell
> wrote:
> >
> > The riscv target incorrectly enabled semihosting always, whether the
> > user asked for it or not. Call semihosting_enabled() passing the
> > correct value to the is_userspac
This patchset fixes a Coverity nit relating to the
pci_set_*_by_mask() helper functions, where we might shift off the
end of a variable if the caller passes in a bogus mask argument.
Patch 2 is the coverity fix (adding an assert() to help Coverity
out a bit and to catch potential future actual bugs
Coverity complains that in functions like pci_set_word_by_mask()
we might end up shifting by more than 31 bits. This is true,
but only if the caller passes in a zero mask. Help Coverity out
by asserting that the mask argument is valid.
Fixes: CID 1487168
Reviewed-by: Richard Henderson
Signed-off
The helper functions pci_get_{byte,word,long,quad}_by_mask()
were added in 2012 in commit c9f50cea70a1596. In the decade
since we have never added a single use of them.
The helpers clearly aren't that helpful, so drop them
rather than carrying around dead code.
Reviewed-by: Richard Henderson
Sig
On Wed, Aug 17, 2022 at 10:40:12PM -0700, Hugh Dickins wrote:
> On Wed, 6 Jul 2022, Chao Peng wrote:
> > This is the v7 of this series which tries to implement the fd-based KVM
> > guest private memory.
>
> Here at last are my reluctant thoughts on this patchset.
>
> fd-based approach for support
Daniel,
On 8/17/22 17:08, BALATON Zoltan wrote:
Hello,
This is based on gitlab.com/danielhb/qemu/tree/ppc-7.2
This series contains the rest of Cédric's OOM'ify patches modified
according my review comments and some other clean ups I've noticed
along the way.
I think patches 01-24 are good fo
On 8/17/22 17:08, BALATON Zoltan wrote:
Signed-off-by: BALATON Zoltan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/ppc/ppc405_uc.c | 5 +++--
hw/ppc/ppc440_bamboo.c | 27 ++--
hw/ppc/ppc440_uc.c | 3 ++-
hw/ppc/ppc4xx_devs.c | 48 +++
* Vladimir Sementsov-Ogievskiy (vsement...@yandex-team.ru) wrote:
> [add migration maintainers]
Thanks,
> On 8/11/22 19:49, Andrey Ryabinin wrote:
> > pxb/pxb-pcie/pxb-cxl devices currently doesn't have vmstate description
> > So the state of device is not preserved during migration and
> > guest
On Donnerstag, 18. August 2022 14:06:04 CEST Guoyi Tu wrote:
> Ping...
>
> Any comments are welcome
>
> On 8/12/22 19:01, Guoyi Tu wrote:
> > socket_get_fd() have much the same codes as monitor_fd_param(),
> > so qemu_get_fd() is introduced to implement the common logic.
> > now socket_get_fd() a
On 8/18/22 14:38, Dr. David Alan Gilbert wrote:
> * Nikolay Borisov (nbori...@suse.com) wrote:
>> [adding Juan and David to cc as I had missed them. ]
>
> Hi Nikolay,
>
>> On 11.08.22 г. 16:47 ч., Nikolay Borisov wrote:
>>> Hello,
>>>
>>> I'm currently looking into implementing a 'file:' uri for
* Nikolay Borisov (nbori...@suse.com) wrote:
> [adding Juan and David to cc as I had missed them. ]
Hi Nikolay,
> On 11.08.22 г. 16:47 ч., Nikolay Borisov wrote:
> > Hello,
> >
> > I'm currently looking into implementing a 'file:' uri for migration save
> > in qemu. Ideally the solution will be
Hi,
Google Summer of Code organizations are encouraged to create 2-3
minute videos that present their organization. Organizations with
videos will stand out and may be more successful in attracting
applicants.
I want to give this a try for QEMU. If you want to be involved either
as the video prese
Ping...
Any comments are welcome
On 8/12/22 19:01, Guoyi Tu wrote:
socket_get_fd() have much the same codes as monitor_fd_param(),
so qemu_get_fd() is introduced to implement the common logic.
now socket_get_fd() and monitor_fd_param() directly call this
function.
Signed-off-by: Guoyi Tu
---
Hi,
> > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> > index 3a35193ff7..2e5dae9a89 100644
> > --- a/hw/i386/pc_q35.c
> > +++ b/hw/i386/pc_q35.c
> > @@ -376,6 +376,7 @@ static void pc_q35_7_1_machine_options(MachineClass *m)
> > pc_q35_machine_options(m);
> > m->alias = "q35";
On 8/12/22 19:49, Peter Maydell wrote:
On Fri, 12 Aug 2022 at 12:44, wrote:
From: Guoyi Tu
qemu_socketpair() will create a pair of connected sockets
with FD_CLOEXEC set
Signed-off-by: Guoyi Tu
---
include/qemu/sockets.h | 3 +++
util/osdep.c | 24
On 8/12/22 19:50, Peter Maydell wrote:
On Fri, 12 Aug 2022 at 12:44, wrote:
From: Guoyi Tu
set close-on-exec flag on the new opened file descriptors at default
What goes wrong if we don't do this? The commit message
is a good place to explain what bug the commit is fixing,
and its conse
Hi
Please, send any topic that you are interested in covering.
At the end of Monday I will send an email with the agenda or the
cancellation of the call, so hurry up.
After discussions on the QEMU Summit, we are going to have always open a
KVM call where you can add topics.
Call details:
B
On Thu, Aug 18, 2022 at 1:44 PM Paolo Bonzini wrote:
> Found with "muon analyze".
>
> Signed-off-by: Paolo Bonzini
>
Reviewed-by: Marc-André Lureau
> ---
> plugins/meson.build | 2 +-
> tests/fp/meson.build | 2 +-
> tests/qapi-schema/meson.build | 24 --
On Thu, Aug 18, 2022 at 1:31 PM Paolo Bonzini wrote:
> Found with "muon analyze".
>
nice
Reviewed-by: Marc-André Lureau
>
> Signed-off-by: Paolo Bonzini
> ---
> meson.build | 2 --
> pc-bios/keymaps/meson.build | 1 -
> qapi/meson.build| 15 ---
> ta
On Thu, Aug 18, 2022 at 11:27:30AM +0200, Paolo Bonzini wrote:
> On 8/17/22 18:14, Michael S. Tsirkin wrote:
> > @@ -332,7 +332,7 @@ static void microvm_memory_init(MicrovmMachineState
> > *mms)
> > rom_set_fw(fw_cfg);
> > if (machine->kernel_filename != NULL) {
> > -x86_load_l
* Daniel Henrique Barboza (danielhb...@gmail.com) wrote:
> Reading the FDT requires that the user saves the fdt_blob and then use
> 'dtc' to read the contents. Saving the file and using 'dtc' is a strong
> use case when we need to compare two FDTs, but it's a lot of steps if
> you want to do quick
This patch updates code of avx512 support for xbzrle_encode_buffer
function. We modified runtime check of avx512 and simplified algorithm.
Besides, we provide benchmark in xbzrle-bench.c for performance
comparison.
Signed-off-by: ling xu
Co-authored-by: Zhou Zhao
Co-authored-by: Jun Jin
ling x
Test code in test-xbzrle.c, benchmark code in xbzrle-bench.c for
performance benchmarking.
Signed-off-by: ling xu
Co-authored-by: Zhou Zhao
Co-authored-by: Jun Jin
---
tests/bench/meson.build| 4 +
tests/bench/xbzrle-bench.c | 468 +
tests/unit/test-xb
This commit updates code of avx512 support for xbzrle_encode_buffer function to
accelerate xbzrle encoding speed. We add runtime check of avx512 and add
benchmark for this feature. Compared with C version of
xbzrle_encode_buffer function, avx512 version can achieve 50%-70%
performance improvement o
Found with "muon analyze".
Signed-off-by: Paolo Bonzini
---
plugins/meson.build | 2 +-
tests/fp/meson.build | 2 +-
tests/qapi-schema/meson.build | 24
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/plugins/meson.build b/plugins/me
On 8/18/22 11:49, Alexander Ivanov wrote:
On 17.08.2022 21:43, Vladimir Sementsov-Ogievskiy wrote:
On 8/17/22 22:27, Denis V. Lunev wrote:
On 17.08.2022 21:13, Vladimir Sementsov-Ogievskiy wrote:
On 8/15/22 12:02, Alexander Ivanov wrote:
data_end field in BDRVParallelsState is set to the big
* Daniel Henrique Barboza (danielhb...@gmail.com) wrote:
> To save the FDT blob we have the '-machine dumpdtb=' property.
> With this property set, the machine saves the FDT in and exit.
> The created file can then be converted to plain text dts format using
> 'dtc'.
>
> There's nothing particula
On 8/17/22 18:14, Michael S. Tsirkin wrote:
@@ -332,7 +332,7 @@ static void microvm_memory_init(MicrovmMachineState *mms)
rom_set_fw(fw_cfg);
if (machine->kernel_filename != NULL) {
-x86_load_linux(x86ms, fw_cfg, 0, true, false);
+x86_load_linux(x86ms, fw_cfg, 0, t
On 8/18/22 01:41, Kirill A. Shutemov wrote:
Note, that userfaultfd is only relevant for shared memory as it requires
VMA which we don't have for MFD_INACCESSIBLE.
Oh, you're right! So yeah, looks like userfaultfd is not a problem.
Paolo
Found with "muon analyze".
Signed-off-by: Paolo Bonzini
---
meson.build | 2 --
pc-bios/keymaps/meson.build | 1 -
qapi/meson.build| 15 ---
target/riscv/meson.build| 2 --
4 files changed, 20 deletions(-)
diff --git a/meson.build b/meson.build
ind
Queued, thanks.
Paolo
On 17.08.2022 23:00, Vladimir Sementsov-Ogievskiy wrote:
On 8/15/22 12:02, Alexander Ivanov wrote:
We will add more and more checks so we need a better code structure
in parallels_co_check. Let each check performs in a separate loop
in a separate helper.
Signed-off-by: Alexander Ivanov
---
v
On 17.08.2022 21:48, Vladimir Sementsov-Ogievskiy wrote:
On 8/15/22 12:02, Alexander Ivanov wrote:
BAT is written in the context of conventional operations over
the image inside bdrv_co_flush() when it calls
parallels_co_flush_to_os() callback. Thus we should not
modify BAT array directly, but c
On 17.08.2022 21:43, Vladimir Sementsov-Ogievskiy wrote:
On 8/17/22 22:27, Denis V. Lunev wrote:
On 17.08.2022 21:13, Vladimir Sementsov-Ogievskiy wrote:
On 8/15/22 12:02, Alexander Ivanov wrote:
data_end field in BDRVParallelsState is set to the biggest offset
present
in BAT. If this offset
Am 17/08/2022 um 15:10 schrieb Emanuele Giuseppe Esposito:
>
>
> Am 17/08/2022 um 10:04 schrieb Emanuele Giuseppe Esposito:
+/* protect against read in job_do_yield_locked */
+JOB_LOCK_GUARD();
+/* ensure the coroutine is quiescent while the AioContext is changed
>>
Hi,
On Mon, Jun 27, 2022 at 05:29:26PM +0200, Markus Armbruster wrote:
> Victor Toso writes:
>
> > Hi Markus,
> >
> > On Mon, Jun 27, 2022 at 09:15:53AM +0200, Markus Armbruster wrote:
> >> Victor Toso writes:
> >>
> >> > Hi,
> >> >
> >> > This is the second iteration of RFC v1:
> >> > https:
On Wed, Aug 17, 2022 at 3:45 PM Zhang, Chen wrote:
>
> Ping Jason and Peter, any comments for this patch?
>
> Thanks
> Chen
>
> > -Original Message-
> > From: Zhang, Chen
> > Sent: Tuesday, August 9, 2022 4:49 PM
> > To: Jason Wang ; Peter Maydell
> > ; Li Zhijian ; qemu-dev
> >
> >
Yes, it should. I'll squash it in the next version, thanks.
Milica
From: Philippe Mathieu-Daudé on behalf of
Philippe Mathieu-Daudé
Sent: Tuesday, August 16, 2022 2:22 AM
To: Milica Lazarevic ; th...@redhat.com
Cc: qemu-devel@nongnu.org ; cfont...@suse.de
; b
Hi,
On Tue, Jul 05, 2022 at 05:47:25PM +0100, Daniel P. Berrangé wrote:
> On Tue, Jul 05, 2022 at 08:45:54AM -0700, Andrea Bolognani wrote:
> > On Fri, Jun 17, 2022 at 02:19:29PM +0200, Victor Toso wrote:
> > > This patch handles QAPI event types and generates data structures in
> > > Go that hand
Hi,
On Tue, Jul 05, 2022 at 08:45:54AM -0700, Andrea Bolognani wrote:
> On Fri, Jun 17, 2022 at 02:19:29PM +0200, Victor Toso wrote:
> > This patch handles QAPI event types and generates data structures in
> > Go that handles it.
> >
> > We also define a Event interface and two helper functions Ma
Am 17/08/2022 um 20:54 schrieb Vladimir Sementsov-Ogievskiy:
> On 8/16/22 15:52, Emanuele Giuseppe Esposito wrote:
}
@@ -501,8 +481,12 @@ void job_unref_locked(Job *job)>
assert(!job->txn);
if (job->driver->free) {
+ AioContext *aio_context = j
On 17.08.2022 21:21, Vladimir Sementsov-Ogievskiy wrote:
On 8/15/22 12:02, Alexander Ivanov wrote:
This helper will be reused in next patches during parallels_co_check
rework to simplify its code.
Signed-off-by: Alexander Ivanov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
v2: A new pa
On 18/08/2022 09.07, Alex Bennée wrote:
Bin Meng writes:
Current project timeout is 1 hour, but the check-gprof-gcov job never
completes within 1 hour. Increase the job timeout to 90 minutes.
I've tried to do some data mining on this test which seems to indicate
that the average successful
Bin Meng writes:
> Current project timeout is 1 hour, but the check-gprof-gcov job never
> completes within 1 hour. Increase the job timeout to 90 minutes.
I've tried to do some data mining on this test which seems to indicate
that the average successful completion time for gprof-gcov is 27 mi
From: Marc-André Lureau
The display may be corrupted when changing screen colour depth in
qemu-system-ppc/MacOS since 7.0.
Do not short-cut qemu_console_resize() if the surface is backed by vga
vram. When the scanout isn't set, or it is already allocated, or opengl,
and the size is fitting, we s
From: Priyankar Jain
The purpose of dbus_get_proxies to construct the proxies corresponding to the
IDs registered to dbus-vmstate.
Currenty, this function returns an error in case there is any failure
while instantiating proxy for "all" the names on dbus.
Ideally this function should error out
101 - 157 of 157 matches
Mail list logo
