Re: [PATCH v9 5/7] config: add check to block layer

2022-09-10 Thread Damien Le Moal
On 2022/09/10 14:27, Sam Li wrote: > Putting zoned/non-zoned BlockDrivers on top of each other is not > allowed. > > Signed-off-by: Sam Li > Reviewed-by: Stefan Hajnoczi > --- > block.c | 14 ++ > block/file-posix.c | 14 ++ >

Re: [PATCH v9 7/7] docs/zoned-storage: add zoned device documentation

2022-09-10 Thread Damien Le Moal
On 2022/09/10 14:27, Sam Li wrote: > Add the documentation about the zoned device support to virtio-blk > emulation. > > Signed-off-by: Sam Li > Reviewed-by: Stefan Hajnoczi > --- > docs/devel/zoned-storage.rst | 41 ++ > docs/system/qemu-block-drivers.rst.inc

Re: [PATCH v9 4/7] raw-format: add zone operations to pass through requests

2022-09-10 Thread Damien Le Moal
On 2022/09/10 14:27, Sam Li wrote: > raw-format driver usually sits on top of file-posix driver. It needs to > pass through requests of zone commands. > > Signed-off-by: Sam Li > Reviewed-by: Stefan Hajnoczi Reviewed-by: Damien Le Moal > --- > block/raw-format.c | 13 + > 1 file

Re: [PATCH v9 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-09-10 Thread Damien Le Moal
On 2022/09/10 14:27, Sam Li wrote: [...] > +/* > + * Send a zone_report command. > + * offset is a byte offset from the start of the device. No alignment > + * required for offset. > + * nr_zones represents IN maximum and OUT actual. > + */ > +int coroutine_fn blk_co_zone_report(BlockBackend *blk,

Re: [PATCH v9 2/7] file-posix: introduce helper functions for sysfs attributes

2022-09-10 Thread Damien Le Moal
On 2022/09/10 14:27, Sam Li wrote: > Use get_sysfs_str_val() to get the string value of device > zoned model. Then get_sysfs_zoned_model() can convert it to > BlockZoneModel type of QEMU. > > Use get_sysfs_long_val() to get the long value of zoned device > information. > > Signed-off-by: Sam Li

Re:Re: [PATCH] bugfix:migrate with block-dirty-bitmap (disk size is big enough) can't be finished

2022-09-10 Thread liuhaiwei9699
sometimes ,post-copy mode is not the best choice. For instance, Supposing migrate process will take ten minutes,but network may be interruptted In this process . If it does happenthe , memory data of VM will be splitted into two parts, and will not be rollback.This is a bad situation so

Re: [PATCH v2] hw/virtio/vhost-shadow-virtqueue: Silence GCC error "maybe-uninitialized"

2022-09-10 Thread Bernhard Beschow
Am 10. September 2022 15:11:17 UTC schrieb Bernhard Beschow : >GCC issues a false positive warning, resulting in build failure with -Werror: > > In file included from /usr/include/glib-2.0/glib.h:114, > from src/include/glib-compat.h:32, > from

[PATCH] tests/9p: split virtio-9p-test.c into tests and 9p client part

2022-09-10 Thread Christian Schoenebeck
This patch is pure refactoring, it does not change behaviour. virtio-9p-test.c grew to 1657 lines. Let's split this file up between actual 9p test cases vs. 9p test client, to make it easier to concentrate on the actual 9p tests. Move the 9p test client code to a new unit virtio-9p-client.c,

Re: [PATCH v2] hw/virtio/vhost-shadow-virtqueue: Silence GCC error "maybe-uninitialized"

2022-09-10 Thread Richard Henderson
On 9/10/22 16:11, Bernhard Beschow wrote: GCC issues a false positive warning, resulting in build failure with -Werror: In file included from /usr/include/glib-2.0/glib.h:114, from src/include/glib-compat.h:32, from src/include/qemu/osdep.h:144,

[PATCH] arm/monitor: add register name resolution

2022-09-10 Thread Nikola Brkovic
This patch allows the monitor to resolve the stack pointer, instruction pointer, system status register and FPU status register on ARM targets. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1145 Signed-off-by: Nikola Brkovic --- target/arm/monitor.c | 29 +

[PATCH v2] hw/virtio/vhost-shadow-virtqueue: Silence GCC error "maybe-uninitialized"

2022-09-10 Thread Bernhard Beschow
GCC issues a false positive warning, resulting in build failure with -Werror: In file included from /usr/include/glib-2.0/glib.h:114, from src/include/glib-compat.h:32, from src/include/qemu/osdep.h:144, from

Re: [PATCH] bugfix:migrate with block-dirty-bitmap (disk size is big enough) can't be finished

2022-09-10 Thread 刘海伟
hi,i have a question if failed in migration using post-copy mode,is there some way to restore the memory data back to soucre VM? 发自我的小米 在 Vladimir Sementsov-Ogievskiy ,2022年9月10日 下午6:18写道: On 9/10/22 09:35, liuhaiwei wrote: > From: liuhaiwei > > bug description as

Re: [PATCH 4/4] scripts: add script to compare compatible properties

2022-09-10 Thread Vladimir Sementsov-Ogievskiy
On 9/8/22 13:36, Maksim Davydov wrote: This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the most suitable machine. Also table in json or csv format should be used

Re: [PATCH 3/4] python/qmp: increase read buffer size

2022-09-10 Thread Vladimir Sementsov-Ogievskiy
On 9/8/22 13:36, Maksim Davydov wrote: After modification of "query-machines" command the buffer size should be more than 452kB to contain output with compat-props. Signed-off-by: Maksim Davydov --- python/qemu/qmp/qmp_client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 2/4] qmp: add dump machine type compatible properties

2022-09-10 Thread Vladimir Sementsov-Ogievskiy
On 9/8/22 13:36, Maksim Davydov wrote: To control that creating new machine type doesn't affect the previous types (their compat_props) and to check complex compat_props inheritance we need qmp command to print machine type compatible properties. This patch adds the ability to get list of all

Re: [PATCH] bugfix:migrate with block-dirty-bitmap (disk size is big enough) can't be finished

2022-09-10 Thread Vladimir Sementsov-Ogievskiy
Hi! On 9/10/22 13:47, Seaway Liu(刘海伟) wrote: hi,i have a question if failed in migration using post-copy mode,is there some way to restore the memory data back to soucre VM? As far as I understand, no, there is not. Postcopy started actually means: target has started. So, RAM is touched

Re: [PATCH 1/4] qom: add devault value

2022-09-10 Thread Vladimir Sementsov-Ogievskiy
On 9/8/22 13:36, Maksim Davydov wrote: qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types.

Re: [PATCH] bugfix:migrate with block-dirty-bitmap (disk size is big enough) can't be finished

2022-09-10 Thread Vladimir Sementsov-Ogievskiy
On 9/10/22 09:35, liuhaiwei wrote: From: liuhaiwei bug description as https://gitlab.com/qemu-project/qemu/-/issues/1203 Usually,we use the precopy or postcopy mode to migrate block dirty bitmap. but if block-dirty-bitmap size more than threshold size,we cannot entry the migration_completion

[QEMU][PATCH 0/5] Introduce Xilinx Versal CANFD

2022-09-10 Thread Vikram Garhwal
Hi, This patch implements CANFD controller for xlnx-versal-virt machine. There are two controllers CANFD0@0xFF06_ and CANFD1@0xFF07_ are connected to the machine. Also, added basic qtests for data exchange between both the controllers in various supported configs. Regards, Vikram Vikram

[QEMU][PATCH 5/5] MAINTAINERS: Include canfd tests under Xilinx CAN

2022-09-10 Thread Vikram Garhwal
Signed-off-by: Vikram Garhwal --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1d45e92271..4bc811c237 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1756,7 +1756,7 @@ M: Francisco Iglesias S: Maintained F: hw/net/can/xlnx-*

[QEMU][PATCH 4/5] tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller

2022-09-10 Thread Vikram Garhwal
The QTests perform three tests on the Xilinx VERSAL CANFD controller: Tests the CANFD controllers in loopback. Tests the CANFD controllers in normal mode with CAN frame. Tests the CANFD controllers in normal mode with CANFD frame. Signed-off-by: Vikram Garhwal ---

[QEMU][PATCH 3/5] xlnx-zynqmp: Connect Xilinx VERSAL CANFD controllers

2022-09-10 Thread Vikram Garhwal
Connect CANFD0 and CANFD1 on the Versal-virt machine. Signed-off-by: Vikram Garhwal --- hw/arm/xlnx-versal-virt.c| 45 hw/arm/xlnx-versal.c | 37 + include/hw/arm/xlnx-versal.h | 12 ++ 3 files changed, 94

[QEMU][PATCH 2/5] hw/net/can: Introduce Xilinx Versal CANFD controller

2022-09-10 Thread Vikram Garhwal
The Xilinx Versal CANFD controller is developed based on SocketCAN, QEMU CAN bus implementation. Bus connection and socketCAN connection for each CAN module can be set through command lines. Example for using connecting CANFD0 and CANFD1 to same bus: -machine xlnx-versal-virt -object

[QEMU][PATCH 1/5] MAINTAINERS: Update maintainer's email for Xilinx CAN

2022-09-10 Thread Vikram Garhwal
Signed-off-by: Vikram Garhwal --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1729c0901c..1d45e92271 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1751,8 +1751,8 @@ F: tests/qtest/intel-hda-test.c F:

[PATCH 2/2] virtio-blk: add zoned storage emulation for zoned devices

2022-09-10 Thread Sam Li
This patch extends virtio-blk emulation to handle zoned device commands by calling the new block layer APIs to perform zoned device I/O on behalf of the guest. It supports Report Zone, four zone oparations (open, close, finish, reset), and Append Zone. The VIRTIO_BLK_F_ZONED feature bit will only

[PATCH 1/2] include: import virtio_blk headers from linux with zoned device support

2022-09-10 Thread Sam Li
Add file from Dmitry's "virtio-blk:add support for zoned block devices" linux patch using scripts/update-linux-headers.sh. There is a link for more information: https://github.com/dmitry-fomichev/virtblk-zbd Signed-off-by: Sam Li --- include/standard-headers/linux/virtio_blk.h | 109

[PATCH] block: introduce zone append write for zoned devices

2022-09-10 Thread Sam Li
A zone append command is a write operation that specifies the first logical block of a zone as the write position. When writing to a zoned block device using zone append, the byte offset of the write is pointing to the write pointer of that zone. Upon completion the device will respond with the

[PATCH] bugfix:migrate with block-dirty-bitmap (disk size is big enough) can't be finished

2022-09-10 Thread liuhaiwei
From: liuhaiwei bug description as https://gitlab.com/qemu-project/qemu/-/issues/1203 Usually,we use the precopy or postcopy mode to migrate block dirty bitmap. but if block-dirty-bitmap size more than threshold size,we cannot entry the migration_completion in migration_iteration_run function