Re: [PATCH v9 1/7] include: add zoned device structs

2022-09-15 Thread Sam Li
Eric Blake 于2022年9月15日周四 16:05写道: > > On Sat, Sep 10, 2022 at 01:27:53PM +0800, Sam Li wrote: > > Signed-off-by: Sam Li > > Reviewed-by: Stefan Hajnoczi > > Reviewed-by: Damien Le Moal > > --- > > include/block/block-common.h | 43 > > 1 file changed, 43

[PATCH v6 1/2] i386: kvm: extend kvm_{get, put}_vcpu_events to support pending triple fault

2022-09-15 Thread Chenyi Qiang
For the direct triple faults, i.e. hardware detected and KVM morphed to VM-Exit, KVM will never lose them. But for triple faults sythesized by KVM, e.g. the RSM path, if KVM exits to userspace before the request is serviced, userspace could migrate the VM and lose the triple fault. A new flag

[PATCH v3 2/2] Update linux headers to v6.0-rc4

2022-09-15 Thread Chenyi Qiang
commit 7e18e42e4b280c85b76967a9106a13ca61c16179 Reviewed-by: Cornelia Huck Signed-off-by: Chenyi Qiang --- include/standard-headers/asm-x86/bootparam.h | 7 +- include/standard-headers/drm/drm_fourcc.h | 73 +++- include/standard-headers/linux/ethtool.h | 29 +--

[PATCH v3 1/2] configure: Add -Wno-gnu-variable-sized-type-not-at-end

2022-09-15 Thread Chenyi Qiang
A Linux headers update to v6.0-rc switches some definitions from GNU 'zero-length-array' extension to the C-standard-defined flexible array member. e.g. struct kvm_msrs { __u32 nmsrs; /* number of msrs in entries */ __u32 pad; - struct kvm_msr_entry entries[0]; +

Re: [PATCH v2 27/30] tests/docker: update and flatten debian-hexagon-cross

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile as we do not some of the extraneous packages from the base image to build the toolchain. Signed-off-by: Alex Bennée Message-Id:

Re: [PATCH v2 30/30] tests/docker: remove the Debian base images

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: We no longer use these in any of our images. Clean-up the remaining comments and documentation that reference them and remove from the build. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id:<20220826172128.353798-25-alex.ben...@linaro.org> ---

Re: [PATCH v2 23/30] tests/docker: update and flatten debian-all-test-cross

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We also need to ensure we install clang as it is used for those builds as well. It would be nice to port this to lcitool but for now this will do. Signed-off-by: Alex

Re: [PATCH v2 29/30] tests/docker: remove FROM qemu/ support from docker.py

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: We want to migrate from docker.py to building our images directly with docker/podman. Before we get there we need to make sure we don't re-introduce our layered builds so bug out if we see FROM qemu/ in a Dockerfile. Signed-off-by: Alex Bennée Acked-by:

Re: [PATCH v2 21/30] Deprecate 32 bit big-endian MIPS

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: It's becoming harder to maintain a cross-compiler to test this host architecture as the old stable Debian 10 ("Buster") moved into LTS which supports fewer architectures. For now: - mark it's deprecation in the docs - downgrade the containers to build

[PATCH v6 0/2] Enable notify VM exit

2022-09-15 Thread Chenyi Qiang
Notify VM exit is introduced to mitigate the potential DOS attach from malicious VM. This series is the userspace part to enable this feature through a new KVM capability KVM_CAP_X86_NOTIFY_VMEXIT. The detailed info can be seen in Patch 3. The corresponding KVM support can be found in linux

[PATCH v3 0/2] Update linux headers to v6.0-rc4 and fix the clang build error

2022-09-15 Thread Chenyi Qiang
After updating linux headers to v6.0-rc, clang build on x86 target would generate warnings related to -Wgnu-variable-sized-type-not-at-end. Simply turn off this warning in this patch set. --- Change logs v2 -> v3 - A minor modification in commit message. (Cornelia Huck) - v2:

Re: [PATCH v2 22/30] tests/docker: flatten debian-riscv64-test-cross

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: Flatten into a single dockerfile and update to match the rest of the test cross compile dockerfiles. Signed-off-by: Alex Bennée Message-Id:<20220826172128.353798-17-alex.ben...@linaro.org> --- v2 - minor reword of commit msg ---

Re: [PATCH v2 18/30] configure: explicitly set cflags for --disable-pie

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: This is working around current limitation of Meson's handling of --disable-pie. Signed-off-by: Alex Bennée Cc: Paolo Bonzini --- configure | 6 ++ 1 file changed, 6 insertions(+) Ah, yes, thanks. Reviewed-by: Richard Henderson r~

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-15 Thread Claudio Fontana
On 9/8/22 20:30, Claudio Fontana wrote: > improve error handling during module load, by changing: > > bool module_load_one(const char *prefix, const char *lib_name); > void module_load_qom_one(const char *type); > > to: > > bool module_load_one(const char *prefix, const char *name, Error

Re: [PATCH v2 05/30] tests/avocado: add explicit timeout for ppc64le TCG tests

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: We don't want to rely on the soon to be reduced default time. These tests are still slow for something we want to run in CI though. Signed-off-by: Alex Bennée --- tests/avocado/boot_linux.py | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Richard

Re: [PATCH v2 07/30] tests/avocado: reduce the default timeout to 120s

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: We should be aiming to keep our tests under 2 minutes so lets reduce the default timeout to that. Tests that we know take longer should explicitly set a longer timeout. Signed-off-by: Alex Bennée Message-Id:<20220826172128.353798-3-alex.ben...@linaro.org>

Re: [PATCH v2 28/30] tests/docker: update and flatten debian-toolchain

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: -FROM qemu/debian10 +FROM docker.io/library/debian:bullseye-slim I'd rather you be consistent about debian-11 instead of codename. Otherwise, Reviewed-by: Richard Henderson r~

Re: [RFC PATCH 4/4] hw/timer: convert mptimer access to attrs to derive cpu index

2022-09-15 Thread Richard Henderson
On 9/14/22 17:09, Alex Bennée wrote: This removes the hacks to deal with empty current_cpu. Signed-off-by: Alex Bennée --- hw/timer/arm_mptimer.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/timer/arm_mptimer.c b/hw/timer/arm_mptimer.c

Re: [PATCH v2 06/30] tests/avocado: split the AST2x00Machine classes

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: The SDK tests take a lot longer to run and hence need a longer timeout. As they run well over the 60 second maximum for CI lets also disable them for CI as well. I suspect they also suffer from the inability to detect the login prompt due to no newlines

Re: [PATCH v2 03/30] tests/avocado: add explicit timeout for Aarch64 TCG tests

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: We don't want to rely on the soon to be reduced default time. These tests are still slow for something we want to run in CI though. Signed-off-by: Alex Bennée --- tests/avocado/boot_linux.py | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard

Re: [RFC PATCH 1/4] hw: encode accessing CPU index in MemTxAttrs

2022-09-15 Thread Richard Henderson
On 9/14/22 17:09, Alex Bennée wrote: @@ -1340,8 +1340,13 @@ static uint64_t io_readx(CPUArchState *env, CPUIOTLBEntry *iotlbentry, uint64_t val; bool locked = false; MemTxResult r; +MemTxAttrs attrs = iotlbentry->attrs; -section = iotlb_to_section(cpu,

Re: [PATCH v2 01/30] gitlab: reduce targets in cross_user_build_job

2022-09-15 Thread Richard Henderson
On 9/14/22 16:59, Alex Bennée wrote: We already limit the scope of the cross system build to reduce the cross build times. With the recent addition of more targets we are also running into timeout issues for some of the cross user builds. I've selected a few of those linux-user targets which

Re: [RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-15 Thread Richard Henderson
On 9/14/22 17:09, Alex Bennée wrote: Now that MxTxAttrs encodes a CPU we should use that to figure it out. This solves edge cases like accessing via gdbstub or qtest. Signed-off-by: Alex Bennée Resolves: https://gitlab.com/qemu-project/qemu/-/issues/124 --- hw/intc/arm_gic.c | 39

Re: [PATCH v9 1/7] include: add zoned device structs

2022-09-15 Thread Eric Blake
On Sat, Sep 10, 2022 at 01:27:53PM +0800, Sam Li wrote: > Signed-off-by: Sam Li > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Damien Le Moal > --- > include/block/block-common.h | 43 > 1 file changed, 43 insertions(+) > > diff --git

Re: [RFC PATCH 2/4] qtest: make read/write operation appear to be from CPU

2022-09-15 Thread Richard Henderson
On 9/14/22 17:09, Alex Bennée wrote: The point of qtest is to simulate how running code might interact with the system. However because it's not a real system we have places in the code which especially handle check qtest_enabled() before referencing current_cpu. Now we can encode these details

Re: [PATCH v2 15/30] tests/docker: remove tricore qemu/debian10 dependency

2022-09-15 Thread Thomas Huth
On 14/09/2022 16.59, Alex Bennée wrote: We missed removing this dependency when we flattened the build. Fixes: 39ce923732 (gitlab: enable a very minimal build with the tricore container) Signed-off-by: Alex Bennée Fixes: 39ce923732 ("gitlab: enable a very minimal build with the tricore

Re: [PATCH v2 20/30] gitlab-ci: update aarch32/aarch64 custom runner jobs

2022-09-15 Thread Thomas Huth
On 14/09/2022 16.59, Alex Bennée wrote: The custom runner is now using 22.04 so we can drop our hacks to deal with broken libssh and glusterfs. The provisioning scripts will be updated in a separate commit. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id:

Re: [PATCH v2 19/30] gitlab-ci/custom-runners: Disable -static-pie for ubuntu-20.04-aarch64

2022-09-15 Thread Thomas Huth
On 14/09/2022 16.59, Alex Bennée wrote: From: Richard Henderson The project has reached the magic size at which we see /usr/aarch64-linux-gnu/lib/libc.a(init-first.o): in function `__libc_init_first': (.text+0x10): relocation truncated to fit: R_AARCH64_LD64_GOTPAGE_LO15 against \ symbol

Re: [PATCH 30/37] target/i386: reimplement 0x0f 0x10-0x17, add AVX

2022-09-15 Thread Richard Henderson
On 9/14/22 23:45, Paolo Bonzini wrote: You've just been moving i64 pieces in the other functions, why is this one different using a gvec move in the middle? I do wonder if a generic helper moving offset->offset, with the comparison wouldn't be helpful within these functions, even when you

Re: [PATCH 28/37] target/i386: reimplement 0x0f 0x38, add AVX

2022-09-15 Thread Richard Henderson
On 9/14/22 18:04, Paolo Bonzini wrote: +void glue(helper_vpgatherdd, SUFFIX)(CPUX86State *env, +Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale) +{ +int i; +for (i = 0; i < (2 << SHIFT); i++) { +if (v->L(i) >> 31) { +target_ulong addr = a0 +

Re: [PATCH 27/37] target/i386: Use tcg gvec ops for pmovmskb

2022-09-15 Thread Richard Henderson
On 9/14/22 23:59, Paolo Bonzini wrote: On Tue, Sep 13, 2022 at 10:17 AM Richard Henderson wrote: On 9/12/22 00:04, Paolo Bonzini wrote: +while (vec_len > 8) { +vec_len -= 8; +tcg_gen_shli_tl(s->T0, s->T0, 8); +tcg_gen_ld8u_tl(t, cpu_env, offsetof(CPUX86State,

Re: [PATCH 1/1] s390x/tcg: Fix opcode for lzrf

2022-09-15 Thread Thomas Huth
On 14/09/2022 11.57, Christian Borntraeger wrote: Fix the opcode for Load and Zero Rightmost Byte (32). Cc: qemu-sta...@nongnu.org Reported-by: Nathan Chancellor Tested-by: Nathan Chancellor Signed-off-by: Christian Borntraeger --- target/s390x/tcg/insn-data.def | 2 +- 1 file changed, 1

<    1   2