Re: [PATCH 0/1] hw/display: expose linear framebuffer address in Bochs VBE registers

2022-09-21 Thread Gerd Hoffmann
Hi, > > Why not just use virtio-gpu? > > Trying to run this command: > qemu-system-x86_64 -M microvm -m 2048 -device virtio-gpu '-device virtio-gpu-device' Might also need '-global virtio-mmio.force-legacy=false' to switch virtio-mmio into 1.0 mode. take care, Gerd

Re: [PATCH v1 3/3] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

2022-09-21 Thread Markus Armbruster
"Kasireddy, Vivek" writes: > Hi Markus, > > Thank you for the review. > >> Vivek Kasireddy writes: >> >> > The new parameter named "connector" can be used to assign physical >> > monitors/connectors to individual GFX VCs such that when the monitor >> > is connected or hotplugged, the

Re: [PATCH v1 01/10] monitor: expose monitor_puts to rest of code

2022-09-21 Thread Markus Armbruster
Alex Bennée writes: > This helps us construct strings elsewhere before echoing to the > monitor. It avoids having to jump through hoops like: > > monitor_printf(mon, "%s", s->str); > > It will be useful in following patches but for now convert all > existing plain "%s" printfs to use the _puts

Re: [PATCH v2 26/39] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled

2022-09-21 Thread Bin Meng
On Thu, Sep 22, 2022 at 5:54 AM Marc-André Lureau wrote: > > Hi > > On Tue, Sep 20, 2022 at 3:18 PM Bin Meng wrote: >> >> From: Xuzhou Cheng >> >> Make sure QEMU process "to" exited before launching another target >> for migration in the test_multifd_tcp_cancel case. >> >> Signed-off-by: Xuzhou

Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32

2022-09-21 Thread Bin Meng
On Thu, Sep 22, 2022 at 1:23 AM Daniel P. Berrangé wrote: > > On Wed, Sep 21, 2022 at 05:51:33PM +0100, Dr. David Alan Gilbert wrote: > > * Bin Meng (bmeng...@gmail.com) wrote: > > > From: Bin Meng > > > > > > Some migration test cases use TLS to communicate, but they fail on > > > Windows with

Re: [PATCH v3 0/5] hw/arm/virt: Improve address assignment for high memory regions

2022-09-21 Thread Zhenyu Zhang
[PATCH v3 0/5] hw/arm/virt: Improve address assignment for high memory regions Author: Gavin Shan Date: Thu Sep 22 07:13:45 2022 +0800 PATCH[1-3] preparatory work for the improvment PATCH[4] improve high memory region address assignment PATCH[5] adds 'highmem-compact' to enable

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-21 Thread Jason Wang
On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz wrote: > > If I read your response on the other thread correctly, this change is intended > > to prioritize the MAC address exposed by DPDK over the one provided by the > > QEMU command line? Sounds reasonable in principle, but I would get >

Re: [PATCH] Revert "intel_iommu: Fix irqchip / X2APIC configuration checks"

2022-09-21 Thread Jason Wang
On Thu, Sep 22, 2022 at 12:12 AM Peter Xu wrote: > > It's true that when vcpus<=255 we don't require the length of 32bit APIC > IDs. However here since we already have EIM=ON it means the hypervisor > will declare the VM as x2apic supported (e.g. VT-d ECAP register will have > EIM bit 4 set), so

Re: [PATCH v3 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

2022-09-21 Thread Robert Hoo
On Wed, 2022-09-21 at 15:29 +0200, Igor Mammedov wrote: > On Tue, 20 Sep 2022 20:28:31 +0800 > Robert Hoo wrote: > > > On Tue, 2022-09-20 at 11:13 +0200, Igor Mammedov wrote: > > > On Fri, 16 Sep 2022 21:15:35 +0800 > > > Robert Hoo wrote: > > > > > > > On Fri, 2022-09-16 at 09:37 +0200,

[PATCH] hw/net: npcm7xx_emc: set MAC in register space

2022-09-21 Thread Patrick Venture
The MAC address set from Qemu wasn't being saved into the register space. Reviewed-by: Hao Wu Signed-off-by: Patrick Venture --- hw/net/npcm7xx_emc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/net/npcm7xx_emc.c b/hw/net/npcm7xx_emc.c index 7c86bb52e5..6be1008529

Re: [PATCH v2 13/23] target/i386: Introduce DISAS_JUMP

2022-09-21 Thread Richard Henderson
On 9/21/22 12:28, Paolo Bonzini wrote: On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson wrote: Drop the unused dest argument to gen_jr(). Remove most of the calls to gen_jr, and use DISAS_JUMP. Remove some unused loads of eip for lcall and ljmp. The only use outside i386_tr_tb_stop is

[PATCH v3 3/5] hw/arm/virt: Introduce variable region_base in virt_set_high_memmap()

2022-09-21 Thread Gavin Shan
This introduces variable 'region_base' for the base address of the specific high memory region. It's the preparatory work to optimize high memory region address assignment. No functional change intended. Signed-off-by: Gavin Shan --- hw/arm/virt.c | 12 ++-- 1 file changed, 6

[PATCH v3 5/5] hw/arm/virt: Add 'highmem-compact' property

2022-09-21 Thread Gavin Shan
After the improvement to high memory region address assignment is applied, the memory layout is changed. For example, VIRT_HIGH_PCIE_MMIO memory region is enabled when the improvement is applied, but it's disabled if the improvement isn't applied. pa_bits = 40;

[PATCH v3 1/5] hw/arm/virt: Introduce virt_set_high_memmap() helper

2022-09-21 Thread Gavin Shan
This introduces virt_set_high_memmap() helper. The logic of high memory region address assignment is moved to the helper. The intention is to make the subsequent optimization for high memory region address assignment easier. No functional change intended. Signed-off-by: Gavin Shan ---

[PATCH v3 4/5] hw/arm/virt: Improve high memory region address assignment

2022-09-21 Thread Gavin Shan
There are three high memory regions, which are VIRT_HIGH_REDIST2, VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses are floating on highest RAM address. However, they can be disabled in several cases. (1) One specific high memory region is disabled by developer by toggling

[PATCH v3 2/5] hw/arm/virt: Rename variable size to region_size in virt_set_high_memmap()

2022-09-21 Thread Gavin Shan
This renames variable 'size' to 'region_size' in virt_set_high_memmap(). Its counterpart ('region_base') will be introduced in next patch. No functional change intended. Signed-off-by: Gavin Shan --- hw/arm/virt.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff

[PATCH v3 0/5] hw/arm/virt: Improve address assignment for high memory regions

2022-09-21 Thread Gavin Shan
There are three high memory regions, which are VIRT_HIGH_REDIST2, VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses are floating on highest RAM address. However, they can be disabled in several cases. (1) One specific high memory region is disabled by developer by toggling

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-21 Thread Si-Wei Liu
On 9/16/2022 6:45 AM, Eugenio Perez Martin wrote: On Wed, Sep 14, 2022 at 5:44 PM Si-Wei Liu wrote: On 9/14/2022 2:57 PM, Eugenio Perez Martin wrote: On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: On 9/14/2022 3:20 AM, Jason Wang wrote: On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez

RE: [PATCH v1 3/3] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

2022-09-21 Thread Kasireddy, Vivek
Hi Markus, Thank you for the review. > Vivek Kasireddy writes: > > > The new parameter named "connector" can be used to assign physical > > monitors/connectors to individual GFX VCs such that when the monitor > > is connected or hotplugged, the associated GTK window would be > > fullscreened

Re: [PATCH v2 26/39] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled

2022-09-21 Thread Marc-André Lureau
Hi On Tue, Sep 20, 2022 at 3:18 PM Bin Meng wrote: > From: Xuzhou Cheng > > Make sure QEMU process "to" exited before launching another target > for migration in the test_multifd_tcp_cancel case. > > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng > Reviewed-by: Marc-André Lureau >

Re: [PATCH v8 1/8] mm/memfd: Introduce userspace inaccessible memfd

2022-09-21 Thread Andy Lutomirski
(please excuse any formatting disasters. my internet went out as I was composing this, and i did my best to rescue it.) On Mon, Sep 19, 2022, at 12:10 PM, Sean Christopherson wrote: > +Will, Marc and Fuad (apologies if I missed other pKVM folks) > > On Mon, Sep 19, 2022, David Hildenbrand

Re: [PATCH RESEND] hw/microblaze: pass random seed to fdt

2022-09-21 Thread Edgar E. Iglesias
On Wed, Sep 21, 2022 at 12:32:37PM +0200, Jason A. Donenfeld wrote: > On Thu, Sep 8, 2022 at 11:40 AM Jason A. Donenfeld wrote: > > > > If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to > > initialize early. Set this using the usual guest random number > > generation

[PULL v1 0/1] Xilinx queue

2022-09-21 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit 2906f933dd1de6d94c54881cc16ea7390a6ba300: Merge tag 'pull-request-2022-09-20' of https://gitlab.com/thuth/qemu into staging (2022-09-20 16:24:07 -0400) are available in the Git repository at: g...@github.com:edgarigl/qemu.git

[PULL v1 1/1] hw/microblaze: pass random seed to fdt

2022-09-21 Thread Edgar E. Iglesias
From: "Jason A. Donenfeld" If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to initialize early. Set this using the usual guest random number generation function. This FDT node is part of the DT specification. Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason A. Donenfeld

Re: [PATCH v4 2/7] accel/tcg: Use DisasContextBase in plugin_gen_tb_start

2022-09-21 Thread Alex Bennée
Richard Henderson writes: > Use the pc coming from db->pc_first rather than the TB. > > Use the cached host_addr rather than re-computing for the > first page. We still need a separate lookup for the second > page because it won't be computed for DisasContextBase until > the translator

Re: [PATCH v4 1/7] accel/tcg: Use bool for page_find_alloc

2022-09-21 Thread Alex Bennée
Richard Henderson writes: > Bool is more appropriate type for the alloc parameter. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PULL 00/17] ppc queue

2022-09-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/5] M68k for 7.2 patches

2022-09-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-21 Thread Michael S. Tsirkin
On Wed, Sep 21, 2022 at 07:23:12PM +0100, Alex Bennée wrote: > > chenh writes: > > > From: Hao Chen > > > > When use dpdk-vdpa tests vdpa device. You need to specify the mac address to > > start the virtual machine through libvirt or qemu, but now, the libvirt or > > qemu can call dpdk vdpa

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-21 Thread Alex Bennée
chenh writes: > From: Hao Chen > > When use dpdk-vdpa tests vdpa device. You need to specify the mac address to > start the virtual machine through libvirt or qemu, but now, the libvirt or > qemu can call dpdk vdpa vendor driver's ops .get_config through > vhost_net_get_config > to get the

Re: [PATCH 0/1] hw/display: expose linear framebuffer address in Bochs VBE registers

2022-09-21 Thread Liav Albani
On 9/21/22 09:14, Gerd Hoffmann wrote: Nope. Even if you fix the framebuffer address conflict you still have the io address conflict. Yeah, that is why I explicitly said that this is needed to be fixed as well in later patches. Yep. That's why isa-pc is pretty much unused these days.

Re: [PULL 00/12] Publish1 patches

2022-09-21 Thread Philippe Mathieu-Daudé via
Hi Helge, On 20/9/22 19:31, Helge Deller wrote: The following changes since commit 621da7789083b80d6f1ff1c0fb499334007b4f51: Update version for v7.1.0 release (2022-08-30 09:40:11 -0700) are available in the Git repository at: https://github.com/hdeller/qemu-hppa.git

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-21 Thread Raphael Norwitz
If I read your response on the other thread correctly, this change is intended to prioritize the MAC address exposed by DPDK over the one provided by the QEMU command line? Sounds reasonable in principle, but I would get confirmation from vDPA/vhost-net maintainers. That said the way you’re

Re: [PATCH v2 02/23] target/i386: Return bool from disas_insn

2022-09-21 Thread Philippe Mathieu-Daudé via
On 8/9/22 14:14, Richard Henderson wrote: On 9/6/22 15:42, Philippe Mathieu-Daudé wrote: On 6/9/22 12:09, Richard Henderson wrote: Instead of returning the new pc, which is present in DisasContext, return true if an insn was translated. This is false when we detect a page crossing and must

Re: [PATCH v1 06/10] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr

2022-09-21 Thread Philippe Mathieu-Daudé via
On 21/9/22 18:07, Alex Bennée wrote: From: Richard Henderson Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx. Fixes: Coverity CID 1487201 Signed-off-by: Richard Henderson Reviewed-by: Damien Hedde Message-Id:

Re: [PATCH v1 07/10] docs/devel: clean-up qemu invocations in tcg-plugins

2022-09-21 Thread Philippe Mathieu-Daudé via
On 21/9/22 18:07, Alex Bennée wrote: We currently have the final binaries in the root of the build dir so the build prefix is superfluous. Additionally add a shell prompt to be more in line with the rest of the code. Signed-off-by: Alex Bennée --- docs/devel/tcg-plugins.rst | 18

Re: [PATCH v1 08/10] docs/devel: move API to end of tcg-plugins.rst

2022-09-21 Thread Philippe Mathieu-Daudé via
On 21/9/22 18:07, Alex Bennée wrote: The API documentation is quite dry and doesn't flow nicely with the rest of the document. Move it to its own section at the bottom along with a little leader text to remind people to update it. Signed-off-by: Alex Bennée --- docs/devel/tcg-plugins.rst |

Re: [PATCH v1 09/10] contrib/plugins: reset skip when matching in execlog

2022-09-21 Thread Philippe Mathieu-Daudé via
On 21/9/22 18:08, Alex Bennée wrote: The purpose of the matches was to only track the execution of instructions we care about. Without resetting skip to the value at the start of the block we end up dumping all instructions after the match with the consequent load on the instrumentation.

Re: [PATCH v1 03/10] disas: use result of ->read_memory_func

2022-09-21 Thread Philippe Mathieu-Daudé via
On 21/9/22 18:07, Alex Bennée wrote: This gets especially confusing if you start plugging in host addresses from a trace and you wonder why the output keeps changing. Report when read_memory_func fails instead of blindly disassembling the buffer contents. Signed-off-by: Alex Bennée

Re: [PULL 00/15] Testing, qga and misc patches

2022-09-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v1 01/10] monitor: expose monitor_puts to rest of code

2022-09-21 Thread Philippe Mathieu-Daudé via
On 21/9/22 18:07, Alex Bennée wrote: This helps us construct strings elsewhere before echoing to the monitor. It avoids having to jump through hoops like: monitor_printf(mon, "%s", s->str); It will be useful in following patches but for now convert all existing plain "%s" printfs to use the

Re: [PULL 00/21] Misc patches for 2022-09-19

2022-09-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32

2022-09-21 Thread Daniel P . Berrangé
On Wed, Sep 21, 2022 at 05:51:33PM +0100, Dr. David Alan Gilbert wrote: > * Bin Meng (bmeng...@gmail.com) wrote: > > From: Bin Meng > > > > Some migration test cases use TLS to communicate, but they fail on > > Windows with the following error messages: > > > > qemu-system-x86_64: TLS

Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32

2022-09-21 Thread Dr. David Alan Gilbert
* Bin Meng (bmeng...@gmail.com) wrote: > From: Bin Meng > > Some migration test cases use TLS to communicate, but they fail on > Windows with the following error messages: > > qemu-system-x86_64: TLS handshake failed: Insufficient credentials for that > request. > qemu-system-x86_64: TLS

Re: [PATCH v2 26/39] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled

2022-09-21 Thread Daniel P . Berrangé
On Wed, Sep 21, 2022 at 05:29:55PM +0100, Dr. David Alan Gilbert wrote: > * Bin Meng (bmeng...@gmail.com) wrote: > > From: Xuzhou Cheng > > > > Make sure QEMU process "to" exited before launching another target > > for migration in the test_multifd_tcp_cancel case. > > > > Signed-off-by: Xuzhou

[PATCH v1 09/10] contrib/plugins: reset skip when matching in execlog

2022-09-21 Thread Alex Bennée
The purpose of the matches was to only track the execution of instructions we care about. Without resetting skip to the value at the start of the block we end up dumping all instructions after the match with the consequent load on the instrumentation. Signed-off-by: Alex Bennée Cc: Alexandre

Re: [PATCH v2 26/39] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled

2022-09-21 Thread Dr. David Alan Gilbert
* Bin Meng (bmeng...@gmail.com) wrote: > From: Xuzhou Cheng > > Make sure QEMU process "to" exited before launching another target > for migration in the test_multifd_tcp_cancel case. > > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng > Reviewed-by: Marc-André Lureau Hmm you might

[PATCH] Revert "intel_iommu: Fix irqchip / X2APIC configuration checks"

2022-09-21 Thread Peter Xu
It's true that when vcpus<=255 we don't require the length of 32bit APIC IDs. However here since we already have EIM=ON it means the hypervisor will declare the VM as x2apic supported (e.g. VT-d ECAP register will have EIM bit 4 set), so the guest should assume the APIC IDs are 32bits width even

[PATCH v1 10/10] docs/devel: document the test plugins

2022-09-21 Thread Alex Bennée
Although the test plugins are fairly basic they are still useful for some things so we should document their existence. Signed-off-by: Alex Bennée --- docs/devel/tcg-plugins.rst | 137 +++-- 1 file changed, 133 insertions(+), 4 deletions(-) diff --git

[PATCH v1 07/10] docs/devel: clean-up qemu invocations in tcg-plugins

2022-09-21 Thread Alex Bennée
We currently have the final binaries in the root of the build dir so the build prefix is superfluous. Additionally add a shell prompt to be more in line with the rest of the code. Signed-off-by: Alex Bennée --- docs/devel/tcg-plugins.rst | 18 +- 1 file changed, 9 insertions(+),

[PATCH v1 06/10] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr

2022-09-21 Thread Alex Bennée
From: Richard Henderson Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx. Fixes: Coverity CID 1487201 Signed-off-by: Richard Henderson Reviewed-by: Damien Hedde Message-Id:

[PATCH v1 05/10] plugins: extend execlog to filter matches

2022-09-21 Thread Alex Bennée
Sometimes the whole execlog is just two much so add the ability to filter by instruction opcode or address. [AJB: this shows for example .qemu-system-aarch64 -display none -serial mon:stdio \ -M virt -cpu max \ -semihosting-config enable=on \ -kernel

[PATCH v1 02/10] disas: generalise plugin_printf and use for monitor_disas

2022-09-21 Thread Alex Bennée
Rather than assembling our output piecemeal lets use the same approach as the plugin disas interface to build the disassembly string before printing it. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- disas.c | 23 +++ 1 file changed, 15 insertions(+), 8

[PATCH v1 08/10] docs/devel: move API to end of tcg-plugins.rst

2022-09-21 Thread Alex Bennée
The API documentation is quite dry and doesn't flow nicely with the rest of the document. Move it to its own section at the bottom along with a little leader text to remind people to update it. Signed-off-by: Alex Bennée --- docs/devel/tcg-plugins.rst | 15 ++- 1 file changed, 10

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-21 Thread Claudio Fontana
On 9/21/22 14:16, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 16/9/22 11:27, Markus Armbruster wrote: >>> Claudio Fontana writes: >>> improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name);

[PATCH v1 04/10] tests/tcg: add memory-sve test for aarch64

2022-09-21 Thread Alex Bennée
This will be helpful in debugging problems with tracking SVE memory accesses via the TCG plugins system. Signed-off-by: Alex Bennée Cc: Robert Henry Cc: Aaron Lindsay --- tests/tcg/aarch64/Makefile.softmmu-target | 7 +++ tests/tcg/aarch64/system/boot.S | 3 ++- 2 files changed,

[PATCH v1 03/10] disas: use result of ->read_memory_func

2022-09-21 Thread Alex Bennée
This gets especially confusing if you start plugging in host addresses from a trace and you wonder why the output keeps changing. Report when read_memory_func fails instead of blindly disassembling the buffer contents. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- disas.c

[PATCH v1 00/10] plugins/next (disas, monitor, docs, execlog)

2022-09-21 Thread Alex Bennée
Hi, It has been a while since I last posted the state of my plugins queue. These are mostly small cleanups and documentation tweaks. I also did a little bit of tidying up in the disas interface. The following still need review: - docs/devel: document the test plugins - contrib/plugins: reset

[PATCH v1 01/10] monitor: expose monitor_puts to rest of code

2022-09-21 Thread Alex Bennée
This helps us construct strings elsewhere before echoing to the monitor. It avoids having to jump through hoops like: monitor_printf(mon, "%s", s->str); It will be useful in following patches but for now convert all existing plain "%s" printfs to use the _puts api. Signed-off-by: Alex Bennée

[PULL 4/5] target/m68k: rename M68K_FEATURE_M68000 to M68K_FEATURE_M68K

2022-09-21 Thread Laurent Vivier
From: Mark Cave-Ayland The M68K_FEATURE_M68000 feature is misleading in that its name suggests the feature is defined just for Motorola 68000 CPUs, whilst in fact it is defined for all Motorola 680X0 CPUs. In order to avoid confusion with the other M68K_FEATURE_M680X0 constants which define

[PULL 5/5] target/m68k: always call gen_exit_tb() after writes to SR

2022-09-21 Thread Laurent Vivier
From: Mark Cave-Ayland Any write to SR can change the security state so always call gen_exit_tb() when this occurs. In particular MacOS makes use of andiw/oriw in a few places to handle the switch between user and supervisor mode. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson

[PULL 0/5] M68k for 7.2 patches

2022-09-21 Thread Laurent Vivier
-pull-request for you to fetch changes up to c7546abfaa1b1c2729eaddd41c6268a73cdae14f: target/m68k: always call gen_exit_tb() after writes to SR (2022-09-21 15:10:57 +0200) m68k pull request 20220921 - several fixes for SR

[PULL 3/5] target/m68k: Perform writback before modifying SR

2022-09-21 Thread Laurent Vivier
From: Richard Henderson Writes to SR may change security state, which may involve a swap of %ssp with %usp as reflected in %a7. Finish the writeback of %sp@+ before swapping stack pointers. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1206 Signed-off-by: Richard Henderson

[PULL 2/5] target/m68k: Fix MACSR to CCR

2022-09-21 Thread Laurent Vivier
From: Richard Henderson First, we were writing to the entire SR register, instead of only the flags portion. Second, we were not clearing C as per the documentation (X was cleared via the 0xf mask). Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id:

[PULL 1/5] target/m68k: Implement atomic test-and-set

2022-09-21 Thread Laurent Vivier
From: Richard Henderson This is slightly more complicated than cas, because tas is allowed on data registers. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20220829051746.227094-1-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

Re: [RFC 4/4] tcg/plugins: Add example pair of QPP plugins

2022-09-21 Thread Alex Bennée
Andrew Fasano writes: > The first plugin, qpp_srv exposes two functions and one callback that other > plugins can leverage. These functions are described in the corresponding > header file. > > The second plugin, qpp_client, imports this header file, registers its > own function to run on a

Re: [PATCH] add keepalive for qemu-nbd

2022-09-21 Thread Denis V. Lunev
On 9/21/22 10:36, songlinfeng wrote: From: songlinfeng we want to export a image with qemu-nbd as server, in client we use libnbd to connect qemu-nbd,but when client power down,the server is still working. qemu-nbd will exit when last client exit.so,we still want server exit when client

Re: [RFC 4/4] tcg/plugins: Add example pair of QPP plugins

2022-09-21 Thread Alex Bennée
Andrew Fasano writes: > The first plugin, qpp_srv exposes two functions and one callback that other > plugins can leverage. These functions are described in the corresponding > header file. > > The second plugin, qpp_client, imports this header file, registers its > own function to run on a

Re: [PATCH v8 12/14] qemu-sockets: update socket_uri() and socket_parse() to be consistent

2022-09-21 Thread Markus Armbruster
Laurent Vivier writes: > To be consistent with socket_uri(), add 'tcp:' prefix for inet type in > socket_parse(), by default socket_parse() use tcp when no prefix is > provided (format is host:port). > > In socket_uri(), use 'vsock:' prefix for vsock type rather than 'tcp:' > because it makes a

Re: [PATCH v8 13/14] net: stream: move to QIO

2022-09-21 Thread Markus Armbruster
Laurent Vivier writes: > Use QIOChannel, QIOChannelSocket and QIONetListener. > > Signed-off-by: Laurent Vivier > --- [...] > diff --git a/qemu-options.hx b/qemu-options.hx > index ee2436ae14a7..a0b5b70c80cb 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2732,8 +2732,8 @@

Re: [RFC 3/4] tcg/plugins: Support for inter-plugin interactions

2022-09-21 Thread Alex Bennée
Andrew Fasano writes: > Expand tcg-plugin system to allow for plugins to export functions > and callbacks that can be used by other plugins. Exported functions > can be called at runtime by other loaded plugins. Loaded plugins > can register functions with exported callbacks and have these >

Re: QEMU's FreeBSD 13 CI job is failing

2022-09-21 Thread Warner Losh
On Wed, Sep 21, 2022 at 1:13 AM Daniel P. Berrangé wrote: > On Tue, Sep 20, 2022 at 02:21:46PM -0600, Warner Losh wrote: > > On Tue, Sep 20, 2022 at 2:57 AM Daniel P. Berrangé > > wrote: > > > > > On Tue, Sep 20, 2022 at 10:23:56AM +0200, Thomas Huth wrote: > > > > On 20/09/2022 10.21, Daniel

Re: [PATCH v3 1/1] monitor/hmp: print trace as option in help for log command

2022-09-21 Thread Markus Armbruster
Dongli Zhang writes: > Hi Markus, > > On 9/17/22 2:44 PM, Philippe Mathieu-Daudé via wrote: >> Hi Markus, >> >> On 2/9/22 14:24, Markus Armbruster wrote: >>> Dongli Zhang writes: >>> The below is printed when printing help information in qemu-system-x86_64 command line, and when

Re: [PATCH] i386: Add new CPU model SapphireRapids

2022-09-21 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Sep 21, 2022 at 03:51:42PM +0100, Dr. David Alan Gilbert wrote: > > * Wang, Lei (lei4.w...@intel.com) wrote: > > > The new CPU model mostly inherits features from Icelake-Server, while > > > adding new features: > > > - AMX (Advance

Re: [PATCH] i386: Add new CPU model SapphireRapids

2022-09-21 Thread Daniel P . Berrangé
On Wed, Sep 21, 2022 at 03:51:42PM +0100, Dr. David Alan Gilbert wrote: > * Wang, Lei (lei4.w...@intel.com) wrote: > > The new CPU model mostly inherits features from Icelake-Server, while > > adding new features: > > - AMX (Advance Matrix eXtensions) > > - Bus Lock Debug Exception > > and new

Re: [PATCH] qga: fix possible memory leak

2022-09-21 Thread Markus Armbruster
luzhipeng writes: > From: lu zhipeng > > Signed-off-by: lu zhipeng > --- > qga/main.c | 19 ++- > 1 file changed, 14 insertions(+), 5 deletions(-) > > diff --git a/qga/main.c b/qga/main.c > index 5f1efa2333..73ea1aae65 100644 > --- a/qga/main.c > +++ b/qga/main.c > @@ -1287,7

Re: [PATCH RFC 0/7] hostmem: NUMA-aware memory preallocation using ThreadContext

2022-09-21 Thread David Hildenbrand
On 21.09.22 16:44, Michal Prívozník wrote: On 7/21/22 14:07, David Hildenbrand wrote: Ping? Is there any plan how to move forward? I have libvirt patches ready to consume this and I'd like to prune my old local branches :-) Heh, I was thinking about this series just today. I was distracted

[PATCH] qcow2: fix memory leak in qcow2_read_extensions

2022-09-21 Thread luzhipeng
From: lu zhipeng Free feature_table if it is failed in bdrv_pread. Signed-off-by: lu zhipeng --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index c6c6692fb7..c8fc3a6160 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -275,6 +275,7 @@

Re: [PATCH] i386: Add new CPU model SapphireRapids

2022-09-21 Thread Dr. David Alan Gilbert
* Wang, Lei (lei4.w...@intel.com) wrote: > The new CPU model mostly inherits features from Icelake-Server, while > adding new features: > - AMX (Advance Matrix eXtensions) > - Bus Lock Debug Exception > and new instructions: > - AVX VNNI (Vector Neural Network Instruction): > - VPDPBUS:

Re: [PATCH RFC 0/7] hostmem: NUMA-aware memory preallocation using ThreadContext

2022-09-21 Thread Michal Prívozník
On 7/21/22 14:07, David Hildenbrand wrote: > Ping? Is there any plan how to move forward? I have libvirt patches ready to consume this and I'd like to prune my old local branches :-) Michal

[PATCH] add keepalive for qemu-nbd

2022-09-21 Thread songlinfeng
From: songlinfeng we want to export a image with qemu-nbd as server, in client we use libnbd to connect qemu-nbd,but when client power down,the server is still working. qemu-nbd will exit when last client exit.so,we still want server exit when client power down.maybe qmp can handle it,but i

Re: [PATCH v2] virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events.

2022-09-21 Thread Venu Busireddy
On 2022-09-21 16:33:35 +0200, Paolo Bonzini wrote: > On Fri, Sep 16, 2022 at 3:44 AM Venu Busireddy > wrote: > > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > > index 41f2a5630173..69194c7ae23c 100644 > > --- a/hw/scsi/virtio-scsi.c > > +++ b/hw/scsi/virtio-scsi.c > > @@ -608,7

Re: [PATCH v2] virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events.

2022-09-21 Thread Paolo Bonzini
On Fri, Sep 16, 2022 at 3:44 AM Venu Busireddy wrote: > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > index 41f2a5630173..69194c7ae23c 100644 > --- a/hw/scsi/virtio-scsi.c > +++ b/hw/scsi/virtio-scsi.c > @@ -608,7 +608,19 @@ static void virtio_scsi_command_complete(SCSIRequest *r,

Re: [PATCH v1 3/3] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

2022-09-21 Thread Markus Armbruster
Vivek Kasireddy writes: > The new parameter named "connector" can be used to assign physical > monitors/connectors to individual GFX VCs such that when the monitor > is connected or hotplugged, the associated GTK window would be > fullscreened on it. If the monitor is disconnected or unplugged,

[PATCH] try to find out which cluster allocated in qcow2

2022-09-21 Thread songlinfeng
In our project,we want to full backup a disk only allocated area,but qmp block-dity-block-add can create a bitmap with all zero,so we can't find out which cluster is allocated.in qcow2,I think l2_table can help me find out which cluster should be backup. Signed-off-by: songlinfeng ---

Re: [PATCH v2 00/23] target/i386: pc-relative translation blocks

2022-09-21 Thread Paolo Bonzini
Looks good! Just a couple weird parts of the architecture where I need some more explanation. Paolo On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson wrote: > > This is the x86 specific changes required to reduce the > amount of translation for address space randomization. > This is a re-base,

[PATCH] qga: fix possible memory leak

2022-09-21 Thread luzhipeng
From: lu zhipeng Signed-off-by: lu zhipeng --- qga/main.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/qga/main.c b/qga/main.c index 5f1efa2333..73ea1aae65 100644 --- a/qga/main.c +++ b/qga/main.c @@ -1287,7 +1287,7 @@ static GAState

Re: [PATCH v2 23/23] target/i386: Enable TARGET_TB_PCREL

2022-09-21 Thread Paolo Bonzini
On Tue, Sep 6, 2022 at 12:10 PM Richard Henderson wrote: > static void gen_update_eip_cur(DisasContext *s) > { > gen_jmp_im(s, s->base.pc_next - s->cs_base); > +s->pc_save = s->base.pc_next; s->pc_save is not valid after all gen_jmp_im() calls. Is it worth noting after each call to

Re: [RFC 2/4] tcg/plugins: Automatically define CURRENT_PLUGIN

2022-09-21 Thread Alex Bennée
Andrew Fasano writes: > Use plugin filenames to set the preprocessor variable CURRENT_PLUGIN > as a string during plugin compilation. > > Signed-off-by: Andrew Fasano > --- > contrib/plugins/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [RFC 0/4] Support interactions between TCG plugins

2022-09-21 Thread Alex Bennée
Andrew Fasano writes: > Hello, > > I'm requesting comments on the following series of patches expanding the > TCG plugin system to add the "QEMU Plugin-to-Plugin (QPP)" interface > that allows for interactions between TCG plugins. The goal of this > interface is to enable plugins to expand on

Re: [PATCH 2/4] target/m68k: increase size of m68k CPU features from uint32_t to uint64_t

2022-09-21 Thread Laurent Vivier
Le 20/09/2022 à 18:30, Mark Cave-Ayland a écrit : On 17/09/2022 23:27, Philippe Mathieu-Daudé via wrote: On 17/9/22 14:09, BALATON Zoltan wrote: On Sat, 17 Sep 2022, Mark Cave-Ayland wrote: There are already 32 feature bits in use, so change the size of the m68k CPU features to uint64_t

Re: [PATCH v2 20/23] target/i386: Use gen_jmp_rel for gen_repz*

2022-09-21 Thread Paolo Bonzini
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson wrote: > > Subtract cur_insn_len to restart the current insn. > > Signed-off-by: Richard Henderson I wouldn't mind squashing this with the jecxz/loop patch (and the review comments there apply here too). Paolo > --- >

Re: [RFC 1/4] docs/tcg-plugins: describe QPP API

2022-09-21 Thread Alex Bennée
Andrew Fasano writes: > Describe how multiple TCG plugins can interact using the QEMU > Plugin-to-Plugin API (QPP) with both callbacks and direct > function calls. Looks ok at first glance. I suspect it is quickly coming to the point we need to split the examples and the API apart in the docs

Re: [PATCH v3 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

2022-09-21 Thread Igor Mammedov
On Tue, 20 Sep 2022 20:28:31 +0800 Robert Hoo wrote: > On Tue, 2022-09-20 at 11:13 +0200, Igor Mammedov wrote: > > On Fri, 16 Sep 2022 21:15:35 +0800 > > Robert Hoo wrote: > > > > > On Fri, 2022-09-16 at 09:37 +0200, Igor Mammedov wrote: > > > > > > > > Fine, get your point now. > > > > >

Re: [PATCH v2 18/23] target/i386: Use gen_jmp_rel for loop and jecxz insns

2022-09-21 Thread Paolo Bonzini
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson wrote: > > With gen_jmp_rel, we may chain to the next tb > instead of merely writing to eip and exiting. > > Signed-off-by: Richard Henderson See comment on the previous patch. Paolo > --- > target/i386/tcg/translate.c | 21

Re: [PATCH 13/14] migration: Remove old preempt code around state maintainance

2022-09-21 Thread Peter Xu
On Tue, Sep 20, 2022 at 08:47:20PM -0400, Peter Xu wrote: > On Tue, Sep 20, 2022 at 06:52:27PM -0400, Peter Xu wrote: > > With the new code to send pages in rp-return thread, there's little help to > > keep lots of the old code on maintaining the preempt state in migration > > thread, because the

Re: [PATCH v2] hw/acpi: Add ospm_status hook implementation for acpi-ged

2022-09-21 Thread Igor Mammedov
On Tue, 20 Sep 2022 14:15:36 +0100 Peter Maydell wrote: > On Wed, 24 Aug 2022 at 16:04, Igor Mammedov wrote: > > > > On Tue, 16 Aug 2022 17:49:57 +0800 > > Keqian Zhu wrote: > > > > > Setup an ARM virtual machine of machine virt and execute qmp > > > "query-acpi-ospm-status" > > > causes

Re: [PATCH 1/2] target/m68k: Fix MACSR to CCR

2022-09-21 Thread Laurent Vivier
Le 13/09/2022 à 16:28, Richard Henderson a écrit : First, we were writing to the entire SR register, instead of only the flags portion. Second, we were not clearing C as per the documentation (X was cleared via the 0xf mask). Signed-off-by: Richard Henderson --- target/m68k/translate.c | 6

Re: [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR

2022-09-21 Thread Laurent Vivier
Le 17/09/2022 à 13:25, Mark Cave-Ayland a écrit : Any write to SR can change the security state so always call gen_exit_tb() when this occurs. In particular MacOS makes use of andiw/oriw in a few places to handle the switch between user and supervisor mode. Signed-off-by: Mark Cave-Ayland ---

Re: [PATCH v2 19/23] target/i386: Use gen_jmp_rel for gen_jcc

2022-09-21 Thread Paolo Bonzini
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson wrote: > -static inline void gen_jcc(DisasContext *s, int b, > - target_ulong val, target_ulong next_eip) > +static void gen_jcc(DisasContext *s, MemOp ot, int b, int diff) > { > -TCGLabel *l1, *l2; > +TCGLabel

  1   2   >