On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Create a common helper for pc-relative branches.
> The jmp jb insn was missing a mask for CODE32.
>
> Signed-off-by: Richard Henderson
(Oops, my remark the previous patch should still have pointed to gen_jmp_tb).
In
Claudio Fontana writes:
> Hi Markus, sorry for the harsh response last week, it comes from a position
> of lack of time,
> and the expectation that Richard's review would be enough.
I gladly accept your apology.
We had the good fortune to meet in person (at KVM Forums before the
plague).
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> With gen_jmp_rel, we may chain between two translation blocks
> which may only be separated because of TB size limits.
>
> Signed-off-by: Richard Henderson
> ---
> target/i386/tcg/translate.c | 3 +++
> 1 file changed, 3 insertions(+)
Le 13/09/2022 à 16:28, Richard Henderson a écrit :
Writes to SR may change security state, which may involve
a swap of %ssp with %usp as reflected in %a7. Finish the
writeback of %sp@+ before swapping stack pointers.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1206
Signed-off-by:
Le 17/09/2022 à 13:25, Mark Cave-Ayland a écrit :
The M68K_FEATURE_M68000 feature is misleading in that its name suggests the
feature
is defined just for Motorola 68000 CPUs, whilst in fact it is defined for all
Motorola 680X0 CPUs.
In order to avoid confusion with the other
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> We can set is_jmp early, using only one if, and let that
> be overwritten by gen_repz_* etc.
Perhaps "be overwritten by gen_rep*'s calls to gen_jmp_rel". Code-wise,
Reviewed-by: Paolo Bonzini
Paolo
>
> Signed-off-by: Richard
Le 29/08/2022 à 07:17, Richard Henderson a écrit :
This is slightly more complicated than cas,
because tas is allowed on data registers.
Signed-off-by: Richard Henderson
---
target/m68k/translate.c | 40 ++--
1 file changed, 30 insertions(+), 10
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/i386/tcg/translate.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
> index
Hi,
This is my attempt of converting MIPS translation code into decodetree.
Currently only MIPS I to MIPS Release 5 arithmatic functions are converted.
Old decoding functions are perserved in codebase for now due to dependencies
from microMIPS/nanoMIPS translation code. Will remove them after
Mostly copy paste from translate.c, with some simplification
based on newly introduced register access functions.
Signed-off-by: Jiaxun Yang
---
target/mips/tcg/insn_trans/trans_arith.c.inc | 352 +++
target/mips/tcg/legacy.decode| 62
Hi,
On Thu, Sep 8, 2022 at 9:28 PM Bin Meng wrote:
>
> At present packaging the required DLLs of QEMU executables is a
> manual process, and error prone.
>
> Improve scripts/nsis.py by adding a logic to automatically package
> required DLLs of QEMU executables.
>
> 'make installer' is tested in
Introduce register access functions with value extend capability
to prepare for decodetree based translation implmentation.
Signed-off-by: Jiaxun Yang
---
target/mips/tcg/translate.c | 143 +++-
target/mips/tcg/translate.h | 54 ++
2 files changed,
Philippe Mathieu-Daudé writes:
> On 16/9/22 11:27, Markus Armbruster wrote:
>> Claudio Fontana writes:
>>
>>> improve error handling during module load, by changing:
>>>
>>> bool module_load_one(const char *prefix, const char *lib_name);
>>> void module_load_qom_one(const char *type);
>>>
>>>
Those cases are delivered from MIPS internal architecture validation
tools.
Signed-off-by: Jiaxun Yang
---
tests/tcg/mips/include/test_utils_32.h| 75 +++
.../tcg/mips/user/isa/mips32/arithmatic/add.c | 99 ++
.../mips/user/isa/mips32/arithmatic/addi.c| 70
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Create helpers for loading the address of the next insn.
> Use tcg_constant_* in adjacent code where convenient.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Paolo Bonzini
> ---
> target/i386/tcg/translate.c | 44
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Use i32 not int or tl for eip and cs arguments.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Paolo Bonzini
> ---
> target/i386/helper.h | 2 +-
> target/i386/tcg/seg_helper.c | 6 ++
> target/i386/tcg/translate.c
On 15/09/2022 12:54, Thomas Huth wrote:
On 14/09/2022 13.41, Lucas Mateus Castro(alqotel) wrote:
From: "Lucas Mateus Castro (alqotel)"
ninja-build is missing from the RHEL environment, so a system prepared
with that script would still fail to compile QEMU.
Tested on a Fedora 36
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> All callers pass s->base.pc_next and s->pc, which we can just
> as well compute within the functions. Pull out common helpers
> and reduce the amount of code under macros.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Paolo
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Add a few DISAS_TARGET_* aliases to reduce the number of
> calls to gen_eob() and gen_eob_inhibit_irq(). So far,
> only update i386_tr_translate_insn for exiting the block
> because of single-step or previous inhibit irq.
>
>
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Drop the unused dest argument to gen_jr().
> Remove most of the calls to gen_jr, and use DISAS_JUMP.
> Remove some unused loads of eip for lcall and ljmp.
The only use outside i386_tr_tb_stop is here:
static void
-Original Message-
From: Philippe Mathieu-Daudé On Behalf Of
Philippe Mathieu-Daudé
Sent: Sunday, September 18, 2022 5:32 AM
To: Bin Meng ; qemu-devel@nongnu.org
Cc: Meng, Bin ; Hanna Reitz ; Kevin
Wolf ; Peter Lieven ; qemu-bl...@nongnu.org
Subject: Re: [PATCH 5/7] block/nfs: Fix
On Tue, Sep 6, 2022 at 4:50 PM Philippe Mathieu-Daudé wrote:
>
> On 6/9/22 12:09, Richard Henderson wrote:
> > Create common routines for computing the length of the insn.
> >
> > Signed-off-by: Richard Henderson
> > ---
> > target/i386/tcg/translate.c | 31 +++
> >
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Like gen_update_cc_op, sync EIP before doing something
> that could raise an exception. Replace all gen_jmp_im
> that use s->base.pc_next.
The commit message seems a bit off (it sounds like adding
stuff rather than refactoring), but
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Replace sequences of gen_update_cc_op, gen_update_eip_next,
> and gen_eob with the new is_jmp enumerator.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Paolo Bonzini
> ---
> target/i386/tcg/translate.c | 40
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Replace lone calls to gen_eob() with the new enumerator.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Paolo Bonzini
> ---
> target/i386/tcg/translate.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>
On 21/09/2022 14.18, Bin Meng wrote:
Hi,
On Thu, Sep 8, 2022 at 9:28 PM Bin Meng wrote:
At present packaging the required DLLs of QEMU executables is a
manual process, and error prone.
Improve scripts/nsis.py by adding a logic to automatically package
required DLLs of QEMU executables.
Am 21.09.2022 um 09:50 hat Claudio Fontana geschrieben:
> On 9/20/22 18:50, Kevin Wolf wrote:
> > Am 08.09.2022 um 19:36 hat Claudio Fontana geschrieben:
> >> On 9/8/22 19:10, Claudio Fontana wrote:
> >>> On 9/8/22 18:03, Richard Henderson wrote:
> On 9/8/22 15:53, Claudio Fontana wrote:
>
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Set is_jmp properly in gen_movl_seg_T0, so that the callers
> need to nothing special.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Paolo Bonzini
> ---
> target/i386/tcg/translate.c | 36 +---
>
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> Sync EIP before exiting a translation block.
> Replace all gen_jmp_im that use s->pc.
>
> Signed-off-by: Richard Henderson
> ---
> target/i386/tcg/translate.c | 45 -
> 1 file changed, 25
Kevin Wolf writes:
> Am 21.09.2022 um 06:45 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > Am 08.09.2022 um 19:36 hat Claudio Fontana geschrieben:
>> >> On 9/8/22 19:10, Claudio Fontana wrote:
>> >> > On 9/8/22 18:03, Richard Henderson wrote:
>> >> >> On 9/8/22 15:53, Claudio
On Tue, Sep 6, 2022 at 4:46 PM Philippe Mathieu-Daudé wrote:
>
> On 6/9/22 12:09, Richard Henderson wrote:
> > All callers pass s->base.pc_next and s->pc, which we can just
> > as well compute within the function.
> >
> > Signed-off-by: Richard Henderson
> > ---
> > target/i386/tcg/translate.c
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
wrote:
>
> The DisasContext member and the disas_insn local variable of
> the same name are identical to DisasContextBase.pc_next.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Paolo Bonzini
> ---
> target/i386/tcg/translate.c | 114
On Tue, Sep 6, 2022 at 4:45 PM Philippe Mathieu-Daudé wrote:
>
> On 6/9/22 12:09, Richard Henderson wrote:
> > All callers pass s->base.pc_next - s->cs_base, which we can just
> > as well compute within the function. Note the special case of
> > EXCP_VSYSCALL in which s->cs_base didn't have the
Am 21.09.2022 um 06:45 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 08.09.2022 um 19:36 hat Claudio Fontana geschrieben:
> >> On 9/8/22 19:10, Claudio Fontana wrote:
> >> > On 9/8/22 18:03, Richard Henderson wrote:
> >> >> On 9/8/22 15:53, Claudio Fontana wrote:
> >> >>> @@
Enable resource UUID feature and implement command resource assign UUID.
This is done by introducing a hash table to map resource IDs to their
UUIDs.
Signed-off-by: Antonio Caggiano
---
hw/display/trace-events| 1 +
hw/display/virtio-gpu-base.c | 2 ++
hw/display/virtio-gpu-virgl.c
On 29/08/2022 18.29, Jason A. Donenfeld wrote:
On Fri, Aug 26, 2022 at 01:28:11PM +0200, Thomas Huth wrote:
+qemu_guest_getrandom_nofail(tmp, block);
+for (size_t i = 0; i < block; ++i) {
+cpu_stb_data_ra(env, wrap_address(env, *buf_reg), tmp[i], ra);
+
On Wed, Sep 21, 2022 at 11:55:01AM +0200, Claudio Fontana wrote:
> Hi,
>
> I think this bug report warrants some attention,
>
> can Gerd take a look here?
>
> The GTK Clipboard commit seems involved:
>
> https://gitlab.com/qemu-project/qemu/-/issues/1150
Had a very quick look. Seems
On Thu, Sep 8, 2022 at 11:40 AM Jason A. Donenfeld wrote:
>
> If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to
> initialize early. Set this using the usual guest random number
> generation function. This FDT node is part of the DT specification.
>
> Reviewed-by: Edgar E.
On 29/08/22 10:04 am, Het Gala wrote:
On 08/08/22 11:41 am, Het Gala wrote:
On 02/08/22 1:23 pm, Markus Armbruster wrote:
Het Gala writes:
On 26/07/22 4:43 pm, Daniel P. Berrangé wrote:
On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote:
i) Modified the format of the qemu
In order to fully support MSA_EXT_5, we have to support the SHA-512
special instructions. So implement those.
The implementation began as something TweetNacl-like, and then was
adjusted to be useful here. It's not very beautiful, but it is quite
short and compact, which is what we're going for.
In order for hosts running inside of TCG to initialize the kernel's
random number generator, we should support the PRNO_TRNG instruction,
backed in the usual way with the qemu_guest_getrandom helper. This is
confirmed working on Linux 5.19.
Cc: Thomas Huth
Cc: David Hildenbrand
Cc: Christian
Hi,
I think this bug report warrants some attention,
can Gerd take a look here?
The GTK Clipboard commit seems involved:
https://gitlab.com/qemu-project/qemu/-/issues/1150
Thanks,
Claudio
On Tue, 20 Sept 2022 at 23:50, Bernhard Beschow wrote:
>
> Am 20. September 2022 09:55:37 UTC schrieb Peter Maydell
> :
> >On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrote:
> >>
> >> In address-spaces.h it can be read that get_system_memory() and
> >> get_system_io() are temporary
On Wed, Sep 21, 2022 at 11:12 AM Jason A. Donenfeld wrote:
> > Also I think it's cleaner if a reset callback puts the value back to
> > zero. fw_cfg already has fw_cfg_machine_reset, so perhaps the easiest
> > way is to add a FWCfgCallback reset_cb argument to just
> > fw_cfg_add_bytes_callback.
This reverts 3824e25db1 ("x86: disable rng seeding via setup_data"), but
for 7.2 rather than 7.1, now that modifying setup_data is safe to do.
Cc: Laurent Vivier
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
Cc: Peter Maydell
Cc: Philippe Mathieu-Daudé
Cc: Richard Henderson
Cc: Ard Biesheuvel
If setup_data is being read into a specific memory location, then
generally the setup_data address parameter is read first, so that the
caller knows where to read it into. In that case, we should return
setup_data containing the absolute addresses that are hard coded and
determined a priori. This
Since this is read from fw_cfg on each boot, the kernel zeroing it out
alone is insufficient to prevent it from being used twice. And indeed on
reboot we always want a new seed, not the old one. So re-fill it in this
circumstance.
Cc: Paolo Bonzini
Signed-off-by: Jason A. Donenfeld
---
The preferred style is SetupData as a typedef, not setup_data as a plain
struct.
Cc: Paolo Bonzini
Cc: Ard Biesheuvel
Suggested-by: Michael S. Tsirkin
Signed-off-by: Jason A. Donenfeld
---
hw/i386/x86.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
On Wed, Sep 21, 2022 at 11:15 AM Michael S. Tsirkin wrote:
>
> On Wed, Sep 14, 2022 at 12:41:34AM +0100, Jason A. Donenfeld wrote:
> > If setup_data is being read into a specific memory location, then
> > generally the setup_data address parameter is read first, so that the
> > caller knows where
On Wed, Sep 14, 2022 at 12:41:34AM +0100, Jason A. Donenfeld wrote:
> If setup_data is being read into a specific memory location, then
> generally the setup_data address parameter is read first, so that the
> caller knows where to read it into. In that case, we should return
> setup_data
On Wed, Sep 21, 2022 at 11:04:17AM +0200, Jason A. Donenfeld wrote:
> > Also I think it's cleaner if a reset callback puts the value back to
> > zero. fw_cfg already has fw_cfg_machine_reset, so perhaps the easiest
> > way is to add a FWCfgCallback reset_cb argument to just
> >
On Sep 21 13:44, Damien Le Moal wrote:
> On 9/20/22 17:51, Klaus Jensen wrote:
> > On Sep 10 13:27, Sam Li wrote:
> > > Add a new zoned_host_device BlockDriver. The zoned_host_device option
> > > accepts only zoned host block devices. By adding zone management
> > > operations in this new
Hi Paolo,
On Wed, Sep 21, 2022 at 10:59 AM Paolo Bonzini wrote:
> Just a small comment, addr should be little-endian (see
> fw_cfg_add_i32). It's not used outside x86_load_linux, so it is
> possible to just use cpu_to_le32 there.
Oh, shucks: I thought about this and then forgot to do it.
> diff --git a/hw/i386/x86.c b/hw/i386/x86.c
> index 050eedc0c8..933bbdd836 100644
> --- a/hw/i386/x86.c
> +++ b/hw/i386/x86.c
> @@ -764,6 +764,18 @@ static bool load_elfboot(const char *kernel_filename,
> return true;
> }
>
> +struct setup_data_fixup {
> +void *pos;
> +hwaddr val;
>
On Wed 21 Sep 2022 09:47:32 AM +08, Wang Liang wrote:
>> > -return limit->slice_end_time - now;
>> > +return MAX(limit->slice_end_time - now, 0);
>>
>> How can this be negative? slice_end_time is guaranteed to be larger
>> than
>> now:
>>
>> if (limit->slice_end_time < now) {
>>
On 9/20/22 18:50, Kevin Wolf wrote:
> Am 08.09.2022 um 19:36 hat Claudio Fontana geschrieben:
>> On 9/8/22 19:10, Claudio Fontana wrote:
>>> On 9/8/22 18:03, Richard Henderson wrote:
On 9/8/22 15:53, Claudio Fontana wrote:
> @@ -446,8 +447,13 @@ static int dmg_open(BlockDriverState *bs,
On Tue, Sep 20, 2022 at 02:21:46PM -0600, Warner Losh wrote:
> On Tue, Sep 20, 2022 at 2:57 AM Daniel P. Berrangé
> wrote:
>
> > On Tue, Sep 20, 2022 at 10:23:56AM +0200, Thomas Huth wrote:
> > > On 20/09/2022 10.21, Daniel P. Berrangé wrote:
> > > > On Tue, Sep 20, 2022 at 08:44:27AM +0200,
On Wed, Sep 21, 2022 at 02:15:41PM +0800, Jason Wang wrote:
> On Wed, Sep 21, 2022 at 11:57 AM Michael S. Tsirkin wrote:
> >
> > On Wed, Sep 21, 2022 at 10:59:50AM +0800, Jason Wang wrote:
> > > On Tue, Sep 20, 2022 at 8:59 PM Michael S. Tsirkin
> > > wrote:
> > > >
> > > > On Tue, Sep 20, 2022
On Wed, 2022-09-21 at 06:53 +0200, Markus Armbruster wrote:
> Wang Liang writes:
>
> > On Tue, 2022-09-20 at 13:18 +, Alberto Garcia wrote:
> > > On Tue 20 Sep 2022 08:33:50 PM +08, wanglian...@126.com wrote:
> > > > From: Wang Liang
> > > >
> > > > The delay time should never be a
在 2022/9/21 13:28, Raphael Norwitz 写道:
I have some concerns from the vhost-user-blk side.
>On Tue, Sep 13, 2022 at 5:13 PM Hao Chen wrote:
>>
>> When use dpdk-vdpa tests vdpa device. You need to specify the mac address to
>> start the virtual machine through libvirt or qemu, but now, the
On Wed, Sep 21, 2022 at 11:57 AM Michael S. Tsirkin wrote:
>
> On Wed, Sep 21, 2022 at 10:59:50AM +0800, Jason Wang wrote:
> > On Tue, Sep 20, 2022 at 8:59 PM Michael S. Tsirkin wrote:
> > >
> > > On Tue, Sep 20, 2022 at 10:03:23AM +0800, Jason Wang wrote:
> > > > On Tue, Sep 20, 2022 at 9:38 AM
Hi,
> 1. Although it is reasonable to assume no more than one isa-vga device
> will exist in one machine, this could be changed easily later on.
Nope. Even if you fix the framebuffer address conflict you still have
the io address conflict.
> As it stands now, on an ISA-PC machine with no
"Kasireddy, Vivek" writes:
> Hi Markus,
>
>> Any overlap with Dongwon Kim's "[PATCH v5 0/2] handling guest multiple
>> displays"?
>
> [Kasireddy, Vivek] Yes, there is some overlap but as I mentioned in the cover
> letter,
> this series is intended to replace Dongwon's series dealing with
From: Hao Chen
When use dpdk-vdpa tests vdpa device. You need to specify the mac address to
start the virtual machine through libvirt or qemu, but now, the libvirt or
qemu can call dpdk vdpa vendor driver's ops .get_config through
vhost_net_get_config
to get the mac address of the vdpa hardware
101 - 164 of 164 matches
Mail list logo
