RE: [PATCH v8 1/8] mm/memfd: Introduce userspace inaccessible memfd

2022-09-22 Thread Wang, Wei W
On Thursday, September 22, 2022 5:11 AM, Andy Lutomirski wrote: > To: Christopherson,, Sean ; David Hildenbrand > > Cc: Chao Peng ; kvm list > ; Linux Kernel Mailing List > ; linux...@kvack.org; > linux-fsde...@vger.kernel.org; Linux API ; > linux-...@vger.kernel.org; qemu-devel@nongnu.org; Paolo

Re: [PATCH] Revert "intel_iommu: Fix irqchip / X2APIC configuration checks"

2022-09-22 Thread Igor Mammedov
On Wed, 21 Sep 2022 12:12:27 -0400 Peter Xu wrote: > It's true that when vcpus<=255 we don't require the length of 32bit APIC > IDs. However here since we already have EIM=ON it means the hypervisor > will declare the VM as x2apic supported (e.g. VT-d ECAP register will have > EIM bit 4 set),

[PATCH 2/5] qga: Add initial FreeBSD support

2022-09-22 Thread Alexander Ivanov
Add commands-bsd.c file with dumb functions, fix device path and make the code buildable in FreeBSD. Signed-off-by: Alexander Ivanov --- meson.build | 2 +- qga/commands-bsd.c | 121 +++ qga/commands-posix.c | 6 ++- qga/main.c |

[PATCH 1/4] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-09-22 Thread Yicong Yang via
From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and it's unncessary to build it if user don't need. So only generate it when user specify explicitly. Also update the test ACPI tables.

Re: [PATCH 0/7] configure: fix misc shellcheck warnings

2022-09-22 Thread Peter Maydell
On Thu, 25 Aug 2022 at 16:07, Peter Maydell wrote: > > Currently if you run shellcheck on our configure script it > generates a ton of warnings. This patchset fixes some of the > easier ones. I wasn't aiming for completeness or consistency; > I just wanted to zap some of the ones where the fix is

[PATCH 5/5] qga: Add support for user password settinng in FreeeBSD

2022-09-22 Thread Alexander Ivanov
Move qmp_guest_set_user_password() to commands-posix.c under (__linux__ or __FreeBSD) condition. Add command and arguments for password setting in FreeBSD. Signed-off-by: Alexander Ivanov --- qga/commands-bsd.c | 8 --- qga/commands-linux.c | 105 --

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 15:34, Philippe Mathieu-Daudé wrote: > On Thu, Sep 22, 2022 at 3:20 PM Markus Armbruster wrote: >> >> Claudio Fontana writes: >> >> [...] >> >>> I think it would be better to completely make the return value separate >>> from the Error, >>> and really treat Error as an exception and

Re: [PATCH 5/7] configure: Remove use of backtick `...` syntax

2022-09-22 Thread Peter Maydell
On Tue, 30 Aug 2022 at 13:13, Philippe Mathieu-Daudé wrote: > > On 25/8/22 17:07, Peter Maydell wrote: > > There's only one place in configure where we use `...` to execute a > > command and capture the result. Switch to $() to match the rest of > > the script. This silences a shellcheck

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Philippe Mathieu-Daudé via
On Thu, Sep 22, 2022 at 3:20 PM Markus Armbruster wrote: > > Claudio Fontana writes: > > [...] > > > I think it would be better to completely make the return value separate > > from the Error, > > and really treat Error as an exception and not mix it up with the regular > > execution, > > > >

Re: [PULL 00/12] Publish1 patches

2022-09-22 Thread Laurent Vivier
Le 22/09/2022 à 11:37, Peter Maydell a écrit : On Wed, 21 Sept 2022 at 00:00, Helge Deller wrote: The following changes since commit 621da7789083b80d6f1ff1c0fb499334007b4f51: Update version for v7.1.0 release (2022-08-30 09:40:11 -0700) are available in the Git repository at:

[PATCH 3/5] qga: Add UFS freeze/thaw support for FreeBSD

2022-09-22 Thread Alexander Ivanov
UFS supports FS freezing through ioctl UFSSUSPEND on /dev/ufssuspend. Freezed FS can be thawed by closing /dev/ufssuspend file descriptior. Use getmntinfo to get a list of mounted FS. Signed-off-by: Alexander Ivanov --- qga/commands-bsd.c| 109 +++---

Re: [PATCH v4] x86: add etc/phys-bits fw_cfg file

2022-09-22 Thread Paolo Bonzini
On Thu, Sep 22, 2022 at 2:21 PM Gerd Hoffmann wrote: > No. This will basically inform the guest that host-phys-bits has been > enabled (and pass the number of bits). So the firmware can make use of > the available address space instead of trying to be as conservative as > possible to avoid

Re: [PATCH] arm/monitor: add register name resolution

2022-09-22 Thread Peter Maydell
On Sat, 10 Sept 2022 at 15:14, Nikola Brkovic wrote: > > This patch allows the monitor to resolve the > stack pointer, instruction pointer, > system status register and FPU status register > on ARM targets. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1145 > > Signed-off-by: Nikola

Re: [PATCH v3] 9pfs: use GHashTable for fid table

2022-09-22 Thread Christian Schoenebeck
On Donnerstag, 22. September 2022 13:43:56 CEST Linus Heckemann wrote: > Christian Schoenebeck writes: > > On Freitag, 9. September 2022 15:10:48 CEST Christian Schoenebeck wrote: > >> On Donnerstag, 8. September 2022 13:23:53 CEST Linus Heckemann wrote: > >> > The previous implementation would

[PATCH 0/4] Only generate cluster node in PPTT when specified

2022-09-22 Thread Yicong Yang via
From: Yicong Yang This series mainly change the policy for building a cluster topology node in PPTT. Previously we'll always build a cluster node in PPTT without asking the user, after this set the cluster node will be built only the the user specify through "-smp clusters=X". Update the tests

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Daniel P . Berrangé
On Thu, Sep 22, 2022 at 02:30:35PM +0200, Claudio Fontana wrote: > On 9/22/22 12:37, Daniel P. Berrangé wrote: > > On Thu, Sep 22, 2022 at 11:34:22AM +0200, Claudio Fontana wrote: > >> On 9/22/22 11:31, Daniel P. Berrangé wrote: > >>> On Thu, Sep 22, 2022 at 11:20:07AM +0200, Claudio Fontana

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 15:20, Markus Armbruster wrote: > Claudio Fontana writes: > > [...] > >> I think it would be better to completely make the return value separate from >> the Error, >> and really treat Error as an exception and not mix it up with the regular >> execution, >> >> but if it is the

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Markus Armbruster
Claudio Fontana writes: [...] > I think it would be better to completely make the return value separate from > the Error, > and really treat Error as an exception and not mix it up with the regular > execution, > > but if it is the general consensus that I am the only one seeing this >

Re: [PATCH v8 2/2] target/s390x: support PRNO_TRNG instruction

2022-09-22 Thread David Hildenbrand
On 21.09.22 12:07, Jason A. Donenfeld wrote: In order for hosts running inside of TCG to initialize the kernel's random number generator, we should support the PRNO_TRNG instruction, backed in the usual way with the qemu_guest_getrandom helper. This is confirmed working on Linux 5.19. Cc:

Re: [PATCH v8 1/2] target/s390x: support SHA-512 extensions

2022-09-22 Thread David Hildenbrand
On 21.09.22 12:07, Jason A. Donenfeld wrote: In order to fully support MSA_EXT_5, we have to support the SHA-512 special instructions. So implement those. The implementation began as something TweetNacl-like, and then was adjusted to be useful here. It's not very beautiful, but it is quite

Re: [PATCH 14/27] qapi migration: Elide redundant has_FOO in generated C

2022-09-22 Thread Philippe Mathieu-Daudé via
On Thu, Sep 15, 2022 at 10:52 PM Markus Armbruster wrote: > > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by step.

[PATCH 4/5] qga: Add shutdown/halt/reboot support for FreeBSD

2022-09-22 Thread Alexander Ivanov
Add appropriate shutdown command arguments in qmp_guest_shutdown() for FreeBSD. Signed-off-by: Alexander Ivanov --- qga/commands-posix.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 3a1055d5c3..60cc673f25 100644 ---

[PATCH v4 3/5] acpi/nvdimm: define macro for NVDIMM Device _DSM

2022-09-22 Thread Robert Hoo
Since it will be heavily used in next patch, define macro NVDIMM_DEVICE_DSM_UUID for "4309AC30-0D11-11E4-9191-0800200C9A66", which is NVDIMM device specific method uuid defined in NVDIMM _DSM interface spec, Section 3. [1] No functional changes in this patch. [1]

Re: [PATCH 14/27] qapi migration: Elide redundant has_FOO in generated C

2022-09-22 Thread Daniel P . Berrangé
On Thu, Sep 22, 2022 at 12:28:55PM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > The has_FOO for pointer-valued FOO are redundant, except for arrays. > > They are also a nuisance to work with. Recent commit "qapi: Start to > > elide redundant has_FOO in

[PATCH v4 1/5] tests/acpi: allow SSDT changes

2022-09-22 Thread Robert Hoo
Signed-off-by: Robert Hoo Reviewed-by: Jingqi Liu --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..eb8bae1407 100644 ---

[PATCH] target/i386/kvm: fix kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc' failed

2022-09-22 Thread Ray Zhang
New KVM_CLOCK flags were added in the kernel.(c68dc1b577eabd5605c6c7c08f3e07ae18d30d5d) ``` + #define KVM_CLOCK_VALID_FLAGS \ + (KVM_CLOCK_TSC_STABLE | KVM_CLOCK_REALTIME | KVM_CLOCK_HOST_TSC) case KVM_CAP_ADJUST_CLOCK: - r =

[PATCH 2/4] tests: virt: update expected ACPI tables for virt test

2022-09-22 Thread Yicong Yang via
From: Yicong Yang Update the ACPI tables according to the acpi aml_build change. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.pxb | Bin 0 -> 168 bytes tests/data/acpi/virt/DBG2.memhp | Bin 0 -> 87 bytes tests/data/acpi/virt/DBG2.numamem | Bin 0 -> 87 bytes

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 12:37, Daniel P. Berrangé wrote: > On Thu, Sep 22, 2022 at 11:34:22AM +0200, Claudio Fontana wrote: >> On 9/22/22 11:31, Daniel P. Berrangé wrote: >>> On Thu, Sep 22, 2022 at 11:20:07AM +0200, Claudio Fontana wrote: On 9/22/22 10:28, Daniel P. Berrangé wrote: > >> Another

[PATCH 4/4] tests: acpi: aarch64: add *.topology tables

2022-09-22 Thread Yicong Yang via
From: Yicong Yang Add *.topology tables for the aarch64's topology test. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.topology | Bin 0 -> 700 bytes tests/data/acpi/virt/DBG2.topology | Bin 0 -> 87 bytes tests/data/acpi/virt/DSDT.topology | Bin 0 -> 5398 bytes

Re: [PATCH v7 14/14] qmp/hmp, device_tree.c: introduce dumpdtb

2022-09-22 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 8/9/22 21:40, Daniel Henrique Barboza wrote: >> To save the FDT blob we have the '-machine dumpdtb=' property. >> With this property set, the machine saves the FDT in and exit. >> The created file can then be converted to plain text dts format using >> 'dtc'.

[PATCH 3/4] tests: acpi: aarch64: add topology test for aarch64

2022-09-22 Thread Yicong Yang via
From: Yicong Yang Add test for aarch64's ACPI topology building for all the supported levels. Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/qtest/bios-tables-test.c

Re: [PATCH v4] x86: add etc/phys-bits fw_cfg file

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 12:24:09PM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 22, 2022 at 12:14:54PM +0200, Gerd Hoffmann wrote: > > In case phys bits are functional and can be used by the guest (aka > > host-phys-bits=on) add a fw_cfg file carrying the value. This can > > be used by the

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 14:42, Markus Armbruster wrote: > Claudio Fontana writes: > >> On 9/22/22 11:38, Markus Armbruster wrote: >>> Daniel P. Berrangé writes: >>> On Thu, Sep 22, 2022 at 08:07:43AM +0200, Markus Armbruster wrote: > Ease of use matters, too. When sticking to the rule leads to

Re: [PATCH V4 1/3] hw/arm, loongarch: Move load_image_to_fw_cfg() to common location

2022-09-22 Thread Sunil V L
On Thu, Sep 15, 2022 at 08:56:01PM +0800, gaosong wrote: > > 在 2022/9/15 下午7:59, Sunil V L 写道: > > Hi, > > > > Could maintainers of hw/arm and hw/loongarch to take a look at this? I > > have addressed Peter's earlier comment. > > > > Thanks > > Sunil > > > > On Thu, Sep 08, 2022 at 11:17:52AM

[PATCH v4 5/5] test/acpi/bios-tables-test: SSDT: update golden master binaries

2022-09-22 Thread Robert Hoo
And empty bios-tables-test-allowed-diff.h. Diff of ASL form, from qtest testlog.txt: --- /tmp/asl-RFWZS1.dsl 2022-09-22 18:25:06.191519589 +0800 +++ /tmp/asl-B1ZZS1.dsl 2022-09-22 18:25:06.187519182 +0800 @@ -1,30 +1,30 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler

Re: [PATCH] hw/net: npcm7xx_emc: set MAC in register space

2022-09-22 Thread Peter Maydell
On Thu, 22 Sept 2022 at 00:47, Patrick Venture wrote: > > The MAC address set from Qemu wasn't being saved into the register space. > > Reviewed-by: Hao Wu > Signed-off-by: Patrick Venture > @@ -112,6 +115,18 @@ static void emc_reset(NPCM7xxEMCState *emc) > > emc->tx_active = false; >

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Markus Armbruster
Claudio Fontana writes: > On 9/22/22 11:38, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >>> On Thu, Sep 22, 2022 at 08:07:43AM +0200, Markus Armbruster wrote: Ease of use matters, too. When sticking to the rule leads to awkward code, we should stop and think. Should

Re: [PATCH v4] x86: add etc/phys-bits fw_cfg file

2022-09-22 Thread Daniel P . Berrangé
On Thu, Sep 22, 2022 at 12:14:54PM +0200, Gerd Hoffmann wrote: > In case phys bits are functional and can be used by the guest (aka > host-phys-bits=on) add a fw_cfg file carrying the value. This can > be used by the guest firmware for address space configuration. > > The value in the

[PATCH v4 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

2022-09-22 Thread Robert Hoo
Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, which deprecates corresponding _DSM Functions defined by PMEM _DSM Interface spec [2]. Since the semantics of the new Label Methods are almost same as old _DSM methods, the implementations here simply wrapper old ones. ASL form

Re: [PATCH v4 5/5] test/acpi/bios-tables-test: SSDT: update golden master binaries

2022-09-22 Thread Robert Hoo
On Thu, 2022-09-22 at 20:21 +0800, Robert Hoo wrote: > And empty bios-tables-test-allowed-diff.h. > > Diff of ASL form, from qtest testlog.txt: > > --- /tmp/asl-RFWZS1.dsl 2022-09-22 18:25:06.191519589 +0800 > +++ /tmp/asl-B1ZZS1.dsl 2022-09-22 18:25:06.187519182 +0800 > @@ -1,30

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 14:33, Daniel P. Berrangé wrote: > On Thu, Sep 22, 2022 at 02:30:35PM +0200, Claudio Fontana wrote: >> On 9/22/22 12:37, Daniel P. Berrangé wrote: >>> On Thu, Sep 22, 2022 at 11:34:22AM +0200, Claudio Fontana wrote: On 9/22/22 11:31, Daniel P. Berrangé wrote: > On Thu, Sep 22,

[PATCH v4 2/5] acpi/ssdt: Fix aml_or() and aml_and() in if clause

2022-09-22 Thread Robert Hoo
In If condition, using bitwise and/or, rather than logical and/or. The result change in AML code: If (((Local6 == Zero) | (Arg0 != Local0))) ==> If (((Local6 == Zero) || (Arg0 != Local0))) If (((ObjectType (Arg3) == 0x04) & (SizeOf (Arg3) == One))) ==> If (((ObjectType (Arg3) == 0x04) &&

Re: [PATCH v7 00/14] QMP/HMP: introduce 'dumpdtb'

2022-09-22 Thread Philippe Mathieu-Daudé via
Hi Daniel, On 8/9/22 21:40, Daniel Henrique Barboza wrote: Hi, This new version implements all change requests from the v6. - patch 5: - change bamboo_load_device_tree() to use a MachineState pointer - patch 7: - change xilinx_load_device_tree() to use a MachineState pointer - patch 14:

Re: [PATCH v4] x86: add etc/phys-bits fw_cfg file

2022-09-22 Thread Gerd Hoffmann
On Thu, Sep 22, 2022 at 12:24:09PM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 22, 2022 at 12:14:54PM +0200, Gerd Hoffmann wrote: > > In case phys bits are functional and can be used by the guest (aka > > host-phys-bits=on) add a fw_cfg file carrying the value. This can > > be used by the

[PATCH v4 0/5] Support ACPI NVDIMM Label Methods

2022-09-22 Thread Robert Hoo
Originally NVDIMM Label methods was defined in Intel PMEM _DSM Interface Spec [1], of function index 4, 5 and 6. Recent ACPI spec [2] has deprecated those _DSM methods with ACPI NVDIMM Label Methods _LS{I,R,W}. The essence of these functions has no changes. This patch set is to update QEMU

Re: [PATCH v7 14/14] qmp/hmp, device_tree.c: introduce dumpdtb

2022-09-22 Thread Philippe Mathieu-Daudé via
On 22/9/22 12:47, Philippe Mathieu-Daudé wrote: On 8/9/22 21:40, Daniel Henrique Barboza wrote: To save the FDT blob we have the '-machine dumpdtb=' property. With this property set, the machine saves the FDT in and exit. The created file can then be converted to plain text dts format using

Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32

2022-09-22 Thread Bin Meng
On Thu, Sep 22, 2022 at 6:39 PM Daniel P. Berrangé wrote: > > On Thu, Sep 22, 2022 at 10:47:26AM +0800, Bin Meng wrote: > > On Thu, Sep 22, 2022 at 1:23 AM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Sep 21, 2022 at 05:51:33PM +0100, Dr. David Alan Gilbert wrote: > > > > * Bin Meng

Re: [PATCH v2] hw/acpi: Add ospm_status hook implementation for acpi-ged

2022-09-22 Thread Peter Maydell
On Wed, 21 Sept 2022 at 14:22, Igor Mammedov wrote: > > On Tue, 20 Sep 2022 14:15:36 +0100 > Peter Maydell wrote: > > > On Wed, 24 Aug 2022 at 16:04, Igor Mammedov wrote: > > > > > > On Tue, 16 Aug 2022 17:49:57 +0800 > > > Keqian Zhu wrote: > > > > > > > Setup an ARM virtual machine of

Re: [PATCH v7 08/14] hw/ppc: set machine->fdt in pegasos2_machine_reset()

2022-09-22 Thread Philippe Mathieu-Daudé via
On 8/9/22 21:58, BALATON Zoltan wrote: On Thu, 8 Sep 2022, Daniel Henrique Barboza wrote: We'll introduce a QMP/HMP command that requires machine->fdt to be set properly. Cc: BALATON Zoltan Cc: qemu-...@nongnu.org Signed-off-by: Daniel Henrique Barboza Reviewed-by: BALATON Zoltan ---

Re: [PATCH v7 07/14] hw/ppc: set machine->fdt in xilinx_load_device_tree()

2022-09-22 Thread Philippe Mathieu-Daudé via
On 8/9/22 21:40, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' QMP/HMP command for the virtex_ml507 machine. Setting machine->fdt requires a MachineState pointer to be used inside xilinx_load_device_tree(). Let's change the function to receive this pointer from the

Re: [PATCH v3] 9pfs: use GHashTable for fid table

2022-09-22 Thread Linus Heckemann
Christian Schoenebeck writes: > On Freitag, 9. September 2022 15:10:48 CEST Christian Schoenebeck wrote: >> On Donnerstag, 8. September 2022 13:23:53 CEST Linus Heckemann wrote: >> > The previous implementation would iterate over the fid table for >> > lookup operations, resulting in an

Re: [PATCH v7 10/14] hw/ppc: set machine->fdt in spapr machine

2022-09-22 Thread Philippe Mathieu-Daudé via
On 8/9/22 21:40, Daniel Henrique Barboza wrote: The pSeries machine never bothered with the common machine->fdt attribute. We do all the FDT related work using spapr->fdt_blob. We're going to introduce a QMP/HMP command to dump the FDT, which will rely on setting machine->fdt properly to work

Re: [PATCH 14/27] qapi migration: Elide redundant has_FOO in generated C

2022-09-22 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by step. This is the step

Re: [PATCH v7 04/14] hw/ppc: set machine->fdt in ppce500_load_device_tree()

2022-09-22 Thread Philippe Mathieu-Daudé via
+David/Peter On 8/9/22 21:40, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' QMP/HMP command for the e500 machine. Cc: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff

Re: [PATCH v7 11/14] hw/riscv: set machine->fdt in sifive_u_machine_init()

2022-09-22 Thread Philippe Mathieu-Daudé via
On 8/9/22 21:40, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' QMP/HMP command for the sifive_u machine. Cc: Alistair Francis Cc: Bin Meng Cc: Palmer Dabbelt Reviewed-by: Alistair Francis Signed-off-by: Daniel Henrique Barboza --- hw/riscv/sifive_u.c | 3 +++ 1

Re: [PATCH v7 14/14] qmp/hmp, device_tree.c: introduce dumpdtb

2022-09-22 Thread Philippe Mathieu-Daudé via
On 8/9/22 21:40, Daniel Henrique Barboza wrote: To save the FDT blob we have the '-machine dumpdtb=' property. With this property set, the machine saves the FDT in and exit. The created file can then be converted to plain text dts format using 'dtc'. There's nothing particularly sophisticated

Re: [PATCH v2] hw/ide/piix: Ignore writes of hardwired PCI command register bits

2022-09-22 Thread Michael S. Tsirkin
On Tue, Sep 06, 2022 at 10:23:57AM -0400, Michael S. Tsirkin wrote: > On Thu, Jun 02, 2022 at 08:47:31PM +, Lev Kujawski wrote: > > One method to enable PCI bus mastering for IDE controllers, often used > > by x86 firmware, is to write 0x7 to the PCI command register. Neither > > the PIIX3

Re: [PATCH v7 06/14] hw/ppc: set machine->fdt in sam460ex_load_device_tree()

2022-09-22 Thread Philippe Mathieu-Daudé via
On 8/9/22 21:40, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' QMP/HMP command for the sam460ex machine. Setting machine->fdt requires a MachineState pointer to be used inside sam460ex_load_device_tree(). Let's change the function to receive this pointer from the caller.

Re: [PATCH v7 12/14] hw/riscv: set machine->fdt in spike_board_init()

2022-09-22 Thread Philippe Mathieu-Daudé via
On 8/9/22 21:40, Daniel Henrique Barboza wrote: This will enable support for the 'dumpdtb' QMP/HMP command for the spike machine. Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Bin Meng Reviewed-by: Alistair Francis Signed-off-by: Daniel Henrique Barboza --- hw/riscv/spike.c | 6 ++ 1

Re: [PATCH v3] x86: add etc/phys-bits fw_cfg file

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 10:43:56AM +0200, Gerd Hoffmann wrote: > In case phys bits are functional and can be used by the guest (aka > host-phys-bits=on) add a fw_cfg file carrying the value. This can > be used by the guest firmware for address space configuration. > > This is only enabled for

Re: [PATCH v3] x86: add etc/phys-bits fw_cfg file

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 11:37:10AM +0200, Gerd Hoffmann wrote: > On Thu, Sep 22, 2022 at 04:55:16AM -0400, Michael S. Tsirkin wrote: > > On Thu, Sep 22, 2022 at 10:43:56AM +0200, Gerd Hoffmann wrote: > > > In case phys bits are functional and can be used by the guest (aka > > > host-phys-bits=on)

Re: [PATCH v7 03/14] hw/nios2: set machine->fdt in nios2_load_dtb()

2022-09-22 Thread Philippe Mathieu-Daudé via
On 8/9/22 21:40, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' QMP/HMP command for all nios2 machines that uses nios2_load_dtb(). Cc: Chris Wulff Cc: Marek Vasut Signed-off-by: Daniel Henrique Barboza --- hw/nios2/boot.c | 8 +++- hw/nios2/meson.build | 2

Re: [PATCH v2 00/66] target/arm: Implement FEAT_HAFDBS

2022-09-22 Thread Peter Maydell
On Mon, 22 Aug 2022 at 16:28, Richard Henderson wrote: > > This is a major reorg to arm page table walking. While the result > here is "merely" Hardware-assited Access Flag and Dirty Bit Setting > (HAFDBS), the ultimate goal is the Realm Management Extension (RME). > RME "recommends" that HAFDBS

Re: [PATCH] watchdog: remove -watchdog option

2022-09-22 Thread Thomas Huth
On 22/09/2022 11.29, Paolo Bonzini wrote: This was deprecated in 6.2 and is ready to go. It removes quite a bit of code that handled the registration of watchdog models. Signed-off-by: Paolo Bonzini --- docs/about/deprecated.rst | 5 docs/about/removed-features.rst | 5

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Sep 22, 2022 at 08:07:43AM +0200, Markus Armbruster wrote: >> Ease of use matters, too. When sticking to the rule leads to awkward >> code, we should stop and think. Should we deviate from the rule? Or >> can we avoid that by tweaking the interface? >> >>

[PATCH v4] x86: add etc/phys-bits fw_cfg file

2022-09-22 Thread Gerd Hoffmann
In case phys bits are functional and can be used by the guest (aka host-phys-bits=on) add a fw_cfg file carrying the value. This can be used by the guest firmware for address space configuration. The value in the etc/phys-bits fw_cfg file should be identical to the phys bits value published via

Re: [PULL 00/12] Publish1 patches

2022-09-22 Thread Peter Maydell
On Wed, 21 Sept 2022 at 00:00, Helge Deller wrote: > > The following changes since commit 621da7789083b80d6f1ff1c0fb499334007b4f51: > > Update version for v7.1.0 release (2022-08-30 09:40:11 -0700) > > are available in the Git repository at: > > https://github.com/hdeller/qemu-hppa.git

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 09:34:41AM +0800, Jason Wang wrote: > On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz > wrote: > > > > If I read your response on the other thread correctly, this change is > > intended > > > > to prioritize the MAC address exposed by DPDK over the one provided by the > >

Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32

2022-09-22 Thread Daniel P . Berrangé
On Thu, Sep 22, 2022 at 10:47:26AM +0800, Bin Meng wrote: > On Thu, Sep 22, 2022 at 1:23 AM Daniel P. Berrangé > wrote: > > > > On Wed, Sep 21, 2022 at 05:51:33PM +0100, Dr. David Alan Gilbert wrote: > > > * Bin Meng (bmeng...@gmail.com) wrote: > > > > From: Bin Meng > > > > > > > > Some

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Daniel P . Berrangé
On Thu, Sep 22, 2022 at 11:34:22AM +0200, Claudio Fontana wrote: > On 9/22/22 11:31, Daniel P. Berrangé wrote: > > On Thu, Sep 22, 2022 at 11:20:07AM +0200, Claudio Fontana wrote: > >> On 9/22/22 10:28, Daniel P. Berrangé wrote: > >>> > Another interface that does: return -1 for error, 0 for

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 11:21, Claudio Fontana wrote: > On 9/22/22 11:20, Claudio Fontana wrote: >> On 9/22/22 10:28, Daniel P. Berrangé wrote: >>> On Thu, Sep 22, 2022 at 08:07:43AM +0200, Markus Armbruster wrote: Ease of use matters, too. When sticking to the rule leads to awkward code, we should

Re: [PATCH v8 13/14] net: stream: move to QIO

2022-09-22 Thread Markus Armbruster
Laurent Vivier writes: > On 9/21/22 16:58, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> Use QIOChannel, QIOChannelSocket and QIONetListener. >>> >>> Signed-off-by: Laurent Vivier >>> --- >> [...] >> >>> diff --git a/qemu-options.hx b/qemu-options.hx >>> index

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Daniel P . Berrangé
On Thu, Sep 22, 2022 at 11:20:07AM +0200, Claudio Fontana wrote: > On 9/22/22 10:28, Daniel P. Berrangé wrote: > > > >> Another interface that does: return -1 for error, 0 for module not found > >> (no error), and 1 for loaded. > > > > IMHO this pattern is generally easier to understand when

Re: [PATCH v3] x86: add etc/phys-bits fw_cfg file

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 10:43:56AM +0200, Gerd Hoffmann wrote: > In case phys bits are functional and can be used by the guest (aka > host-phys-bits=on) add a fw_cfg file carrying the value. This can > be used by the guest firmware for address space configuration. > > This is only enabled for

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 11:02:56AM +0100, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Wed, Sep 21, 2022 at 07:23:12PM +0100, Alex Bennée wrote: > >> > >> chenh writes: > >> > >> > From: Hao Chen > >> > > >> > When use dpdk-vdpa tests vdpa device. You need to specify the mac

Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-22 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Wed, Sep 21, 2022 at 07:23:12PM +0100, Alex Bennée wrote: >> >> chenh writes: >> >> > From: Hao Chen >> > >> > When use dpdk-vdpa tests vdpa device. You need to specify the mac address >> > to >> > start the virtual machine through libvirt or qemu, but

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 11:20, Claudio Fontana wrote: > On 9/22/22 10:28, Daniel P. Berrangé wrote: >> On Thu, Sep 22, 2022 at 08:07:43AM +0200, Markus Armbruster wrote: >>> Ease of use matters, too. When sticking to the rule leads to awkward >>> code, we should stop and think. Should we deviate from the

[PATCH 22/26] coroutine-lock: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- util/qemu-coroutine-lock.c | 14 +++--- 1 file changed, 7

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 10:28, Daniel P. Berrangé wrote: > On Thu, Sep 22, 2022 at 08:07:43AM +0200, Markus Armbruster wrote: >> Ease of use matters, too. When sticking to the rule leads to awkward >> code, we should stop and think. Should we deviate from the rule? Or >> can we avoid that by tweaking the

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 11:38, Markus Armbruster wrote: > Daniel P. Berrangé writes: > >> On Thu, Sep 22, 2022 at 08:07:43AM +0200, Markus Armbruster wrote: >>> Ease of use matters, too. When sticking to the rule leads to awkward >>> code, we should stop and think. Should we deviate from the rule? Or >>>

[PATCH 23/26] raw-format: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- block/raw-format.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v8 13/14] net: stream: move to QIO

2022-09-22 Thread Laurent Vivier
On 9/21/22 16:58, Markus Armbruster wrote: Laurent Vivier writes: Use QIOChannel, QIOChannelSocket and QIONetListener. Signed-off-by: Laurent Vivier --- [...] diff --git a/qemu-options.hx b/qemu-options.hx index ee2436ae14a7..a0b5b70c80cb 100644 --- a/qemu-options.hx +++

[PATCH 20/26] vmdk: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- block/vmdk.c | 20 ++-- 1 file changed, 10

Re: [PATCH v7 00/14] QMP/HMP: introduce 'dumpdtb'

2022-09-22 Thread Daniel Henrique Barboza
Ping We're missing just patch 14/14. I'll leave non-acked patches behind and, if no one is strongly against it, I'll push both the dumpdtb implementation and the ppc parts via the ppc tree. Alistair, I can also push the riscv bits through the ppc tree if it's easier for you. Thanks, Daniel

[PATCH 18/26] quorum: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- block/quorum.c | 35 ++- 1 file

Re: [PATCH v3] x86: add etc/phys-bits fw_cfg file

2022-09-22 Thread Gerd Hoffmann
On Thu, Sep 22, 2022 at 04:55:16AM -0400, Michael S. Tsirkin wrote: > On Thu, Sep 22, 2022 at 10:43:56AM +0200, Gerd Hoffmann wrote: > > In case phys bits are functional and can be used by the guest (aka > > host-phys-bits=on) add a fw_cfg file carrying the value. This can > > be used by the

[PATCH 17/26] qed: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- block/qed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 25/26] migration: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
From: Marc-André Lureau Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela Reviewed-by: Stefan Hajnoczi Reviewed-by:

[PATCH 14/26] qcow2: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- block/qcow2-cluster.c | 18 +- block/qcow2-refcount.c

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-22 Thread Claudio Fontana
On 9/22/22 11:31, Daniel P. Berrangé wrote: > On Thu, Sep 22, 2022 at 11:20:07AM +0200, Claudio Fontana wrote: >> On 9/22/22 10:28, Daniel P. Berrangé wrote: >>> Another interface that does: return -1 for error, 0 for module not found (no error), and 1 for loaded. >>> >>> IMHO this

[PATCH 21/26] job: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- include/qemu/job.h | 2 +- job.c | 2 +- 2 files changed,

[PATCH] watchdog: remove -watchdog option

2022-09-22 Thread Paolo Bonzini
This was deprecated in 6.2 and is ready to go. It removes quite a bit of code that handled the registration of watchdog models. Signed-off-by: Paolo Bonzini --- docs/about/deprecated.rst | 5 docs/about/removed-features.rst | 5 hw/watchdog/sbsa_gwdt.c | 6 -

[PATCH 13/26] parallels: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- block/parallels.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 24/26] 9p: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
From: Marc-André Lureau Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Signed-off-by: Marc-André Lureau Acked-by: Greg Kurz Reviewed-by: Alberto Faria Signed-off-by: Paolo

[PATCH 19/26] throttle: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- block/throttle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 16/26] curl: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 08/26] file-posix: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- block/file-posix.c | 2 +- 1 file changed, 1

[PATCH 10/26] nbd: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- block/nbd.c | 10 +- 1 file changed, 5

[PATCH 15/26] copy-before-write: add missing coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
Callers of coroutine_fn must be coroutine_fn themselves, or the call must be within "if (qemu_in_coroutine())". Apply coroutine_fn to functions where this holds. Reviewed-by: Alberto Faria Signed-off-by: Paolo Bonzini --- block/copy-before-write.c | 8 1 file changed, 4

[PATCH 05/26] coroutine: remove incorrect coroutine_fn annotations

2022-09-22 Thread Paolo Bonzini
qemu_coroutine_get_aio_context inspects a coroutine, but it does not have to be called from the coroutine itself (or from any coroutine). Reviewed-by: Alberto Faria Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- include/qemu/coroutine.h | 2 +- util/qemu-coroutine.c| 2 +- 2

<    1   2   3   4   >