Re: [PATCH v2] e1000e: set RX desc status with DD flag in a separate operation

2022-09-26 Thread Jason Wang
在 2022/9/14 20:16, Ding Hui 写道: Like commit 034d00d48581 ("e1000: set RX descriptor status in a separate operation"), there is also same issue in e1000e, which would cause lost packets or stop sending packets to VM with DPDK. Do similar fix in e1000e. Resolves:

Re: [PATCH 2/4] hw/intc: sifive_plic.c: Fix interrupt priority index.

2022-09-26 Thread Jim Shu
Hi Tyler, Thanks for the explanation. I understand the issue here. I think we should align the priority base in each RISC-V platform to the same value (no matter 0x0 or 0x4) if they use PLIC in the same way. Thanks, Jim Shu On Tue, Sep 27, 2022 at 4:04 AM Tyler Ng wrote: > > Hi Jim, > >

Re: [PATCH] qemu-nbd: set timeout to qemu-nbd socket

2022-09-26 Thread luzhipeng
在 2022/9/26 20:44, Vladimir Sementsov-Ogievskiy 写道: On 9/26/22 14:34, Denis V. Lunev wrote: On 9/26/22 12:05, Vladimir Sementsov-Ogievskiy wrote: [+ Den] On 9/25/22 16:53, luzhipeng wrote: From: lu zhipeng Prevent the NBD socket stuck all the time, So set timeout. Signed-off-by: lu

[no subject]

2022-09-26 Thread 张 泽宇
unsubscribe

x86, pflash, unassigned memory access

2022-09-26 Thread Alexey Kardashevskiy
Hi! I am trying qemu-system-x86_64 with OVMF with the q35 machine, the complete command line is below. It works fine (including SEV on AMD EPYC), but these 2 parameters make me wonder if I miss something: -drive if=pflash,format=raw,unit=0,file=/home/aik/OVMF_CODE.fd,readonly=on,id=MYPF

Re: [PATCH v2] disas/riscv.c: rvv: Add disas support for vector instructions

2022-09-26 Thread Alistair Francis
On Fri, Sep 23, 2022 at 2:27 PM Alistair Francis wrote: > > On Fri, Aug 26, 2022 at 1:26 PM Yang Liu wrote: > > > > Tested with https://github.com/ksco/rvv-decoder-tests > > > > Expected checkpatch errors for consistency and brevity reasons: > > > > ERROR: line over 90 characters > > ERROR:

Re: [RFC PATCH] ast2600: Fix CPU features

2022-09-26 Thread Joel Stanley
On Mon, 26 Sept 2022 at 07:05, Cédric Le Goater wrote: > > On 9/26/22 08:26, Cédric Le Goater wrote: > > Currently, the CPU features exposed to the AST2600 QEMU machines are : > > > >half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt > >vfpd32 lpae evtstrm > > > > But, the

Re: [PULL 00/25] Kraxel 20220926 patches

2022-09-26 Thread Stefan Hajnoczi
Hi Gerd, I'm dropping this pull request because it breaks boot-serial-test for ppc64-softmmu. See my reply to the "hcd-ohci: Fix inconsistency when resetting ohci root hubs" patch for more info. Stefan

Re: [PULL 13/25] hcd-ohci: Fix inconsistency when resetting ohci root hubs

2022-09-26 Thread Stefan Hajnoczi
On Mon, 26 Sept 2022 at 06:29, Gerd Hoffmann wrote: > > From: Qiang Liu > > I found an assertion failure in usb_cancel_packet() and posted my analysis in > https://gitlab.com/qemu-project/qemu/-/issues/1180. I think this issue is > because the inconsistency when resetting ohci root hubs. > >

[RFC v2] hw/registerfields: add `FIELDx_1CLEAR()` macro

2022-09-26 Thread Wilfred Mallawa
From: Wilfred Mallawa Changes from V1: * Instead of needing all field bits to be set we clear the field if any are set. If the field is 0/clear then no change. Adds a helper macro that implements the register `w1c` functionality. Ex: uint32_t data =

Re: [PATCH v1 2/7] contrib/gitdm: add mapping for Loongson Technology

2022-09-26 Thread gaosong
在 2022/9/26 下午9:46, Alex Bennée 写道: Please confirm you are happy with this mapping. Signed-off-by: Alex Bennée Cc: Xiaojuan Yang Cc: Song Gao --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) Acked-by: Song Gao Thanks Song Gao diff --git a/contrib/gitdm/domain-map

Re: [PATCH v4 5/5] test/acpi/bios-tables-test: SSDT: update golden master binaries

2022-09-26 Thread Robert Hoo
On Mon, 2022-09-26 at 15:22 +0200, Igor Mammedov wrote: > > > 0800200c9a66"), One, 0x05, Local0, One) > > > +CreateDWordField (Local3, Zero, STTS) > > > +CreateField (Local3, 0x20, (LEN << 0x03), > > > LDAT) > > > +Name (LSA, Buffer

Re: [PATCH v3 37/54] tests/qtest: {ahci, ide}-test: Use relative path for temporary files for win32

2022-09-26 Thread Bin Meng
Hi Thomas, On Tue, Sep 27, 2022 at 12:20 AM Thomas Huth wrote: > > On 25/09/2022 13.30, Bin Meng wrote: > > From: Bin Meng > > > > These test cases uses "blkdebug:path/to/config:path/to/image" for > > testing. On Windows, absolute file paths contain the delimiter ':' > > which causes the

Re: [PATCH v2 3/3] hw/timer: ibex_timer.c: Add support for writes to mtime

2022-09-26 Thread Tyler Ng
Hi Eddie, On Mon, Sep 26, 2022 at 2:06 PM Dong, Eddie wrote: > > > > -Original Message- > > From: Qemu-devel > > On Behalf Of Tyler Ng > > Sent: Thursday, September 22, 2022 8:59 AM > > To: open list:RISC-V ; qemu-devel@nongnu.org > > Developers > > Cc: Alistair Francis ; Meng, Bin >

Re: [PATCH v2 3/3] hw/timer: ibex_timer.c: Add support for writes to mtime

2022-09-26 Thread Tyler Ng
On Thu, Sep 22, 2022 at 2:45 PM Philippe Mathieu-Daudé wrote: > On 22/9/22 17:58, Tyler Ng wrote: > > 1. Adds fields to hold the value of mtime in timer_upper0 and > timer_lower0. > > > > 2. Changes the read and write functions to use the mtime fields. > > > > 3. Updates the value of mtime in

RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

2022-09-26 Thread Ji, Ruili
[AMD Official Use Only - General] Hi Anthony, You could change the mail name as following: Signed-off-by: Aaron Liu Signed-off-by: Ruili Ji Thank you very much for your help!  Ruili -Original Message- From: Anthony PERARD Sent: 2022年9月26日 23:12 To: Ji, Ruili Cc:

Re: [PATCH v2 1/3] hw/watchdog: wdt_ibex_aon.c: Implement the watchdog for the OpenTitan

2022-09-26 Thread Tyler Ng
Hi Eddie, On Mon, Sep 26, 2022 at 1:46 PM Dong, Eddie wrote: > > > > -Original Message- > > From: Qemu-devel > > On Behalf Of Tyler Ng > > Sent: Thursday, September 22, 2022 8:59 AM > > To: open list:RISC-V ; qemu-devel@nongnu.org > > Developers > > Cc: Alistair Francis ; Meng, Bin >

Re: [PATCH v2 1/3] hw/watchdog: wdt_ibex_aon.c: Implement the watchdog for the OpenTitan

2022-09-26 Thread Tyler Ng
Hi Thomas, On Thu, Sep 22, 2022 at 9:17 AM Thomas Huth wrote: > On 22/09/2022 17.58, Tyler Ng wrote: > > This commit adds most of an implementation of the OpenTitan Always-On > > Timer. The documentation for this timer is found here: > > > > https://docs.opentitan.org/hw/ip/aon_timer/doc/ > > >

回复: [PATCH v1 7/7] contrib/gitdm: add China Telecom to the domain map

2022-09-26 Thread huang...@chinatelecom.cn
Yes,  this is my contribution account. Thanks. 发件人:Alex Bennée 日期:2022年9月26日 21:46主题:[PATCH v1 7/7] contrib/gitdm: add China Telecom to the domain map收件人:qemu-devel@nongnu.orgPlease confirm if this is a corporate contribution account. Signed-off-by: Alex Bennée Cc: Hyman Huang(黄勇) ---

Re: [PATCH v6 00/25] ppc4xx_sdram QOMify and clean ups

2022-09-26 Thread BALATON Zoltan
On Mon, 26 Sep 2022, Daniel Henrique Barboza wrote: On 9/26/22 14:09, Daniel Henrique Barboza wrote: Zoltan, I've started to push some patches to ppc-next. Patches 1-13 are already pushed and I'm running tests on patches 14-17. Assuming everything is ok we'll be left with patches 18-25 to

Re: [PATCH v6 00/25] ppc4xx_sdram QOMify and clean ups

2022-09-26 Thread BALATON Zoltan
On Mon, 26 Sep 2022, Cédric Le Goater wrote: On 9/24/22 14:27, BALATON Zoltan wrote: This is the end of the QOMify series started by Cédric. This series handles the SDRAM controller models to clean them up, QOMify and unify them and at least partially clean up the mess that has accumulated

Re: [PATCH v2 22/37] target/i386: reimplement 0x0f 0x78-0x7f, add AVX

2022-09-26 Thread Richard Henderson
On 9/26/22 07:24, Paolo Bonzini wrote: On Sat, Sep 24, 2022 at 10:43 PM Richard Henderson wrote: +static void decode_0F79(DisasContext *s, CPUX86State *env, X86OpEntry *entry, uint8_t *b) +{ +if (s->prefix & PREFIX_REPNZ) { +entry->gen = gen_INSERTQ_r; +} else if (s->prefix &

Re: [PATCH v1 1/9] hw: encode accessing CPU index in MemTxAttrs

2022-09-26 Thread Richard Henderson
On 9/25/22 13:02, Alex Bennée wrote: I'm not keen on adding another field like this. Hmm I thought it was unavoidable from Edgar's comment: "CPU's can also have a Master-IDs (Requester IDs) which are unrelated to the Clusters CPU index. This is used for example in the Xilinx ZynqMP

Re: [PATCH v2] RISC-V: Add support for Ztso

2022-09-26 Thread Richard Henderson
On 9/23/22 10:49, Palmer Dabbelt wrote:    The Ztso extension was recently frozen, this adds it as a CPU property    and adds various fences throughout the port in order to allow TSO    targets to function on weaker hosts.  We need no fences for AMOs as    they're already SC, the placess we

Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-26 Thread Richard Henderson
On 9/21/22 16:03, Claudio Fontana wrote: On 9/21/22 14:16, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 16/9/22 11:27, Markus Armbruster wrote: Claudio Fontana writes: improve error handling during module load, by changing: bool module_load_one(const char *prefix, const

Re: [PATCH v1 9/9] gdbstub: move guest debug support check to ops

2022-09-26 Thread Richard Henderson
On 9/22/22 14:58, Alex Bennée wrote: This removes the final hard coding of kvm_enabled() in gdbstub and moves the check to an AccelOps. Signed-off-by: Alex Bennée Cc: Mads Ynddal --- accel/kvm/kvm-cpus.h | 1 + gdbstub/internals.h| 1 + include/sysemu/accel-ops.h | 1 +

Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

2022-09-26 Thread Laurent Vivier
Le 26/09/2022 à 23:40, Jason A. Donenfeld a écrit : On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier wrote: Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit : Various tools, such as kexec-tools and m68k-bootinfo, expect each bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the

Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

2022-09-26 Thread Jason A. Donenfeld
On Mon, Sep 26, 2022 at 11:42 PM Laurent Vivier wrote: > > Le 26/09/2022 à 23:40, Jason A. Donenfeld a écrit : > > On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier wrote: > >> > >> Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit : > >>> Various tools, such as kexec-tools and m68k-bootinfo,

Re: [PATCH v2 00/13] Misc ppc/mac machines clean up

2022-09-26 Thread Daniel Henrique Barboza
Mark, It seems that you're usually push mac changes via a qemu-macppc PR (git log says that the last one was Jan 2021), so feel free to keep doing so. If it's convenient for you I can pick them via ppc-next as well. Just let me know. Thanks, Daniel On 9/25/22 09:38, BALATON Zoltan wrote:

Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

2022-09-26 Thread Jason A. Donenfeld
On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier wrote: > > Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit : > > Various tools, such as kexec-tools and m68k-bootinfo, expect each > > bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the > > padding to fill this out as such. > > >

Re: [RFC 3/4] tcg/plugins: Support for inter-plugin interactions

2022-09-26 Thread Andrew S. Fasano
> Andrew Fasano writes: > > > Expand tcg-plugin system to allow for plugins to export functions > > and callbacks that can be used by other plugins. Exported functions > > can be called at runtime by other loaded plugins. Loaded plugins > > can register functions with exported callbacks and have

Re: [RFC 4/4] tcg/plugins: Add example pair of QPP plugins

2022-09-26 Thread Andrew S. Fasano
From: Alex Bennée > Andrew Fasano writes: > > > The first plugin, qpp_srv exposes two functions and one callback that other > > plugins can leverage. These functions are described in the corresponding > > header file. > > > > The second plugin, qpp_client, imports this header file, registers

Re: [RFC 4/4] tcg/plugins: Add example pair of QPP plugins

2022-09-26 Thread Andrew S. Fasano
From: Alex Bennée > Andrew Fasano writes: > > > The first plugin, qpp_srv exposes two functions and one callback that other > > plugins can leverage. These functions are described in the corresponding > > header file. > > > > The second plugin, qpp_client, imports this header file, registers

Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

2022-09-26 Thread Laurent Vivier
Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit : Various tools, such as kexec-tools and m68k-bootinfo, expect each bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the padding to fill this out as such. Also, break apart the padding additions from the other field length

Re: [PATCH 2/2] target/m68k: use M68K_FEATURE_MOVEFROMSR_PRIV feature for move_from_sr privilege check

2022-09-26 Thread Laurent Vivier
Le 25/09/2022 à 15:48, Mark Cave-Ayland a écrit : Now that M68K_FEATURE_M68000 has been renamed to M68K_FEATURE_M68K it is easier to see that the privilege exception check is wrong: it is currently only generated for ColdFire CPUs when in fact it should also be generated for Motorola CPUs from

Re: [RFC 2/4] tcg/plugins: Automatically define CURRENT_PLUGIN

2022-09-26 Thread Andrew S. Fasano
From: Alex Bennée > Andrew Fasano writes: > > > Use plugin filenames to set the preprocessor variable CURRENT_PLUGIN > > as a string during plugin compilation. > > > > Signed-off-by: Andrew Fasano > > --- > > contrib/plugins/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [RFC 0/4] Support interactions between TCG plugins

2022-09-26 Thread Andrew S. Fasano
From: Alex Bennée > Andrew Fasano writes: > > > Hello, > > > > I'm requesting comments on the following series of patches expanding the > > TCG plugin system to add the "QEMU Plugin-to-Plugin (QPP)" interface > > that allows for interactions between TCG plugins. The goal of this > > interface

Re: [RFC PATCH 0/3] MIPS decodetree conversion attempt

2022-09-26 Thread Philippe Mathieu-Daudé via
Hi Jiaxun, On Mon, Sep 26, 2022 at 4:44 PM Jiaxun Yang wrote: > > 2022年9月21日 13:41,Jiaxun Yang 写道: > > > > Hi, > > > > This is my attempt of converting MIPS translation code into decodetree. > > > > Currently only MIPS I to MIPS Release 5 arithmatic functions are converted. > > Old decoding

Re: [PATCH 1/2] target/m68k: increase size of m68k CPU features from uint32_t to uint64_t

2022-09-26 Thread Laurent Vivier
Le 25/09/2022 à 15:48, Mark Cave-Ayland a écrit : There are already 32 feature bits in use, so change the size of the m68k CPU features to uint64_t (along with the associated m68k_feature() functions) to allow up to 64 feature bits to be used. At the same time make use of the BIT_ULL() macro

RE: [PATCH v2 3/3] hw/timer: ibex_timer.c: Add support for writes to mtime

2022-09-26 Thread Dong, Eddie
> -Original Message- > From: Qemu-devel > On Behalf Of Tyler Ng > Sent: Thursday, September 22, 2022 8:59 AM > To: open list:RISC-V ; qemu-devel@nongnu.org > Developers > Cc: Alistair Francis ; Meng, Bin > ; Thomas Huth ; Paolo > Bonzini ; Palmer Dabbelt ; > Laurent Vivier > Subject:

Re: [PULL 00/12] riscv-to-apply queue

2022-09-26 Thread Stefan Hajnoczi
On Mon, 26 Sept 2022 at 17:00, Alistair Francis wrote: > > On Tue, Sep 27, 2022 at 5:29 AM Stefan Hajnoczi wrote: > > > > On Fri, 23 Sept 2022 at 00:08, Alistair Francis > > wrote: > > > are available in the Git repository at: > > > > > > g...@github.com:alistair23/qemu.git

Re: [PULL 00/12] riscv-to-apply queue

2022-09-26 Thread Alistair Francis
On Tue, Sep 27, 2022 at 5:29 AM Stefan Hajnoczi wrote: > > On Fri, 23 Sept 2022 at 00:08, Alistair Francis > wrote: > > are available in the Git repository at: > > > > g...@github.com:alistair23/qemu.git pull-riscv-to-apply-20220923-2 > > Hi Alistair, > Please use the HTTPS GitHub repo URL in

RE: [PATCH v2 1/3] hw/watchdog: wdt_ibex_aon.c: Implement the watchdog for the OpenTitan

2022-09-26 Thread Dong, Eddie
> -Original Message- > From: Qemu-devel > On Behalf Of Tyler Ng > Sent: Thursday, September 22, 2022 8:59 AM > To: open list:RISC-V ; qemu-devel@nongnu.org > Developers > Cc: Alistair Francis ; Meng, Bin > ; Thomas Huth ; Paolo > Bonzini ; Palmer Dabbelt ; > Laurent Vivier > Subject:

Re: [PATCH 2/4] hw/intc: sifive_plic.c: Fix interrupt priority index.

2022-09-26 Thread Tyler Ng
Hi Jim, Thanks for raising this comment. I think I understand where the confusion happens and it's because in the OpenTitan machine (which uses the sifive plic), it uses 0x00 as the priority base by default, which was the source of the problems. I'll drop this commit in the next version. -Tyler

Re: [PATCH v2 03/11] target/arm: ensure HVF traps set appropriate MemTxAttrs

2022-09-26 Thread Alexander Graf
On 26.09.22 15:38, Alex Bennée wrote: As most HVF devices are done purely in software we need to make sure we properly encode the source CPU in MemTxAttrs. This will allow the device emulations to use those attributes rather than relying on current_cpu (although current_cpu will still be

Re: [PATCH v2 01/11] hw: encode accessing CPU index in MemTxAttrs

2022-09-26 Thread Alexander Graf
On 26.09.22 15:38, Alex Bennée wrote: We currently have hacks across the hw/ to reference current_cpu to work out what the current accessing CPU is. This breaks in some cases including using gdbstub to access HW state. As we have MemTxAttrs to describe details about the access lets extend it

[PATCH v9 16/16] net: stream: add QAPI events to report connection state

2022-09-26 Thread Laurent Vivier
The netdev reports NETDEV_STREAM_CONNECTED event when the backend is connected, and NETDEV_STREAM_EOC when it is disconnected. The NETDEV_STREAM_CONNECTED event includes the URI of the destination address. Signed-off-by: Laurent Vivier --- net/stream.c | 11 +-- qapi/net.json | 46

[PATCH v9 09/16] net: dgram: make dgram_dst generic

2022-09-26 Thread Laurent Vivier
dgram_dst is a sockaddr_in structure. To be able to use it with unix socket, use a pointer to a generic sockaddr structure. Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- net/dgram.c | 73 - 1 file changed, 44 insertions(+), 29

[PATCH v9 14/16] net: stream: move to QIO to enable additional parameters

2022-09-26 Thread Laurent Vivier
Use QIOChannel, QIOChannelSocket and QIONetListener. This allows net/stream to use all the available parameters provided by SocketAddress. Signed-off-by: Laurent Vivier --- net/stream.c| 481 +--- qemu-options.hx | 4 +- 2 files changed, 171

[PATCH v9 10/16] net: dgram: move mcast specific code from net_socket_fd_init_dgram()

2022-09-26 Thread Laurent Vivier
It is less complex to manage special cases directly in net_dgram_mcast_init() and net_dgram_udp_init(). Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- net/dgram.c | 143 +++- 1 file changed, 73 insertions(+), 70 deletions(-) diff

[PATCH v9 01/16] net: introduce convert_host_port()

2022-09-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- include/qemu/sockets.h | 2 ++ net/net.c | 62 ++ 2 files changed, 34 insertions(+), 30 deletions(-) diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h index

[PATCH v9 15/16] tests/qtest: netdev: test stream and dgram backends

2022-09-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- tests/qtest/meson.build | 1 + tests/qtest/netdev-socket.c | 391 2 files changed, 392 insertions(+) create mode 100644 tests/qtest/netdev-socket.c diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index

[PATCH v9 12/16] qemu-sockets: move and rename SocketAddress_to_str()

2022-09-26 Thread Laurent Vivier
Rename SocketAddress_to_str() to socket_uri() and move it to util/qemu-sockets.c close to socket_parse(). socket_uri() generates a string from a SocketAddress while socket_parse() generates a SocketAddress from a string. Signed-off-by: Laurent Vivier Reviewed-by: David Gibson Reviewed-by: Dr.

[PATCH v9 11/16] net: dgram: add unix socket

2022-09-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- net/dgram.c | 65 ++--- qapi/net.json | 2 +- qemu-options.hx | 1 + 3 files changed, 64 insertions(+), 4 deletions(-) diff --git a/net/dgram.c b/net/dgram.c index

[PATCH v9 03/16] net: simplify net_client_parse() error management

2022-09-26 Thread Laurent Vivier
All net_client_parse() callers exit in case of error. Move exit(1) to net_client_parse() and remove error checking from the callers. Suggested-by: Markus Armbruster Signed-off-by: Laurent Vivier Reviewed-by: Markus Armbruster --- include/net/net.h | 2 +- net/net.c | 6 ++

[PATCH v9 00/16] qapi: net: add unix socket type support to netdev backend

2022-09-26 Thread Laurent Vivier
"-netdev socket" only supports inet sockets. It's not a complex task to add support for unix sockets, but the socket netdev parameters are not defined to manage well unix socket parameters. As discussed in: "socket.c added support for unix domain socket datagram transport"

[PATCH v9 13/16] qemu-sockets: update socket_uri() and socket_parse() to be consistent

2022-09-26 Thread Laurent Vivier
To be consistent with socket_uri(), add 'tcp:' prefix for inet type in socket_parse(), by default socket_parse() use tcp when no prefix is provided (format is host:port). In socket_uri(), use 'vsock:' prefix for vsock type rather than 'tcp:' because it makes a vsock address look like an inet

[PATCH v9 06/16] net: socket: Don't ignore EINVAL on netdev socket connection

2022-09-26 Thread Laurent Vivier
From: Stefano Brivio Other errors are treated as failure by net_socket_connect_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio Signed-off-by: Laurent Vivier --- net/socket.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH v9 07/16] net: stream: Don't ignore EINVAL on netdev socket connection

2022-09-26 Thread Laurent Vivier
From: Stefano Brivio Other errors are treated as failure by net_stream_client_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio [lvivier: applied to net/stream.c] Signed-off-by: Laurent Vivier Reviewed-by: Daniel P.

[PATCH v9 05/16] qapi: net: add stream and dgram netdevs

2022-09-26 Thread Laurent Vivier
Copied from socket netdev file and modified to use SocketAddress to be able to introduce new features like unix socket. "udp" and "mcast" are squashed into dgram netdev, multicast is detected according to the IP address type. "listen" and "connect" modes are managed by stream netdev. An optional

[PATCH v9 04/16] qapi: net: introduce a way to bypass qemu_opts_parse_noisily()

2022-09-26 Thread Laurent Vivier
As qemu_opts_parse_noisily() flattens the QAPI structures ("type" field of Netdev structure can collides with "type" field of SocketAddress), we introduce a way to bypass qemu_opts_parse_noisily() and use directly visit_type_Netdev() to parse the backend parameters. More details from Markus:

[PATCH v9 02/16] net: remove the @errp argument of net_client_inits()

2022-09-26 Thread Laurent Vivier
The only caller passes _fatal, so use this directly in the function. It's what we do for -blockdev, -device, and -object. Suggested-by: Markus Armbruster Signed-off-by: Laurent Vivier Reviewed-by: Markus Armbruster Reviewed-by: David Gibson --- include/net/net.h | 2 +- net/net.c |

[PATCH v9 08/16] net: stream: add unix socket

2022-09-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Stefano Brivio --- net/stream.c| 108 +--- qapi/net.json | 2 +- qemu-options.hx | 1 + 3 files changed, 105 insertions(+), 6 deletions(-) diff --git a/net/stream.c b/net/stream.c index

Re: [PATCH] target/arm/kvm: Retry KVM_CREATE_VM call if it fails EINTR

2022-09-26 Thread Eric Auger
On 9/26/22 21:07, Peter Maydell wrote: > On Mon, 26 Sept 2022 at 19:08, Vitaly Chikunov wrote: >> >> Peter, >> >> On Mon, Sep 26, 2022 at 02:36:44PM +0100, Peter Maydell wrote: >>> Occasionally the KVM_CREATE_VM ioctl can return EINTR, even though >>> there is no pending signal to be taken. In

Re: [PULL 00/12] riscv-to-apply queue

2022-09-26 Thread Stefan Hajnoczi
On Fri, 23 Sept 2022 at 00:08, Alistair Francis wrote: > are available in the Git repository at: > > g...@github.com:alistair23/qemu.git pull-riscv-to-apply-20220923-2 Hi Alistair, Please use the HTTPS GitHub repo URL in pull requests. Setting separate "url" (HTTPS) and "pushUrl" (ssh)

Re: [PULL 00/39] target-arm queue

2022-09-26 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] target/arm/kvm: Retry KVM_CREATE_VM call if it fails EINTR

2022-09-26 Thread Peter Maydell
On Mon, 26 Sept 2022 at 19:08, Vitaly Chikunov wrote: > > Peter, > > On Mon, Sep 26, 2022 at 02:36:44PM +0100, Peter Maydell wrote: > > Occasionally the KVM_CREATE_VM ioctl can return EINTR, even though > > there is no pending signal to be taken. In commit 94ccff13382055 > > we added a

[PATCH v8 16/16] hw/xtensa: set machine->fdt in xtfpga_init()

2022-09-26 Thread Daniel Henrique Barboza
This will enable support for the 'dumpdtb' QMP/HMP command for all xtensa machines that uses a FDT. Signed-off-by: Daniel Henrique Barboza --- hw/xtensa/meson.build | 2 +- hw/xtensa/xtfpga.c| 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/xtensa/meson.build

[PATCH v8 10/16] hw/ppc: set machine->fdt in xilinx_load_device_tree()

2022-09-26 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the virtex_ml507 machine. Setting machine->fdt requires a MachineState pointer to be used inside xilinx_load_device_tree(). Let's change the function to receive this pointer from the caller. kernel_cmdline' can be retrieved directly from

[PATCH v8 09/16] hw/ppc: set machine->fdt in sam460ex_load_device_tree()

2022-09-26 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the sam460ex machine. Setting machine->fdt requires a MachineState pointer to be used inside sam460ex_load_device_tree(). Let's change the function to receive this pointer from the caller. 'ramsize' and 'kernel_cmdline' can be retrieved

[PATCH v8 15/16] hw/riscv: set machine->fdt in spike_board_init()

2022-09-26 Thread Daniel Henrique Barboza
This will enable support for the 'dumpdtb' QMP/HMP command for the spike machine. Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Bin Meng Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel Henrique Barboza --- hw/riscv/spike.c | 6 ++ 1 file changed, 6

[PATCH v8 02/16] hw/core: free ms->fdt in machine_finalize()

2022-09-26 Thread Daniel Henrique Barboza
ms->fdt must also be freed in machine_finalize() similar to what is already done with other MachineState objects. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Daniel Henrique Barboza --- hw/core/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/machine.c

[PATCH v8 06/16] hw/nios2: set machine->fdt in nios2_load_dtb()

2022-09-26 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for all nios2 machines that uses nios2_load_dtb(). Cc: Chris Wulff Cc: Marek Vasut Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel Henrique Barboza --- hw/nios2/boot.c | 8 +++- hw/nios2/meson.build | 2 +- 2 files

Re: [PATCH] target/arm/kvm: Retry KVM_CREATE_VM call if it fails EINTR

2022-09-26 Thread Vitaly Chikunov
Peter, On Mon, Sep 26, 2022 at 02:36:44PM +0100, Peter Maydell wrote: > Occasionally the KVM_CREATE_VM ioctl can return EINTR, even though > there is no pending signal to be taken. In commit 94ccff13382055 > we added a retry-on-EINTR loop to the KVM_CREATE_VM call in the > generic KVM code. Adopt

[PATCH v8 04/16] hw/mips: set machine->fdt in boston_mach_init()

2022-09-26 Thread Daniel Henrique Barboza
This will enable support for the 'dumpdtb' QMP/HMP command for the boston machine. 'dtb_load_data' can't be autofreed anymore, otherwise we'll free the fdt that is now being referenced by machine->fdt. Signed-off-by: Daniel Henrique Barboza --- hw/mips/boston.c | 5 - 1 file changed, 4

[PATCH v8 01/16] qmp/hmp, device_tree.c: introduce dumpdtb

2022-09-26 Thread Daniel Henrique Barboza
To save the FDT blob we have the '-machine dumpdtb=' property. With this property set, the machine saves the FDT in and exit. The created file can then be converted to plain text dts format using 'dtc'. There's nothing particularly sophisticated into saving the FDT that can't be done with the

[PATCH v8 03/16] hw/arm: do not free machine->fdt in arm_load_dtb()

2022-09-26 Thread Daniel Henrique Barboza
At this moment, arm_load_dtb() can free machine->fdt when binfo->dtb_filename is NULL. If there's no 'dtb_filename', 'fdt' will be retrieved by binfo->get_dtb(). If get_dtb() returns machine->fdt, as is the case of machvirt_dtb() from hw/arm/virt.c, fdt now has a pointer to machine->fdt. And, in

[PULL 13/14] s390x/s390-virtio-ccw: add zpcii-disable machine property

2022-09-26 Thread Thomas Huth
From: Matthew Rosato The zpcii-disable machine property can be used to force-disable the use of zPCI interpretation facilities for a VM. By default, this setting will be off for machine 7.2 and newer. Signed-off-by: Matthew Rosato Message-Id: <20220902172737.170349-9-mjros...@linux.ibm.com>

Re: [PATCH v2 4/4] virtio-gpu: Don't require udmabuf when blob support is enabled

2022-09-26 Thread Dmitry Osipenko
On 9/23/22 15:32, Gerd Hoffmann wrote: > On Tue, Sep 13, 2022 at 12:50:22PM +0200, Antonio Caggiano wrote: >> From: Dmitry Osipenko >> >> Host blobs don't need udmabuf, it's only needed by guest blobs. The host >> blobs are utilized by the Mesa virgl driver when persistent memory mapping >> is

Re: [PATCH] gtk: Add show_menubar=on|off command line option.

2022-09-26 Thread Bryce Mills
The patch adds "show_menubar" command line option for GTK UI similar to "show_tabs". This option allows to hide menu bar initially, it still can be toggled by shortcut and other shortcuts still work. Signed-off-by: Bryce Mills --- qapi/ui.json| 6 +- qemu-options.hx | 3 +++ ui/gtk.c

[PATCH v8 11/16] hw/ppc: set machine->fdt in pegasos2_machine_reset()

2022-09-26 Thread Daniel Henrique Barboza
We'll introduce a QMP/HMP command that requires machine->fdt to be set properly. Cc: BALATON Zoltan Cc: qemu-...@nongnu.org Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel Henrique Barboza --- hw/ppc/pegasos2.c | 4 1 file changed, 4 insertions(+)

[PULL 12/14] s390x/pci: reflect proper maxstbl for groups of interpreted devices

2022-09-26 Thread Thomas Huth
From: Matthew Rosato The maximum supported store block length might be different depending on whether the instruction is interpretively executed (firmware-reported maximum) or handled via userspace intercept (host kernel API maximum). Choose the best available value during group creation.

Re: [PATCH v6 00/25] ppc4xx_sdram QOMify and clean ups

2022-09-26 Thread Daniel Henrique Barboza
On 9/26/22 14:09, Daniel Henrique Barboza wrote: Zoltan, I've started to push some patches to ppc-next. Patches 1-13 are already pushed and I'm running tests on patches 14-17. Assuming everything is ok we'll be left with patches 18-25 to work on. Patches 01-17 queued in ppc-next. If a

[PULL 08/14] s390x/pci: enable for load/store interpretation

2022-09-26 Thread Thomas Huth
From: Matthew Rosato If the ZPCI_OP ioctl reports that is is available and usable, then the underlying KVM host will enable load/store intepretation for any guest device without a SHM bit in the guest function handle. For a device that will be using interpretation support, ensure the guest

[PATCH v8 08/16] hw/ppc: set machine->fdt in bamboo_load_device_tree()

2022-09-26 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the bamboo machine. Setting machine->fdt requires a MachineState pointer to be used inside bamboo_load_device_tree(). Let's change the function to receive this pointer from the caller. 'ramsize' and 'kernel_cmdline' can be retrieved

[PATCH v8 05/16] hw/microblaze: set machine->fdt in microblaze_load_dtb()

2022-09-26 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for all microblaze machines that uses microblaze_load_dtb(). Cc: Edgar E. Iglesias Signed-off-by: Daniel Henrique Barboza --- hw/microblaze/boot.c | 8 +++- hw/microblaze/meson.build | 2 +- 2 files changed, 8 insertions(+), 2

[PULL 04/14] target/s390x: support PRNO_TRNG instruction

2022-09-26 Thread Thomas Huth
From: "Jason A. Donenfeld" In order for hosts running inside of TCG to initialize the kernel's random number generator, we should support the PRNO_TRNG instruction, backed in the usual way with the qemu_guest_getrandom helper. This is confirmed working on Linux 5.19. Signed-off-by: Jason A.

Re: [PATCH v6 00/25] ppc4xx_sdram QOMify and clean ups

2022-09-26 Thread Cédric Le Goater
On 9/24/22 14:27, BALATON Zoltan wrote: This is the end of the QOMify series started by Cédric. This series handles the SDRAM controller models to clean them up, QOMify and unify them and at least partially clean up the mess that has accumulated around these in the past. This includes the not

[PATCH v8 00/16] QMP/HMP: introduce 'dumpdtb'

2022-09-26 Thread Daniel Henrique Barboza
Hi, This new version contains all changes proposed during the review process, all of them done in the patch that introduces dumpdtb. Other changes made: - Patch 14/14, the one that introduces the command, is now patch 1. This change is to make the other machine patches referencing 'dumpdtb

[PULL 02/14] linux-user/host/s390: Add vector instructions to host_signal_write()

2022-09-26 Thread Thomas Huth
From: Ilya Leoshkevich The new noexec test fails on s390x with "unexpected SEGV". This test overwrites code using libc's memcpy(), which uses VSTL instruction. host_signal_write() does not recognize it, which causes SEGV to be incorrectly forwarded to the test. Add all vector instructions that

Re: [PATCH v6 00/25] ppc4xx_sdram QOMify and clean ups

2022-09-26 Thread Daniel Henrique Barboza
Zoltan, I've started to push some patches to ppc-next. Patches 1-13 are already pushed and I'm running tests on patches 14-17. Assuming everything is ok we'll be left with patches 18-25 to work on. Thanks, Daniel On 9/24/22 09:27, BALATON Zoltan wrote: This is the end of the QOMify series

[PULL 14/14] Remove the slirp submodule (i.e. compile only with an external libslirp)

2022-09-26 Thread Thomas Huth
Since QEMU 7.1 we don't support Ubuntu 18.04 anymore, so the last big important Linux distro that did not have a pre-packaged libslirp has been dismissed. All other major distros seem to have a libslirp package in their distribution already - according to repology.org: Fedora 35: 4.6.1

[PULL 00/14] s390x patches and slirp submodule removal

2022-09-26 Thread Thomas Huth
Hi Stefan! The following changes since commit 6160d8ff81fb9fba70f5dad88d43ffd0fa44984c: Merge tag 'edgar/xilinx-next-2022-09-21.for-upstream' of https://github.com/edgarigl/qemu into staging (2022-09-22 13:24:28 -0400) are available in the Git repository at:

Re: [PATCH] x86: re-initialize RNG seed when selecting kernel

2022-09-26 Thread Jason A. Donenfeld
Hi Peter, On Mon, Sep 26, 2022 at 7:05 PM Peter Maydell wrote: > > On Mon, 26 Sept 2022 at 17:53, Jason A. Donenfeld wrote: > > On both x86 and dtb-based archs, the seed in memory is zeroed out by the > > kernel after reading. So, as far as the guest is concerned, there's > > forward secrecy.

[PULL 11/14] s390x/pci: let intercept devices have separate PCI groups

2022-09-26 Thread Thomas Huth
From: Matthew Rosato Let's use the reserved pool of simulated PCI groups to allow intercept devices to have separate groups from interpreted devices as some group values may be different. If we run out of simulated PCI groups, subsequent intercept devices just get the default group. Furthermore,

[PULL 10/14] s390x/pci: enable adapter event notification for interpreted devices

2022-09-26 Thread Thomas Huth
From: Matthew Rosato Use the associated kvm ioctl operation to enable adapter event notification and forwarding for devices when requested. This feature will be set up with or without firmware assist based upon the 'forwarding_assist' setting. Signed-off-by: Matthew Rosato Message-Id:

Re: [PATCH] x86: re-initialize RNG seed when selecting kernel

2022-09-26 Thread Peter Maydell
On Mon, 26 Sept 2022 at 17:53, Jason A. Donenfeld wrote: > On both x86 and dtb-based archs, the seed in memory is zeroed out by the > kernel after reading. So, as far as the guest is concerned, there's > forward secrecy. Except! Except if the guest has someway of > re-requesting that seed from

[PATCH v8 13/16] hw/ppc: set machine->fdt in spapr machine

2022-09-26 Thread Daniel Henrique Barboza
The pSeries machine never bothered with the common machine->fdt attribute. We do all the FDT related work using spapr->fdt_blob. We're going to introduce a QMP/HMP command to dump the FDT, which will rely on setting machine->fdt properly to work across all machine archs/types. Let's set

Re: [PATCH v1 4/7] contrib/gitdm: add WANG Xuerui to individual contributers

2022-09-26 Thread WANG Xuerui
Hi, On 2022/9/26 21:46, Alex Bennée wrote: His blog confirms he is not affiliated with Longsoon. It's spelled "Loongson" ;-) Signed-off-by: Alex Bennée Cc: WANG Xuerui --- contrib/gitdm/group-map-individuals | 1 + 1 file changed, 1 insertion(+) diff --git

[PULL 06/14] Update linux headers to v6.0-rc4

2022-09-26 Thread Thomas Huth
From: Chenyi Qiang commit 7e18e42e4b280c85b76967a9106a13ca61c16179 Signed-off-by: Chenyi Qiang Reviewed-by: Cornelia Huck Message-Id: <20220915091035.3897-3-chenyi.qi...@intel.com> Signed-off-by: Thomas Huth --- include/standard-headers/asm-x86/bootparam.h | 7 +-

  1   2   3   4   >