Re: [PATCH v2 3/3] target/mips: Disable DSP ASE for Octeon68XX

2022-10-31 Thread Pavel Dovgalyuk
On 31.10.2022 16:25, Jiaxun Yang wrote: I don't have access to Octeon68XX hardware but accroading to my investigation Octeon never had DSP ASE support. As per "Cavium Networks OCTEON Plus CN50XX Hardware Reference Manual" CP0C3_DSPP is reserved bit and read as 0. Also I do have access to a

[PATCH] target/mips: enable LBX/LWX/* instructions for Octeon

2022-10-31 Thread Pavel Dovgalyuk
This patch changes condition and function name for enabling indexed load instructions for Octeon vCPUs. Octeons do not have DSP extension, but implement LBX-and-others. Signed-off-by: Pavel Dovgalyuk --- target/mips/tcg/translate.c | 10 +++--- 1 file changed, 7 insertions(+), 3

Re: [PATCH v2 2/3] target/mips: Cast offset field of Octeon BBIT to int16_t

2022-10-31 Thread Pavel Dovgalyuk
Acked-by: Pavel Dovgalyuk On 31.10.2022 16:25, Jiaxun Yang wrote: As per "Cavium Networks OCTEON Plus CN50XX Hardware Reference Manual" offset field is signed 16 bit value. However arg_BBIT.offset is unsigned. We need to cast it as signed to do address calculation. Signed-off-by: Jiaxun Yang

Re: [PATCH v2] target/arm: honor HCR_E2H and HCR_TGE in ats_write64()

2022-10-31 Thread Richard Henderson
On 10/31/22 19:43, Ake Koomsin wrote: We need to check HCR_E2H and HCR_TGE to select the right MMU index for the correct translation regime. To check for EL2&0 translation regime: - For S1E0*, S1E1* and S12E* ops, check both HCR_E2H and HCR_TGE - For S1E2* ops, check only HCR_E2H

[PATCH] tests/qtest: migration-test: Enable TLS PSK tests for win32

2022-10-31 Thread Bin Meng
Since commit f1018ea0a30f ("tests: avoid DOS line endings in PSK file"), the bug of the helper test_tls_psk_init_common() that caused TLS PSK tests to fail on Windows was fixed. Let's enable these tests on win32. Signed-off-by: Bin Meng --- tests/qtest/migration-test.c | 14 -- 1

Re: [PATCH 2/3] hw/riscv: sifive_e: Support the watchdog timer of HiFive 1 rev b.

2022-10-31 Thread Tommy Wu
Hi Alistair, >> RISCV_ACLINT_DEFAULT_TIMEBASE_FREQ, false); > Newline here >> +qdev_get_gpio_in(DEVICE(s->plic), SIFIVE_E_AON_WDT_IRQ)); > and here please I've deleted the public create function and added newlines in patch v2. Thank you for the review ! Regards, Tommy On Mon,

Re: [PATCH 1/3] hw/misc: sifive_e_aon: Support the watchdog timer of HiFive 1 rev b.

2022-10-31 Thread Tommy Wu
Hi Alistair, Sorry for the late reply. Thank you for the great feedback! > Can you please keep all variable declarations at the top of the code block. I've fixed it in patch v2. > Does the guest not expect to read the values back? The devices : AON-LFROSC, AON-BACKUP, AON_PMU haven't been

[PATCH v2 3/3] tests/qtest: sifive-e-aon-watchdog-test.c : Add QTest of watchdog of sifive_e

2022-10-31 Thread Tommy Wu
Add some simple tests of the watchdog timer in the always-on domain device of HiFive 1 rev b. Signed-off-by: Tommy Wu --- tests/qtest/meson.build | 3 + tests/qtest/sifive-e-aon-watchdog-test.c | 650 +++ 2 files changed, 653 insertions(+) create mode

[PATCH v2 2/3] hw/riscv: sifive_e: Support the watchdog timer of HiFive 1 rev b.

2022-10-31 Thread Tommy Wu
Create the AON device when we realize the sifive_e machine. This patch only implemented the functionality of the watchdog timer, not all the functionality of the AON device. Signed-off-by: Tommy Wu --- hw/riscv/Kconfig| 1 + hw/riscv/sifive_e.c | 13 +++--

[PATCH v2 0/3] Implement the watchdog timer of HiFive 1 rev b.

2022-10-31 Thread Tommy Wu
The HiFive 1 rev b includes a watchdog module based on a 32-bit counter. The watchdog timer is in the always-on domain device of HiFive 1 rev b, so this patch added the AON device to the sifive_e machine. This patch only implemented the functionality of the watchdog timer, not all the

[PATCH v2 1/3] hw/misc: sifive_e_aon: Support the watchdog timer of HiFive 1 rev b.

2022-10-31 Thread Tommy Wu
The watchdog timer is in the always-on domain device of HiFive 1 rev b, so this patch added the AON device to the sifive_e machine. This patch only implemented the functionality of the watchdog timer. Signed-off-by: Tommy Wu --- hw/misc/Kconfig| 3 + hw/misc/meson.build

Re: [PATCH 0/4] Endianess and coding style fixes for SVQ event idx support

2022-10-31 Thread Jason Wang
On Sat, Oct 29, 2022 at 12:02 AM Eugenio Pérez wrote: > > Some fixes that did not get in time for the last net pull request. > > Eugenio Pérez (4): > vhost: Delete useless casting > vhost: convert byte order on SVQ used event write > vhost: Fix lines over 80 characters > vhost: convert

Re: [PATCH 0/4] Shadow VirtQueue event index support

2022-10-31 Thread Jason Wang
On Fri, Oct 28, 2022 at 2:50 PM Eugenio Perez Martin wrote: > > On Fri, Oct 28, 2022 at 4:44 AM Jason Wang wrote: > > > > > > 在 2022/10/27 04:58, Michael S. Tsirkin 写道: > > > On Thu, Oct 20, 2022 at 05:52:47PM +0200, Eugenio Pérez wrote: > > >> Event idx helps to reduce the number of

Re: [PATCH 4/4] vhost: convert byte order on avail_event read

2022-10-31 Thread Jason Wang
在 2022/10/31 20:35, Michael S. Tsirkin 写道: On Mon, Oct 31, 2022 at 09:29:53AM +0100, Eugenio Perez Martin wrote: On Sat, Oct 29, 2022 at 12:53 AM Philippe Mathieu-Daudé wrote: On 28/10/22 18:02, Eugenio Pérez wrote: This causes errors on virtio modern devices on big endian hosts

Re: [PATCH V5 2/4] intel-iommu: drop VTDBus

2022-10-31 Thread Jason Wang
On Sun, Oct 30, 2022 at 6:39 PM Yi Liu wrote: > > On 2022/10/28 14:14, Jason Wang wrote: > > We introduce VTDBus structure as an intermediate step for searching > > the address space. This works well with SID based matching/lookup. But > > when we want to support SID plus PASID based address

Re: [PATCH V5 4/4] intel-iommu: PASID support

2022-10-31 Thread Jason Wang
On Mon, Oct 31, 2022 at 5:28 PM Yi Liu wrote: > > On 2022/10/31 17:15, Jason Wang wrote: > > On Mon, Oct 31, 2022 at 2:43 PM Michael S. Tsirkin wrote: > >> > >> On Fri, Oct 28, 2022 at 09:49:36PM +0800, Yi Liu wrote: > >>> On 2022/10/28 14:14, Jason Wang wrote: > This patch introduce

[PATCH] qapi: virtio: Fix the introduced version

2022-10-31 Thread Han Han
The items of qapi/virtio.json are introduced at a5ebce38576. They will be in the version 7.2 not 7.1. Signed-off-by: Han Han --- qapi/virtio.json | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/qapi/virtio.json b/qapi/virtio.json index

Re: [PATCH] vhost-vdpa: fix assert !virtio_net_get_subqueue(nc)->async_tx.elem in virtio_net_reset

2022-10-31 Thread Jason Wang
On Sat, Oct 29, 2022 at 1:28 AM Si-Wei Liu wrote: > > Hi Jason, > > This one is a one-line simple bug fix but seems to be missed from the pull > request. If there's a v2 for the PULL, would appreciate if you can piggyback. > Thanks in advance! > > Regards, > -Siwei > I've queued this for rc1.

Re: [PATCH v4 1/3] util/main-loop: Fix maximum number of wait objects for win32

2022-10-31 Thread Bin Meng
Hi Daniel, On Wed, Oct 26, 2022 at 12:41 AM Bin Meng wrote: > > On Wed, Oct 19, 2022 at 6:20 PM Bin Meng wrote: > > > > From: Bin Meng > > > > The maximum number of wait objects for win32 should be > > MAXIMUM_WAIT_OBJECTS, not MAXIMUM_WAIT_OBJECTS + 1. > > > > Signed-off-by: Bin Meng > > ---

[PATCH v7 10/17] pcie: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of a PCIe function which calls pci_add_capability() in turn is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki Acked-by: Jonathan Cameron (for CXL parts) --- docs/pcie_sriov.txt

[PATCH v7 15/17] hw/vfio/pci: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
The code generating errors in pci_add_capability has a comment which says: > Verify that capabilities don't overlap. Note: device assignment > depends on this check to verify that the device is not broken. > Should never trigger for emulated devices, but it's helpful for > debugging these.

[PATCH v7 17/17] pci: Remove legacy errp from pci_add_capability

2022-10-31 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 20 +--- include/hw/pci/pci.h | 12 ++-- 2 files changed, 7 insertions(+), 25 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 9e62c8e75d..b352a9c732 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@

[PATCH v7 16/17] virtio-pci: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v7 14/17] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v7 13/17] pci/slotid: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of slotid_cap_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/slotid_cap.c | 8 ++-- 1 file changed, 2

[PATCH v7 06/17] eepro100: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v7 09/17] hw/pci/pci_bridge: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of pci_bridge_ssvid_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/i82801b11.c | 14 ++

[PATCH v7 07/17] hw/nvme: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v7 00/17] pci: Abort if pci_add_capability fails

2022-10-31 Thread Akihiko Odaki
pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring

[PATCH v7 11/17] pci/shpc: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of shpc_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/pci_bridge_dev.c | 2 +-

[PATCH v7 12/17] msix: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v7 01/17] hw/vfio/pci: Ensure MSI and MSI-X do not overlap

2022-10-31 Thread Akihiko Odaki
pci_add_capability() checks whether capabilities overlap, and notifies its caller so that it can properly handle the case. However, in the most cases, the capabilities actually never overlap, and the interface incurred extra error handling code, which is often incorrect or suboptimal. For such

[PATCH v7 04/17] ahci: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v7 03/17] hw/i386/amd_iommu: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v7 05/17] e1000e: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate here because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v7 08/17] msi: Omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msi_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msi.c | 9 + 1 file changed, 1 insertion(+), 8

[PATCH v7 02/17] pci: Allow to omit errp for pci_add_capability

2022-10-31 Thread Akihiko Odaki
pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring

Re: [PATCH v9 7/8] KVM: Handle page fault for private memory

2022-10-31 Thread Isaku Yamahata
On Fri, Oct 28, 2022 at 02:55:45PM +0800, Chao Peng wrote: > On Wed, Oct 26, 2022 at 02:54:25PM -0700, Isaku Yamahata wrote: > > On Tue, Oct 25, 2022 at 11:13:43PM +0800, > > Chao Peng wrote: > > > > > A memslot with KVM_MEM_PRIVATE being set can include both fd-based > > > private memory and

Re: [PATCH v2 2/3] hw/i386/acpi-build: Resolve redundant attribute

2022-10-31 Thread Bernhard Beschow
Am 31. Oktober 2022 17:41:59 UTC schrieb "Michael S. Tsirkin" : >On Mon, Oct 31, 2022 at 01:45:29PM +0100, Igor Mammedov wrote: >> On Fri, 28 Oct 2022 12:34:18 +0200 >> Bernhard Beschow wrote: >> >> > The is_piix4 attribute is set once in one location and read once in >> > another. Doing both in

Re: [PULL 08/30] target/arm: Add ptw_idx to S1Translate

2022-10-31 Thread Philippe Mathieu-Daudé
On 25/10/22 18:39, Peter Maydell wrote: From: Richard Henderson Hoist the computation of the mmu_idx for the ptw up to get_phys_addr_with_struct and get_phys_addr_twostage. This removes the duplicate check for stage2 disabled from the middle of the walk, performing it only once.

Re: [PATCH v6 00/19] Misc ppc/mac machines clean up

2022-10-31 Thread Philippe Mathieu-Daudé
On 31/10/22 23:09, BALATON Zoltan wrote: On Mon, 31 Oct 2022, Mark Cave-Ayland wrote: On 30/10/2022 22:23, BALATON Zoltan wrote: On Sun, 30 Oct 2022, Mark Cave-Ayland wrote: On 28/10/2022 12:56, BALATON Zoltan wrote: Since only one week is left until freeze starts I've included some more

Re: [PATCH v6 00/19] Misc ppc/mac machines clean up

2022-10-31 Thread BALATON Zoltan
On Mon, 31 Oct 2022, Mark Cave-Ayland wrote: On 30/10/2022 22:23, BALATON Zoltan wrote: On Sun, 30 Oct 2022, Mark Cave-Ayland wrote: On 28/10/2022 12:56, BALATON Zoltan wrote: Since only one week is left until freeze starts I've included some more patches in this version that I've intended to

Re: [PATCH v4 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-31 Thread Philippe Mathieu-Daudé
On 31/10/22 22:35, Chuck Zmudzinski wrote: When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck

Re: [PULL 25/47] accel/tcg: Add restore_state_to_opc to TCGCPUOps

2022-10-31 Thread Richard Henderson
On 11/1/22 08:27, Mark Cave-Ayland wrote: On 31/10/2022 20:53, Stefan Hajnoczi wrote: On Mon, 31 Oct 2022 at 16:42, Richard Henderson wrote: On 11/1/22 04:56, Christian Schoenebeck wrote: On Wednesday, October 26, 2022 4:10:54 AM CET Richard Henderson wrote: BTW Richard, could you add a

[PULL v2 05/13] accel/tcg: Introduce cpu_unwind_state_data

2022-10-31 Thread Richard Henderson
Add a way to examine the unwind data without actually restoring the data back into env. Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- accel/tcg/internal.h | 4 +-- include/exec/exec-all.h | 21 --- accel/tcg/translate-all.c | 74

[PULL v2 10/13] accel/tcg: Remove reset_icount argument from cpu_restore_state_from_tb

2022-10-31 Thread Richard Henderson
The value passed is always true. Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- accel/tcg/internal.h | 2 +- accel/tcg/tb-maint.c | 4 ++-- accel/tcg/translate-all.c | 15 +++ 3 files changed, 10 insertions(+), 11 deletions(-) diff --git

[PULL v2 11/13] target/i386: Expand eflags updates inline

2022-10-31 Thread Richard Henderson
The helpers for reset_rf, cli, sti, clac, stac are completely trivial; implement them inline. Drop some nearby #if 0 code. Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/i386/helper.h| 5 - target/i386/tcg/cc_helper.c |

[PULL v2 13/13] tests/tcg/multiarch: Add munmap-pthread.c

2022-10-31 Thread Richard Henderson
From: Ilya Leoshkevich Add a test to detect races between munmap() and creating new threads. Signed-off-by: Ilya Leoshkevich Message-Id: <20221028124227.2354792-3-...@linux.ibm.com> [rth: add more return insns] Signed-off-by: Richard Henderson --- tests/tcg/multiarch/munmap-pthread.c | 79

[PULL v2 09/13] accel/tcg: Remove will_exit argument from cpu_restore_state

2022-10-31 Thread Richard Henderson
The value passed is always true, and if the target's synchronize_from_tb hook is non-trivial, not exiting may be erroneous. Reviewed-by: Claudio Fontana Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 5 + accel/tcg/cpu-exec-common.c | 2 +-

[PULL v2 06/13] target/i386: Use cpu_unwind_state_data for tpr access

2022-10-31 Thread Richard Henderson
Avoid cpu_restore_state, and modifying env->eip out from underneath the translator with TARGET_TB_PCREL. There is some slight duplication from x86_restore_state_to_opc, but it's just a few lines. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1269 Reviewed-by: Claudio Fontana

[PULL v2 12/13] accel/tcg: Complete cpu initialization before registration

2022-10-31 Thread Richard Henderson
Delay cpu_list_add until realize is complete, so that cross-cpu interaction does not happen with incomplete cpu state. For this, we must delay plugin initialization out of tcg_exec_realizefn, because no cpu_index has been assigned. Fixes a problem with cross-cpu jump cache flushing, when the

[PULL v2 07/13] target/openrisc: Always exit after mtspr npc

2022-10-31 Thread Richard Henderson
We have called cpu_restore_state asserting will_exit. Do not go back on that promise. This affects icount. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL v2 08/13] target/openrisc: Use cpu_unwind_state_data for mfspr

2022-10-31 Thread Richard Henderson
Since we do not plan to exit, use cpu_unwind_state_data and extract exactly the data requested. This is a bug fix, in that we no longer clobber dflag. Consider: l.j L2 // branch l.mfspr r1, ppc// delay L1: boom L2: l.lwa r3, (r4) Here, dflag

[PULL v2 04/13] tcg/tci: fix logic error when registering helpers via FFI

2022-10-31 Thread Richard Henderson
From: Icenowy Zheng When registering helpers via FFI for TCI, the inner loop that iterates parameters of the helper reuses (and thus pollutes) the same variable used by the outer loop that iterates all helpers, thus made some helpers unregistered. Fix this logic error by using a dedicated

[PULL v2 03/13] tcg/sparc64: Remove sparc32plus constraints

2022-10-31 Thread Richard Henderson
With sparc64 we need not distinguish between registers that can hold 32-bit values and those that can hold 64-bit values. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/sparc64/tcg-target-con-set.h | 16 + tcg/sparc64/tcg-target-con-str.h | 3 -

[PULL v2 02/13] tcg/sparc64: Rename from tcg/sparc

2022-10-31 Thread Richard Henderson
Emphasize that we only support full 64-bit code generation. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- meson.build | 4 +--- tcg/{sparc => sparc64}/tcg-target-con-set.h | 0 tcg/{sparc =>

[PULL v2 01/13] tcg/sparc: Remove support for sparc32plus

2022-10-31 Thread Richard Henderson
Since 9b9c37c36439, we have only supported sparc64 cpus. Debian and Gentoo now only support 64-bit sparc64 userland, so it is time to drop the 32-bit sparc64 userland: sparc32plus. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson ---

[PULL v2 00/13] tcg-next patch queue

2022-10-31 Thread Richard Henderson
at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20221031-2 for you to fetch changes up to 83d92559cdf0ce842e52e5bbf230f7f62a6206aa: tests/tcg/multiarch: Add munmap-pthread.c (2022-11-01 08:31:41 +1100) Remove sparc32plus

[PATCH v4 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2022-10-31 Thread Chuck Zmudzinski
Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI

[PATCH v4 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD

2022-10-31 Thread Chuck Zmudzinski
This is a series of two patches: The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough configure options are set with when building for the linux target os. The second fixes a regression that was introduced many years ago with the upgrade from the Qemu traditional device

[PATCH v4 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-31 Thread Chuck Zmudzinski
When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck Zmudzinski --- v2: Remove From: tag at top

Re: [PULL 25/47] accel/tcg: Add restore_state_to_opc to TCGCPUOps

2022-10-31 Thread Mark Cave-Ayland
On 31/10/2022 20:53, Stefan Hajnoczi wrote: On Mon, 31 Oct 2022 at 16:42, Richard Henderson wrote: On 11/1/22 04:56, Christian Schoenebeck wrote: On Wednesday, October 26, 2022 4:10:54 AM CET Richard Henderson wrote: BTW Richard, could you add a message-id tag to your queued TCG patches?

Re: [PATCH] accel/tcg: Complete cpu initialization before registration

2022-10-31 Thread Richard Henderson
On 10/31/22 22:07, Ilya Leoshkevich wrote: @@ -1580,15 +1580,13 @@ void tcg_flush_jmp_cache(CPUState *cpu) { CPUJumpCache *jc = cpu->tb_jmp_cache; -if (likely(jc)) { -for (int i = 0; i < TB_JMP_CACHE_SIZE; i++) { -qatomic_set(>array[i].tb, NULL); -} -

Re: [PULL 25/47] accel/tcg: Add restore_state_to_opc to TCGCPUOps

2022-10-31 Thread Stefan Hajnoczi
On Mon, 31 Oct 2022 at 16:42, Richard Henderson wrote: > On 11/1/22 04:56, Christian Schoenebeck wrote: > > On Wednesday, October 26, 2022 4:10:54 AM CET Richard Henderson wrote: > > BTW Richard, could you add a message-id tag to your queued TCG patches? > > Sometimes I remember, but I don't use

Re: [PATCH v6 00/19] Misc ppc/mac machines clean up

2022-10-31 Thread Mark Cave-Ayland
On 30/10/2022 22:23, BALATON Zoltan wrote: On Sun, 30 Oct 2022, Mark Cave-Ayland wrote: On 28/10/2022 12:56, BALATON Zoltan wrote: Since only one week is left until freeze starts I've included some more patches in this version that I've intended to submit after the clean ups but we're running

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Stefan Hajnoczi
On Mon, 31 Oct 2022 at 16:37, Michael S. Tsirkin wrote: > > On Mon, Oct 31, 2022 at 04:12:24PM -0400, Stefan Hajnoczi wrote: > > Another CI failure: > > https://gitlab.com/qemu-project/qemu/-/jobs/3253817492 > > > > Stefan > > Thanks! > Freeze rules only require pull request on list so I think

Re: [PULL 25/47] accel/tcg: Add restore_state_to_opc to TCGCPUOps

2022-10-31 Thread Richard Henderson
On 11/1/22 04:56, Christian Schoenebeck wrote: On Wednesday, October 26, 2022 4:10:54 AM CET Richard Henderson wrote: Add a tcg_ops hook to replace the restore_state_to_opc function call. Because these generic hooks cannot depend on target-specific types, temporarily, copy the current

Re: [PATCH 1/2] qpci_device_enable: Allow for command bits hardwired to 0

2022-10-31 Thread Michael S. Tsirkin
On Mon, Oct 24, 2022 at 09:46:20AM +, Lev Kujawski wrote: > Devices like the PIIX3/4 IDE controller do not support certain modes > of operation, such as memory space accesses, and indicate this lack of > support by hardwiring the applicable bits to zero. Extend the QEMU > PCI device testing

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 04:12:24PM -0400, Stefan Hajnoczi wrote: > Another CI failure: > https://gitlab.com/qemu-project/qemu/-/jobs/3253817492 > > Stefan Thanks! Freeze rules only require pull request on list so I think it's ok if I handle the failout and resubmit day after tomorrow, right? --

Re: [PATCH v4 2/3] io_uring: use LuringState from the running thread

2022-10-31 Thread Stefan Hajnoczi
On Mon, Oct 31, 2022 at 08:59:35AM -0400, Emanuele Giuseppe Esposito wrote: > Remove usage of aio_context_acquire by always submitting asynchronous > AIO to the current thread's LuringState. > > In order to prevent mistakes from the caller side, avoid passing LuringState > in

Re: [PATCH v4 1/3] linux-aio: use LinuxAioState from the running thread

2022-10-31 Thread Stefan Hajnoczi
On Mon, Oct 31, 2022 at 08:59:34AM -0400, Emanuele Giuseppe Esposito wrote: > @@ -56,10 +59,8 @@ struct LinuxAioState { > io_context_t ctx; > EventNotifier e; > > -/* io queue for submit at batch. Protected by AioContext lock. */ > +/* All data is only used in one I/O thread.

Re: [PATCH v4 3/3] thread-pool: use ThreadPool from the running thread

2022-10-31 Thread Stefan Hajnoczi
On Mon, Oct 31, 2022 at 08:59:36AM -0400, Emanuele Giuseppe Esposito wrote: > @@ -251,6 +247,9 @@ BlockAIOCB *thread_pool_submit_aio(ThreadPool *pool, Documentation must be added to explain that thread_pool_submit_aio(), thread_pool_submit_co(), and thread_pool_submit() must be called on the

[PULL 10/14] hw/ppc/mac.h: Move PROM and KERNEL defines to board code

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan The PROM_FILENAME and KERNEL_* defines are used by mac_oldworld and mac_newworld but they don't have to be identical so these could be moved to the individual boards. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland

[PULL 11/14] hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan All that is left in mac.h now belongs to the nvram emulation so rename it accordingly and only include it where it is really used. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Message-Id: Signed-off-by: Mark Cave-Ayland --- MAINTAINERS

[PULL 05/14] mac_newworld: Clean up creation of Uninorth devices

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan Map regions in ascending order and reorganise code a bit to avoid some casts and move Uninorth parts together. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Message-Id: Signed-off-by: Mark Cave-Ayland --- hw/ppc/mac_newworld.c | 37

[PULL 03/14] mac_{old|new}world: Set tbfreq at declaration

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan The tbfreq variable is only set once in an if-else which can be done at the variable declaration saving some lines of code and making it simpler. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Message-Id:

[PULL 12/14] mac_nvram: Use NVRAM_SIZE constant

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan The NVRAM_SIZE constant was defined but not used. Rename it to MACIO_NVRAM_SIZE to match the device model and use it where appropriate. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Message-Id:

[PULL 01/14] mac_newworld: Drop some variables

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan Values not used frequently enough may not worth putting in a local variable, especially with names almost as long as the original value because that does not improve readability, to the contrary it makes it harder to see what value is used. Drop a few such variables. This is

[PULL 04/14] mac_{old|new}world: Avoid else branch by setting default value

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan Several variables are set in if-else branches where the else branch can be removed by setting a default value at the variable declaration which leads to simlpler code that is easier to follow. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Message-Id:

[PULL 14/14] mac_newworld: Turn CORE99_VIA_CONFIG defines into an enum

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan This might allow the compiler to check values. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Message-Id: Signed-off-by: Mark Cave-Ayland --- hw/ppc/mac_newworld.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PULL 00/14] qemu-macppc queue 20221031

2022-10-31 Thread Mark Cave-Ayland
The following changes since commit 5107fd3effb1cfec3b96d9e819f1605048640e31: net/vhost-vdpa.c: Fix clang compilation failure (2022-10-31 13:01:31 -0400) are available in the Git repository at: https://github.com/mcayland/qemu.git tags/qemu-macppc-20221031 for you to fetch changes up

[PULL 09/14] hw/ppc/mac.h: Move grackle-pcihost type declaration out to a header

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Message-Id: Signed-off-by: Mark Cave-Ayland --- MAINTAINERS | 1 + hw/pci-host/grackle.c | 14 +-- hw/ppc/mac.h | 3 --- hw/ppc/mac_oldworld.c | 1

[PULL 06/14] mac_{old|new}world: Reduce number of QOM casts

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan By storing the device pointers in a variable with the right type the number of QOM casts can be reduced which also makes the code more readable. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Message-Id: Signed-off-by:

[PULL 13/14] mac_{old|new}world: Code style fix adding missing braces to if-s

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Message-Id: Signed-off-by: Mark Cave-Ayland --- hw/ppc/mac_newworld.c | 6 -- hw/ppc/mac_oldworld.c | 9 ++--- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/ppc/mac_newworld.c

[PULL 07/14] hw/ppc/mac.h: Move newworld specific parts out from shared header

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan Move the parts specific to and only used by mac99 out from the shared mac.h into mac_newworld.c where they better belong. Signed-off-by: BALATON Zoltan Reviewed-by: Mark Cave-Ayland Message-Id: Signed-off-by: Mark Cave-Ayland --- hw/ppc/mac.h | 24

[PULL 02/14] mac_oldworld: Drop some more variables

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan Drop some more local variables additionally to commit b8df32555ce5 to match clean ups done to mac_newwold in previous patch. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Message-Id:

[PULL 08/14] hw/ppc/mac.h: Move macio specific parts out from shared header

2022-10-31 Thread Mark Cave-Ayland
From: BALATON Zoltan Move the parts specific to and only used by macio out from the shared mac.h into macio.c where they better belong. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Message-Id: Signed-off-by: Mark Cave-Ayland ---

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Stefan Hajnoczi
Another CI failure: https://gitlab.com/qemu-project/qemu/-/jobs/3253817492 Stefan

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Stefan Hajnoczi
Here is another CI failure: qemu-system-i386: current -smp configuration requires kernel irqchip and X2APIC API support. Broken pipe ../tests/qtest/libqtest.c:179: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) TAP parsing error: Too few tests run (expected

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Stefan Hajnoczi
Hi Michael, I removed the local variable in virtio_crypto_req_complete() since it's unused: -g_autofree struct iovec *in_iov_copy = req->in_iov; Stefan

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Stefan Hajnoczi
Hi Michael, The fuzzer is not happy with qpci_device_enable(): https://gitlab.com/qemu-project/qemu/-/jobs/3253817499 Stefan

Re: [PATCH v9 4/5] hw/mem/cxl-type3: Add CXL CDAT Data Object Exchange

2022-10-31 Thread Ira Weiny
On Tue, Oct 25, 2022 at 11:56:17AM +0100, Jonathan Cameron wrote: > On Mon, 24 Oct 2022 13:42:54 -0400 > Gregory Price wrote: > > > On Fri, Oct 14, 2022 at 04:10:44PM +0100, Jonathan Cameron wrote: > > > From: Huai-Cheng Kuo > > > > > > The CDAT can be specified in two ways. One is to add

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 03:35:28PM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 31, 2022 at 03:31:54PM -0400, Michael S. Tsirkin wrote: > > On Mon, Oct 31, 2022 at 03:19:25PM -0400, Stefan Hajnoczi wrote: > > > On Mon, 31 Oct 2022 at 15:14, Stefan Hajnoczi wrote: > > > > > > > > On Mon, 31 Oct

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 03:31:54PM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 31, 2022 at 03:19:25PM -0400, Stefan Hajnoczi wrote: > > On Mon, 31 Oct 2022 at 15:14, Stefan Hajnoczi wrote: > > > > > > On Mon, 31 Oct 2022 at 08:52, Michael S. Tsirkin wrote: > > > > Lei He (4): > > > >

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 03:19:25PM -0400, Stefan Hajnoczi wrote: > On Mon, 31 Oct 2022 at 15:14, Stefan Hajnoczi wrote: > > > > On Mon, 31 Oct 2022 at 08:52, Michael S. Tsirkin wrote: > > > Lei He (4): > > > virtio-crypto: Support asynchronous mode > > > > The following clang warning

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Stefan Hajnoczi
On Mon, 31 Oct 2022 at 15:14, Stefan Hajnoczi wrote: > > On Mon, 31 Oct 2022 at 08:52, Michael S. Tsirkin wrote: > > Lei He (4): > > virtio-crypto: Support asynchronous mode > > The following clang warning breaks the build. Please resend a fixed > pull request, thanks! On second thought,

Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups

2022-10-31 Thread Stefan Hajnoczi
On Mon, 31 Oct 2022 at 08:52, Michael S. Tsirkin wrote: > Lei He (4): > virtio-crypto: Support asynchronous mode The following clang warning breaks the build. Please resend a fixed pull request, thanks! clang -m64 -mcx16 -Ilibqemu-x86_64-softmmu.fa.p -I. -I.. -Itarget/i386

Re: [PATCH v4 4/4] hw/usb: fix tab indentation

2022-10-31 Thread Amarjargal Gundjalam
On 26/10/22 00:22, Thomas Huth wrote: On 25/10/2022 16.28, Amarjargal Gundjalam wrote: The TABs should be replaced with spaces, to make sure that we have a consistent coding style with an indentation of 4 spaces everywhere. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/370

Re: [PULL 0/4] Patches for Windows

2022-10-31 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] block/blkio: Make driver nvme-io_uring take a "path" instead of a "filename"

2022-10-31 Thread Stefan Hajnoczi
On Sat, Oct 29, 2022 at 12:38:54AM +0100, Alberto Faria wrote: > The nvme-io_uring driver expects a character special file such as > /dev/ng0n1. Follow the convention of having a "filename" option when a > regular file is expected, and a "path" option otherwise. > > This makes io_uring the only

  1   2   3   4   5   >