Re: [PATCH for-8.0 6/7] hw/intc/xics: Convert TYPE_ICS to 3-phase reset

On 11/25/22 12:52, Peter Maydell wrote: Convert the TYPE_ICS class to 3-phase reset; this will allow us to convert the TYPE_PHB3_MSI class which inherits from it. Signed-off-by: Peter Maydell Reviewed-by: Cédric Le Goater Thanks, C. --- hw/intc/xics.c | 9 + 1 file changed,

Re: [PATCH for-8.0 5/7] hw/intc/xics: Reset TYPE_ICS objects with device_cold_reset()

On 11/25/22 12:52, Peter Maydell wrote: The realize method for the TYPE_ICS class uses qemu_register_reset() to register a reset handler, as a workaround for the fact that currently objects which directly inherit from TYPE_DEVICE don't get automatically reset. However, the reset function

[PATCH] target/i386/hax: Add XCR0 support

Hi, maintainers, As HAXM v7.8.0 is released and it added XCR0 support, could you help to merge this patch to add corresponding support into HAX user space of QEMU? The patch has been included in the attachment. Thanks. Best Regards, Wenchao >From b1789f2523d06798b8883664bfa9a9df797bfccf Mon

Re: [PATCH for 7.2-rc3 v1 0/2] virtio fixes

On Thu, Nov 24, 2022 at 10:24:14PM +, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Thu, Nov 24, 2022 at 09:21:15AM +, Alex Bennée wrote: > >> > >> "Michael S. Tsirkin" writes: > >> > >> > On Wed, Nov 23, 2022 at 04:03:49PM +, Alex Bennée wrote: > >> >> > >> >>

[PATCH for-8.0 1/7] hw/virtio: Convert TYPE_VIRTIO_PCI to 3-phase reset

Convert the TYPE_VIRTIO_PCI class to 3-phase reset. This is necessary so that we can convert the subclass TYPE_VIRTIO_VGA_BASE also to 3-phase reset. Signed-off-by: Peter Maydell --- hw/virtio/virtio-pci.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH for-8.0 6/7] hw/intc/xics: Convert TYPE_ICS to 3-phase reset

Convert the TYPE_ICS class to 3-phase reset; this will allow us to convert the TYPE_PHB3_MSI class which inherits from it. Signed-off-by: Peter Maydell --- hw/intc/xics.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index

[PATCH for-8.0 7/7] hw/pci-host/pnv_phb3_msi: Convert TYPE_PHB3_MSI to 3-phase reset

Convert the TYPE_PHB3_MSI class to 3-phase reset, so we can avoid using the device_class_set_parent_reset() function. Signed-off-by: Peter Maydell --- include/hw/ppc/xics.h | 2 +- hw/pci-host/pnv_phb3_msi.c | 15 +-- 2 files changed, 10 insertions(+), 7 deletions(-) diff

[PATCH for-8.0 4/7] pci: Convert child classes of TYPE_PCIE_ROOT_PORT to 3-phase reset

Convert the TYPE_CXL_ROOT_PORT and TYPE_PNV_PHB_ROOT_PORT classes to 3-phase reset, so they don't need to use the deprecated device_class_set_parent_reset() function any more. We have to do both in the same commit, because they keep the parent_reset field in their common parent class's class

[PATCH for-8.0 2/7] hw/display/virtio-vga: Convert TYPE_VIRTIO_VGA_BASE to 3-phase reset

Convert the TYPE_VIRTIO_VGA_BASE class to 3-phase reset, so we don't need to use device_class_set_parent_reset() any more. Note that this is an abstract class itself; none of the subclasses override its reset method. Signed-off-by: Peter Maydell --- hw/display/virtio-vga.h | 2 +-

[PATCH for-8.0 0/7] virtio, pci, xics: 3-phase reset conversions

This patchset converts a miscellaneous collection of classes to 3-phase reset. The common link, as with other series I've sent out recently, is converting child classes that currently use device_class_set_parent_reset() so that we can remove that function. To do this we first need to convert the

[PATCH for-8.0 5/7] hw/intc/xics: Reset TYPE_ICS objects with device_cold_reset()

The realize method for the TYPE_ICS class uses qemu_register_reset() to register a reset handler, as a workaround for the fact that currently objects which directly inherit from TYPE_DEVICE don't get automatically reset. However, the reset function directly calls ics_reset(), which is the

[PATCH for-8.0 3/7] pci: Convert TYPE_PCIE_ROOT_PORT to 3-phase reset

Convert the TYPE_PCIE_ROOT_PORT device to 3-phase reset; this is a necessary precursor to converting any of its child classes. Signed-off-by: Peter Maydell --- hw/pci-bridge/pcie_root_port.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: guest Linux Kernel hangs and reports CPU lockup/stuck gitlab bug

Gerd Hoffmann writes: > On Wed, Sep 21, 2022 at 11:55:01AM +0200, Claudio Fontana wrote: >> Hi, >> >> I think this bug report warrants some attention, >> >> can Gerd take a look here? >> >> The GTK Clipboard commit seems involved: >> >> https://gitlab.com/qemu-project/qemu/-/issues/1150 > >

[PATCH v2 3/4] .gitlab-ci.d/windows.yml: Exclude qTests from 64-bit CI job for now

From: Bin Meng qTests don't run successfully with "--without-default-devices", so let's exclude the qtests from CI for now. Suggested-by: Marc-André Lureau Signed-off-by: Bin Meng --- (no changes since v1) .gitlab-ci.d/windows.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH v2 1/4] .gitlab-ci.d/windows.yml: Unify the prerequisite packages

From: Bin Meng At present the prerequisite packages for 64-bit and 32-bit builds are slightly different. Let's use the same packages for both for easier maintenance in the future. Signed-off-by: Bin Meng --- (no changes since v1) .gitlab-ci.d/windows.yml | 12 +++- 1 file changed,

[PATCH v2 4/4] tests/qtest: Enable qtest build on Windows

From: Bin Meng Now that we have fixed various test case issues as seen when running on Windows, let's enable the qtest build on Windows. Signed-off-by: Bin Meng Reviewed-by: Thomas Huth --- (no changes since v1) tests/qtest/meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH v2 2/4] .gitlab-ci.d/windows.yml: Keep 64-bit and 32-bit build scripts consistent

From: Bin Meng At present the build scripts of 32-bit and 64-bit are inconsistent. Let's keep them consistent for easier maintenance. While we are here, add some comments to explain that for the 64-bit job, "--without-default-devices" is a must have, at least for now. Signed-off-by: Bin Meng

Re: [PATCH 2/4] .gitlab-ci.d/windows.yml: Keep 64-bit and 32-bit build scripts consistent

On Fri, Nov 25, 2022 at 6:56 PM Thomas Huth wrote: > > On 25/11/2022 11.49, Bin Meng wrote: > > From: Bin Meng > > > > At present the build scripts of 32-bit and 64-bit are inconsistent. > > Let's keep them consistent for easier maintenance. > > > > While we are here, add some comments to

[PATCH v2] riscv: Add RISCVCPUConfig.satp_mode to set sv48, sv57, etc.

RISC-V specifies multiple sizes for addressable memory and Linux probes for the machine's support at startup via the satp CSR register (done in csr.c:validate_vm). As per the specification, sv64 must support sv57, which in turn must support sv48...etc. So we can restrict machine support by simply

Re: [PULL 0/4] Fixes 20221124 patches

On Fri, 25 Nov 2022 at 06:34, Gerd Hoffmann wrote: > > On Thu, Nov 24, 2022 at 01:03:21PM -0500, Stefan Hajnoczi wrote: > > On Thu, 24 Nov 2022 at 02:27, Gerd Hoffmann wrote: > > > usb+ui: fixes for 7.2 > > > > Hi Gerd, > > I already applied your previous pull request so these patches are in > >

Re: [PATCH 2/4] .gitlab-ci.d/windows.yml: Keep 64-bit and 32-bit build scripts consistent

On 25/11/2022 11.49, Bin Meng wrote: From: Bin Meng At present the build scripts of 32-bit and 64-bit are inconsistent. Let's keep them consistent for easier maintenance. While we are here, add some comments to explain that for the 64-bit job, "--without-default-devices" is a must have, at

[PATCH 4/4] tests/qtest: Enable qtest build on Windows

From: Bin Meng Now that we have fixed various test case issues as seen when running on Windows, let's enable the qtest build on Windows. Signed-off-by: Bin Meng Reviewed-by: Thomas Huth --- tests/qtest/meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 2/4] .gitlab-ci.d/windows.yml: Keep 64-bit and 32-bit build scripts consistent

From: Bin Meng At present the build scripts of 32-bit and 64-bit are inconsistent. Let's keep them consistent for easier maintenance. While we are here, add some comments to explain that for the 64-bit job, "--without-default-devices" is a must have, at least for now. Signed-off-by: Bin Meng

[PATCH 3/4] .gitlab-ci.d/windows.yml: Exclude qTests from 64-bit CI job for now

From: Bin Meng qTests don't run successfully with "--without-default-devices", so let's exclude the qtests from CI for now. Suggested-by: Marc-André Lureau Signed-off-by: Bin Meng --- .gitlab-ci.d/windows.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 1/4] .gitlab-ci.d/windows.yml: Unify the prerequisite packages

From: Bin Meng At present the prerequisite packages for 64-bit and 32-bit builds are slightly different. Let's use the same packages for both for easier maintenance in the future. Signed-off-by: Bin Meng --- .gitlab-ci.d/windows.yml | 12 +++- 1 file changed, 11 insertions(+), 1

Re: [PATCH v6 11/11] tests/qtest: Enable qtest build on Windows

Hi Marc-André, On Wed, Nov 23, 2022 at 10:14 PM Marc-André Lureau wrote: > > Hi Bin > > On Fri, Oct 28, 2022 at 9:06 AM Bin Meng wrote: > > > > Now that we have fixed various test case issues as seen when running > > on Windows, let's enable the qtest build on Windows. > > > > Signed-off-by:

[PATCH v4 0/2] Add OCP extended log to nvme QEMU

The motivation and description are contained in the last patch in this set. Will copy paste it here for convenience: In order to evaluate write amplification factor (WAF) within the storage stack it is important to know the number of bytes written to the controller. The existing SMART

[PATCH v4 2/2] nvme: Add physical writes/reads from OCP log

In order to evaluate write amplification factor (WAF) within the storage stack it is important to know the number of bytes written to the controller. The existing SMART log value of Data Units Written is too coarse (given in units of 500 Kb) and so we add the SMART health information extended from

[PATCH v4 1/2] nvme: Move adjustment of data_units{read,written}

In order to return the units_{read/written} required by the SMART log we need to shift the number of bytes value by BDRV_SECTORS_BITS and multiply by 1000. This is a prep patch that moves this adjustment to where the SMART log is calculated in order to use the stats struct for calculating OCP

Re: [PATCH] tests/qtest/migration-test: Fix unlink error and memory leaks

On Fri, Nov 25, 2022 at 09:30:54AM +0100, Thomas Huth wrote: > When running the migration test compiled with Clang from Fedora 37 > and sanitizers enabled, there is an error complaining about unlink(): > > ../tests/qtest/migration-test.c:1072:12: runtime error: null pointer > passed as

[PATCH] tests/qtest/migration-test: Fix unlink error and memory leaks

When running the migration test compiled with Clang from Fedora 37 and sanitizers enabled, there is an error complaining about unlink(): ../tests/qtest/migration-test.c:1072:12: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/unistd.h:858:48:

Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices

On Thu, Nov 24, 2022 at 01:36:29PM -0500, Stefan Hajnoczi wrote: On Wed, Nov 23, 2022 at 02:16:30PM +0100, Stefano Garzarella wrote: Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user backend, but we

<    1   2