On Wed, 2023-03-01 at 23:47 +0100, BALATON Zoltan wrote:
> On Wed, 1 Mar 2023, David Woodhouse wrote:
> > On Wed, 2023-03-01 at 19:01 +0100, BALATON Zoltan wrote:
> > >
> > > > It isn't a *correct* fix without a little bit more typing, but does
> > > > this make it work?
> > > >
> > > > diff
On 3/1/23 16:52, Nina Schoetterl-Glausch wrote:
On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote:
Add some basic examples for the definition of cpu topology
in s390x.
Signed-off-by: Pierre Morel
---
docs/system/s390x/cpu-topology.rst | 378 +
On Thu, Mar 02, 2023 at 11:45:00AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 02.03.23 11:37, Michael S. Tsirkin wrote:
> > On Thu, Mar 02, 2023 at 11:28:44AM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > On 02.03.23 00:09, Michael S. Tsirkin wrote:
> > > > On Thu, Feb 16, 2023 at
On 02.03.23 00:16, Michael S. Tsirkin wrote:
On Thu, Feb 16, 2023 at 09:03:38PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
v5: - don't deprecate IDs and return to ID & QOM scheme
- split complicated HOTPLUG_STATE patch into several ones
One small point: when you change patchset
On Thu, Mar 02, 2023 at 11:39:42AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 02.03.23 00:07, Michael S. Tsirkin wrote:
> > On Thu, Feb 16, 2023 at 09:03:56PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > We have DEVICE_DELETED event, that signals that device_del command is
> > >
On 2/1/23 12:19, Eugenio Perez Martin wrote:
On Wed, Feb 1, 2023 at 12:14 PM Maxime Coquelin
wrote:
Thanks Eugenio for working on this.
On 1/31/23 20:10, Eugenio Perez Martin wrote:
Hi,
The current approach of offering an emulated CVQ to the guest and map
the commands to vhost-user is
On 02.03.23 11:37, Michael S. Tsirkin wrote:
On Thu, Mar 02, 2023 at 11:28:44AM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 02.03.23 00:09, Michael S. Tsirkin wrote:
On Thu, Feb 16, 2023 at 09:03:51PM +0300, Vladimir Sementsov-Ogievskiy wrote:
To be used in further patch to identify the
On Thu, Feb 16, 2023 at 09:03:56PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We have DEVICE_DELETED event, that signals that device_del command is
> actually completed. But we don't have a counter-part for device_add.
> Still it's sensible for SHPC and PCIe-native hotplug, as there are time
>
On 02.03.23 00:07, Michael S. Tsirkin wrote:
On Thu, Feb 16, 2023 at 09:03:56PM +0300, Vladimir Sementsov-Ogievskiy wrote:
We have DEVICE_DELETED event, that signals that device_del command is
actually completed. But we don't have a counter-part for device_add.
Still it's sensible for SHPC and
On Thu, Mar 02, 2023 at 11:28:44AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 02.03.23 00:09, Michael S. Tsirkin wrote:
> > On Thu, Feb 16, 2023 at 09:03:51PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > To be used in further patch to identify the device hot-plugged into
> > >
From: Vladimir Sementsov-Ogievskiy
It should be zero, the only valid values are ON, OFF and BLINK.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Anton Kuchin
Message-Id: <20230216180356.156832-13-vsement...@yandex-team.ru>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S.
From: Jonathan Cameron
msix_init_exclusive_bar() can fail, so if it does cleanup the address space.
Reviewed-by: Ira Weiny
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
Message-Id: <20230206172816.8201-2-jonathan.came...@huawei.com>
Reviewed-by: Fan Ni
From: Maxime Coquelin
Backend's message and protocol features names were still
using "_SLAVE_" naming. For consistency with the new naming
convention, replace it with _BACKEND_.
Signed-off-by: Maxime Coquelin
Message-Id: <20230208203259.381326-2-maxime.coque...@redhat.com>
Reviewed-by:
From: Akihiko Odaki
vhost_dev_cleanup() clears vhost_dev so back up its vqs member to free
the memory pointed by the member.
Fixes: 821d28b88f ("vhost-user-rng: Add vhost-user-rng implementation")
Signed-off-by: Akihiko Odaki
Message-Id: <20230130140516.78078-1-akihiko.od...@daynix.com>
From: Ira Weiny
The cel_uuid was programatically generated previously because there was
no static initializer for network order UUIDs.
Use the new network order initializer for cel_uuid. Adjust
cxl_initialize_mailbox() because it can't fail now.
Update specification reference.
Reviewed-by:
From: Jonathan Cameron
Dropping the ID effects this table in trivial fashion.
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
Message-Id: <20230206172816.8201-8-jonathan.came...@huawei.com>
Reviewed-by: Fan Ni
Reviewed-by: Michael S. Tsirkin
From: Jason Wang
Without dt mode, device IOTLB notifier won't work since guest won't
send device IOTLB invalidation descriptor in this case. Let's fail
early instead of misbehaving silently.
Reviewed-by: Laurent Vivier
Tested-by: Laurent Vivier
Tested-by: Viktor Prutyanov
Buglink:
From: Vladimir Sementsov-Ogievskiy
ENABLED -> PWRONLY transition is not allowed and we handle it by
shpc_invalid_command(). But PWRONLY -> ENABLED transition is silently
ignored, which seems wrong. Let's handle it as correct.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Anton
From: Vladimir Sementsov-Ogievskiy
We'll need it in further patch to report bridge in QAPI event.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Anton Kuchin
Message-Id: <20230216180356.156832-6-vsement...@yandex-team.ru>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S.
From: Gregory Price
Remove usage of magic numbers when accessing capacity fields and replace
with CXL_CAPACITY_MULTIPLIER, matching the kernel definition.
Signed-off-by: Gregory Price
Reviewed-by: Davidlohr Bueso
Signed-off-by: Jonathan Cameron
Message-Id:
This reverts commit e935b735085dfa61d8e6d276b6f9e7687796a3c7.
Fixes: e935b73508 ("x86: return modified setup_data only if read as memory, not
as file")
Signed-off-by: Michael S. Tsirkin
Tested-by: Nathan Chancellor
Tested-by: Dov Murik
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael
From: Jonathan Cameron
Noticed as this prevents iASL disasembling the DSDT table.
Reviewed-by: Ira Weiny
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
Message-Id: <20230206172816.8201-7-jonathan.came...@huawei.com>
Reviewed-by: Fan Ni
Reviewed-by:
On Wed, Mar 1, 2023 at 9:04 AM Laszlo Ersek wrote:
>
> Hello Christian,
>
> On 3/1/23 08:17, Christian Ehrhardt wrote:
> > On Thu, Jan 5, 2023 at 8:14 AM Laszlo Ersek wrote:
> >>
> >> On 1/4/23 13:35, Michael S. Tsirkin wrote:
> >>> On Wed, Jan 04, 2023 at 10:01:38AM +0100, Laszlo Ersek wrote:
>
From: Carlos López
Check the return value for malloc(), avoiding a NULL pointer
dereference, and propagate error in function callers.
Found with GCC 13 and -fanalyzer:
../subprojects/libvhost-user/libvhost-user.c: In function
‘virtqueue_alloc_element’:
From: Vladimir Sementsov-Ogievskiy
Free slot if both conditions (power-led = OFF and state = DISABLED)
becomes true regardless of the sequence. It is similar to how PCIe
hotplug works.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Anton Kuchin
Message-Id:
From: Gregory Price
Current code sets to STORAGE_EXPRESS and then overrides it.
Reviewed-by: Davidlohr Bueso
Reviewed-by: Ira Weiny
Signed-off-by: Gregory Price
Signed-off-by: Jonathan Cameron
Message-Id: <20230206172816.8201-4-jonathan.came...@huawei.com>
Reviewed-by: Fan Ni
Reviewed-by:
From: Jason Wang
This patch introduces a new helper to unmap the range of a specific
IOMMU notifier.
Signed-off-by: Jason Wang
Message-Id: <20230223065924.42503-4-jasow...@redhat.com>
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
From: Zhenzhong Duan
On x86, there are two notifiers registered due to vtd-ir memory region
splitting the whole address space. During replay of the address space
for each notifier, the whole address space is scanned which is
unnecessory.
We only need to scan the space belong to notifier
On 02.03.23 00:09, Michael S. Tsirkin wrote:
On Thu, Feb 16, 2023 at 09:03:51PM +0300, Vladimir Sementsov-Ogievskiy wrote:
To be used in further patch to identify the device hot-plugged into
pcie-root-port.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Anton Kuchin
Wait a second
From: Eugenio Pérez
Not stopping them leave the device in a bad state when virtio-net
fronted device is unplugged with device_del monitor command.
This is not triggable in regular poweroff or qemu forces shutdown
because cleanup is called right after vhost_vdpa_dev_start(false). But
devices
From: Alex Bennée
While ioeventfds are needed for good performance with KVM guests it
should not be a gating requirement. We can run vhost-user backends using
simulated ioeventfds or inband signalling.
With this change I can run:
$QEMU $OPTS \
-display gtk,gl=on \
-device
From: Ira Weiny
Gcc requires constant versions of cpu_to_le* calls.
Add a 64 bit version.
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Ira Weiny
Signed-off-by: Jonathan Cameron
Message-Id:
From: Akihiko Odaki
vhost_dev_cleanup(), called from vu_gpio_disconnect(), clears vhost_dev
so vhost-user-gpio must set the members of vhost_dev each time
connecting.
do_vhost_user_cleanup() should also acquire the pointer to vqs directly
from VHostUserGPIO instead of referring to vhost_dev as
From: Jonathan Cameron
Fan Ni has offered to help out with QEMU CXL emulation reviewing.
Add him as a designated reviewer.
Thanks to Fan for stepping up after I requested help following Ben
stepping down as co-maintainer. Fan base been active in testing
and review recently so great to have Fan
From: Ira Weiny
UUID's are defined as network byte order fields. No static initializer
was available for UUID's in their standard big endian format.
Define a big endian initializer for UUIDs.
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Ira Weiny
Signed-off-by:
From: Vladimir Sementsov-Ogievskiy
Rename it to shpc_device_get_slot(), to mention what it does rather
than how it is used. It also helps to reuse it in further commit.
Also, add a return value and get rid of local_err.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Anton Kuchin
From: Jonathan Cameron
Fix capitalization difference between struct name and typedef.
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Ira Weiny
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
Message-Id:
From: Jason Wang
Signed-off-by: Jason Wang
Message-Id: <20230223065924.42503-5-jasow...@redhat.com>
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/arm/smmu-common.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff
When virt ACPI files were added, lots of duplicates were created because
we forgot that there's a no-prefix fallback: e.g. if
tests/data/acpi/virt/APIC.memhp is not there then test will use
tests/data/acpi/virt/APIC.
Drop these.
These were found with
$find tests/data/acpi/ -type f -exec
From: Jonathan Cameron
Next patch will drop duplicate _UID entry so allow update.
Reviewed-by: Gregory Price
Tested-by: Gregory Price
Signed-off-by: Jonathan Cameron
Message-Id: <20230206172816.8201-6-jonathan.came...@huawei.com>
Reviewed-by: Fan Ni
Reviewed-by: Michael S. Tsirkin
From: Philippe Mathieu-Daudé
Trace how IRQ are rooted from EP to RC.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20230211152239.88106-3-phi...@linaro.org>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/pci/pci.c| 8
hw/pci/trace-events | 1 +
From: Carlos López
In vhost_svq_poll(), if vhost_svq_get_buf() fails due to a device
providing invalid descriptors, len is left uninitialized and returned
to the caller, potentally leaking stack data or causing undefined
behavior.
Fix this by initializing len to 0.
Found with GCC 13 and
From: Vladimir Sementsov-Ogievskiy
PCI_EXP_SLTCTL_PIC_OFF is a value, and PCI_EXP_SLTCTL_PIC is a mask.
Happily PCI_EXP_SLTCTL_PIC_OFF is a maximum value for this mask and is
equal to the mask itself. Still the code looks like a bug. Let's make
it more reader-friendly.
Signed-off-by: Vladimir
From: Jason Wang
Without caching mode, MAP notifier won't work correctly since guest
won't send IOTLB update event when it establishes new mappings in the
I/O page tables. Let's fail the IOMMU notifiers early instead of
misbehaving silently.
Reviewed-by: Eric Auger
Tested-by: Viktor Prutyanov
From: Vladimir Sementsov-Ogievskiy
We already have indicator values in
include/standard-headers/linux/pci_regs.h , no reason to reinvent them
in include/hw/pci/pcie_regs.h. (and we already have usage of
PCI_EXP_SLTCTL_PWR_IND_BLINK and PCI_EXP_SLTCTL_PWR_IND_OFF in
hw/pci/pcie.c, so let's be
This reverts commit eebb38a5633a77f5fa79d6486d5b2fcf8fbe3c07.
Fixes: eebb38a563 ("x86: use typedef for SetupData struct")
Signed-off-by: Michael S. Tsirkin
Tested-by: Nathan Chancellor
Tested-by: Dov Murik
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Daniel
From: Vladimir Sementsov-Ogievskiy
In pcie_cap_slot_write_config() we check for PCI_EXP_SLTCTL_PWR_OFF in
a bad form. We should distinguish PCI_EXP_SLTCTL_PWR which is a "mask"
and PCI_EXP_SLTCTL_PWR_OFF which is value for that mask.
Better code is in pcie_cap_slot_unplug_request_cb() and in
From: Vladimir Sementsov-Ogievskiy
The structure type is unused. Also, it's the only user of corresponding
macros, so drop them too.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Anton Kuchin
Message-Id:
From: Vladimir Sementsov-Ogievskiy
*_by_mask() helpers shouldn't be used here (and that's the only one).
*_by_mask() helpers do shift their value argument, but in pcie.c code
we use values that are already shifted appropriately.
Happily, PCI_EXP_SLTCTL_PWR_ON is zero, so shift doesn't matter.
From: Eugenio Pérez
Since GUEST_ANNOUNCE is emulated the feature bit could be set without
backend support. This happens in the vDPA case.
However, backend vDPA parent may not have CVQ support. This causes an
incoherent feature set, and the driver may refuse to start. This
happens in
From: Maxime Coquelin
The Vhost-user specification changed feature and request
naming from _SLAVE_ to _BACKEND_.
This patch adopts the new naming convention.
Signed-off-by: Maxime Coquelin
Message-Id: <20230208203259.381326-4-maxime.coque...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
From: Maxime Coquelin
The Vhost-user specification changed feature and request
naming from _SLAVE_ to _BACKEND_.
This patch adopts the new naming convention.
Signed-off-by: Maxime Coquelin
Message-Id: <20230208203259.381326-3-maxime.coque...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
From: "Dr. David Alan Gilbert"
In bad9c5a516 ("virtio-rng-pci: fix migration compat for vectors") I
fixed the virtio-rng-pci migration compatibility, but it was discovered
that we also need to fix the other aliases of the device for the
transitional cases.
Fixes: 9ea02e8f1 ('virtio-rng-pci:
From: Peter Xu
We don't send UNMAP notification upon domain or global invalidation
which will lead the notifier can't work correctly. One example is to
use vhost remote IOTLB without enabling device IOTLB.
Fixing this by sending UNMAP notification.
Signed-off-by: Peter Xu
Signed-off-by: Jason
From: Akihiko Odaki
The expiration time provided for timer_mod() can overflow if a
ridiculously large value is set to the comparator register. The
resulting value can represent a past time after rounded, forcing the
timer to fire immediately. If the timer is configured as periodic, it
will rearm
From: Vladimir Sementsov-Ogievskiy
0 is not a valid state for the led. Let's start with OFF.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Anton Kuchin
Message-Id: <20230216180356.156832-2-vsement...@yandex-team.ru>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy
The result of the function is always one byte. The result is always
assigned to uint8_t variable. Also, shpc_get_status() should be
symmetric to shpc_set_status() which has uint8_t value argument.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Anton
This reverts commit 67f7e426e53833a5db75b0d813e8d537b8a75bd2.
Additionally to the automatic revert, I went over the code
and dropped all mentions of legacy_no_rng_seed manually,
effectively reverting a combination of 2 additional commits:
commit ffe2d2382e5f1aae1abc4081af407905ef380311
This reverts commit 763a2828bf313ed55878b09759dc435355035f2e.
Fixes: 763a2828bf ("x86: reinitialize RNG seed on system reboot")
Signed-off-by: Michael S. Tsirkin
Tested-by: Nathan Chancellor
Tested-by: Dov Murik
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Reviewed-by:
From: Yajun Wu
After live migration with virtio block device, qemu crash at:
#0 0x55914f46f795 in object_dynamic_cast_assert
(obj=0x559151b7b090, typename=0x55914f80fbc4 "qio-channel", file=0x55914f80fb90
"/images/testvfe/sw/qemu.gerrit/include/io/channel.h", line=30,
The following changes since commit 627634031092e1514f363fd8659a579398de0f0e:
Merge tag 'buildsys-qom-qdev-ui-20230227' of https://github.com/philmd/qemu
into staging (2023-02-28 15:09:18 +)
are available in the Git repository at:
https://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
This reverts commit 14b29fea742034186403914b4d013d0e83f19e78.
Signed-off-by: Michael S. Tsirkin
Fixes: 14b29fea74 ("x86: do not re-randomize RNG seed on snapshot load")
Tested-by: Nathan Chancellor
Tested-by: Dov Murik
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
From: Akihiko Odaki
vhost_dev_cleanup() clears vhost_dev so back up its vqs member to free
the memory pointed by the member.
Fixes: 7221d3b634 ("hw/virtio: add boilerplate for vhost-user-i2c device")
Signed-off-by: Akihiko Odaki
Message-Id: <20230130140435.78049-1-akihiko.od...@daynix.com>
This reverts commit cc63374a5a7c240b7d3be734ef589dabbefc7527.
Fixes: cc63374a5a ("x86: re-initialize RNG seed when selecting kernel")
Signed-off-by: Michael S. Tsirkin
Tested-by: Nathan Chancellor
Tested-by: Dov Murik
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
This reverts commit eac7a7791bb6d719233deed750034042318ffd56.
Fixes: eac7a7791b ("x86: don't let decompressed kernel image clobber
setup_data")
Signed-off-by: Michael S. Tsirkin
Tested-by: Nathan Chancellor
Tested-by: Dov Murik
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S.
From: Julia Suvorova
Since table type 4 of SMBIOS version 2.6 is shorter than 3.0, the
strings which follow immediately after the struct fields have been
overwritten by unconditional filling of later fields such as core_count2.
Make these fields dependent on the SMBIOS version.
Fixes:
On 01-03-23, 12:29, Stefan Hajnoczi wrote:
> What is the advantage over defining separate messages? Separate messages
> are cleaner and more typesafe.
I thought we wanted to keep single message for one kind of functionality, which
is mmap related quirks here. And so it would be better if we can
On 3/1/23 23:24, Bin Meng wrote:
Hi Palmer,
On Thu, Mar 2, 2023 at 10:08 AM Palmer Dabbelt wrote:
On Fri, 24 Feb 2023 09:45:16 PST (-0800), dbarb...@ventanamicro.com wrote:
Hi,
These cleanups were suggested by LIU Zhiwei during the review of the
RISCV_FEATURE_* cleanups, currently on
On 3/1/23 20:43, Palmer Dabbelt wrote:
On Wed, 22 Feb 2023 10:51:55 PST (-0800), dbarb...@ventanamicro.com wrote:
Hi,
In this version we gave up removing all the write_misa() body and,
instead, we went back to something closer to what we were doing in v2.
write_misa() is now gated behind an
601 - 669 of 669 matches
Mail list logo
