Re: [PATCH v4 6/6] hw/cxl: Add clear poison mailbox command support.

2023-03-03 Thread Ira Weiny
Jonathan Cameron wrote: > Current implementation is very simple so many of the corner > cases do not exist (e.g. fragmenting larger poison list entries) One coding style change at the bottom and I'm still hung up on that loop logic... > > Signed-off-by: Jonathan Cameron > --- > v4: > - Fix off

Re: [PATCH v2 0/6] target/i386: Support new Intel platform Instructions in CPUID enumeration

2023-03-03 Thread Xiaoyao Li
On 3/3/2023 2:59 PM, Tao Su wrote: Intel platforms Granite Rapids/Sierra Forest introduce below new instructions and CPUID leaves: - CMPccXADD CPUID.(EAX=7,ECX=1):EAX[bit 7] - AMX-FP16 CPUID.(EAX=7,ECX=1):EAX[bit 21] - AVX-IFMA CPUID.(EAX=7,ECX=1):EAX[bit 23] - AVX-VNNI-INT8

[PATCH v3 13/13] docs/devel: Document VFIO device dirty page tracking

2023-03-03 Thread Joao Martins
From: Avihai Horon Adjust the VFIO dirty page tracking documentation and add a section to describe device dirty page tracking. Signed-off-by: Avihai Horon Signed-off-by: Joao Martins --- docs/devel/vfio-migration.rst | 46 +++ 1 file changed, 31 insertions(+),

[PATCH v3 07/13] vfio/common: Record DMA mapped IOVA ranges

2023-03-03 Thread Joao Martins
According to the device DMA logging uAPI, IOVA ranges to be logged by the device must be provided all at once upon DMA logging start. As preparation for the following patches which will add device dirty page tracking, keep a record of all DMA mapped IOVA ranges so later they can be used for DMA

[PATCH v3 12/13] vfio/migration: Query device dirty page tracking support

2023-03-03 Thread Joao Martins
Now that everything has been set up for device dirty page tracking, query the device for device dirty page tracking support. Signed-off-by: Avihai Horon Signed-off-by: Joao Martins --- hw/vfio/migration.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/vfio/migration.c

[PATCH v3 04/13] vfio/common: Add VFIOBitmap and alloc function

2023-03-03 Thread Joao Martins
From: Avihai Horon There are already two places where dirty page bitmap allocation and calculations are done in open code. With device dirty page tracking being added in next patches, there are going to be even more places. To avoid code duplication, introduce VFIOBitmap struct and

[PATCH v3 05/13] vfio/common: Add helper to validate iova/end against hostwin

2023-03-03 Thread Joao Martins
In preparation to be used in device dirty tracking, move the code that finds the container host DMA window against a iova range. This avoids duplication on the common checks across listener callbacks. Signed-off-by: Joao Martins --- hw/vfio/common.c | 38 --

[PATCH v3 11/13] vfio/migration: Block migration with vIOMMU

2023-03-03 Thread Joao Martins
Migrating with vIOMMU will require either tracking maximum IOMMU supported address space (e.g. 39/48 address width on Intel) or range-track current mappings and dirty track the new ones post starting dirty tracking. This will be done as a separate series, so add a live migration blocker until that

[PATCH v3 10/13] vfio/common: Add device dirty page bitmap sync

2023-03-03 Thread Joao Martins
Add device dirty page bitmap sync functionality. This uses the device DMA logging uAPI to sync dirty page bitmap from the device. Device dirty page bitmap sync is used only if all devices within a container support device dirty page tracking. Signed-off-by: Avihai Horon Signed-off-by: Joao

[PATCH v3 00/13] vfio/migration: Device dirty page tracking

2023-03-03 Thread Joao Martins
Hey, Presented herewith a series based on the basic VFIO migration protocol v2 implementation [1]. It is split from its parent series[5] to solely focus on device dirty page tracking. Device dirty page tracking allows the VFIO device to record its DMAs and report them back when needed. This is

[PATCH v3 09/13] vfio/common: Extract code from vfio_get_dirty_bitmap() to new function

2023-03-03 Thread Joao Martins
From: Avihai Horon Extract the VFIO_IOMMU_DIRTY_PAGES ioctl code in vfio_get_dirty_bitmap() to its own function. This will help the code to be more readable after next patch will add device dirty page bitmap sync functionality. Signed-off-by: Avihai Horon Signed-off-by: Joao Martins ---

[PATCH v3 06/13] vfio/common: Consolidate skip/invalid section into helper

2023-03-03 Thread Joao Martins
The checks are replicated against region_add and region_del and will be soon added in another memory listener dedicated for dirty tracking. Move these into a new helper for avoid duplication. Signed-off-by: Joao Martins --- hw/vfio/common.c | 52 +++-

[PATCH v3 03/13] vfio/common: Abort migration if dirty log start/stop/sync fails

2023-03-03 Thread Joao Martins
From: Avihai Horon If VFIO dirty pages log start/stop/sync fails during migration, migration should be aborted as pages dirtied by VFIO devices might not be reported properly. This is not the case today, where in such scenario only an error is printed. Fix it by aborting migration in the above

[PATCH v3 01/13] vfio/common: Fix error reporting in vfio_get_dirty_bitmap()

2023-03-03 Thread Joao Martins
From: Avihai Horon Return -errno instead of -1 if VFIO_IOMMU_DIRTY_PAGES ioctl fails in vfio_get_dirty_bitmap(). Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater --- hw/vfio/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index

[PATCH v3 02/13] vfio/common: Fix wrong %m usages

2023-03-03 Thread Joao Martins
From: Avihai Horon There are several places where the %m conversion is used if one of vfio_dma_map(), vfio_dma_unmap() or vfio_get_dirty_bitmap() fail. The %m usage in these places is wrong since %m relies on errno value while the above functions don't report errors via errno. Fix it by using

[PATCH v3 08/13] vfio/common: Add device dirty page tracking start/stop

2023-03-03 Thread Joao Martins
Add device dirty page tracking start/stop functionality. This uses the device DMA logging uAPI to start and stop dirty page tracking by device. Device dirty page tracking is used only if all devices within a container support device dirty page tracking. Signed-off-by: Avihai Horon

RE: [PATCH 0/2] tcg: Merge two sequential labels

2023-03-03 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Friday, March 3, 2023 3:31 PM > To: qemu-devel@nongnu.org > Cc: a...@rev.ng; Taylor Simpson > Subject: [PATCH 0/2] tcg: Merge two sequential labels > > WARNING: This email originated from outside of Qualcomm. Please be wary > of

Re: [PATCH v2 07/20] vfio/common: Add VFIOBitmap and (de)alloc functions

2023-03-03 Thread Joao Martins
On 02/03/2023 14:52, Cédric Le Goater wrote: > Hello Joao, > > On 3/2/23 14:24, Joao Martins wrote: >> On 27/02/2023 14:09, Cédric Le Goater wrote: >>> On 2/22/23 18:49, Avihai Horon wrote: --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -320,6 +320,41 @@ const MemoryRegionOps

Re: [PATCH v2 10/20] vfio/common: Record DMA mapped IOVA ranges

2023-03-03 Thread Joao Martins
On 03/03/2023 23:57, Joao Martins wrote: > On 03/03/2023 23:47, Alex Williamson wrote: >> On Fri, 3 Mar 2023 20:16:19 + >> Joao Martins wrote: >> >>> On 03/03/2023 19:40, Alex Williamson wrote: On Fri, 3 Mar 2023 19:14:50 + Joao Martins wrote: > On 03/03/2023 17:05,

Re: [PATCH v2 10/20] vfio/common: Record DMA mapped IOVA ranges

2023-03-03 Thread Joao Martins
On 03/03/2023 23:47, Alex Williamson wrote: > On Fri, 3 Mar 2023 20:16:19 + > Joao Martins wrote: > >> On 03/03/2023 19:40, Alex Williamson wrote: >>> On Fri, 3 Mar 2023 19:14:50 + >>> Joao Martins wrote: >>> On 03/03/2023 17:05, Alex Williamson wrote: > On Fri, 3 Mar 2023

Re: [PATCH v2 10/20] vfio/common: Record DMA mapped IOVA ranges

2023-03-03 Thread Alex Williamson
On Fri, 3 Mar 2023 20:16:19 + Joao Martins wrote: > On 03/03/2023 19:40, Alex Williamson wrote: > > On Fri, 3 Mar 2023 19:14:50 + > > Joao Martins wrote: > > > >> On 03/03/2023 17:05, Alex Williamson wrote: > >>> On Fri, 3 Mar 2023 16:58:55 + > >>> Joao Martins wrote: > >>>

RE: [PATCH 2/2] tcg: Merge two sequential labels

2023-03-03 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Friday, March 3, 2023 3:31 PM > To: qemu-devel@nongnu.org > Cc: a...@rev.ng; Taylor Simpson > Subject: [PATCH 2/2] tcg: Merge two sequential labels > > Remove the first label and redirect all uses to the second. > >

Re: [PATCH v2 1/2] gitlab/opensbi: Move to docker:stable

2023-03-03 Thread Bin Meng
On Sat, Mar 4, 2023 at 4:25 AM Palmer Dabbelt wrote: > > The OpenSBI build has been using docker:19.03.1, which appears to be old > enough that v2 of the manifest is no longer supported. Something has > started serving us those manifests, resulting in errors along the lines > of > > $ docker

RE: [PATCH 1/2] tcg: Link branches to the labels

2023-03-03 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Friday, March 3, 2023 3:31 PM > To: qemu-devel@nongnu.org > Cc: a...@rev.ng; Taylor Simpson > Subject: [PATCH 1/2] tcg: Link branches to the labels > > This allows us to easily find all branches that use a label. > Since 'refs'

Re: [PULL 03/38] pflash: Only read non-zero parts of backend image

2023-03-03 Thread Maciej S. Szmigiero
On 8.02.2023 12:19, Cédric Le Goater wrote: On 2/7/23 13:48, Kevin Wolf wrote: Am 07.02.2023 um 10:19 hat Cédric Le Goater geschrieben: On 2/7/23 09:38, Kevin Wolf wrote: Am 06.02.2023 um 16:54 hat Cédric Le Goater geschrieben: On 1/20/23 13:25, Kevin Wolf wrote: From: Xiang Zheng

Re: [PATCH v2 5/6] spec: Introduce NBD_FLAG_BLOCK_STATUS_PAYLOAD

2023-03-03 Thread Eric Blake
On Wed, Feb 22, 2023 at 12:05:44PM +0200, Wouter Verhelst wrote: > On Mon, Nov 14, 2022 at 04:46:54PM -0600, Eric Blake wrote: > > Simple reply message > > > > @@ -1232,6 +1235,19 @@ The field has the following format: > >will be faster than a regular write). Clients MUST NOT set the >

Re: [PATCH v2 3/6] spec: Add NBD_OPT_EXTENDED_HEADERS

2023-03-03 Thread Eric Blake
On Wed, Feb 22, 2023 at 11:49:18AM +0200, Wouter Verhelst wrote: > On Mon, Nov 14, 2022 at 04:46:52PM -0600, Eric Blake wrote: > [...] > > @@ -1370,9 +1475,10 @@ of the newstyle negotiation. > > Return a list of `NBD_REP_META_CONTEXT` replies, one per context, > > followed by an

[PATCH 0/2] tcg: Merge two sequential labels

2023-03-03 Thread Richard Henderson
Supercedes: 20230301142221.24495-1-a...@rev.ng ("[PATCH] tcg: `reachable_code_pass()` remove empty else-branch") Anton has probably seen this already but his patch now has conflicts with master. Rather than a while loop looking back across labels, let's fold all adjacent labels into a single

[PATCH 2/2] tcg: Merge two sequential labels

2023-03-03 Thread Richard Henderson
Remove the first label and redirect all uses to the second. Signed-off-by: Richard Henderson --- tcg/tcg.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index a8ec11dfb9..88614102cd 100644 --- a/tcg/tcg.c

[PATCH 1/2] tcg: Link branches to the labels

2023-03-03 Thread Richard Henderson
This allows us to easily find all branches that use a label. Since 'refs' is only tested vs zero, remove it and test for an empty list instead. Drop the use of bitfields, which had been used to pack refs into a single 32-bit word. Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h | 7

Re: [PATCH v2 2/6] spec: Tweak description of maximum block size

2023-03-03 Thread Eric Blake
On Tue, Feb 21, 2023 at 05:21:37PM +0200, Wouter Verhelst wrote: > Hi Eric, > > Busy days, busy times. Sorry about the insane delays here. No problem; I've been tackling other things in the meantime too, so this extension has taken far longer than I planned for more reasons than just slow review

Re: [PATCH v2 2/6] spec: Tweak description of maximum block size

2023-03-03 Thread Eric Blake
On Fri, Dec 16, 2022 at 11:22:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 11/15/22 01:46, Eric Blake wrote: > > Commit 9f30fedb improved the spec to allow non-payload requests that > > exceed any advertised maximum block size. Take this one step further > > by permitting the server to

Re: [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

2023-03-03 Thread Eric Blake
On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 11/15/22 01:46, Eric Blake wrote: > > The spec was silent on how many extents a server could reply with. > > However, both qemu and nbdkit (the two server implementations known to > > have implemented the

Re: hexagon: check-tcg rebuilding up to date image

2023-03-03 Thread Fabiano Rosas
Matheus Tavares Bernardino writes: > Hi, > > We noticed that local `make check-tcg` is rebuilding the docker image > for qemu-hexagon at every run, whereas previously it would say "Image is > up to date" and move on. > > This was changed at 0b1a649047 (tests/docker: use direct RUNC call to >

Re: [PATCH v2] vfio: Fix vfio_get_dev_region() trace event

2023-03-03 Thread Cédric Le Goater
On 3/3/23 16:42, Alex Williamson wrote: On Fri, 3 Mar 2023 10:34:47 +0100 Philippe Mathieu-Daudé wrote: On 3/3/23 08:43, Cédric Le Goater wrote: From: Cédric Le Goater Simply revert 'x8' to fix the typo and remove the ending '8' s/revert/reverse/? ie. transpose? Nothing is being

[PULL 4/5] pnv_phb4_pec: Move pnv_phb4_get_pec() to rightful file

2023-03-03 Thread Daniel Henrique Barboza
From: Frederic Barrat The function pnv_phb4_get_pec() exposes some internals of the PEC and PHB logic, yet it was in the higher level hw/ppc/pnv.c file for historical reasons: P8 implements the PHBs from pnv.c directly, but on P9/P10, it's done through the CEC model, which has its own file. So

[PULL 3/5] pnv_phb4_pec: Only export existing PHBs to the device tree

2023-03-03 Thread Daniel Henrique Barboza
From: Frederic Barrat So far, we were always exporting all possible PHBs to the device tree. It works well when using the default config but it potentially adds non-existing devices when using '-nodefaults' and user-created PHBs, causing the firmware (skiboot) to report errors when probing those

[PULL 2/5] pnv_phb4_pec: Keep track of instantiated PHBs

2023-03-03 Thread Daniel Henrique Barboza
From: Frederic Barrat Add an array on the PEC object to keep track of the PHBs which are instantiated. The array can be sparsely populated when using user-created PHBs. It will be useful for the next patch to only export instantiated PHBs in the device tree. Reviewed-by: Daniel Henrique Barboza

[PULL 1/5] target/ppc/translate: Add dummy implementation for dcblc instruction

2023-03-03 Thread Daniel Henrique Barboza
From: Bernhard Beschow The dcblc instruction is used by u-boot in mpc85xx/start.S. Without it, an illegal istruction exception is generated very early in the boot process where the processor is not yet able to handle exceptions. See:

[PULL 0/5] ppc queue

2023-03-03 Thread Daniel Henrique Barboza
-20230303 for you to fetch changes up to ddf0676f1ade90026483a91823d86db4096a40ef: pnv_phb4_pec: Simplify/align code to parent user-created PHBs (2023-03-03 16:50:17 -0300) ppc patch queue for 2023-03-03: This queue includes a stub

[PULL 5/5] pnv_phb4_pec: Simplify/align code to parent user-created PHBs

2023-03-03 Thread Daniel Henrique Barboza
From: Frederic Barrat When instantiating a user-created PHB on P9/P10, we don't really have a reason any more to go through an indirection in pnv_chip_add_phb() in pnv.c, we can go straight to the right function in pnv_phb4_pec.c. That way, default PHBs and user-created PHBs are all handled in

Re: [PATCH v4 4/6] hw/cxl: QMP based poison injection support

2023-03-03 Thread Ira Weiny
Jonathan Cameron wrote: > Inject poison using qmp command cxl-inject-poison to add an entry to the > poison list. > > For now, the poison is not returned CXL.mem reads, but only via the > mailbox command Get Poison List. > > See CXL rev 3.0, sec 8.2.9.8.4.1 Get Poison list (Opcode 4300h) > >

Re: [PATCH RESEND v7 5/9] tests/avocado: Pass parameters to migration test

2023-03-03 Thread Fabiano Rosas
Peter Maydell writes: > On Tue, 28 Feb 2023 at 19:28, Fabiano Rosas wrote: >> >> The migration tests are currently broken for an aarch64 host because >> the tests pass no 'machine' and 'cpu' options on the QEMU command >> line. >> >> Add a separate class to each architecture so that we can

[PATCH v2 1/2] gitlab/opensbi: Move to docker:stable

2023-03-03 Thread Palmer Dabbelt
The OpenSBI build has been using docker:19.03.1, which appears to be old enough that v2 of the manifest is no longer supported. Something has started serving us those manifests, resulting in errors along the lines of $ docker build --cache-from $IMAGE_TAG --tag

[PATCH v2 0/2] Fix the OpenSBI CI job and bump to v1.2

2023-03-03 Thread Palmer Dabbelt
I missed the second-stage OpenSBI job when debugging the v1. It turns out that the Docker update dropped python3, so this adds it back in via apt. I ran the whole CI this time (via push-ci-now from the docs) and I'm getting two errors: clang-system: 46/96 qemu:qtest+qtest-arm /

Re: [PATCH v2 10/20] vfio/common: Record DMA mapped IOVA ranges

2023-03-03 Thread Joao Martins
On 03/03/2023 19:40, Alex Williamson wrote: > On Fri, 3 Mar 2023 19:14:50 + > Joao Martins wrote: > >> On 03/03/2023 17:05, Alex Williamson wrote: >>> On Fri, 3 Mar 2023 16:58:55 + >>> Joao Martins wrote: >>> On 03/03/2023 00:19, Joao Martins wrote: > On 02/03/2023 18:42,

Re: [PATCH 1/2] target/riscv: cpu: Implement get_arch_id callback

2023-03-03 Thread Daniel Henrique Barboza
On 3/3/23 03:50, Mayuresh Chitale wrote: Implement the callback for getting the architecture-dependent CPU ID ie mhartid. Signed-off-by: Mayuresh Chitale Signed-off-by: Anup Patel --- Reviewed-by: Daniel Henrique Barboza target/riscv/cpu.c | 8 1 file changed, 8

Re: [PATCH 2/2] hw: intc: Use cpu_by_arch_id to fetch CPU state

2023-03-03 Thread Daniel Henrique Barboza
On 3/3/23 03:50, Mayuresh Chitale wrote: Qemu_get_cpu uses the logical CPU id assigned during init to fetch the CPU state. However APLIC, IMSIC and ACLINT contain registers and states which are specific to physical hart Ids. The hart Ids in any given system might be sparse and hence calls to

Re: [PATCH v2 66/76] target/sparc: Drop get_temp_i32

2023-03-03 Thread Richard Henderson
On 3/3/23 11:09, Peter Maydell wrote: On Mon, 27 Feb 2023 at 05:43, Richard Henderson wrote: Translators are no longer required to free tcg temporaries, therefore there's no need to record temps for later freeing. Replace the few uses with tcg_temp_new_i32. Signed-off-by: Richard Henderson

Re: [PATCH] test: Fix test-crypto-secret when compiling without keyring support

2023-03-03 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Fri, Mar 03, 2023 at 01:47:40PM +0100, Thomas Huth wrote: >> On 01/03/2023 12.00, Juan Quintela wrote: >> > Linux keyring support is protected by CONFIG_KEYUTILS. >> > Use CONFIG_SECRET_KEYRING. >> > >> > Signed-off-by: Juan Quintela >> > >> > --- >> > >> >

Re: [PATCH v2 10/20] vfio/common: Record DMA mapped IOVA ranges

2023-03-03 Thread Alex Williamson
On Fri, 3 Mar 2023 19:14:50 + Joao Martins wrote: > On 03/03/2023 17:05, Alex Williamson wrote: > > On Fri, 3 Mar 2023 16:58:55 + > > Joao Martins wrote: > > > >> On 03/03/2023 00:19, Joao Martins wrote: > >>> On 02/03/2023 18:42, Alex Williamson wrote: > On Thu, 2 Mar

Re: [PATCH] firmware: qemu_fw_cfg: make kobj_type structure constant

2023-03-03 Thread Gabriel L. Somlo
On Mon, Feb 27, 2023 at 03:19:56AM +, Thomas Weißschuh wrote: > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") > the driver core allows the usage of const struct kobj_type. > > Take advantage of this to constify the structure definition to prevent > modification at

[PATCH v3 0/2] QGA installer fixes

2023-03-03 Thread Konstantin Kostiuk
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167423 fixes: CVE-2023-0664 (2 parts) CVE Technical details: The cached installer for QEMU Guest Agent in c:\windows\installer (https://github.com/qemu/qemu/blob/master/qga/installer/qemu-ga.wxs), can be leveraged to begin a repair of the

[PATCH v3 2/2] qga/win32: Use rundll for VSS installation

2023-03-03 Thread Konstantin Kostiuk
The custom action uses cmd.exe to run VSS Service installation and removal which causes an interactive command shell to spawn. This shell can be used to execute any commands as a SYSTEM user. Even if call qemu-ga.exe directly the interactive command shell will be spawned as qemu-ga.exe is a

[PATCH v3 1/2] qga/win32: Remove change action from MSI installer

2023-03-03 Thread Konstantin Kostiuk
Remove the 'change' button from "Programs and Features" because it does not checks if a user is an admin or not. The installer has no components to choose from and always installs everything. So the 'change' button is not obviously needed but can create a security issue. resolves:

Re: [PATCH v2 10/20] vfio/common: Record DMA mapped IOVA ranges

2023-03-03 Thread Joao Martins
On 03/03/2023 17:05, Alex Williamson wrote: > On Fri, 3 Mar 2023 16:58:55 + > Joao Martins wrote: > >> On 03/03/2023 00:19, Joao Martins wrote: >>> On 02/03/2023 18:42, Alex Williamson wrote: On Thu, 2 Mar 2023 00:07:35 + Joao Martins wrote: > @@ -426,6 +427,11 @@ void

Re: [PATCH v2 00/76] tcg: Drop tcg_temp_free from translators

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:29, Richard Henderson wrote: > > Based-on: 20230225085945.1798188-1-richard.hender...@linaro.org > ("[PATCH v3 00/30] tcg: Simplify temporary usage") > > In the above patch set, we changed the lifetime of the temps > allocated by the guest translators, and eliminated

Re: [PATCH v2 66/76] target/sparc: Drop get_temp_i32

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:43, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries, > therefore there's no need to record temps for later freeing. > Replace the few uses with tcg_temp_new_i32. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v2 69/76] target/sparc: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:39, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/sparc/translate.c | 136 --- > 1 file changed, 136 deletions(-) Reviewed-by: Peter

Re: [PATCH v2 68/76] target/sparc: Drop free_compare

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:40, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > Remove the g1 and g2 members of DisasCompare, as they were > used to track which temps needed to be freed. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v2 67/76] target/sparc: Remove egress label in disas_sparc_context

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:45, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/sparc/translate.c | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 66/76] target/sparc: Drop get_temp_i32

2023-03-03 Thread Peter Maydell
On Sat, 25 Feb 2023 at 09:27, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries, > therefore there's no need to record temps for later freeing. > Replace the few uses with tcg_temp_new_i32. > > Signed-off-by: Richard Henderson > @@ -5762,14 +5752,7 @@

Re: [PATCH v2 65/76] target/sparc: Drop get_temp_tl

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:44, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries, > therefore there's no need to record temps for later freeing. > Replace the few uses with tcg_temp_new. > > Signed-off-by: Richard Henderson > --- > target/sparc/translate.c |

Re: [PATCH v2 35/76] target/m68k: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:32, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/m68k/translate.c | 181 > 1 file changed, 181 deletions(-) > > diff --git

Re: [PATCH] test: Fix test-crypto-secret when compiling without keyring support

2023-03-03 Thread Juan Quintela
Thomas Huth wrote: > On 01/03/2023 12.00, Juan Quintela wrote: >> Linux keyring support is protected by CONFIG_KEYUTILS. >> Use CONFIG_SECRET_KEYRING. >> Signed-off-by: Juan Quintela >> --- >> Previous version of this patch changed the meson build rules. >> Daniel told me that the proper fix was

Re: [PATCH v2 34/76] target/m68k: Drop free_cond

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:39, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > Remove the g1 and g2 members of DisasCompare, as they were > used to track which temps needed to be freed. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v2 33/76] target/m68k: Drop mark_to_release

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:31, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries, > therefore there's no need to record temps for later freeing. > > Signed-off-by: Richard Henderson > --- > target/m68k/translate.c | 55

Re: [PATCH 5/6] Add the aehd-i8259 device type.

2023-03-03 Thread Haitao Shan
On Fri, Mar 3, 2023 at 2:09 AM Philippe Mathieu-Daudé wrote: > > On 3/3/23 03:26, Haitao Shan wrote: > > The aehd-i8259 device type represents the AEHD in kernel PICs. > > The irqchips should be always in kernel when AEHD is used. > > > > Signed-off-by: Haitao Shan > > --- > >

Re: [PATCH v2 36/76] target/microblaze: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:31, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/microblaze/translate.c | 54 --- > 1 file changed, 54 deletions(-) Reviewed-by: Peter

Re: [PATCH v2 29/76] target/hppa: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:36, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 6/6] Add the AEHD implementation.

2023-03-03 Thread Haitao Shan
On Fri, Mar 3, 2023 at 2:15 AM Philippe Mathieu-Daudé wrote: > > On 3/3/23 03:26, Haitao Shan wrote: > > Implement the AEHD accelerator including the AEHD AccelClass, > > AccelCPUClass, AccelOpsClass. > > > > Signed-off-by: Haitao Shan > > --- > > hw/i386/x86.c |2 +- >

Re: [PATCH v2 49/76] target/openrisc: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:41, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/openrisc/translate.c | 39 - > 1 file changed, 39 deletions(-) > Reviewed-by: Peter

Re: [PATCH v2 64/76] target/sh4: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:38, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 110 - > 1 file changed, 110 deletions(-) Reviewed-by: Peter

Re: [PATCH v2 54/76] target/rx: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:39, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 48/76] target/nios2: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:50, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/nios2/translate.c | 15 --- > 1 file changed, 15 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 23/76] target/cris: Drop addr from dec10_ind_move_m_pr

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:27, Richard Henderson wrote: > > This variable is not used, only allocated and freed. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 24/76] target/cris: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:37, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/cris/translate.c | 70 - > target/cris/translate_v10.c.inc | 41 ---

Re: [PATCH v2 22/76] target/cris: Drop cris_alu_m_free_temps

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:36, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/cris/translate.c | 23 --- > target/cris/translate_v10.c.inc | 4 > 2 files changed, 27

Re: [PATCH v2 21/76] target/cris: Drop cris_alu_free_temps

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:31, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/cris/translate.c | 20 > 1 file changed, 20 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 20/76] target/avr: Drop tcg_temp_free

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:32, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/avr/translate.c | 228 - > 1 file changed, 228 deletions(-) Reviewed-by: Peter

Re: [PATCH v2 19/76] target/avr: Drop R from trans_COM

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:32, Richard Henderson wrote: > > This variable is not used, only allocated and freed. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 18/76] target/avr: Drop DisasContext.free_skip_var0

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:31, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries, > therefore there's no need to record for later freeing. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

test-blockjob: intermittent CI failures in msys2-64bit job

2023-03-03 Thread Peter Maydell
I've noticed that test-blockjob seems to fail intermittently on the msys2-64bit job: https://gitlab.com/qemu-project/qemu/-/jobs/3872508803 https://gitlab.com/qemu-project/qemu/-/jobs/3871061024 https://gitlab.com/qemu-project/qemu/-/jobs/3865312440 Sample output: | 53/89

Re: [PATCH 3/6] Add the aehd-apic device type.

2023-03-03 Thread Haitao Shan
On Fri, Mar 3, 2023 at 1:59 AM Philippe Mathieu-Daudé wrote: > > Hi Haitao, > > On 3/3/23 03:26, Haitao Shan wrote: > > The aehd-apic device type represents the AEHD in kernel APIC. > > The irqchips should be always in kernel when AEHD is used. > > > > Signed-off-by: Haitao Shan > > --- > >

Re: [PATCH v2 75/76] tcg: Create tcg/tcg-temp-internal.h

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:37, Richard Henderson wrote: > > Move the tcg_temp_free_* and tcg_temp_ebb_new_* declarations > and inlines to the new header. These are private to the > implementation, and will prevent tcg_temp_free_* from creaping > back into the guest front ends. "creeping".

Re: [PATCH v2 73/76] include/exec/gen-icount: Drop tcg_temp_free in gen_tb_start

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:36, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 17/76] target/arm: Drop tcg_temp_free from translator.h

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:29, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.h | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 16/76] target/arm: Drop tcg_temp_free from translator-vfp.c

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:41, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-vfp.c | 193 - > 1 file changed, 193 deletions(-) Reviewed-by: Peter

Re: [PATCH v2 15/76] target/arm: Drop tcg_temp_free from translator-sve.c

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:32, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 186 + > 1 file changed, 2 insertions(+), 184 deletions(-) >

Re: [PATCH v2 14/76] target/arm: Drop tcg_temp_free from translator-sme.c

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:28, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

hexagon: check-tcg rebuilding up to date image

2023-03-03 Thread Matheus Tavares Bernardino
Hi, We noticed that local `make check-tcg` is rebuilding the docker image for qemu-hexagon at every run, whereas previously it would say "Image is up to date" and move on. This was changed at 0b1a649047 (tests/docker: use direct RUNC call to build containers, 2023-02-28), where we started to no

Re: [PATCH 1/6] Add the Android Emulator hypervisor driver (AEHD) accelerator.

2023-03-03 Thread Haitao Shan
On Fri, Mar 3, 2023 at 9:29 AM Daniel P. Berrangé wrote: > > On Fri, Mar 03, 2023 at 09:24:16AM -0800, Haitao Shan wrote: > > On Fri, Mar 3, 2023 at 2:19 AM Philippe Mathieu-Daudé > > wrote: > > > > > > On 3/3/23 08:33, Michael S. Tsirkin wrote: > > > > On Thu, Mar 02, 2023 at 06:26:12PM -0800,

Re: [PATCH 0/6] Adding the Android Emulator hypervisor driver accelerator

2023-03-03 Thread Haitao Shan
On Fri, Mar 3, 2023 at 9:12 AM Daniel P. Berrangé wrote: > > On Fri, Mar 03, 2023 at 08:50:18AM -0800, Haitao Shan wrote: > > On Fri, Mar 3, 2023 at 2:34 AM Daniel P. Berrangé > > wrote: > > > > > > On Thu, Mar 02, 2023 at 06:25:59PM -0800, Haitao Shan wrote: > > > > The Android Emulator

Re: [PATCH v2 13/76] target/arm: Drop tcg_temp_free from translator-neon.c

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:31, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-neon.c | 131 +--- > 1 file changed, 1 insertion(+), 130 deletions(-)

Re: [PATCH v2 12/76] target/arm: Drop tcg_temp_free from translator-mve.c

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:35, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-mve.c | 52 -- > 1 file changed, 52 deletions(-) Reviewed-by: Peter

Re: [PATCH v2 11/76] target/arm: Drop tcg_temp_free from translator-m-nocp.c

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:31, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-m-nocp.c | 20 > 1 file changed, 20 deletions(-) Reviewed-by: Peter Maydell thanks --

Re: [PATCH v2 10/76] target/arm: Drop tcg_temp_free from translator-a64.c

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:28, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 468 + > 1 file changed, 11 insertions(+), 457 deletions(-)

Re: [PATCH v2 09/76] target/arm: Drop new_tmp_a64_zero

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:28, Richard Henderson wrote: > > Only the use within cpu_reg requires a writable temp, > so inline new_tmp_a64_zero there. All other uses are > fine with a constant temp, so use tcg_constant_i64(0). > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell

Re: [PATCH v2 08/76] target/arm: Drop new_tmp_a64

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:26, Richard Henderson wrote: > > This is now a simple wrapper for tcg_temp_new_i64. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.h | 1 - > target/arm/translate-a64.c | 45 +- > target/arm/translate-sve.c |

Re: [PATCH v2 07/76] target/arm: Drop DisasContext.tmp_a64

2023-03-03 Thread Peter Maydell
On Mon, 27 Feb 2023 at 05:27, Richard Henderson wrote: > > Translators are no longer required to free tcg temporaries, > therefore there's no need to record temps for later freeing. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

  1   2   3   4   >