Re: [PATCH v3 3/4] hw/misc: Add MIPS Trickbox device

2023-03-07 Thread Thomas Huth
On 08/03/2023 01.07, Philippe Mathieu-Daudé wrote: From: Jiaxun Yang MIPS Trickbox is a emulated device present in MIPS's IASIM simulator for decades. It's capable of managing simulator status, signaling interrupts, doing DMA and EJTAG signal stimulations. For now we just use definition of

Re: [PATCH v3 2/4] configs/targets: Have all MIPS targets select FDT

2023-03-07 Thread Thomas Huth
On 08/03/2023 01.07, Philippe Mathieu-Daudé wrote: With the introduction of the MIPS virt machine in a pair of commits, all MIPS targets will require libfdt. Define TARGET_NEED_FDT in all mips*-softmmu.mak files. Signed-off-by: Philippe Mathieu-Daudé --- configs/targets/mips-softmmu.mak |

Re: [PATCH v10 9/9] KVM: Enable and expose KVM_MEM_PRIVATE

2023-03-07 Thread Chao Peng
On Wed, Mar 08, 2023 at 12:13:24AM +, Ackerley Tng wrote: > Chao Peng writes: > > > On Sat, Jan 14, 2023 at 12:01:01AM +, Sean Christopherson wrote: > > > On Fri, Dec 02, 2022, Chao Peng wrote: > > ... > > > Strongly prefer to use similar logic to existing code that detects wraps: > > >

Re: [PATCH v3 1/4] gitlab-ci: Remove mips64-softmmu from build-without-defaults job

2023-03-07 Thread Thomas Huth
On 08/03/2023 01.07, Philippe Mathieu-Daudé wrote: With the introduction of the MIPS virt machine in a pair of commits, all MIPS targets will require libfdt. Since the 'build-without-defaults' job is configured with '--disable-fdt', it won't be able to build any MIPS target. In particular this

Re: [PULL 00/51] Net patches

2023-03-07 Thread Philippe Mathieu-Daudé
On 8/3/23 07:56, Jason Wang wrote: On Wed, Mar 8, 2023 at 4:43 AM Philippe Mathieu-Daudé wrote: On 7/3/23 18:01, Peter Maydell wrote: On Tue, 7 Mar 2023 at 07:08, Jason Wang wrote: The following changes since commit 817fd33836e73812df2f1907612b57750fcb9491: Merge tag

Re: [PULL 00/51] Net patches

2023-03-07 Thread Jason Wang
On Wed, Mar 8, 2023 at 1:01 AM Peter Maydell wrote: > > On Tue, 7 Mar 2023 at 07:08, Jason Wang wrote: > > > > The following changes since commit 817fd33836e73812df2f1907612b57750fcb9491: > > > > Merge tag 'audio-pull-request' of > > https://gitlab.com/marcandre.lureau/qemu into staging

Re: [PULL 00/51] Net patches

2023-03-07 Thread Jason Wang
On Wed, Mar 8, 2023 at 4:43 AM Philippe Mathieu-Daudé wrote: > > On 7/3/23 18:01, Peter Maydell wrote: > > On Tue, 7 Mar 2023 at 07:08, Jason Wang wrote: > >> > >> The following changes since commit > >> 817fd33836e73812df2f1907612b57750fcb9491: > >> > >>Merge tag 'audio-pull-request' of >

Re: [PATCH v4 04/11] osdep: implement qemu_socketpair() for win32

2023-03-07 Thread Marc-André Lureau
Hi On Tue, Mar 7, 2023 at 6:50 PM Daniel P. Berrangé wrote: > > On Mon, Mar 06, 2023 at 04:27:44PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Manually implement a socketpair() function, using UNIX sockets and > > simple peer credential checking. > > > > QEMU

Re: [PATCH V2 3/5] memory: introduce memory_region_unmap_iommu_notifier_range()

2023-03-07 Thread Jason Wang
On Wed, Mar 8, 2023 at 9:02 AM Michael S. Tsirkin wrote: > > On Thu, Feb 23, 2023 at 02:59:22PM +0800, Jason Wang wrote: > > This patch introduces a new helper to unmap the range of a specific > > IOMMU notifier. > > > > Signed-off-by: Jason Wang > > --- > > include/exec/memory.h | 10

Re: stable releases

2023-03-07 Thread Michael Roth via
On Mon, Mar 06, 2023 at 09:57:58AM +0100, Thomas Huth wrote: > On 05/03/2023 11.27, Michael Tokarev wrote: > > Hi! > > > > For a few qemu major releases already, we did not have any stable minor > > releases. > > I'd love to change that, in order to consolidate efforts and to make better > >

Re: [RESEND PATCH v6 8/8] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-07 Thread Michael S. Tsirkin
On Tue, Mar 07, 2023 at 07:26:41PM +, Fan Ni wrote: > > +typedef struct CXLError { > > +QTAILQ_ENTRY(CXLError) node; > > +int type; /* Error code as per FE definition */ > > +uint32_t header[32]; > Instead of using 32 here, would it be better to use > CXL_RAS_ERR_HEADER_NUM?

[PULL 68/73] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron CXL uses PCI AER Internal errors to signal to the host that an error has occurred. The host can then read more detailed status from the CXL RAS capability. For uncorrectable errors: support multiple injection in one operation as this is needed to reliably test multiple

[PULL 69/73] hw/pci: Add pcie_count_ds_port() and pcie_find_port_first() helpers

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron These two helpers enable host bridges to operate differently depending on the number of downstream ports, in particular if there is only a single port. Useful for CXL where HDM address decoders are allowed to be implicit in the host bridge if there is only a single root

[PULL 50/73] acpi: pci: describe all functions on populated slots

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov describing all present devices on functions other than 0 was complicated when non hotplug and hotplug code was intermixed. So QEMU has been excluding non zero functions since they are not supported by hotplug code, then a condition to whitelist coldplugged bridges was added

[PULL 62/73] hw/pci/aer: Add missing routing for AER errors

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron PCIe r6.0 Figure 6-3 "Pseudo Logic Diagram for Selected Error Message Control and Status Bits" includes a right hand branch under "All PCI Express devices" that allows for messages to be generated or sent onwards without SERR# being set as long as the appropriate per error

[PULL 45/73] tests: acpi: whitelist DSDT before adding device with acpi-index to testcases

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-20-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PULL 17/73] vdpa: add vhost_vdpa->suspended parameter

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez This allows vhost_vdpa to track if it is safe to get the vring base from the device or not. If it is not, vhost can fall back to fetch idx from the guest buffer again. No functional change intended in this patch, later patches will use this field. Signed-off-by: Eugenio

[PULL 65/73] hw/mem/cxl-type3: Add AER extended capability

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron This enables AER error injection to function as expected. It is intended as a building block in enabling CXL RAS error injection in the following patches. Signed-off-by: Jonathan Cameron Reviewed-by: Dave Jiang Message-Id:

[PULL 41/73] tests: acpi: update expected blobs

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov only following context change: - Local1 = Zero If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */)) { Return (Local0) ... Return (Local0) } + Local1 = Zero Local2 = AIDX (DerefOf (Arg4 [Zero]),

[PULL 35/73] x86: pcihp: fix missing bridge AML when intermediate root-port has 'hotplug=off' set

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov (I practice [1] hasn't broke anything since on hardware side we unset hotplug_handler on such intermediate port => hotplug behind it has never worked) When deciding if bridge should be described, the original condition was cold_plugged_bridge && pcihp_bridge_en which was

[PULL 16/73] vdpa: rewind at get_base, not set_base

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez At this moment it is only possible to migrate to a vdpa device running with x-svq=on. As a protective measure, the rewind of the inflight descriptors was done at the destination. That way if the source sent a virtqueue with inuse descriptors they are always discarded. Since

[PULL 03/73] cryptodev: Introduce cryptodev alg type in QAPI

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Introduce cryptodev alg type in cryptodev.json, then apply this to related codes, and drop 'enum CryptoDevBackendAlgType'. There are two options: 1, { 'enum': 'QCryptodevBackendAlgType', 'prefix': 'CRYPTODEV_BACKEND_ALG', 'data': ['sym', 'asym']} Then we can keep

[PULL 43/73] acpi: pci: add EDSM method to DSDT

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov it's a helper method for acpi-index support on PCI buses that do no support or have disabled ACPI PCI hotplug or for non-hotpluggble endpoint devices. (like non-hotpluggble NICs, integrated endpoints and later for machines that do not support ACPI PCI hotplug) no functional

[PULL 37/73] pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI hotplug is disabled

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov commit [1] added ability to disable ACPI PCI hotplug on hostbridge but forgot to take into account that it should disable all ACPI hotplug machinery in case both hostbridge and bridge hotplug are disabled. Commit [2] tried to fix that, however it forgot to remove

[PULL 66/73] hw/cxl: Fix endian issues in CXL RAS capability defaults / masks

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron As these are about to be modified, fix the endian handle for this set of registers rather than making it worse. Note that CXL is currently only supported in QEMU on x86 (arm64 patches out of tree) so we aren't going to yet hit an problems with big endian. However it is

[PULL 63/73] hw/pci-bridge/cxl_root_port: Wire up AER

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron We are missing necessary config write handling for AER emulation in the CXL root port. Add it based on pcie_root_port.c Signed-off-by: Jonathan Cameron Reviewed-by: Dave Jiang Message-Id: <20230302133709.30373-4-jonathan.came...@huawei.com> Reviewed-by: Michael S.

[PULL 73/73] virtio: refresh vring region cache after updating a virtqueue size

2023-03-07 Thread Michael S. Tsirkin
From: Carlos López When a virtqueue size is changed by the guest via virtio_queue_set_num(), its region cache is not automatically updated. If the size was increased, this could lead to accessing the cache out of bounds. For example, in vring_get_used_event(): static inline uint16_t

[PULL 49/73] tests: acpi: whitelist DSDT before exposing non zero functions

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-24-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 37 + 1 file changed, 37 insertions(+) diff

[PULL 61/73] hw/pci/aer: Implement PCI_ERR_UNCOR_MASK register

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron This register in AER should be both writeable and should have a default value with a couple of the errors masked including the Uncorrectable Internal Error used by CXL for it's error reporting. Signed-off-by: Jonathan Cameron Reviewed-by: Dave Jiang Message-Id:

[PULL 70/73] hw/pxb-cxl: Support passthrough HDM Decoders unless overridden

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron The CXL r3.0 specification allows for there to be no HDM decoders on CXL Host Bridges if they have only a single root port. Instead, all accesses directed to the host bridge (as specified in CXL Fixed Memory Windows) are assumed to be routed to the single root port. Linux

[PULL 30/73] tests: acpi: update expected blobs

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov expected changes: Basically adds devices present on root bus in form: Device (SXX) { Name (_ADR, 0x) // _ADR: Address } On top of that For q35.noacpihp, all ACPI PCI hotplug AML is removed and _OSC get native hotplug enabled:

[PULL 71/73] hw/virtio/vhost-user: avoid using unitialized errp

2023-03-07 Thread Michael S. Tsirkin
From: Albert Esteve During protocol negotiation, when we the QEMU stub does not support a backend with F_CONFIG, it throws a warning and supresses the VHOST_USER_PROTOCOL_F_CONFIG bit. However, the warning uses warn_reportf_err macro and passes an unitialized errp pointer. However, the macro

[PULL 26/73] vdpa: return VHOST_F_LOG_ALL in vhost-vdpa devices

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez vhost-vdpa devices can return this feature now that blockers have been set in case some features are not met. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Message-Id: <20230303172445.1089785-15-epere...@redhat.com> Tested-by: Lei Yang Reviewed-by: Michael S. Tsirkin

[PULL 38/73] pci: fix 'hotplugglable' property behavior

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Currently the property may flip its state during VM bring up or just doesn't work as the name implies. In particular with PCIE root port that has 'hotplug={on|off}' property, and when it's turned off, one would expect 'hotpluggable' == false for any devices attached to it.

[PULL 23/73] vdpa: block migration if device has unsupported features

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez A vdpa net device must initialize with SVQ in order to be migratable at this moment, and initialization code verifies some conditions. If the device is not initialized with the x-svq parameter, it will not expose _F_LOG so the vhost subsystem will block VM migration from its

[PULL 27/73] Revert "tests/qtest: Check for devices in bios-tables-test"

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov This reverts commit c471eb4f40445908c1be7bb11a37ac676a0edae7. which broke acpi tables test and rebuild due to skipping some tests even thought none of devices tests depend on weren't disabled. As result it leads to some expected tables not being updated, merge conflicts and

[PULL 20/73] vdpa: add vdpa net migration state notifier

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez This allows net to restart the device backend to configure SVQ on it. Ideally, these changes should not be net specific and they could be done in: * vhost_vdpa_set_features (with VHOST_F_LOG_ALL) * vhost_vdpa_set_vring_addr (with .enable_log) * vhost_vdpa_set_log_base.

[PULL 67/73] hw/pci/aer: Make PCIE AER error injection facility available for other emulation to use.

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron This infrastructure will be reused for CXL RAS error injection in patches that follow. Reviewed-by: Dave Jiang Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Jonathan Cameron Message-Id: <20230302133709.30373-8-jonathan.came...@huawei.com> Reviewed-by: Michael S.

[PULL 52/73] tests: acpi: whitelist DSDT before adding non-0 function device with acpi-index to testcases

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-27-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PULL 56/73] acpi: pci: drop BSEL usage when deciding that device isn't hotpluggable

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov previous commit ("pci: fix 'hotplugglable' property behavior") fixed pcie root port's 'hotpluggable' property to behave consistently. So we don't need a BSEL crutch anymore to see of device is not hotpluggable, drop it from 'generic' PCI slots description handling. BSEL is

[PULL 64/73] hw/pci-bridge/cxl_root_port: Wire up MSI

2023-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron Done to avoid fixing ACPI route description of traditional PCI interrupts on q35 and because we should probably move with the times anyway. Signed-off-by: Jonathan Cameron Reviewed-by: Dave Jiang Message-Id: <20230302133709.30373-5-jonathan.came...@huawei.com>

[PULL 72/73] virtio: fix reachable assertion due to stale value of cached region size

2023-03-07 Thread Michael S. Tsirkin
From: Carlos López In virtqueue_{split,packed}_get_avail_bytes() descriptors are read in a loop via MemoryRegionCache regions and calls to vring_{split,packed}_desc_read() - these take a region cache and the index of the descriptor to be read. For direct descriptors we use a cache provided by

[PULL 10/73] cryptodev: support QoS

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Add 'throttle-bps' and 'throttle-ops' limitation to set QoS. The two arguments work with both QEMU command line and QMP command. Example of QEMU command line: -object cryptodev-backend-builtin,id=cryptodev1,throttle-bps=1600,\ throttle-ops=100 Example of QMP command: virsh

[PULL 24/73] vdpa: block migration if SVQ does not admit a feature

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches enable devices to be migrated even if vdpa netdev has not been started with x-svq. However, not all devices are migratable, so we need to block migration if we detect that. Block migration if we detect the device expose a feature SVQ does not know how to work

[PULL 25/73] vdpa net: allow VHOST_F_LOG_ALL

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez Since some actions move to the start function instead of init, the device features may not be the parent vdpa device's, but the one returned by vhost backend. If transition to SVQ is supported, the vhost backend will return _F_LOG_ALL to signal the device is migratable. Add

[PULL 48/73] tests: acpi: update expected blobs

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov the only chenge is addition of _DSM- > EDSM method on non-hotpluggable devices with configured acpi-index. Something like: +Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method +{ +Local0 = Package (0x01) +

[PULL 60/73] pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Provide pcihp specific callback to check if bus is hotpluggable and consolidate its scattered hotplug criteria there. While at it clean up no longer needed qbus_set_hotplug_handler(BUS(bus), NULL) workarounds since callback makes qbus_is_hotpluggable() return correct

[PULL 58/73] acpi: pci: move out ACPI PCI hotplug generator from generic slot generator build_append_pci_bus_devices()

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-33-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/pcihp.h | 2 ++ hw/acpi/pci-bridge.c| 12 +++- hw/i386/acpi-build.c| 9 -

[PULL 36/73] tests: acpi: update expected blobs

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov BNUM numbering changes across DSDT due to addition of new bridges. Fixed missing PCI tree brunch (q35/DSDT.multi-bridge case): // -device pcie-root-port,id=rpnohp,chassis=8,addr=0xA.0,hotplug=off +Device (S50) +{ +Name (_ADR,

[PULL 22/73] vdpa net: block migration if the device has CVQ

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez Devices with CVQ need to migrate state beyond vq state. Leaving this to future series. Signed-off-by: Eugenio Pérez Message-Id: <20230303172445.1089785-11-epere...@redhat.com> Tested-by: Lei Yang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL 40/73] pcihp: move PCI _DSM function 0 prolog into separate function

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov it will be reused by follow up patches that will implement static _DSM for non-hotpluggable devices. no functional AML change, only context one, where 'cap' (Local1) initialization is moved after UUID/revision checks. Signed-off-by: Igor Mammedov Message-Id:

[PULL 53/73] tests: acpi: add non zero function device with acpi-index on non-hotpluggble bus

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-28-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PULL 55/73] pci: move acpi-index uniqueness check to generic PCI device code

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov acpi-index is now working with non-hotpluggable buses (pci/q35 machine hostbridge), it can be used even if ACPI PCI hotplug is disabled and as result acpi-index uniqueness check will be omitted (since the check is done by ACPI PCI hotplug handler, which isn't wired when ACPI

[PULL 29/73] tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend test_acpi_piix4_no_acpi_pci_hotplug

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov test bridge AML generator with ACPI PCI hotplug disabled (i.e. with native hotplug enabled/disabled per bridge/root port) PS: while at make sure that devices on pci-bridge are starting from addr=1.0 as slot 0 is not available there and test passes only because of a bug in

[PULL 31/73] tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-6-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PULL 47/73] acpi: pci: support acpi-index for non-hotpluggable devices

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Inject static _DSM (EDSM) if non-hotpluggable device has acpi-index configured on it. It lets use acpi-index non-hotpluggable devices / devices attached to non-hotpluggable bus. Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-22-imamm...@redhat.com>

[PULL 57/73] acpi: pci: move BSEL into build_append_pcihp_slots()

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Generic PCI enumeration code doesn't really need access to BSEL value, it is only used as means to decide if hotplug enumerator should be called. Use stateless object_property_find() to do that, and move the rest of BSEL handling into build_append_pcihp_slots() where it

[PULL 46/73] tests: acpi: add device with acpi-index on non-hotpluggble bus

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-21-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test.c

[PULL 04/73] cryptodev: Introduce server type in QAPI

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Introduce cryptodev service type in cryptodev.json, then apply this to related codes. Now we can remove VIRTIO_CRYPTO_SERVICE_xxx dependence from QEMU cryptodev. Reviewed-by: Daniel P. Berrangé Signed-off-by: zhenwei pi Message-Id:

[PULL 44/73] tests: acpi: update expected blobs

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-19-imamm...@redhat.com> --- tests/qtest/bios-tables-test-allowed-diff.h | 37 -- tests/data/acpi/pc/DSDT | Bin 6360 -> 6454 bytes tests/data/acpi/pc/DSDT.acpierst

[PULL 08/73] cryptodev: Use CryptoDevBackendOpInfo for operation

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Move queue_index, CryptoDevCompletionFunc and opaque into struct CryptoDevBackendOpInfo, then cryptodev_backend_crypto_operation() needs an argument CryptoDevBackendOpInfo *op_info only. And remove VirtIOCryptoReq from cryptodev. It's also possible to hide VirtIOCryptoReq into

[PULL 19/73] vdpa: move vhost reset after get vring base

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez The function vhost.c:vhost_dev_stop calls vhost operation vhost_dev_start(false). In the case of vdpa it totally reset and wipes the device, making the fetching of the vring base (virtqueue state) totally useless. The kernel backend does not use vhost_dev_start vhost op

[PULL 51/73] tests: acpi: update expected blobs

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov in PC machine case piix3-ide and PIIX4_PM get exposed +Device (S09) +{ +Name (_ADR, 0x00010001) // _ADR: Address +} + +Device (S0B) +{ +Name (_ADR, 0x00010003) //

[PULL 54/73] tests: acpi: update expected blobs

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov an extra devices at non-zero function address with static _DSM method get exposed, ex: +Device (S15) +{ +Name (_ADR, 0x00020005) // _ADR: Address +Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method

[PULL 34/73] tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov follow up fix for missing root-port AML will affect these tests by adding non-hotpluggable Device descriptors of colplugged bridges when bridge hotplug is disabled. Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-9-imamm...@redhat.com> Reviewed-by: Michael

[PULL 09/73] cryptodev: Account statistics

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Account OPS/BPS for crypto device, this will be used for 'query-stats' QEMU monitor command and QoS in the next step. Note that a crypto device may support symmetric mode, asymmetric mode, both symmetric and asymmetric mode. So we use two structure to describe the statistics of

[PULL 59/73] pcihp: move fields enabling hotplug into AcpiPciHpState

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov ... instead of duplicating them in piix4 and lpc and then trying to pass them to pcihp routines as arguments. it simplifies call sites and places pcihp specific in its own structure. Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-34-imamm...@redhat.com>

[PULL 32/73] tests: acpi: extend multi-bridge case with case 'root-port,id=HOHP,hotplug=off root-port,bus=NOHP'

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Following corner case wasn't covered: -device pcie-root-port,id=NO_HOTPLUG,hotplug=off -device pcie-root-port,bus=NO_HOTPLUG when intermediate root-port has explicitly disabled hotplug, all hierarchy below it is not described anymore (used to be described in 7.2) So as

[PULL 28/73] tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov for q35.noacpihp use plain default Q35 DSDT table as a starting point. Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-3-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h

[PULL 21/73] vdpa: disable RAM block discard only for the first device

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez Although it does not make a big difference, its more correct and simplifies the cleanup path in subsequent patches. Move ram_block_discard_disable(false) call to the top of vhost_vdpa_cleanup because: * We cannot use vhost_vdpa_first_dev after dev->opaque = NULL

[PULL 39/73] tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0 prolog

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-14-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 35 + 1 file changed, 35 insertions(+) diff

[PULL 42/73] tests: acpi: whitelist DSDT before adding EDSM method

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20230302161543.286002-17-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 37 + 1 file changed, 37 insertions(+) diff

[PULL 14/73] vdpa: Remember last call fd set

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez As SVQ can be enabled dynamically at any time, it needs to store call fd always. Signed-off-by: Eugenio Pérez Message-Id: <20230303172445.1089785-3-epere...@redhat.com> Tested-by: Lei Yang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL 02/73] cryptodev: Remove 'name' & 'model' fields

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi We have already used qapi to generate crypto device types, this allows to convert type to a string 'model', so the 'model' field is not needed. And the 'name' field is not used by any backend driver, drop it. Reviewed-by: Daniel P. Berrangé Signed-off-by: zhenwei pi

[PULL 00/73] virtio,pc,pci: features, fixes

2023-03-07 Thread Michael S. Tsirkin
The following changes since commit 9832009d9dd2386664c15cc70f6e6bfe062be8bd: Merge tag 'pull-riscv-to-apply-20230306' of https://gitlab.com/palmer-dabbelt/qemu into staging (2023-03-07 12:53:00 +) are available in the Git repository at:

[PULL 33/73] x86: pcihp: fix missing PCNT callchain when intermediate root-port has 'hotplug=off' set

2023-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Beside BSEL numbers change (due to 2 extra root-ports in q35/miltibridge test), following change is expected: Scope (\_SB.PCI0) { ... +Scope (S50) +{ +Scope (S00) +{ +Method (PCNT, 0,

[PULL 05/73] cryptodev: Introduce 'query-cryptodev' QMP command

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Now we have a QMP command to query crypto devices: virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq { "return": [ { "service": [ "akcipher", "mac", "hash", "cipher" ], "id": "cryptodev1", "client":

[PULL 18/73] vdpa: add vhost_vdpa_suspend

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez The function vhost.c:vhost_dev_stop fetches the vring base so the vq state can be migrated to other devices. However, this is unreliable in vdpa, since we didn't signal the device to suspend the queues, making the value fetched useless. Suspend the device if possible before

[PULL 07/73] hmp: add cryptodev info command

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Example of this command: # virsh qemu-monitor-command vm --hmp info cryptodev cryptodev1: service=[akcipher|mac|hash|cipher] queue 0: type=builtin cryptodev0: service=[akcipher] queue 0: type=lkcf Acked-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé

[PULL 15/73] vdpa: Negotiate _F_SUSPEND feature

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez This is needed for qemu to know it can suspend the device to retrieve its status and enable SVQ with it, so all the process is transparent to the guest. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Message-Id: <20230303172445.1089785-4-epere...@redhat.com> Tested-by:

[PULL 06/73] cryptodev-builtin: Detect akcipher capability

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Rather than exposing akcipher service/RSA algorithm to virtio crypto device unconditionally, detect akcipher capability from akcipher crypto framework. This avoids unsuccessful requests. Reviewed-by: Daniel P. Berrangé Signed-off-by: zhenwei pi Message-Id:

[PULL 11/73] cryptodev: Support query-stats QMP command

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Now we can use "query-stats" QMP command to query statistics of crypto devices. (Originally this was designed to show statistics by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that querying configuration info by "query-cryptodev", and querying runtime performance

[PULL 13/73] vdpa net: move iova tree creation from init to start

2023-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez Only create iova_tree if and when it is needed. The cleanup keeps being responsible for the last VQ but this change allows it to merge both cleanup functions. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Message-Id: <20230303172445.1089785-2-epere...@redhat.com>

[PULL 01/73] cryptodev: Introduce cryptodev.json

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Introduce QCryptodevBackendType in cryptodev.json, also apply this to related codes. Then we can drop 'enum CryptoDevBackendOptionsType'. Note that `CRYPTODEV_BACKEND_TYPE_NONE` is *NOT* used by anywhere, so drop it(no 'none' enum in QCryptodevBackendType). Reviewed-by: Daniel

[PULL 12/73] MAINTAINERS: add myself as the maintainer for cryptodev

2023-03-07 Thread Michael S. Tsirkin
From: zhenwei pi I developed the akcipher service, QoS setting, QMP/HMP commands and statistics accounting for crypto device. Making myself as the maintainer for QEMU's cryptodev. Cc: Gonglei Signed-off-by: zhenwei pi Message-Id: <20230301105847.253084-13-pizhen...@bytedance.com> Reviewed-by:

Re: [PATCH V2 3/5] memory: introduce memory_region_unmap_iommu_notifier_range()

2023-03-07 Thread Michael S. Tsirkin
On Thu, Feb 23, 2023 at 02:59:22PM +0800, Jason Wang wrote: > This patch introduces a new helper to unmap the range of a specific > IOMMU notifier. > > Signed-off-by: Jason Wang > --- > include/exec/memory.h | 10 ++ > softmmu/memory.c | 13 + > 2 files changed, 23

Re: [PATCH v4 2/2] hw/cxl: Multi-Region CXL Type-3 Devices (Volatile and Persistent)

2023-03-07 Thread Michael S. Tsirkin
On Mon, Feb 27, 2023 at 04:31:57PM +, Jonathan Cameron wrote: > From: Gregory Price > > This commit enables each CXL Type-3 device to contain one volatile > memory region and one persistent region. > > Two new properties have been added to cxl-type3 device initialization: >

Re: [PATCH v2] virtio-balloon: optimize the virtio-balloon on the ARM platform

2023-03-07 Thread Michael S. Tsirkin
On Wed, Mar 01, 2023 at 06:38:13AM +, Yangming wrote: > Optimize the virtio-balloon feature on the ARM platform by adding > a variable to keep track of the current hot-plugged pc-dimm size, > instead of traversing the virtual machine's memory modules to count > the current RAM size during the

Re: [PATCH v10 9/9] KVM: Enable and expose KVM_MEM_PRIVATE

2023-03-07 Thread Ackerley Tng
Chao Peng writes: On Sat, Jan 14, 2023 at 12:01:01AM +, Sean Christopherson wrote: On Fri, Dec 02, 2022, Chao Peng wrote: ... Strongly prefer to use similar logic to existing code that detects wraps: mem->restricted_offset + mem->memory_size < mem->restricted_offset

[PATCH v3 2/4] configs/targets: Have all MIPS targets select FDT

2023-03-07 Thread Philippe Mathieu-Daudé
With the introduction of the MIPS virt machine in a pair of commits, all MIPS targets will require libfdt. Define TARGET_NEED_FDT in all mips*-softmmu.mak files. Signed-off-by: Philippe Mathieu-Daudé --- configs/targets/mips-softmmu.mak | 1 + configs/targets/mips64-softmmu.mak | 1 +

[PATCH v3 0/4] MIPS Virt machine

2023-03-07 Thread Philippe Mathieu-Daudé
Since v2: - Remove mips64 from gitlab's build-without-defaults job - Require libfdt for all MIPS targets - Various changes described in each trickbox/virt patches v2 cover from Jiaxun Yang: This patchset is to add a new machine type for MIPS architecture, which is purely a VirtIO machine.

[PATCH v3 3/4] hw/misc: Add MIPS Trickbox device

2023-03-07 Thread Philippe Mathieu-Daudé
From: Jiaxun Yang MIPS Trickbox is a emulated device present in MIPS's IASIM simulator for decades. It's capable of managing simulator status, signaling interrupts, doing DMA and EJTAG signal stimulations. For now we just use definition of this device and implement power management related

[PATCH v3 4/4] hw/mips: Add MIPS virt board

2023-03-07 Thread Philippe Mathieu-Daudé
From: Jiaxun Yang MIPS virt board is design to utilize existing VirtIO infrastures but also comptitable with MIPS's existing internal simulation tools. It includes virtio-pci, virtio-mmio, pcie gpex, flash rom, fw_cfg, goldfish-rtc and MIPS CPS system. It should be able to cooperate with any

[PATCH v3 1/4] gitlab-ci: Remove mips64-softmmu from build-without-defaults job

2023-03-07 Thread Philippe Mathieu-Daudé
With the introduction of the MIPS virt machine in a pair of commits, all MIPS targets will require libfdt. Since the 'build-without-defaults' job is configured with '--disable-fdt', it won't be able to build any MIPS target. In particular this job triggers: ../meson.build:2809:2: ERROR: Problem

Re: sh4-linux-user compile failure

2023-03-07 Thread Mark Cave-Ayland
On 07/03/2023 23:52, Philippe Mathieu-Daudé wrote: On 8/3/23 00:46, Mark Cave-Ayland wrote: Hi Richard/Anton, It looks as if a compile failure has crept into sh4-linux-user, most likely related to the recent TARGET_TB_PCREL/CF_PCREL changes: In file included from

[PULL 1/1] roms/openbios: update OpenBIOS images to af97fd7a built from submodule

2023-03-07 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- pc-bios/openbios-ppc | Bin 677196 -> 677196 bytes pc-bios/openbios-sparc32 | Bin 382080 -> 382080 bytes pc-bios/openbios-sparc64 | Bin 1593408 -> 1593408 bytes roms/openbios| 2 +- 4 files changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 0/1] qemu-openbios queue 20230307

2023-03-07 Thread Mark Cave-Ayland
-openbios-20230307 for you to fetch changes up to fff1aaf4451231ac680aa278e9fafc4f8b69ff57: roms/openbios: update OpenBIOS images to af97fd7a built from submodule (2023-03-07 22:30:06 +) qemu-openbios queue

Re: sh4-linux-user compile failure

2023-03-07 Thread Philippe Mathieu-Daudé
On 8/3/23 00:46, Mark Cave-Ayland wrote: Hi Richard/Anton, It looks as if a compile failure has crept into sh4-linux-user, most likely related to the recent TARGET_TB_PCREL/CF_PCREL changes: In file included from ../accel/tcg/tb-hash.h:26, from ../accel/tcg/tb-maint.c:28:

[PULL 17/20] hw/usb/ohci: Implement resume on connection status change

2023-03-07 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan If certain bit is set remote wake up should change state from suspended to resume and generate interrupt. There was a todo comment for this, implement that by moving existing resume logic to a function and call that. Signed-off-by: BALATON Zoltan Acked-by: Gerd Hoffmann

[PULL 15/20] hw/usb/vt82c686-uhci-pci: Use PCI IRQ routing

2023-03-07 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow According to the PCI specification, PCI_INTERRUPT_LINE shall have no effect on hardware operations. Now that the VIA south bridges implement the internal PCI interrupt router let's be more conformant to the PCI specification. Signed-off-by: Bernhard Beschow Reviewed-by:

  1   2   3   4   5   6   7   8   >