Re: [PATCH v3 09/14] nbd/server: Initial support for extended headers

2023-06-07 Thread Eric Blake
On Wed, May 31, 2023 at 05:46:55PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 15.05.23 22:53, Eric Blake wrote: > > Time to support clients that request extended headers. Now we can > > finally reach the code added across several previous patches. > > > > Even though the NBD spec has been al

Re: [PATCH 11/16] target/riscv: add KVM specific MISA properties

2023-06-07 Thread Andrew Jones
On Tue, May 30, 2023 at 04:46:18PM -0300, Daniel Henrique Barboza wrote: > Using all TCG user properties in KVM is tricky. First because KVM > supports only a small subset of what TCG provides, so most of the > cpu->cfg flags do nothing for KVM. > > Second, and more important, we don't have a way

Re: [PATCH] hw/timer/nrf51_timer: Don't lose time when timer is queried in tight loop

2023-06-07 Thread Joel Stanley
On Tue, 6 Jun 2023 at 13:49, Peter Maydell wrote: > > The nrf51_timer has a free-running counter which we implement using > the pattern of using two fields (update_counter_ns, counter) to track > the last point at which we calculated the counter value, and the > counter value at that time. Then w

Re: [PATCH] ui/sdl2: Support multiple OpenGL-enabled windows

2023-06-07 Thread Akihiko Odaki
On 2023/06/07 19:29, Marc-André Lureau wrote: Hi Antonio On Wed, Jun 7, 2023 at 1:13 PM Antonio Caggiano mailto:quic_acagg...@quicinc.com>> wrote: Multiple graphics devices can be defined with an associated OpenGL enabled SDL console, hence make sure to not destroy their shaders and

Re: [PATCH v2 12/12] target/arm: Allow users to set the number of VFP registers

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > Cortex A7 CPUs with an FPU implementing VFPv4 without NEON support > have 16 64-bit FPU registers and not 32 registers. Let users set the > number of VFP registers with a CPU property. > > The primary use case of this property is for the Cor

Re: [PATCH v2] 9pfs: prevent opening special files (CVE-2023-2861)

2023-06-07 Thread Christian Schoenebeck
On Tuesday, June 6, 2023 8:48:49 PM CEST Michael Tokarev wrote: > 06.06.2023 16:57, Christian Schoenebeck wrote: [...] > > +/* CVE-2023-2861: Prohibit opening any special file directly on host > > + * (especially device files), as a compromised client could potentially > > + * gain acce

Re: [PATCH v2] 9pfs: prevent opening special files (CVE-2023-2861)

2023-06-07 Thread Christian Schoenebeck
On Tuesday, June 6, 2023 6:00:28 PM CEST Greg Kurz wrote: > Hi Christian, > > On Tue, 06 Jun 2023 15:57:50 +0200 > Christian Schoenebeck wrote: > > > The 9p protocol does not specifically define how server shall behave when > > client tries to open a special file, however from security POV it do

Re: [PATCH v2 11/12] aspeed: Introduce a "bmc-console" machine option

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > Most of the Aspeed machines use the UART5 device for the boot console, > and QEMU connects the first serial Chardev to this SoC device for this > purpose. See routine connect_serial_hds_to_uarts(). > > Nevertheless, some machines use another

Re: [PATCH v2 10/12] aspeed: Get the BlockBackend of FMC0 from the flash device

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > and get rid of an unnecessary drive_get(IF_MTD) call. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley > --- > hw/arm/aspeed.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deleti

Re: [PATCH v2 09/12] m25p80: Introduce an helper to retrieve the BlockBackend of a device

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > It will help in getting rid of some drive_get(IF_MTD) calls by > retrieving the BlockBackend directly from the m25p80 device. > > Cc: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Cédric Le Goater One suggestion

Re: [PATCH v2 07/12] hw/ssi: Check for duplicate addresses

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > This to avoid address conflicts on the same SSI bus. Adapt machines > using multiple devices on the same bus to avoid breakage. > > Cc: "Edgar E. Iglesias" > Cc: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Cédr

Re: [PATCH v2 06/12] aspeed/smc: Wire CS lines at reset

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > Currently, a set of default flash devices is created at machine init > and drives defined on the QEMU command line are associated to the FMC > and SPI controllers in sequence : > >-drive file,format=raw,if=mtd >-drive file,format=raw

Re: [PATCH] ui/sdl2: Support multiple OpenGL-enabled windows

2023-06-07 Thread Marc-André Lureau
Hi Antonio On Wed, Jun 7, 2023 at 1:13 PM Antonio Caggiano wrote: > Multiple graphics devices can be defined with an associated OpenGL > enabled SDL console, hence make sure to not destroy their shaders and > windows. > > Signed-off-by: Antonio Caggiano > --- > ui/sdl2-gl.c | 2 +- > 1 file ch

Re: [PATCH] hw/mips: Improve the default USB settings in the loongson3-virt machine

2023-06-07 Thread Thomas Huth
On 25/05/2023 08.47, Thomas Huth wrote: It's possible to compile QEMU without the USB devices (e.g. when using "--without-default-devices" as option for the "configure" script). To be still able to run the loongson3-virt machine in default mode with such a QEMU binary, we have to check here for t

Re: [PATCH] ui/sdl2: Allow high-dpi

2023-06-07 Thread Marc-André Lureau
Hi Antonio On Wed, Jun 7, 2023 at 1:05 PM Antonio Caggiano wrote: > Add the SDL_WINDOW_ALLOW_HIGHDPI flag when creating a window and get the > drawable size instead of the window size when setting up the framebuffer > and the viewport. > > What does this actually change? What about non-gl displa

Re: [PATCH] vdpa: fix not using CVQ buffer in case of error

2023-06-07 Thread Michael Tokarev
02.06.2023 20:34, Eugenio Pérez wrote: Bug introducing when refactoring. Otherway, the guest never received the used buffer. Fixes: be4278b65fc1 ("vdpa: extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail") Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 2 +- 1 file c

Re: [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices

2023-06-07 Thread Michael Tokarev
02.06.2023 20:33, Eugenio Pérez wrote: QEMU does not emulate it so it must be disabled as long as the backend does not support it. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) Is it -stable material? Thanks, /mjt

Re: Building of docs does not work anymore

2023-06-07 Thread Thomas Huth
On 07/06/2023 11.42, Thomas Huth wrote:  Hi Paolo, hi John, since the recent reworks with the Python venv, building of the docs does not work for me on my RHEL 8 installation anymore. If I just run "configure" without any additional arguments, I get: - 8< --

Re: [PATCH v1 1/2] target/ppc: Fix decrementer time underflow and infinite timer loop

2023-06-07 Thread Daniel Henrique Barboza
On 6/7/23 06:26, Michael Tokarev wrote: 30.05.2023 16:12, Nicholas Piggin wrote: It is possible to store a very large value to the decrementer that it does not raise the decrementer exception so the timer is scheduled, but the next time value wraps and is treated as in the past. This can occ

Building of docs does not work anymore

2023-06-07 Thread Thomas Huth
Hi Paolo, hi John, since the recent reworks with the Python venv, building of the docs does not work for me on my RHEL 8 installation anymore. If I just run "configure" without any additional arguments, I get: - 8< - $ ./configure Using '

Re: [PATCH] vhost: fix vhost_dev_enable_notifiers() error case

2023-06-07 Thread Michael Tokarev
02.06.2023 19:27, Laurent Vivier wrote: in vhost_dev_enable_notifiers(), if virtio_bus_set_host_notifier(true) fails, we call vhost_dev_disable_notifiers() that executes virtio_bus_set_host_notifier(false) on all queues, even on queues that have failed to be initialized. This triggers a core dum

Re: [PATCH] meson: fix "static build" entry in summary

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 11:26, Paolo Bonzini wrote: On Wed, Jun 7, 2023 at 11:09 AM Philippe Mathieu-Daudé wrote: On 7/6/23 11:03, Paolo Bonzini wrote: Fixes: a0cbd2e8496 ("meson: use prefer_static option", 2023-05-18) Signed-off-by: Paolo Bonzini --- meson.build | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH v1 1/2] target/ppc: Fix decrementer time underflow and infinite timer loop

2023-06-07 Thread Michael Tokarev
30.05.2023 16:12, Nicholas Piggin wrote: It is possible to store a very large value to the decrementer that it does not raise the decrementer exception so the timer is scheduled, but the next time value wraps and is treated as in the past. This can occur if (u64)-1 is stored on a zero-triggered

Re: [PATCH] meson: fix "static build" entry in summary

2023-06-07 Thread Paolo Bonzini
On Wed, Jun 7, 2023 at 11:09 AM Philippe Mathieu-Daudé wrote: > > On 7/6/23 11:03, Paolo Bonzini wrote: > > Fixes: a0cbd2e8496 ("meson: use prefer_static option", 2023-05-18) > > Signed-off-by: Paolo Bonzini > > --- > > meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] virtio-net: correctly report maximum tx_queue_size value

2023-06-07 Thread Michael Tokarev
05.06.2023 17:21, Laurent Vivier wrote: Maximum value for tx_queue_size depends on the backend type. 1024 for vDPA/vhost-user, 256 for all the others. The value is returned by virtio_net_max_tx_queue_size() to set the parameter: n->net_conf.tx_queue_size = MIN(virtio_net_max_tx_queue_size(

[PATCH 1/1] hw/arm/Kconfig: sbsa-ref uses Bochs display

2023-06-07 Thread Marcin Juszkiewicz
Signed-off-by: Marcin Juszkiewicz Reviewed-by: Thomas Huth --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 0f42c556d7..4484de67e8 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -249,6 +249,7 @@ config SBSA_REF select PL061 #

[PATCH] ui/sdl2: Support multiple OpenGL-enabled windows

2023-06-07 Thread Antonio Caggiano
Multiple graphics devices can be defined with an associated OpenGL enabled SDL console, hence make sure to not destroy their shaders and windows. Signed-off-by: Antonio Caggiano --- ui/sdl2-gl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index

[PATCH v2] target/riscv/vector_helper.c: Remove the check for extra tail elements

2023-06-07 Thread Xiao Wang
Commit 752614cab8e6 ("target/riscv: rvv: Add tail agnostic for vector load / store instructions") added an extra check for LMUL fragmentation, intended for setting the "rest tail elements" in the last register for a segment load insn. Actually, the max_elements derived in vext_ld*() won't be a fra

Re: [PULL 15/18] s390x/tcg: Fix CPU address returned by STIDP

2023-06-07 Thread Ilya Leoshkevich
On Wed, 2023-06-07 at 12:05 +0300, Michael Tokarev wrote: > 06.06.2023 08:56, Thomas Huth wrote: > > From: Ilya Leoshkevich > > > > In qemu-user-s390x, /proc/cpuinfo contains: > > > > processor 0: version = 00,  identification = 00,  > > machine = 8561 > > processor 1: versio

[PATCH] vdpa: dont check vhost_vdpa->suspended when unsupported

2023-06-07 Thread Zhu Lingshan
When read the state of a virtqueue, vhost_vdpa need to check whether the device is suspended. This commit verifies whether VHOST_BACKEND_F_SUSPEND is negotiated when checking vhost_vdpa->suspended. Signed-off-by: Zhu Lingshan --- hw/virtio/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] meson: fix "static build" entry in summary

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 11:03, Paolo Bonzini wrote: Fixes: a0cbd2e8496 ("meson: use prefer_static option", 2023-05-18) Signed-off-by: Paolo Bonzini --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 553c8e0b9c5..34d0444ffbb 100644 --- a/meson

Re: [PULL 15/18] s390x/tcg: Fix CPU address returned by STIDP

2023-06-07 Thread Michael Tokarev
06.06.2023 08:56, Thomas Huth wrote: From: Ilya Leoshkevich In qemu-user-s390x, /proc/cpuinfo contains: processor 0: version = 00, identification = 00, machine = 8561 processor 1: version = 00, identification = 40, machine = 8561 The highest nibble is supposed to c

[PATCH] ui/sdl2: Allow high-dpi

2023-06-07 Thread Antonio Caggiano
Add the SDL_WINDOW_ALLOW_HIGHDPI flag when creating a window and get the drawable size instead of the window size when setting up the framebuffer and the viewport. Signed-off-by: Antonio Caggiano --- ui/sdl2-gl.c | 4 ++-- ui/sdl2.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) di

[PATCH] meson: fix "static build" entry in summary

2023-06-07 Thread Paolo Bonzini
Fixes: a0cbd2e8496 ("meson: use prefer_static option", 2023-05-18) Signed-off-by: Paolo Bonzini --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 553c8e0b9c5..34d0444ffbb 100644 --- a/meson.build +++ b/meson.build @@ -4088,7 +4088,

Re: [PATCH] configure: check for $download value properly

2023-06-07 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH v2 00/10] meson: replace submodules with wrap files

2023-06-07 Thread Paolo Bonzini
No, Michal is correct. Patch "meson: subprojects: replace berkeley-{soft,test}float-3 with wraps" did not remove the submodules. Paolo On Wed, Jun 7, 2023 at 10:54 AM Michal Prívozník wrote: > > On 6/7/23 09:47, Daniel P. Berrangé wrote: > > On Wed, Jun 07, 2023 at 09:41:40AM +0200, Michal Prívo

[PATCH v2] hvf: Report HV_DENIED error

2023-06-07 Thread Antonio Caggiano
On MacOS 11 and subsequent versions, in case the resulting binary is not signed with the proper entitlement, handle and report the HV_DENIED error. Signed-off-by: Antonio Caggiano --- v2: Use architecture specific defines from AvailabilityMacros.h to enable the HV_DENIED case only on MacOS 11

Re: [PATCH v2 00/10] meson: replace submodules with wrap files

2023-06-07 Thread Michal Prívozník
On 6/7/23 09:47, Daniel P. Berrangé wrote: > On Wed, Jun 07, 2023 at 09:41:40AM +0200, Michal Prívozník wrote: >> On 6/5/23 11:52, Paolo Bonzini wrote: >>> This series replaces git submodules for bundled libraries with .wrap >>> files that can be used directly by meson for subprojects. >> >> Pardo

Re: [PULL 05/17] parallels: Out of image offset in BAT leads to image inflation

2023-06-07 Thread Michael Tokarev
07.06.2023 09:51, Michael Tokarev wrote: 05.06.2023 18:45, Hanna Czenczek wrote: From: Alexander Ivanov data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is outside of the image, any further write will create the cluster at this offset and/or the

Re: [PATCH v5 3/3] pc: q35: Bump max_cpus to 1024

2023-06-07 Thread Daniel P . Berrangé
On Wed, Jun 07, 2023 at 10:26:59AM +0200, Philippe Mathieu-Daudé wrote: > On 7/6/23 04:49, Suravee Suthikulpanit wrote: > > Since KVM_MAX_VCPUS is currently defined to 1024 for x86 as shown in > > arch/x86/include/asm/kvm_host.h, update QEMU limits to the same number. > > > > In case KVM could not

Re: [PATCH v2 04/12] hw/ssi: Add an "addr" property to SSIPeripheral

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 10:06, Joel Stanley wrote: On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: Boards will use this new property to identify the device CS line and wire the SPI controllers accordingly. "addr" and not "cs" or even "chip-select"? "chip-select" is a good suggestion! Reviewed-by:

Re: [PATCH 3/3] tests/qtest: Re-enable multifd cancel test

2023-06-07 Thread Juan Quintela
Fabiano Rosas wrote: > We've found the source of flakiness in this test, so re-enable it. > > Signed-off-by: Fabiano Rosas > --- > tests/qtest/migration-test.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration

Re: [PATCH v5 3/3] pc: q35: Bump max_cpus to 1024

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 04:49, Suravee Suthikulpanit wrote: Since KVM_MAX_VCPUS is currently defined to 1024 for x86 as shown in arch/x86/include/asm/kvm_host.h, update QEMU limits to the same number. In case KVM could not support the specified number of vcpus, QEMU would return the following error message:

Re: [PATCH 2/3] migration/multifd: Protect accesses to migration_threads

2023-06-07 Thread Juan Quintela
Fabiano Rosas wrote: > This doubly linked list is common for all the multifd and migration > threads so we need to avoid concurrent access. > > Add a mutex to protect the data from concurrent access. This fixes a > crash when removing two MigrationThread objects from the list at the > same time du

Re: [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices

2023-06-07 Thread Lei Yang
QE tested sanity testing for this patch on the vhost_vdpa device, everything works fine. Tested-by: Lei Yang On Tue, Jun 6, 2023 at 9:33 AM Jason Wang wrote: > > On Sat, Jun 3, 2023 at 1:33 AM Eugenio Pérez wrote: > > > > QEMU does not emulate it so it must be disabled as long as the backend >

Re: [PATCH] vdpa: fix not using CVQ buffer in case of error

2023-06-07 Thread Lei Yang
QE tested sanity testing for this patch on the vhost_vdpa device, everything works fine. Tested-by: Lei Yang On Tue, Jun 6, 2023 at 9:32 AM Jason Wang wrote: > > On Sat, Jun 3, 2023 at 1:35 AM Eugenio Pérez wrote: > > > > Bug introducing when refactoring. Otherway, the guest never received >

Re: [PATCH v5 1/3] hw/i386/pc: Refactor logic to set SMBIOS defaults

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 10:11, Daniel P. Berrangé wrote: On Tue, Jun 06, 2023 at 09:49:37PM -0500, Suravee Suthikulpanit wrote: Into a helper function pc_machine_init_smbios() in preparation for subsequent code to upgrade default SMBIOS entry point type. Then, call the helper function from the pc_machine_ini

Re: [PATCH v5 1/3] hw/i386/pc: Refactor logic to set SMBIOS defaults

2023-06-07 Thread Daniel P . Berrangé
On Tue, Jun 06, 2023 at 09:49:37PM -0500, Suravee Suthikulpanit wrote: > Into a helper function pc_machine_init_smbios() in preparation for > subsequent code to upgrade default SMBIOS entry point type. > > Then, call the helper function from the pc_machine_initfn() to eliminate > duplicate code in

Re: [PATCH v2 05/12] hw/ssi: Introduce a ssi_get_cs() helper

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > Simple routine to retrieve a DeviceState object on a SPI bus using its > address/cs. It will be useful for the board to wire the CS lines. > > Cc: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Cédric Le Goater R

Re: Reducing vdpa migration downtime because of memory pin / maps

2023-06-07 Thread Eugenio Perez Martin
On Wed, Jun 7, 2023 at 12:43 AM Si-Wei Liu wrote: > > Sorry for reviving this old thread, I lost the best timing to follow up > on this while I was on vacation. I have been working on this and found > out some discrepancy, please see below. > > On 4/5/23 04:37, Eugenio Perez Martin wrote: > > Hi!

Re: [PATCH v2 04/12] hw/ssi: Add an "addr" property to SSIPeripheral

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > Boards will use this new property to identify the device CS line and > wire the SPI controllers accordingly. "addr" and not "cs" or even "chip-select"? Reviewed-by: Joel Stanley > > Cc: Alistair Francis > Reviewed-by: Philippe Mathieu-D

Re: [PATCH v2 03/12] aspeed: Use the boot_rom region of the fby35 machine

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > This change completes commits 5aa281d757 ("aspeed: Introduce a > spi_boot region under the SoC") and 8b744a6a47 ("aspeed: Add a > boot_rom overlap region in the SoC spi_boot container") which > introduced a spi_boot container at the SoC leve

Re: [PATCH v2 02/12] aspeed: Introduce a boot_rom region at the machine level

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > This should also avoid Coverity to report a memory leak warning when > the QEMU process exits. See CID 1508061. Ok, so now our layout is this if booted with a mtd device (rainier-bmc): address-space: memory -f

Re: [PATCH v5 1/3] hw/i386/pc: Refactor logic to set SMBIOS defaults

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 04:49, Suravee Suthikulpanit wrote: "Refactor logic to set SMBIOS defaults" Into a helper function pc_machine_init_smbios() in preparation for subsequent code to upgrade default SMBIOS entry point type. Then, call the helper function from the pc_machine_initfn() to eliminate duplicat

Re: [PATCH] configure: check for $download value properly

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 09:50, Michal Privoznik wrote: If configure was invoked with --disable-download and git submodules were not checked out a warning is produced and the configure script fails. But the $download variable (which reflects the enable/disable download argument) is checked for in a weird fashio

Re: [PATCH 1/3] migration/multifd: Rename threadinfo.c functions

2023-06-07 Thread Philippe Mathieu-Daudé
On 6/6/23 16:45, Fabiano Rosas wrote: The code in threadinfo.c is only used for the QMP command query-migrationthreads. Make it explicit that this is something related to QMP. The current names are also too generic for a piece of code that doesn't affect the migration directly in any way. Signe

Re: [PATCH v2 01/12] aspeed/hace: Initialize g_autofree pointer

2023-06-07 Thread Joel Stanley
On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: > > As mentioned in docs/devel/style.rst "Automatic memory deallocation": > > * Variables declared with g_auto* MUST always be initialized, > otherwise the cleanup function will use uninitialized stack memory > > This avoids QEMU to coredump w

Re: [PATCH] target/ppc: Implement gathering irq statistics

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 00:02, BALATON Zoltan wrote: Count exceptions which can be queried with info irq monitor command. Signed-off-by: BALATON Zoltan --- target/ppc/cpu.h | 1 + target/ppc/cpu_init.c| 18 ++ target/ppc/excp_helper.c | 1 + 3 files changed, 20 insertions(+

[PATCH] configure: check for $download value properly

2023-06-07 Thread Michal Privoznik
If configure was invoked with --disable-download and git submodules were not checked out a warning is produced and the configure script fails. But the $download variable (which reflects the enable/disable download argument) is checked for in a weird fashion: test -f "$download" = disabled Drop

Re: [PATCH v2 00/10] meson: replace submodules with wrap files

2023-06-07 Thread Daniel P . Berrangé
On Wed, Jun 07, 2023 at 09:41:40AM +0200, Michal Prívozník wrote: > On 6/5/23 11:52, Paolo Bonzini wrote: > > This series replaces git submodules for bundled libraries with .wrap > > files that can be used directly by meson for subprojects. > > Pardon my lack of knowledge, but even after I clone

Re: [PATCH 1/2] target/arm: Only include tcg/oversized-guest.h if CONFIG_TCG

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 00:46, Richard Henderson wrote: Fixes the build for --disable-tcg. This header is only needed for cross-hosting. Without CONFIG_TCG, we know this is an AArch64 host, CONFIG_ATOMIC64 will be set, and the TCG_OVERSIZED_GUEST block will never be compiled. Signed-off-by: Richard Henderso

Re: [PATCH 2/2] gitlab: Add cross-arm64-kvm-only

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 00:46, Richard Henderson wrote: We are not currently running a --disable-tcg test for arm64, like we are for mips, ppc and s390x. We have a job for the native aarch64 runner, but it is not run by default and it is not helpful for normal developer testing without access to qemu's privat

Re: [PATCH 2/2] tcg/tci: Adjust call-clobbered regs for int128_t

2023-06-07 Thread Philippe Mathieu-Daudé
On 7/6/23 07:46, Richard Henderson wrote: We require either 2 or 4 registers to hold int128_t. Failure to do so results in a register allocation assert. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c.inc | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by:

Re: [PATCH v5 8/9] vfio/migration: Add x-allow-pre-copy VFIO device property

2023-06-07 Thread Avihai Horon
On 06/06/2023 16:40, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello Avihai On 6/6/23 13:59, Avihai Horon wrote: On 05/06/2023 17:56, Alex Williamson wrote: External email: Use caution opening links or attachments On Sun, 4 Jun 2023 12:33:43 +0300

Re: [PATCH v2 00/10] meson: replace submodules with wrap files

2023-06-07 Thread Michal Prívozník
On 6/5/23 11:52, Paolo Bonzini wrote: > This series replaces git submodules for bundled libraries with .wrap > files that can be used directly by meson for subprojects. Pardon my lack of knowledge, but even after I clone new repo and run: ./configure --enable-donwload && make && make test I s

Re: [PATCH] tests/avocado/tuxrun_baselines: Fix ppc64 tests for binaries without slirp

2023-06-07 Thread Thomas Huth
On 07/06/2023 06.22, Joel Stanley wrote: On Tue, 6 Jun 2023 at 19:28, Thomas Huth wrote: The ppc64 tuxrun tests are currently failing if "slirp" has been disabled in the binary since they are using "-netdev user" now. We have to skip the test if this network backend is missing. Do the boot t

Re: [PATCH v4 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI

2023-06-07 Thread Chen Baozi
> On Jun 7, 2023, at 10:33, Yuquan Wang wrote: > > The current sbsa-ref cannot use EHCI controller which is only > able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB. > Hence, this uses system bus XHCI to provide a usb controller with > 64-bit DMA capablity instead of EHCI. > > S

Re: [PATCH 2/2] gitlab: Add cross-arm64-kvm-only

2023-06-07 Thread Thomas Huth
On 07/06/2023 00.46, Richard Henderson wrote: We are not currently running a --disable-tcg test for arm64, like we are for mips, ppc and s390x. We have a job for the native aarch64 runner, but it is not run by default and it is not helpful for normal developer testing without access to qemu's pr

<    1   2   3