[PATCH v2 03/10] target/i386: Fix duplicated feature name in FEAT_KVM

2023-09-08 Thread Tim Wiederhake
The mistake became apparent as there were two features with the same name in this cpuid leaf. The names are now in line with the documentation from https://kernel.org/doc/html/latest/virt/kvm/x86/cpuid.html Fixes: 642258c6c7 ("kvm: add kvmclock to its second bit") Signed-off-by: Tim Wiederhake

[PATCH v2 01/10] target/i386: Add missing feature names in FEAT_VMX_EPT_VPID_CAPS

2023-09-08 Thread Tim Wiederhake
Add the missing feature names for two bits in the FEAT_VMX_EPT_VPID_CAPS cpuid leaf. "vmx-ept-uc" is currently unused, but "vmx-ept-wb" is enabled for multiple cpu models. Signed-off-by: Tim Wiederhake --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [virtio-dev] [RFC PATCH v2] docs/interop: define PROBE feature for vhost-user VirtIO devices

2023-09-08 Thread Stefan Hajnoczi
A QEMU built-in VIRTIO device will also call virtio_add_queue() for the maximum number of virtqueues. I'm not sure what the concern is about adding as few virtqueues as possible? If the front-end's implementation is inefficient, then it should be optimized so that untouched virtqueues don't

Re: [PATCH v2 18/22] semihosting/arm-compat: Clean up local variable shadowing

2023-09-08 Thread Peter Maydell
On Mon, 4 Sept 2023 at 17:15, Philippe Mathieu-Daudé wrote: > > Fix: > > semihosting/arm-compat-semi.c: In function ‘do_common_semihosting’: > semihosting/arm-compat-semi.c:379:13: warning: declaration of ‘ret’ shadows > a previous local [-Wshadow=local] > 379 | int ret, err = 0;

Re: [PATCH v2 07/22] hw/arm/armv7m: Clean up local variable shadowing

2023-09-08 Thread Peter Maydell
On Mon, 4 Sept 2023 at 17:13, Philippe Mathieu-Daudé wrote: > > Fix: > > hw/arm/armv7m.c: In function ‘armv7m_realize’: > hw/arm/armv7m.c:520:27: warning: declaration of ‘sbd’ shadows a previous > local [-Wshadow=compatible-local] > 520 | SysBusDevice *sbd =

[PULL v2 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-08 Thread Eric Blake
From: "Denis V. Lunev" Closing stderr earlier is good for daemonized qemu-nbd under ssh earlier, but breaks the case where -v is being used to track what is happening in the server, as in iotest 233. When we know we are verbose, we should preserve original stderr and restore it once the setup

[PULL v2 00/13] NBD patches for 2023-09-07

2023-09-08 Thread Eric Blake
The following changes since commit 03a3a62fbd0aa5227e978eef3c67d3978aec9e5f: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-09-07 10:29:06 -0400) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2023-09-07-v2 for you

Re: [PATCH v2 03/22] target/arm/hvf: Clean up local variable shadowing

2023-09-08 Thread Peter Maydell
On Mon, 4 Sept 2023 at 17:12, Philippe Mathieu-Daudé wrote: > > Per Peter Maydell analysis [*]: > > The hvf_vcpu_exec() function is not documented, but in practice > its caller expects it to return either EXCP_DEBUG (for "this was > a guest debug exception you need to deal with") or

Re: [PATCH] hw: forbid DEFINE_PROP_ARRAY for user creatable devices

2023-09-08 Thread Kevin Wolf
Am 08.09.2023 um 11:29 hat Daniel P. Berrangé geschrieben: > The DEFINE_PROP_ARRAY macro is a clever trick for defining array > properties. It initially creates a property "len-$FOO". When that > property is set, then it creates a sequence "$FOO[NN]" for NN > in the range 0 to "len-$FOO". > > The

Re: [PATCH v2 02/22] target/arm/tcg: Clean up local variable shadowing

2023-09-08 Thread Peter Maydell
On Mon, 4 Sept 2023 at 17:12, Philippe Mathieu-Daudé wrote: > > Fix: > > target/arm/tcg/translate-m-nocp.c: In function ‘gen_M_fp_sysreg_read’: > target/arm/tcg/translate-m-nocp.c:509:18: warning: declaration of ‘tmp’ > shadows a previous local [-Wshadow=compatible-local] > 509 |

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-08 Thread Kevin Wolf
Am 08.09.2023 um 11:53 hat Peter Maydell geschrieben: > On Fri, 8 Sept 2023 at 10:26, Kevin Wolf wrote: > > > > Am 07.09.2023 um 11:35 hat Peter Maydell geschrieben: > > > On Thu, 7 Sept 2023 at 10:33, Markus Armbruster wrote: > > > > > > > > Kevin Wolf writes: > > > > > > > > > Am 04.09.2023

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-08 Thread Daniel P . Berrangé
On Fri, Sep 08, 2023 at 02:16:35PM +0200, Kevin Wolf wrote: > Am 08.09.2023 um 11:27 hat Daniel P. Berrangé geschrieben: > > On Fri, Sep 08, 2023 at 11:25:54AM +0200, Kevin Wolf wrote: > > > Am 07.09.2023 um 11:35 hat Peter Maydell geschrieben: > > > > On Thu, 7 Sept 2023 at 10:33, Markus

Re: [PATCH] hw/intc/arm_gicv3: Simplify gicv3_class_name() logic

2023-09-08 Thread Peter Maydell
On Tue, 5 Sept 2023 at 15:56, Philippe Mathieu-Daudé wrote: > > Simplify gicv3_class_name() logic. No functional change intended. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/intc/arm_gicv3_common.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-08 Thread Kevin Wolf
Am 08.09.2023 um 11:27 hat Daniel P. Berrangé geschrieben: > On Fri, Sep 08, 2023 at 11:25:54AM +0200, Kevin Wolf wrote: > > Am 07.09.2023 um 11:35 hat Peter Maydell geschrieben: > > > On Thu, 7 Sept 2023 at 10:33, Markus Armbruster wrote: > > > > > > > > Kevin Wolf writes: > > > > > > > > > Am

Re: [PULL 00/17] Net patches

2023-09-08 Thread Daniel P . Berrangé
On Fri, Sep 08, 2023 at 02:00:47PM +0200, Ilya Maximets wrote: > On 9/8/23 13:49, Daniel P. Berrangé wrote: > > On Fri, Sep 08, 2023 at 01:34:54PM +0200, Ilya Maximets wrote: > >> On 9/8/23 13:19, Stefan Hajnoczi wrote: > >>> Hi Ilya and Jason, > >>> There is a CI failure related to a missing

Re: [PATCH v2] target/arm: Do not use gen_mte_checkN in trans_STGP

2023-09-08 Thread Peter Maydell
On Fri, 1 Sept 2023 at 21:31, Richard Henderson wrote: > > STGP writes to tag memory, it does not check it. > This happened to work because we wrote tag memory first > so that the check always succeeded. > > Signed-off-by: Richard Henderson Applied to target-arm.next, thanks. -- PMM

Re: [RFC PATCH v2] docs/interop: define PROBE feature for vhost-user VirtIO devices

2023-09-08 Thread Alex Bennée
Stefan Hajnoczi writes: > On Fri, Sep 01, 2023 at 12:00:18PM +0100, Alex Bennée wrote: >> Currently QEMU has to know some details about the VirtIO device >> supported by a vhost-user daemon to be able to setup the guest. This >> makes it hard for QEMU to add support for additional vhost-user

Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-08 Thread Eric Blake
On Fri, Sep 08, 2023 at 01:42:00PM +0200, Denis V. Lunev wrote: > On 9/8/23 13:24, Denis V. Lunev wrote: > > On 9/8/23 13:03, Stefan Hajnoczi wrote: > > > Please resolve the following CI failure: > > > > > > https://gitlab.com/qemu-project/qemu/-/jobs/5045998355 > > > > > > ../qemu-nbd.c: In

Re: [PATCH v4 12/15] vfio/common: Support device dirty page tracking with vIOMMU

2023-09-08 Thread Joao Martins
On 08/09/2023 12:52, Duan, Zhenzhong wrote: > On 9/8/2023 6:11 PM, Joao Martins wrote: >> On 08/09/2023 07:11, Duan, Zhenzhong wrote: >>> Hi Joao, >>> >>> On 6/23/2023 5:48 AM, Joao Martins wrote: Currently, device dirty page tracking with vIOMMU is not supported, and a blocker is added

[PATCH RFC] vfio/common: Add an option to relax vIOMMU migration blocker

2023-09-08 Thread Joao Martins
Add an option 'x-migration-iommu-pt' to VFIO that allows it to relax whether the vIOMMU usage blocks the migration. The current behaviour is kept and we block migration in the following conditions: * By default if the guest does try to use vIOMMU migration is blocked when migration is attempted,

Re: [PATCH v5 0/8] Xilinx Versal CFI support

2023-09-08 Thread Peter Maydell
On Thu, 31 Aug 2023 at 17:57, Francisco Iglesias wrote: > > Hi, > > This series adds support for the Configuration Frame Unit (CFU) and the > Configuration Frame controllers (CFRAME) to the Xilinx Versal machine > ([1], chapter 21) for emulaing bitstream loading and readback. > > The series

Re: [virtio-dev] [RFC PATCH v2] docs/interop: define PROBE feature for vhost-user VirtIO devices

2023-09-08 Thread Alex Bennée
Stefan Hajnoczi writes: > On Fri, 8 Sept 2023 at 02:43, Alex Bennée wrote: >> >> >> Stefan Hajnoczi writes: >> >> > On Tue, Sep 05, 2023 at 10:34:11AM +0100, Alex Bennée wrote: >> >> >> >> Albert Esteve writes: >> >> >> >> > This looks great! Thanks for this proposal. >> >> > >> >> > On

Re: [PULL 00/17] Net patches

2023-09-08 Thread Ilya Maximets
On 9/8/23 13:49, Daniel P. Berrangé wrote: > On Fri, Sep 08, 2023 at 01:34:54PM +0200, Ilya Maximets wrote: >> On 9/8/23 13:19, Stefan Hajnoczi wrote: >>> Hi Ilya and Jason, >>> There is a CI failure related to a missing Debian libxdp-dev package: >>>

Re: [PATCH] hw/intc/arm_gicv3_its: Avoid maybe-uninitialized error in get_vte()

2023-09-08 Thread Peter Maydell
On Thu, 31 Aug 2023 at 14:13, Philippe Mathieu-Daudé wrote: > > Fix when using GCC v11.4 (Ubuntu 11.4.0-1ubuntu1~22.04) with CFLAGS=-Og: > > [4/6] Compiling C object libcommon.fa.p/hw_intc_arm_gicv3_its.c.o > FAILED: libcommon.fa.p/hw_intc_arm_gicv3_its.c.o > inlined from ‘lookup_vte’

Re: [PATCH v5 00/12] Implement Most ARMv8.3 Pointer Authentication Features

2023-09-08 Thread Peter Maydell
On Wed, 30 Aug 2023 at 00:24, Richard Henderson wrote: > > Changes for v5: > * Updates for review. > * Include linux-user ESR changes. > > Patch 10 is the only one without review. > > > r~ Applied to target-arm.next. Thanks to both you and Aaron for this work. -- PMM

Re: [PULL 12/17] net: add initial support for AF_XDP network backend

2023-09-08 Thread Ilya Maximets
On 9/8/23 13:48, Daniel P. Berrangé wrote: > On Fri, Sep 08, 2023 at 02:45:02PM +0800, Jason Wang wrote: >> From: Ilya Maximets >> >> AF_XDP is a network socket family that allows communication directly >> with the network device driver in the kernel, bypassing most or all >> of the kernel

Re: [PATCH v4 12/15] vfio/common: Support device dirty page tracking with vIOMMU

2023-09-08 Thread Duan, Zhenzhong
On 9/8/2023 6:11 PM, Joao Martins wrote: On 08/09/2023 07:11, Duan, Zhenzhong wrote: Hi Joao, On 6/23/2023 5:48 AM, Joao Martins wrote: Currently, device dirty page tracking with vIOMMU is not supported, and a blocker is added and the migration is prevented. When vIOMMU is used, IOVA

Re: [PULL 00/17] Net patches

2023-09-08 Thread Daniel P . Berrangé
On Fri, Sep 08, 2023 at 01:34:54PM +0200, Ilya Maximets wrote: > On 9/8/23 13:19, Stefan Hajnoczi wrote: > > Hi Ilya and Jason, > > There is a CI failure related to a missing Debian libxdp-dev package: > > https://gitlab.com/qemu-project/qemu/-/jobs/5046139967 > > > > I think the issue is that

Re: [PULL 12/17] net: add initial support for AF_XDP network backend

2023-09-08 Thread Daniel P . Berrangé
On Fri, Sep 08, 2023 at 02:45:02PM +0800, Jason Wang wrote: > From: Ilya Maximets > > AF_XDP is a network socket family that allows communication directly > with the network device driver in the kernel, bypassing most or all > of the kernel networking stack. In the essence, the technology is >

Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-08 Thread Denis V. Lunev
On 9/8/23 13:24, Denis V. Lunev wrote: On 9/8/23 13:03, Stefan Hajnoczi wrote: Please resolve the following CI failure: https://gitlab.com/qemu-project/qemu/-/jobs/5045998355 ninja: job failed: cc -m64 -mcx16 -Iqemu-nbd.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/p11-kit-1

Re: [PULL 00/17] Net patches

2023-09-08 Thread Ilya Maximets
On 9/8/23 13:19, Stefan Hajnoczi wrote: > Hi Ilya and Jason, > There is a CI failure related to a missing Debian libxdp-dev package: > https://gitlab.com/qemu-project/qemu/-/jobs/5046139967 > > I think the issue is that the debian-amd64 container image that QEMU > uses for testing is based on

[PATCH 2/4] hw/cpu: Call object_class_is_abstract() once in cpu_class_by_name()

2023-09-08 Thread Philippe Mathieu-Daudé
Let CPUClass::class_by_name() handlers to return abstract classes, and filter them once in the public cpu_class_by_name() method. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 7 --- hw/core/cpu-common.c | 14 +++--- target/arm/cpu.c | 3 +--

[PATCH 3/4] hw/cpu: Introduce CPUClass::cpu_resolving_type field

2023-09-08 Thread Philippe Mathieu-Daudé
Add a field to return the QOM type name of a CPU class. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 2 ++ hw/core/cpu-common.c| 2 +- target/alpha/cpu.c | 1 + target/arm/cpu.c| 1 + target/avr/cpu.c| 1 + target/cris/cpu.c | 1 +

[PATCH 0/4] hw/core/cpu-common: Consolidate cpu_class_by_name()

2023-09-08 Thread Philippe Mathieu-Daudé
Gavin noticed the same pattern is duplicated in many CPUClass::class_by_name() handlers [*]. This series consolidate the calls to - object_class_is_abstract() - object_class_dynamic_cast() in the common cpu_class_by_name(), by introducing the CPUClass::cpu_resolving_type field. [*]

Re: [PATCH v3 15/32] target/s390x: Use generic helper to show CPU model names

2023-09-08 Thread Philippe Mathieu-Daudé
On 8/9/23 10:04, Philippe Mathieu-Daudé wrote: On 8/9/23 01:44, Gavin Shan wrote: On 9/7/23 18:20, David Hildenbrand wrote: On 07.09.23 02:35, Gavin Shan wrote: For target/s390x, the CPU type name is always the combination of the CPU modle name and suffix. The CPU model names have been

Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-08 Thread Denis V. Lunev
On 9/8/23 13:03, Stefan Hajnoczi wrote: Please resolve the following CI failure: https://gitlab.com/qemu-project/qemu/-/jobs/5045998355 ninja: job failed: cc -m64 -mcx16 -Iqemu-nbd.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0

[PATCH 1/4] target/alpha: Tidy up alpha_cpu_class_by_name()

2023-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/cpu.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index 270ae787b1..351ee2e9f2 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -142,13 +142,10 @@ static

[PATCH 4/4] hw/cpu: Call object_class_dynamic_cast() once in cpu_class_by_name()

2023-09-08 Thread Philippe Mathieu-Daudé
Leverage the public CPUClass::cpu_resolving_type field and call object_class_dynamic_cast() once in cpu_class_by_name(). Signed-off-by: Philippe Mathieu-Daudé --- hw/core/cpu-common.c | 3 ++- target/alpha/cpu.c | 3 +-- target/arm/cpu.c | 4 +--- target/avr/cpu.c | 4 +---

Re: [PULL 00/17] Net patches

2023-09-08 Thread Stefan Hajnoczi
Hi Ilya and Jason, There is a CI failure related to a missing Debian libxdp-dev package: https://gitlab.com/qemu-project/qemu/-/jobs/5046139967 I think the issue is that the debian-amd64 container image that QEMU uses for testing is based on Debian 11 ("bullseye" aka "oldstable") and libxdp is

Re: [PULL 00/65] riscv-to-apply queue

2023-09-08 Thread Stefan Hajnoczi
into staging > (2023-09-07 10:29:06 -0400) > > are available in the Git repository at: > > https://github.com/alistair23/qemu.git tags/pull-riscv-to-apply-20230908 > > for you to fetch changes up to 69749970db9f1b05c8cd77a7bbb45e4e156f7d33: > > target/riscv/cpu.c: consi

Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-08 Thread Stefan Hajnoczi
Please resolve the following CI failure: https://gitlab.com/qemu-project/qemu/-/jobs/5045998355 ninja: job failed: cc -m64 -mcx16 -Iqemu-nbd.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -fdiagnostics-color=auto -Wall

Re: [PATCH V4 1/2] migration: file URI

2023-09-08 Thread Daniel P . Berrangé
On Wed, Aug 30, 2023 at 10:15:43AM -0400, Steven Sistare wrote: > On 8/30/2023 9:16 AM, Daniel P. Berrangé wrote: > > On Fri, Jun 30, 2023 at 07:25:07AM -0700, Steve Sistare wrote: > >> Extend the migration URI to support file:. This can be used for > >> any migration scenario that does not

Re: [PATCH v3 4/4] io: follow coroutine AioContext in qio_channel_yield()

2023-09-08 Thread Stefan Hajnoczi
On Thu, Sep 07, 2023 at 03:41:08PM -0500, Eric Blake wrote: > On Wed, Aug 30, 2023 at 06:48:02PM -0400, Stefan Hajnoczi wrote: > > The ongoing QEMU multi-queue block layer effort makes it possible for > > multiple > > threads to process I/O in parallel. The nbd block driver is not compatible > >

Re: [RFC PATCH] softmmu: Fix async_run_on_cpu() use in tcg_commit_cpu()

2023-09-08 Thread Philippe Mathieu-Daudé
On 7/9/23 21:36, Philippe Mathieu-Daudé wrote: On 7/9/23 18:28, Richard Henderson wrote: On 9/7/23 09:14, Philippe Mathieu-Daudé wrote: CPUState::halt_cond is an accelerator specific pointer, used in particular by TCG (which tcg_commit() is about). The pointer is set by the

Re: [PATCH 0/2] virtio: Drop out of coroutine context in virtio_load()

2023-09-08 Thread Stefan Hajnoczi
On Tue, Sep 05, 2023 at 04:50:00PM +0200, Kevin Wolf wrote: > This fixes a recently introduced assertion failure that was reported to > happen when migrating virtio-net with a failover. The latent bug that > we're executing code in coroutine context that was never supposed to run > there has

Re: [PATCH 2/2] virtio: Drop out of coroutine context in virtio_load()

2023-09-08 Thread Stefan Hajnoczi
On Fri, Sep 08, 2023 at 10:59:48AM +0200, Kevin Wolf wrote: > Am 07.09.2023 um 20:40 hat Stefan Hajnoczi geschrieben: > > On Tue, Sep 05, 2023 at 04:50:02PM +0200, Kevin Wolf wrote: > > > virtio_load() as a whole should run in coroutine context because it > > > reads from the migration stream and

Re: [RESEND] qemu/timer: Add host ticks function for RISC-V

2023-09-08 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] mem/x86: add processor address space check for VM memory

2023-09-08 Thread David Hildenbrand
On 08.09.23 11:50, Ani Sinha wrote: Depending on the number of available address bits of the current processor, a VM can only use a certain maximum amount of memory and no more. This change makes sure that a VM is not configured to have more memory than what it can use with the current processor

Re: [PATCH v4 15/15] vfio/common: Block migration with vIOMMUs without address width limits

2023-09-08 Thread Joao Martins
On 08/09/2023 07:28, Duan, Zhenzhong wrote: > > On 6/23/2023 5:48 AM, Joao Martins wrote: >> Only block the case when the underlying vIOMMU model does not report any >> address space limits, in addition to DMA translation being off or no >> vIOMMU present. The limits are needed such that can

Re: [PATCH v4 12/15] vfio/common: Support device dirty page tracking with vIOMMU

2023-09-08 Thread Joao Martins
On 08/09/2023 07:11, Duan, Zhenzhong wrote: > Hi Joao, > > On 6/23/2023 5:48 AM, Joao Martins wrote: >> Currently, device dirty page tracking with vIOMMU is not supported, >> and a blocker is added and the migration is prevented. >> >> When vIOMMU is used, IOVA ranges are DMA mapped/unmapped on

Re: [virtio-dev] [RFC PATCH v2] docs/interop: define PROBE feature for vhost-user VirtIO devices

2023-09-08 Thread Stefan Hajnoczi
On Fri, 8 Sept 2023 at 02:43, Alex Bennée wrote: > > > Stefan Hajnoczi writes: > > > On Tue, Sep 05, 2023 at 10:34:11AM +0100, Alex Bennée wrote: > >> > >> Albert Esteve writes: > >> > >> > This looks great! Thanks for this proposal. > >> > > >> > On Fri, Sep 1, 2023 at 1:00 PM Alex Bennée >

Re: [PATCH v4 06/15] intel-iommu: Implement get_attr() method

2023-09-08 Thread Joao Martins
On 08/09/2023 07:23, Duan, Zhenzhong wrote: > > On 6/23/2023 5:48 AM, Joao Martins wrote: >> Implement IOMMU MR get_attr() method and use the dma_translation >> property to report the IOMMU_ATTR_DMA_TRANSLATION attribute. >> Additionally add the necessary get_iommu_attr into the PCIIOMMUOps to

[PULL v2 00/22] Trivial patches for 2023-09-08

2023-09-08 Thread Michael Tokarev
The following changes since commit 03a3a62fbd0aa5227e978eef3c67d3978aec9e5f: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-09-07 10:29:06 -0400) are available in the Git repository at: https://gitlab.com/mjt0k/qemu.git tags/pull-trivial-patches for you to

Re: [PATCH] io: Stop appending -listen to net listeners

2023-09-08 Thread Daniel P . Berrangé
On Mon, Sep 04, 2023 at 11:41:08AM -0300, Fabiano Rosas wrote: > All callers of qio_net_listener_set_name() already add some sort of > "listen" or "listener" suffix. > > For intance, we currently have "migration-socket-listener-listen" and > "vnc-listen-listen" as ioc names. > > Signed-off-by:

Re: [PATCH] crypto/rsakey-builtin.c.inc: Clean up two error paths

2023-09-08 Thread Daniel P . Berrangé
On Fri, Sep 01, 2023 at 02:32:26PM +0200, Markus Armbruster wrote: > When qcrypto_builtin_rsa_public_key_parse() is about to fail, but no > error has been set, it makes one up. Actually, there's just one way > to fail without setting an error. Set it there instead. > > Same for

Re: [PULL 01/23] qemu-img: omit errno value in error message

2023-09-08 Thread Michael Tokarev
08.09.2023 12:54, Michael Tokarev wrote: I'm getting io-qcow2-244 test failure on mips* due to output mismatch: Take an internal snapshot: -qemu-img: Could not create snapshot 'test': -95 (Operation not supported) +qemu-img: Could not create snapshot 'test': -122 (Operation not

[PULL 21/23] tests/qtest/usb-hcd: Remove the empty "init" tests

2023-09-08 Thread Michael Tokarev
From: Thomas Huth These tests do nothing additional compared to the other test, so let's remove the empty functions to avoid wasting some few precious test cycles here. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev ---

Re: [SeaBIOS] new release tag?

2023-09-08 Thread Niklas Cassel
On Thu, Aug 24, 2023 at 10:56:05AM +0200, Gerd Hoffmann wrote: > On Mon, Aug 07, 2023 at 10:51:33AM +, Niklas Cassel via SeaBIOS wrote: > > Hello Seabios maintainers, > > > > > > I was wondering, is there any chance of getting a new release tag > > (e.g. rel-1.16.3) anytime soon? > > Or is

[PULL 14/23] qemu-options.hx: Rephrase the descriptions of the -hd* and -cdrom options

2023-09-08 Thread Michael Tokarev
From: Thomas Huth The current description says that these options will create a device on the IDE bus, which is only true on x86. So rephrase these sentences a little bit to speak of "default bus" instead. Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée Signed-off-by: Michael Tokarev ---

[PULL 22/23] hw/net/vmxnet3: Fix guest-triggerable assert()

2023-09-08 Thread Michael Tokarev
From: Thomas Huth The assert() that checks for valid MTU sizes can be triggered by the guest (e.g. with the reproducer code from the bug ticket https://gitlab.com/qemu-project/qemu/-/issues/517 ). Let's avoid this problem by simply logging the error and refusing to activate the device instead.

[PULL 15/23] docs tests: Fix use of migrate_set_parameter

2023-09-08 Thread Michael Tokarev
From: Markus Armbruster docs/multi-thread-compression.txt uses parameter names with underscores instead of dashes. Wrong since day one. docs/rdma.txt, tests/qemu-iotests/181, and tests/qtest/test-hmp.c are wrong the same way since commit cbde7be900d2 (v6.0.0). Hard to see, as test-hmp doesn't

[PULL 23/23] qxl: don't assert() if device isn't yet initialized

2023-09-08 Thread Michael Tokarev
From: Marc-André Lureau If the PCI BAR isn't yet mapped or was unmapped, QXL_IO_SET_MODE will assert(). Instead, report a guest bug and keep going. This can be reproduced with: cat << EOF | ./qemu-system-x86_64 -vga qxl -m 2048 -nodefaults -qtest stdio outl 0xcf8 0x8000101c outl 0xcfc 0xc000

[PULL 08/23] scripts/: spelling fixes

2023-09-08 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Alex Bennée --- scripts/checkpatch.pl | 2 +- scripts/ci/gitlab-pipeline-status | 2 +- scripts/codeconverter/codeconverter/qom_macros.py | 2 +- scripts/oss-fuzz/minimize_qtest_trace.py | 8

[PULL 19/23] hw/ppc: use g_free() in spapr_tce_table_post_load()

2023-09-08 Thread Michael Tokarev
From: Daniel Henrique Barboza tcet->mig_table is copied from tcet->table, which in turn is created in spapr_tce_alloc_table() using g_new0(). Use g_free() instead of free() to deallocate it. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev

[PULL 16/23] tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test

2023-09-08 Thread Michael Tokarev
From: Markus Armbruster The command always fails with "Error: Parameter 'xbzrle_cache_size' expects a power of two no less than the target page size". The test passes anyway. Change the argument from 1 to 64k to make the test a bit more useful. Signed-off-by: Markus Armbruster Reviewed-by:

[PULL 09/23] tests/: spelling fixes

2023-09-08 Thread Michael Tokarev
with some rewording in tests/qemu-iotests/298 tests/qtest/fuzz/generic_fuzz.c tests/unit/test-throttle.c as suggested by Eric. Signed-off-by: Michael Tokarev Reviewed-by: Eric Blake --- tests/avocado/acpi-bits.py | 4 ++--

[PULL 20/23] target/ppc: use g_free() in test_opcode_table()

2023-09-08 Thread Michael Tokarev
From: Daniel Henrique Barboza table[i] is allocated in create_new_table() using g_new(). Use g_free(table[i]) instead of free(table[i]) to comply with QEMU low level memory management guidelines. Signed-off-by: Daniel Henrique Barboza Signed-off-by: Michael Tokarev [Mjt: minor commit comment

[PULL 13/23] hw/display/xlnx_dp: update comments

2023-09-08 Thread Michael Tokarev
From: Peter Maydell Clarify somewhat misleading code comments. Signed-off-by: Peter Maydell Reviewed-by: Michael Tokarev Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- hw/display/xlnx_dp.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PULL 05/23] xen: spelling fix

2023-09-08 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Acked-by: David Woodhouse --- hw/xen/xen_pvdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c index be1504b82c..c5ad71e8dc 100644 --- a/hw/xen/xen_pvdev.c +++ b/hw/xen/xen_pvdev.c @@ -89,7 +89,7 @@

[PULL 18/23] trivial: Simplify the spots that use TARGET_BIG_ENDIAN as a numeric value

2023-09-08 Thread Michael Tokarev
From: Thomas Huth TARGET_BIG_ENDIAN is *always* defined, either as 0 for little endian targets or as 1 for big endian targets. So we can use this as a value directly in places that need such a 0 or 1 for some reason, instead of taking a detour through an additional local variable or something

[PULL 12/23] block: spelling fixes

2023-09-08 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Eric Blake --- block.c | 2 +- block/block-copy.c | 4 ++-- block/export/vduse-blk.c | 2 +- block/export/vhost-user-blk-server.c | 2 +- block/export/vhost-user-blk-server.h | 2 +-

[PULL 03/23] hexagon: spelling fixes

2023-09-08 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Brian Cain --- target/hexagon/README | 2 +- target/hexagon/fma_emu.c| 2 +- target/hexagon/idef-parser/README.rst | 2 +- target/hexagon/idef-parser/idef-parser.h| 2 +-

[PULL 07/23] include/: spelling fixes

2023-09-08 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Alex Bennée --- include/block/block_int-common.h | 2 +- include/chardev/char-fe.h| 4 ++-- include/crypto/akcipher.h| 2 +- include/crypto/ivgen.h | 4 ++-- include/hw/acpi/aml-build.h | 2 +-

[PULL 17/23] accel/tcg: Fix typo in translator_io_start() description

2023-09-08 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Missed while reviewing commit dfd1b81274 ("accel/tcg: Introduce translator_io_start"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- include/exec/translator.h | 2 +- 1 file changed, 1 insertion(+), 1

[PULL 11/23] misc/other: spelling fixes

2023-09-08 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Eric Blake --- backends/tpm/tpm_ioctl.h | 2 +- chardev/char-socket.c| 6 +++--- chardev/char.c | 2 +- crypto/afalg.c | 2 +- crypto/block-luks.c | 6 +++--- crypto/der.c | 2 +- crypto/der.h | 6

[PULL 10/23] qga/: spelling fixes

2023-09-08 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Eric Blake --- qga/channel-posix.c | 2 +- qga/commands-posix-ssh.c | 2 +- qga/commands-posix.c | 2 +- qga/commands-win32.c | 4 ++-- qga/main.c| 2 +- qga/vss-win32/install.cpp | 4 ++-- 6 files changed, 8

[PULL 06/23] audio: spelling fixes

2023-09-08 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Philippe Mathieu-Daudé --- audio/mixeng.h| 2 +- hw/audio/fmopl.c | 8 hw/audio/fmopl.h | 2 +- hw/audio/gusemu_hal.c | 4 ++-- hw/audio/intel-hda-defs.h | 4 ++-- 5 files changed, 10 insertions(+), 10

[PULL 01/23] qemu-img: omit errno value in error message

2023-09-08 Thread Michael Tokarev
I'm getting io-qcow2-244 test failure on mips* due to output mismatch: Take an internal snapshot: -qemu-img: Could not create snapshot 'test': -95 (Operation not supported) +qemu-img: Could not create snapshot 'test': -122 (Operation not supported) No errors were found on the image. This

[PULL 04/23] riscv: spelling fixes

2023-09-08 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Acked-by: Alistair Francis --- hw/riscv/microchip_pfsoc.c| 2 +- hw/riscv/virt.c | 4 ++-- include/hw/riscv/riscv_hart.h | 2 +- target/riscv/cpu.h| 2 +- target/riscv/cpu_bits.h

[PULL 02/23] trace-events: Fix the name of the tracing.rst file

2023-09-08 Thread Michael Tokarev
From: Thomas Huth The file has been converted to .rst a while ago - make sure that the references in the trace-events files are pointing to the right location now. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- bsd-user/trace-events | 2 +- ebpf/trace-events

[PULL 00/23] trivial patches for 2023-09-08

2023-09-08 Thread Michael Tokarev
The following changes since commit 03a3a62fbd0aa5227e978eef3c67d3978aec9e5f: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-09-07 10:29:06 -0400) are available in the Git repository at: https://gitlab.com/mjt0k/qemu.git tags/pull-trivial-patches for you to

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-08 Thread Peter Maydell
On Fri, 8 Sept 2023 at 10:26, Kevin Wolf wrote: > > Am 07.09.2023 um 11:35 hat Peter Maydell geschrieben: > > On Thu, 7 Sept 2023 at 10:33, Markus Armbruster wrote: > > > > > > Kevin Wolf writes: > > > > > > > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben: > > > >> By the time of

[PATCH] mem/x86: add processor address space check for VM memory

2023-09-08 Thread Ani Sinha
Depending on the number of available address bits of the current processor, a VM can only use a certain maximum amount of memory and no more. This change makes sure that a VM is not configured to have more memory than what it can use with the current processor settings when started. Additionally,

Re: [PATCH] arm64: Restore trapless ptimer access

2023-09-08 Thread Peter Maydell
On Thu, 7 Sept 2023 at 20:31, Michael Tokarev wrote: > > 31.08.2023 22:00, Colton Lewis wrote: > > Due to recent KVM changes, QEMU is setting a ptimer offset resulting > > in unintended trap and emulate access and a consequent performance > > hit. Filter out the PTIMER_CNT register to restore

Re: [PATCH] hw/display/xlnx_dp: update comments

2023-09-08 Thread Peter Maydell
On Thu, 7 Sept 2023 at 21:35, Michael Tokarev wrote: > > From: Peter Maydell > > Clarify somewhat misleading code comments. > > Signed-off-by: Michael Tokarev > --- > hw/display/xlnx_dp.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > Peter, this is the result of your

Re: [PATCH 10/21] q800: add easc bool machine class property to switch between ASC and EASC

2023-09-08 Thread Philippe Mathieu-Daudé
On 8/9/23 08:54, Mark Cave-Ayland wrote: On 07/07/2023 09:29, Philippe Mathieu-Daudé wrote: On 2/7/23 17:48, Mark Cave-Ayland wrote: This determines whether the Apple Sound Chip (ASC) is set to enhanced mode (default) or to original mode. The real Q800 hardware used an EASC chip however a

Re: [PATCH v3 2/3] i386: Explicitly ignore unsupported BUS_MCEERR_AO MCE on AMD guest

2023-09-08 Thread Gupta, Pankaj
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 5fce74aac5..4d42d3ed4c 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -604,6 +604,10 @@ static void kvm_mce_inject(X86CPU *cpu, hwaddr paddr, int code)   mcg_status |= MCG_STATUS_RIPV;   }

[PATCH] hw: forbid DEFINE_PROP_ARRAY for user creatable devices

2023-09-08 Thread Daniel P . Berrangé
The DEFINE_PROP_ARRAY macro is a clever trick for defining array properties. It initially creates a property "len-$FOO". When that property is set, then it creates a sequence "$FOO[NN]" for NN in the range 0 to "len-$FOO". The intended usage for this was to simplify code for internal devices,

[PATCH v1] vfio/common: Separate vfio-pci ranges

2023-09-08 Thread Joao Martins
QEMU computes the DMA logging ranges for two predefined ranges: 32-bit and 64-bit. In the OVMF case, when the dynamic MMIO window is enabled, QEMU includes in the 64-bit range the RAM regions at the lower part and vfio-pci device RAM regions which are at the top of the address space. This range

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-08 Thread Daniel P . Berrangé
On Fri, Sep 08, 2023 at 11:25:54AM +0200, Kevin Wolf wrote: > Am 07.09.2023 um 11:35 hat Peter Maydell geschrieben: > > On Thu, 7 Sept 2023 at 10:33, Markus Armbruster wrote: > > > > > > Kevin Wolf writes: > > > > > > > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben: > > > >> By the

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-08 Thread Kevin Wolf
Am 07.09.2023 um 11:35 hat Peter Maydell geschrieben: > On Thu, 7 Sept 2023 at 10:33, Markus Armbruster wrote: > > > > Kevin Wolf writes: > > > > > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben: > > >> By the time of the 8.2.0 release, it will have been 2 years and 6 > > >> releases

Re: [PATCH 2/2] virtio: Drop out of coroutine context in virtio_load()

2023-09-08 Thread Kevin Wolf
Am 07.09.2023 um 20:40 hat Stefan Hajnoczi geschrieben: > On Tue, Sep 05, 2023 at 04:50:02PM +0200, Kevin Wolf wrote: > > virtio_load() as a whole should run in coroutine context because it > > reads from the migration stream and we don't want this to block. > > Is that "should" a "must" or a

Re: [PATCH 0/2] virtio: Drop out of coroutine context in virtio_load()

2023-09-08 Thread Kevin Wolf
Am 07.09.2023 um 20:42 hat Stefan Hajnoczi geschrieben: > On Tue, Sep 05, 2023 at 04:50:00PM +0200, Kevin Wolf wrote: > > This fixes a recently introduced assertion failure that was reported to > > happen when migrating virtio-net with a failover. The latent bug that > > we're executing code in

[PATCH v2 2/8] hw/acpi/cpu: Have build_cpus_aml() take a build_madt_cpu_fn callback

2023-09-08 Thread Bernhard Beschow
build_cpus_aml() is architecture independent but needs to create architecture- specific CPU AML. So far this was achieved by using a virtual method from TYPE_ACPI_DEVICE_IF. However, build_cpus_aml() would resolve this interface from global (!) state. This makes it quite incomprehensible where

[PATCH v2 3/8] hw/acpi/acpi_dev_interface: Remove now unused madt_cpu virtual method

2023-09-08 Thread Bernhard Beschow
This virtual method was always set to the x86-specific pc_madt_cpu_entry(), even in piix4 which is also used in MIPS. The previous changes use pc_madt_cpu_entry() otherwise, so madt_cpu can be dropped. Since pc_madt_cpu_entry() is now only used in x86-specific code, the stub in

[PATCH v2 7/8] hw/acpi: Trace GPE access in all device models, not just PIIX4

2023-09-08 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- hw/acpi/core.c | 5 + hw/acpi/piix4.c | 3 --- hw/acpi/trace-events | 8 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c

[PATCH v2 6/8] hw/i386/acpi-build: Determine SMI command port just once

2023-09-08 Thread Bernhard Beschow
The SMI command port is currently hardcoded by means of the ACPI_PORT_SMI_CMD macro. This hardcoding is Intel specific and doesn't match VIA, for example. There is already the AcpiFadtData::smi_cmd attribute which is used when building the FADT. Let's also use it when building the DSDT which

[PATCH v2 1/8] hw/i386/acpi-build: Use pc_madt_cpu_entry() directly

2023-09-08 Thread Bernhard Beschow
This is x86-specific code, so there is no advantage in using pc_madt_cpu_entry() behind an architecture-agnostic interface. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/acpi-common.h | 3 +-- hw/i386/acpi-build.c | 3 +-- hw/i386/acpi-common.c | 5 ++---

[PATCH v2 5/8] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-09-08 Thread Bernhard Beschow
Now that TYPE_ACPI_GED_X86 doesn't assign AcpiDeviceIfClass::madt_cpu any more it is the same as TYPE_ACPI_GED. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- include/hw/acpi/generic_event_device.h | 2 -- hw/i386/generic_event_device_x86.c | 27

[PATCH v2 8/8] hw/acpi/core: Trace enable and status registers of GPE separately

2023-09-08 Thread Bernhard Beschow
The bit positions of both registers are related. Tracing the registers independently results in the same offsets across these registers which eases debugging. Signed-off-by: Bernhard Beschow Acked-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- hw/acpi/core.c | 10 +++---

<    1   2   3   4   5   >