Re: [PATCH v3 1/4] migration/qmp: Fix crash on setting tls-authz with null

2023-09-27 Thread Markus Armbruster
Michael Tokarev writes: > 05.09.2023 19:23, Peter Xu: >> QEMU will crash if anyone tries to set tls-authz (which is a type >> StrOrNull) with 'null' value. Fix it in the easy way by converting it to >> qstring just like the other two tls parameters. > > Ping? Has this been forgotten?

Re: [PATCH v7 2/2] tpm: add backend for mssim

2023-09-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Sep 27, 2023 at 12:49:08PM -0400, James Bottomley wrote: >> From: James Bottomley >> >> The Microsoft Simulator (mssim) is the reference emulation platform >> for the TCG TPM 2.0 specification. >> >> https://github.com/Microsoft/ms-tpm-20-ref.git >> >> It

Re: [PATCH] hw/rdma: Deprecate the pvrdma device and the rdma subsystem

2023-09-27 Thread Markus Armbruster
Wrong thread, please ignore.

Re: [PATCH] chardev/char-pty: Avoid losing bytes when the other side just (re-)connected

2023-09-27 Thread Thomas Huth
On 28/08/2023 14.23, Thomas Huth wrote: On 17/08/2023 19.09, Thomas Huth wrote: On 17/08/2023 15.47, Marc-André Lureau wrote: Hi On Thu, Aug 17, 2023 at 5:06 PM Daniel P. Berrangé wrote: On Thu, Aug 17, 2023 at 02:00:26PM +0200, Thomas Huth wrote: On 17/08/2023 12.32, Daniel P. Berrangé

Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-09-27 Thread Thomas Huth
On 27/09/2023 23.47, Fabiano Rosas wrote: Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way harder to figure out what is causing the script to fail, the person

[PATCH v3 1/6] python/machine: move socket setup out of _base_args property

2023-09-27 Thread John Snow
This property isn't meant to do much else besides return a list of strings, so move this setup back out into _pre_launch(). Signed-off-by: John Snow Reviewed-by: Ani Sinha Reviewed-by: Daniel P. Berrangé --- python/qemu/machine/machine.py | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH v3 4/6] python/machine: use socketpair() for console connections

2023-09-27 Thread John Snow
Create a socketpair for the console output. This should help eliminate race conditions around console text early in the boot process that might otherwise have been dropped on the floor before being able to connect to QEMU under "server,nowait". Signed-off-by: John Snow Reviewed-by: Ani Sinha

[PATCH v3 5/6] python/machine: use socketpair() for qtest connection

2023-09-27 Thread John Snow
Like the QMP and console sockets, begin using socketpairs for the qtest connection, too. After this patch, we'll be able to remove the vestigial sock_dir argument, but that cleanup is best done in its own patch. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé ---

[PATCH v3 3/6] python/console_socket: accept existing FD in initializer

2023-09-27 Thread John Snow
Useful if we want to use ConsoleSocket() for a socket created by socketpair(). Signed-off-by: John Snow Reviewed-by: Ani Sinha Reviewed-by: Daniel P. Berrangé --- python/qemu/machine/console_socket.py | 29 +++ 1 file changed, 21 insertions(+), 8 deletions(-) diff

[PATCH v3 2/6] python/machine: close sock_pair in cleanup path

2023-09-27 Thread John Snow
If everything has gone smoothly, we'll already have closed the socket we gave to the child during post_launch. The other half of the pair that we gave to the QMP connection should, likewise, be definitively closed by now. However, in the cleanup path, it's possible we've created the socketpair

[PATCH v3 6/6] python/machine: remove unused sock_dir argument

2023-09-27 Thread John Snow
By using a socketpair for all of the sockets managed by the VM class and its extensions, we don't need the sock_dir argument anymore, so remove it. We only added this argument so that we could specify a second, shorter temporary directory for cases where the temp/log dirs were "too long" as a

[PATCH v3 0/6] python/machine: use socketpair() for console socket

2023-09-27 Thread John Snow
Like we did for the QMP socket, use socketpair() for the console socket so that hopefully there isn't a race condition during early boot where data might get dropped on the floor. May or may not help with various race conditions where early console output is not showing up in the logs and/or

Re: [PATCH v3 1/4] migration/qmp: Fix crash on setting tls-authz with null

2023-09-27 Thread Michael Tokarev
05.09.2023 19:23, Peter Xu: QEMU will crash if anyone tries to set tls-authz (which is a type StrOrNull) with 'null' value. Fix it in the easy way by converting it to qstring just like the other two tls parameters. Ping? Has this been forgotten? Thanks, /mjt Cc: qemu-sta...@nongnu.org #

Re: [PATCH] tests/qtest: Fix npcm7xx_timer-test.c flaky test

2023-09-27 Thread Thomas Huth
On 28/09/2023 05.45, Chris Rauer wrote: Could you please add a proper patch description how this is fixing the issue? Thanks, Thomas Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897 Signed-off-by: Chris Rauer --- tests/qtest/npcm7xx_timer-test.c | 1 + 1 file changed, 1

[PATCH] tests/qtest: Fix npcm7xx_timer-test.c flaky test

2023-09-27 Thread Chris Rauer
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897 Signed-off-by: Chris Rauer --- tests/qtest/npcm7xx_timer-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c index 43711049ca..58f58c2f71 100644 ---

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-09-27 Thread Ani Sinha
> On 27-Sep-2023, at 8:55 PM, Michael S. Tsirkin wrote: > > On Tue, Sep 26, 2023 at 11:22:35AM +0530, Ani Sinha wrote: >> Code changes that addresses all compiler complaints coming from enabling >> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing >> other local

Re: [PATCH 3/3] virtio: call ->vhost_reset_device() during reset

2023-09-27 Thread Raphael Norwitz
> On Sep 27, 2023, at 3:27 PM, Stefan Hajnoczi wrote: > > vhost-user-scsi has a VirtioDeviceClass->reset() function that calls > ->vhost_reset_device(). The other vhost devices don't notify the vhost > device upon reset. > > Stateful vhost devices may need to handle device reset in order to

Re: [PATCH 2/3] vhost-backend: remove vhost_kernel_reset_device()

2023-09-27 Thread Raphael Norwitz
> On Sep 27, 2023, at 3:27 PM, Stefan Hajnoczi wrote: > > vhost_kernel_reset_device() invokes RESET_OWNER, which disassociates the > owner process from the device. The device is left non-operational since > SET_OWNER is only called once during startup in vhost_dev_init(). > >

Re: [PATCH 1/3] vhost-user: do not send RESET_OWNER on device reset

2023-09-27 Thread Raphael Norwitz
> On Sep 27, 2023, at 3:27 PM, Stefan Hajnoczi wrote: > > The VHOST_USER_RESET_OWNER message is deprecated in the spec: > > This is no longer used. Used to be sent to request disabling all > rings, but some back-ends interpreted it to also discard connection > state (this

RE: [PATCH v2 09/12] vfio/ccw: Use vfio_[attach/detach]_device

2023-09-27 Thread Duan, Zhenzhong
Hi Eric, Matthew, >-Original Message- >From: Matthew Rosato >Sent: Wednesday, September 27, 2023 9:26 PM >Subject: Re: [PATCH v2 09/12] vfio/ccw: Use vfio_[attach/detach]_device > >On 9/27/23 8:09 AM, Duan, Zhenzhong wrote: >> >> >>> -Original Message- >>> From: Eric Auger >>>

RE: [PATCH v2 11/12] vfio/common: Introduce two kinds of VFIO device lists

2023-09-27 Thread Duan, Zhenzhong
Hi Eric, >-Original Message- >From: Eric Auger >Sent: Wednesday, September 27, 2023 9:14 PM >Subject: Re: [PATCH v2 11/12] vfio/common: Introduce two kinds of VFIO device >lists > >Hi Zhenzhong, >On 9/26/23 13:32, Zhenzhong Duan wrote: >> In VFIO subsystem, there are different VFIO

Re: [PATCH 1/5] migration: Store downtime timestamps in an array

2023-09-27 Thread Wang, Lei
On 9/27/2023 0:18, Joao Martins wrote: > Right now downtime_start is stored in MigrationState. > > In preparation to having more downtime timestamps during > switchover, move downtime_start to an array namely, @timestamp. > > Add a setter/getter surrounding which timestamps to record, > to make

Re: [PATCH v3 2/7] Update CPUs AML with cpu-(ctrl)dev change

2023-09-27 Thread lixianglai
Hi Michael S. Tsirkin: On Tue, Sep 26, 2023 at 08:49:27PM +0800, lixianglai wrote: Hi Salil Mehta via  And Michael S. Tsirkin: From: Michael S. Tsirkin Sent: Tuesday, September 26, 2023 12:54 PM To: Salil Mehta Cc: xianglai li ; qemu-devel@nongnu.org; Bernhard Beschow ; Salil Mehta ;

Re: [PATCH RFC V2 17/37] arm/virt/acpi: Build CPUs AML with CPU Hotplug support

2023-09-27 Thread Gavin Shan
Hi Salil, On 9/26/23 20:04, Salil Mehta wrote: Support of vCPU Hotplug requires sequence of ACPI handshakes between Qemu and Guest kernel when a vCPU is plugged or unplugged. Most of the AML code to support these handshakes already exists. This AML need to be build during VM init for ARM

Re: [PATCH RFC V2 16/37] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2023-09-27 Thread Gavin Shan
On 9/26/23 20:04, Salil Mehta wrote: CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is based on PCI and is IO port based and hence existing cpus AML code assumes _CRS objects ^^

Re: [PATCH RFC V2 15/37] arm/virt: Create GED dev before *disabled* CPU Objs are destroyed

2023-09-27 Thread Gavin Shan
Hi Salil, On 9/26/23 20:04, Salil Mehta wrote: ACPI CPU hotplug state (is_present=_STA.PRESENT, is_enabled=_STA.ENABLED) for all the possible vCPUs MUST be initialized during machine init. This is done during the creation of the GED device. VMM/Qemu MUST expose/fake the ACPI state of the

Re: [PATCH RFC V2 14/37] arm/virt: Add cpu hotplug events to GED during creation

2023-09-27 Thread Gavin Shan
Hi Salil, On 9/26/23 20:04, Salil Mehta wrote: Add CPU Hotplug event to the set of supported ged-events during the creation of GED device during VM init. Also initialize the memory map for CPU Hotplug ^^ it can be dropped. control device used in event

Re: [PATCH RFC V2 13/37] hw/acpi: Init GED framework with cpu hotplug events

2023-09-27 Thread Gavin Shan
Hi Salil, On 9/26/23 20:04, Salil Mehta wrote: ACPI GED(as described in the ACPI 6.2 spec) can be used to generate ACPI events when OSPM/guest receives an interrupt listed in the _CRS object of GED. OSPM then maps or demultiplexes the event by evaluating _EVT method. This change adds the

Re: [PATCH RFC V2 12/37] hw/acpi: Use qemu_present_cpu() API in ACPI CPU hotplug init

2023-09-27 Thread Gavin Shan
Hi Salil, On 9/26/23 20:04, Salil Mehta wrote: ACPI CPU Hotplug code assumes a virtual CPU is unplugged if the CPUState object is absent in the list of ths possible CPUs(CPUArchIdList *possible_cpus) maintained on per-machine basis. Use the earlier introduced qemu_present_cpu() API to check

Re: [PATCH RFC V2 11/37] hw/acpi: Add ACPI CPU hotplug init stub

2023-09-27 Thread Gavin Shan
On 9/26/23 20:04, Salil Mehta wrote: ACPI CPU hotplug related initialization should only happend if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Signed-off-by: Salil Mehta --- hw/acpi/acpi-cpu-hotplug-stub.c

Re: [PATCH RFC V2 10/37] arm/acpi: Enable ACPI support for vcpu hotplug

2023-09-27 Thread Gavin Shan
Hi Salil, On 9/26/23 20:04, Salil Mehta wrote: ACPI is required to interface QEMU with the guest. Roughly falls into below cases, 1. Convey the possible vcpus config at the machine init time to the guest using various DSDT tables like MADT etc. 2. Convey vcpu hotplug events to guest(using

Re: [PATCH RFC V2 09/37] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2023-09-27 Thread Gavin Shan
On 9/26/23 20:04, Salil Mehta wrote: CPU ctrl-dev MMIO region length could be used in ACPI GED (common ACPI code across architectures) and various other architecture specific places. To make these code places independent of compilation order, ACPI_CPU_HOTPLUG_REG_LEN macro should be moved to a

Re: [PATCH RFC V2 07/37] arm/virt, gicv3: Changes to pre-size GIC with possible vcpus @machine init

2023-09-27 Thread Gavin Shan
Hi Salil, On 9/26/23 20:04, Salil Mehta wrote: GIC needs to be pre-sized with possible vcpus at the initialization time. This is necessary because Memory regions and resources associated with GICC/GICR etc cannot be changed (add/del/modified) after VM has inited. Also, GIC_TYPER needs to be

Re: [PATCH 02/19] hw/cxl/mbox: Split mailbox command payload into separate input and output

2023-09-27 Thread Fan Ni
On Mon, Sep 25, 2023 at 05:11:07PM +0100, Jonathan Cameron wrote: > New CCI types that will be supported shortly do not have a single buffer > used in both directions. As such, split it up. For CXL mailboxes the two > pointers will be aliases of the same memory so all callbacks must allow > for

[PATCH] misc/pca9552: Let external devices set pca9552 inputs

2023-09-27 Thread Glenn Miles
Allow external devices to drive pca9552 input pins by adding input GPIO's to the model. This allows a device to connect its output GPIO's to the pca9552 input GPIO's. In order for an external device to set the state of a pca9552 pin, the pin must first be configured for high impedance (LED is

Re: [PATCH] qtest/migration: Add a test for the analyze-migration script

2023-09-27 Thread Fabiano Rosas
Fabiano Rosas writes: > Add a smoke test that migrates to a file and gives it to the > script. It should catch the most annoying errors such as changes in > the ram flags. > > After code has been merged it becomes way harder to figure out what is > causing the script to fail, the person making

[PATCH] qtest/migration: Add a test for the analyze-migration script

2023-09-27 Thread Fabiano Rosas
Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way harder to figure out what is causing the script to fail, the person making the change is the most likely to

Re: [PATCH v4 1/4] docs/qcow2: add the zoned format feature

2023-09-27 Thread Stefan Hajnoczi
On Mon, Sep 18, 2023 at 05:53:10PM +0800, Sam Li wrote: > Add the specs for the zoned format feature of the qcow2 driver. > The qcow2 file can be taken as zoned device and passed through by > virtio-blk device or NVMe ZNS device to the guest given zoned > information. > > Signed-off-by: Sam Li >

[PATCH] misc/pca9552: Fix inverted input status

2023-09-27 Thread Glenn Miles
The pca9552 INPUT0 and INPUT1 registers are supposed to hold the logical values of the LED pins. A logical 0 should be seen in the INPUT0/1 registers for a pin when its corresponding LSn bits are set to 0, which is also the state needed for turning on an LED in a typical usage scenario. Existing

Re: [Virtio-fs] [PATCH v3 0/5] vhost-user: Back-end state migration

2023-09-27 Thread Stefan Hajnoczi
On Wed, Sep 27, 2023 at 10:32:14AM +0200, Hanna Czenczek wrote: > On 26.09.23 22:10, Stefan Hajnoczi wrote: > > Hi Hanna, > > I was thinking about how this could work without SUSPEND/RESUME. What > > do you think of the following? > > > > 1. The front-end sends VHOST_USER_RESET_DEVICE (or > >

Re: [PATCH 0/8] migration fixes

2023-09-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/19] Misc patches for 2023-09-26

2023-09-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] analyze-migration: ignore RAM_SAVE_FLAG_MULTIFD_FLUSH

2023-09-27 Thread Fabiano Rosas
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Traceback (most recent call last): > File "scripts/analyze-migration.py", line 605, in > dump.read(dump_memory = args.memory) > File "scripts/analyze-migration.py", line 542, in read > section.read() > File

[PATCH 3/3] virtio: call ->vhost_reset_device() during reset

2023-09-27 Thread Stefan Hajnoczi
vhost-user-scsi has a VirtioDeviceClass->reset() function that calls ->vhost_reset_device(). The other vhost devices don't notify the vhost device upon reset. Stateful vhost devices may need to handle device reset in order to free resources or prevent stale device state from interfering after

[PATCH 1/3] vhost-user: do not send RESET_OWNER on device reset

2023-09-27 Thread Stefan Hajnoczi
The VHOST_USER_RESET_OWNER message is deprecated in the spec: This is no longer used. Used to be sent to request disabling all rings, but some back-ends interpreted it to also discard connection state (this interpretation would lead to bugs). It is recommended that back-ends either

[PATCH 2/3] vhost-backend: remove vhost_kernel_reset_device()

2023-09-27 Thread Stefan Hajnoczi
vhost_kernel_reset_device() invokes RESET_OWNER, which disassociates the owner process from the device. The device is left non-operational since SET_OWNER is only called once during startup in vhost_dev_init(). vhost_kernel_reset_device() is never called so this latent bug never appears. Get rid

[PATCH 0/3] vhost: clean up device reset

2023-09-27 Thread Stefan Hajnoczi
Stateful vhost devices may need to free resources or clear device state upon device reset. The vhost-user protocol has a VHOST_USER_RESET_DEVICE message for this and vDPA has SET_STATUS 0, but only QEMU's vhost-user-scsi device actually implements this today. This patch series performs device

Re: [PATCH 01/19] hw/cxl/mbox: Pull the payload out of struct cxl_cmd and make instances constant

2023-09-27 Thread Fan Ni
On Mon, Sep 25, 2023 at 05:11:06PM +0100, Jonathan Cameron wrote: > Putting the pointer in the structure for command handling puts a single > variable element inside an otherwise constant structure. Move it out as > a directly passed variable and take the cxl_cmd structures constant. > >

Re: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-09-27 Thread Fan Ni
On Mon, Sep 25, 2023 at 04:22:58PM +0100, Jonathan Cameron wrote: > Rename the version not burried in the macro to cap_h. The change looks good to me. Just one minor thing. why "version" get involved here? Fan > > Signed-off-by: Jonathan Cameron > --- > > I had another instance of this in a

Re: [PATCH] hw/rdma: Deprecate the pvrdma device and the rdma subsystem

2023-09-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Sep 27, 2023 at 12:49:08PM -0400, James Bottomley wrote: >> From: James Bottomley >> >> The Microsoft Simulator (mssim) is the reference emulation platform >> for the TCG TPM 2.0 specification. >> >> https://github.com/Microsoft/ms-tpm-20-ref.git >> >> It

Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errored

2023-09-27 Thread Markus Armbruster
Eric Blake writes: > On Mon, Sep 18, 2023 at 04:41:40PM +0200, Markus Armbruster wrote: >> All we do with the value of RDMAContext member @error_state is test >> whether it's zero. Change to bool and rename to @errored. >> >> Signed-off-by: Markus Armbruster >> --- >> migration/rdma.c | 66

Re: [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool

2023-09-27 Thread Markus Armbruster
Eric Blake writes: > On Mon, Sep 18, 2023 at 04:41:27PM +0200, Markus Armbruster wrote: >> qemu_rdma_buffer_mergable() is semantically a predicate. It returns >> int 0 or 1. Return bool instead. > > While at it, this would be a perfect time to s/mergable/mergeable/g Will do, thanks!

Re: [PATCH 10/52] migration/rdma: Eliminate error_propagate()

2023-09-27 Thread Markus Armbruster
Eric Blake writes: > On Mon, Sep 18, 2023 at 04:41:24PM +0200, Markus Armbruster wrote: >> When all we do with an Error we receive into a local variable is >> propagating to somewhere else, we can just as well receive it there >> right away. >> >> Signed-off-by: Markus Armbruster >> --- >>

Re: [PATCH 0/8] migration fixes

2023-09-27 Thread Stefan Hajnoczi
On Mon, Sep 18, 2023 at 02:28:14PM -0300, Fabiano Rosas wrote: > This series contains fixes for the two currently know failures that > show up in migration tests plus a set of fixes for some theoretical > race conditions around QEMUFile handling. > > Patch 1 addresses the issue found in the

[PATCH 1/1] linux-user: Add drm ioctls for graphics drivers

2023-09-27 Thread Xiongchuan Tan
This patch adds more drm-related ioctls to support userland OpenGL and Vulkan drivers. Signed-off-by: Xiongchuan Tan --- linux-user/ioctls.h| 26 +++ linux-user/syscall_defs.h | 15 - linux-user/syscall_types.h | 68 ++ 3 files

[PATCH 0/1] linux-user: Add drm ioctls for userland graphics drivers

2023-09-27 Thread Xiongchuan Tan
This patch adds more Direct Rendering Manager ioctls to support userland OpenGL and Vulkan drivers, in addition to existing DRM_IOCTL_VERSION. More device-specific ioctls are needed though, but they share the same range from 0x40 to 0x9f. Adding these would break the current

Re: [PULL 00/21] tricore queue

2023-09-27 Thread Bastian Koppelmann
ailable in the Git repository at: > > https://github.com/bkoppelmann/qemu.git tags/pull-tricore-20230927 > > for you to fetch changes up to 32dd1f0b4bf5f38f37434b0c8fe6c8d86e093b2b: > > target/tricore: Change effective address (ea) to target

Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errored

2023-09-27 Thread Eric Blake
On Mon, Sep 18, 2023 at 04:41:40PM +0200, Markus Armbruster wrote: > All we do with the value of RDMAContext member @error_state is test > whether it's zero. Change to bool and rename to @errored. > > Signed-off-by: Markus Armbruster > --- > migration/rdma.c | 66

Re: [PATCH v7 1/2] tpm: convert tpmdev options processing to new visitor format

2023-09-27 Thread Stefan Berger
On 9/27/23 12:49, James Bottomley wrote: From: James Bottomley Instead of processing the tpmdev options using the old qemu options, convert to the new visitor format which also allows the passing of json on the command line. Signed-off-by: James Bottomley --- v4: add TpmConfiOptions v5:

Re: [PATCH v7 2/2] tpm: add backend for mssim

2023-09-27 Thread Daniel P . Berrangé
On Wed, Sep 27, 2023 at 12:49:08PM -0400, James Bottomley wrote: > From: James Bottomley > > The Microsoft Simulator (mssim) is the reference emulation platform > for the TCG TPM 2.0 specification. > > https://github.com/Microsoft/ms-tpm-20-ref.git > > It exports a fairly simple network socket

[PATCH v7 1/2] tpm: convert tpmdev options processing to new visitor format

2023-09-27 Thread James Bottomley
From: James Bottomley Instead of processing the tpmdev options using the old qemu options, convert to the new visitor format which also allows the passing of json on the command line. Signed-off-by: James Bottomley --- v4: add TpmConfiOptions v5: exit(0) for help v7: adjust line lengths, free

[PATCH v7 2/2] tpm: add backend for mssim

2023-09-27 Thread James Bottomley
From: James Bottomley The Microsoft Simulator (mssim) is the reference emulation platform for the TCG TPM 2.0 specification. https://github.com/Microsoft/ms-tpm-20-ref.git It exports a fairly simple network socket based protocol on two sockets, one for command (default 2321) and one for

[PATCH v7 0/2] tpm: add mssim backend

2023-09-27 Thread James Bottomley
From: James Bottomley The requested feedback was to convert the tpmdev handler to being json based, which requires rethreading all the backends. The good news is this reduced quite a bit of code (especially as I converted it to error_fatal handling as well, which removes the return status

Re: [PATCH v1 0/4] vfio: report NUMA nodes for device memory

2023-09-27 Thread Alex Williamson
On Wed, 27 Sep 2023 15:03:09 + Vikram Sethi wrote: > > From: Alex Williamson > > Sent: Wednesday, September 27, 2023 9:25 AM > > To: Jason Gunthorpe > > Cc: Jonathan Cameron ; Ankit Agrawal > > ; David Hildenbrand ; Cédric Le > > Goater ; shannon.zha...@gmail.com; > >

Re: [PATCH] MAINTAINERS: Add myself as a migration reviewer

2023-09-27 Thread Peter Xu
On Wed, Sep 27, 2023 at 01:11:38PM -0300, Fabiano Rosas wrote: > I've been dedicating time to reviewing migration patches already for a > while. I'll continue to do so for the foreseeable future. > > Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu Thanks! -- Peter Xu

Re: [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool

2023-09-27 Thread Eric Blake
On Mon, Sep 18, 2023 at 04:41:27PM +0200, Markus Armbruster wrote: > qemu_rdma_buffer_mergable() is semantically a predicate. It returns > int 0 or 1. Return bool instead. While at it, this would be a perfect time to s/mergable/mergeable/g > > Signed-off-by: Markus Armbruster > --- >

Re: [PATCH 10/52] migration/rdma: Eliminate error_propagate()

2023-09-27 Thread Eric Blake
On Mon, Sep 18, 2023 at 04:41:24PM +0200, Markus Armbruster wrote: > When all we do with an Error we receive into a local variable is > propagating to somewhere else, we can just as well receive it there > right away. > > Signed-off-by: Markus Armbruster > --- > > ret =

[PATCH] MAINTAINERS: Add myself as a migration reviewer

2023-09-27 Thread Fabiano Rosas
I've been dedicating time to reviewing migration patches already for a while. I'll continue to do so for the foreseeable future. Signed-off-by: Fabiano Rosas --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 355b1960ce..2f2fa60311 100644 ---

Re: [PATCH v7 01/12] nbd/server: Support a request payload

2023-09-27 Thread Eric Blake
On Wed, Sep 27, 2023 at 11:55:41AM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 25.09.23 22:22, Eric Blake wrote: > > Upcoming additions to support NBD 64-bit effect lengths allow for the > > possibility to distinguish between payload length (capped at 32M) and > > effect length (64 bits,

Re: [PATCH] target/arm: Fix CNTPCT_EL0 trapping from EL0 when HCR_EL2.E2H is 0

2023-09-27 Thread Peter Maydell
On Fri, 22 Sept 2023 at 14:21, Michal Orzel wrote: > > On an attempt to access CNTPCT_EL0 from EL0 using a guest running on top > of Xen, a trap from EL2 was observed which is something not reproducible > on HW (also, Xen does not trap accesses to physical counter). > > This is because

Re: [PATCH] virtio: remove unnecessary thread fence while reading next descriptor

2023-09-27 Thread Ilya Maximets
On 9/27/23 17:41, Michael S. Tsirkin wrote: > On Wed, Sep 27, 2023 at 04:06:41PM +0200, Ilya Maximets wrote: >> On 9/25/23 20:04, Ilya Maximets wrote: >>> On 9/25/23 16:32, Stefan Hajnoczi wrote: On Fri, 25 Aug 2023 at 13:02, Ilya Maximets wrote: > > It was supposed to be a compiler

Re: [PATCH] hw/display/ramfb: plug slight guest-triggerable leak on mode setting

2023-09-27 Thread Laszlo Ersek
On 9/19/23 15:19, Laszlo Ersek wrote: > The fw_cfg DMA write callback in ramfb prepares a new display surface in > QEMU; this new surface is put to use ("swapped in") upon the next display > update. At that time, the old surface (if any) is released. > > If the guest triggers the fw_cfg DMA write

Re: [PATCH v1 0/4] vfio: report NUMA nodes for device memory

2023-09-27 Thread Jason Gunthorpe
On Wed, Sep 27, 2023 at 03:03:09PM +, Vikram Sethi wrote: > > From: Alex Williamson > > Sent: Wednesday, September 27, 2023 9:25 AM > > To: Jason Gunthorpe > > Cc: Jonathan Cameron ; Ankit Agrawal > > ; David Hildenbrand ; Cédric Le > > Goater ; shannon.zha...@gmail.com; > >

Re: [PATCH] virtio: remove unnecessary thread fence while reading next descriptor

2023-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2023 at 04:06:41PM +0200, Ilya Maximets wrote: > On 9/25/23 20:04, Ilya Maximets wrote: > > On 9/25/23 16:32, Stefan Hajnoczi wrote: > >> On Fri, 25 Aug 2023 at 13:02, Ilya Maximets wrote: > >>> > >>> It was supposed to be a compiler barrier and it was a compiler barrier > >>>

Re: [PATCH v2 0/2] virtio: clean up of virtqueue_split_read_next_desc()

2023-09-27 Thread Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi On Wed, 27 Sept 2023 at 10:00, Ilya Maximets wrote: > > > Version 2: > - Converted into a patch set adding a new patch that removes the > 'next' argument. [Stefan] > - Completely removing the barrier instead of changing into compiler > barrier.

RE: [PATCH v1 0/4] vfio: report NUMA nodes for device memory

2023-09-27 Thread Vikram Sethi
> From: Alex Williamson > Sent: Wednesday, September 27, 2023 9:25 AM > To: Jason Gunthorpe > Cc: Jonathan Cameron ; Ankit Agrawal > ; David Hildenbrand ; Cédric Le > Goater ; shannon.zha...@gmail.com; > peter.mayd...@linaro.org; a...@anisinha.ca; Aniket Agashe > ; Neo Jia ; Kirti Wankhede > ;

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

2023-09-27 Thread Michael S. Tsirkin
On Tue, Sep 26, 2023 at 11:22:35AM +0530, Ani Sinha wrote: > Code changes that addresses all compiler complaints coming from enabling > -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing > other local variables or parameters. These makes the code confusing and/or > adds

Re: [PATCH v3 1/7] Update ACPI GED framework to support vcpu hot-(un)plug

2023-09-27 Thread Michael S. Tsirkin
On Tue, Sep 26, 2023 at 12:38:44PM +, Salil Mehta wrote: > Hi Michael, > > > From: Michael S. Tsirkin > > Sent: Tuesday, September 26, 2023 1:08 PM > > > > On Tue, Sep 26, 2023 at 07:26:40PM +0800, lixianglai wrote: > > > > > > Hi, Michael S. Tsirkin : > > > > On Tue, Sep 26, 2023 at

Re: [PATCH v3 2/7] Update CPUs AML with cpu-(ctrl)dev change

2023-09-27 Thread Michael S. Tsirkin
On Tue, Sep 26, 2023 at 08:49:27PM +0800, lixianglai wrote: > > Hi Salil Mehta via  And Michael S. Tsirkin: > > > From: Michael S. Tsirkin > > > Sent: Tuesday, September 26, 2023 12:54 PM > > > To: Salil Mehta > > > Cc: xianglai li ; qemu-devel@nongnu.org; Bernhard > > > Beschow ; Salil Mehta ;

Re: [PATCH v3 2/7] Update CPUs AML with cpu-(ctrl)dev change

2023-09-27 Thread Michael S. Tsirkin
On Tue, Sep 26, 2023 at 01:30:30PM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 26, 2023 at 07:54:04AM -0400, Michael S. Tsirkin wrote: > > On Tue, Sep 26, 2023 at 11:45:19AM +, Salil Mehta wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Tuesday, September 26, 2023 12:12 PM > >

Re: migration maintenance, governance [Was: Re: [PATCH V4 0/2] migration file URI]

2023-09-27 Thread Peter Xu
On Wed, Sep 27, 2023 at 03:36:16PM +0100, Daniel P. Berrangé wrote: > Even if not actively sending a PR, a possible starting point that could > be done today, would be for someone to put up a gitlab.com branch that > contains all the outstanding patch series that are considered ready > to merge

[PATCH 2/8] docs/specs/edu: Convert to rST

2023-09-27 Thread Peter Maydell
Convert docs/specs/edu.txt to rST format. Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + docs/specs/{edu.txt => edu.rst} | 84 - docs/specs/index.rst| 1 + 3 files changed, 54 insertions(+), 32 deletions(-) rename

[PATCH 0/8] docs/specs: Convert txt files to rST

2023-09-27 Thread Peter Maydell
This patchseries converts most of the remaining .txt files in docs/specs to rST format and integrates tem with our documentation. (The one remaining .txt file is rocker.txt, which I left to do later because at over 1000 lines it is much bigger than these.) These are mostly simple conversions with

[PATCH 7/8] docs/specs/vmcoreinfo: Convert to rST

2023-09-27 Thread Peter Maydell
Convert docs/specs/vmcoreinfo.txt to rST format. Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + docs/specs/index.rst | 1 + docs/specs/{vmcoreinfo.txt => vmcoreinfo.rst} | 33 ++- 3 files changed, 19

[PATCH 3/8] docs/specs/ivshmem-spec: Convert to rST

2023-09-27 Thread Peter Maydell
Convert docs/specs/ivshmem-spec.txt to rST format. In converting, I have dropped the sections on the device's command line interface and usage, as they are already covered by the user-facing docs in system/devices/ivshmem.rst. I have also removed the reference to Memnic, because the URL is dead

[PATCH 1/8] docs/specs/vmw_pvscsi-spec: Convert to rST

2023-09-27 Thread Peter Maydell
Convert the docs/specs/vmw_pvscsi-spec.txt file to rST format. This conversion includes some minor wordsmithing of the text to fix some grammar nits. Signed-off-by: Peter Maydell --- The number of lines changed for markup formatting was such a large amount of the document that it didn't seem

[PATCH 5/8] docs/specs/standard-vga: Convert to rST

2023-09-27 Thread Peter Maydell
Convert docs/specs/standard-vga.txt to rST format. Signed-off-by: Peter Maydell --- docs/specs/index.rst| 1 + docs/specs/standard-vga.rst | 94 + docs/specs/standard-vga.txt | 81 hw/display/vga-isa.c| 2 +-

[PATCH 8/8] docs/specs/vmgenid: Convert to rST

2023-09-27 Thread Peter Maydell
Convert docs/specs/vmgenid.txt to rST format. Signed-off-by: Peter Maydell --- MAINTAINERS| 2 +- docs/specs/index.rst | 1 + docs/specs/vmgenid.rst | 246 + docs/specs/vmgenid.txt | 245 4 files

[PATCH 6/8] docs/specs/virt-ctlr: Convert to rST

2023-09-27 Thread Peter Maydell
Convert docs/specs/virt-ctlr.txt to rST format. I added the name of the device to give readers a bit more idea of which device we're actually documenting here. Signed-off-by: Peter Maydell --- docs/specs/index.rst| 1 + docs/specs/{virt-ctlr.txt => virt-ctlr.rst} | 12

[PATCH 4/8] docs/specs/pvpanic: Convert to rST

2023-09-27 Thread Peter Maydell
Convert docs/specs/pvpanic.txt to rST format. Signed-off-by: Peter Maydell --- docs/specs/index.rst| 1 + docs/specs/{pvpanic.txt => pvpanic.rst} | 41 - 2 files changed, 28 insertions(+), 14 deletions(-) rename docs/specs/{pvpanic.txt =>

Re: [PATCH v2 2/3] maint: Tweak comments in mailmap regarding SPF

2023-09-27 Thread Peter Maydell
On Wed, 27 Sept 2023 at 15:40, Eric Blake wrote: > > From: Eric Blake > > Documenting that we should not add new lines to work around SPF > rewrites sounds foreboding; the intent is instead that new lines here > are okay, but indicate a second problem elsewhere in our build process > that we

Re: [PATCH v2 2/3] maint: Tweak comments in mailmap regarding SPF

2023-09-27 Thread Eric Blake
On Wed, Sep 27, 2023 at 09:38:18AM -0500, Eric Blake wrote: > From: Eric Blake > > Documenting that we should not add new lines to work around SPF > rewrites sounds foreboding; the intent is instead that new lines here > are okay, but indicate a second problem elsewhere in our build process >

Re: [PATCH v2] virtio: use shadow_avail_idx while checking number of heads

2023-09-27 Thread Stefan Hajnoczi
On Wed, 27 Sept 2023 at 09:52, Ilya Maximets wrote: > > We do not need the most up to date number of heads, we only want to > know if there is at least one. > > Use shadow variable as long as it is not equal to the last available > index checked. This avoids expensive qatomic dereference of the

[PATCH v2 0/3] Another attempt at mailmap patches

2023-09-27 Thread Eric Blake
From: Eric Blake Experimenting yet again, this time with an eye towards letting patchew attribute the patch to my name rather than my email. Also, by sending a series with more than one patch, I'm testing how authorship is preserved. My editor window does not see a body From: line, but

[PATCH v2 1/3] mailmap: Fix Andrey Drobyshev author email

2023-09-27 Thread Eric Blake
From: Andrey Drobyshev This fixes authorship of commits 2848289168, 52b10c9c0c as the mailing list rewrote the "From:" field in the corresponding patches. See commit 3bd2608db7 ("maint: Add .mailmap entries for patches claiming list authorship") for explanation. Signed-off-by: Andrey Drobyshev

[PATCH v2 2/3] maint: Tweak comments in mailmap regarding SPF

2023-09-27 Thread Eric Blake
From: Eric Blake Documenting that we should not add new lines to work around SPF rewrites sounds foreboding; the intent is instead that new lines here are okay, but indicate a second problem elsewhere in our build process that we should also consider fixing at the same time, to keep the section

[PATCH v2 3/3] mailmap: Fix BALATON Zoltan author email

2023-09-27 Thread Eric Blake
From: Eric Blake This fixes authorship of commits 5cbd51a5 and friends, where the qemu-ppc mailing list rewrote the "From:" field in the corresponding patches. See commit 3bd2608db7 ("maint: Add .mailmap entries for patches claiming list authorship") for explanation. Signed-off-by: Eric Blake

Re: migration maintenance, governance [Was: Re: [PATCH V4 0/2] migration file URI]

2023-09-27 Thread Daniel P . Berrangé
On Wed, Sep 27, 2023 at 09:56:44AM -0400, Peter Xu wrote: > Juan will be back next Monday. Before he left, he told me that he's > preparing the pull. > > If next week there's still no pull from migration side then I suppose > someone should start to pick up patches and send PR. I would volunteer

Re: migration maintenance, governance [Was: Re: [PATCH V4 0/2] migration file URI]

2023-09-27 Thread Daniel P . Berrangé
On Wed, Sep 27, 2023 at 03:14:29PM +0200, Claudio Fontana wrote: > On 9/13/23 15:00, Claudio Fontana wrote: > > On 8/30/23 15:09, Claudio Fontana wrote: > >> On 8/22/23 15:25, Philippe Mathieu-Daudé wrote: > >>> Hi Claudio, > >>> > >>> On 22/8/23 14:00, Claudio Fontana wrote: > Hello, >

Re: [PATCH v1 0/4] vfio: report NUMA nodes for device memory

2023-09-27 Thread Alex Williamson
On Wed, 27 Sep 2023 10:53:36 -0300 Jason Gunthorpe wrote: > On Wed, Sep 27, 2023 at 12:33:18PM +0100, Jonathan Cameron wrote: > > > CXL accelerators / GPUs etc are a different question but who has one > > of those anyway? :) > > That's exactly what I mean when I say CXL will need it too. I

  1   2   3   >