Markus Armbruster writes:
> Peter Maydell writes:
>
>> On Fri, 3 Nov 2023 at 07:02, wrote:
>>>
>>> From: Stephen Brennan
>>>
>>> The QMP dump API represents the dump format as an enumeration. Add three
>>> new enumerators, one for each supported kdump compression, each named
>>> "kdump-raw-*".
Markus Armbruster writes:
> Markus Armbruster (2):
> dump: Plug file descriptor leak on non-seekable file
> dump: Fix HMP dump-guest-memory -z without -R
Hi Markus,
I'm a bit late on the uptake here as these are already queued, but thank
you so much for finding and fixing my issues. Sorry
On Tue, Nov 07, 2023 at 10:53:40AM +, Peter Maydell wrote:
> On Tue, 7 Nov 2023 at 03:02, Ethan Chen wrote:
> >
> > On Mon, Nov 06, 2023 at 10:34:41AM +, Peter Maydell wrote:
> > > What AXI bus signals? You already get address and size in the
> > > actual memory transaction, they don't
Hi Matthew,
>-Original Message-
>From: Matthew Rosato
>Sent: Wednesday, November 8, 2023 11:00 AM
>Subject: Re: [PATCH v4 28/41] vfio/iommufd: Implement the iommufd backend
>
>On 11/2/23 3:12 AM, Zhenzhong Duan wrote:
>> From: Yi Liu
>>
>> Add the iommufd backend. The IOMMUFD container
Hi
On Wed, Nov 8, 2023 at 9:37 AM Markus Armbruster wrote:
>
> Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats)
> Fixes: CID 1523842
> Signed-off-by: Markus Armbruster
> ---
> dump/dump.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/dump/dump.c b/dump/dump.c
Kevin Wolf writes:
> Am 02.11.2023 um 13:55 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > The 'name' parameter of QOM setters is primarily used to specify the name
>> > of the currently parsed input element in the visitor interface. For
>> > top-level qdev properties, this
>-Original Message-
>From: Cédric Le Goater
>Sent: Tuesday, November 7, 2023 10:37 PM
>Subject: Re: [PATCH v4 25/41] Add iommufd configure option
>
>On 11/7/23 14:14, Cédric Le Goater wrote:
>> On 11/2/23 08:12, Zhenzhong Duan wrote:
>>> This adds "--enable-iommufd/--disable-iommufd" to
Cédric Le Goater writes:
> On 11/2/23 08:12, Zhenzhong Duan wrote:
>> From: Eric Auger
>> Introduce an iommufd object which allows the interaction
>> with the host /dev/iommu device.
>> The /dev/iommu can have been already pre-opened outside of qemu,
>> in which case the fd can be passed
>-Original Message-
>From: Cédric Le Goater
>Sent: Tuesday, November 7, 2023 9:53 PM
>Subject: Re: [PATCH v4 32/41] vfio/pci: Introduce a vfio pci hot reset
>interface
>
>On 11/2/23 08:12, Zhenzhong Duan wrote:
>> Legacy vfio pci and iommufd cdev have different process to hot reset
>>
>-Original Message-
>From: Cédric Le Goater
>Sent: Tuesday, November 7, 2023 9:41 PM
>Subject: Re: [PATCH v4 28/41] vfio/iommufd: Implement the iommufd backend
>
>On 11/2/23 08:12, Zhenzhong Duan wrote:
>> From: Yi Liu
>>
>> Add the iommufd backend. The IOMMUFD container class is
Peter Maydell writes:
> On Fri, 3 Nov 2023 at 07:02, wrote:
>>
>> From: Stephen Brennan
>>
>> The QMP dump API represents the dump format as an enumeration. Add three
>> new enumerators, one for each supported kdump compression, each named
>> "kdump-raw-*".
>>
>> For the HMP command line,
-z without -R has no effect: the dump format remains @elf. Fix the
logic error so it becomes @kdump-zlib.
Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats)
Fixes: CID 1523841
Signed-off-by: Markus Armbruster
---
dump/dump-hmp-cmds.c | 2 +-
1 file changed, 1 insertion(+),
Markus Armbruster (2):
dump: Plug file descriptor leak on non-seekable file
dump: Fix HMP dump-guest-memory -z without -R
dump/dump-hmp-cmds.c | 2 +-
dump/dump.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.41.0
Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats)
Fixes: CID 1523842
Signed-off-by: Markus Armbruster
---
dump/dump.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/dump/dump.c b/dump/dump.c
index 1c304cadfd..ad5294e853 100644
--- a/dump/dump.c
+++ b/dump/dump.c
@@
>-Original Message-
>From: Cédric Le Goater
>Sent: Tuesday, November 7, 2023 9:44 PM
>Subject: Re: [PATCH v4 41/41] vfio: Compile out iommufd for PPC target
>
>On 11/2/23 08:13, Zhenzhong Duan wrote:
>> Since PPC doesn't support IOMMUFD, make iommufd related code
>> compiled out.
>>
>>
>-Original Message-
>From: Cédric Le Goater
>Sent: Tuesday, November 7, 2023 9:38 PM
>Subject: Re: [PATCH v4 27/41] util/char_dev: Add open_cdev()
>
>On 11/2/23 08:12, Zhenzhong Duan wrote:
>> From: Yi Liu
>>
>> /dev/vfio/devices/vfioX may not exist. In that case it is still possible
>-Original Message-
>From: Cédric Le Goater
>Sent: Tuesday, November 7, 2023 9:33 PM
>Subject: Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object
>
>On 11/2/23 08:12, Zhenzhong Duan wrote:
>> From: Eric Auger
[...]
>> diff --git a/qapi/qom.json b/qapi/qom.json
>> index
On 11/7/23 1:28 PM, Cédric Le Goater wrote:
> On 11/2/23 08:12, Zhenzhong Duan wrote:
>> Hi,
>>
>> Thanks all for giving guides and comments on previous series, here is
>> the v4 of pure iommufd support part.
>>
>> Based on Cédric's suggestion, this series includes an effort to remove
>> spapr
On 11/2/23 3:12 AM, Zhenzhong Duan wrote:
> From: Yi Liu
>
> Add the iommufd backend. The IOMMUFD container class is implemented
> based on the new /dev/iommu user API. This backend obviously depends
> on CONFIG_IOMMUFD.
>
> So far, the iommufd backend doesn't support dirty page sync yet due
>
On Tue, 7 Nov 2023 at 21:52, Kevin Wolf wrote:
>
> The following changes since commit bb541a7068d2eee51a9abbe2dedcdf27298b1872:
>
> Merge tag 'pull-pa-20231106' of https://gitlab.com/rth7680/qemu into
> staging (2023-11-07 15:01:17 +0800)
>
> are available in the Git repository at:
>
>
On Wed, 8 Nov 2023 at 02:47, Kevin Wolf wrote:
>
> The following changes since commit 462ad017ed76889d46696a3581e1b52343f9b683:
>
> Merge tag 'pixman-pull-request' of https://gitlab.com/marcandre.lureau/qemu
> into staging (2023-11-07 19:00:03 +0800)
>
> are available in the Git repository at:
From: Tianrui Zhao
Implement loongarch kvm set vcpu interrupt interface,
when a irq is set in vcpu, we use the KVM_INTERRUPT
ioctl to set intr into kvm.
Signed-off-by: Tianrui Zhao
Signed-off-by: xianglai li
---
target/loongarch/cpu.c | 18 +-
From: Tianrui Zhao
Implement the kvm_arch_init of loongarch, in the function, the
KVM_CAP_MP_STATE cap is checked by kvm ioctl.
Signed-off-by: Tianrui Zhao
Reviewed-by: Richard Henderson
Signed-off-by: xianglai li
---
target/loongarch/kvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git
From: Tianrui Zhao
Implement kvm_arch_handle_exit for loongarch. In this
function, the KVM_EXIT_LOONGARCH_IOCSR is handled,
we read or write the iocsr address space by the addr,
length and is_write argument in kvm_run.
Signed-off-by: Tianrui Zhao
Reviewed-by: Richard Henderson
Signed-off-by:
From: Tianrui Zhao
Add kvm.c and kvm-stub.c into meson.build to compile
it when kvm is configed. Meanwhile in meson.build,
we set the kvm_targets to loongarch64-softmmu when
the cpu is loongarch.
Signed-off-by: Tianrui Zhao
Signed-off-by: xianglai li
---
meson.build | 2 ++
From: Tianrui Zhao
Define some functions in target/loongarch/kvm.c, such as
kvm_arch_put_registers, kvm_arch_get_registers and
kvm_arch_handle_exit, etc. which are needed by kvm/kvm-all.c.
Now the most functions has no content and they will be
implemented in the next patches.
Signed-off-by:
From: Tianrui Zhao
Implement kvm_arch_init_vcpu interface for loongarch,
in this function, we register VM change state handler.
And when VM state changes to running, the counter value
should be put into kvm to keep consistent with kvm,
and when state change to stop, counter value should be
From: Tianrui Zhao
Implement kvm_arch_get/set_registers interfaces, many regs
can be get/set in the function, such as core regs, csr regs,
fpu regs, mp state, etc.
Signed-off-by: Tianrui Zhao
Signed-off-by: xianglai li
---
meson.build | 1 +
target/loongarch/cpu.c
From: zhaotianrui
Update linux KVM headers about LoongArch KVM form linux
kernel. Mainly contains some KVM structures and macro
defines such as LoongArch KVM registers number, LoongArch
fpu structure, exit reason of LoongArch IOCSR, etc.
Signed-off-by: zhaotianrui
Signed-off-by: xianglai li
From: Tianrui Zhao
Supplement vcpu env initial when vcpu reset, including
init vcpu CSR_CPUID,CSR_TID to cpu->cpu_index. The two
regs will be used in kvm_get/set_csr_ioctl.
Signed-off-by: Tianrui Zhao
Signed-off-by: xianglai li
---
target/loongarch/cpu.c | 2 ++
target/loongarch/cpu.h | 2 +-
The LoongArch KVM patch series have been merged in Linux kernel,
so we remove the RFC flag in this patch series.
This series add loongarch kvm support, mainly implement
some interfaces used by kvm such as kvm_arch_get/set_regs,
kvm_arch_handle_exit, kvm_loongarch_set_interrupt, etc.
Currently,
Hi all, appreciate any comments or feedbacks on the patch.
Thanks,
Eiichi
> On Nov 1, 2023, at 23:04, Vitaly Kuznetsov wrote:
>
> Eiichi Tsukata writes:
>
>> FYI: The EINVAL in vmx_set_nested_state() is caused by the following
>> condition:
>> * vcpu->arch.hflags == 0
>> *
On Wed, 8 Nov 2023 at 05:14, Stefano Stabellini wrote:
>
> Minor bug fix for Virtio/Xen support
>
>
> The following changes since commit 462ad017ed76889d46696a3581e1b52343f9b683:
>
> Merge tag 'xen-virtio-fix-1-tag' of
> https://gitlab.com/marcandre.lureau/qemu into staging (2023-11-07
On Tue, Nov 07, 2023 at 07:14:07PM +0100, Kevin Wolf wrote:
> Am 05.10.2023 um 12:04 hat Niklas Cassel geschrieben:
> > From: Niklas Cassel
> >
> > Legacy software contains a standard mechanism for generating a reset to a
> > Serial ATA device - setting the SRST (software reset) bit in the
On Wed, Nov 08, 2023 at 12:30:39AM +0530, ank...@nvidia.com wrote:
> +for (l = gi->nodelist; l; l = l->next) {
> +PCIDeviceHandle dev_handle = {0};
> +PCIDevice *pci_dev = PCI_DEVICE(o);
> +dev_handle.bdf =
On Wed, Nov 08, 2023 at 12:30:39AM +0530, ank...@nvidia.com wrote:
> From: Ankit Agrawal
>
> ACPI spec provides a scheme to associate "Generic Initiators" [1]
> (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> integrated compute or DMA engines GPUs) with Proximity
On Wed, 8 Nov 2023 00:30:39 +0530
wrote:
> From: Ankit Agrawal
>
> ACPI spec provides a scheme to associate "Generic Initiators" [1]
> (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> integrated compute or DMA engines GPUs) with Proximity Domains. This is
>
Remove '=' from 'if CONFIG_XEN_CTRL_INTERFACE_VERSION <= 41500'.
Because xendevicemodel_set_irq_level() was introduced in 4.15 version.
Also, update xendevicemodel_set_irq_level() to return -1 for older versions.
Signed-off-by: Vikram Garhwal
Reviewed-by: Stefano Stabellini
---
Minor bug fix for Virtio/Xen support
The following changes since commit 462ad017ed76889d46696a3581e1b52343f9b683:
Merge tag 'xen-virtio-fix-1-tag' of https://gitlab.com/marcandre.lureau/qemu
into staging (2023-11-07 19:00:03 +0800)
are available in the Git repository at:
Daniel P. Berrangé writes:
> On Tue, Nov 07, 2023 at 07:33:37PM +, Alex Bennée wrote:
>> Daniel P. Berrangé writes:
>>
>> > Fedora is gradually killing off i386 packages in its repos, via a
>> > death-by-1000-cuts process. Thus Debian looks like a better long
>> > term bit for i686 build
From: Glenn Miles
Wires up four I2C controller instances to the powernv10 chip
XSCOM address space.
Each controller instance is wired up to two I2C buses of
its own. No other I2C devices are connected to the buses
at this time.
Signed-off-by: Glenn Miles
Reviewed-by: Cédric Le Goater
From: Juan Quintela
Having two functions with the same name is a bad idea. As spapr only
uses the function locally, made it static.
When you compile with clang, you get this compilation error:
/usr/bin/ld: tests/qtest/libqos/libqos.fa.p/.._libqtest.c.o: in function
`qtest_rtas_call':
From: Cédric Le Goater
Wires up three I2C controller instances to the powernv9 chip
XSCOM address space.
Each controller instance is wired up to a single I2C bus of
its own. No other I2C devices are connected to the buses
at this time.
Signed-off-by: Cédric Le Goater
[milesg: Split wiring
From: Glenn Miles
Power9 is supposed to have 4 PIB-connected I2C engines with the
following number of ports on each engine:
0: 2
1: 13
2: 2
3: 2
Power10 also has 4 engines but has the following number of ports
on each engine:
0: 14
1: 14
2: 2
3: 16
Current
From: BALATON Zoltan
The AmigaOne is a rebranded MAI Teron board that uses U-Boot firmware
with patches to support AmigaOS and is very similar to pegasos2 so can
be easily emulated sharing most code with pegasos2. The reason to
emulate it is that AmigaOS comes in different versions for AmigaOne
From: BALATON Zoltan
The Articia S is a generic chipset supporting several different CPUs
that were among others used on some PPC boards. This is a minimal
emulation of the parts needed for emulating the AmigaOne board.
Signed-off-by: BALATON Zoltan
Tested-by: Rene Engel
Acked-by: Daniel
-20231107
for you to fetch changes up to 5bf4ceec109289356f50f69bf277c99b045182e7:
ppc: qtest already exports qtest_rtas_call() (2023-11-07 15:49:41 -0300)
ppc patch queue for 2023-11-07:
This queue, the last one before the 8.2 feature
From: Saif Abrar
Add new XSCOM registers introduced in PHB5.
Apply bit-masks within xscom-write methods.
Bit-masks specified using PPC_BITMASK macro.
Signed-off-by: Saif Abrar
Reviewed-by: Cédric Le Goater
Reviewed-by: Harsh Prateek Bora
Message-ID:
From: BALATON Zoltan
Add an avocado test for the amigaone board that tests it with the
firmware.
Signed-off-by: BALATON Zoltan
Reviewed-by: Daniel Henrique Barboza
Message-ID:
Signed-off-by: Daniel Henrique Barboza
---
tests/avocado/ppc_amiga.py | 38 ++
From: Cédric Le Goater
The more recent IBM power processors have an embedded I2C
controller that is accessible by software via the XSCOM
address space.
Each instance of the I2C controller is capable of controlling
multiple I2C buses (one at a time). Prior to beginning a
transaction on an I2C
On 7/11/23 20:08, Daniel P. Berrangé wrote:
Effective immediately, the libvirt project has moved its list off
libvir-l...@redhat.com, to de...@lists.libvirt.org
Signed-off-by: Daniel P. Berrangé
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
FYI I already sent this
On Tue, Nov 07, 2023 at 07:33:37PM +, Alex Bennée wrote:
> Daniel P. Berrangé writes:
>
> > Fedora is gradually killing off i386 packages in its repos, via a
> > death-by-1000-cuts process. Thus Debian looks like a better long
> > term bit for i686 build testing. It has the added advantage
Volker Rümelin writes:
> The virtio sound device is currently an unclassified PCI device.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Unclassified device [00ff]:
> Red Hat, Inc. Device [1af4:1059] (rev 01)
> Subsystem: Red Hat, Inc. Device [1af4:1100]
>
> Set the correct
Daniel P. Berrangé writes:
> Fedora is gradually killing off i386 packages in its repos, via a
> death-by-1000-cuts process. Thus Debian looks like a better long
> term bit for i686 build testing. It has the added advantage that
> we can generate it via lcitool too.
>
> Signed-off-by: Daniel P.
I forgot to turn off HTML formatting on my mail,
thats why, sorry.
I also changed the liaf to alcnode if its valid?
Please check your next email from me for the
hopefully fixed patch!
Thanks,
Christopher Lentocha
On 11/7/23 5:19 AM, Philippe Mathieu-Daudé wrote:
> Hi Christopher,
>
> On
Change the ID to be a Realtek ALC885 so that both
Windows 2000 and up (including XP) and macOS
(on a later patch for HDEF ACPI Fixes) support HDA
HDA is supported for ALC885 on macOS AppleHDA.kext
and 2K people can use the following file to get
sound working (MD5sum):
"Michael S. Tsirkin" writes:
> On Tue, Nov 07, 2023 at 06:07:45PM +, Alex Bennée wrote:
>> A lot of our vhost-user stubs are large chunks of boilerplate that do
>> (mostly) the same thing. This series continues the cleanups by
>> splitting the vhost-user-base and vhost-user-generic
On Tue, 7 Nov 2023 at 20:50, Volker Rümelin wrote:
>
> The virtio sound device is currently an unclassified PCI device.
>
> ~> sudo lspci -s '00:02.0' -v -nn | head -n 2
> 00:02.0 Unclassified device [00ff]:
> Red Hat, Inc. Device [1af4:1059] (rev 01)
> Subsystem: Red Hat, Inc. Device
Print a debug message as is done for other unsupported audio formats
to give the user the chance to understand their mistake.
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
audio/wavaudio.c | 4
1 file changed, 4 insertions(+)
diff --git a/audio/wavaudio.c
Effective immediately, the libvirt project has moved its list off
libvir-l...@redhat.com, to de...@lists.libvirt.org
Signed-off-by: Daniel P. Berrangé
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b86ea7f75a..751860e064
The following changes since commit 462ad017ed76889d46696a3581e1b52343f9b683:
Merge tag 'pixman-pull-request' of https://gitlab.com/marcandre.lureau/qemu
into staging (2023-11-07 19:00:03 +0800)
are available in the Git repository at:
https://gitlab.com/berrange/qemu
From: Fabiano Rosas
All callers of qio_net_listener_set_name() already add some sort of
"listen" or "listener" suffix.
For intance, we currently have "migration-socket-listener-listen" and
"vnc-listen-listen" as ioc names.
Signed-off-by: Fabiano Rosas
Signed-off-by: Daniel P. Berrangé
---
From: Markus Armbruster
When qcrypto_builtin_rsa_public_key_parse() is about to fail, but no
error has been set, it makes one up. Actually, there's just one way
to fail without setting an error. Set it there instead.
Same for qcrypto_builtin_rsa_private_key_parse().
Signed-off-by: Markus
From: Zhao Liu
When run this script, there's the error:
python3 scripts/cpu-x86-uarch-abi.py /tmp/qmp
Traceback (most recent call last):
File "/path-to-qemu/qemu/scripts/cpu-x86-uarch-abi.py", line 96, in
cpu = shell.cmd("query-cpu-model-expansion",
TypeError: QEMUMonitorProtocol.cmd()
From: Ankit Agrawal
NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows
partitioning of the GPU device resources (including device memory) into
several (upto 8) isolated instances. Each of the partitioned memory needs
a dedicated NUMA node to operate. The partitions are not
On 7/11/23 19:07, Alex Bennée wrote:
Make it clear the vhost-user-device is intended for expert use only.
Signed-off-by: Alex Bennée
---
v5
- split vhost-user-device out of the table
- sort the table alphabetically
- add sound and scmi devices
v6
- add note re vhost-user-device
v7
From: Ankit Agrawal
ACPI spec provides a scheme to associate "Generic Initiators" [1]
(e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
integrated compute or DMA engines GPUs) with Proximity Domains. This is
achieved using Generic Initiator Affinity Structure in SRAT.
From: Ankit Agrawal
There are upcoming devices which allow CPU to cache coherently access
their memory. It is sensible to expose such memory as NUMA nodes separate
from the sysmem node to the OS. The ACPI spec provides a scheme in SRAT
called Generic Initiator Affinity Structure [1] to allow an
On 7/11/23 19:50, Volker Rümelin wrote:
The virtio sound device is currently an unclassified PCI device.
~> sudo lspci -s '00:02.0' -v -nn | head -n 2
00:02.0 Unclassified device [00ff]:
Red Hat, Inc. Device [1af4:1059] (rev 01)
Subsystem: Red Hat, Inc. Device [1af4:1100]
Set the
On 7/11/23 17:41, Daniel P. Berrangé wrote:
Fedora is gradually killing off i386 packages in its repos, via a
death-by-1000-cuts process. Thus Debian looks like a better long
term bit for i686 build testing. It has the added advantage that
we can generate it via lcitool too.
Signed-off-by:
Queue in ppc-next after amending this in:
$ git diff
diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
index cec01b2c92..f329693c55 100644
--- a/hw/ppc/spapr_rtas.c
+++ b/hw/ppc/spapr_rtas.c
@@ -38,7 +38,6 @@
#include "hw/ppc/spapr.h"
#include "hw/ppc/spapr_vio.h"
-#include
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
On 10/16/23 14:59, Saif Abrar wrote:
Add new XSCOM registers introduced in PHB5.
Apply bit-masks within xscom-write methods.
Bit-masks specified using PPC_BITMASK macro.
Signed-off-by: Saif Abrar
Reviewed-by: Cédric Le Goater
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
On 10/25/23 12:27, Glenn Miles wrote:
Power9 is supposed to have 4 PIB-connected I2C engines with the
following number of ports on each engine:
0: 2
1: 13
2: 2
3: 2
Power10 also has 4 engines but has the
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
On 10/17/23 19:14, Glenn Miles wrote:
Wires up four I2C controller instances to the powernv10 chip
XSCOM address space.
Each controller instance is wired up to two I2C buses of
its own. No other I2C devices are connected to
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
On 10/16/23 19:20, Glenn Miles wrote:
Upstreams the PowerNV I2C controller model originally
authored by Cédric Le Goater with minor changes by
myself to split the actual addition of the model from
wiring it up to a power
Patches 1 and 3 from v7, and 2 from v9, queued in ppc-next.
Thanks,
Daniel
On 10/27/23 08:54, BALATON Zoltan wrote:
Changes in v7:
- Increase default memory size to 512m to match pegasos2 and sam460ex
and it's a better default for AmigaOS
Changes in v6:
- Dropped patch 1, now it's
On 10/27/23 08:54, BALATON Zoltan wrote:
Add an avocado test for the amigaone board that tests it with the
firmware.
Signed-off-by: BALATON Zoltan
---
Reviewed-by: Daniel Henrique Barboza
tests/avocado/ppc_amiga.py | 38 ++
1 file changed, 38
On 10/27/23 08:54, BALATON Zoltan wrote:
The Articia S is a generic chipset supporting several different CPUs
that were among others used on some PPC boards. This is a minimal
emulation of the parts needed for emulating the AmigaOne board.
Signed-off-by: BALATON Zoltan
Tested-by: Rene Engel
On 11/7/23 15:40, BALATON Zoltan wrote:
The AmigaOne is a rebranded MAI Teron board that uses U-Boot firmware
with patches to support AmigaOS and is very similar to pegasos2 so can
be easily emulated sharing most code with pegasos2. The reason to
emulate it is that AmigaOS comes in different
The virtio sound device is currently an unclassified PCI device.
~> sudo lspci -s '00:02.0' -v -nn | head -n 2
00:02.0 Unclassified device [00ff]:
Red Hat, Inc. Device [1af4:1059] (rev 01)
Subsystem: Red Hat, Inc. Device [1af4:1100]
Set the correct PCI class code to change the device to
This updates the qcow2 code to add GRAPH_RDLOCK annotations for all
places that read bs->file.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-22-kw...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/qcow2.h | 48
Almost all functions that access bs->backing already take the graph
lock now. Add locking to the remaining users and finally annotate the
struct field itself as protected by the graph lock.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-18-kw...@redhat.com>
Reviewed-by: Eric Blake
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_chain_contains() need to hold a reader lock for the graph because
it calls bdrv_filter_or_cow_bs(), which accesses bs->file/backing.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-11-kw...@redhat.com>
Reviewed-by:
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_filter_or_cow_bs() need to hold a reader lock for the graph because
it calls bdrv_filter_or_cow_child(), which accesses bs->file/backing.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-7-kw...@redhat.com>
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_skip_implicit_filters() need to hold a reader lock for the graph
because it calls bdrv_filter_child(), which accesses bs->file/backing.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-8-kw...@redhat.com>
Reviewed-by:
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_has_zero_init() need to hold a reader lock for the graph because
it calls bdrv_filter_bs(), which accesses bs->file/backing.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-3-kw...@redhat.com>
Reviewed-by: Eric Blake
From: Niklas Cassel
According to AHCI 1.3.1, 5.3.8.1 RegFIS:Entry, if ERR_STAT is set,
we jump to state ERR:FatalTaskfile, which will raise a TFES IRQ
unconditionally, regardless if the I bit is set in the FIS or not.
Thus, we should never raise a normal IRQ after having sent an error
IRQ.
Almost all functions that access bs->file already take the graph
lock now. Add locking to the remaining users and finally annotate the
struct field itself as protected by the graph lock.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-25-kw...@redhat.com>
Reviewed-by: Eric Blake
bdrv_change_backing_file() is called both inside and outside coroutine
context. This makes it difficult for it to take the graph lock
internally. It also means that driver implementations need to be able to
run outside of coroutines, too. Switch it to the usual model with a
coroutine based
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_skip_filters() need to hold a reader lock for the graph because it
calls bdrv_filter_child(), which accesses bs->file/backing.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-9-kw...@redhat.com>
Reviewed-by: Eric
Instead of taking the writer lock internally, require callers to already
hold it when calling bdrv_replace_node(). Its callers may already want
to hold the graph lock and so wouldn't be able to call functions that
take it internally.
Signed-off-by: Kevin Wolf
Message-ID:
This is either bdrv_co_preadv() or bdrv_co_pwritev() which both need to
have the graph locked. Annotate the function pointer accordingly and add
locking to its callers.
This shouldn't actually have resulted in a bug because the graph lock is
already held by blkverify_co_prwv(), which waits for
This adds GRAPH_RDLOCK to some driver callbacks that are already called
with the graph lock held, and which will need the annotation because
they access bs->file, but don't have it yet.
This also covers a few callbacks that were not marked GRAPH_RDLOCK
before, but where updating BlockDriver is
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_(un)freeze_backing_chain() need to hold a reader lock for the
graph because it calls bdrv_filter_or_cow_child(), which accesses
bs->file/backing.
Use the opportunity to make bdrv_is_backing_chain_frozen() static, it
has no
Most implementations of .bdrv_open first open their file child (which is
an operation that internally takes the write lock and therefore we
shouldn't hold the graph lock while calling it), and afterwards many
operations that require holding the graph lock, e.g. for accessing
bs->file.
This
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_cow_child() need to hold a reader lock for the graph because it
accesses bs->backing.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-13-kw...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
Instead of taking the writer lock internally, require callers to already
hold it when calling bdrv_replace_node_common(). Basically everthing in
the function needs the lock and its callers may already want to hold the
graph lock and so wouldn't be able to call functions that take it
internally.
It's only a single line and has a single caller. Inlining makes things
a bit easier to follow.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-15-kw...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block.c | 14 +-
1 file changed, 1 insertion(+),
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_filter_child() need to hold a reader lock for the graph because it
accesses bs->file/backing.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-12-kw...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
This updates the vhdx code to add GRAPH_RDLOCK annotations for all
places that read bs->file.
Signed-off-by: Kevin Wolf
Message-ID: <20231027155333.420094-23-kw...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/vhdx.h | 9 ++---
block/vhdx-log.c | 40
1 - 100 of 505 matches
Mail list logo
