Re: [PATCH v3 3/8] ppc/pnv: PNV I2C engines assigned incorrect XSCOM addresses

2023-11-17 Thread Cédric Le Goater
Nick, Since I started collecting fixes for 8.2 while you were away, I will finish this cycle with a last PR next week and let you take over 9.0. On 11/14/23 20:56, Glenn Miles wrote: The PNV I2C engines for power9 and power10 were being assigned a base XSCOM address that was off by one I2C

Re: [PATCH v3 4/8] ppc/pnv: Fix PNV I2C invalid status after reset

2023-11-17 Thread Cédric Le Goater
On 11/14/23 20:56, Glenn Miles wrote: The PNV I2C Controller was clearing the status register after a reset without repopulating the "upper threshold for I2C ports", "Command Complete" and the SCL/SDA input level fields. Fixed this for resets caused by a system reset as well as from writing to

Re: [PATCH v3] hw/ide/ahci: fix legacy software reset

2023-11-17 Thread Michael Tokarev
10.11.2023 12:51, Kevin Wolf: Am 08.11.2023 um 23:26 hat Niklas Cassel geschrieben: From: Niklas Cassel Legacy software contains a standard mechanism for generating a reset to a Serial ATA device - setting the SRST (software reset) bit in the Device Control register. ... Fixes: e2a5d9b3d9c3

Re: [PATCH v5 00/31] Unified CPU type check

2023-11-17 Thread Gavin Shan
On 11/17/23 17:34, Philippe Mathieu-Daudé wrote: On 17/11/23 00:26, Gavin Shan wrote: On 11/17/23 02:20, Philippe Mathieu-Daudé wrote: On 16/11/23 14:35, Philippe Mathieu-Daudé wrote: I'm queuing patches 1-3 & 5-23 to my cpus-next tree. No need to repost them, please base them on my tree.

[PATCH] qga/linux: Add new api 'guest-network-get-route'

2023-11-17 Thread Dehan Meng
The Route information of the Linux VM needs to be used by administrators and users when debugging network problems and troubleshooting. Signed-off-by: Dehan Meng --- qga/commands-posix.c | 82 qga/commands-win32.c | 6 qga/qapi-schema.json | 80

Re: [PATCH v3 19/70] i386/tdx: Introduce is_tdx_vm() helper and cache tdx_guest object

2023-11-17 Thread Isaku Yamahata
On Wed, Nov 15, 2023 at 02:14:28AM -0500, Xiaoyao Li wrote: > It will need special handling for TDX VMs all around the QEMU. > Introduce is_tdx_vm() helper to query if it's a TDX VM. > > Cache tdx_guest object thus no need to cast from ms->cgs every time. > > Signed-off-by: Xiaoyao Li >

Re: [PATCH v3 18/70] i386/tdx: Get tdx_capabilities via KVM_TDX_CAPABILITIES

2023-11-17 Thread Isaku Yamahata
On Wed, Nov 15, 2023 at 02:14:27AM -0500, Xiaoyao Li wrote: > KVM provides TDX capabilities via sub command KVM_TDX_CAPABILITIES of > IOCTL(KVM_MEMORY_ENCRYPT_OP). Get the capabilities when initializing > TDX context. It will be used to validate user's setting later. > > Since there is no

Re: [PATCH v3 09/70] physmem: Introduce ram_block_convert_range() for page conversion

2023-11-17 Thread Isaku Yamahata
On Wed, Nov 15, 2023 at 02:14:18AM -0500, Xiaoyao Li wrote: > It's used for discarding opposite memory after memory conversion, for > confidential guest. > > When page is converted from shared to private, the original shared > memory can be discarded via ram_block_discard_range(); > > When

Re: [PATCH v3 05/70] kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot

2023-11-17 Thread Isaku Yamahata
On Wed, Nov 15, 2023 at 02:14:14AM -0500, Xiaoyao Li wrote: > From: Chao Peng > > Switch to KVM_SET_USER_MEMORY_REGION2 when supported by KVM. > > With KVM_SET_USER_MEMORY_REGION2, QEMU can set up memory region that > backend'ed both by hva-based shared memory and guest memfd based private >

Re: [PATCH v3 02/70] RAMBlock: Add support of KVM private guest memfd

2023-11-17 Thread Isaku Yamahata
On Wed, Nov 15, 2023 at 02:14:11AM -0500, Xiaoyao Li wrote: > diff --git a/system/physmem.c b/system/physmem.c > index fc2b0fee0188..0af2213cbd9c 100644 > --- a/system/physmem.c > +++ b/system/physmem.c > @@ -1841,6 +1841,20 @@ static void ram_block_add(RAMBlock *new_block, Error > **errp) >

[PULL 1/2] target/hppa: Fix 64-bit SHRPD instruction

2023-11-17 Thread deller
From: Helge Deller When shifting the two joined 64-bit registers right, shift the upper 64-bit register to the left and the lower 64-bit register to the right before merging them with OR. Signed-off-by: Helge Deller Reviewed-by: Richard Henderson --- target/hppa/translate.c | 4 ++-- 1 file

[PULL 0/2] hppa64 fixes

2023-11-17 Thread deller
From: Helge Deller The following changes since commit 34a5cb6d8434303c170230644b2a7c1d5781d197: Merge tag 'pull-tcg-20231114' of https://gitlab.com/rth7680/qemu into staging (2023-11-15 08:05:25 -0500) are available in the Git repository at: https://github.com/hdeller/qemu-hppa.git

[PULL 2/2] disas/hppa: Show hexcode of instruction along with disassembly

2023-11-17 Thread deller
From: Helge Deller On hppa many instructions can be expressed by different bytecodes. To be able to debug qemu translation bugs it's therefore necessary to see the currently executed byte codes without the need to lookup the sequence without the full executable. With this patch the instruction

Re: [PATCH v2 2/2] disas/hppa: Show hexcode of instruction along with disassembly

2023-11-17 Thread Richard Henderson
On 11/17/23 09:33, Helge Deller wrote: * Richard Henderson : On 11/17/23 02:53, del...@kernel.org wrote: From: Helge Deller On hppa many instructions can be expressed by different bytecodes. To be able to debug qemu translation bugs it's therefore necessary to see the currently executed byte

[PATCH for-8.2] target/arm: Fix SME FMOPA (16-bit), BFMOPA

2023-11-17 Thread Richard Henderson
Perform the loop increment unconditionally, not nested within the predication. Cc: qemu-sta...@nongnu.org Fixes: 3916841ac75 ("target/arm: Implement FMOPA, FMOPS (widening)") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1985 Signed-off-by: Richard Henderson ---

Re: [PATCH v3 1/8] ppc/pnv: Add pca9552 to powernv10 for PCIe hotplug power control

2023-11-17 Thread Miles Glenn
On Fri, 2023-11-17 at 17:04 +0100, Cédric Le Goater wrote: > > Well, I was hoping to sweep the pca9554 model under the PowerNV > > maintainership (like pca9552 is under the BMC aspeed > > maintainership). > > I did update the PowerNV list to include it, but perhaps that was > > presumptuous of me.

[PATCH v3] hw/usb: fix xhci port notify

2023-11-17 Thread Nikita Ostrenkov
>From MCF5253 Reference manual >https://www.nxp.com/docs/en/reference-manual/MCF5253RM.pdf Host mode: Port Change Detect. The controller sets this bit to a one when on any port a Connect Status occurs, a PortEnable/Disable Change occurs, an Over Current Change occurs, or the Force Port Resume

[PATCH v2] hw/usb: fix xhci port notify

2023-11-17 Thread Nikita Ostrenkov
>From MCF5253 Reference manual >https://www.nxp.com/docs/en/reference-manual/MCF5253RM.pdf Host mode: The controller sets this bit to a one when on any port a Connect Status occurs, a PortEnable/Disable Change occurs, an Over Current Change occurs, or the Force Port Resume bit is set as

Re: [PATCH-for-8.2] target/nios2: Deprecate the Nios II architecture

2023-11-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > See commit 9ba1caf510 ("MAINTAINERS: Mark the Nios II CPU as orphan"), > last contribution from Chris was in 2012 [1] and Marek in 2018 [2]. > > [1] > https://lore.kernel.org/qemu-devel/1352607539-10455-2-git-send-email-crwu...@gmail.com/ > [2] >

Re: [PATCH v2 2/2] disas/hppa: Show hexcode of instruction along with disassembly

2023-11-17 Thread Helge Deller
* Richard Henderson : > On 11/17/23 02:53, del...@kernel.org wrote: > > From: Helge Deller > > > > On hppa many instructions can be expressed by different bytecodes. > > To be able to debug qemu translation bugs it's therefore necessary to see > > the > > currently executed byte codes without

Re: [PATCH-for-8.2] target/nios2: Deprecate the Nios II architecture

2023-11-17 Thread Marek Vasut
On 11/17/23 08:02, Philippe Mathieu-Daudé wrote: See commit 9ba1caf510 ("MAINTAINERS: Mark the Nios II CPU as orphan"), last contribution from Chris was in 2012 [1] and Marek in 2018 [2]. [1] https://lore.kernel.org/qemu-devel/1352607539-10455-2-git-send-email-crwu...@gmail.com/ [2]

Re: [PATCH v2 2/2] disas/hppa: Show hexcode of instruction along with disassembly

2023-11-17 Thread Richard Henderson
On 11/17/23 02:53, del...@kernel.org wrote: From: Helge Deller On hppa many instructions can be expressed by different bytecodes. To be able to debug qemu translation bugs it's therefore necessary to see the currently executed byte codes without the need to lookup the sequence without the full

Re: [PATCH v2 1/2] target/hppa: Fix 64-bit SHRPD instruction

2023-11-17 Thread Richard Henderson
On 11/17/23 02:53, del...@kernel.org wrote: From: Helge Deller When shifting the two joined 64-bit registers right, shift the upper 64-bit register to the left and the lower 64-bit register to the right before merging them with OR. Signed-off-by: Helge Deller --- target/hppa/translate.c |

Re: [PATCH v2 17/35] tcg/mips: Support TCG_COND_TST{EQ,NE}

2023-11-17 Thread Richard Henderson
On 11/16/23 23:46, Philippe Mathieu-Daudé wrote: Hi Richard, On 28/10/23 21:45, Richard Henderson wrote: Signed-off-by: Richard Henderson ---   tcg/mips/tcg-target.c.inc | 41 +++   1 file changed, 41 insertions(+) @@ -1053,6 +1071,14 @@ static void

Re: [PATCH-for-8.2] target/nios2: Deprecate the Nios II architecture

2023-11-17 Thread Richard Henderson
On 11/16/23 23:02, Philippe Mathieu-Daudé wrote: See commit 9ba1caf510 ("MAINTAINERS: Mark the Nios II CPU as orphan"), last contribution from Chris was in 2012 [1] and Marek in 2018 [2]. [1] https://lore.kernel.org/qemu-devel/1352607539-10455-2-git-send-email-crwu...@gmail.com/ [2]

Re: [RFC 0/2] vhost-user-test: Add negotiated features check

2023-11-17 Thread Yong Huang
On Fri, Nov 17, 2023 at 6:29 PM Michael S. Tsirkin wrote: > On Thu, Nov 16, 2023 at 09:01:28AM +0800, Yong Huang wrote: > > ping > > Sit tight pls it's only been a couple of days. > But if you want to, address comments by Markus pls. > > I'm happy to do that, of course, and thank you also for

Re: [RFC 1/2] qapi/virtio: introduce the "show-bits" argument for x-query-virtio-status

2023-11-17 Thread Yong Huang
On Thu, Nov 16, 2023 at 10:44 PM Markus Armbruster wrote: > Hyman Huang writes: > > > This patch allows to display feature and status bits in virtio-status. > > > > An optional argument is introduced: show-bits. For example: > > {"execute": "x-query-virtio-status", > > "arguments": {"path": >

Re: [PATCH v3 1/8] ppc/pnv: Add pca9552 to powernv10 for PCIe hotplug power control

2023-11-17 Thread Cédric Le Goater
Well, I was hoping to sweep the pca9554 model under the PowerNV maintainership (like pca9552 is under the BMC aspeed maintainership). I did update the PowerNV list to include it, but perhaps that was presumptuous of me. :-) Well, you are the person who has the most knowledge on both and you

Re: [PULL 0/8] Firmware/edk2 20230918 patches

2023-11-17 Thread Akihiko Odaki
On 2023/11/13 20:09, Gerd Hoffmann wrote: Hi, This apparently broke EDK2 for AArch64. I tried the following command: build/qemu-system-aarch64 -drive file=build/pc-bios/edk2-aarch64-code.fd,format=raw,if=pflash,readonly=on -M virt -cpu max -nographic -cdrom

Re: [PATCH-for-8.2] target/nios2: Deprecate the Nios II architecture

2023-11-17 Thread Sandra Loosemore
On 11/17/23 01:46, Thomas Huth wrote: Being orphan for so long in QEMU, I guess it makes sense to mark it as deprecated here now. We can still reconsider if a new maintainer shows up... Reviewed-by: Thomas Huth I agree, but I'd be surprised if anybody steps forward, since Intel has

Re: [PATCH v6 18/21] vfio: Make VFIOContainerBase poiner parameter const in VFIOIOMMUOps callbacks

2023-11-17 Thread Eric Auger
On 11/14/23 11:09, Zhenzhong Duan wrote: > Some of the callbacks in VFIOIOMMUOps pass VFIOContainerBase poiner, > those callbacks only need read access to the sub object of VFIOContainerBase. > So make VFIOContainerBase, VFIOContainer and VFIOIOMMUFDContainer as const > in these callbacks. > >

Re: [PATCH v6 12/21] vfio/platform: Allow the selection of a given iommu backend

2023-11-17 Thread Eric Auger
Hi Zhenzhong, On 11/14/23 11:09, Zhenzhong Duan wrote: > Now we support two types of iommu backends, let's add the capability > to select one of them. This depends on whether an iommufd object has > been linked with the vfio-platform device: > > If the user wants to use the legacy backend, it

[PATCH for-8.2 3/3] ui/console: fix default VC when there are no display

2023-11-17 Thread marcandre . lureau
From: Marc-André Lureau When display is "none", we may still have remote displays (I think it would be simpler if VNC/Spice were regular display btw). Return the default VC then, and set them up to fix a regression when using remote display and it used the TTY instead. Fixes: commit 1bec1cc0d

[PATCH for-8.2 2/3] ui: use "vc" chardev for dbus, gtk & spice-app

2023-11-17 Thread marcandre . lureau
From: Marc-André Lureau Those display have their own implementation of "vc" chardev, which doesn't use pixman. They also don't implement the width/height/cols/rows options, so qemu_display_get_vc() should return a compatible argument. This patch was meant to be with the pixman series, when the

[PATCH for-8.2 1/3] vl: revert behaviour for -display none

2023-11-17 Thread marcandre . lureau
From: Marc-André Lureau Commit 1bec1cc0d ("ui/console: allow to override the default VC") changed the behaviour of the "-display none" option, so that it now creates a QEMU monitor on the terminal. "-display none" should not be tangled up with whether we create a monitor or a serial terminal; it

[PATCH for-8.2 0/3] UI: fix default VC regressions

2023-11-17 Thread marcandre . lureau
From: Marc-André Lureau Hi, There are a few annoying regressions with the default VCs introduced with the pixman series. The "vl: revert behaviour for -display none" change solves most of the issues. Another one is hit when using remote displays, and VCs are not created as they used to, see:

Re: [PATCH] docs/devel: Add VFIO iommufd backend documentation

2023-11-17 Thread Cédric Le Goater
On 11/17/23 13:58, Cédric Le Goater wrote: On 11/17/23 10:35, Zhenzhong Duan wrote: Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan The content looks good but it lacks formatting. Please try to generate the docs. Please check my vfio-8.2 branch. Thanks, C.

Re: [PATCH v3 0/4] ide: implement simple legacy/native mode switching for PCI IDE controllers

2023-11-17 Thread BALATON Zoltan
On Thu, 16 Nov 2023, BALATON Zoltan wrote: On Thu, 16 Nov 2023, Kevin Wolf wrote: Am 16.11.2023 um 11:33 hat Mark Cave-Ayland geschrieben: This series adds a simple implementation of legacy/native mode switching for PCI IDE controllers and updates the via-ide device to use it. The approach I

[PATCH] vl: add missing display_remote++

2023-11-17 Thread marcandre . lureau
From: Marc-André Lureau We should also consider -display vnc= as setting up a remote display, and not attempt to add another default one. The display_remote++ in qemu_setup_display() isn't necessary at this point, but is there for completeness and further usages of the variable. Signed-off-by:

Re: [PATCH 03/16] hw/uefi: add include/hw/uefi/var-service.h

2023-11-17 Thread Laszlo Ersek
On 11/15/23 16:12, Gerd Hoffmann wrote: > Add state structs and function declarations for the uefi-vars device. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/uefi/var-service.h | 119 ++ > 1 file changed, 119 insertions(+) > create mode 100644

Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object

2023-11-17 Thread Cédric Le Goater
On 11/17/23 14:29, Eric Auger wrote: Hi Cédric, On 11/17/23 12:39, Duan, Zhenzhong wrote: Hi Cédric, -Original Message- From: Cédric Le Goater Sent: Friday, November 17, 2023 7:10 PM Subject: Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object Hello, +int

Re: [PATCH v2] migration: free 'saddr' since be no longer used

2023-11-17 Thread Peter Xu
On Fri, Nov 17, 2023 at 10:51:18AM +0800, Zongmin Zhou wrote: > > As Peter said, putting a comment why we don't use > > qapi_free_SocketAddress() will be a good idea. > > I have put some comments on patch v2 to explain Normally we use "comment" to represent direct comment in the code. You

Re: [PATCH v6 09/21] vfio/iommufd: Enable pci hot reset through iommufd cdev interface

2023-11-17 Thread Eric Auger
On 11/14/23 11:09, Zhenzhong Duan wrote: > Add a new callback iommufd_cdev_pci_hot_reset to do iommufd specific > check and reset operation. nit: Implement the newly introduced pci_hot_reset callback? > > Signed-off-by: Zhenzhong Duan > --- > v6: pci_hot_reset return -errno if fails > >

Re: [PATCH v3 5/5] qom/object: Limit type names to alphanumerical and some few special characters

2023-11-17 Thread Thomas Huth
On 17/11/2023 13.25, Philippe Mathieu-Daudé wrote: On 17/11/23 12:44, Thomas Huth wrote: QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when they are used on the command line for the "-device" option (where the comma is used to separate properties). To

Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object

2023-11-17 Thread Eric Auger
Hi Cédric, On 11/17/23 12:39, Duan, Zhenzhong wrote: > Hi Cédric, > >> -Original Message- >> From: Cédric Le Goater >> Sent: Friday, November 17, 2023 7:10 PM >> Subject: Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object >> >> Hello, >> >>> +int

Re: [PATCH] docs/devel: Add VFIO iommufd backend documentation

2023-11-17 Thread Cédric Le Goater
On 11/17/23 10:35, Zhenzhong Duan wrote: Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan The content looks good but it lacks formatting. Please try to generate the docs. Thanks, C. --- MAINTAINERS| 1 + docs/devel/index-internals.rst | 1 +

Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object

2023-11-17 Thread Cédric Le Goater
On 11/17/23 12:39, Duan, Zhenzhong wrote: Hi Cédric, -Original Message- From: Cédric Le Goater Sent: Friday, November 17, 2023 7:10 PM Subject: Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object Hello, +int iommufd_backend_map_dma(IOMMUFDBackend *be, uint32_t

Re: [PATCH v3 5/5] qom/object: Limit type names to alphanumerical and some few special characters

2023-11-17 Thread Philippe Mathieu-Daudé
On 17/11/23 12:44, Thomas Huth wrote: QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when they are used on the command line for the "-device" option (where the comma is used to separate properties). To avoid that such problematic type names come in again,

[PATCH v3 1/5] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl"

2023-11-17 Thread Thomas Huth
From: Markus Armbruster Fixes: b65b4b7ae3c8 (xlnx-bbram: hw/nvram: Use dot in device type name) Signed-off-by: Markus Armbruster [thuth: Use longhand syntax to avoid problems with the "." in the name] Reviewed-by: Peter Maydell Signed-off-by: Thomas Huth ---

[PATCH v3 3/5] memory: Remove "qemu:" prefix from the "qemu:ram-discard-manager" type name

2023-11-17 Thread Thomas Huth
Type names should not contain special characters like ":". Let's remove the whole prefix here since it does not really seem to be helpful to have such a prefix here. The type name is only used internally for an interface type, so the renaming should not affect the user interface or migration.

[PATCH v3 2/5] hw: Replace anti-social QOM type names (again)

2023-11-17 Thread Thomas Huth
From: Markus Armbruster QOM type names containing ',' result in awful UI. We got rid of them in v6.0.0 (commit e178113ff64 hw: Replace anti-social QOM type names). A few have crept back since: xlnx,cframe-reg xlnx,efuse xlnx,pmc-efuse-cache xlnx,versal-cfu-apb

[PATCH v3 4/5] tests/unit/test-io-task: Rename "qemu:dummy" to avoid colon in the name

2023-11-17 Thread Thomas Huth
Type names should not contain special characters like ":" (so that they are easier to use with QAPI and other parts). We are going to forbid such names in an upcoming patch. Thus let's replace the ":" here with a "-". Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé

[PATCH v3 5/5] qom/object: Limit type names to alphanumerical and some few special characters

2023-11-17 Thread Thomas Huth
QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when they are used on the command line for the "-device" option (where the comma is used to separate properties). To avoid that such problematic type names come in again, let's restrict the set of acceptable

[PATCH v3 0/5] Limit type names to alphanumerical and some few special characters

2023-11-17 Thread Thomas Huth
QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when they are used on the command line for the "-device" option (where the comma is used to separate properties). To avoid that such problematic type names come in again, let's restrict the set of acceptable

RE: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object

2023-11-17 Thread Duan, Zhenzhong
Hi Cédric, >-Original Message- >From: Cédric Le Goater >Sent: Friday, November 17, 2023 7:10 PM >Subject: Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object > >Hello, > >> +int iommufd_backend_map_dma(IOMMUFDBackend *be, uint32_t ioas_id, >hwaddr iova, >> +

Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object

2023-11-17 Thread Cédric Le Goater
Hello, +int iommufd_backend_map_dma(IOMMUFDBackend *be, uint32_t ioas_id, hwaddr iova, +ram_addr_t size, void *vaddr, bool readonly) +{ +int ret, fd = be->fd; +struct iommu_ioas_map map = { +.size = sizeof(map), +.flags =

[PATCH v2 0/2] HPPA64-PATCHES-for-8.2

2023-11-17 Thread deller
From: Helge Deller Two patches which I'd like to get included for 8.2. The SHRPD patch fixes a real translation bug which then allows to boot the 64-bit Linux kernels of the Debian-11 and Debian-12 installation CDs. The second patch adds the instruction byte sequence to the assembly log. This

[PATCH v2 1/2] target/hppa: Fix 64-bit SHRPD instruction

2023-11-17 Thread deller
From: Helge Deller When shifting the two joined 64-bit registers right, shift the upper 64-bit register to the left and the lower 64-bit register to the right before merging them with OR. Signed-off-by: Helge Deller --- target/hppa/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 2/2] disas/hppa: Show hexcode of instruction along with disassembly

2023-11-17 Thread deller
From: Helge Deller On hppa many instructions can be expressed by different bytecodes. To be able to debug qemu translation bugs it's therefore necessary to see the currently executed byte codes without the need to lookup the sequence without the full executable. With this patch the instruction

[PATCH 0/2] HPPA64-PATCHES-for-8.2

2023-11-17 Thread deller
From: Helge Deller Two HPPA64 patches which I'd like to get included for 8.2. The SHRPD patch fixes a real translation bug which then allows to boot the 64-bit Linux kernels of the Debian-11 and Debian-12 installation CDs. The second patch adds the instruction byte sequence to the assembly

[PATCH 2/2] disas/hppa: Show hexcode of instruction along with disassembly

2023-11-17 Thread deller
From: Helge Deller On hppa many instructions can be expressed by different bytecodes. To be able to debug qemu translation bugs it's therefore necessary to see the currently executed byte codes without the need to lookup the sequence without the full executable. With this patch the instruction

[PATCH 1/2] target/hppa: Fix 64-bit SHRPD instruction

2023-11-17 Thread deller
From: Helge Deller When shifting the two joined 64-bit registers right, shift the lower 64-bit register to the left and the higher 64-bit register to the right before merging them with OR. Signed-off-by: Helge Deller --- target/hppa/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2

RE: [PATCH v5 11/11] tests/qtest: Adding PCS Module test to GMAC Qtest

2023-11-17 Thread kft...@nuvoton.com
-Original Message- From: Nabih Estefan Sent: Saturday, October 28, 2023 1:56 AM To: peter.mayd...@linaro.org Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; CS20 KFTing ; wuhao...@google.com; jasonw...@redhat.com; IS20 Avi Fishman ; nabiheste...@google.com; CS20 KWLiu ; IS20 Tomer

Re: [RFC 0/2] vhost-user-test: Add negotiated features check

2023-11-17 Thread Michael S. Tsirkin
On Thu, Nov 16, 2023 at 09:01:28AM +0800, Yong Huang wrote: > ping Sit tight pls it's only been a couple of days. But if you want to, address comments by Markus pls.

Re: [PATCH for-8.2] Revert "ui/console: allow to override the default VC"

2023-11-17 Thread Marc-André Lureau
Hi On Thu, Nov 16, 2023 at 10:25 PM Peter Maydell wrote: > > This reverts commit 1bec1cc0da497e55c16e2a7b50f94cdb2a02197f. This > commit changed the behaviour of the "-display none" option, so that > it now creates a QEMU monitor on the terminal. "-display none" > should not be tangled up with

Re: [PATCH] riscv: Fix SiFive E CLINT clock frequency

2023-11-17 Thread Daniel Henrique Barboza
On 11/17/23 05:28, Román Cárdenas wrote: If you check the manual of SiFive E310 (https://cdn.sparkfun.com/assets/7/f/0/2/7/fe310-g002-manual-v19p05.pdf), you can see in Figure 1 that the CLINT is connected to the real time clock, which also feeds the AON peripheral (they share the same

[PULL 0/7] Error reporting patches for 2023-11-17

2023-11-17 Thread Markus Armbruster
The following changes since commit 34a5cb6d8434303c170230644b2a7c1d5781d197: Merge tag 'pull-tcg-20231114' of https://gitlab.com/rth7680/qemu into staging (2023-11-15 08:05:25 -0500) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-error-2023-11-17 for

[PULL 1/7] spapr/pci: Correct "does not support hotplugging error messages

2023-11-17 Thread Markus Armbruster
When dynamic-reconfiguration is off, hot plug / unplug can fail with "Bus 'spapr-pci-host-bridge' does not support hotplugging". spapr-pci-host-bridge is a device, not a bus. Report the name of the bus it provides instead: 'pci.0'. Signed-off-by: Markus Armbruster Message-ID:

[PULL 7/7] target/i386/cpu: Improve error message for property "vendor"

2023-11-17 Thread Markus Armbruster
Improve $ qemu-system-x86_64 -device max-x86_64-cpu,vendor=me qemu-system-x86_64: -device max-x86_64-cpu,vendor=me: Property '.vendor' doesn't take value 'me' to qemu-system-x86_64: -device max-x86_64-cpu,vendor=0123456789abc: value of property 'vendor' must consist of exactly 12

[PULL 2/7] hmp: Improve sync-profile error message

2023-11-17 Thread Markus Armbruster
Improve (qemu) sync-profile of Error: Invalid parameter 'of' to Error: invalid parameter 'of', expecting 'on', 'off', or 'reset' Signed-off-by: Markus Armbruster Message-ID: <2023103059.3407803-3-arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David

[PULL 3/7] qga: Improve guest-exec-status error message

2023-11-17 Thread Markus Armbruster
When the PID passed to guest-exec-status does not exist, we report "Invalid parameter 'pid'" Improve this to "PID 1234 does not exist" Signed-off-by: Markus Armbruster Message-ID: <2023103059.3407803-4-arm...@redhat.com> Reviewed-by: Konstantin Kostiuk Reviewed-by: Philippe

[PULL 5/7] net: Fix a misleading error message

2023-11-17 Thread Markus Armbruster
The error message $ qemu-system-x86_64 -netdev user,id=net0,ipv6-net=fec0::0/ qemu-system-x86_64: -netdev user,id=net0,ipv6-net=fec0::0/: Parameter 'ipv6-prefixlen' expects a number points to ipv6-prefixlen instead of ipv6-net. Fix: qemu-system-x86_64: -netdev

[PULL 4/7] ui/qmp-cmds: Improve two error messages

2023-11-17 Thread Markus Armbruster
set_password with "protocol": "vnc" supports only "connected": "keep". Any other value is rejected with Invalid parameter 'connected' Improve this to parameter 'connected' must be 'keep' when 'protocol' is 'vnc' client_migrate_info requires "port" or "tls-port". When both are missing,

[PULL 6/7] balloon: Fix a misleading error message

2023-11-17 Thread Markus Armbruster
The error message {"execute": "balloon", "arguments":{"value": -1}} {"error": {"class": "GenericError", "desc": "Parameter 'target' expects a size"}} points to 'target' instead of 'value'. Fix: {"error": {"class": "GenericError", "desc": "Parameter 'value' expects a size"}} Root

[PATCH] docs/devel: Add VFIO iommufd backend documentation

2023-11-17 Thread Zhenzhong Duan
Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan --- MAINTAINERS| 1 + docs/devel/index-internals.rst | 1 + docs/devel/vfio-iommufd.rst| 115 + 3 files changed, 117 insertions(+) create mode 100644

RE: [PATCH v5 10/11] hw/net: GMAC Tx Implementation

2023-11-17 Thread kft...@nuvoton.com
-Original Message- From: Nabih Estefan Sent: Saturday, October 28, 2023 1:56 AM To: peter.mayd...@linaro.org Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; CS20 KFTing ; wuhao...@google.com; jasonw...@redhat.com; IS20 Avi Fishman ; nabiheste...@google.com; CS20 KWLiu ; IS20 Tomer

Re: [PATCH 0/7] Miscellaneous error message improvements

2023-11-17 Thread Markus Armbruster
Queued.

RE: [PATCH v5 09/11] hw/net: GMAC Rx Implementation

2023-11-17 Thread kft...@nuvoton.com
-Original Message- From: Nabih Estefan Sent: Saturday, October 28, 2023 1:56 AM To: peter.mayd...@linaro.org Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; CS20 KFTing ; wuhao...@google.com; jasonw...@redhat.com; IS20 Avi Fishman ; nabiheste...@google.com; CS20 KWLiu ; IS20 Tomer

Re: QEMU snapshotting

2023-11-17 Thread Alexander Bulekov
On 231115 1522, Brian Cain wrote: > Alexander, Bandan, Paolo, Stefan, Manuel, > > Hi, I'm Brian and I maintain the Hexagon arch for QEMU. Elia, a security > researcher at Qualcomm is exploring ways to fuzz some hexagon OS kernel with > QEMU and in particular leveraging snapshotting, inspired

Re: [PATCH-for-8.2] target/nios2: Deprecate the Nios II architecture

2023-11-17 Thread Thomas Huth
On 17/11/2023 08.02, Philippe Mathieu-Daudé wrote: See commit 9ba1caf510 ("MAINTAINERS: Mark the Nios II CPU as orphan"), last contribution from Chris was in 2012 [1] and Marek in 2018 [2]. [1] https://lore.kernel.org/qemu-devel/1352607539-10455-2-git-send-email-crwu...@gmail.com/ [2]

Re: [PATCH v2] system/memory: use ldn_he_p/stn_he_p

2023-11-17 Thread David Hildenbrand
On 16.11.23 17:36, Patrick Venture wrote: Using direct pointer dereferencing can allow for unaligned accesses, which was seen during execution with sanitizers enabled. Reviewed-by: Chris Rauer Reviewed-by: Peter Foley Signed-off-by: Patrick Venture Cc: qemu-sta...@nongnu.org Reviewed-by:

[PATCH] riscv: Fix SiFive E CLINT clock frequency

2023-11-17 Thread Román Cárdenas
If you check the manual of SiFive E310 (https://cdn.sparkfun.com/assets/7/f/0/2/7/fe310-g002-manual-v19p05.pdf), you can see in Figure 1 that the CLINT is connected to the real time clock, which also feeds the AON peripheral (they share the same clock). In page 43, the docs also say that the

[PATCH] hw/usb: fix xhci port notify

2023-11-17 Thread Nikita Ostrenkov
>From MCF5253 Reference manual >https://www.nxp.com/docs/en/reference-manual/MCF5253RM.pdf Host mode: The controller sets this bit to a one when on any port a Connect Status occurs, a PortEnable/Disable Change occurs, an Over Current Change occurs, or the Force Port Resume bit is set as

Re: [PATCH v2] system/memory: use ldn_he_p/stn_he_p

2023-11-17 Thread Philippe Mathieu-Daudé
On 16/11/23 17:36, Patrick Venture wrote: Using direct pointer dereferencing can allow for unaligned accesses, which was seen during execution with sanitizers enabled. Reviewed-by: Chris Rauer Reviewed-by: Peter Foley Signed-off-by: Patrick Venture Cc: qemu-sta...@nongnu.org --- v2: changed