Re: [PATCH 00/10] usb cleanups: remove usb_bus_find(), extract sysbus-ohci to a separate file

2024-02-25 Thread Philippe Mathieu-Daudé
On 23/2/24 13:43, Paolo Bonzini wrote: Paolo Bonzini (10): acpi, qom: move object_resolve_type_unambiguous to core QOM ppc: sam460ex: do not use usb_bus_find() sh4: r2d: do not use usb_bus_find() mips/loongson3_virt: do not require CONFIG_USB hppa: do not require CONFIG_USB

Re: [PATCH 5/6] tests/qtest: Reorganize common code in ivshmem-test

2024-02-25 Thread Thomas Huth
On 22/02/2024 23.22, Gustavo Romero wrote: This commit reorganizes the ivshmem-test qtest by moving common structs, functions, and code that can be utilized by other ivshmem qtests into two new files: ivshmem-utils.h and ivshmem-utils.c. Enum Reg, struct ServerThread, and mktempshm() have been

Re: [PATCH v4 21/34] migration/multifd: Add incoming QIOChannelFile support

2024-02-25 Thread Peter Xu
On Mon, Feb 26, 2024 at 03:34:26PM +0800, Peter Xu wrote: > On Tue, Feb 20, 2024 at 07:41:25PM -0300, Fabiano Rosas wrote: > > On the receiving side we don't need to differentiate between main > > channel and threads, so whichever channel is defined first gets to be > > the main one. And since

Re: [PATCH v2 3/7] target/i386: introduce function to query MMU indices

2024-02-25 Thread Zhao Liu
On Fri, Feb 23, 2024 at 02:09:44PM +0100, Paolo Bonzini wrote: > Date: Fri, 23 Feb 2024 14:09:44 +0100 > From: Paolo Bonzini > Subject: [PATCH v2 3/7] target/i386: introduce function to query MMU indices > X-Mailer: git-send-email 2.43.0 > > Remove knowledge of specific MMU indexes (other than

Re: [PATCH v2 1/7] target/i386: mask high bits of CR3 in 32-bit mode

2024-02-25 Thread Zhao Liu
On Fri, Feb 23, 2024 at 02:09:42PM +0100, Paolo Bonzini wrote: > Date: Fri, 23 Feb 2024 14:09:42 +0100 > From: Paolo Bonzini > Subject: [PATCH v2 1/7] target/i386: mask high bits of CR3 in 32-bit mode > X-Mailer: git-send-email 2.43.0 > > CR3 bits 63:32 are ignored in 32-bit mode (either legacy

Re: [PATCH v4 22/34] migration/multifd: Prepare multifd sync for fixed-ram migration

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:26PM -0300, Fabiano Rosas wrote: > The fixed-ram migration can be performed live or non-live, but it is > always asynchronous, i.e. the source machine and the destination > machine are not migrating at the same time. We only need some pieces > of the multifd sync

Re: [PATCH] migration: Free argv

2024-02-25 Thread Akihiko Odaki
On 2024/02/26 12:49, Peter Xu wrote: On Sun, Feb 25, 2024 at 02:54:01PM +0900, Akihiko Odaki wrote: exec_start_outgoing_migration() and exec_start_incoming_migration() leak argv because it uses g_steal_pointer() is used to pass argv qio_channel_command_new_spawn() while it does not free argv

Re: [RFC PATCH] target/ppc/mmu: Silent maybe-uninitialized error in ppc_hash64_xlate()

2024-02-25 Thread Thomas Huth
On 23/02/2024 09.32, Philippe Mathieu-Daudé wrote: Initialize apshift to avoid a maybe-uninitialized error: C compiler for the host machine: cc -m64 -mbig-endian (gcc 13.2.0 "cc (Debian 13.2.0-10) 13.2.0") C linker for the host machine: cc -m64 -mbig-endian ld.bfd 2.41.90.20240115

Re: [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find()

2024-02-25 Thread Markus Armbruster
Paolo Bonzini writes: > usb_bus_find() is always used with argument -1; it can be replaced with > a search of the single USB bus on the machine. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Paolo Bonzini > --- > hw/ppc/sam460ex.c | 6 -- > 1 file changed, 4 insertions(+), 2

Re: [PATCH 04/10] mips/loongson3_virt: do not require CONFIG_USB

2024-02-25 Thread Markus Armbruster
Paolo Bonzini writes: > Once the Kconfig for hw/mips is cleaned up, it will be possible to build a > binary that does not include any USB host controller and therefore that > does not include the code guarded by CONFIG_USB. While the simpler > creation functions such as usb_create_simple can be

Re: [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find()

2024-02-25 Thread Markus Armbruster
Please ignore this one; I replied to the wrong patch by accident.

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-25 Thread Markus Armbruster
BALATON Zoltan writes: > On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: >> Rename "internal.h" as "ide_internal.h", and include > > Is there a convention about using underscore or dash in file names? The > headers Thomas added are using - as well as ahci-allwinner.c, only > ahci_internal.h

Re: [PATCH V1] migration: export fewer options

2024-02-25 Thread Markus Armbruster
Steve Sistare writes: > A small number of migration options are accessed by migration clients, > but to see them clients must include all of options.h, which is mostly > for migration core code. migrate_mode() in particular will be needed by > multiple clients. > > Refactor the option

Re: [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find()

2024-02-25 Thread Markus Armbruster
Paolo Bonzini writes: > Once the Kconfig for hw/mips is cleaned up, it will be possible to build a > binary that does not include any USB host controller and therefore that > does not include the code guarded by CONFIG_USB. While the simpler > creation functions such as usb_create_simple can be

Re: [PATCH] hw/rtc/sun4v-rtc: Relicense to GPLv2-or-later

2024-02-25 Thread Markus Armbruster
Peter Maydell writes: > The sun4v RTC device model added under commit a0e893039cf2ce0 in 2016 > was unfortunately added with a license of GPL-v3-or-later, which is > not compatible with other QEMU code which has a GPL-v2-only license. > > Relicense the code in the .c and the .h file to

RE: [PATCH rfcv2 14/18] intel_iommu: Add a framework to check and sync host IOMMU cap/ecap

2024-02-25 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: Re: [PATCH rfcv2 14/18] intel_iommu: Add a framework to check >and sync host IOMMU cap/ecap > > > >On 2/1/24 08:28, Zhenzhong Duan wrote: >> From: Yi Liu >> >> Add a framework to check and synchronize host IOMMU cap/ecap with >> vIOMMU

Re: [PATCH 4/4] replay: simple auto-snapshot mode for record

2024-02-25 Thread Nicholas Piggin
On Fri Aug 18, 2023 at 2:36 PM AEST, Pavel Dovgalyuk wrote: > On 14.08.2023 19:31, Nicholas Piggin wrote: > > record makes an initial snapshot when the machine is created, to enable > > reverse-debugging. Often the issue being debugged appears near the end of > > the trace, so it is important for

Re: [PATCH v4 21/34] migration/multifd: Add incoming QIOChannelFile support

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:25PM -0300, Fabiano Rosas wrote: > On the receiving side we don't need to differentiate between main > channel and threads, so whichever channel is defined first gets to be > the main one. And since there are no packets, use the atomic channel > count to index into

Re: [PATCH v2 20/27] plugins: create CPUPluginState and migrate plugin_mask

2024-02-25 Thread Pierrick Bouvier
On 2/23/24 8:21 PM, Alex Bennée wrote: We are going to want to keep track of some per-vCPU data for plugins and the logical place to do so is in track it in CPUState. For now this just moves the plugin_mask (renamed to event_mask) as the memory callbacks are accessed directly by TCG generated

Re: [PATCH v2 24/27] contrib/plugins: extend execlog to track register changes

2024-02-25 Thread Pierrick Bouvier
On 2/23/24 8:21 PM, Alex Bennée wrote: With the new plugin register API we can now track changes to register values. Currently the implementation is fairly dumb which will slow down if a large number of register values are being tracked. This could be improved by only instrumenting instructions

RE: [PATCH RFCv2 1/8] backends/iommufd: Introduce helper function iommufd_device_get_hw_capabilities()

2024-02-25 Thread Duan, Zhenzhong
Hi Joao, >-Original Message- >From: Joao Martins >Subject: [PATCH RFCv2 1/8] backends/iommufd: Introduce helper function >iommufd_device_get_hw_capabilities() > >The new helper will fetch vendor agnostic IOMMU capabilities supported >both by hardware and software. Right now it is only

Re: [PATCH v2 1/2] system/memory.c: support unaligned access

2024-02-25 Thread Tomoyuki Hirose
Hello, I would be happy if you could give me some comments. ping. On Thu, Feb 1, 2024 at 5:14 PM Tomoyuki HIROSE wrote: > > The previous code ignored 'impl.unaligned' and handled unaligned accesses > as is. But this implementation cannot emulate specific registers of some > devices that allow

RE: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

2024-02-25 Thread 張哲嘉
Hi Alistair, > -Original Message- > From: Alistair Francis > Sent: Monday, February 26, 2024 2:45 PM > To: Alvin Che-Chia Chang(張哲嘉) > Cc: qemu-ri...@nongnu.org; qemu-devel@nongnu.org; > alistair.fran...@wdc.com; bin.m...@windriver.com; liwei1...@gmail.com; > dbarb...@ventanamicro.com;

Re: [PATCH v4 20/34] migration/multifd: Add outgoing QIOChannelFile support

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:24PM -0300, Fabiano Rosas wrote: > +int file_send_channel_destroy(QIOChannel *ioc) > +{ > +if (ioc) { > +qio_channel_close(ioc, NULL); > +} > +g_free(outgoing_args.fname); > +outgoing_args.fname = NULL; Ah another thing: we may want to have

Re: [PATCH v2 1/7] migration/multifd: Add new migration option zero-page-detection.

2024-02-25 Thread Wang, Lei
On 2/17/2024 6:39, Hao Xiang wrote: > This new parameter controls where the zero page checking is running. > 1. If this parameter is set to 'legacy', zero page checking is > done in the migration main thread. > 2. If this parameter is set to 'none', zero page checking is disabled. > >

[Bug 2055003] Re: Qemu cmdline core dumped with more(8193 or more) cpus

2024-02-25 Thread Frank Heimes
** Also affects: qemu Importance: Undecided Status: New ** No longer affects: qemu ** Also affects: ubuntu-power-systems Importance: Undecided Status: New ** Changed in: ubuntu-power-systems Assignee: (unassigned) => Ubuntu on IBM Power Systems Bug Triage

Re: support on risc-v 128bits

2024-02-25 Thread Philippe Mathieu-Daudé
On 26/2/24 00:57, Alistair Francis wrote: On Mon, Feb 26, 2024 at 9:30 AM Jean-Christophe Énée wrote: hi, i would like developpe my OS on risc-v 128 bits. after search the support isn´t fully operational We have some basic 128-bit support, but it isn't complete. The RISC-V spec states: ```

Re: [PATCH 09/10] usb: extract sysbus-ohci to a separate file

2024-02-25 Thread Thomas Huth
On 23/02/2024 13.44, Paolo Bonzini wrote: Split the sysbus version to a separate file so that it is not included in PCI-only machines, and adjust Kconfig for machines that do need sysbus-ohci. The copyrights are based on the time and employer of balrog and Paul Brook's contributions. While

Re: [PATCH v4 20/34] migration/multifd: Add outgoing QIOChannelFile support

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:24PM -0300, Fabiano Rosas wrote: > Allow multifd to open file-backed channels. This will be used when > enabling the fixed-ram migration stream format which expects a > seekable transport. > > The QIOChannel read and write methods will use the preadv/pwritev >

[PATCH v3 0/4] RISC-V: Modularize common match conditions for trigger

2024-02-25 Thread Alvin Chang via
According to latest RISC-V Debug specification version 1.0 [1], the enabled privilege levels of the trigger is common match conditions for all the types of the trigger. This series modularize the code for checking the privilege levels of type 2/3/6 triggers by implementing functions

[PATCH v3 2/4] target/riscv: Apply modularized matching conditions for breakpoint

2024-02-25 Thread Alvin Chang via
We have implemented trigger_common_match(), which checks if the enabled privilege levels of the trigger match CPU's current privilege level. Remove the related code in riscv_cpu_debug_check_breakpoint() and invoke trigger_common_match() to check the privilege levels of the type 2 and type 6

[PATCH v3 4/4] target/riscv: Apply modularized matching conditions for icount trigger

2024-02-25 Thread Alvin Chang via
We have implemented trigger_common_match(), which checks if the enabled privilege levels of the trigger match CPU's current privilege level. We can invoke trigger_common_match() to check the privilege levels of the type 3 triggers. Signed-off-by: Alvin Chang --- target/riscv/debug.c | 2 +- 1

[PATCH v3 3/4] target/riscv: Apply modularized matching conditions for watchpoint

2024-02-25 Thread Alvin Chang via
We have implemented trigger_common_match(), which checks if the enabled privilege levels of the trigger match CPU's current privilege level. Remove the related code in riscv_cpu_debug_check_watchpoint() and invoke trigger_common_match() to check the privilege levels of the type 2 and type 6

[PATCH v3 1/4] target/riscv: Add functions for common matching conditions of trigger

2024-02-25 Thread Alvin Chang via
According to RISC-V Debug specification version 1.0 [1], there are several common matching conditions before firing a trigger, including the enabled privilege levels of the trigger. This commit adds trigger_common_match() to prepare the common matching conditions for the type 2/3/6 triggers. For

Re: [PATCH 04/10] mips/loongson3_virt: do not require CONFIG_USB

2024-02-25 Thread Thomas Huth
On 23/02/2024 13.44, Paolo Bonzini wrote: Once the Kconfig for hw/mips is cleaned up, it will be possible to build a binary that does not include any USB host controller and therefore that does not include the code guarded by CONFIG_USB. While the simpler creation functions such as

Re: [PATCH 03/10] sh4: r2d: do not use usb_bus_find()

2024-02-25 Thread Thomas Huth
On 23/02/2024 13.43, Paolo Bonzini wrote: usb_bus_find() is always used with argument -1; it can be replaced with a search of the single USB bus on the machine. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- hw/sh4/r2d.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find()

2024-02-25 Thread Thomas Huth
On 23/02/2024 13.43, Paolo Bonzini wrote: usb_bus_find() is always used with argument -1; it can be replaced with a search of the single USB bus on the machine. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- hw/ppc/sam460ex.c | 6 -- 1 file changed, 4

Re: [PATCH 01/10] acpi, qom: move object_resolve_type_unambiguous to core QOM

2024-02-25 Thread Thomas Huth
On 23/02/2024 13.43, Paolo Bonzini wrote: object_resolve_type_unambiguous provides a useful functionality, that is currently emulated for example by usb_bus_find(). Move it to core code and add error reporting for increased generality. Signed-off-by: Paolo Bonzini --- include/qom/object.h |

Re: [RFC PATCH v3 06/21] target/arm: Add support for Non-maskable Interrupt

2024-02-25 Thread Jinjie Ruan via
On 2024/2/24 3:55, Richard Henderson wrote: > On 2/23/24 00:32, Jinjie Ruan via wrote: >> This only implements the external delivery method via the GICv3. >> >> Signed-off-by: Jinjie Ruan >> --- >> v3: >> - Not include CPU_INTERRUPT_NMI when FEAT_NMI not enabled >> - Add ARM_CPU_VNMI. >> -

Re: [PATCH v4 19/34] migration/multifd: Allow receiving pages without packets

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:23PM -0300, Fabiano Rosas wrote: > Currently multifd does not need to have knowledge of pages on the > receiving side because all the information needed is within the > packets that come in the stream. > > We're about to add support to fixed-ram migration, which

RE: [PATCH rfcv2 07/18] vfio/container: Implement host_iommu_device_init callback in legacy mode

2024-02-25 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: Re: [PATCH rfcv2 07/18] vfio/container: Implement >host_iommu_device_init callback in legacy mode > >Hi Zhenzhong, >On 2/1/24 08:28, Zhenzhong Duan wrote: >> This callback will be used to initialize base and public elements >> in

Re: [PATCH 05/10] hppa: do not require CONFIG_USB

2024-02-25 Thread Thomas Huth
On 24/02/2024 23.38, Paolo Bonzini wrote: On Fri, Feb 23, 2024 at 8:56 PM BALATON Zoltan wrote: -if (!lasi_dev && machine->enable_graphics) { +if (!lasi_dev && machine->enable_graphics && defaults_enabled()) { Do we need the defaults_enabled() here? Isn't enable_graphics already

RE: [PATCH rfcv2 11/18] intel_iommu: Add set/unset_iommu_device callback

2024-02-25 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: Re: [PATCH rfcv2 11/18] intel_iommu: Add >set/unset_iommu_device callback > > > >On 2/1/24 08:28, Zhenzhong Duan wrote: >> From: Yi Liu >> >> This adds set/unset_iommu_device() implementation in Intel vIOMMU. >> In set call, a pointer to

Re: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

2024-02-25 Thread Alistair Francis
On Mon, Feb 26, 2024 at 11:16 AM Alvin Che-Chia Chang(張哲嘉) wrote: > > Hi Alistair, > > > -Original Message- > > From: Alistair Francis > > Sent: Monday, February 26, 2024 8:25 AM > > To: Alvin Che-Chia Chang(張哲嘉) > > Cc: qemu-ri...@nongnu.org; qemu-devel@nongnu.org; > >

Re: [PATCH v2 2/4] scripts/replay-dump.py: Update to current rr record format

2024-02-25 Thread Nicholas Piggin
On Wed Jan 31, 2024 at 7:36 AM AEST, John Snow wrote: > On Thu, Jan 25, 2024 at 11:09 AM Nicholas Piggin wrote: > > > > The v12 format support for replay-dump has a few issues still. This > > fixes async decoding; adds event, shutdown, and end decoding; fixes > > audio in / out events, fixes

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

2024-02-25 Thread Stefan Weil via
Am 26.02.24 um 05:35 schrieb Bin Meng: On Mon, Feb 26, 2024 at 1:37 AM Stefan Weil wrote: Am 10.09.22 um 02:37 schrieb Bin Meng: On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland wrote: On 08/09/2022 14:28, Bin Meng wrote: From: Bin Meng At present packaging the required DLLs of QEMU

RE: [PATCH rfcv2 10/18] hw/pci: Introduce pci_device_set/unset_iommu_device()

2024-02-25 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: Re: [PATCH rfcv2 10/18] hw/pci: Introduce >pci_device_set/unset_iommu_device() > >Hi Zhenzhong, > >On 2/1/24 08:28, Zhenzhong Duan wrote: >> From: Yi Liu >> >> This adds pci_device_set/unset_iommu_device() to set/unset >> HostIOMMUDevice

Re: [PATCH v2 1/3] hw/arm/sbsa-ref: Do not open-code ahci_ide_create_devs()

2024-02-25 Thread Thomas Huth
On 25/02/2024 18.21, Philippe Mathieu-Daudé wrote: On 25/2/24 18:16, Philippe Mathieu-Daudé wrote: Use ahci_ide_create_devs() instead of open-coding it. Not accessing AHCIDevice internals anymore allows to remove "hw/ide/ahci_internal.h" (which isn't really a public header). Signed-off-by:

RE: [PATCH rfcv2 04/18] vfio: Add host iommu device instance into VFIODevice

2024-02-25 Thread Duan, Zhenzhong
Hi Eric, >-Original Message- >From: Eric Auger >Subject: Re: [PATCH rfcv2 04/18] vfio: Add host iommu device instance into >VFIODevice > > > >On 2/1/24 08:28, Zhenzhong Duan wrote: >> Either IOMMULegacyDevice or IOMMUFDDevice into VFIODevice, neither >> both. >> >> Signed-off-by:

Re: [PATCH v4 00/34] migration: File based migration with multifd and fixed-ram

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:04PM -0300, Fabiano Rosas wrote: > 0) Cleanups [1-5] While I am still reading the rest.. I queued these five first. -- Peter Xu

Re: [PATCH v2 4/6] hw/i386/pc: Remove unneeded class attribute "kvmclock_enabled"

2024-02-25 Thread Thomas Huth
On 24/02/2024 14.58, Bernhard Beschow wrote: PCMachineClass introduces the attribute into the class hierarchy and sets it to true. There is no sub class overriding the attribute. Commit 30d2a17b46e9 "hw/i386: Remove the deprecated machines 0.12 up to 0.15" removed the last overrides of this

Re: [PATCH v4 18/34] migration/multifd: Allow multifd without packets

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:22PM -0300, Fabiano Rosas wrote: > For the upcoming support to the new 'fixed-ram' migration stream > format, we cannot use multifd packets because each write into the > ramblock section in the migration file is expected to contain only the > guest pages. They are

Re: [PATCH v4 14/34] migration/ram: Add incoming 'fixed-ram' migration

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:18PM -0300, Fabiano Rosas wrote: > Add the necessary code to parse the format changes for the 'fixed-ram' > capability. > > One of the more notable changes in behavior is that in the 'fixed-ram' > case ram pages are restored in one go rather than constantly looping >

Re: [PATCH v2] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-25 Thread Jason Wang
On Tue, Feb 20, 2024 at 3:41 PM Michael S. Tsirkin wrote: > > On Tue, Feb 20, 2024 at 12:39:35PM +0530, Srujana Challa wrote: > > Currently, virtio_pci_queue_mem_mult function always returns 4K > > when VIRTIO_PCI_FLAG_PAGE_PER_VQ is set. But this won't > > work for vhost vdpa when host has page

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

2024-02-25 Thread Bin Meng
On Mon, Feb 26, 2024 at 1:37 AM Stefan Weil wrote: > > Am 10.09.22 um 02:37 schrieb Bin Meng: > > On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland > > wrote: > >> > >> On 08/09/2022 14:28, Bin Meng wrote: > >> > >>> From: Bin Meng > >>> > >>> At present packaging the required DLLs of QEMU

Re: [PATCH v4 13/34] migration/ram: Add outgoing 'fixed-ram' migration

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:17PM -0300, Fabiano Rosas wrote: > Implement the outgoing migration side for the 'fixed-ram' capability. > > A bitmap is introduced to track which pages have been written in the > migration file. Pages are written at a fixed location for every > ramblock. Zero pages

Re: [PATCH] migration: Free argv

2024-02-25 Thread Peter Xu
On Sun, Feb 25, 2024 at 02:54:01PM +0900, Akihiko Odaki wrote: > exec_start_outgoing_migration() and exec_start_incoming_migration() > leak argv because it uses g_steal_pointer() is used to pass argv > qio_channel_command_new_spawn() while it does not free argv either. > > Removing

Re: [PATCH v2 0/5] migration: cleanup TLS channel referencing

2024-02-25 Thread Peter Xu
On Thu, Feb 22, 2024 at 05:52:56PM +0800, pet...@redhat.com wrote: > From: Peter Xu > > v2: > - add patches > - migration/multifd: Make multifd_channel_connect() return void > - migration/multifd: Cleanup outgoing_args in state destroy > - migration/multifd: Drop unnecessary helper to

Re: [PATCH v4 11/34] migration/ram: Introduce 'fixed-ram' migration capability

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:15PM -0300, Fabiano Rosas wrote: > + Without fixed-ram: With fixed-ram: > + > + - > + | ramblock 1 header | | ramblock 1 header| > + -

Re: [PATCH v4 12/34] migration: Add fixed-ram URI compatibility check

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:16PM -0300, Fabiano Rosas wrote: > The fixed-ram migration format needs a channel that supports seeking > to be able to write each page to an arbitrary offset in the migration > stream. > > Signed-off-by: Fabiano Rosas > Reviewed-by: Daniel P. Berrangé

Re: [PATCH v4 11/34] migration/ram: Introduce 'fixed-ram' migration capability

2024-02-25 Thread Peter Xu
On Tue, Feb 20, 2024 at 07:41:15PM -0300, Fabiano Rosas wrote: > Add a new migration capability 'fixed-ram'. > > The core of the feature is to ensure that each RAM page has a specific > offset in the resulting migration stream. The reasons why we'd want > such behavior are: > > - The resulting

Re: [PATCH] spapr: avoid overhead of finding vhyp class in critical operations

2024-02-25 Thread David Gibson
On Sat, Feb 24, 2024 at 05:33:59PM +1000, Nicholas Piggin wrote: > PPC_VIRTUAL_HYPERVISOR_GET_CLASS is used in critical operations like > interrupts and TLB misses and is quite costly. Running the > kvm-unit-tests sieve program with radix MMU enabled thrashes the TCG > TLB and spends a lot of time

Re: [PATCH V1] migration: export fewer options

2024-02-25 Thread Peter Xu
On Fri, Feb 23, 2024 at 09:13:24AM -0800, Steve Sistare wrote: > A small number of migration options are accessed by migration clients, > but to see them clients must include all of options.h, which is mostly > for migration core code. migrate_mode() in particular will be needed by > multiple

Re: [RFC PATCH v3 04/21] target/arm: Implement ALLINT MSR (immediate)

2024-02-25 Thread Jinjie Ruan via
On 2024/2/24 3:03, Richard Henderson wrote: > On 2/23/24 00:32, Jinjie Ruan via wrote: >> Add ALLINT MSR (immediate) to decodetree. And the EL0 check is necessary >> to ALLINT. Avoid the unconditional write to pc and use raise_exception_ra >> to unwind. >> >> Signed-off-by: Jinjie Ruan >> ---

Re: [PATCH V4 00/14] allow cpr-reboot for vfio

2024-02-25 Thread Peter Xu
On Thu, Feb 22, 2024 at 12:33:42PM -0500, Steven Sistare wrote: > Peter (and David if interested): these patches still need RB: > migration: notifier error checking > migration: stop vm for cpr > migration: update cpr-reboot description > migration: options incompatible with cpr These all

Re: [PATCH V4 14/14] migration: options incompatible with cpr

2024-02-25 Thread Peter Xu
On Thu, Feb 22, 2024 at 09:28:40AM -0800, Steve Sistare wrote: > Fail the migration request if options are set that are incompatible > with cpr. > > Signed-off-by: Steve Sistare Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH V4 13/14] migration: update cpr-reboot description

2024-02-25 Thread Peter Xu
On Thu, Feb 22, 2024 at 09:28:39AM -0800, Steve Sistare wrote: > Clarify qapi for cpr-reboot migration mode, and add vfio support. > > Signed-off-by: Steve Sistare Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-02-25 Thread Peter Xu
On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: > When migration for cpr is initiated, stop the vm and set state > RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the > possibility of ram and device state being out of sync, and guarantees > that a guest in the

Re: [PATCH V4 09/14] migration: notifier error checking

2024-02-25 Thread Peter Xu
On Thu, Feb 22, 2024 at 09:28:35AM -0800, Steve Sistare wrote: > Check the status returned by migration notifiers for event type > MIG_EVENT_PRECOPY_SETUP, and report errors. None of the notifiers > return an error status at this time. > > Signed-off-by: Steve Sistare Reviewed-by: Peter Xu

Re: [PATCH] migration: Fix qmp_query_migrate mbps value

2024-02-25 Thread Peter Xu
On Fri, Feb 23, 2024 at 09:39:12AM -0300, Fabiano Rosas wrote: > I've been planning to merge migration_completion() and > migration_iteration_finish(). It's too unintuitive to do the completion > routine deep inside migration_iteration_run(). AFAICS those are all tail > calls, so we could bring

Re: [External] Re: [PATCH v2 4/7] migration/multifd: Enable zero page checking from multifd threads.

2024-02-25 Thread Peter Xu
On Sat, Feb 24, 2024 at 03:03:15PM -0800, Hao Xiang wrote: > So I just want to make sure I am coding the right solution. I added > setting "zero-page-detection" to "legacy" in hw_compat_8_2 and tested > it. The behavior is that if I set machine type to pc-q35-8.2, > zero-page-detection will

Re: [PATCH 0/2] RISC-V: Add Ztso extension

2024-02-25 Thread Alistair Francis
On Wed, Feb 7, 2024 at 10:24 PM Christoph Müllner wrote: > > The first patch of this series picks up an earlier v2 Ztso patch from Palmer, > which can be found here: > > https://patchwork.kernel.org/project/qemu-devel/patch/20220917072635.11616-1-pal...@rivosinc.com/ > This patch did not apply

Re: [PATCH 2/2] linux-user/riscv: Add Ztso extension to hwprobe

2024-02-25 Thread Alistair Francis
On Wed, Feb 7, 2024 at 10:25 PM Christoph Müllner wrote: > > This patch exposes Ztso via hwprobe in QEMU's user space emulator. > > Signed-off-by: Christoph Müllner Reviewed-by: Alistair Francis Alistair > --- > linux-user/syscall.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread.

2024-02-25 Thread Peter Xu
On Sat, Feb 24, 2024 at 02:56:15PM -0800, Hao Xiang wrote: > > > > I don't think it's super clean to have three arrays offset, zero and > > > > normal, all sized for the full packet size. It might be possible to just > > > > carry a bitmap of non-zero pages along with pages->offset and operate on

Re: [PATCH 1/2] RISC-V: Add support for Ztso

2024-02-25 Thread Alistair Francis
On Wed, Feb 7, 2024 at 10:25 PM Christoph Müllner wrote: > > From: Palmer Dabbelt > > The Ztso extension is already ratified, this adds it as a CPU property > and adds various fences throughout the port in order to allow TSO > targets to function on weaker hosts. We need no fences for AMOs as >

RE: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

2024-02-25 Thread 張哲嘉
Hi Alistair, > -Original Message- > From: Alistair Francis > Sent: Monday, February 26, 2024 8:25 AM > To: Alvin Che-Chia Chang(張哲嘉) > Cc: qemu-ri...@nongnu.org; qemu-devel@nongnu.org; > alistair.fran...@wdc.com; bin.m...@windriver.com; liwei1...@gmail.com; > dbarb...@ventanamicro.com;

Re: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

2024-02-25 Thread Alistair Francis
On Fri, Feb 23, 2024 at 12:22 PM Alvin Chang via wrote: > > According to RISC-V Debug specification, the enabled privilege levels of Can you specify what version of the debug spec? Ideally if you can link directly to the PDF that would be very useful. There are multiple versions so it's hard to

Re: [PATCH v2 1/2] hw/arm: Use TYPE_OR_IRQ when connecting STM32L4x5 EXTI fan-in IRQs

2024-02-25 Thread Alistair Francis
On Wed, Feb 21, 2024 at 4:42 AM Inès Varhol wrote: > > Fixes: 52671f69f7a4 ("[PATCH v8 0/3] Add device STM32L4x5 EXTI") > Signed-off-by: Inès Varhol Acked-by: Alistair Francis Alistair > --- > include/hw/arm/stm32l4x5_soc.h | 4 ++ > hw/arm/stm32l4x5_soc.c | 80

[PATCH v6 18/41] Add clock_isp stub

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 6 ++ include/hw/arm/bcm2838_peripherals.h | 1 + 2 files changed, 7 insertions(+) diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c index 6badda3045..1f41028649 100644 ---

[PATCH v6 39/41] Add missed BCM2835 properties

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/misc/bcm2835_property.c | 21 + include/hw/arm/raspberrypi-fw-defs.h | 11 +++ 2 files changed, 32 insertions(+) diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c index 5c48f8d743..bdd9a6bbce 100644

[PATCH v6 12/41] Add memory region for BCM2837 RPiVid ASB

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2838_peripherals.c | 3 +++ include/hw/arm/bcm2838_peripherals.h | 2 ++ include/hw/arm/raspi_platform.h | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/arm/bcm2838_peripherals.c

[PATCH v6 11/41] Temporarily disable unimplemented rpi4b devices

2024-02-25 Thread Sergey Kambalin
This commit adds RPi4B device tree modifications: - disable pcie, rng200, thermal sensor and genet devices (they're going to be re-enabled in the following commits) - create additional memory region in device tree if RAM amount exceeds VC base address. Signed-off-by: Sergey Kambalin

[PATCH v6 20/41] Add GENET register structs. Part 1

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 37 include/hw/net/bcm2838_genet.h | 77 +- 2 files changed, 113 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index

[PATCH v6 27/41] Implement GENET TX path

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 221 - include/hw/net/bcm2838_genet.h | 17 +++ 2 files changed, 237 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 1fae3ecbc2..4c9b39a3ca 100644

[PATCH v6 23/41] Add GENET register structs. Part 4

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- include/hw/net/bcm2838_genet.h | 37 ++ 1 file changed, 37 insertions(+) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 1bd004785a..94c2f3ebca 100644 --- a/include/hw/net/bcm2838_genet.h +++

Re: [PATCH v6 2/3] hw/arm: Connect STM32L4x5 GPIO to STM32L4x5 SoC

2024-02-25 Thread Alistair Francis
On Sat, Feb 24, 2024 at 8:56 PM Inès Varhol wrote: > > Signed-off-by: Arnaud Minier > Signed-off-by: Inès Varhol > Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Alistair > --- > include/hw/arm/stm32l4x5_soc.h | 2 + > include/hw/gpio/stm32l4x5_gpio.h | 1 + >

Re: [PATCH v6 1/3] hw/gpio: Implement STM32L4x5 GPIO

2024-02-25 Thread Alistair Francis
On Sat, Feb 24, 2024 at 8:55 PM Inès Varhol wrote: > > Features supported : > - the 8 STM32L4x5 GPIOs are initialized with their reset values > (except IDR, see below) > - input mode : setting a pin in input mode "externally" (using input > irqs) results in an out irq (transmitted to

[PATCH v6 33/41] Add mailbox tests tags. Part 1

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 177 ++ 1 file changed, 177 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index 9222b38bad..1360fbb8cf 100644 --- a/tests/qtest/bcm2838-mailbox.h +++

[PATCH v6 06/41] Add BCM2838 GPIO stub

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/gpio/bcm2838_gpio.c | 153 + hw/gpio/meson.build| 5 +- include/hw/gpio/bcm2838_gpio.h | 40 + 3 files changed, 197 insertions(+), 1 deletion(-) create mode 100644

[PATCH v6 40/41] Append added properties to mailbox test

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/qtest/bcm2838-mbox-property-test.c b/tests/qtest/bcm2838-mbox-property-test.c index c96a9ba3f3..ff7c347e7c 100644 ---

[PATCH v6 02/41] Split out common part of peripherals

2024-02-25 Thread Sergey Kambalin
Pre-setup for BCM2838 introduction Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- hw/arm/bcm2835_peripherals.c | 198 +++ hw/arm/bcm2836.c | 24 ++-- include/hw/arm/bcm2835_peripherals.h | 29 +++- include/hw/arm/bcm2836.h

[PATCH v6 16/41] Add RPi4 RNG200

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 4 + hw/arm/bcm2838_peripherals.c | 17 ++ hw/arm/raspi4b.c | 1 - hw/misc/bcm2838_rng200.c | 405 +++ hw/misc/meson.build | 1 +

[PATCH v6 41/41] Add RPi4B to raspi.rst

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin Reviewed-by: Peter Maydell --- docs/system/arm/raspi.rst | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/system/arm/raspi.rst b/docs/system/arm/raspi.rst index d0a6f08b2b..c21b27744e 100644 --- a/docs/system/arm/raspi.rst +++

[PATCH v6 30/41] Add Rpi4b boot tests

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/avocado/boot_linux_console.py | 92 + 1 file changed, 92 insertions(+) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index a00202df3c..f5ec6de0f1 100644 ---

[PATCH v6 29/41] Enable BCM2838 GENET controller

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 6 ++ hw/arm/bcm2838_peripherals.c | 11 +++ hw/arm/raspi4b.c | 20 +--- include/hw/arm/bcm2838_peripherals.h | 2 ++ 4 files changed, 20 insertions(+), 19

[PATCH v6 13/41] Add BCM2838 PCIE Root Complex

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c | 82 +++ hw/arm/meson.build| 5 ++- include/hw/arm/bcm2838_pcie.h | 53 ++ 3 files changed, 139 insertions(+), 1 deletion(-) create mode 100644

[PATCH v6 26/41] Implement GENET MDIO

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 126 - include/hw/net/bcm2838_genet.h | 3 +- 2 files changed, 126 insertions(+), 3 deletions(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 56ff6a6f39..1fae3ecbc2 100644

[PATCH v6 36/41] Add mailbox property tests. Part 1

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.c| 1 - tests/qtest/bcm2838-mbox-property-test.c | 207 +++ tests/qtest/meson.build | 2 +- 3 files changed, 208 insertions(+), 2 deletions(-) create mode 100644

[PATCH v6 14/41] Add BCM2838 PCIE host

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c | 217 +- hw/arm/trace-events | 4 + include/hw/arm/bcm2838_pcie.h | 22 3 files changed, 241 insertions(+), 2 deletions(-) diff --git a/hw/arm/bcm2838_pcie.c

[PATCH v6 34/41] Add mailbox tests tags. Part 2

2024-02-25 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 152 ++ 1 file changed, 152 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index 1360fbb8cf..b4f7b7b314 100644 --- a/tests/qtest/bcm2838-mailbox.h +++

  1   2   >