[PATCH v3 16/20] smbios: in case of entry point is 'auto' try to build v2 tables 1st

2024-03-12 Thread Igor Mammedov
QEMU for some time now uses SMBIOS 3.0 for PC/Q35 machines by default, however Windows has a bug in locating SMBIOS 3.0 entrypoint and fails to find tables when booted on SeaBIOS (on UEFI SMBIOS 3.0 tables work fine since firmware hands over tables in another way) Missing SMBIOS tables may lead

[PATCH v3 00/20] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS

2024-03-12 Thread Igor Mammedov
Changelog: v3: * whitespace missed by checkpatch * fix idndent in QAPI * reorder 17/20 before 1st 'auto' can be used * pick up acks v2: * QAPI style fixes (Markus Armbruster ) * squash 11/19 into 10/19 (Ani Sinha ) * split '[PATCH 09/19] smbios: build legacy mode code only

Re: [PATCH v5 7/8] Add multifd_tcp_plain test using list of channels instead of uri

2024-03-12 Thread Het Gala
Hi Fabiano and Peter, do not give Reviewed-by tag for this patch. There is a small mistake here, forgot to replace NULL with args->connect_channels while calling migrate_qmp inside test_precopy_common. This was not caught earlier because, in the case where channels and uri both are absent,

[PATCH v3 07/20] smbios: avoid mangling user provided tables

2024-03-12 Thread Igor Mammedov
currently smbios_entry_add() preserves internally '-smbios type=' options but tables provided with '-smbios file=' are stored directly into blob that eventually will be exposed to VM. And then later QEMU adds default/'-smbios type' entries on top into the same blob. It makes impossible to

[PATCH v3 02/20] tests: smbios: add test for -smbios type=11 option

2024-03-12 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha Tested-by: Fiona Ebner --- tests/data/smbios/type11_blob | Bin 0 -> 11 bytes tests/qtest/bios-tables-test.c | 17 + 2 files changed, 17 insertions(+) create mode 100644 tests/data/smbios/type11_blob diff --git

[PATCH v3 03/20] tests: smbios: add test for legacy mode CLI options

2024-03-12 Thread Igor Mammedov
Unfortunately having 2.0 machine type deprecated is not enough to get rid of legacy SMBIOS handling since 'isapc' also uses that and it's staying around. Hence add test for CLI options handling to be sure that it ain't broken during SMBIOS code refactoring. Signed-off-by: Igor Mammedov

Re: [PATCH 4/5] plugins: conditional callbacks

2024-03-12 Thread Pierrick Bouvier
On 3/12/24 19:04, Alex Bennée wrote: Pierrick Bouvier writes: On 3/11/24 14:08, Alex Bennée wrote: Pierrick Bouvier writes: Extend plugins API to support callback called with a given criteria (evaluated inline). Added functions: - qemu_plugin_register_vcpu_tb_exec_cond_cb -

Re: [PATCH v3] docs/system/ppc: Document running Linux on AmigaNG machines

2024-03-12 Thread BALATON Zoltan
On Wed, 13 Mar 2024, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 8:36 PM AEST, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 7:28 PM AEST, Bernhard Beschow wrote: Am 9. März 2024 11:34:56 UTC schrieb BALATON Zoltan : On Thu, 29 Feb 2024, BALATON Zoltan wrote: On Wed, 21 Feb 2024, BALATON

Re: [EXT] Re: [PATCH] vhost_net: add NOTIFICATION_DATA and IN_ORDER feature bits to vdpa_feature_bits

2024-03-12 Thread Michael S. Tsirkin
On Mon, Mar 11, 2024 at 09:32:53AM +0100, Eugenio Perez Martin wrote: > On Fri, Mar 8, 2024 at 2:39 PM Srujana Challa wrote: > > > > Hi Michael, > > > > VIRTIO_F_NOTIFICATION_DATA needs to be exposed to make Marvell's device > > works > > with Qemu. Any other better ways to expose

Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

2024-03-12 Thread Kevin Wolf
Am 12.03.2024 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 11.03.24 18:15, Vladimir Sementsov-Ogievskiy wrote: > > On 08.03.24 11:52, Kevin Wolf wrote: > > > Am 07.03.2024 um 20:42 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > > On 04.03.24 14:09, Peter Krempa wrote: > > > > >

Re: [PATCH v3 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-03-12 Thread Daniel P . Berrangé
On Tue, Mar 12, 2024 at 12:21:14PM +0100, Anthony Harivel wrote: > Daniel P. Berrangé, Jan 30, 2024 at 10:39: > > > +rcu_register_thread(); > > > + > > > +/* Get QEMU PID*/ > > > +pid = getpid(); > > > + > > > +/* Nb of CPUS per packages */ > > > +maxcpus =

Re: [PATCH 0/5] Implement port 92 in south bridges

2024-03-12 Thread Michael S. Tsirkin
On Sun, Feb 18, 2024 at 02:16:56PM +0100, Bernhard Beschow wrote: > This series attempts to make QEMU's south bridge families PIIX, ICH9, and VIA > 82xx more self-contained by integrating IO port 92 like the originals do. Bernhard my understanding is that you agreed with Mark this needs more

Re: [PATCH 7/9] i386/sev: Refactor setting of reset vector and initial CPU state

2024-03-12 Thread Roy Hopkins
On Fri, 2024-03-01 at 17:01 +, Daniel P. Berrangé wrote: > On Tue, Feb 27, 2024 at 02:50:13PM +, Roy Hopkins wrote: > > When an SEV guest is started, the reset vector and state are > > extracted from metadata that is contained in the firmware volume. > > > > In preparation for using IGVM

Re: [PATCH v2 00/11] virtio-sound migration part 1

2024-03-12 Thread Michael S. Tsirkin
On Sun, Feb 18, 2024 at 09:31:02AM +0100, Volker Rümelin wrote: > Here is the first part of my virtio-sound patches. Most of them are a > preparation to make migration work. Patch 10/11 enables migration. > > The second part isn't finished yet and will have to do with virtio-sound > jack and

Re: [PATCH v2 07/11] hw/audio/virtio-sound: add stream state variable

2024-03-12 Thread Michael S. Tsirkin
On Mon, Feb 19, 2024 at 02:59:45PM +0200, Manos Pitsidianakis wrote: > Hello Volker, > > On Sun, 18 Feb 2024 at 10:34, Volker Rümelin wrote: > > > > So far, only rudimentary checks have been made to ensure that > > the guest only performs state transitions permitted in > > virtio-v1.2-csd01

Re: [PATCH qemu] hw/pci-bridge/pxb-cxl: Drop RAS capability from host bridge.

2024-03-12 Thread Michael S. Tsirkin
On Thu, Feb 15, 2024 at 05:42:12PM +, Jonathan Cameron wrote: > On Thu, 15 Feb 2024 11:11:47 -0500 > "Michael S. Tsirkin" wrote: > > > On Thu, Feb 15, 2024 at 03:52:06PM +, Jonathan Cameron wrote: > > > This CXL component isn't allowed to have a RAS capability. > > > Whilst this should

Re: [PULL for 9.0 0/8] final maintainer updates (testing, gdbstub)

2024-03-12 Thread Peter Maydell
On Tue, 12 Mar 2024 at 15:01, Alex Bennée wrote: > That's annoying - I thought I had the s390 jobs in my matrix but it > seems they don't appear anymore. That said I see: > > root@qemu01 ~# cat /etc/lsb-release > DISTRIB_ID=Ubuntu > DISTRIB_RELEASE=20.04 > DISTRIB_CODENAME=focal >

Re: [PATCH] pcie: Support PCIe Gen5/Gen6 link speeds

2024-03-12 Thread Michael S. Tsirkin
On Thu, Feb 15, 2024 at 02:23:26AM +0100, Lukas Stockner wrote: > diff --git a/qapi/common.json b/qapi/common.json > index f1bb841951..867a9ad9b0 100644 > --- a/qapi/common.json > +++ b/qapi/common.json > @@ -107,10 +107,14 @@ > # > # @16: 16.0GT/s > # > +# @32: 32.0GT/s > +# > +# @64: 64.0GT/s

Re: [PATCH v3 1/5] hw/display : Add device DM163

2024-03-12 Thread Peter Maydell
On Wed, 28 Feb 2024 at 12:02, Inès Varhol wrote: > > This device implements the IM120417002 colors shield v1.1 for Arduino > (which relies on the DM163 8x3-channel led driving logic) and features > a simple display of an 8x8 RGB matrix. The columns of the matrix are > driven by the DM163 and the

Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup()

2024-03-12 Thread Peter Xu
On Tue, Mar 12, 2024 at 11:24:39AM -0300, Fabiano Rosas wrote: > Cédric Le Goater writes: > > > On 3/12/24 14:34, Cédric Le Goater wrote: > >> On 3/12/24 13:32, Cédric Le Goater wrote: > >>> On 3/11/24 20:03, Fabiano Rosas wrote: > Cédric Le Goater writes: > > > On 3/8/24 15:36,

Re: [PATCH 08/10] qapi: Correct error message for 'vcpu_dirty_limit' parameter

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:41PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:41 +0100 > From: Markus Armbruster > Subject: [PATCH 08/10] qapi: Correct error message for 'vcpu_dirty_limit' > parameter > > From: Philippe Mathieu-Daudé > > QERR_INVALID_PARAMETER_VALUE is

[PATCH v2] virtio-blk: iothread-vq-mapping coroutine pool sizing

2024-03-12 Thread Stefan Hajnoczi
It is possible to hit the sysctl vm.max_map_count limit when the coroutine pool size becomes large. Each coroutine requires two mappings (one for the stack and one for the guard page). QEMU can crash with "failed to set up stack guard page" or "failed to allocate memory for stack" when this

Re: [PATCH 10/10] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:43PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:43 +0100 > From: Markus Armbruster > Subject: [PATCH 10/10] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD > definition > > From: Philippe Mathieu-Daudé > > Address the comment added in commit

Re: [PATCH v2 1/2] vhost: dirty log should be per backend type

2024-03-12 Thread Michael S. Tsirkin
On Wed, Feb 14, 2024 at 10:42:29AM -0800, Si-Wei Liu wrote: > Hi Michael, > > I'm taking off for 2+ weeks, but please feel free to provide comment and > feedback while I'm off. I'll be checking emails still, and am about to > address any opens as soon as I am back. > > Thanks, > -Siwei Eugenio

Re: [PATCH v1 2/8] virtio-pci: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-12 Thread Jonah Palmer
On 3/12/24 10:58 AM, Michael S. Tsirkin wrote: On Tue, Mar 12, 2024 at 10:33:51AM -0400, Jonah Palmer wrote: On 3/11/24 11:47 AM, Michael S. Tsirkin wrote: On Mon, Mar 11, 2024 at 10:53:25AM -0400, Jonah Palmer wrote: On 3/8/24 2:19 PM, Michael S. Tsirkin wrote: On Fri, Mar 08, 2024

Re: [PATCH 09/10] qapi: Inline and remove QERR_MIGRATION_ACTIVE definition

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:42PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:42 +0100 > From: Markus Armbruster > Subject: [PATCH 09/10] qapi: Inline and remove QERR_MIGRATION_ACTIVE > definition > > From: Philippe Mathieu-Daudé > > Address the comment added in commit

Re: [PATCH 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:40PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:40 +0100 > From: Markus Armbruster > Subject: [PATCH 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE > definition > > From: Philippe Mathieu-Daudé > > Address the comment added in

Re: [PATCH 06/10] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value)

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:39PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:39 +0100 > From: Markus Armbruster > Subject: [PATCH 06/10] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition > (constant value) > > From: Philippe Mathieu-Daudé > > Address the comment added

Re: [PATCH v7 2/4] qcow2: add configurations for zoned format extension

2024-03-12 Thread Stefan Hajnoczi
On Mon, Jan 22, 2024 at 07:48:28PM +0100, Sam Li wrote: > To configure the zoned format feature on the qcow2 driver, it > requires settings as: the device size, zone model, zone size, > zone capacity, number of conventional zones, limits on zone > resources (max append bytes, max open zones, and

Re: [PATCH 4/5] plugins: conditional callbacks

2024-03-12 Thread Alex Bennée
Pierrick Bouvier writes: > On 3/11/24 14:08, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> Extend plugins API to support callback called with a given criteria >>> (evaluated inline). >>> >>> Added functions: >>> - qemu_plugin_register_vcpu_tb_exec_cond_cb >>> -

Re: [PULL for 9.0 0/8] final maintainer updates (testing, gdbstub)

2024-03-12 Thread Alex Bennée
Peter Maydell writes: > On Tue, 12 Mar 2024 at 11:26, Alex Bennée wrote: >> >> The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f: >> >> Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into >> staging (2024-03-09 20:12:21 +) >> >> are available in

Re: [PATCH 05/10] qapi: Inline and remove QERR_INVALID_PARAMETER definition

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:38PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:38 +0100 > From: Markus Armbruster > Subject: [PATCH 05/10] qapi: Inline and remove QERR_INVALID_PARAMETER > definition > > From: Philippe Mathieu-Daudé > > Address the comment added in commit

Re: [PATCH v1 2/8] virtio-pci: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-12 Thread Michael S. Tsirkin
On Tue, Mar 12, 2024 at 10:33:51AM -0400, Jonah Palmer wrote: > > > On 3/11/24 11:47 AM, Michael S. Tsirkin wrote: > > On Mon, Mar 11, 2024 at 10:53:25AM -0400, Jonah Palmer wrote: > > > > > > > > > On 3/8/24 2:19 PM, Michael S. Tsirkin wrote: > > > > On Fri, Mar 08, 2024 at 12:45:13PM -0500,

Re: [PATCH 04/10] qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG definition

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:37PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:37 +0100 > From: Markus Armbruster > Subject: [PATCH 04/10] qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG > definition > > From: Philippe Mathieu-Daudé > > Address the comment added in commit

Re: [PATCH 03/10] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM definition

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:36PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:36 +0100 > From: Markus Armbruster > Subject: [PATCH 03/10] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM > definition > > From: Philippe Mathieu-Daudé > > Address the comment added in commit

Re: [PATCH 02/10] qapi: Inline and remove QERR_BUS_NO_HOTPLUG definition

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:35PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:35 +0100 > From: Markus Armbruster > Subject: [PATCH 02/10] qapi: Inline and remove QERR_BUS_NO_HOTPLUG > definition > > From: Philippe Mathieu-Daudé > > Address the comment added in commit

Re: [PATCH 01/10] error: Drop superfluous #include "qapi/qmp/qerror.h"

2024-03-12 Thread Zhao Liu
On Tue, Mar 12, 2024 at 03:13:34PM +0100, Markus Armbruster wrote: > Date: Tue, 12 Mar 2024 15:13:34 +0100 > From: Markus Armbruster > Subject: [PATCH 01/10] error: Drop superfluous #include "qapi/qmp/qerror.h" > > Signed-off-by: Markus Armbruster > --- > backends/iommufd.c | 1 - >

Re: [PATCH v3 2/5] hw/arm : Pass STM32L4x5 SYSCFG gpios to STM32L4x5 SoC

2024-03-12 Thread Peter Maydell
On Wed, 28 Feb 2024 at 12:02, Inès Varhol wrote: > > Exposing SYSCFG inputs to the SoC is practical in order to wire the SoC > to the optional DM163 display from the board code (GPIOs outputs need > to be connected to both SYSCFG inputs and DM163 inputs). > > STM32L4x5 SYSCFG in-irq interception

Re: [PATCH v2] linux-aio: add IO_CMD_FDSYNC command support

2024-03-12 Thread Stefan Hajnoczi
On Tue, Mar 12, 2024 at 07:07:04PM +0530, Prasad Pandit wrote: > Hello, > > On Tue, 12 Mar 2024 at 15:15, Kevin Wolf wrote: > > Am 11.03.2024 um 20:36 hat Stefan Hajnoczi geschrieben: > > > > > That can be avoided with a variable that keeps track of whether > > > > > -EINVAL was seen before and

Re: [PATCH] target/ppc: Move floating-point arithmetic instructions to decodetree.

2024-03-12 Thread Richard Henderson
On 3/12/24 04:24, Nicholas Piggin wrote: Beware -- GETPC() may only be called from the outermost helper. Ah, because it's using __builtin_return_address. Good to know. Using always_inline and a comment should do the trick then. No, seriously just don't do it. Pass an argument 'uintptr_t ra'

[PATCH 10/15] tcg/riscv: Do not accept immediate operand for andc, orc, eqv

2024-03-12 Thread Richard Henderson
The transformations with inverted immediate are now done generically and need not be handled by the backend. Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target-con-set.h | 1 - tcg/riscv/tcg-target-con-str.h | 1 - tcg/riscv/tcg-target.c.inc | 36 +++---

[PATCH 08/15] tcg/loongarch64: Do not accept immediate operand for andc, orc

2024-03-12 Thread Richard Henderson
The transformations with inverted immediate are now done generically and need not be handled by the backend. Signed-off-by: Richard Henderson --- tcg/loongarch64/tcg-target-con-set.h | 2 +- tcg/loongarch64/tcg-target-con-str.h | 1 - tcg/loongarch64/tcg-target.c.inc | 31

[PATCH 15/15] tcg/optimize: Lower unsupported deposit during optimize

2024-03-12 Thread Richard Henderson
The expansions that we chose in tcg-op.c may be less than optimial. Delay lowering until optimize, so that we have propagated constants and have computed known zero masks. Signed-off-by: Richard Henderson --- tcg/optimize.c | 231 +- tcg/tcg-op.c |

[PATCH 13/15] tcg/optimize: Fold and to extu during optimize

2024-03-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 43 +++ 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c6b0ab35c8..39bcd32f72 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1300,11 +1300,46

[PATCH 11/15] tcg/riscv: Do not accept immediate operands for sub

2024-03-12 Thread Richard Henderson
The transformations to neg and add immediate are now done generically and need not be handled by the backend. Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target-con-set.h | 2 +- tcg/riscv/tcg-target-con-str.h | 1 - tcg/riscv/tcg-target.c.inc | 24 3 files

[PATCH 02/15] tcg/optimize: Fold orc with immediate to or

2024-03-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 2ec52df368..5729433548 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2065,6 +2065,15 @@ static bool fold_orc(OptContext *ctx, TCGOp *op)

[PATCH for-9.1 00/15] tcg: Canonicalize operations during optimize

2024-03-12 Thread Richard Henderson
This is a follow-on to 6334a968eec3 ("tcg/optimize: Canonicalize subi to addi during optimization"), which I wrote at the end of the previous devel cycle, then forgot about during the current. In addition to sub->add, canonicalize andc->and etc. The early expansion that we produce for deposit

[PATCH 12/15] tcg/riscv: Do not accept zero operands for logicals, multiply or divide

2024-03-12 Thread Richard Henderson
Trust that the optimizer has folded all of these away. Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target-con-set.h | 1 - tcg/riscv/tcg-target.c.inc | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tcg/riscv/tcg-target-con-set.h

[PATCH 01/15] tcg/optimize: Fold andc with immediate to and

2024-03-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 752cc5c56b..2ec52df368 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1324,17 +1324,23 @@ static bool

[PATCH 04/15] tcg/i386: Do not accept immediate operand for andc

2024-03-12 Thread Richard Henderson
The transformation of andc with immediate to and is now done generically and need not be handled by the backend. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target-con-set.h | 3 +-- tcg/i386/tcg-target-con-str.h | 1 - tcg/i386/tcg-target.c.inc | 20 +--- 3 files

[PATCH 09/15] tcg/s390x: Do not accept immediate operand for andc, orc

2024-03-12 Thread Richard Henderson
The transformations with inverted immediate are now done generically and need not be handled by the backend. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 56 ++ 1 file changed, 8 insertions(+), 48 deletions(-) diff --git

[PATCH 14/15] tcg: Use arg_is_const_val in fold_sub_to_neg

2024-03-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 39bcd32f72..f3867ce9e6 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2451,7 +2451,7 @@ static bool fold_sub_to_neg(OptContext *ctx,

[PATCH 07/15] tcg/ppc: Do not accept immediate operand for andc, orc, eqv

2024-03-12 Thread Richard Henderson
The transformations with inverted immediate are now done generically and need not be handled by the backend. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 32 +--- 1 file changed, 5 insertions(+), 27 deletions(-) diff --git

[PATCH 05/15] tcg/aarch64: Do not accept immediate operand for andc, orc, eqv

2024-03-12 Thread Richard Henderson
The transformations with inverted immediate are now done generically and need not be handled by the backend. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c.inc | 50 +++- 1 file changed, 15 insertions(+), 35 deletions(-) diff --git

[PATCH 06/15] tcg/arm: Do not accept immediate operand for andc

2024-03-12 Thread Richard Henderson
The transformation of andc with immediate to and is now done generically and need not be handled by the backend. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/arm/tcg-target.c.inc

[PATCH 03/15] tcg/optimize: Fold eqv with immediate to xor

2024-03-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 5729433548..c6b0ab35c8 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1687,6 +1687,15 @@ static bool fold_eqv(OptContext *ctx, TCGOp *op)

Re: [PATCH v3] docs/system/ppc: Document running Linux on AmigaNG machines

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 8:36 PM AEST, Nicholas Piggin wrote: > On Tue Mar 12, 2024 at 7:28 PM AEST, Bernhard Beschow wrote: > > > > > > Am 9. März 2024 11:34:56 UTC schrieb BALATON Zoltan : > > >On Thu, 29 Feb 2024, BALATON Zoltan wrote: > > >> On Wed, 21 Feb 2024, BALATON Zoltan wrote: > > >>>

Re: [PATCH v1 2/8] virtio-pci: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-12 Thread Jonah Palmer
On 3/11/24 11:47 AM, Michael S. Tsirkin wrote: On Mon, Mar 11, 2024 at 10:53:25AM -0400, Jonah Palmer wrote: On 3/8/24 2:19 PM, Michael S. Tsirkin wrote: On Fri, Mar 08, 2024 at 12:45:13PM -0500, Jonah Palmer wrote: On 3/8/24 12:36 PM, Eugenio Perez Martin wrote: On Fri, Mar 8, 2024

Re: [PATCH] target/ppc: Move floating-point arithmetic instructions to decodetree.

2024-03-12 Thread Peter Maydell
On Tue, 12 Mar 2024 at 14:25, Nicholas Piggin wrote: > > On Wed Mar 13, 2024 at 12:01 AM AEST, Richard Henderson wrote: > > On 3/11/24 23:36, Nicholas Piggin wrote: > > [snip] > > > > > > > #define FPU_HELPER(name, op, flags_handler) \ > > > float64

[PULL 1/3] xen/pt: Emulate multifunction bit in header type

2024-03-12 Thread Anthony PERARD
From: Ross Lagerwall The intention of the code appears to have been to unconditionally set the multifunction bit but since the emulation mask is 0x00 it has no effect. Instead, emulate the bit and set it based on the multifunction property of the PCIDevice (which can be set using QAPI). This

[PULL 0/3] Xen queue 2024-03-12

2024-03-12 Thread Anthony PERARD
-dm.git tags/pull-xen-20240312 for you to fetch changes up to 918a7f706b69a8c725bac0694971d2831f688ebb: i386: load kernel on xen using DMA (2024-03-12 14:13:08 +) Xen queue: * In Xen PCI passthrough, emulate multifunction bit

[PULL 2/3] xen: Drop out of coroutine context xen_invalidate_map_cache_entry

2024-03-12 Thread Anthony PERARD
From: Peng Fan xen_invalidate_map_cache_entry is not expected to run in a coroutine. Without this, there is crash: signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44 threadid=) at pthread_kill.c:78 at /usr/src/debug/glibc/2.38+git-r0/sysdeps/posix/raise.c:26

[PULL 3/3] i386: load kernel on xen using DMA

2024-03-12 Thread Anthony PERARD
From: Marek Marczykowski-Górecki Kernel on Xen is loaded via fw_cfg. Previously it used non-DMA version, which loaded the kernel (and initramfs) byte by byte. Change this to DMA, to load in bigger chunks. This change alone reduces load time of a (big) kernel+initramfs from ~10s down to below 1s.

Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup()

2024-03-12 Thread Fabiano Rosas
Cédric Le Goater writes: > On 3/12/24 14:34, Cédric Le Goater wrote: >> On 3/12/24 13:32, Cédric Le Goater wrote: >>> On 3/11/24 20:03, Fabiano Rosas wrote: Cédric Le Goater writes: > On 3/8/24 15:36, Fabiano Rosas wrote: >> Cédric Le Goater writes: >> >>> This

Re: [PATCH] target/ppc: Move floating-point arithmetic instructions to decodetree.

2024-03-12 Thread Nicholas Piggin
On Wed Mar 13, 2024 at 12:01 AM AEST, Richard Henderson wrote: > On 3/11/24 23:36, Nicholas Piggin wrote: [snip] > > > > #define FPU_HELPER(name, op, flags_handler) \ > > float64 helper_##name(CPUPPCState *env, float64 arg1, float64 arg2) \ > > {

[PATCH 10/10] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition

2024-03-12 Thread Markus Armbruster
From: Philippe Mathieu-Daudé Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Manual change. Remove the definition in include/qapi/qmp/qerror.h.

[PATCH 02/10] qapi: Inline and remove QERR_BUS_NO_HOTPLUG definition

2024-03-12 Thread Markus Armbruster
From: Philippe Mathieu-Daudé Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, and manual cleanup.

[PATCH 00/10] Reduce usage of QERR_ macros further

2024-03-12 Thread Markus Armbruster
Philippe posted "[PATCH v2 00/22] qapi: Kill 'qapi/qmp/qerror.h' for good" a couple of months ago. I cherry-picked just its simplest parts for now. Markus Armbruster (1): error: Drop superfluous #include "qapi/qmp/qerror.h" Philippe Mathieu-Daudé (9): qapi: Inline and remove

[PATCH 09/10] qapi: Inline and remove QERR_MIGRATION_ACTIVE definition

2024-03-12 Thread Markus Armbruster
From: Philippe Mathieu-Daudé Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, manually removing the

[PATCH 03/10] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM definition

2024-03-12 Thread Markus Armbruster
From: Philippe Mathieu-Daudé Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, and manual cleanup.

[PATCH 08/10] qapi: Correct error message for 'vcpu_dirty_limit' parameter

2024-03-12 Thread Markus Armbruster
From: Philippe Mathieu-Daudé QERR_INVALID_PARAMETER_VALUE is defined as: #define QERR_INVALID_PARAMETER_VALUE \ "Parameter '%s' expects %s" The current error is formatted as: "Parameter 'vcpu_dirty_limit' expects is invalid, it must greater then 1 MB/s" Replace by: "Parameter

[PATCH 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition

2024-03-12 Thread Markus Armbruster
From: Philippe Mathieu-Daudé Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Manual changes (escaping the format in qapi/visit.py).

[PATCH 05/10] qapi: Inline and remove QERR_INVALID_PARAMETER definition

2024-03-12 Thread Markus Armbruster
From: Philippe Mathieu-Daudé Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using: $ sed -i -e

[PATCH 04/10] qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG definition

2024-03-12 Thread Markus Armbruster
From: Philippe Mathieu-Daudé Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, and manual cleanup.

[PATCH 06/10] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value)

2024-03-12 Thread Markus Armbruster
From: Philippe Mathieu-Daudé Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using the following coccinelle semantic

[PATCH 01/10] error: Drop superfluous #include "qapi/qmp/qerror.h"

2024-03-12 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- backends/iommufd.c | 1 - chardev/char-fe.c | 1 - system/rtc.c | 1 - 3 files changed, 3 deletions(-) diff --git a/backends/iommufd.c b/backends/iommufd.c index 1ef683c7b0..922d75e49e 100644 --- a/backends/iommufd.c +++ b/backends/iommufd.c @@ -13,7

Re: [PATCH v4 06/24] chardev: set record/replay on the base device of a muxed device

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 10:39 PM AEST, Marc-André Lureau wrote: > Hi > > On Mon, Mar 11, 2024 at 9:44 PM Nicholas Piggin wrote: > > > > chardev events to a muxed device don't get recorded because e.g., > > qemu_chr_be_write() checks whether the base device has the record flag > > set. > > > > This

Re: [PATCH v4 05/24] Revert "replay: stop us hanging in rr_wait_io_event"

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 11:33 PM AEST, Alex Bennée wrote: > Nicholas Piggin writes: > > > This reverts commit 1f881ea4a444ef36a8b6907b0b82be4b3af253a2. > > > > That commit causes reverse_debugging.py test failures, and does > > not seem to solve the root cause of the problem x86-64 still > > hangs

[PULL 4/5] virtio-gpu: remove needless condition

2024-03-12 Thread marcandre . lureau
From: Marc-André Lureau qemu_create_displaysurface_pixman() never returns NULL. Signed-off-by: Marc-André Lureau --- hw/display/virtio-gpu.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 1c1ee230b3..ccbe31d759 100644 ---

[PULL 3/5] ui/dbus: filter out pending messages when scanout

2024-03-12 Thread marcandre . lureau
From: Marc-André Lureau The "Listener" connection, being private and under the control of the qemu display, allows for the optimization of discarding pending intermediary messages when queuing a new scanout. This ensures that the client receives only the latest scanout update, improving

[PULL 5/5] virtio-gpu: fix scanout migration post-load

2024-03-12 Thread marcandre . lureau
From: Marc-André Lureau The current post-loading code for scanout has a FIXME: it doesn't take the resource region/rect into account. But there is more, when adding blob migration support in commit f66767f75c9, I didn't realize that blob resources could be used for scanouts. This situationn

[PULL 2/5] ui/dbus: factor out sending a scanout

2024-03-12 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 18f556aa73..3f4529dbbd 100644 --- a/ui/dbus-listener.c +++

[PULL 0/5] UI patches

2024-03-12 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 8f3f329f5e0117bd1a23a79ab751f8a7d3471e4b: Merge tag 'migration-20240311-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-03-12 11:35:41 +) are available in the Git repository at:

[PULL 1/5] ui/vnc: Respect bound console

2024-03-12 Thread marcandre . lureau
From: Akihiko Odaki ui/vnc may have a bound console so pass it to qemu_console_is_graphic() and qemu_text_console_put_keysym(). Fixes: 1d0d59fe2919 ("vnc: allow binding servers to qemu consoles") Signed-off-by: Akihiko Odaki Reviewed-by: Marc-André Lureau Message-Id:

Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup()

2024-03-12 Thread Cédric Le Goater
On 3/12/24 14:34, Cédric Le Goater wrote: On 3/12/24 13:32, Cédric Le Goater wrote: On 3/11/24 20:03, Fabiano Rosas wrote: Cédric Le Goater writes: On 3/8/24 15:36, Fabiano Rosas wrote: Cédric Le Goater writes: This prepares ground for the changes coming next which add an Error**

Re: [PATCH] target/ppc: Move floating-point arithmetic instructions to decodetree.

2024-03-12 Thread Richard Henderson
On 3/11/24 23:36, Nicholas Piggin wrote: On Thu Mar 7, 2024 at 9:03 PM AEST, Chinmay Rath wrote: This patch moves the below instructions to decodetree specification : f{add, sub, mul, div, re, rsqrte, madd, msub, nmadd, nmsub}[s][.] : A-form ft{div, sqrt}

Re: [PATCH v2] target/riscv: Implement dynamic establishment of custom decoder

2024-03-12 Thread Richard Henderson
On 3/11/24 19:45, Huang Tao wrote: +static void riscv_cpu_finalize_dynamic_decoder(RISCVCPU *cpu) +{ +decode_fn *dynamic_decoders; +dynamic_decoders = g_new0(decode_fn, decoder_table_size); Allocating ARRAY_SIZE(decoder_table)... +int j = 0; +for (size_t i = 0; i <

[RFC v2 2/2] hw/riscv: Add server platform reference machine

2024-03-12 Thread Fei Wu
The RISC-V Server Platform specification[1] defines a standardized set of hardware and software capabilities, that portable system software, such as OS and hypervisors can rely on being present in a RISC-V server platform. A corresponding Qemu RISC-V server platform reference (rvsp-ref for short)

[RFC v2 1/2] target/riscv: Add server platform reference cpu

2024-03-12 Thread Fei Wu
The harts requirements of RISC-V server platform [1] require RVA23 ISA profile support, plus Sv48, Svadu, H, Sscofmpf etc. This patch provides a virt CPU type (rvsp-ref) as compliant as possible. [1]

[RFC v2 0/2] Add RISC-V Server Platform Reference Board

2024-03-12 Thread Fei Wu
The RISC-V Server Platform specification[1] defines a standardized set of hardware and software capabilities, that portable system software, such as OS and hypervisors can rely on being present in a RISC-V server platform. This patchset provides a RISC-V Server Platform (RVSP) reference

Re: [PATCH v4 22/24] target/ppc: fix timebase register reset state

2024-03-12 Thread Nicholas Piggin
On Tue Mar 12, 2024 at 11:24 PM AEST, Alex Bennée wrote: > Nicholas Piggin writes: > > > (H)DEC and PURR get reset before icount does, which causes them to be > > skewed and not match the init state. This can cause replay to not > > match the recorded trace exactly. For DEC and HDEC this is

Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

2024-03-12 Thread Vladimir Sementsov-Ogievskiy
On 11.03.24 18:15, Vladimir Sementsov-Ogievskiy wrote: On 08.03.24 11:52, Kevin Wolf wrote: Am 07.03.2024 um 20:42 hat Vladimir Sementsov-Ogievskiy geschrieben: On 04.03.24 14:09, Peter Krempa wrote: On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote: Am 28.02.2024 um 19:07 hat

Re: [PATCH v2 08/10] ppc/pnv: Set POWER9, POWER10 ibm,pa-features bits

2024-03-12 Thread Harsh Prateek Bora
On 3/12/24 18:44, Nicholas Piggin wrote: Copy the pa-features arrays from spapr, adjusting slightly as described in comments. Signed-off-by: Nicholas Piggin Although future re-org is expected per discussion on v1, but for now: Reviewed-by: Harsh Prateek Bora --- hw/ppc/pnv.c | 67

Re: [PULL for 9.0 0/8] final maintainer updates (testing, gdbstub)

2024-03-12 Thread Peter Maydell
On Tue, 12 Mar 2024 at 11:26, Alex Bennée wrote: > > The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f: > > Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging > (2024-03-09 20:12:21 +) > > are available in the Git repository at: > >

[PULL 2/4] target/i386: Fix query-cpu-model-expansion to reject props

2024-03-12 Thread Markus Armbruster
CpuModelInfo member @props is semantically a mapping from name to value, and syntactically a JSON object on the wire. This translates to QDict in C. Since the QAPI schema language lacks the means to express 'object', we use 'any' instead. This is QObject in C. Commands taking a CpuModelInfo

[PULL 3/4] target: Improve error reporting for CpuModelInfo member @props

2024-03-12 Thread Markus Armbruster
query-cpu-model-comparison, query-cpu-model-baseline, and query-cpu-model-expansion take CpuModelInfo arguments. Errors in @props members of these arguments are reported for 'props', without further context. For instance, s390x rejects {"execute": "query-cpu-model-comparison", "arguments":

[PULL 1/4] target: Simplify type checks for CpuModelInfo member @props

2024-03-12 Thread Markus Armbruster
CpuModelInfo member @props is semantically a mapping from name to value, and syntactically a JSON object on the wire. This translates to QDict in C. Since the QAPI schema language lacks the means to express 'object', we use 'any' instead. This is QObject in C. Commands taking a CpuModelInfo

[PULL 0/4] Error reporting patches for 2024-03-12

2024-03-12 Thread Markus Armbruster
The following changes since commit 05ec974671200814fa5c1d5db710e0e4b88a40af: Merge tag 'm68k-for-9.0-pull-request' of https://github.com/vivier/qemu-m68k into staging (2024-03-11 18:42:53 +) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git

[PULL 4/4] target/loongarch: Fix query-cpu-model-expansion to reject props

2024-03-12 Thread Markus Armbruster
query-cpu-model-expansion takes a CpuModelInfo argument. The loongarch version of the command silently ignores the argument's member @props. For instance, {"execute": "query-cpu-model-expansion", "arguments": {"type": "static", "model": {"name": "la464", "props": null}}} and

Re: [PATCH] MAINTAINERS: Remove myself as reviewer from PPC

2024-03-12 Thread Nicholas Piggin
On Tue Feb 20, 2024 at 6:09 PM AEST, Cédric Le Goater wrote: > PPC maintainership has been a side activity for the last 2 years and > it is time to let go some of it now that Nick has taken over. Reviewed-by: Nicholas Piggin > > Signed-off-by: Cédric Le Goater > --- > MAINTAINERS | 3 --- > 1

<    1   2   3   4   5   6   7   >