Re: [PATCH] target/i386/translate.c: always write 32-bits for SGDT and SIDT

2024-04-25 Thread Paolo Bonzini
On Tue, Apr 23, 2024 at 10:42 PM Mark Cave-Ayland wrote: > > Let's change "Despite claims to the contrary" with "Despite a > > confusing description". > > Thanks for sorting this, Paolo. I suspect that KVM needs a similar patch as > per >

Re: [PATCH 1/6] migration: Remove 'skipped' field from MigrationStats

2024-04-25 Thread Markus Armbruster
Fabiano Rosas writes: > The 'skipped' field of the MigrationStats struct has been deprecated > in 8.1. Time to remove it. > > Deprecation commit 7b24d32634 ("migration: skipped field is really > obsolete."). > > Signed-off-by: Fabiano Rosas > --- > docs/about/deprecated.rst | 6 -- >

Re: [PULL v2 00/63] First batch of i386 and build system patch for QEMU 9.1

2024-04-25 Thread Paolo Bonzini
On Wed, Apr 24, 2024 at 8:49 PM Richard Henderson wrote: > > On 4/24/24 01:14, Paolo Bonzini wrote: > > The following changes since commit 62dbe54c24dbf77051bafe1039c31ddc8f37602d: > > > >Update version for v9.0.0-rc4 release (2024-04-16 18:06:15 +0100) > > > > are available in the Git

Re: [PATCH v3 4/4] qapi: introduce exit-on-error parameter for migrate-incoming

2024-04-25 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Now we do set MIGRATION_FAILED state, but don't give a chance to > orchestrator to query migration state and get the error. > > Let's provide a possibility for QMP-based orchestrators to get an error > like with outgoing migration. > > For

Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Thomas Huth
On 25/04/2024 22.56, Philippe Mathieu-Daudé wrote: Hi Thomas, On 25/4/24 20:43, Thomas Huth wrote: For downstream versions of QEMU, we'd like to be able to compile QEMU without the FDC code included (since it's not required for modern VMs anymore and the FDC code has rather a bad reputation,

Re: [PATCH v2] hw/mem/cxl_type3: reset dvsecs in ct3d_reset()

2024-04-25 Thread Zhijian Li (Fujitsu)
ping On 11/04/2024 18:18, Jonathan Cameron wrote: > On Tue, 9 Apr 2024 15:58:46 +0800 > Li Zhijian wrote: > >> After the kernel commit >> 0cab68720598 ("cxl/pci: Fix disabling memory if DVSEC CXL Range does not >> match a CFMWS window") >> CXL type3 devices cannot be enabled again after the

RE: [PATCH v2 3/5] intel_iommu: Add a framework to do compatibility check with host IOMMU cap/ecap

2024-04-25 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v2 3/5] intel_iommu: Add a framework to do >compatibility check with host IOMMU cap/ecap > >On 4/25/24 10:46, Duan, Zhenzhong wrote: >> Hi Cédric, >> >>> -Original Message- >>> From: Cédric Le Goater >>> Subject:

Re: [PULL 00/22] Misc HW patches for 2024-04-25

2024-04-25 Thread Richard Henderson
://github.com/philmd/qemu.git tags/hw-misc-20240425 for you to fetch changes up to 098de99aad1aa911b4950b47b55d2e2bcc4f9c0c: hw/core: Support module-id in numa configuration (2024-04-25 12:48:12 +0200) 2 checkpatch issues: - one spurious: WARNING: added, moved or deleted file(s), does MAINTAINERS

Re: [PATCH for-9.1 v3 1/2] target/riscv/debug: set tval=pc in breakpoint exceptions

2024-04-25 Thread LIU Zhiwei
On 2024/4/17 7:04, Daniel Henrique Barboza wrote: We're not setting (s/m)tval when triggering breakpoints of type 2 (mcontrol) and 6 (mcontrol6). According to the debug spec section 5.7.12, "Match Control Type 6": "The Privileged Spec says that breakpoint exceptions that occur on instruction

Re: [PATCH for-9.1 v3 2/2] trans_privileged.c.inc: set (m|s)tval on ebreak breakpoint

2024-04-25 Thread LIU Zhiwei
On 2024/4/17 7:04, Daniel Henrique Barboza wrote: Privileged spec section 4.1.9 mentions: "When a trap is taken into S-mode, stval is written with exception-specific information to assist software in handling the trap. (...) If stval is written with a nonzero value when a breakpoint,

[PATCH] ui/gtk: Draw guest frame at refresh cycle

2024-04-25 Thread dongwon . kim
From: Dongwon Kim Draw routine needs to be manually invoked in the next refresh if there is a scanout blob from the guest. This is to prevent a situation where there is a scheduled draw event but it won't happen bacause the window is currently in inactive state (minimized or tabified). If draw

Re: [PATCH] tests/avocado: update sunxi kernel from armbian to 6.6.16

2024-04-25 Thread Strahinja Jankovic
Hi Peter, I ran the avocado tests and this patch looks good to me. The only comment I have would be that the `test_arm-Orangepi_bionic_20_08` is not executed anymore since the image is not available, but I guess that can be another patch. On Thu, Apr 25, 2024 at 9:31 PM Peter Maydell wrote:

Re: [PATCH v4 04/14] util/dsa: Implement DSA task enqueue and dequeue.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > * Use a safe thread queue for DSA task enqueue/dequeue. > * Implement DSA task submission. > * Implement DSA batch task submission. > > Signed-off-by: Hao Xiang > --- > include/qemu/dsa.h | 28 +++ > util/dsa.c | 201

[PULL 2/2] nbd/server: Mark negotiation functions as coroutine_fn

2024-04-25 Thread Eric Blake
nbd_negotiate() is already marked coroutine_fn. And given the fix in the previous patch to have nbd_negotiate_handle_starttls not create and wait on a g_main_loop (as that would violate coroutine constraints), it is worth marking the rest of the related static functions reachable only during

[PULL 1/2] nbd/server: do not poll within a coroutine context

2024-04-25 Thread Eric Blake
From: Zhu Yangyang Coroutines are not supposed to block. Instead, they should yield. The client performs TLS upgrade outside of an AIOContext, during synchronous handshake; this still requires g_main_loop. But the server responds to TLS upgrade inside a coroutine, so a nested g_main_loop is

[PULL 0/2] NBD patches for 2024-04-25

2024-04-25 Thread Eric Blake
The following changes since commit 5da72194df36535d773c8bdc951529ecd5e31707: Merge tag 'pull-tcg-20240424' of https://gitlab.com/rth7680/qemu into staging (2024-04-24 15:51:49 -0700) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2024-04-25 for you

Re: [PATCH v4 03/14] util/dsa: Implement DSA device start and stop logic.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > * DSA device open and close. > * DSA group contains multiple DSA devices. > * DSA group configure/start/stop/clean. > > Signed-off-by: Hao Xiang > Signed-off-by: Bryan Zhang > --- > include/qemu/dsa.h | 72 +++ > util/dsa.c | 316

Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Philippe Mathieu-Daudé
Hi Thomas, On 25/4/24 20:43, Thomas Huth wrote: For downstream versions of QEMU, we'd like to be able to compile QEMU without the FDC code included (since it's not required for modern VMs anymore and the FDC code has rather a bad reputation, see the VENOM CVE). IIRC you still need to keep the

Re: [PATCH v4 04/14] util/dsa: Implement DSA task enqueue and dequeue.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > * Use a safe thread queue for DSA task enqueue/dequeue. > * Implement DSA task submission. > * Implement DSA batch task submission. > > Signed-off-by: Hao Xiang > --- > include/qemu/dsa.h | 28 +++ > util/dsa.c | 201

Re: [PATCH v4 02/14] util/dsa: Add dependency idxd.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > Idxd is the device driver for DSA (Intel Data Streaming > Accelerator). The driver is fully functioning since Linux > kernel 5.19. This change adds the driver's header file used > for userspace development. Have you looked at the update-linux-headers script?

Re: [PATCH v3 4/4] qapi: introduce exit-on-error parameter for migrate-incoming

2024-04-25 Thread Fabiano Rosas
Vladimir Sementsov-Ogievskiy writes: > Now we do set MIGRATION_FAILED state, but don't give a chance to > orchestrator to query migration state and get the error. > > Let's provide a possibility for QMP-based orchestrators to get an error > like with outgoing migration. > > For

Re: [PATCH v3 3/4] migration: process_incoming_migration_co(): rework error reporting

2024-04-25 Thread Fabiano Rosas
Vladimir Sementsov-Ogievskiy writes: > Unify error reporting in the function. This simplifies the following > commit, which will not-exit-on-error behavior variant to the function. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas

Re: [PATCH v3 2/4] migration: process_incoming_migration_co(): complete cleanup on failure

2024-04-25 Thread Fabiano Rosas
Vladimir Sementsov-Ogievskiy writes: > Make call to migration_incoming_state_destroy(), instead of doing only > partial of it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas

Re: [PATCH v3 1/4] migration: move trace-point from migrate_fd_error to migrate_set_error

2024-04-25 Thread Fabiano Rosas
Vladimir Sementsov-Ogievskiy writes: > Cover more cases by trace-point. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas

Re: [PATCH] tests/avocado: update sunxi kernel from armbian to 6.6.16

2024-04-25 Thread Peter Maydell
Whoops, forgot to cc the allwinner maintainers/reviewers on this. Ping for review, please? thanks -- PMM On Mon, 15 Apr 2024 at 16:18, Peter Maydell wrote: > > The Linux kernel 5.10.16 binary for sunxi has been removed from > apt.armbian.com. This means that the avocado tests for these machines

Re: [PATCH] fix bit fields extraction and prevent overflow

2024-04-25 Thread Peter Maydell
On Wed, 24 Apr 2024 at 19:13, Alexandra Diupina wrote: > > Add a type cast and use extract64() instead of extract32() > to avoid integer overflow on addition. Fix bit fields > extraction according to documentation. The commit message here says we make the handling of the address_extension fields

Re: [PATCH] target/arm: Restrict translation disabled alignment check to VMSA

2024-04-25 Thread Peter Maydell
On Mon, 22 Apr 2024 at 18:07, Richard Henderson wrote: > > For cpus using PMSA, when the MPU is disabled, the default memory > type is Normal, Non-cachable. > > Fixes: 59754f85ed3 ("target/arm: Do memory type alignment check when > translation disabled") > Reported-by: Clément Chigot >

Re: [PATCH] hvf: arm: Remove PL1_WRITE_MASK

2024-04-25 Thread Peter Maydell
On Mon, 22 Apr 2024 at 10:27, Zenghui Yu wrote: > > As it had never been used since the first commit a1477da3ddeb ("hvf: Add > Apple Silicon support"). > > Signed-off-by: Zenghui Yu > --- > target/arm/hvf/hvf.c | 1 - Applied to target-arm.next, thanks. -- PMM

Re: [PATCH] hw/core/clock: remove assert in clock_propagate

2024-04-25 Thread Peter Maydell
On Fri, 19 Apr 2024 at 17:30, Raphael Poggi wrote: > > This commit allows childs clock to propagate their new frequency, > for example, after setting a new multiplier/diviser. > > Signed-off-by: Raphael Poggi Applied to target-arm.next, thanks. I rewrote the commit message to document the

Re: [PATCH v4 01/14] meson: Introduce new instruction set enqcmd to the build system.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > Enable instruction set enqcmd in build. > > Signed-off-by: Hao Xiang > --- > meson.build | 14 ++ > meson_options.txt | 2 ++ > scripts/meson-buildoptions.sh | 3 +++ > 3 files changed, 19 insertions(+) > > diff --git

[PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Thomas Huth
For downstream versions of QEMU, we'd like to be able to compile QEMU without the FDC code included (since it's not required for modern VMs anymore and the FDC code has rather a bad reputation, see the VENOM CVE). The q35 machine can already be instantiated without FDC, but for being able to link

[PATCH 2/3] hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA

2024-04-25 Thread Thomas Huth
The q35 machine can be used without floppy disk controller (FDC), but due to our current Kconfig setup, the FDC code is still always included in the binary. To fix this, the "PC" config option should only imply the "FDC_ISA" instead of always selecting it. The i440fx and the isa-pc machine

[PATCH 1/3] hw/i386/pc: Allow to compile without CONFIG_FDC_ISA

2024-04-25 Thread Thomas Huth
The q35 machine can work without FDC. But to be able to also link a QEMU binary that does not include the FDC code, we have to make it possible to disable the spots that call into the FDC code. Signed-off-by: Thomas Huth --- hw/i386/pc.c | 13 + 1 file changed, 9 insertions(+), 4

[RFC PATCH 3/3] hw/i386: Add the possibility to use i440fx and isapc without FDC

2024-04-25 Thread Thomas Huth
The i440fx and the isapc machines can be used in binaries without FDC, too. We just have to make sure that they don't try to instantiate the FDC when it is not available. Signed-off-by: Thomas Huth --- hw/i386/pc_piix.c | 6 -- hw/i386/Kconfig | 2 -- 2 files changed, 4 insertions(+), 4

[PATCH v3 4/4] qapi: introduce exit-on-error parameter for migrate-incoming

2024-04-25 Thread Vladimir Sementsov-Ogievskiy
Now we do set MIGRATION_FAILED state, but don't give a chance to orchestrator to query migration state and get the error. Let's provide a possibility for QMP-based orchestrators to get an error like with outgoing migration. For hmp_migrate_incoming(), let's enable the new behavior: HMP is not

[PATCH v3 0/4] migration: do not exit on incoming failure

2024-04-25 Thread Vladimir Sementsov-Ogievskiy
Hi all! The series brings an option to not immediately exit on incoming migration failure, giving a possibility to orchestrator to get the error through QAPI and shutdown QEMU by "quit". v3: - don't refactor the whole code around setting migration error, it seems too much and necessary for the

[PATCH v3 1/4] migration: move trace-point from migrate_fd_error to migrate_set_error

2024-04-25 Thread Vladimir Sementsov-Ogievskiy
Cover more cases by trace-point. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 4 +++- migration/trace-events | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index b5af6b5105..2dc6a063e9 100644 ---

[PATCH v3 2/4] migration: process_incoming_migration_co(): complete cleanup on failure

2024-04-25 Thread Vladimir Sementsov-Ogievskiy
Make call to migration_incoming_state_destroy(), instead of doing only partial of it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index

[PATCH v3 3/4] migration: process_incoming_migration_co(): rework error reporting

2024-04-25 Thread Vladimir Sementsov-Ogievskiy
Unify error reporting in the function. This simplifies the following commit, which will not-exit-on-error behavior variant to the function. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff

Re: [RFC 1/2] iova_tree: add an id member to DMAMap

2024-04-25 Thread Si-Wei Liu
On 4/24/2024 12:33 AM, Eugenio Perez Martin wrote: On Wed, Apr 24, 2024 at 12:21 AM Si-Wei Liu wrote: On 4/22/2024 1:49 AM, Eugenio Perez Martin wrote: On Sat, Apr 20, 2024 at 1:50 AM Si-Wei Liu wrote: On 4/19/2024 1:29 AM, Eugenio Perez Martin wrote: On Thu, Apr 18, 2024 at 10:46 PM

Re: [PATCH v2 1/3] cpu-models: add "disable-deprecated-feats" option to cpu model expansion

2024-04-25 Thread Collin Walling
On 4/25/24 02:31, Markus Armbruster wrote: > Collin Walling writes: > >> On 4/24/24 02:19, Markus Armbruster wrote: >>> Collin Walling writes: >>> This optional parameter for query-cpu-model-expansion enables CPU model features flagged as deprecated to appear in the resulting

Re: [PATCH v5 09/13] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-04-25 Thread Ira Weiny
Markus Armbruster wrote: > fan writes: > > > On Wed, Apr 24, 2024 at 03:09:52PM +0200, Markus Armbruster wrote: > >> nifan@gmail.com writes: > >> > >> > From: Fan Ni > >> > > >> > Since fabric manager emulation is not supported yet, the change > >> > implements > >> > the functions to

Re: [PATCH v2 2/3] target/s390x: add support for "disable-deprecated-feats" expansion option

2024-04-25 Thread Collin Walling
On 4/25/24 04:10, David Hildenbrand wrote: > On 24.04.24 20:33, Collin Walling wrote: >> On 4/24/24 03:24, David Hildenbrand wrote: >>> On 23.04.24 23:06, Collin Walling wrote: Retain a list of deprecated features disjoint from any particular CPU model. When a query-cpu-model-expansion

Re: [PATCH v2 1/3] cpu-models: add "disable-deprecated-feats" option to cpu model expansion

2024-04-25 Thread Collin Walling
On 4/25/24 09:35, Daniel P. Berrangé wrote: > On Wed, Apr 24, 2024 at 03:12:42PM -0400, Collin Walling wrote: >> On 4/24/24 13:51, Collin Walling wrote: >>> On 4/24/24 04:20, Daniel P. Berrangé wrote: On Tue, Apr 23, 2024 at 05:06:53PM -0400, Collin Walling wrote: > This optional

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-04-25 Thread Dorjoy Chowdhury
On Mon, Apr 22, 2024 at 5:26 PM Peter Maydell wrote: > > On Mon, 22 Apr 2024 at 11:46, Peter Maydell wrote: > > > > On Sun, 21 Apr 2024 at 06:40, Richard Henderson > > wrote: > > > > --- a/target/arm/cpu.c > > > > +++ b/target/arm/cpu.c > > > > @@ -1314,8 +1314,18 @@ static void

Re: [PULL v2 00/16] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Richard Henderson
On 4/25/24 07:57, Thomas Huth wrote: The following changes since commit 5da72194df36535d773c8bdc951529ecd5e31707: Merge tag 'pull-tcg-20240424' ofhttps://gitlab.com/rth7680/qemu into staging (2024-04-24 15:51:49 -0700) are available in the Git repository at:

Re: [PULL 00/37] target-arm queue

2024-04-25 Thread Richard Henderson
ecd5e31707: Merge tag 'pull-tcg-20240424' ofhttps://gitlab.com/rth7680/qemu into staging (2024-04-24 15:51:49 -0700) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20240425 for you to fetch

Re: [PATCH v3 1/2] cxl/core: correct length of DPA field masks

2024-04-25 Thread Ira Weiny
Shiyang Ruan wrote: > > > 在 2024/4/24 5:04, Ira Weiny 写道: > > Alison Schofield wrote: > >> On Wed, Apr 17, 2024 at 03:50:52PM +0800, Shiyang Ruan wrote: > > > > [snip] > > > >>> diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h > >>> index e5f13260fc52..cdfce932d5b1 100644 > >>>

Re: [PATCH] target/riscv/kvm: implement SBI debug console (DBCN) calls

2024-04-25 Thread Andrew Jones
On Thu, Apr 25, 2024 at 12:50:12PM GMT, Daniel Henrique Barboza wrote: > SBI defines a Debug Console extension "DBCN" that will, in time, replace > the legacy console putchar and getchar SBI extensions. > > The appeal of the DBCN extension is that it allows multiple bytes to be > read/written in

Re: [PATCH v2 1/1] target/riscv/kvm: tolerate KVM disable ext errors

2024-04-25 Thread Andrew Jones
On Mon, Apr 22, 2024 at 02:14:25PM GMT, Daniel Henrique Barboza wrote: > Running a KVM guest using a 6.9-rc3 kernel, in a 6.8 host that has zkr > enabled, will fail with a kernel oops SIGILL right at the start. The > reason is that we can't expose zkr without implementing the SEED CSR. > Disabling

Re: [PATCH v2 4/4] vfio/ccw: Make vfio_ccw_register_irq_notifier() return a bool

2024-04-25 Thread Cédric Le Goater
On 4/25/24 14:55, Eric Farman wrote: On Thu, 2024-04-25 at 12:56 +0200, Markus Armbruster wrote: Cédric Le Goater writes: Since vfio_ccw_register_irq_notifier() takes an 'Error **' argument, best practices suggest to return a bool. See the qapi/error.h Rules section. Signed-off-by: Cédric

[PATCH] target/riscv/kvm: implement SBI debug console (DBCN) calls

2024-04-25 Thread Daniel Henrique Barboza
SBI defines a Debug Console extension "DBCN" that will, in time, replace the legacy console putchar and getchar SBI extensions. The appeal of the DBCN extension is that it allows multiple bytes to be read/written in the SBI console in a single SBI call. As far as KVM goes, the DBCN calls are

[PATCH v9 02/11] virtio-gpu: Support context-init feature with virglrenderer

2024-04-25 Thread Dmitry Osipenko
From: Huang Rui Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init feature flags. Expose this feature and support creating virglrenderer context with flags using context_id if libvirglrenderer is new enough. Originally-by: Antonio Caggiano Signed-off-by: Huang Rui

[PATCH v9 11/11] migration/virtio: Add virtio-gpu section

2024-04-25 Thread Dmitry Osipenko
Document virtio-gpu migration specifics. Suggested-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/devel/migration/virtio.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/devel/migration/virtio.rst b/docs/devel/migration/virtio.rst index 611a18b82151..67f5fcfed196

[PATCH v9 08/11] virtio-gpu: Resource UUID

2024-04-25 Thread Dmitry Osipenko
From: Antonio Caggiano Enable resource UUID feature and implement command resource assign UUID. UUID feature availability is mandatory for Vulkan Venus context. UUID is intended for sharing dmabufs between virtio devices on host. Qemu doesn't have second virtio device for sharing, thus a simple

[PATCH v9 09/11] virtio-gpu: Register capsets dynamically

2024-04-25 Thread Dmitry Osipenko
From: Pierre-Eric Pelloux-Prayer virtio_gpu_virgl_get_num_capsets will return "num_capsets", but we can't assume that capset_index 1 is always VIRGL2 once we'll support more capsets, like Venus and DRM capsets. Register capsets dynamically to avoid that problem. Signed-off-by: Pierre-Eric

[PATCH v9 00/11] Support blob memory and venus on qemu

2024-04-25 Thread Dmitry Osipenko
Hello, This series enables Vulkan Venus context support on virtio-gpu. All virglrender and almost all Linux kernel prerequisite changes needed by Venus are already in upstream. For kernel there is a pending KVM patchset that fixes mapping of compound pages needed for DRM drivers using TTM [1],

[PATCH v9 04/11] virtio-gpu: Add virgl resource management

2024-04-25 Thread Dmitry Osipenko
From: Huang Rui In a preparation to adding host blobs support to virtio-gpu, add virgl resource management that allows to retrieve resource based on its ID and virgl resource wrapper on top of simple resource that will be contain fields specific to virgl. Signed-off-by: Huang Rui Reviewed-by:

[PATCH v9 10/11] virtio-gpu: Support Venus context

2024-04-25 Thread Dmitry Osipenko
From: Antonio Caggiano Request Venus when initializing VirGL and if vulkan=true flag is set for virtio-gpu device. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 2 ++ hw/display/virtio-gpu-virgl.c | 22

[PATCH v9 01/11] virtio-gpu: Use pkgconfig version to decide which virgl features are available

2024-04-25 Thread Dmitry Osipenko
New virglrerenderer features were stabilized with release of v1.0.0. Presence of symbols in virglrenderer.h doesn't guarantee ABI compatibility with pre-release development versions of libvirglerender. Use virglrenderer version to decide reliably which virgl features are available. Signed-off-by:

[PATCH v9 07/11] virtio-gpu: Handle resource blob commands

2024-04-25 Thread Dmitry Osipenko
From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano Signed-off-by: Xenia Ragiadakou

[PATCH v9 05/11] virtio-gpu: Support blob scanout using dmabuf fd

2024-04-25 Thread Dmitry Osipenko
From: Robert Beckett Support displaying blob resources by handling SET_SCANOUT_BLOB command. Signed-by: Antonio Caggiano Signed-off-by: Robert Beckett Signed-off-by: Huang Rui Reviewed-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 109

[PATCH v9 06/11] virtio-gpu: Support suspension of commands processing

2024-04-25 Thread Dmitry Osipenko
Add new "suspended" flag to virtio_gpu_ctrl_command telling cmd processor that it should stop processing commands and retry again next time until flag is unset. Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 1 + hw/display/virtio-gpu-rutabaga.c | 1 +

[PATCH v9 03/11] virtio-gpu: Don't require udmabuf when blobs and virgl are enabled

2024-04-25 Thread Dmitry Osipenko
The udmabuf usage is mandatory when virgl is disabled and blobs feature enabled in the Qemu machine configuration. If virgl and blobs are enabled, then udmabuf requirement is optional. Since udmabuf isn't widely supported by a popular Linux distros today, let's relax the udmabuf requirement for

Re: [PATCH] ci: move external build environment setups to CentOS Stream 9

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 05:03:43PM +0200, Thomas Huth wrote: > On 12/04/2024 12.37, Paolo Bonzini wrote: > > RHEL 9 (and thus also the derivatives) are available since two years > > now, so according to QEMU's support policy, we can drop the active > > support for the previous major version 8 now.

Re: [PATCH v5 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 05:34:52PM +0200, Anthony Harivel wrote: > Hi Daniel, > > Daniel P. Berrangé, Apr 18, 2024 at 18:42: > > > > +if (kvm_is_rapl_feat_enable(cs)) { > > > +if (!IS_INTEL_CPU(env)) { > > > +error_setg(errp, "RAPL feature can only be\ > > > +

Re: [PATCH v4 10/14] migration/multifd: Enable DSA offloading in multifd sender path.

2024-04-25 Thread Fabiano Rosas
Hao Xiang writes: > Multifd sender path gets an array of pages queued by the migration > thread. It performs zero page checking on every page in the array. > The pages are classfied as either a zero page or a normal page. This > change uses Intel DSA to offload the zero page checking from CPU to

Re: [PATCH v5 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-04-25 Thread Anthony Harivel
Hi Daniel, Daniel P. Berrangé, Apr 18, 2024 at 18:42: > > +if (kvm_is_rapl_feat_enable(cs)) { > > +if (!IS_INTEL_CPU(env)) { > > +error_setg(errp, "RAPL feature can only be\ > > + enabled with Intel CPU models"); > > +return

Re: [PATCH v3] fix endianness bug

2024-04-25 Thread Richard Henderson
On 4/25/24 06:41, Alexandra Diupina wrote: +static MemTxResult xlnx_dpdma_read_descriptor(XlnxDPDMAState *s, +uint64_t desc_addr, DPDMADescriptor *desc) +{ +if (dma_memory_read(_space_memory, desc_addr, , +

Re: [PATCH v2 4/7] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean

2024-04-25 Thread Thomas Huth
On 25/04/2024 05.12, Zhao Liu wrote: As error.h suggested, the best practice for callee is to return something to indicate success / failure. So make kvm_s390_get_host_cpu_model() return boolean and check the returned boolean in get_max_cpu_model() instead of accessing @err. Signed-off-by:

Re: [PATCH for-9.1 09/19] target/i386: move 60-BF opcodes to new decoder

2024-04-25 Thread Zhao Liu
On Wed, Apr 24, 2024 at 01:13:01PM +0200, Paolo Bonzini wrote: > Date: Wed, 24 Apr 2024 13:13:01 +0200 > From: Paolo Bonzini > Subject: Re: [PATCH for-9.1 09/19] target/i386: move 60-BF opcodes to new > decoder > > On Thu, Apr 11, 2024 at 5:05 PM Zhao Liu wrote: > > HMM, I met Guest boot

Re: [PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Thomas Huth
On 25/04/2024 17.04, Richard Henderson wrote: On 4/24/24 22:11, Thomas Huth wrote: On 24/04/2024 18.21, Richard Henderson wrote: On 4/24/24 00:57, Thomas Huth wrote: The following changes since commit 13b1e9667737132440f4d500c31cb69320c6b15a:    Merge tag 'for-upstream' of

[PATCH 1/6] migration: Remove 'skipped' field from MigrationStats

2024-04-25 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 6

[PATCH 4/6] migration: Remove block migration

2024-04-25 Thread Fabiano Rosas
The block migration has been considered obsolete since QEMU 8.2 in favor of the more flexible storage migration provided by the blockdev-mirror driver. Two releases have passed so now it's time to remove it. Deprecation commit 66db46ca83 ("migration: Deprecate block migration"). Signed-off-by:

[PATCH 5/6] migration: Remove non-multifd compression

2024-04-25 Thread Fabiano Rosas
The 'compress' migration capability enables the old compression code which has shown issues over the years and is thought to be less stable and tested than the more recent multifd-based compression. The old compression code has been deprecated in 8.2 and now is time to remove it. Deprecation

[PATCH 2/6] migration: Remove 'inc' option from migrate command

2024-04-25 Thread Fabiano Rosas
The block incremental option for block migration has been deprecated in 8.2 in favor of using the block-mirror feature. Remove it now. Deprecation commit 40101f320d ("migration: migrate 'inc' command option is deprecated."). Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 9

[PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-25 Thread Fabiano Rosas
The block migration is considered obsolete and has been deprecated in 8.2. Remove the migrate command option that enables it. This only affects the QMP and HMP commands, the feature can still be accessed by setting the migration 'block' capability. The whole feature will be removed in a future

[PATCH 6/6] migration: Deprecate fd: for file migration

2024-04-25 Thread Fabiano Rosas
The fd: URI can currently trigger two different types of migration, a TCP migration using sockets and a file migration using a plain file. This is in conflict with the recently introduced (8.2) QMP migrate API that takes structured data as JSON-like format. We cannot keep the same backend for both

[PATCH 0/6] migration removals & deprecations

2024-04-25 Thread Fabiano Rosas
Hi everyone, Here's some cleaning up of deprecated code. It removes the old block migration and compression code. Both have suitable replacements in the form of the blockdev-mirror driver and multifd compression, respectively. There's also a deprecation for fd: + file to cope with the fact that

Re: [PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Richard Henderson
On 4/24/24 22:11, Thomas Huth wrote: On 24/04/2024 18.21, Richard Henderson wrote: On 4/24/24 00:57, Thomas Huth wrote: The following changes since commit 13b1e9667737132440f4d500c31cb69320c6b15a:    Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-04-23

Re: [PATCH] ci: move external build environment setups to CentOS Stream 9

2024-04-25 Thread Thomas Huth
On 12/04/2024 12.37, Paolo Bonzini wrote: RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus upgrade our CentOS Stream build environment playbooks to major

[PULL v2 00/16] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Thomas Huth
The following changes since commit 5da72194df36535d773c8bdc951529ecd5e31707: Merge tag 'pull-tcg-20240424' of https://gitlab.com/rth7680/qemu into staging (2024-04-24 15:51:49 -0700) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-04-25 for

Re: [PATCH v4 03/14] util/dsa: Implement DSA device start and stop logic.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:06AM +, Hao Xiang wrote: > * DSA device open and close. > * DSA group contains multiple DSA devices. > * DSA group configure/start/stop/clean. > > Signed-off-by: Hao Xiang > Signed-off-by: Bryan Zhang > --- > include/qemu/dsa.h | 72 +++ > util/dsa.c

Re: [PATCH v4 10/14] migration/multifd: Enable DSA offloading in multifd sender path.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:13AM +, Hao Xiang wrote: > Multifd sender path gets an array of pages queued by the migration > thread. It performs zero page checking on every page in the array. > The pages are classfied as either a zero page or a normal page. This > change uses Intel DSA to

Re: [PATCH v4 03/14] util/dsa: Implement DSA device start and stop logic.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:06AM +, Hao Xiang wrote: > * DSA device open and close. > * DSA group contains multiple DSA devices. > * DSA group configure/start/stop/clean. > > Signed-off-by: Hao Xiang > Signed-off-by: Bryan Zhang > --- > include/qemu/dsa.h | 72 +++ > util/dsa.c

Re: [PATCH v4 03/14] util/dsa: Implement DSA device start and stop logic.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:06AM +, Hao Xiang wrote: > * DSA device open and close. > * DSA group contains multiple DSA devices. > * DSA group configure/start/stop/clean. > > Signed-off-by: Hao Xiang > Signed-off-by: Bryan Zhang > --- > include/qemu/dsa.h | 72 +++ > util/dsa.c

Re: [PATCH v4 08/14] migration/multifd: Add new migration option for multifd DSA offloading.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:11AM +, Hao Xiang wrote: > Intel DSA offloading is an optional feature that turns on if > proper hardware and software stack is available. To turn on > DSA offloading in multifd live migration: > > multifd-dsa-accel="[dsa_dev_path1] [dsa_dev_path2] ...

[PATCH v3] fix endianness bug

2024-04-25 Thread Alexandra Diupina
Add xlnx_dpdma_read_descriptor() and xlnx_dpdma_write_descriptor() functions. xlnx_dpdma_read_descriptor() combines reading a descriptor from desc_addr by calling dma_memory_read() and swapping the desc fields from guest memory order to host memory order. xlnx_dpdma_write_descriptor() performs

[PATCH] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-04-25 Thread Daniil Tatianin
This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Signed-off-by: Daniil Tatianin --- hw/rtc/mc146818rtc.c | 15 +++ include/hw/rtc/mc146818rtc.h | 1 + qapi/misc-target.json| 16

Re: [PATCH v2 1/3] cpu-models: add "disable-deprecated-feats" option to cpu model expansion

2024-04-25 Thread Daniel P . Berrangé
On Wed, Apr 24, 2024 at 03:12:42PM -0400, Collin Walling wrote: > On 4/24/24 13:51, Collin Walling wrote: > > On 4/24/24 04:20, Daniel P. Berrangé wrote: > >> On Tue, Apr 23, 2024 at 05:06:53PM -0400, Collin Walling wrote: > >>> This optional parameter for query-cpu-model-expansion enables CPU >

Re: Timeouts in CI jobs

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:27:17PM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 24, 2024 at 08:10:19PM +0200, Stefan Weil wrote: > > > > I did not run tests in my GitLab fork because I still have to figure out how > > to do that. > > It is quite simple: > > git remote add gitlab

Re: [PATCH] migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro

2024-04-25 Thread Vilhelm Gyda
Yes, yes. The list will always be cc'd. I found your email after I had already sent on the list, so I omitted the list when I sent it to you. Thanks for the suggestion for further contribution. I am looking at them On Thu, Apr 25, 2024 at 6:45 PM Peter Xu wrote: > > On Thu, Apr 25, 2024 at

Re: Timeouts in CI jobs

2024-04-25 Thread Daniel P . Berrangé
On Wed, Apr 24, 2024 at 08:10:19PM +0200, Stefan Weil wrote: > Am 24.04.24 um 19:09 schrieb Daniel P. Berrangé: > > > On Wed, Apr 24, 2024 at 06:27:58PM +0200, Stefan Weil via wrote: > > > I think the timeouts are caused by running too many parallel processes > > > during testing. > > > > > >

Re: [PATCH for-9.1 0/7] target/i386/kvm: Cleanup the kvmclock feature name

2024-04-25 Thread Zhao Liu
On Thu, Apr 25, 2024 at 08:04:46PM +0800, Xiaoyao Li wrote: > Date: Thu, 25 Apr 2024 20:04:46 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH for-9.1 0/7] target/i386/kvm: Cleanup the kvmclock > feature name > > On 4/25/2024 6:29 PM, Zhao Liu wrote: > > On Thu, Apr 25, 2024 at 04:40:10PM +0800,

Re: [PATCH v11 00/21] i386: Introduce smp.modules and clean up cache topology

2024-04-25 Thread Zhao Liu
On Thu, Apr 25, 2024 at 10:06:11AM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 25 Apr 2024 10:06:11 +0200 > From: Philippe Mathieu-Daudé > Subject: Re: [PATCH v11 00/21] i386: Introduce smp.modules and clean up > cache topology > > Hi Zhao, > > On 24/4/24 17:49, Zhao Liu wrote: > > >

Re: [PATCH] migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro

2024-04-25 Thread Peter Xu
On Thu, Apr 25, 2024 at 09:10:34AM -0400, Peter Xu wrote: > Hi, And I just noticed you didn't copy the list, please normally keep copying the list in replies. So before below links, you can also read this first just in case you still miss some:

Re: [PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Apr 25, 2024 at 07:11:41AM +0200, Thomas Huth wrote: >> On 24/04/2024 18.21, Richard Henderson wrote: >> > On 4/24/24 00:57, Thomas Huth wrote: >> > > The following changes since commit >> > > 13b1e9667737132440f4d500c31cb69320c6b15a: >> > > >> > >    Merge

Re: [PATCH v2 4/4] vfio/ccw: Make vfio_ccw_register_irq_notifier() return a bool

2024-04-25 Thread Eric Farman
On Thu, 2024-04-25 at 12:56 +0200, Markus Armbruster wrote: > Cédric Le Goater writes: > > > Since vfio_ccw_register_irq_notifier() takes an 'Error **' > > argument, > > best practices suggest to return a bool. See the qapi/error.h Rules > > section. > > > > Signed-off-by: Cédric Le Goater > >

Re: [PATCH v2 3/5] intel_iommu: Add a framework to do compatibility check with host IOMMU cap/ecap

2024-04-25 Thread Cédric Le Goater
On 4/25/24 10:46, Duan, Zhenzhong wrote: Hi Cédric, -Original Message- From: Cédric Le Goater Subject: Re: [PATCH v2 3/5] intel_iommu: Add a framework to do compatibility check with host IOMMU cap/ecap Hello Zhenzhong, On 4/18/24 10:42, Duan, Zhenzhong wrote: Hi Cédric,

Re: [PATCH v2 3/4] vfio/ccw: Use g_autofree variable in vfio_ccw_register_irq_notifier()

2024-04-25 Thread Eric Farman
On Thu, 2024-04-25 at 11:02 +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- >  hw/vfio/ccw.c | 9 +++-- >  1 file changed, 3 insertions(+), 6 deletions(-) I realize this was just split out of v1, but probably need a commit description here. Regardless, Reviewed-by:

  1   2   3   >