Re: [PATCH 3/3] vfio/migration: Don't emit STOP_COPY state change event twice

2024-05-06 Thread Avihai Horon
On 06/05/2024 17:39, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello Avihai, On 4/30/24 07:16, Avihai Horon wrote: When migrating a VFIO device that supports pre-copy, it is transitioned to STOP_COPY twice: once in vfio_vmstate_change() and second

Re: [PATCH v8 0/5] Support message-based DMA in vfio-user server

2024-05-06 Thread Stefan Hajnoczi
On Thu, 28 Mar 2024 at 03:54, Mattias Nissler wrote: > > Stefan, to the best of my knowledge this is fully reviewed and ready > to go in - can you kindly pick it up or advise in case there's > something I missed? Thanks! This code is outside the areas that I maintain. I think it would make sense

Re: [PULL 00/12] qemu-sparc queue 20240506

2024-05-06 Thread Michael Tokarev
06.05.2024 14:44, Mark Cave-Ayland wrote: Mark Cave-Ayland (1): hw/sparc64: set iommu_platform=on for virtio devices attached to the sun4u machine Richard Henderson (7): linux-user/sparc: Add more hwcap bits for sparc64 target/sparc: Fix FEXPAND target/sparc: Fix

Re: [PATCH v8 0/5] Support message-based DMA in vfio-user server

2024-05-06 Thread Peter Xu
On Thu, Mar 28, 2024 at 08:53:36AM +0100, Mattias Nissler wrote: > Stefan, to the best of my knowledge this is fully reviewed and ready > to go in - can you kindly pick it up or advise in case there's > something I missed? Thanks! Fails cross-compile on mipsel:

Re: [PATCH 3/3] vfio/migration: Don't emit STOP_COPY state change event twice

2024-05-06 Thread Cédric Le Goater
Hello Avihai, On 4/30/24 07:16, Avihai Horon wrote: When migrating a VFIO device that supports pre-copy, it is transitioned to STOP_COPY twice: once in vfio_vmstate_change() and second time in vfio_save_complete_precopy(). The second transition is harmless, as it's a STOP_COPY->STOP_COPY no-op

Re: [PATCH 2/3] vfio/migration: Emit VFIO device migration state change QAPI event

2024-05-06 Thread Fabiano Rosas
Markus Armbruster writes: > Peter, Fabiano, I'd like to hear your opinion on the issue discussed > below. > > Avihai Horon writes: > >> On 02/05/2024 13:22, Joao Martins wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> On 01/05/2024 13:28, Avihai Horon wrote:

Re: [PATCH v4 00/22] hw/i386: Remove deprecated pc-i440fx-2.0 -> 2.3 machines

2024-05-06 Thread Philippe Mathieu-Daudé
On 16/4/24 20:59, Philippe Mathieu-Daudé wrote: Series fully reviewed. Ping, is there some issue holding this series? Philippe Mathieu-Daudé (22): hw/i386/pc: Deprecate 2.4 to 2.12 pc-i440fx machines hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine hw/usb/hcd-xhci: Remove

Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-05-06 Thread Philippe Mathieu-Daudé
On 25/4/24 20:43, Thomas Huth wrote: Thomas Huth (3): hw/i386/pc: Allow to compile without CONFIG_FDC_ISA hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA hw/i386: Add the possibility to use i440fx and isapc without FDC Series: Acked-by: Philippe Mathieu-Daudé

Re: [PATCH 1/3] hw/i386/pc: Allow to compile without CONFIG_FDC_ISA

2024-05-06 Thread Philippe Mathieu-Daudé
Hi Thomas, On 25/4/24 20:43, Thomas Huth wrote: The q35 machine can work without FDC. But to be able to also link a QEMU binary that does not include the FDC code, we have to make it possible to disable the spots that call into the FDC code. Signed-off-by: Thomas Huth --- hw/i386/pc.c | 13

Re: [PATCH v2 5/7] target/sparc: Fix FMULD8*X16

2024-05-06 Thread Philippe Mathieu-Daudé
On 2/5/24 18:55, Richard Henderson wrote: Not only do these instructions have f32 inputs, they also do not perform rounding. Since these are relatively simple, implement them properly inline. Signed-off-by: Richard Henderson --- target/sparc/helper.h | 2 -- target/sparc/translate.c

Re: [PATCH v2] MAINTAINERS: Update my email address

2024-05-06 Thread Philippe Mathieu-Daudé
On 5/5/24 09:23, Bin Meng wrote: From: Bin Meng The old Wind River email address (bin.m...@windriver.com) is no longer available due to an internal infrastructure change within the company. While a new email address (bin.meng...@windriver.com) has been assigned to me, I am unable to find a way

Re: [PATCH] MAINTAINERS: Update Aleksandar Rikalo email

2024-05-06 Thread Philippe Mathieu-Daudé
On 6/5/24 08:13, Markus Armbruster wrote: Looks like this fell through the cracks. As far as I can tell, the patch did come from @syrmia.com. Cc'ing qemu-trivial. Aleksandar Rikalo writes: Syrmia LLC has been acquired recently and the syrmia.com domain will disappear soon, so updating my

Re: [PATCH v4 14/17] xen: Add xen_mr_is_memory()

2024-05-06 Thread Edgar E. Iglesias
On Mon, May 6, 2024 at 11:59 AM Philippe Mathieu-Daudé wrote: > > On 2/5/24 09:26, David Hildenbrand wrote: > > On 30.04.24 18:49, Edgar E. Iglesias wrote: > >> From: "Edgar E. Iglesias" > >> > >> Add xen_mr_is_memory() to abstract away tests for the > >> xen_memory MR. > >> > >> Signed-off-by:

RE: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-06 Thread Gonglei (Arei)
Hi, Peter RDMA features high bandwidth, low latency (in non-blocking lossless network), and direct remote memory access by bypassing the CPU (As you know, CPU resources are expensive for cloud vendors, which is one of the reasons why we introduced offload cards.), which TCP does not have.

Re: [PATCH v2] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-05-06 Thread Paolo Bonzini
On Mon, May 6, 2024 at 1:21 PM Thomas Huth wrote: > > The old "-runas" option has the disadvantage that it is not visible > in the QAPI schema, so it is not available via the normal introspection > mechanisms. We've recently introduced the "-run-with" option for exactly > this purpose, which is

Re: [PATCH v2 11/15] hw/riscv/riscv-iommu: add DBG support

2024-05-06 Thread Daniel Henrique Barboza
Hi Frank, On 5/6/24 01:09, Frank Chang wrote: Hi Daniel, Daniel Henrique Barboza 於 2024年3月8日 週五 上午12:05寫道: From: Tomasz Jeznach DBG support adds three additional registers: tr_req_iova, tr_req_ctl and tr_response. The DBG cap is always enabled. No on/off toggle is provided for it.

Re: [PATCH 5/7] qapi: Drop "Returns" section where default is fine WIP

2024-05-06 Thread Markus Armbruster
Sent by accident, please ignore.

Re: [PATCH 7/7] find untagged sections WIP

2024-05-06 Thread Markus Armbruster
Sent by accident, please ignore.

Re: [PATCH 1/7] qapi: make since sections special WIP

2024-05-06 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 6/5/24 13:02, Markus Armbruster wrote: >> since moves to end in generated output >> --- >> docs/sphinx/qapidoc.py | 22 +- >> scripts/qapi/parser.py | 5 +++-- >> tests/qapi-schema/test-qapi.py | 2 ++ >> 3 files

Re: [PATCH 6/7] qga/qapi-schema: Drop "Returns" section where default is fine WIP

2024-05-06 Thread Markus Armbruster
Sent by accident, please ignore.

Re: [PATCH 4/7] qapidoc: Generate default Returns WIP

2024-05-06 Thread Markus Armbruster
Sent by accident, please ignore.

Re: [PATCH 2/7] sphinx/qapidoc: Tweak "Since" section formatting WIP

2024-05-06 Thread Markus Armbruster
Sent by accident, please ignore.

Re: [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw]

2024-05-06 Thread Michael Tokarev
06.05.2024 15:38, Yoshinori Sato wrote: [...] Does this mean you changed it like this? I think this is fine. Yes, the main part is exactly like this, and there's no questions here. My question was more about was the testsuite changes which comes with the same patch, and parts of the Makefile

Re: [PATCH 3/7] qapi: make returns sections special WIP

2024-05-06 Thread Markus Armbruster
Sent by accident, please ignore.

Re: [PATCH 1/7] qapi: make since sections special WIP

2024-05-06 Thread Markus Armbruster
Markus Armbruster writes: > since moves to end in generated output Sent by accident, please ignore.

Re: [PULL 00/28] Accelerator patches for 2024-05-06

2024-05-06 Thread Philippe Mathieu-Daudé
://github.com/philmd/qemu.git tags/accel-next-20240506 The tag is 'accel-20240506'. for you to fetch changes up to c984d1d8916df8abac71325a5a135cd851b2106a: MAINTAINERS: Update my email address (2024-05-06 14:33:49 +0200) Accelerator

Re: [PATCH v4] vfio/pci: migration: Skip config space check for Vendor Specific Information in VSC during restore/load

2024-05-06 Thread Cédric Le Goater
On 5/3/24 16:51, Vinayak Kale wrote: In case of migration, during restore operation, qemu checks config space of the pci device with the config space in the migration stream captured during save operation. In case of config space data mismatch, restore operation is failed. config space check is

[PULL 21/28] xen: mapcache: Break out xen_ram_addr_from_mapcache_single

2024-05-06 Thread Philippe Mathieu-Daudé
From: "Edgar E. Iglesias" Break out xen_ram_addr_from_mapcache_single(), a multi-cache aware version of xen_ram_addr_from_mapcache. No functional changes. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini Reviewed-by: Philippe Mathieu-Daudé Message-ID:

[PULL 24/28] xen: mapcache: Break out xen_invalidate_map_cache_single()

2024-05-06 Thread Philippe Mathieu-Daudé
From: "Edgar E. Iglesias" Break out xen_invalidate_map_cache_single(). No functional changes. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240430164939.925307-10-edgar.igles...@gmail.com> Signed-off-by: Philippe

Re: [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw]

2024-05-06 Thread Yoshinori Sato
On Sat, 04 May 2024 17:25:52 +0900, Michael Tokarev wrote: > > 06.04.2024 08:37, Richard Henderson wrote: > > Zack's recent patches, tidied a little bit, and with > > test cases added. > > These fixes ended up in stable-8.2, but not in stable-7.2. > This is because in 7.2, the context is a bit

[PULL 26/28] softmmu: Pass RAM MemoryRegion and is_write in xen_map_cache()

2024-05-06 Thread Philippe Mathieu-Daudé
From: "Edgar E. Iglesias" Propagate MR and is_write to xen_map_cache(). This is in preparation for adding support for grant mappings. No functional change. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini Reviewed-by: Philippe Mathieu-Daudé Acked-by: Peter Xu Reviewed-by:

[PULL 22/28] xen: mapcache: Refactor xen_replace_cache_entry_unlocked

2024-05-06 Thread Philippe Mathieu-Daudé
From: "Edgar E. Iglesias" Add MapCache argument to xen_replace_cache_entry_unlocked in preparation for supporting multiple map caches. No functional change. Signed-off-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240430164939.925307-8-edgar.igles...@gmail.com>

[PULL 25/28] xen: mapcache: Break out xen_map_cache_init_single()

2024-05-06 Thread Philippe Mathieu-Daudé
From: "Edgar E. Iglesias" Break out xen_map_cache_init_single() in preparation for adding multiple map caches. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini Message-ID: <20240430164939.925307-11-edgar.igles...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé ---

[PULL 28/28] MAINTAINERS: Update my email address

2024-05-06 Thread Philippe Mathieu-Daudé
From: Bin Meng The old Wind River email address (bin.m...@windriver.com) is no longer available due to an internal infrastructure change within the company. While a new email address (bin.meng...@windriver.com) has been assigned to me, I am unable to find a way to send this patch directly from

[PULL 27/28] MAINTAINERS: Update Aleksandar Rikalo email

2024-05-06 Thread Philippe Mathieu-Daudé
From: Aleksandar Rikalo Syrmia LLC has been acquired recently and the syrmia.com domain will disappear soon, so updating my email in the MAINTAINERS file. Signed-off-by: Aleksandar Rikalo Message-ID: <20240209062147.62453-1-aleksandar.rik...@syrmia.com> Signed-off-by: Philippe Mathieu-Daudé

[PULL 20/28] xen: mapcache: Refactor xen_remap_bucket for multi-instance

2024-05-06 Thread Philippe Mathieu-Daudé
From: "Edgar E. Iglesias" Add MapCache argument to xen_remap_bucket in preparation to support multiple map caches. No functional changes. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini Reviewed-by: Philippe Mathieu-Daudé Message-ID:

[PULL 23/28] xen: mapcache: Refactor xen_invalidate_map_cache_entry_unlocked

2024-05-06 Thread Philippe Mathieu-Daudé
From: "Edgar E. Iglesias" Add MapCache argument to xen_invalidate_map_cache_entry_unlocked. This is in preparation for supporting multiple map caches. No functional changes. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini Reviewed-by: Philippe Mathieu-Daudé Message-ID:

[PULL 10/28] accel/tcg: Restrict qemu_plugin_vcpu_exit_hook() to TCG plugins

2024-05-06 Thread Philippe Mathieu-Daudé
qemu_plugin_vcpu_exit_hook() is specific to TCG plugins, so must be restricted to it in cpu_common_unrealizefn(), similarly to how qemu_plugin_create_vcpu_state() is restricted in the cpu_common_realizefn() counterpart. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson

[PULL 08/28] accel/tcg: Move user definition of cpu_interrupt() to user-exec.c

2024-05-06 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240428221450.26460-4-phi...@linaro.org> --- accel/tcg/translate-all.c | 9 - accel/tcg/user-exec.c | 8 2 files changed, 8 insertions(+), 9 deletions(-) diff --git

[PULL 19/28] xen: mapcache: Refactor xen_map_cache for multi-instance

2024-05-06 Thread Philippe Mathieu-Daudé
From: "Edgar E. Iglesias" Make xen_map_cache take a MapCache as argument. This is in prepaparation to support multiple map caches. No functional changes. Signed-off-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefano Stabellini Message-ID:

[PULL 15/28] user: Use get_task_state() helper

2024-05-06 Thread Philippe Mathieu-Daudé
Get the TaskState pointer calling get_task_state(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240428221450.26460-11-phi...@linaro.org> --- gdbstub/gdbstub.c | 3 ++- gdbstub/user-target.c | 4 ++-- linux-user/syscall.c | 4 ++-- 3 files changed, 6

[PULL 18/28] xen: mapcache: Refactor lock functions for multi-instance

2024-05-06 Thread Philippe Mathieu-Daudé
From: "Edgar E. Iglesias" Make the lock functions take MapCache * as argument. This is in preparation for supporting multiple caches. No functional changes. Signed-off-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefano Stabellini Message-ID:

[PULL 16/28] softmmu: let qemu_map_ram_ptr() use qemu_ram_ptr_length()

2024-05-06 Thread Philippe Mathieu-Daudé
From: Juergen Gross qemu_map_ram_ptr() and qemu_ram_ptr_length() share quite some code, so modify qemu_ram_ptr_length() a little bit and use it for qemu_map_ram_ptr(), too. Signed-off-by: Juergen Gross Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Alex Bennée

[PULL 17/28] xen: let xen_ram_addr_from_mapcache() return -1 in case of not found entry

2024-05-06 Thread Philippe Mathieu-Daudé
From: Juergen Gross Today xen_ram_addr_from_mapcache() will either abort() or return 0 in case it can't find a matching entry for a pointer value. Both cases are bad, so change that to return an invalid address instead. Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini Message-Id:

[PULL 12/28] accel/tcg: Move @plugin_mem_cbs from CPUState to CPUNegativeOffsetState

2024-05-06 Thread Philippe Mathieu-Daudé
@plugin_mem_cbs is accessed by tcg generated code, move it to CPUNegativeOffsetState. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240429213050.55177-4-phi...@linaro.org> --- accel/tcg/internal-common.h | 2 +- include/hw/core/cpu.h | 13

[PULL 14/28] user: Declare get_task_state() once in 'accel/tcg/vcpu-state.h'

2024-05-06 Thread Philippe Mathieu-Daudé
While each user emulation implentation defines its own TaskState structure, both use the same get_task_state() declaration, in particular in common code (such gdbstub). Declare the method once in "accel/tcg/vcpu-state.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson

[PULL 13/28] user: Forward declare TaskState type definition

2024-05-06 Thread Philippe Mathieu-Daudé
Forward declare TaskState in "qemu/typedefs.h" so we can use it in generic headers like "hw/cpu/core.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240428221450.26460-9-phi...@linaro.org> --- bsd-user/qemu.h | 4 ++-- include/qemu/typedefs.h | 1

[PULL 11/28] accel/tcg: Restrict cpu_plugin_mem_cbs_enabled() to TCG

2024-05-06 Thread Philippe Mathieu-Daudé
So far cpu_plugin_mem_cbs_enabled() is only called from TCG, so reduce it to accel/tcg/. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <5f59c754-44e5-4743-a2dd-87ef8e13e...@linaro.org> --- accel/tcg/internal-common.h | 17 +

[PULL 07/28] accel/tcg: Access tcg_cflags with getter / setter

2024-05-06 Thread Philippe Mathieu-Daudé
Access the CPUState::tcg_cflags via tcg_cflags_has() and tcg_cflags_set() helpers. Mechanical change using the following Coccinelle spatch script: @@ expression cpu; expression flags; @@ - cpu->tcg_cflags & flags + tcg_cflags_has(cpu, flags) @@ expression cpu;

[PULL 05/28] exec/cpu: Extract page-protection definitions to page-protection.h

2024-05-06 Thread Philippe Mathieu-Daudé
Extract page-protection definitions from "exec/cpu-all.h" to "exec/page-protection.h". The list of files requiring the new header was generated using: $ git grep -wE \ 'PAGE_(READ|WRITE|EXEC|RWX|VALID|ANON|RESERVED|TARGET_.|PASSTHROUGH)' Signed-off-by: Philippe Mathieu-Daudé Acked-by:

[PULL 09/28] accel/tcg: Update CPUNegativeOffsetState::can_do_io field documentation

2024-05-06 Thread Philippe Mathieu-Daudé
The @can_do_io field got moved from CPUState to CPUNegativeOffsetState in commit 464dacf609 ("accel/tcg: Move can_do_io to CPUNegativeOffsetState"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240428221450.26460-14-phi...@linaro.org> ---

[PULL 06/28] accel/tcg: Use cpu_loop_exit_requested() in cpu_loop_exec_tb()

2024-05-06 Thread Philippe Mathieu-Daudé
Do not open-code cpu_loop_exit_requested(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240428214915.10339-9-phi...@linaro.org> --- accel/tcg/cpu-exec.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/accel/tcg/cpu-exec.c

[PULL 04/28] exec/cpu: Remove duplicated PAGE_PASSTHROUGH definition

2024-05-06 Thread Philippe Mathieu-Daudé
Missed in commit 58771921af ("include/exec: Move PAGE_* macros to common header"), PAGE_PASSTHROUGH ended being defined twice. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240427155714.53669-8-phi...@linaro.org> --- include/exec/cpu-all.h | 6 -- 1

[PULL 03/28] exec/cpu: Remove obsolete PAGE_RESERVED definition

2024-05-06 Thread Philippe Mathieu-Daudé
We stopped using the PAGE_RESERVED definition in commit 50d25c8aec ("accel/tcg: Drop PAGE_RESERVED for CONFIG_BSD"). This completes commit 2e9a5713f0 ("Remove PAGE_RESERVED"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id:

[PULL 02/28] exec/cpu: Rename PAGE_BITS macro to PAGE_RWX

2024-05-06 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan This macro can be used to abbreviate PAGE_READ | PAGE_WRITE | PAGE_EXEC for which PAGE_RWX is a better name and renaming it also shows it is not related to TARGET_PAGE_BITS. Signed-off-by: BALATON Zoltan Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé

[PULL 00/28] Accelerator patches for 2024-05-06

2024-05-06 Thread Philippe Mathieu-Daudé
The following changes since commit 248f6f62df073a3b4158fd0093863ab885feabb5: Merge tag 'pull-axp-20240504' of https://gitlab.com/rth7680/qemu into staging (2024-05-04 08:39:46 -0700) are available in the Git repository at: https://github.com/philmd/qemu.git tags/accel-next-20240506

[PULL 01/28] exec/cpu: Indent TARGET_PAGE_foo definitions

2024-05-06 Thread Philippe Mathieu-Daudé
The TARGET_PAGE_foo definitions are defined with multiple level of #ifdef'ry. Indent it a bit for clarity. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240427155714.53669-6-phi...@linaro.org> --- include/exec/cpu-all.h | 25 + 1

Re: [PATCH v3 00/19] Add a host IOMMU device abstraction to check with vIOMMU

2024-05-06 Thread Jason Gunthorpe
On Mon, May 06, 2024 at 02:30:47AM +, Duan, Zhenzhong wrote: > I'm not clear how useful multiple iommufd instances support are. > One possible benefit is for security? It may bring a slightly fine-grained > isolation in kernel. No. I don't think there is any usecase, it is only harmful.

Re: [PATCH v4 0/2] query-cpu-model-expansion: report deprecated features

2024-05-06 Thread Thomas Huth
On 29/04/2024 21.10, Collin Walling wrote: Changelog v4 - updated cover letter to show example output - deprecated features are now a subset of the full CPU model's list of features - value: 1. no longer listing the deprecated

Re: [PATCH 3/3] vfio: Make VFIOIOMMUClass::add_window() and its wrapper return bool

2024-05-06 Thread Cédric Le Goater
On 5/6/24 10:33, Zhenzhong Duan wrote: Make VFIOIOMMUClass::add_window() and its wrapper function vfio_container_add_section_window() return bool. This is to follow the coding standand to return bool if 'Error **' is used to pass error. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong

Re: [PATCH 2/3] vfio: Make VFIOIOMMUClass::setup() return bool

2024-05-06 Thread Cédric Le Goater
On 5/6/24 10:33, Zhenzhong Duan wrote: This is to follow the coding standand to return bool if 'Error **' is used to pass error. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/vfio/vfio-container-base.h | 2 +-

Re: [PATCH 1/3] vfio: Make VFIOIOMMUClass::attach_device() and its wrapper return bool

2024-05-06 Thread Cédric Le Goater
On 5/6/24 10:33, Zhenzhong Duan wrote: Make VFIOIOMMUClass::attach_device() and its wrapper function vfio_attach_device() return bool. This is to follow the coding standand to return bool if 'Error **' is used to pass error. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan ---

[PATCH] spapr: Migrate ail-mode-3 spapr cap

2024-05-06 Thread Nicholas Piggin
This cap did not add the migration code when it was introduced. This results in migration failure when changing the default using the command line. Cc: qemu-sta...@nongnu.org Fixes: ccc5a4c5e10 ("spapr: Add SPAPR_CAP_AIL_MODE_3 for AIL mode 3 support for H_SET_MODE hcall") Signed-off-by:

[PULL 10/12] target/sparc: Fix FMULD8*X16

2024-05-06 Thread Mark Cave-Ayland
From: Richard Henderson Not only do these instructions have f32 inputs, they also do not perform rounding. Since these are relatively simple, implement them properly inline. Signed-off-by: Richard Henderson Message-Id: <20240502165528.244004-6-richard.hender...@linaro.org> Signed-off-by: Mark

[PULL 12/12] target/sparc: Split out do_ms16b

2024-05-06 Thread Mark Cave-Ayland
From: Richard Henderson The unit operation for fmul8x16 and friends is described in the manual as "MS16b". Split that out for clarity. Improve rounding with an unconditional addition of 0.5 as a fixed-point integer. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé

[PULL 11/12] target/sparc: Fix FPMERGE

2024-05-06 Thread Mark Cave-Ayland
From: Richard Henderson This instruction has f32 inputs, which changes the decode of the register numbers. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240502165528.244004-7-richard.hender...@linaro.org> Signed-off-by: Mark Cave-Ayland ---

[PULL 08/12] target/sparc: Fix FMUL8x16

2024-05-06 Thread Mark Cave-Ayland
From: Richard Henderson This instruction has f32 as source1, which alters the decoding of the register number, which means we've been passing the wrong data for odd register numbers. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 03/12] docs/system/target-sparc: Improve the Sparc documentation

2024-05-06 Thread Mark Cave-Ayland
From: Thomas Huth Add some words about how to enable or disable boolean features, and remove the note about a Linux kernel being available on the QEMU website (they have been removed long ago already), and the note about NetBSD and OpenBSD still having issues (they should work fine nowadays).

[PULL 05/12] hw/sparc64: set iommu_platform=on for virtio devices attached to the sun4u machine

2024-05-06 Thread Mark Cave-Ayland
The sun4u machine has an IOMMU and therefore it is possible to program it such that the virtio-device IOVA does not map directly to the CPU physical address. This is not a problem with Linux which always maps the IOVA directly to the CPU physical address, however it is required for the NetBSD

[PULL 09/12] target/sparc: Fix FMUL8x16A{U,L}

2024-05-06 Thread Mark Cave-Ayland
From: Richard Henderson These instructions have f32 inputs, which changes the decode of the register numbers. While we're fixing things, use a common helper for both insns, extracting the 16-bit scalar in tcg beforehand. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé

[PULL 06/12] linux-user/sparc: Add more hwcap bits for sparc64

2024-05-06 Thread Mark Cave-Ayland
From: Richard Henderson Supply HWCAP_SPARC_V8PLUS, HWCAP_SPARC_MUL32, HWCAP_SPARC_DIV32, HWCAP_SPARC_POPC, HWCAP_SPARC_FSMULD, HWCAP_SPARC_VIS, HWCAP_SPARC_VIS2. Signed-off-by: Richard Henderson Message-Id: <20240502165528.244004-2-richard.hender...@linaro.org> Signed-off-by: Mark Cave-Ayland

[PULL 07/12] target/sparc: Fix FEXPAND

2024-05-06 Thread Mark Cave-Ayland
From: Richard Henderson This is a 2-operand instruction, not 3-operand. Worse, we took the source from the wrong operand. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240502165528.244004-3-richard.hender...@linaro.org> Signed-off-by: Mark Cave-Ayland

[PULL 04/12] docs/about: Deprecate the old "UltraSparc" CPU names that contain a "+"

2024-05-06 Thread Mark Cave-Ayland
From: Thomas Huth For consistency we should drop the names with a "+" in it in the long run. Reviewed-by: Mark Cave-Ayland Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240419084812.504779-5-th...@redhat.com> Signed-off-by: Mark

[PULL 01/12] target/sparc/cpu: Rename the CPU models with a "+" in their names

2024-05-06 Thread Mark Cave-Ayland
From: Thomas Huth Commit b447378e12 ("qom/object: Limit type names to alphanumerical ...") cut down the amount of allowed characters for QOM types to a saner set. The "+" character was meant to be included in this set, so we had to add a hack there to still allow the legacy names of POWER and

[PULL 02/12] target/sparc/cpu: Avoid spaces by default in the CPU names

2024-05-06 Thread Mark Cave-Ayland
From: Thomas Huth The output of "-cpu help" is currently rather confusing to the users: It might not be fully clear which part of the output defines the CPU names since the CPU names contain white spaces (which we later have to convert into dashes internally). At best it's at least a nuisance

[PULL 00/12] qemu-sparc queue 20240506

2024-05-06 Thread Mark Cave-Ayland
The following changes since commit 248f6f62df073a3b4158fd0093863ab885feabb5: Merge tag 'pull-axp-20240504' of https://gitlab.com/rth7680/qemu into staging (2024-05-04 08:39:46 -0700) are available in the Git repository at: https://github.com/mcayland/qemu.git tags/qemu-sparc-20240506

Re: [PATCH 1/7] qapi: make since sections special WIP

2024-05-06 Thread Philippe Mathieu-Daudé
On 6/5/24 13:02, Markus Armbruster wrote: since moves to end in generated output --- docs/sphinx/qapidoc.py | 22 +- scripts/qapi/parser.py | 5 +++-- tests/qapi-schema/test-qapi.py | 2 ++ 3 files changed, 22 insertions(+), 7 deletions(-)

Re: [PATCH v2] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-05-06 Thread Philippe Mathieu-Daudé
On 6/5/24 13:20, Thomas Huth wrote: The old "-runas" option has the disadvantage that it is not visible in the QAPI schema, so it is not available via the normal introspection mechanisms. We've recently introduced the "-run-with" option for exactly this purpose, which is meant to handle the

[PATCH v2] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-05-06 Thread Thomas Huth
The old "-runas" option has the disadvantage that it is not visible in the QAPI schema, so it is not available via the normal introspection mechanisms. We've recently introduced the "-run-with" option for exactly this purpose, which is meant to handle the options that affect the runtime behavior.

Re: [qemu-web PATCH] blog: KVM Forum 2024 CFP

2024-05-06 Thread Thomas Huth
On 06/05/2024 12.55, Stefan Hajnoczi wrote: The mistakes were mine. Thanks for pointing them out, Thomas! All right, so I went ahead and fixed the deadline date and link and pushed it to the repository now. Thanks, Thomas

[PATCH 2/7] sphinx/qapidoc: Tweak "Since" section formatting WIP

2024-05-06 Thread Markus Armbruster
--- docs/sphinx/qapidoc.py | 6 +++--- tests/qapi-schema/doc-good.txt | 6 +- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py index ac81003f0e..f19f5ded78 100644 --- a/docs/sphinx/qapidoc.py +++ b/docs/sphinx/qapidoc.py @@

[PULL 5/7] qapi: Rename QAPISchemaAlternateType.variants to .alternatives

2024-05-06 Thread Markus Armbruster
A previous commit narrowed the type of QAPISchemaAlternateType.variants from QAPISchemaVariants to QAPISchemaAlternatives. Rename it to .alternatives. Same for .__init__() parameter @variants. Signed-off-by: Markus Armbruster --- scripts/qapi/schema.py | 25 + 1 file

[PULL 7/7] qapi: Simplify QAPISchemaVariants @tag_member

2024-05-06 Thread Markus Armbruster
For union types, the tag member is known only after .check(). We used to code this in a simple way: QAPISchemaVariants attribute .tag_member was None for union types until .check(). Since this complicated typing, recent commit "qapi/schema: fix typing for QAPISchemaVariants.tag_member" hid it

[PATCH 4/7] qapidoc: Generate default Returns WIP

2024-05-06 Thread Markus Armbruster
Affected: x-debug-query-block-graph query-tpm query-dirty-rate query-vcpu-dirty-limit query-vm-generation-id query-memory-size-summary query-memory-devices query-acpi-ospm-status query-stats-schemas --- docs/sphinx/qapidoc.py | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

[PULL 4/7] qapi: Rename QAPISchemaObjectType.variants to .branches

2024-05-06 Thread Markus Armbruster
A previous commit narrowed the type of QAPISchemaObjectType.variants from QAPISchemaVariants to QAPISchemaBranches. Rename it to .branches. Same for .__init__() parameter @variants. Signed-off-by: Markus Armbruster --- scripts/qapi/commands.py | 2 +- scripts/qapi/events.py | 2 +-

[PATCH 1/7] qapi: make since sections special WIP

2024-05-06 Thread Markus Armbruster
since moves to end in generated output --- docs/sphinx/qapidoc.py | 22 +- scripts/qapi/parser.py | 5 +++-- tests/qapi-schema/test-qapi.py | 2 ++ 3 files changed, 22 insertions(+), 7 deletions(-) diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py

[PULL 0/7] QAPI patches patches for 2024-05-06

2024-05-06 Thread Markus Armbruster
The following changes since commit 248f6f62df073a3b4158fd0093863ab885feabb5: Merge tag 'pull-axp-20240504' of https://gitlab.com/rth7680/qemu into staging (2024-05-04 08:39:46 -0700) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2024-05-06 for

[PULL 6/7] qapi: Move conditional code from QAPISchemaVariants to its subtypes

2024-05-06 Thread Markus Armbruster
QAPISchemaVariants.check()'s code is almost entirely conditional on union vs. alternate type. Move the conditional code to QAPISchemaBranches.check() and QAPISchemaAlternatives.check(), where the conditions are always satisfied. Attribute QAPISchemaVariants.tag_name is now only used by

[PATCH 6/7] qga/qapi-schema: Drop "Returns" section where default is fine WIP

2024-05-06 Thread Markus Armbruster
--- qga/qapi-schema.json | 40 +--- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index d5af155007..fe41670ed2 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -194,8 +194,6 @@ # #

[PULL 3/7] qapi: Rename visitor parameter @variants to @alternatives

2024-05-06 Thread Markus Armbruster
A previous commit narrowed the type of .visit_alternate_type() parameter @variants from QAPISchemaVariants to QAPISchemaAlternatives. Rename it to @alternatives. One of them passes @alternatives to helper function gen_visit_alternate(). Rename its @variants parameter to @alternatives as well.

[PATCH 7/7] find untagged sections WIP

2024-05-06 Thread Markus Armbruster
--- qapi/block-core.json | 1 + qapi/introspect.json | 4 qapi/machine-target.json | 2 ++ qapi/migration.json| 3 +++ qapi/net.json | 2 ++ qapi/qom.json | 1 + qapi/ui.json | 1 + qga/qapi-schema.json

[PATCH 3/7] qapi: make returns sections special WIP

2024-05-06 Thread Markus Armbruster
returns moves in generated output --- docs/sphinx/qapidoc.py | 8 scripts/qapi/parser.py | 4 ++-- tests/qapi-schema/doc-good.out | 4 ++-- tests/qapi-schema/doc-good.txt | 12 ++-- tests/qapi-schema/test-qapi.py | 2 ++ 5 files changed, 20 insertions(+), 10

[PULL 1/7] qapi: New QAPISchemaBranches, QAPISchemaAlternatives

2024-05-06 Thread Markus Armbruster
QAPISchemaVariants represents either a union type's branches, or an alternate type's alternatives. Much of its code is conditional on which one it actually is. Create QAPISchemaBranches for branches, and QAPISchemaAlternatives for alternatives, both subtypes of QAPISchemaVariants. Replace

[PULL 2/7] qapi: Rename visitor parameter @variants to @branches

2024-05-06 Thread Markus Armbruster
The previous commit narrowed the type of .visit_object_type() parameter @variants from QAPISchemaVariants to QAPISchemaBranches. Rename it to @branches. Same for .visit_object_type_flat(). A few of these pass @branches to helper functions: QAPISchemaGenRSTVisitor.visit_object_type() to

[PATCH 5/7] qapi: Drop "Returns" section where default is fine WIP

2024-05-06 Thread Markus Armbruster
--- qapi/audio.json | 2 -- qapi/block-core.json | 21 - qapi/block-export.json | 2 +- qapi/block.json | 3 --- qapi/char.json | 10 +- qapi/control.json| 5 - qapi/cryptodev.json | 2 -- qapi/dump.json

Re: [PATCH 1/3] qapi/vfio: Add VFIO device migration state change QAPI event

2024-05-06 Thread Avihai Horon
On 06/05/2024 13:36, Markus Armbruster wrote: External email: Use caution opening links or attachments Avihai Horon writes: On 06/05/2024 7:52, Markus Armbruster wrote: Avihai Horon writes: On 01/05/2024 14:50, Joao Martins wrote: On 30/04/2024 06:16, Avihai Horon wrote: Add a new

Re: [qemu-web PATCH] blog: KVM Forum 2024 CFP

2024-05-06 Thread Stefan Hajnoczi
The mistakes were mine. Thanks for pointing them out, Thomas! Acked-by: Stefan Hajnoczi

Re: [PATCH 1/3] qapi/vfio: Add VFIO device migration state change QAPI event

2024-05-06 Thread Markus Armbruster
Avihai Horon writes: > On 06/05/2024 7:52, Markus Armbruster wrote: >> Avihai Horon writes: >> >>> On 01/05/2024 14:50, Joao Martins wrote: On 30/04/2024 06:16, Avihai Horon wrote: > Add a new QAPI event for VFIO device migration state change. This event > will be emitted when a

Re: [PATCH v4 00/17] xen: Support grant mappings

2024-05-06 Thread Philippe Mathieu-Daudé
Hi, On 30/4/24 18:49, Edgar E. Iglesias wrote: > Juergen Gross (2): >softmmu: let qemu_map_ram_ptr() use qemu_ram_ptr_length() >xen: let xen_ram_addr_from_mapcache() return -1 if not found entry Edgar E. Iglesias (15): xen: mapcache: Refactor lock functions for multi-instance

Re: [qemu-web PATCH] blog: KVM Forum 2024 CFP

2024-05-06 Thread Thomas Huth
On 06/05/2024 12.13, Paolo Bonzini wrote: Add a new post linking to the KVM Forum 2024 Call for Presentations. Thanks to Stefan Hajnoczi for providing a draft of this post! Cc: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- _posts/2024-05-06-kvm-forum-cfp.md | 36

<    1   2   3   4   >