Re: [PATCH 1/2] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-05-13 Thread Alistair Francis
On Sat, Apr 13, 2024 at 9:00 PM Alexei Filippov wrote: > > From: Daniel Henrique Barboza > > raise_mmu_exception(), as is today, is prioritizing guest page faults by > checking first if virt_enabled && !first_stage, and then considering the > regular inst/load/store faults. > > There's no

RE: [PATCH intel_iommu 0/7] FLTS for VT-d

2024-05-13 Thread Duan, Zhenzhong
Hi Clement, I'll learn and try to give comments this week. Thanks Zhenzhong >-Original Message- >From: CLEMENT MATHIEU--DRIF >Subject: Re: [PATCH intel_iommu 0/7] FLTS for VT-d > >Hi Zhenzhong > >Have you had time to review the ATS series rebased on you FLTS patches? > >Thanks > >cmd >

Re: [PATCH v2 0/4] Fix fp16 checking in vector fp widen/narrow instructions

2024-05-13 Thread Alistair Francis
On Fri, Mar 22, 2024 at 7:33 PM Max Chou wrote: > > When SEW is 16, we need to check whether the Zvfhmin is enabled for the > single width operator for vector floating point widen/narrow > instructions. > > The commits in this patchset fix the single width operator checking and > remove the

Re: riscv disassembler error with pmpcfg0

2024-05-13 Thread Alistair Francis
On Thu, Apr 4, 2024 at 5:02 AM Eric DeVolder wrote: > > I've been using QEMU8 to collect instruction information on U-Boot + OpenSBI. > > I'm running QEMU in this fashion to collect the information: > > # qemu-system-riscv64 -plugin file=qemu/build/contrib/plugins/libexeclog.so > -singlestep -d

[PATCH] dias/riscv: Decode all of the pmpcfg and pmpaddr CSRs

2024-05-13 Thread Alistair Francis
Previously we only listed a single pmpcfg CSR and the first 16 pmpaddr CSRs. This patch fixes this to list all 16 pmpcfg and all 64 pmpaddr CSRs are part of the dissassembly. Reported-by: Eric DeVolder Signed-off-by: Alistair Francis --- disas/riscv.c | 65

Re: [PATCH intel_iommu 0/7] FLTS for VT-d

2024-05-13 Thread CLEMENT MATHIEU--DRIF
Hi Zhenzhong Have you had time to review the ATS series rebased on you FLTS patches? Thanks >cmd On 06/05/2024 03:38, Duan, Zhenzhong wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > >

Re: [PATCH v2 3/4] virtio-gpu: add x-vmstate-version

2024-05-13 Thread Peter Xu
Hey, Marc-Andre, On Mon, May 13, 2024 at 11:19:04AM +0400, marcandre.lur...@redhat.com wrote: > diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c > index ae831b6b3e..7f9fb5eacc 100644 > --- a/hw/display/virtio-gpu.c > +++ b/hw/display/virtio-gpu.c > @@ -1234,7 +1234,8 @@ static int

Re: [PATCH v2 2/4] migration: fix a typo

2024-05-13 Thread Peter Xu
On Mon, May 13, 2024 at 11:19:03AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Reviewed-by: Peter Xu -- Peter Xu

Re: [RFC 0/2] Identify aliased maps in vdpa SVQ iova_tree

2024-05-13 Thread Jason Wang
On Mon, May 13, 2024 at 5:58 PM Eugenio Perez Martin wrote: > > On Mon, May 13, 2024 at 10:28 AM Jason Wang wrote: > > > > On Mon, May 13, 2024 at 2:28 PM Eugenio Perez Martin > > wrote: > > > > > > On Sat, May 11, 2024 at 6:07 AM Jason Wang wrote: > > > > > > > > On Fri, May 10, 2024 at 3:16 

RE: [PATCH v2 00/11] VFIO: misc cleanups

2024-05-13 Thread Duan, Zhenzhong
Hi All, When I looked into more functions passing 'Error **', I see many are in "int testfunc(..., Error **errp)" format. I was a bit confused. The qapi/error.h suggests: * - Whenever practical, also return a value that indicates success / * failure. This can make the error checking more

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Zhao Liu
> I'm failing to see what real world technical problems QEMU faces > with a parameter being set to '1' by a mgmt app, when QEMU itself > treats all omitted values as being '1' anyway. > > If we're trying to faithfully model the real world, then restricting > the topology against machine types

Re: [PATCH] target/ppc: handle vcpu hotplug failure gracefully

2024-05-13 Thread Nicholas Piggin
On Tue Apr 23, 2024 at 4:30 PM AEST, Harsh Prateek Bora wrote: > + qemu-devel > > On 4/23/24 11:40, Harsh Prateek Bora wrote: > > On ppc64, the PowerVM hypervisor runs with limited memory and a VCPU > > creation during hotplug may fail during kvm_ioctl for KVM_CREATE_VCPU, > > leading to

[PATCH] hw/loongarch: Add VM mode in IOCSR feature register in kvm mode

2024-05-13 Thread Bibo Mao
If VM runs in kvm mode, VM mode is added in IOCSR feature register. So guest can detect kvm hypervisor type and enable possible pv functions. Signed-off-by: Bibo Mao --- hw/loongarch/virt.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/loongarch/virt.c

[PATCH] target/riscv: rvzicbo: Fixup CBO extension register calculation

2024-05-13 Thread Alistair Francis
When running the instruction ``` cbo.flush 0(x0) ``` QEMU would segfault. The issue was in cpu_gpr[a->rs1] as QEMU does not have cpu_gpr[0] allocated. In order to fix this let's use the existing get_address() helper. This also has the benefit of performing pointer mask calculations on the

Re: [PATCH v7 09/12] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

2024-05-13 Thread Zhijian Li (Fujitsu)
On 19/04/2024 07:11, nifan@gmail.com wrote: > +} else if (type == DC_EVENT_ADD_CAPACITY) { > +if (cxl_extents_overlaps_dpa_range(>dc.extents, dpa, len)) { > +error_setg(errp, > + "cannot add DPA already accessible to the same >

Re: [PATCH v7 00/12] Enabling DCD emulation support in Qemu

2024-05-13 Thread Zhijian Li (Fujitsu)
Hi Fan Do you have a newer instruction to play with the DCD. It seems that the instruction in RFC[0] doesn't work for current code. [0] https://lore.kernel.org/all/20230511175609.2091136-1-fan...@samsung.com/ On 19/04/2024 07:10, nifan@gmail.com wrote: > A git tree of this series can be

Re: CPR/liveupdate: test results using prior bug fix

2024-05-13 Thread Michael Galaxy
Hi Steve, Thanks for the response. It looks like literally *just today* 8.2.4 was released. I'll go check it out. - Michael On 5/13/24 15:10, Steven Sistare wrote: Hi Michael,   No surprise here, I did see some of the same failure messages and they prompted me to submit the fix.  They are

[PATCH] physmem: allow debug writes to MMIO regions

2024-05-13 Thread Perry Hung
Writes from GDB to memory-mapped IO regions are currently silently dropped. cpu_memory_rw_debug() calls address_space_write_rom(), which calls address_space_write_rom_internal(), which ignores all non-ram/rom regions. Add a check for MMIO regions and direct those to address_space_rw() instead.

Re: [PATCH v2 2/4] migration: fix a typo

2024-05-13 Thread Fabiano Rosas
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > migration/vmstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/vmstate.c b/migration/vmstate.c > index b51212a75b..ff5d589a6d 100644 > ---

Re: [PATCH v5 03/10] vfio: Extend migration_file_set_error() with Error** argument

2024-05-13 Thread Fabiano Rosas
Cédric Le Goater writes: > Use it to update the current error of the migration stream if > available and if not, simply print out the error. Next changes will > update with an error to report. > > Signed-off-by: Cédric Le Goater Acked-by: Fabiano Rosas

Re: Unmapping KVM Guest Memory from Host Kernel

2024-05-13 Thread Manwaring, Derek
On 2024-05-13 13:36-0700, Sean Christopherson wrote: > Hmm, a slightly crazy idea (ok, maybe wildly crazy) would be to support > mapping > all of guest_memfd into kernel address space, but as USER=1 mappings.  I.e. > don't > require a carve-out from userspace, but do require CLAC/STAC when

Re: [PATCH V1 26/26] migration: only-migratable-modes

2024-05-13 Thread Fabiano Rosas
Steven Sistare writes: > On 5/9/2024 3:14 PM, Fabiano Rosas wrote: >> Steve Sistare writes: >> >>> Add the only-migratable-modes option as a generalization of only-migratable. >>> Only devices that support all requested modes are allowed. >>> >>> Signed-off-by: Steve Sistare >>> --- >>>

Re: [PATCH V1 06/26] migration: precreate vmstate for exec

2024-05-13 Thread Fabiano Rosas
Steven Sistare writes: > On 5/6/2024 7:34 PM, Fabiano Rosas wrote: >> Steve Sistare writes: >> >>> Provide migration_precreate_save for saving precreate vmstate across exec. >>> Create a memfd, save its value in the environment, and serialize state >>> to it. Reverse the process in

[ANNOUNCE] QEMU 8.2.4 Stable released

2024-05-13 Thread Michael Tokarev
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi everyone, The QEMU v8.2.4 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-8.2.4.tar.xz

Re: Unmapping KVM Guest Memory from Host Kernel

2024-05-13 Thread Sean Christopherson
On Mon, May 13, 2024, James Gowans wrote: > On Mon, 2024-05-13 at 10:09 -0700, Sean Christopherson wrote: > > On Mon, May 13, 2024, James Gowans wrote: > > > On Mon, 2024-05-13 at 08:39 -0700, Sean Christopherson wrote: > > > > > Sean, you mentioned that you envision guest_memfd also supporting >

Re: CPR/liveupdate: test results using prior bug fix

2024-05-13 Thread Steven Sistare
Hi Michael, No surprise here, I did see some of the same failure messages and they prompted me to submit the fix. They are all symptoms of "the possibility of ram and device state being out of sync" as mentioned in the commit. I am not familiar with the process for maintaining old releases

Re: [PATCH V1 26/26] migration: only-migratable-modes

2024-05-13 Thread Steven Sistare
On 5/9/2024 3:14 PM, Fabiano Rosas wrote: Steve Sistare writes: Add the only-migratable-modes option as a generalization of only-migratable. Only devices that support all requested modes are allowed. Signed-off-by: Steve Sistare --- include/migration/misc.h | 3 +++

Re: Unmapping KVM Guest Memory from Host Kernel

2024-05-13 Thread Gowans, James
On Mon, 2024-05-13 at 10:09 -0700, Sean Christopherson wrote: > On Mon, May 13, 2024, James Gowans wrote: > > On Mon, 2024-05-13 at 08:39 -0700, Sean Christopherson wrote: > > > > Sean, you mentioned that you envision guest_memfd also supporting > > > > non-CoCo VMs. > > > > Do you have some

Re: [PATCH V1 13/26] physmem: ram_block_create

2024-05-13 Thread Steven Sistare
On 5/13/2024 2:37 PM, Fabiano Rosas wrote: Steve Sistare writes: Create a common subroutine to allocate a RAMBlock, de-duping the code to populate its common fields. Add a trace point for good measure. No functional change. Signed-off-by: Steve Sistare --- system/physmem.c| 47

Re: [PATCH V1 24/26] seccomp: cpr-exec blocker

2024-05-13 Thread Steven Sistare
On 5/10/2024 3:54 AM, Daniel P. Berrangé wrote: On Mon, Apr 29, 2024 at 08:55:33AM -0700, Steve Sistare wrote: cpr-exec mode needs permission to exec. Block it if permission is denied. Signed-off-by: Steve Sistare --- include/sysemu/seccomp.h | 1 + system/qemu-seccomp.c| 10

Re: [PATCH V1 22/26] migration: ram block cpr-exec blockers

2024-05-13 Thread Steven Sistare
On 5/9/2024 2:01 PM, Fabiano Rosas wrote: Steve Sistare writes: Unlike cpr-reboot mode, cpr-exec mode cannot save volatile ram blocks in the migration stream file and recreate them later, because the physical memory for the blocks is pinned and registered for vfio. Add an exec-mode blocker

Re: [PATCH V1 09/26] migration: vmstate_register_named

2024-05-13 Thread Steven Sistare
On 5/9/2024 10:32 AM, Fabiano Rosas wrote: Fabiano Rosas writes: Steve Sistare writes: Define vmstate_register_named which takes the instance name as its first parameter, instead of generating the name from VMStateIf of the Object. This will be needed to register objects that are not

Re: [PATCH V1 05/26] migration: precreate vmstate

2024-05-13 Thread Steven Sistare
On 5/7/2024 5:02 PM, Fabiano Rosas wrote: Steve Sistare writes: Provide the VMStateDescription precreate field to mark objects that must be loaded on the incoming side before devices have been created, because they provide properties that will be needed at creation time. They will be saved

Re: [PATCH V1 06/26] migration: precreate vmstate for exec

2024-05-13 Thread Steven Sistare
On 5/6/2024 7:34 PM, Fabiano Rosas wrote: Steve Sistare writes: Provide migration_precreate_save for saving precreate vmstate across exec. Create a memfd, save its value in the environment, and serialize state to it. Reverse the process in migration_precreate_load. Signed-off-by: Steve

Re: [PATCH V1 03/26] migration: SAVEVM_FOREACH

2024-05-13 Thread Steven Sistare
On 5/6/2024 7:17 PM, Fabiano Rosas wrote: Steve Sistare writes: Define an abstraction SAVEVM_FOREACH to loop over all savevm state handlers, and replace QTAILQ_FOREACH. Define variants for ALL so we can loop over all handlers vs a subset of handlers in a subsequent patch, but at this time

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-13 Thread Michael Galaxy
One thing to keep in mind here (despite me not having any hardware to test) was that one of the original goals here in the RDMA implementation was not simply raw throughput nor raw latency, but a lack of CPU utilization in kernel space due to the offload. While it is entirely possible that newer

Re: [PATCH 2/3] hw/timer/imx_gpt: Convert DPRINTF to trace events

2024-05-13 Thread Bernhard Beschow
Am 13. Mai 2024 11:30:04 UTC schrieb "Philippe Mathieu-Daudé" : >On 13/5/24 12:11, Bernhard Beschow wrote: >> Signed-off-by: Bernhard Beschow >> --- >> hw/timer/imx_gpt.c| 18 +- >> hw/timer/trace-events | 6 ++ >> 2 files changed, 11 insertions(+), 13

Re: [PATCH V1 13/26] physmem: ram_block_create

2024-05-13 Thread Fabiano Rosas
Steve Sistare writes: > Create a common subroutine to allocate a RAMBlock, de-duping the code to > populate its common fields. Add a trace point for good measure. > No functional change. > > Signed-off-by: Steve Sistare > --- > system/physmem.c| 47

CPR/liveupdate: test results using prior bug fix

2024-05-13 Thread Michael Galaxy
Hi Steve, We found that this specific change in particular ("migration: stop vm for cpr") fixes a bug that we've identified in testing back-to-back live updates in a lab environment. More specifically, *without* this change (which is not available in 8.2.2, but *is* available in 9.0.0)

Re: [PATCH v2 13/33] plugins: Use DisasContextBase for qemu_plugin_insn_haddr

2024-05-13 Thread Pierrick Bouvier
On 4/24/24 16:31, Richard Henderson wrote: We can delay the computation of haddr until the plugin actually requests it. Signed-off-by: Richard Henderson --- include/qemu/plugin.h | 4 accel/tcg/plugin-gen.c | 20 plugins/api.c | 25

Re: [PATCH 5/6] migration: Rephrase message on failure to save / load Xen device state

2024-05-13 Thread Fabiano Rosas
Markus Armbruster writes: > Functions that use an Error **errp parameter to return errors should > not also report them to the user, because reporting is the caller's > job. When the caller does, the error is reported twice. When it > doesn't (because it recovered from the error), there is no

Re: Intention to work on GSoC project

2024-05-13 Thread Sahil
Hi, On Monday, May 13, 2024 7:53:40 PM GMT+5:30 Eugenio Perez Martin wrote: > [...] > > I have started working on implementing packed virtqueue support in > > vhost-shadow-virtqueue.c. The changes I have made so far are very > > minimal. I have one confusion as well. > > > > In "vhost_svq_add()"

Re: Unmapping KVM Guest Memory from Host Kernel

2024-05-13 Thread Sean Christopherson
On Mon, May 13, 2024, James Gowans wrote: > On Mon, 2024-05-13 at 08:39 -0700, Sean Christopherson wrote: > > > Sean, you mentioned that you envision guest_memfd also supporting > > > non-CoCo VMs. > > > Do you have some thoughts about how to make the above cases work in the > > > guest_memfd

Re: [PATCH v5 03/10] vfio: Extend migration_file_set_error() with Error** argument

2024-05-13 Thread Cédric Le Goater
On 5/13/24 15:14, Avihai Horon wrote: On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments Change commit title: vfio: Extend migration_file_set_error() with Error** argument to: migration: Extend migration_file_set_error() with Error*

Re: [PATCH v5 02/10] vfio: Add Error** argument to vfio_devices_dma_logging_start()

2024-05-13 Thread Cédric Le Goater
On 5/13/24 15:08, Avihai Horon wrote: On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments This allows to update the Error argument of the VFIO log_global_start() handler. Errors detected when device level logging is started will be propagated

RE: [PATCH v2] vhost-user-gpu: fix import of DMABUF

2024-05-13 Thread Kim, Dongwon
Hi Marc-André, This commit looks good but are you planning to merge this before "ui/console: Private QemuDmaBuf struct"? It will cause some conflict. Let me know if rebasing is needed on "ui/console: Private QemuDmaBuf struct". > -Original Message- > From: marcandre.lur...@redhat.com

Re: [PATCH v5 01/10] vfio: Add Error** argument to .set_dirty_page_tracking() handler

2024-05-13 Thread Cédric Le Goater
On 5/13/24 15:03, Avihai Horon wrote: Hi Cedric, On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments We will use the Error object to improve error reporting in the .log_global*() handlers of VFIO. Add documentation while at it. First of

Re: Unmapping KVM Guest Memory from Host Kernel

2024-05-13 Thread Gowans, James
On Mon, 2024-05-13 at 08:39 -0700, Sean Christopherson wrote: > > Sean, you mentioned that you envision guest_memfd also supporting non-CoCo > > VMs. > > Do you have some thoughts about how to make the above cases work in the > > guest_memfd context? > > Yes.  The hand-wavy plan is to allow

Re: Unmapping KVM Guest Memory from Host Kernel

2024-05-13 Thread Sean Christopherson
On Mon, May 13, 2024, Patrick Roy wrote: > For non-CoCo VMs, where memory is not encrypted, and the threat model assumes > a > trusted host userspace, we would like to avoid changing the VM model so > completely. If we adopt CoCo’s approaches where KVM / Userspace touches guest > memory we would

Re: [PATCH v6 6/7] migration/multifd: implement qpl compression and decompression

2024-05-13 Thread Fabiano Rosas
Yuan Liu writes: > each qpl job is used to (de)compress a normal page and it can > be processed independently by the IAA hardware. All qpl jobs > are submitted to the hardware at once, and wait for all jobs > completion. If hardware path(IAA) is not available, use software > for compression and

Re: [PATCH 2/6] dump/win_dump: Improve error messages on write error

2024-05-13 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 13/5/24 16:16, Markus Armbruster wrote: >> create_win_dump() and write_run report qemu_write_full() failure to >> their callers as >> An IO error has occurred >> The errno set by qemu_write_full() is lost. >> Improve this to >> win-dump: failed to

Re: [PATCH 4/6] cpus: Improve error messages on memsave, pmemsave write error

2024-05-13 Thread Philippe Mathieu-Daudé
On 13/5/24 16:45, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 13/5/24 16:17, Markus Armbruster wrote: qmp_memsave() and qmp_pmemsave() report fwrite() error as An IO error has occurred Improve this to writing memory to '' failed Signed-off-by: Markus Armbruster

Re: [PATCH 2/6] dump/win_dump: Improve error messages on write error

2024-05-13 Thread Philippe Mathieu-Daudé
On 13/5/24 16:48, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 13/5/24 16:16, Markus Armbruster wrote: create_win_dump() and write_run report qemu_write_full() failure to their callers as An IO error has occurred The errno set by qemu_write_full() is lost. Improve this to

Re: [PATCH v2 2/3] vfio/migration: Emit VFIO migration QAPI event

2024-05-13 Thread Avihai Horon
On 13/05/2024 17:43, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 5/13/24 16:34, Avihai Horon wrote: On 13/05/2024 17:01, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 5/9/24 11:09, Avihai Horon wrote: Emit

Re: [PATCH 4/6] cpus: Improve error messages on memsave, pmemsave write error

2024-05-13 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 13/5/24 16:17, Markus Armbruster wrote: >> qmp_memsave() and qmp_pmemsave() report fwrite() error as >> An IO error has occurred >> Improve this to >> writing memory to '' failed >> Signed-off-by: Markus Armbruster >> --- >> system/cpus.c | 6

Re: [PATCH v2 2/3] vfio/migration: Emit VFIO migration QAPI event

2024-05-13 Thread Cédric Le Goater
On 5/13/24 16:34, Avihai Horon wrote: On 13/05/2024 17:01, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 5/9/24 11:09, Avihai Horon wrote: Emit VFIO migration QAPI event when a VFIO device changes its migration state. This can be used by management

Re: [PATCH 3/3] hw/watchdog/wdt_imx2: Remove redundant assignment

2024-05-13 Thread Guenter Roeck
On 5/13/24 03:11, Bernhard Beschow wrote: The same statement is executed unconditionally right before the if statement. Cc: Guenter Roeck Signed-off-by: Bernhard Beschow --- The duplicate line may indicate a bug. I'm not familiar with the code, so this patch may go into the wrong direction.

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 10:22:22PM +0800, Zhao Liu wrote: > Cc Paolo for x86 topology part > > Hi Daniel, > > On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > > Date: Mon, 13 May 2024 13:33:57 +0100 > > From: "Daniel P. Berrangé" > > Subject: [PATCH 1/2] hw/core: allow

Re: [PATCH v2 3/3] vfio/migration: Don't emit STOP_COPY VFIO migration QAPI event twice

2024-05-13 Thread Avihai Horon
On 13/05/2024 17:13, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 5/9/24 11:09, Avihai Horon wrote: When migrating a VFIO device that supports pre-copy, it is transitioned to STOP_COPY twice: once in vfio_vmstate_change() and second time in

Re: [PATCH v2 2/3] vfio/migration: Emit VFIO migration QAPI event

2024-05-13 Thread Avihai Horon
On 13/05/2024 17:01, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 5/9/24 11:09, Avihai Horon wrote: Emit VFIO migration QAPI event when a VFIO device changes its migration state. This can be used by management applications to get updates on the current

Re: [PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 04:22:00PM +0200, Thomas Huth wrote: > On 13/05/2024 14.11, Daniel P. Berrangé wrote: > > On Mon, May 13, 2024 at 02:05:16PM +0200, Thomas Huth wrote: > > > On 13/05/2024 12.28, Daniel P. Berrangé wrote: > > > > A better way to handle this would be to define a separate

Re: [PATCH 6/6] qerror: QERR_IO_ERROR is no longer used, drop

2024-05-13 Thread Philippe Mathieu-Daudé
On 13/5/24 16:17, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- include/qapi/qmp/qerror.h | 3 --- 1 file changed, 3 deletions(-) One less! Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 4/6] cpus: Improve error messages on memsave, pmemsave write error

2024-05-13 Thread Philippe Mathieu-Daudé
On 13/5/24 16:17, Markus Armbruster wrote: qmp_memsave() and qmp_pmemsave() report fwrite() error as An IO error has occurred Improve this to writing memory to '' failed Signed-off-by: Markus Armbruster --- system/cpus.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH v5 10/10] vfio: Extend vfio_set_migration_error() with Error* argument

2024-05-13 Thread Avihai Horon
On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments vfio_set_migration_error() sets the 'return' error on the migration stream if a migration is in progress. To improve error reporting, add a new Error* argument to also set the Error object

Re: [PATCH 1/6] block: Improve error message when external snapshot can't flush

2024-05-13 Thread Philippe Mathieu-Daudé
On 13/5/24 16:16, Markus Armbruster wrote: external_snapshot_action() reports bdrv_flush() failure to its caller as An IO error has occurred The errno code returned by bdrv_flush() is lost. Improve this to Write to node '' failed: Signed-off-by: Markus Armbruster ---

Re: Intention to work on GSoC project

2024-05-13 Thread Eugenio Perez Martin
On Mon, May 13, 2024 at 3:49 PM Sahil wrote: > > Hi, > > On Wednesday, May 8, 2024 8:53:12 AM GMT+5:30 Sahil wrote: > > Hi, > > > > On Tuesday, May 7, 2024 12:44:33 PM IST Eugenio Perez Martin wrote: > > > [...] > > > > > > > Shall I start by implementing a mechanism to check if the feature bit >

Re: [PATCH 3/6] block/vmdk: Improve error messages on extent write error

2024-05-13 Thread Philippe Mathieu-Daudé
On 13/5/24 16:17, Markus Armbruster wrote: vmdk_init_extent() reports blk_co_pwrite() failure to its caller as An IO error has occurred The errno code returned by blk_co_pwrite() is lost. Improve this to failed to write VMDK : Signed-off-by: Markus Armbruster --- block/vmdk.c

Re: [PATCH 5/6] migration: Rephrase message on failure to save / load Xen device state

2024-05-13 Thread Philippe Mathieu-Daudé
On 13/5/24 16:17, Markus Armbruster wrote: Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error),

Re: [PATCH 2/6] dump/win_dump: Improve error messages on write error

2024-05-13 Thread Philippe Mathieu-Daudé
On 13/5/24 16:16, Markus Armbruster wrote: create_win_dump() and write_run report qemu_write_full() failure to their callers as An IO error has occurred The errno set by qemu_write_full() is lost. Improve this to win-dump: failed to write header: and win-dump: failed to

Re: [PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-13 Thread Thomas Huth
On 13/05/2024 14.11, Daniel P. Berrangé wrote: On Mon, May 13, 2024 at 02:05:16PM +0200, Thomas Huth wrote: On 13/05/2024 12.28, Daniel P. Berrangé wrote: On Mon, May 13, 2024 at 12:22:50PM +0200, Thomas Huth wrote: We don't need C++ for the normal QEMU builds anymore, so installing g++ in

Re: [PATCH v2 3/3] vfio/migration: Don't emit STOP_COPY VFIO migration QAPI event twice

2024-05-13 Thread Cédric Le Goater
On 5/9/24 11:09, Avihai Horon wrote: When migrating a VFIO device that supports pre-copy, it is transitioned to STOP_COPY twice: once in vfio_vmstate_change() and second time in vfio_save_complete_precopy(). The second transition is harmless, as it's a STOP_COPY->STOP_COPY no-op transition.

[PATCH 4/6] cpus: Improve error messages on memsave, pmemsave write error

2024-05-13 Thread Markus Armbruster
qmp_memsave() and qmp_pmemsave() report fwrite() error as An IO error has occurred Improve this to writing memory to '' failed Signed-off-by: Markus Armbruster --- system/cpus.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/system/cpus.c b/system/cpus.c

[PATCH 1/6] block: Improve error message when external snapshot can't flush

2024-05-13 Thread Markus Armbruster
external_snapshot_action() reports bdrv_flush() failure to its caller as An IO error has occurred The errno code returned by bdrv_flush() is lost. Improve this to Write to node '' failed: Signed-off-by: Markus Armbruster --- blockdev.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH v2 13/33] plugins: Use DisasContextBase for qemu_plugin_insn_haddr

2024-05-13 Thread Philippe Mathieu-Daudé
Cc'ing Pierrick & Alex on this last one :) On 25/4/24 01:31, Richard Henderson wrote: We can delay the computation of haddr until the plugin actually requests it. Signed-off-by: Richard Henderson --- include/qemu/plugin.h | 4 accel/tcg/plugin-gen.c | 20

[PATCH 0/6] error: Eliminate QERR_IO_ERROR

2024-05-13 Thread Markus Armbruster
Markus Armbruster (6): block: Improve error message when external snapshot can't flush dump/win_dump: Improve error messages on write error block/vmdk: Improve error messages on extent write error cpus: Improve error messages on memsave, pmemsave write error migration: Rephrase message

[PATCH 2/6] dump/win_dump: Improve error messages on write error

2024-05-13 Thread Markus Armbruster
create_win_dump() and write_run report qemu_write_full() failure to their callers as An IO error has occurred The errno set by qemu_write_full() is lost. Improve this to win-dump: failed to write header: and win-dump: failed to save memory: This matches how dump.c reports

[PATCH 5/6] migration: Rephrase message on failure to save / load Xen device state

2024-05-13 Thread Markus Armbruster
Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error), there is no error to report, i.e. the report is

[PATCH 3/6] block/vmdk: Improve error messages on extent write error

2024-05-13 Thread Markus Armbruster
vmdk_init_extent() reports blk_co_pwrite() failure to its caller as An IO error has occurred The errno code returned by blk_co_pwrite() is lost. Improve this to failed to write VMDK : Signed-off-by: Markus Armbruster --- block/vmdk.c | 10 +- 1 file changed, 5

[PATCH 6/6] qerror: QERR_IO_ERROR is no longer used, drop

2024-05-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- include/qapi/qmp/qerror.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 00b18e9082..bc9116f76a 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @@ -20,9 +20,6 @@

Re: [PATCH v2 15/45] target/hppa: Use umax in do_ibranch_priv

2024-05-13 Thread Philippe Mathieu-Daudé
On 13/5/24 15:23, Richard Henderson wrote: On 5/13/24 13:18, Philippe Mathieu-Daudé wrote: Hi Richard, On 13/5/24 09:46, Richard Henderson wrote: Signed-off-by: Richard Henderson ---   target/hppa/translate.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 1/3] qapi/vfio: Add VFIO migration QAPI event

2024-05-13 Thread Cédric Le Goater
On 5/9/24 11:09, Avihai Horon wrote: Add a new QAPI event for VFIO migration. This event will be emitted when a VFIO device changes its migration state, for example, during migration or when stopping/starting the guest. This event can be used by management applications to get updates on the

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Zhao Liu
Cc Paolo for x86 topology part Hi Daniel, On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > Date: Mon, 13 May 2024 13:33:57 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > machine > > This effectively reverts >

Re: [PATCH v2 2/3] vfio/migration: Emit VFIO migration QAPI event

2024-05-13 Thread Cédric Le Goater
On 5/9/24 11:09, Avihai Horon wrote: Emit VFIO migration QAPI event when a VFIO device changes its migration state. This can be used by management applications to get updates on the current state of the VFIO device for their own purposes. A new per VFIO device capability, "migration-events", is

Re: [RFC PATCH v3 00/18] SMMUv3 nested translation support

2024-05-13 Thread Julien Grall
Hi Mostafa, On 29/04/2024 04:23, Mostafa Saleh wrote: Future improvements: = 1) One small improvement, that I don’t think it’s worth the extra complexity, is in case of Stage-1 TLB miss for nested translation, we can do stage-1 walk and lookup for stage-2 TLBs,

Re: [PATCH 0/2] hw/core: revert deprecation of 'parameter=1' for SMP topology

2024-05-13 Thread Ján Tomko
On a Monday in 2024, Daniel P. Berrangé wrote: Since QEMU 9.0, users are complaining that depecation messages are shown for every VM libvirt starts. This is due to the newly introduced deprecation of 'parameter=1' for -smp. This proposes reverting that, see the 1st patch for further commentary.

Re: [PATCH v5 09/10] vfio: Also trace event failures in vfio_save_complete_precopy()

2024-05-13 Thread Avihai Horon
On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments vfio_save_complete_precopy() currently returns before doing the trace event. Change that. Signed-off-by: Cédric Le Goater Reviewed-by: Avihai Horon --- hw/vfio/migration.c | 3 ---

Re: [PATCH v5 08/10] vfio: Add Error** argument to .get_dirty_bitmap() handler

2024-05-13 Thread Avihai Horon
On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments Let the callers do the error reporting. Add documentation while at it. Signed-off-by: Cédric Le Goater --- Changes in v5: - Replaced error_setg() by error_setg_errno() in

Re: [PATCH 3/3] hw/misc: Implement mailbox properties for customer OTP and device specific private keys

2024-05-13 Thread Philippe Mathieu-Daudé
On 10/5/24 16:10, Rayhan Faizel wrote: Four mailbox properties are implemented as follows: 1. Customer OTP: GET_CUSTOMER_OTP and SET_CUSTOMER_OTP 2. Device-specific private key: GET_PRIVATE_KEY and SET_PRIVATE_KEY. The customer OTP is located in the rows 36-43. The device-specific private key

Re: Intention to work on GSoC project

2024-05-13 Thread Sahil
Hi, On Wednesday, May 8, 2024 8:53:12 AM GMT+5:30 Sahil wrote: > Hi, > > On Tuesday, May 7, 2024 12:44:33 PM IST Eugenio Perez Martin wrote: > > [...] > > > > > Shall I start by implementing a mechanism to check if the feature bit > > > "VIRTIO_F_RING_PACKED" is set (using

Re: [PATCH 1/3] hw/nvram: Add BCM2835 OTP device

2024-05-13 Thread Philippe Mathieu-Daudé
On 10/5/24 16:10, Rayhan Faizel wrote: The OTP device registers are currently stubbed. For now, the device houses the OTP rows which will be accessed directly by other peripherals. Signed-off-by: Rayhan Faizel --- hw/nvram/bcm2835_otp.c | 187 +

Re: [PATCH v5 07/10] memory: Add Error** argument to memory_get_xlat_addr()

2024-05-13 Thread Avihai Horon
On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments Let the callers do the reporting. This will be useful in vfio_iommu_map_dirty_notify(). Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: David Hildenbrand Reviewed-by: Peter Xu

Re: [PATCH v2 0/4] Fix "virtio-gpu: fix scanout migration post-load"

2024-05-13 Thread Fiona Ebner
Am 13.05.24 um 15:21 schrieb Marc-André Lureau: > > Indeed, it needs: > > diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c > index 5de90bb62f..3a88eb5e3a 100644 > --- a/hw/display/virtio-gpu.c > +++ b/hw/display/virtio-gpu.c > @@ -1201,7 +1201,7 @@ static const VMStateDescription >

Re: [PATCH v5 06/10] vfio: Reverse test on vfio_get_dirty_bitmap()

2024-05-13 Thread Avihai Horon
On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments Title should be: Reverse test on vfio_get_xlat_addr()? It will simplify the changes coming after. Signed-off-by: Cédric Le Goater --- hw/vfio/common.c | 22 +- 1

Re: [PATCH 2/3] hw/arm: Connect OTP device to BCM2835

2024-05-13 Thread Philippe Mathieu-Daudé
Hi Rayhan, On 10/5/24 16:10, Rayhan Faizel wrote: Signed-off-by: Rayhan Faizel --- hw/arm/bcm2835_peripherals.c | 13 - include/hw/arm/bcm2835_peripherals.h | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) @@ -500,7 +512,6 @@ void

Re: [PATCH v5 05/10] vfio: Add Error** argument to .vfio_save_config() handler

2024-05-13 Thread Avihai Horon
On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments Use vmstate_save_state_with_err() to improve error reporting in the callers and store a reported error under the migration stream. Add documentation while at it. Reviewed-by: Philippe

Re: [PATCH 1/3] hw/nvram: Add BCM2835 OTP device

2024-05-13 Thread Philippe Mathieu-Daudé
Hi Rayhan, On 10/5/24 16:10, Rayhan Faizel wrote: The OTP device registers are currently stubbed. For now, the device houses the OTP rows which will be accessed directly by other peripherals. Signed-off-by: Rayhan Faizel --- hw/nvram/bcm2835_otp.c | 187

[Bug 2065579] Re: [UBUNTU 22.04] OS guest boot issues on 9p filesystem

2024-05-13 Thread Sergio Durigan Junior
Thank you for the report. Given that this is an upstream regression and there is a related upstream bug about it, I believe it's best to wait for their input/feedback before moving forward. ** Also affects: qemu Importance: Undecided Status: New ** No longer affects: qemu ** Changed

Re: [PATCH 1/2] copy-before-write: allow specifying minimum cluster size

2024-05-13 Thread Fiona Ebner
Am 26.03.24 um 10:06 schrieb Markus Armbruster: >> @@ -365,7 +368,13 @@ BlockCopyState *block_copy_state_new(BdrvChild *source, >> BdrvChild *target, >> >> GLOBAL_STATE_CODE(); >> >> -cluster_size = block_copy_calculate_cluster_size(target->bs, errp); >> +if (min_cluster_size &&

Re: [PATCH v2 15/45] target/hppa: Use umax in do_ibranch_priv

2024-05-13 Thread Richard Henderson
On 5/13/24 13:18, Philippe Mathieu-Daudé wrote: Hi Richard, On 13/5/24 09:46, Richard Henderson wrote: Signed-off-by: Richard Henderson ---   target/hppa/translate.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index

Re: [PATCH v5 04/10] vfio: Use new Error** argument in vfio_save_setup()

2024-05-13 Thread Avihai Horon
On 06/05/2024 12:20, Cédric Le Goater wrote: External email: Use caution opening links or attachments Nit: change commit title prefix to vfio/migration (also in other patches that are closely related to vfio migration) Plus, maybe change subject to "Add an Error** argument to

  1   2   3   >