Re: [Qemu-devel] [PATCH v3] qemu/thread: Add support for error reporting in qemu_thread_create

2017-03-22 Thread Achilles Benetopoulos
Thank you for the detailed review. The indentation errors mentioned were pure carelesness on my part, sorry about that. On 3/22/17 2:20 PM, Eric Blake wrote: >> @@ -342,13 +343,19 @@ static void pci_edu_realize(PCIDevice *pdev, Error >> **errp) >> { >> EduState *edu = DO_UPCAST(EduState, pd

[Qemu-devel] [PATCH v3] qemu/thread: Add support for error reporting in qemu_thread_create

2017-03-21 Thread Achilles Benetopoulos
Failure during thread creation in qemu_thread_create does not force the program to exit anymore, since that isn't always the desired behaviour. The caller of qemu_thread_create is responsible for the error handling. Signed-off-by: Achilles Benetopoulos --- cpus.c

[Qemu-devel] [PATCH v2] qemu/thread: Add support for error reporting in qemu_thread_create

2017-03-21 Thread Achilles Benetopoulos
Failure during thread creation in qemu_thread_create does not force the program to exit anymore, since that isn't always the desired behaviour. The caller of qemu_thread_create is responsible for the error handling. Signed-off-by: Achilles Benetopoulos --- cpus.c

[Qemu-devel] [PATCH] qemu/thread: Add support for error reporting in qemu_thread_create

2017-03-21 Thread Achilles Benetopoulos
Failure during thread creation in qemu_thread_create does not force the program to exit anymore, since that isn't always the desired behaviour. The caller of qemu_thread_create is responsible for the error handling. Signed-off-by: Achilles Benetopoulos --- cpus.c

[Qemu-devel] Make qemu_thread_create return a flag to indicate if it succeeded

2017-03-16 Thread Achilles Benetopoulos
I am interested in working on the BiteSized Task mentioned in the subject line. However, I have a question: Since the current behaviour of qemu_thread_create is to fail in the case of an error, then it seems logical to make the caller exit (in the patched version) if the return value of the call t