There are many more object files that are built conditionally. Why is
it okay not to delete them?
Perhaps they should be deleted too...
The GNU Make manual says the following about distclean:
http://www.gnu.org/s/hello/manual/make/Standard-Targets.html
Delete all files in the current
Hi Stefan,
You may drop this patch, it doesn't do anything after all...
Sorry about that.
Alexandre
On Wed, Jul 27, 2011 at 5:17 AM, Stefan Hajnoczi
stefa...@linux.vnet.ibm.com wrote:
From: Alexandre Raymond cerb...@gmail.com
This patch fixes a minor bugs which prevented QEMU from being
Indeed, I'd come to the exact same conclusion, yet I've witnessed it
both in the debugger and with trace messages...
Alexandre
On Tue, Jul 26, 2011 at 4:46 AM, Paolo Bonzini pbonz...@redhat.com wrote:
On 07/26/2011 06:58 AM, Alexandre Raymond wrote:
+#ifdef __APPLE__
+ if (sig == 0
Hi Markus,
Well, I'd expect distclean to remove exactly what *this* makefile can
build, and leave everything else alone.
I was expecting distclean to bring back the source directory to
however it was after checkout, removing anything that might have been
created by the build/configure process.
On Tue, Jul 26, 2011 at 9:08 AM, Alexandre Raymond cerb...@gmail.com wrote:
Indeed, I'd come to the exact same conclusion, yet I've witnessed it
both in the debugger and with trace messages...
Alexandre
Note that I don't think that this is a proper patch. I simply want to
verify that it solves
Hi guys,
Thank you for investigating this problem.
I finally found out why this problem occured in the first place. It is
a combination of the bug you just described and the fact that make
distclean only deletes the build directories of the targets specified
*in the last call to configure*.
Please ignore this patch series. It is most definitely wrong.
Alexandre
On Wed, Jul 20, 2011 at 1:01 AM, Alexandre Raymond cerb...@gmail.com wrote:
This series fixes a race condition that occurs under OS X.
It also reworks the signal initialization to make it simpler for later
maintenance
Two simple patches for make distclean
Alexandre Raymond (2):
Makefile: distclean should clean all possible targets
Makefile: delete config.log in distclean
Makefile |3 ++-
configure |1 +
2 files changed, 3 insertions(+), 1 deletions(-)
--
1.7.5
distclean
as it will only remove the i386-softmmu build directory, although the
first build created additional directories.
Solution : pass the full list of targets from configure to make via
the DEFAULT_TARGET_LIST variable.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
Makefile |2
Distclean should remove anything created by the configure script.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
Makefile |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 878402e..9f65d86 100644
--- a/Makefile
+++ b/Makefile
@@ -224,6
Hi Damjan,
I've been able to reproduce the crash you're describing.
Could you try the following patch, to see if it solves it?
Alexandre
On Tue, Jul 5, 2011 at 3:03 PM, Alexandre Raymond cerb...@gmail.com wrote:
Hi again Damjan,
On Mon, Jul 4, 2011 at 6:35 PM, Damjan Marion damjan.mar
Add a new binary and generation directory to the gitignore file
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
.gitignore |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 08013fc..54835bc 100644
--- a/.gitignore
+++ b/.gitignore
-Create cscope symbols for assembly files in addition to .c/.h files.
-Create cscope database with full path instead of relative path so cscope
can be used with CSCOPE_DB in any directory.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
Makefile |2 +-
1 files changed, 1 insertions
if there is a specific reason why SIGUSR2 is not currently
handled via the signal thread?
Alexandre Raymond (2):
Signals: fix race condition with aio-compat
Signals: rework initial signal setup
cpus.c | 43 +++
1 files changed, 23 insertions(+), 20
-Restructure the signal setup by creating two groups:
* blocked_set, which contains signals that are ignored by QEMU or caught
directly by a specific thread (e.g.: SIG_IPI).
* handled_set, which contains signals handled synchronously via signalfd.
Signed-off-by: Alexandre
ping?
On Tue, Jun 14, 2011 at 12:47 PM, Jan Kiszka jan.kis...@siemens.com wrote:
On 2011-06-14 16:05, Alexandre Raymond wrote:
Changes since v1:
- take pthread_sigmask() out of the ifdef as it is now common
to both parts.
This fix effectively blocks, in the main thread, the signals handled
ping?
On Wed, Jun 15, 2011 at 10:11 AM, Alexandre Raymond cerb...@gmail.com wrote:
Hi Jan,
Why? Ahh, because of qemu_cpu_kick_self: raise(SIG_IPI)! That should
generate a per-process SIG_IPI. And that may not only affect Darwin.
Looks good.
Actually, with io-thread enabled, it goes through
Hi again Damjan,
On Mon, Jul 4, 2011 at 6:35 PM, Damjan Marion damjan.mar...@gmail.com wrote:
On Jul 4, 2011, at 6:59 PM, Alexandre Raymond wrote:
Hi Damjan,
Can you try applying the following two patches and see if it solves
your problem?
http://patchwork.ozlabs.org/patch/100348/
http
Hi Damjan,
On Fri, Jul 1, 2011 at 10:56 AM, Damjan Marion damjan.mar...@gmail.com wrote:
On Jul 1, 2011, at 11:17 AM, Damjan Marion (damarion) wrote:
Hi,
I have an issue when I try to run qemu-system-arm on Mac OS X.
Sometime between 1 and 15 secs after qemu is started it crashes
as
Hi Andreas,
This fixes Darwin/ppc64 (and ppc) v10.5.
Don't know whether v10.6 / i386 might have a working implementation (cc'ing
Alexand{re,er}).
In 10.6, I get the following error when I try to compile a simple getcontext():
/usr/include/ucontext.h:42:2: error: #error ucontext routines are
Sorry for the delay.
Commit 744d3644181ddb16ef5944a0f9217e46961c8c84 works fine on OSX 10.6.
Alexandre
On Thu, Jun 23, 2011 at 10:58 AM, malc av1...@comtv.ru wrote:
On Thu, 23 Jun 2011, Andreas F?rber wrote:
OSStatus type is defined as SInt32. That's signed int on __LP64__ and
signed long
a couple of weeks ago.
Alexandre
--
Tested-by: Alexandre Raymond cerb...@gmail.com
Hi Jan,
On Thu, Jun 16, 2011 at 5:31 AM, Jan Kiszka jan.kis...@siemens.com wrote:
Ingo Molnar pointed out that sending the timer signal to the whole
process, just blocking it everywhere, is suboptimal with an increasing
number of threads. QEMU is using this pattern so far.
I am not familiar
Hi Jan,
Why? Ahh, because of qemu_cpu_kick_self: raise(SIG_IPI)! That should
generate a per-process SIG_IPI. And that may not only affect Darwin.
Looks good.
Actually, with io-thread enabled, it goes through qemu_cpu_kick_self()
- qemu_cpu_kick_thread() - pthread_kill(..., SIG_IPI).
I think
sigfd_handler() instead of triggering the signal handler
directly, asynchronously.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
cpus.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpus.c b/cpus.c
index 4ab76f0..18a1522 100644
--- a/cpus.c
+++ b/cpus.c
@@ -399,7
Hi Jan,
Thanks for reviewing my patch.
But please pull the now common pthread_sigmask out of the #ifdef.
Please see v2.
Alexandre
by the cpu
thread.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
cpus.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/cpus.c b/cpus.c
index 18a1522..84ffd1c 100644
--- a/cpus.c
+++ b/cpus.c
@@ -394,10 +394,18 @@ static int qemu_signal_init(void
filed - failed
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
cpus.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpus.c b/cpus.c
index 1fc34b7..4ab76f0 100644
--- a/cpus.c
+++ b/cpus.c
@@ -297,7 +297,7 @@ static void qemu_event_increment(void
-by: Alexandre Raymond cerb...@gmail.com
---
cpus.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/cpus.c b/cpus.c
index 4ab76f0..b6366b5 100644
--- a/cpus.c
+++ b/cpus.c
@@ -411,6 +411,7 @@ static int qemu_signal_init(void)
sigaddset(set, SIGIO);
sigaddset(set
Tested-by: Alexandre Raymond cerb...@gmail.com
That's definitely a better patch ;-)
Thanks,
Alexandre
On Thu, Jun 9, 2011 at 3:03 PM, Andreas Färber andreas.faer...@web.de wrote:
Avoid compiler confusion as to which method signature to use for the
handleEvent: selector on OSX = 10.6
On Wed, Jun 8, 2011 at 6:55 PM, Alexander Graf ag...@suse.de wrote:
Qemu uses signalfd to figure out, if a signal occured without the need
to actually receive the signal. Instead, it can read from the fd to receive
its news.
Now, we obviously don't always have signalfd around. Especially not
Hi Nathan,
On Sun, Jun 5, 2011 at 10:03 AM, Nathan Whitehorn
nwhiteh...@freebsd.org wrote:
On 06/02/11 10:01, Andreas Färber wrote:
Am 31.05.2011 um 16:57 schrieb Nathan Whitehorn:
Add some includes required to build qemu on FreeBSD.
Missing Sob.
Oops, I'll resubmit.
---
Hi Andreas,
On Tue, May 31, 2011 at 4:07 PM, Andreas Färber andreas.faer...@web.de wrote:
Hello Alexandre,
Am 30.05.2011 um 00:36 schrieb Alexandre Raymond:
This fix forces a message to be sent to the handleEvent method
of the QemuCocoaView class instead of letting the system determine
before including stdlib.h
and declares it manually as an extern function. This way, the compiler does not
see the declaration from stdlib.h and thus does not display the warning.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
osdep.h |1 +
oslib-posix.c | 15 +++
qemu
at 11:44 AM, Blue Swirl blauwir...@gmail.com wrote:
On Fri, Jun 3, 2011 at 6:26 AM, Alexandre Raymond cerb...@gmail.com wrote:
This patch removes all references to signal.h when qemu-common.h is included
as they become redundant.
This breaks the build. Maybe it depends on some previous patch
On Thu, Jun 2, 2011 at 6:13 AM, Andreas Färber andreas.faer...@web.de wrote:
Am 02.06.2011 um 04:21 schrieb Alexandre Raymond:
Fix the following warning by including signal.h directly in qemu-common.h
8
iohandler.c: In function ‘qemu_init_child_watch’:
iohandler.c:172: warning
Hi Andreas,
On Thu, Jun 2, 2011 at 8:09 AM, Andreas Färber andreas.faer...@web.de wrote:
Am 02.06.2011 um 04:45 schrieb Alexandre Raymond:
On OSX 10.5, daemon() is deprecated, resulting int he following warning:
= 10.5
http://developer.apple.com/library/mac/#documentation/Darwin/Reference
Thanks Stefan,
Should I send a follow-up patch to remove signal.h wherever
qemu-common.h is already included?
Alexandre
On Thu, Jun 2, 2011 at 6:44 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Thu, Jun 2, 2011 at 3:21 AM, Alexandre Raymond cerb...@gmail.com wrote:
Fix the following
This patch removes all references to signal.h when qemu-common.h is included
as they become redundant.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
audio/audio_pt_int.c |2 --
audio/sdlaudio.c |1 -
block/raw-posix.c |2 --
bsd-user/syscall.c|1 -
darwin
-by: Alexandre Raymond cerb...@gmail.com
---
qemu-common.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
index b851b20..39fabc9 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -39,6 +39,7 @@ typedef struct Monitor Monitor;
#include sys/stat.h
://www.opensource.apple.com/source/mDNSResponder/mDNSResponder-258.18/mDNSPosix/PosixDaemon.c
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
qemu-nbd.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index e858033..10b0791 100644
that this really is The Right Way to check.
In fact, unistd.h defines this value to -1, at least on OSX 10.6.7.
Add this check to the configure file.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
Andreas
---
configure | 8 +++-
1 files changed, 7 insertions(+), 1 deletions
Under darwin (OS X 10.6.7), a symbol exists for the fdatasync() method
but it is not supported because _POSIX_SYNCHRONIZED_IO is set to '-1'.
Enable fdatasync() only if _POSIX_SYNCHRONIZED_IO is '0', as per
The Open Group Base Specifications Issue 7.
Signed-off-by: Alexandre Raymond cerb
There was already a check in place to avoid displaying a window
in certain modes such as vnc, nographic or curses.
Add a check for '-h' and '-help' to avoid displaying a window for a split-
second before showing the usage information.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
ui
by Andreas
* use '%td' in patch 5 instead of '%d'
* remove patch 6; has already been taken into account by Stefan W.
Thanks everyone for your feedback.
Alexandre
Alexandre Raymond (3):
Darwin: Fix incorrect check for fdatasync() in configure
Cocoa: avoid displaying window when command-line contains
: multiple methods named ‘-handleEvent:’ found
/System/Library/Frameworks/AppKit.framework/Headers/NSTextInputContext.h:84:
warning: using ‘-(BOOL)handleEvent:(NSEvent *)theEvent’
ui/cocoa.m:272: warning: also found ‘-(void)handleEvent:(NSEvent *)event’
8---
Signed-off-by: Alexandre Raymond
Hello everyone,
The following series contains trivial patches to fix several minor issues
encountered while compiling qemu under OSX 10.6.7.
I used [./configure --disable-bsd-user --disable-darwin-user --enable-io-thread]
to configure the build.
Cheers,
Alexandre
Alexandre Raymond (6):
Fix
, unistd.h defines this value to -1, at least on OSX 10.6.7.
Add this check to the configure file.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
configure |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index a318d37..b21ef75 100755
There was already a check in place to avoid displaying a window
in certain modes such as vnc, nographic or curses.
Add a check for '-h' to avoid displaying a window for a split-
second before showing the usage information.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
ui/cocoa.m |3
to describe their relative difference.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
target-lm32/translate.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-lm32/translate.c b/target-lm32/translate.c
index eb21158..0f69f27 100644
--- a/target-lm32
: warning: assignment discards qualifiers from pointer
target type
(...)
-8-
Signed-off-by: Alexandre Raymond cerb...@gmail.com
---
audio/coreaudio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/audio/coreaudio.c b/audio/coreaudio.c
index 0a26413..3bd75cd 100644
-by: Alexandre Raymond cerb...@gmail.com
---
vl.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index b362871..b983646 100644
--- a/vl.c
+++ b/vl.c
@@ -107,6 +107,7 @@ int main(int argc, char **argv)
#endif /* CONFIG_SDL */
#ifdef CONFIG_COCOA
+int qemu_main
8
qemu/target-s390x/helper.c:32:23: warning: linux/kvm.h: No such file or director
8
kvm.h, which is included right after this line, already includes linux/kvm.h
with the proper CONFIG_KVM guard. Remove redundant include.
Signed-off-by: Alexandre Raymond cerb...@gmail.com
:22, schrieb Alexandre Raymond:
8
qemu/target-lm32/translate.c: In function
‘gen_intermediate_code_internal’:
qemu/target-lm32/translate.c:1135: warning: format ‘%zd’ expects
type ‘signed size_t’, but argument 4 has type ‘int’
8
Both gen_opc_ptr and gen_opc_buf are uint16_t
54 matches
Mail list logo
