Re: [RFC PATCH v1 0/8] qapi: add generator for Golang interface

2022-04-29 Thread Andrea Bolognani
On Thu, Apr 28, 2022 at 03:50:55PM +0200, Markus Armbruster wrote: > Andrea Bolognani writes: > > One concern that I have is about naming struct members: things like > > SpiceInfo.MouseMode and most others are translated from the QAPI > > schema exactly the way you'd expect

Re: [PATCH] qapi: Fix malformed "Since:" section tags

2022-04-22 Thread Andrea Bolognani
> qapi/crypto.json | 3 +-- > qapi/machine.json| 2 +- > qapi/misc.json | 2 +- > qga/qapi-schema.json | 2 +- > 4 files changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: Create qemu-project/py-qemu.qmp repo

2022-04-22 Thread Andrea Bolognani
On Thu, Apr 21, 2022 at 05:00:16PM -0400, John Snow wrote: > On Thu, Apr 21, 2022, 2:00 PM Andrea Bolognani wrote: > > I think I would go with "python-qemu-qmp". Having a dot in the name > > of a git repo is not very common AFAICT, and I wouldn't rule out the >

Re: Create qemu-project/py-qemu.qmp repo

2022-04-21 Thread Andrea Bolognani
really keen on saving those few extra keystrokes, maybe "pyqemu" is a better prefix than "py-qemu"? I don't know, it just looks more natural to me. -- Andrea Bolognani / Red Hat / Virtualization

[PATCH 2/2] docs: build-platforms: Clarify stance on minor releases and backports

2022-04-20 Thread Andrea Bolognani
changes made to the latter. The policy is not altered significantly - we're simply spelling out some rules that were likely already being implicitly enforced. Signed-off-by: Andrea Bolognani --- docs/about/build-platforms.rst | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs

Re: [PATCH 2/2] docs: build-platforms: Clarify stance on minor releases and backports

2022-04-20 Thread Andrea Bolognani
On Wed, Apr 20, 2022 at 05:15:08PM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 20, 2022 at 06:03:11PM +0200, Andrea Bolognani wrote: > > These changes match those made in the following libvirt commits: > > > > 2ac78307af docs: Clarify our stance on backported packages

[PATCH 1/2] docs: build-platforms: Fix spelling for Homebrew

2022-04-20 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/about/build-platforms.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/about/build-platforms.rst b/docs/about/build-platforms.rst index c29a4b8fe6..e9163ba556 100644 --- a/docs/about/build-platforms.rst +++ b/docs/about

[PATCH 0/2] docs: build-platforms: Fix and clarify

2022-04-20 Thread Andrea Bolognani
Andrea Bolognani (2): docs: build-platforms: Fix spelling for Homebrew docs: build-platforms: Clarify stance on minor releases and backports docs/about/build-platforms.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- 2.35.1

[PATCH 3/3] qapi: Fix typo

2022-04-20 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- qapi/sockets.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/sockets.json b/qapi/sockets.json index 5773d9fcc4..fccc38584b 100644 --- a/qapi/sockets.json +++ b/qapi/sockets.json @@ -149,7 +149,7 @@ # # Note: This type

[PATCH 2/3] qapi: Fix documentation for query-xen-replication-status

2022-04-20 Thread Andrea Bolognani
The correct return type is ReplicationStatus, not ReplicationResult. Signed-off-by: Andrea Bolognani --- qapi/migration.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index 27d7b28158..409eb086a2 100644 --- a/qapi

[PATCH 1/3] docs: qapi: Remove outdated reference to simple unions

2022-04-20 Thread Andrea Bolognani
Commit 4e99f4b12c0e dropped simple unions and updated most documentation accordingly, but in one case we still claim that there are "two flavors of unions". Signed-off-by: Andrea Bolognani --- docs/devel/qapi-code-gen.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 0/3] qapi: Random small fixes

2022-04-20 Thread Andrea Bolognani
Andrea Bolognani (3): docs: qapi: Remove outdated reference to simple unions qapi: Fix documentation for query-xen-replication-status qapi: Fix typo docs/devel/qapi-code-gen.rst | 4 ++-- qapi/migration.json | 2 +- qapi/sockets.json| 2 +- 3 files changed, 4

Re: [RFC PATCH v1 0/8] qapi: add generator for Golang interface

2022-04-19 Thread Andrea Bolognani
On Tue, Apr 19, 2022 at 11:12:28AM -0700, Andrea Bolognani wrote: > Dealing with errors and commands that don't have a return value might > require us to have generic CommandResult wrapper after all, but we > should really try as hard as we can to stick to type safe interfaces. On secon

Re: [RFC PATCH v1 0/8] qapi: add generator for Golang interface

2022-04-19 Thread Andrea Bolognani
nd, and that the application has to explicitly spell out what kind of object it expects to get as output. I'm attaching an incomplete implementation that I used for playing around. It's obviously too simplistic, but hopefully it will help illustrate my point. Dealing with errors and commands that don'

Re: [PATCH 01/10] python/aqmp: add explicit GPLv2 license to legacy.py

2022-03-24 Thread Andrea Bolognani
at if we're going to do a > relicensing at all, and your goal is to encourage usage, then GPLv2+ > is the wrong choice. Use LGPLv2+ if you want to facilitate usage, while > retaining a copyleft license. Does LGPL make sense in the context of Python, where there is no linking? -- Andrea Bolognani / Red Hat / Virtualization

Re: qemu crash 100% CPU with Ubuntu10.04 guest (solved)

2022-02-17 Thread Andrea Bolognani
; e.g. --os-variant ubuntu10.04 FWIW, the --os-variant / --osinfo argument is going to be mandatory starting with the upcoming virt-manager release. https://listman.redhat.com/archives/virt-tools-list/2022-February/msg00021.html -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 2/2] tests: Update CentOS 8 container to CentOS Stream 8

2022-02-01 Thread Andrea Bolognani
e QEMU developers and maintainers. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 2/2] tests: Update CentOS 8 container to CentOS Stream 8

2022-02-01 Thread Andrea Bolognani
On Tue, Feb 01, 2022 at 06:02:21PM +, Daniel P. Berrangé wrote: > On Tue, Feb 01, 2022 at 09:08:22AM -0800, Andrea Bolognani wrote: > > CentOS 8 and CentOS Stream 8 are two pretty distinct operating > > systems in terms of update cadence and stability expectations, so I >

Re: [PATCH 2/2] tests: Update CentOS 8 container to CentOS Stream 8

2022-02-01 Thread Andrea Bolognani
containers and CI jobs that are actually consuming CentOS Stream 8 is going to be a source of confusion. I recommend proceeding with a thorough rename, after which the string "centos8" no longer shows up anywhere, instead. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 0/3] meson: Don't pass 'method' to dependency()

2022-01-19 Thread Andrea Bolognani
On Wed, Jan 19, 2022 at 05:38:38PM +, Daniel P. Berrangé wrote: > On Wed, Jan 19, 2022 at 06:17:57PM +0100, Andrea Bolognani wrote: > > See [1] for recent discussion about libgcrypt specifically, which the > > first patch is about. > > > > After w

[PATCH 1/3] meson: Don't force use of libgcrypt-config

2022-01-19 Thread Andrea Bolognani
-off-by: Andrea Bolognani --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index 762d7cee85..bc17ba67fd 100644 --- a/meson.build +++ b/meson.build @@ -1036,7 +1036,6 @@ endif if not gnutls_crypto.found() if (not get_option('gcrypt').auto

[PATCH 3/3] docs: Don't recommend passing 'method' to dependency()

2022-01-19 Thread Andrea Bolognani
Meson will do the right thing by default. Signed-off-by: Andrea Bolognani --- docs/devel/build-system.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst index 431caba7aa..fcdc0cd187 100644 --- a/docs/devel/build-system.rst +++ b/docs

[PATCH 0/3] meson: Don't pass 'method' to dependency()

2022-01-19 Thread Andrea Bolognani
://lists.gnu.org/archive/html/qemu-devel/2022-01/msg01224.html Andrea Bolognani (3): meson: Don't force use of libgcrypt-config meson: Don't pass 'method' to dependency() docs: Don't recommend passing 'method' to dependency() docs/devel/build-system.rst | 1 - meson.build | 75

[PATCH 2/3] meson: Don't pass 'method' to dependency()

2022-01-19 Thread Andrea Bolognani
Meson will do the right thing by default. Signed-off-by: Andrea Bolognani --- meson.build | 74 - tcg/meson.build | 2 +- 2 files changed, 31 insertions(+), 45 deletions(-) diff --git a/meson.build b/meson.build index bc17ba67fd..b807ad9fbb

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2022-01-07 Thread Andrea Bolognani
On Fri, Jan 07, 2022 at 12:06:47PM +, Daniel P. Berrangé wrote: > On Fri, Jan 07, 2022 at 12:55:42PM +0100, Thomas Huth wrote: > > On 07/01/2022 12.43, Andrea Bolognani wrote: > > > On Thu, Aug 29, 2019 at 10:15:05AM +0100, Daniel P. Berrangé wrote: > > > > W

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2022-01-07 Thread Andrea Bolognani
gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=97194b422bc89a6137f4e218d4cdee118c63e96e libgcrypt 1.9.0, released almost exactly a year ago, comes with a pkg-config file out of the box. With that in mind, I think it would make sense to re-evaluate this patch for inclusion. -- Andrea Bolognani / Red Hat / Virtualization

Re: [qemu-web PATCH] remove deployment phase from CI

2021-11-03 Thread Andrea Bolognani
On Wed, Nov 03, 2021 at 09:14:59AM +0100, Paolo Bonzini wrote: > qemu.org is now served via a reverse proxy from qemu-project.gitlab.io; it > does > not need anymore the rsync step to the QEMU project\s shell server. *project's -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-01 Thread Andrea Bolognani
erface point of view, thanks for addressing the concerns that were raised! I'll leave Drew to review the actual code changes :) -- Andrea Bolognani / Red Hat / Virtualization

Re: Serious doubts about Gitlab CI

2021-03-31 Thread Andrea Bolognani
Dockerfile doesn't contain instructions to create a symlink for clang: https://gitlab.com/libvirt/libvirt/-/blob/master/ci/containers/fedora-rawhide.Dockerfile#L105-107 It's simply a bug in lcitool that needs to be addressed. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 0/3] target/arm: Add nested virtualization support

2021-03-22 Thread Andrea Bolognani
nt implementation there's no way to tell whether nested KVM will be usable short of trying and seeing whether QEMU errors out. -- Andrea Bolognani / Red Hat / Virtualization

Re: minimal "zero conf" build dockerfiles for fedora:latest and alpine:latest

2021-01-14 Thread Andrea Bolognani
As a data point, the libvirt project has made it an explicit goal[1] to remove all usage of Perl in favor of Python. We're not quite there yet, but at this point there are only a very tiny handful of Perl scripts remaining in the repository. [1] https://libvirt.org/strategy.html -- Andrea Bolognani / Red Hat / Virtualization

Re: Command line QAPIfication and -readconfig

2020-11-12 Thread Andrea Bolognani
\ # -nodefaults \ # -readconfig mach-virt-serial.cfg \ # -display none -serial mon:stdio \ # -cpu host because it was simply impossible to provide QEMU with all the settings necessary to obtain the desired virtual hardware using the configuration file only. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH v4 2/4] Jobs based on custom runners: build environment docs and playbook

2020-11-10 Thread Andrea Bolognani
On Mon, 2020-11-09 at 11:37 -0500, Cleber Rosa wrote: > On Tue, Oct 20, 2020 at 07:52:43PM +0200, Andrea Bolognani wrote: > > On Sun, 2020-10-18 at 21:50 -0400, Cleber Rosa wrote: > > > +- name: Install basic packages to build QEMU on FreeBSD 12.x

Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-20 Thread Andrea Bolognani
creation of the package lists that > the tests/vm and ansibile recipes need, as again those are all > inconsistent. Perhaps 'lcitool variables' could be of use here. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH v4 2/4] Jobs based on custom runners: build environment docs and playbook

2020-10-20 Thread Andrea Bolognani
'8'" Another option would be to use command: 'dnf config-manager --set-enabled Stream-PowerTools -y' args: warn: no but I have to admit the way you're doing it is very clever ;) -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH v2 03/15] python: add VERSION file

2020-10-20 Thread Andrea Bolognani
be updating both QEMU & Python together. Once you start uploading the Python packages to PyPi, you really have no way to ensure this will be the case. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH v2 03/15] python: add VERSION file

2020-10-20 Thread Andrea Bolognani
On Mon, 2020-10-19 at 11:02 +0100, Daniel P. Berrangé wrote: > On Mon, Oct 19, 2020 at 11:45:09AM +0200, Andrea Bolognani wrote: > > I think this need to be considered very carefully. > > > > I'm not overly familiar with the Python ecosystem but it would appear >

Re: [PATCH v2 03/15] python: add VERSION file

2020-10-19 Thread Andrea Bolognani
do the same; in particular, using a version number that's not <1.0.0 for a package that is very much in flux will almost certainly break people's expectations, and is also not something that you can easily take back at a later time. -- Andrea Bolognani / Red Hat / Virtualization

Re: [RFC DOCUMENT 00/12] kubevirt-and-kvm: Add documents

2020-09-24 Thread Andrea Bolognani
ms out > of the scope of the "better understanding and documenting the > interactions between KubeVirt and KVM" and looks like left over > notes. That's probably because they absolutely are O:-) > Maybe renaming the "Other topics" section would help. > "Una

Re: Python 3.5 EOL; when can require 3.6?

2020-09-17 Thread Andrea Bolognani
On Thu, 2020-09-17 at 17:35 +0100, Daniel P. Berrangé wrote: > On Thu, Sep 17, 2020 at 06:07:00PM +0200, Andrea Bolognani wrote: > > It would be *fantastic* if we could keep the platform support policy > > used by QEMU and libvirt as aligned as reasonably possible. > > Th

Re: Python 3.5 EOL; when can require 3.6?

2020-09-17 Thread Andrea Bolognani
*fantastic* if we could keep the platform support policy used by QEMU and libvirt as aligned as reasonably possible. -- Andrea Bolognani / Red Hat / Virtualization

[RFC DOCUMENT 11/12] kubevirt-and-kvm: Add Backpropagation page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Backpropagation.md # Backpropagation Whenever a partial VM configuration is submitted to libvirt, any missing information is automatically filled in to obtain a configuration that's complete enough to guarantee long-term guest ABI

[RFC DOCUMENT 12/12] kubevirt-and-kvm: Add Contacts page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Contacts.md # Contacts and credits # Contacts The following people have agreed to serve as points of contact for follow-up discussion around the topics included in these documents. ## Overall * Andrea Bolognani <> (KVM user

[RFC DOCUMENT 10/12] kubevirt-and-kvm: Add Upgrades page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Upgrades.md # Upgrades The KubeVirt installation and upgrade process are entirely controlled by an [operator][], which is a common pattern in the Kubernetes world. The operator is a piece of software running in the cluster and managing

[RFC DOCUMENT 09/12] kubevirt-and-kvm: Add Isolation page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Isolation.md # Isolation How is the QEMU process isolated from the host and from other VMs? ## Traditional virtualization cgroups * managed by libvirt SELinux * libvirt is privileged and QEMU is protected by SELinux policies set

[RFC DOCUMENT 08/12] kubevirt-and-kvm: Add NUMA Pinning page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/NUMA-Pinning.md # NUMA pinning KubeVirt doesn't currently implement NUMA pinning due to Kubernetes limitation. ## Kubernetes Topology Manager Allows aligning CPU and peripheral device allocations by NUMA node. Many limitations: * Not

[RFC DOCUMENT 07/12] kubevirt-and-kvm: Add CPU Pinning page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/CPU-Pinning.md # CPU pinning As is the case for many of KubeVirt's features, CPU pinning is partially achieved using standard Kubernetes components: this both reduces the amount of new code that has to be written and guarantees better

[RFC DOCUMENT 06/12] kubevirt-and-kvm: Add Live Migration page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Live-Migration.md # Live Migration There are two scenarios where live migration is triggered in KubeVirt * As per user request, by posting a `VirtualMachineInstanceMigration` to the cluster * As per cluster request, for instance on a

[RFC DOCUMENT 02/12] kubevirt-and-kvm: Add Components page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Components.md # Components This document describes the various components of the KubeVirt architecture, how they fit together, and how they compare to the traditional virtualization architecture (QEMU + libvirt). ## Traditional

[RFC DOCUMENT 05/12] kubevirt-and-kvm: Add Networking page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Networking.md # Networking ## Problem description Service meshes (such as [Istio][], [Linkerd][]) typically expect application processes to run on the same physical host, usually in a separate user namespace. Network namespaces might be

[RFC DOCUMENT 03/12] kubevirt-and-kvm: Add Hotplug page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Hotplug.md # Hotplug In Kubernetes, pods are defined to be immutable, so it's not possible to perform hotplug of devices in the same way as with the traditional virtualization stack. This limitation is a result of KubeVirt's guiding

[RFC DOCUMENT 04/12] kubevirt-and-kvm: Add Storage page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Storage.md # Storage This document describes the known use-cases and architecture options we have for Linux Virtualization storage in [KubeVirt][]. ## Problem description The main goal of Kubevirt is to leverage the storage subsystem

[RFC DOCUMENT 01/12] kubevirt-and-kvm: Add Index page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Index.md # KubeVirt and the KVM user space This is the entry point to a series of documents which, together, detail the current status of KubeVirt and how it interacts with the KVM user space. The intended audience is people who are

[RFC DOCUMENT 00/12] kubevirt-and-kvm: Add documents

2020-09-16 Thread Andrea Bolognani
knowledge, all accurate, some parts are in a rougher state than others. Improvements will hopefully come over time - and if you feel like helping out in making that happen, it would certainly be appreciated! Looking forward to your feedback :) [1] https://gitlab.com/abologna/kubevirt-and-kvm -- Andrea

Re: Python 3.5 EOL; when can require 3.6?

2020-09-16 Thread Andrea Bolognani
oldest dropped from > our side) we can add/remove a column and see the oldest version we aim > to support. In case you're not already aware of it, https://repology.org/ is a very valuable tool when it comes to figuring out minimum versions for dependencies. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-09-04 Thread Andrea Bolognani
1cb3daba59069429d9665b I'm not sure why gitlab-runner would use a fork rather than the primary repository, but perhaps they can be convinced to switch and gain better FreeBSD support in the process. -- Andrea Bolognani / Red Hat / Virtualization

[PATCH] schemas: Add vim modeline

2020-07-29 Thread Andrea Bolognani
comments for vim. Signed-off-by: Andrea Bolognani --- docs/interop/firmware.json| 1 + docs/interop/vhost-user.json | 1 + qapi/authz.json | 1 + qapi/block-core.json | 1 + qapi/block.json | 1

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

2020-07-09 Thread Andrea Bolognani
te a container image for it and add it to the mix. Additionally, the gitlab-runner Docker executor provides more isolation than the shell executor, so running untrusted builds becomes a more reasonable proposition - this is how the shared runners on gitlab.com work - and you don't have to worry about your jobs cleaning up properly after themselves nearly as much. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 0/5] QEMU Gating CI

2020-04-27 Thread Andrea Bolognani
ch good to go. Installation of VMs we already perform in an unattended fashion using preseed/kickstart, and it should be relatively straighforward to adapt those configurations to also work on real hardware. This way we'd both be able to rely on having a sane OS as the base, and relieve the administrator from the duty of manually installing the machines. -- Andrea Bolognani / Red Hat / Virtualization

[PATCH] qapi: Expand documentation for LostTickPolicy

2020-02-11 Thread Andrea Bolognani
of view. Signed-off-by: Andrea Bolognani --- This information is reported pretty much word by word in https://libvirt.org/formatdomain.html#elementsTime so I'm hoping I can get the QEMU documentation updated and then just merge back the changes. qapi/misc.json | 34

Re: Making QEMU easier for management tools and applications

2020-02-03 Thread Andrea Bolognani
aving access to a user interface that doesn't require either rigging up libvirt support or messing with JSON directly, and such an interface could even look very similarly to the current CLI, but it could simply not be made user-facing and thus not subject to any compatibility concerns. [1] https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg06034.html -- Andrea Bolognani / Red Hat / Virtualization virt-run Description: application/shellscript

Re: [RFC PATCH v3 0/6] target/arm/kvm: Adjust virtual time

2020-01-31 Thread Andrea Bolognani
ed approach in 5/6 to properly deal with migration and to >track running vs. !running, rather than running vs. paused states. Probably too late since Peter already queued the series, but FWIW Tested-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH qemu v5] spapr: Kill SLOF

2020-01-28 Thread Andrea Bolognani
and let grub do filesystems and MBR/GPT. > > I don't want that to be the only way, because I want the GRUB > installed by the OS installer to be the GRUB we use. Agreed, the bootloader and the kernel should live inside the guest image and not on the host's filesystem. -- Andrea Bolognani / Red Hat / Virtualization

Re: [RFC PATCH qemu] spapr: Kill SLOF

2020-01-13 Thread Andrea Bolognani
On Wed, 2020-01-08 at 13:34 +1100, Alexey Kardashevskiy wrote: > On 07/01/2020 20:39, Andrea Bolognani wrote: > > On Tue, 2020-01-07 at 12:55 +1100, Alexey Kardashevskiy wrote: > > > Petitboot kernel+initramdisk almost replaces SLOF + GRUB. > > > > Is this necessari

Re: [RFC PATCH qemu] spapr: Kill SLOF

2020-01-07 Thread Andrea Bolognani
amdisk almost replaces SLOF + GRUB. Is this necessarily a good thing? Personally I quite like the fact that I can use the same bootloader across x86, ppc64 and aarch64. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-12-10 Thread Andrea Bolognani
be to adjust the time then I don't expect many people will actually need to use the parameter, so the name doesn't matter that much after all :) -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-12-10 Thread Andrea Bolognani
On Tue, 2019-12-10 at 15:33 +0100, Andrew Jones wrote: > On Tue, Dec 10, 2019 at 03:21:02PM +0100, Andrea Bolognani wrote: > > I agree with everything except the naming: why would > > > > kvm-no-adjvtime=off vtime is adjusted (default) > > kvm-no-adjvtime

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-12-10 Thread Andrea Bolognani
advantage of not introducing any unwieldy double negatives. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-12-10 Thread Andrea Bolognani
ing workarounds, dos and don'ts. With that in mind, in my opinion it would make sense to make kvm-adjvtime=on the behavior for newer machine types so that people coming from an x86 background and/or having to manage both at the same time will get a consistent experience and will be able to draw, even for aarch64, on the considerable amount of existing x86-centric literature on the subject. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH-for-5.0] roms/edk2-funcs.sh: Use available GCC for ARM/Aarch64 targets

2019-12-05 Thread Andrea Bolognani
ps CentOS 8, not sure). > > Unfortunately CentOS 8 is not available as a Docker image, which is a > convenient way to build EDK2 in a CI. Uh? https://hub.docker.com/_/centos seems to disagree with you. Is the 'centos:8' image not suitable for some non-obvious reason? -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] git.qemu.org gitweb misrenders on git/ URLs

2019-08-29 Thread Andrea Bolognani
sy to setup. Maybe consider switching from gitweb to it? -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [PATCH v3 00/15] target/arm/kvm: enable SVE in guests

2019-08-20 Thread Andrea Bolognani
ing the modified libvirt version, and that your guest is configured to use the modified QEMU binary? Anyway, once v4 has been posted I'll respin the libvirt series as well, since in the meantime conflicts have popped up and it no longer applies cleanly on top of master. -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

2019-08-15 Thread Andrea Bolognani
On Wed, 2019-08-14 at 17:14 +0200, Philippe Mathieu-Daudé wrote: > On 8/14/19 4:51 PM, Andrea Bolognani wrote: > > On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daudé wrote: > > > On 8/14/19 3:27 PM, Andrea Bolognani wrote: > > > > On Wed, 2019-08-14 at 14:15

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

2019-08-14 Thread Andrea Bolognani
On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daudé wrote: > On 8/14/19 3:27 PM, Andrea Bolognani wrote: > > On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote: > > > The libssh packaged by a distribution can predate version 0.8, > > > but still provid

Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API

2019-08-14 Thread Andrea Bolognani
h.o] Error 1 > > Fix by using the newer API if available. > > Suggested-by: Andrea Bolognani > Signed-off-by: Philippe Mathieu-Daudé > --- > block/ssh.c | 2 +- > configure | 7 +++ > 2 files changed, 8 insertions(+), 1 deletion(-) Did I really suggest this? I ha

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Andrea Bolognani
On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: > On Tue, 30 Jul 2019 12:25:30 +0200 > Andrea Bolognani wrote: > > Can you please make sure virtio-mmio uses the existing interface > > instead of introducing a new one? > > FWIW, I really hate virtio-pci's disab

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Andrea Bolognani
ease make sure virtio-mmio uses the existing interface instead of introducing a new one? -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 0/5] RISC-V: Add firmware loading support and default

2019-06-27 Thread Andrea Bolognani
On Fri, 2019-06-21 at 14:35 +0200, Andrea Bolognani wrote: > On Thu, 2019-06-20 at 21:43 +0300, David Abdurachmanov wrote: > > On Thu, Jun 20, 2019 at 9:18 PM Alistair Francis > > wrote: > > > OE-Core already packages OpenSBI by default, Fedora and Debian are > >

Re: [Qemu-devel] [Qemu-arm] [RFC v2 PATCH] hw/arm/virt: makes virt a default machine type

2019-06-24 Thread Andrea Bolognani
th the small (and not so small :) differences in behavior between QEMU targets: as Peter correctly says, machine type is just a single example among many. -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 0/5] RISC-V: Add firmware loading support and default

2019-06-21 Thread Andrea Bolognani
On Thu, 2019-06-20 at 21:43 +0300, David Abdurachmanov wrote: > On Thu, Jun 20, 2019 at 9:18 PM Alistair Francis wrote: > > On Thu, Jun 20, 2019 at 1:16 AM Andrea Bolognani > > wrote: > > > but one question comes to mind: once this is in, we will probably > > &

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 0/5] RISC-V: Add firmware loading support and default

2019-06-20 Thread Andrea Bolognani
then. I'm unclear on the advantages of using one format over the other, but one question comes to mind: once this is in, we will probably want to have OpenSBI packaged separately in distributions, the same way it already happens for SeaBIOS, SLOF and edk2-based firmwares. Will using either of the formats prevent that from happening? -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-27 Thread Andrea Bolognani
On Fri, 2019-05-24 at 15:24 -0300, Eduardo Habkost wrote: > On Thu, May 23, 2019 at 10:35:24AM +0200, Andrea Bolognani wrote: > > [...] the above looks good to > > me as a general direction, but note that you'll have to implement at > > the very least the query-cpu-model-

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-23 Thread Andrea Bolognani
licabile, we will want to implement at some point; more in general, what s390x is doing with respect to CPU models is a good blueprint, according to the libvirt developer who's the most involved with that specific area of the project. -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Andrea Bolognani
On Wed, 2019-05-15 at 12:14 +0100, Dave Martin wrote: > On Wed, May 15, 2019 at 09:03:58AM +0100, Andrea Bolognani wrote: > > On Tue, 2019-05-14 at 13:14 -0700, Richard Henderson wrote: > > > Why is =4 less user-friendly than =512? > > > > > > I don't actuall

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-15 Thread Andrea Bolognani
On Tue, 2019-05-14 at 13:14 -0700, Richard Henderson wrote: > On 5/14/19 9:03 AM, Andrea Bolognani wrote: > > On Tue, 2019-05-14 at 14:53 +0200, Andrew Jones wrote: > > > We already have sve-max-vq, so I'm not sure we want to rename it. > > > > Oh, I di

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-14 Thread Andrea Bolognani
On Tue, 2019-05-14 at 14:53 +0200, Andrew Jones wrote: > On Tue, May 14, 2019 at 02:29:51PM +0200, Andrea Bolognani wrote: > > Since we expect management applications to use QMP to discover what > > vector lengths are supported and then provide an explicit map, I > > t

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-14 Thread Andrea Bolognani
On Mon, 2019-05-13 at 14:36 +0200, Andrew Jones wrote: > On Mon, May 13, 2019 at 11:32:46AM +0200, Andrea Bolognani wrote: > > On Sun, 2019-05-12 at 10:36 +0200, Andrew Jones wrote: > > [...] > > >CPU type | accel |

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-13 Thread Andrea Bolognani
ditional parser on top of the bitmap handling and conversion routines we'll clearly need to make this work; plus it just feels weird that the information reported by QMP can't be used on the command line without going through some tranformation first. Wouldn't it make more sense to both accept and report bitmaps? -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [PATCH] vl: fix -sandbox parsing crash when seccomp support is disabled

2019-04-29 Thread Andrea Bolognani
at vl.c:3589 > > Fixes: 5780760f5ea6163939a5dabe7427318b4f07d1a2 > Cc: da...@gibson.dropbear.id.au > Cc: ot...@redhat.com > Signed-off-by: Marc-André Lureau > --- > vl.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) This fixes the crash for me, so Tested-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 0/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-04-09 Thread Andrea Bolognani
hrough the management layer, as Daniel was also suggesting earlier in the thread. [1] https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L364-L372 [2] https://libvirt.org/formatdomain.html#elementsSysinfo -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-21 Thread Andrea Bolognani
ng libvirt patches in before our own freeze starts. It would be great if we could make it so guests created with QEMU 4.0.0 + libvirt 5.2.0 get PCI by default :) -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread Andrea Bolognani
variable should be set to true even if they don't > support MSI. In this case that is what we are doing as we don't support > MSI. > > Signed-off-by: Alistair Francis > Reported-by: Andrea Bolognani > Reported-by: David Abdurachmanov > --- > This should allow working pc

Re: [Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-18 Thread Andrea Bolognani
b8dbd5cb17faa8e6a01afe1f;hb=HEAD#l38 > > the msi_nonbroken variable should be set to true even if they don't > > support MSI. In this case that is what we are doing as we don't support > > MSI. > > > > Signed-off-by: Alistair Francis > > Repo

Re: [Qemu-devel] [PATCH] ci: store Patchew configuration in the tree

2019-03-15 Thread Andrea Bolognani
On Fri, 2019-03-15 at 10:19 +0100, Paolo Bonzini wrote: [...] > +s390x: > + enabled: false > + requirements: ppcle This doesn't look right :) -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

2019-03-15 Thread Andrea Bolognani
+++ > hw/ppc/Kconfig| 1 + > hw/rdma/Kconfig | 3 +++ > hw/rdma/Makefile.objs | 6 ++ > hw/s390x/Kconfig | 1 + > 13 files changed, 28 insertions(+), 12 deletions(-) > create mode 100644 hw/rdma/Kconfig FWIW Tested-by: Andrea Bolognani Thanks for addressing this :) -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Andrea Bolognani
t be surprised if the same happened for other architectures, too. -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [libvirt] [PATCH for-4.0 v4 0/2] virtio: Provide version-specific variants of virtio PCI devices

2019-03-06 Thread Andrea Bolognani
On Wed, 2019-03-06 at 09:30 +0100, Ján Tomko wrote: > On Wed, Mar 06, 2019 at 08:41:48AM +0100, Peter Krempa wrote: > > On Tue, Mar 05, 2019 at 16:56:43 +0100, Andrea Bolognani wrote: > > > So I agree neither scenario is exactly perfect, but I still think > > > ad

Re: [Qemu-devel] [PATCH for-4.0 v4 0/2] virtio: Provide version-specific variants of virtio PCI devices

2019-03-05 Thread Andrea Bolognani
y. > So I can't see how this would be so much better. We have to document > the mess no matter what. We have some documentation in libvirt: https://libvirt.org/formatdomain.html#elementsVirtioTransitional Not that more / improved documentation is ever a bad idea :) -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [PATCH for-4.0 v4 0/2] virtio: Provide version-specific variants of virtio PCI devices

2019-03-05 Thread Andrea Bolognani
ional variants means that only the non-transitional variant is available - except you have to use the suffix-less device name to use it. tl;dr providing the non-transitional variant for virtio 1.0-only devices would make using this much more user-friendly. -- Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Andrea Bolognani
nship between old and new devices consistent going forward, because not doing so will certainly result in confusion for those using QEMU directly. -- Andrea Bolognani / Red Hat / Virtualization

<    1   2   3   4   >