From: Anthony PERARD
Signed-off-by: Anthony PERARD
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 302b6fd00c..ea9672fc52 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -532,7 +532,7 @@ Guest CPU Cores (Xen
timer_del(state->buffered_io_timer);
> qemu_xen_evtchn_unmask(state->xce_handle,
> state->bufioreq_local_port);
> +} else {
> +timer_mod(state->buffered_io_timer,
> + BUFFER_IO_MAX_DELAY +
> qemu_clock_get_ms(QEMU_CLOCK_REALTIME));
> }
> }
Cheers,
--
Anthony PERARD
arameters
> etc), the real BDF needs to be used.
> Get the in-stubdomain BDF by looking up relevant PV PCI xenstore
> entries.
>
> Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
o be done
> differently.
>
> Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
only checked the xen_pt* source files, I don't know if the same
applies to "xen-operations.c" or "xen-mapcache.c".
Beside this, QEMU built with Xen support still seems to works fine, so
adding the objects to `system_ss` instead of `specific_ss` seems
alright.
Thanks,
--
Anthony PERARD
d Woodhouse
> Signed-off-by: Philippe Mathieu-Daudé
Fine by me. Looks like there was a license header before:
https://xenbits.xen.org/gitweb/?p=qemu-xen-unstable.git;a=blob;f=hw/pass-through.h;h=0b5822414e24d199a064abccc4d378dcaf569bd6;hb=HEAD
I don't know why I didn't copied it over here.
Acked
remove from the "hw/xen/xen-hvm-common.h" *common* header.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Richard Henderson
> Reviewed-by: David Woodhouse
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
were more IOREQ types.
So my guess is it isn't relevant anymore, but extending the clamping to
32-bits request should be fine, when using qemu-system-i386 that is, as
it is already be done if one use qemu-system-x86_64.
So I think the patch is fine, and the tests I've ran so far worked fine.
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
Mathieu-Daudé
> Reviewed-by: David Woodhouse
> Reviewed-by: Richard Henderson
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
use
> Reviewed-by: Richard Henderson
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
/
+ /* last cacheline: 48 bytes */
+} __attribute__((__aligned__(8)));
Thanks,
--
Anthony PERARD
f(0){...}`, but there's
no guaranty, is there?
Cheers,
--
Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:01PM +0100, Philippe Mathieu-Daudé wrote:
> Only call xen_register_framebuffer() when Xen is enabled.
>
> Signed-off-by: Philippe Mathieu-Daudé
I don't think this patch is very useful but it's fine, so:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
hilippe
talked about at
https://lore.kernel.org/qemu-devel/429a5a27-21b9-45bd-a1a6-a1c2ccc48...@linaro.org/
materialise.
Beside the coding style, the patch looks file.
Thanks,
--
Anthony PERARD
acy-backend", if possible.
(In xen_hvm_init_pc(), a call to xen_register_ioreq() opens another
xenstore, as `state->xenstore`.)
(There's already been effort to build QEMU without legacy backends, that
stubdom check would break in this scenario.)
Thanks,
--
Anthony PERARD
).
This allows making passthrough devices appear as functions in a Xen
guest.
Signed-off-by: Ross Lagerwall
Reviewed-by: Paul Durrant
Message-Id: <20231103172601.1319375-1-ross.lagerw...@citrix.com>
Signed-off-by: Anthony PERARD
---
hw/xen/xen_pt_config_init.c | 7 +--
1 file changed, 5 inse
The following changes since commit 8f3f329f5e0117bd1a23a79ab751f8a7d3471e4b:
Merge tag 'migration-20240311-pull-request' of https://gitlab.com/peterx/qemu
into staging (2024-03-12 11:35:41 +)
are available in the Git repository at:
c:1559
--Type for more, q to quit, c to continue without paging--
at ../qemu-xen-dir-remote/block/block-backend.c:1614
i1=) at ../qemu-xen-dir-remote/util/coroutine-ucontext.c:177
at ../sysdeps/unix/sysv/linux/aarch64/setcontext.S:123
Signed-off-by: Peng Fan
Reviewed-by: Stefano Stabel
.
This change was suggested initially here:
https://lore.kernel.org/xen-devel/20180216204031.5...@gmail.com/
Apparently this alone is already enough to get massive speedup.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Alex Bennée
Reviewed-by: Anthony PERARD
Message-Id
From: Anthony PERARD
In file_write_ramblock_iov(), "offset" is "uintptr_t" and not
"ram_addr_t". While usually they are both equivalent, this is not the
case with CONFIG_XEN_BACKEND.
Use the right format. This will fix build on 32-bit.
Fixes: f427d90b9898 ("
_PCI,
> @@ -759,8 +759,8 @@ static void xen_pt_destroy(PCIDevice *d) {
> memory_listener_unregister(>io_listener);
> s->listener_set = false;
> }
> -if (!xen_host_pci_device_closed(>real_device)) {
> -xen_host_pci_device_put(>real_device);
&
e to me but I don't have any x86
> Xen HW to test this one. Are the x86 maintainers happy to take this on?
Yes. It looks like it works well with both SeaBIOS and OVMF, so the
patch is good.
> FWIW:
>
> Reviewed-by: Alex Bennée
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
parameter.
> - xen_console_frontend_changed(): the @errp points its caller's
>@local_err.
>
> To avoid the issue like [1] said, add missing ERRP_GUARD() at the
> beginning of xen_console_connect().
>
> [1]: Issue description in the commit message of commit ae7c80a7
anged().
> >
> > Though its @errp points to @local_err of xen_device_frontend_changed(),
> > to follow the requirement of @errp, add missing ERRP_GUARD() at the
> > beginning of this function.
> >
> > [1]: Issue description in the commit message of commit ae7c80a
It works fine for me.
Thanks,
--
Anthony PERARD
On Tue, Dec 12, 2023 at 03:35:50PM +, Volodymyr Babchuk wrote:
> Hi Anthony
>
> Anthony PERARD writes:
>
> > On Fri, Dec 08, 2023 at 02:49:27PM -0800, Stefano Stabellini wrote:
> >> On Fri, 8 Dec 2023, Daniel P. Berrangé wrote:
> >> > On Thu, Dec 07,
nds them self, as seen by
a guest aren't going to change, and are not legacy. Also, a few month
ago, "qnic" would have been part of the list. Maybe a description like
"Xen backends based on legacy support" might be more appropriate. I'm
not sure listing the different backend in the description is a good
idea, as we will have to remember to change it whenever one of those
backend is been upgraded.
Cheers,
--
Anthony PERARD
pass I think.
Building qemu with something like:
./configure --enable-xen --cpu=x86_64
used to work. Can we fix that? It still works with v8.1.0.
At least, it works on x86, I never really try to build qemu for arm.
Notice that there's no "--target-list" on the configure command line.
I don't know if --cpu is useful here.
Looks like the first commit where the build doesn't work is
7899f6589b78 ("xen_arm: Add virtual PCIe host bridge support").
Could we get that fixed?
I'm sure distribution will appreciate to be able to build a single qemu
package for xen and other, rather than having a dedicated qemu-xen
package.
Cheers,
--
Anthony PERARD
an x86 hvm guest with qdisk.
Error from guest kernel:
"2 reading backend fields at /local/domain/0/backend/qdisk/23/768"
It seems that "sector-size" is missing for the disk.
Thanks,
--
Anthony PERARD
On Wed, Oct 11, 2023 at 12:22:46PM -0700, Vikram Garhwal wrote:
> Hi Anthony,
> On Thu, Oct 05, 2023 at 11:40:57AM +0100, Anthony PERARD wrote:
> > Hi Vikram,
> >
> > This patch prevent QEMU from been build with Xen 4.15. See comments.
> >
> > Also, w
irq_level(xen_dmod, xen_domid, irq, level);
So, you just ignore the return value here. Shouldn't there be some kind
of error check?
And is it OK to create a virtio-mmio device without an error, even when
we could find out that it never going to work (e.g. on Xen 4.14)?
Cheers,
--
Anthony PERARD
gt;type == XEN_BLOCK_VDEV_TYPE_HD) ?
>"hd" :
>"sd",
> - name, vdev->partition);
> -g_free(name);
> + vbd_name, vdev->partition);
> + g_free(vbd_name);
> break;
> }
> default:
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
? And same
question for the xen toolstack side.
Cheers,
--
Anthony PERARD
* fix an access to `request_cond` QemuCond in thread-pool
* fix issue with PCI devices when unplugging IDE devices in Xen guest
* several fixes for issues pointed out by Coverity
Anthony PERARD (2):
xen-block: Avoid leaks
: <20230720072950.20198-1-o...@aepfle.de>
Signed-off-by: Anthony PERARD
---
hw/i386/xen/xen_platform.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c
index 57f1d742c1..17457ff3de 100644
--- a/hw/i386/xen/x
watches on
the newly-committed changed nodes. So make it a g_assert(!ret), since
it really should never happen.
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
Message-Id: <20076888f6bdf06a65aafc5cf954260965d45b97.ca...@infradead.org>
Signed-off-by: Anthony PERARD
---
hw/i3
From: Anthony PERARD
Commit 189829399070 ("xen-block: Use specific blockdev driver")
introduced a new error path, without taking care of allocated
resources.
So only allocate the qdicts after the error check, and free both
`filename` and `driver` when we are about to return and thus t
From: Anthony PERARD
thread_pool_free() might have been called on the `pool`, which would
be a reason for worker_thread() to quit. In this case,
`pool->request_cond` is been destroyed.
If worker_thread() didn't managed to signal `request_cond` before it
been destroyed by thread_pool_free(),
variables const, since nothing changes them.
Signed-off-by: Peter Maydell
Acked-by: Anthony PERARD
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230718101057.1110979-1-peter.mayd...@linaro.org>
Signed-off-by: Anthony PERARD
---
hw/arm/xen_arm.c| 4 ++--
hw/i386/xen/xen
r(). We can also make the file-scope
> MemoryListener variables const, since nothing changes them.
>
> Signed-off-by: Peter Maydell
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Tue, Jul 04, 2023 at 11:56:54AM +0200, Roger Pau Monné wrote:
> On Tue, Jul 04, 2023 at 10:37:38AM +0100, Anthony PERARD wrote:
> > On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote:
> > > On Fri, Jun 23, 2023 at 03:04:21PM +, osstest service owner wrote:
>
From: Anthony PERARD
thread_pool_free() might have been called on the `pool`, which would
be a reason for worker_thread() to quit. In this case,
`pool->request_cond` is been destroyed.
If worker_thread() didn't managed to signal `request_cond` before it
been destroyed by thread_pool_free(),
From: Anthony PERARD
Commit 189829399070 ("xen-block: Use specific blockdev driver")
introduced a new error path, without taking care of allocated
resources.
So only allocate the qdicts after the error check, and free both
`filename` and `driver` when we are about to return and thus t
so with QEMU 7.2, as testing with upstream QEMU is blocked
> ATM, so there's a chance it has already been fixed upstream.
>
> Thanks, Roger.
So, I've run a test with the latest QEMU and I can still reproduce the
issue. The test also fails with QEMU 7.1.0.
But, QEMU 7.0 seems to pass the test, even with a start-stop loop of 200
iteration. So I'll try to find out if something change in that range.
Or try to find out why would the thread pool be not initialised
properly.
Cheers,
--
Anthony PERARD
uggest for you to pick up the patches. But as it
> > >>happens I'll have to likely send another pull request in a week or two
> > >>and I can add these patches to it.
> > >>
> > >>Let me know your preference and I am happy to follow it.
> > >
> > >Hi Stefano,
> > >
> > >Michael's PR was merged last week. How about including this series into
> > >your PR then?
> >
> > Ping
>
> Sorry for the late reply, it looks like patch #3 breaks the build:
Hi Stefano,
Sorry I forgot to reply to these mails. I've sent a pull request for
this earlier this week (along with other patches I had to send), so the
series should be applied now.
I guess the build issue is due to trying to apply the same patch again.
Cheers,
--
Anthony PERARD
in Xen mode.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Anthony PERARD
Tested-by: Chuck Zmudzinski
Message-Id: <20230312120221.99183-3-shen...@gmail.com>
Message-Id: <20230403074124.3925-4-shen...@gmail.com>
Signed-off-by: Anthony PERARD
---
hw/isa
ction to
internal emulation")
Suggested-by: Peter Maydell
Signed-off-by: David Woodhouse
Reviewed-by: Peter Maydell
Reviewed-by: Paul Durrant
Message-Id: <20230412185102.441523-3-dw...@infradead.org>
Signed-off-by: Anthony PERARD
---
hw/xen/xen-operations.c | 2 +-
1 file changed, 1
From: Bernhard Beschow
During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of
TYPE_PIIX3_DEVICE. Remove this redundancy.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Anthony PERARD
Tested-by: Chuck Zmudzinski
Message-Id: <20230312120221.9918
From: Anthony PERARD
The following changes since commit f5e6786de4815751b0a3d2235c760361f228ea48:
Merge tag 'pull-target-arm-20230606' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-06-06
12:11:34 -0700)
are available in the Git repository at:
https
From: Bernhard Beschow
The previous patch unified handling of piix3_write_config() accross the
PIIX3 device models which allows for assigning k->config_write once in the
base class.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Anthony PERARD
Tested-by: Ch
ed-off-by: Anthony PERARD
---
hw/pci/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 1cc7c89036..9b7b4d7c18 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -560,6 +560,7 @@ void pci_bus_irqs(PCIBus *bus, pci_set_irq_fn set_irq,
bus->set_irq
-by: Michael S. Tsirkin
Reviewed-by: Anthony PERARD
Tested-by: Chuck Zmudzinski
Message-Id: <20230312120221.99183-4-shen...@gmail.com>
Message-Id: <20230403074124.3925-5-shen...@gmail.com>
Signed-off-by: Anthony PERARD
---
hw/i386/pc_piix.c | 13 +
hw/isa/pii
GSI that it should be connected to, is still non-intuitive for me.
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
Message-Id: <20230412185102.441523-2-dw...@infradead.org>
Signed-off-by: Anthony PERARD
---
hw/i386/kvm/xen_evtchn.c | 40
hw
to XEN_IOAPIC_NUM_PIRQS since the Xen's
IOAPIC rather than PIIX has this many interrupt routes.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Anthony PERARD
Tested-by: Chuck Zmudzinski
Message-Id: <20230312120221.99183-2-shen...@gmail.com>
Message-Id: <20230403074124.39
From: Anthony PERARD
Backtrace:
qemu_lockcnt_lock (lockcnt=0xb4) at ../util/lockcnt.c:238
aio_set_fd_handler (ctx=0x0, fd=51, is_external=true, io_read=0x0,
io_write=0x0, io_poll=0x0, io_poll_ready=0x0, opaque=0x0) at
../util/aio-posix.c:119
xen_device_unbind_event_channel (xendev
wed-by: Peter Maydell
Message-Id: <20230412185102.441523-6-dw...@infradead.org>
Signed-off-by: Anthony PERARD
---
hw/i386/kvm/xen_xenstore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c
index 0b189c6ab8..133d89e9
for it is fairly
unintrusive.
Fixes: 15e283c5b684 ("hw/xen: Add foreignmem operations to allow redirection to
internal emulation")
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
Message-Id: <20230412185102.441523-4-dw...@infradead.org>
Signed-off-by: Anthony PERARD
, pci_bus_fire_intx_routing_notifier() could
be adjusted in such a way that subscribing to it doesn't require
knowledge of the device firing it.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Anthony PERARD
Tested-by: Chuck Zmudzinski
Message-Id
From: Anthony PERARD
Backtrace:
qemu_lockcnt_lock (lockcnt=0xb4) at ../util/lockcnt.c:238
aio_set_fd_handler (ctx=0x0, fd=51, is_external=true, io_read=0x0,
io_write=0x0, io_poll=0x0, io_poll_ready=0x0, opaque=0x0) at
../util/aio-posix.c:119
xen_device_unbind_event_channel (xendev
event_channel() at the moment
so I don't know if other implementation making use of this API will want
to call set_event_channel_context or not.)
> +xen_block_dataplane_attach(dataplane);
> +}
>
> return;
>
--
Anthony PERARD
xternal() API.
>
> Signed-off-by: Stefan Hajnoczi
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
safe.
>
> It's safer to register BlockDevOps after the dataplane instance has been
> created. The BlockDevOps .drained_begin/end() callbacks depend on the
> dataplane instance, so move the blk_set_dev_ops() call after
> xen_block_dataplane_create().
>
> Signed-off-by: Stefan Hajnoczi
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
f(msg, "%u", _devs) != 1) {
libxl writes `num_devs` as "%d". So I think qemu should read a %d.
> +error_setg(errp, "Failed to parse %s (%s)", msg, path);
> +goto err_out;
> +}
> + free(msg);
> +
> +for (i = 0; i < num_devs; i++) {
> +snprintf(path, sizeof(path), "%s/dev-%u", be_path, i);
Same here, the path is written with a %d, even if that doesn't change the
result.
Thanks,
--
Anthony PERARD
On Sat, Apr 01, 2023 at 10:36:45PM +, Bernhard Beschow wrote:
>
>
> Am 30. März 2023 13:00:25 UTC schrieb Anthony PERARD
> :
> >On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote:
> >> This is a preparational patch for the next one to make the
On Sun, Mar 12, 2023 at 01:02:21PM +0100, Bernhard Beschow wrote:
> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of
> TYPE_PIIX3_DEVICE. Remove this redundancy.
>
> Signed-off-by: Bernhard Beschow
> Reviewed-by: Michael S. Tsirkin
Reviewed-by: Anthony
eviewed-by: Michael S. Tsirkin
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
el S. Tsirkin
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
in the board.
>
> Signed-off-by: Bernhard Beschow
> Reviewed-by: Michael S. Tsirkin
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
et_route_irq_fn() is now also called in Xen mode.
>
> Signed-off-by: Bernhard Beschow
> Reviewed-by: Michael S. Tsirkin
Beside the leak which I think can happen only once, patch is fine:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
mmunicate
> this.
>
> Also rename XEN_PIIX_NUM_PIRQS to XEN_IOAPIC_NUM_PIRQS since the Xen's
> IOAPIC rather than PIIX has this many interrupt routes.
>
> Signed-off-by: Bernhard Beschow
> Reviewed-by: Michael S. Tsirkin
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
().
Fixes: b6cacfea0b38 ("hw/xen: Add evtchn operations to allow redirection to
internal emulation")
Reported-by: Anthony PERARD
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
Tested-by: Anthony PERARD
Message-Id: <5dfb65342d4502c1ce2f890c97cff20bf25b3860.ca...@infradea
store operations to allow redirection to
internal emulation")
Reported-by: Jason Andryuk
Co-developed-by: Jason Andryuk
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
Tested-by: Jason Andryuk
Message-Id: <1f141995bb61af32c2867ef5559e253f39b0949c.ca...@infradead.org>
Signed-off-by
On Thu, Mar 23, 2023 at 10:01:59AM +, Anthony PERARD wrote:
> The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12:
>
> Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into
> staging (2023-03-22 17:58:12 +)
>
> are av
The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12:
Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into
staging (2023-03-22 17:58:12 +)
are available in the Git repository at:
https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git
the operations for the true Xen
> libraries. Add the missing call to setup_xen_backend_ops().
>
> Fixes: b6cacfea0b38 ("hw/xen: Add evtchn operations to allow redirection to
> internal emulation")
> Reported-by: Anthony PERARD
> Signed-off-by: David Woodhouse
Teste
o.html
http://logs.test-lab.xenproject.org/osstest/logs/179868/test-amd64-i386-xl-vhd/info.html
Any idea of what's wrong?
Thanks,
--
Anthony PERARD
store operations to allow redirection to
internal emulation")
Reported-by: Jason Andryuk
Co-developed-by: Jason Andryuk
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
Tested-by: Jason Andryuk
Message-Id: <1f141995bb61af32c2867ef5559e253f39b0949c.ca...@infradead.org>
Signed-off-by
The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12:
Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into
staging (2023-03-22 17:58:12 +)
are available in the Git repository at:
https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git
The following changes since commit 2946e1af2704bf6584f57d4e3aec49d1d5f3ecc0:
configure: Disable thread-safety warnings on macOS (2023-03-04 14:03:46 +)
are available in the Git repository at:
https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git
tags/pull-xen-20230306
for you to
' are not initialized. Then, the function fails if any of those
higher bits are set.
Fix this by initializing 'val' with zero.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Stefano Stabellini
Message-Id: <20230127050815.4155276-1-marma...@invisiblethingslab.com>
Signed-off-by: Anthony
by checking the domain, bus, slot,
and function values as well as by checking that gfx_passthru is enabled,
the device class is VGA, and the device vendor in Intel.
Signed-off-by: Chuck Zmudzinski
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Stefano Stabellini
Message-Id:
Signed-off-by: Anthony PERAR
te guest, I don't think there
is another way for libvirt to create xen guests.
So overall, unfortunately the "pc" machine in QEMU isn't suitable to do
IGD passthrough as the "xenfv" machine has already some workaround to
make IGD work and just need some more.
I've seen that the patch for QEMU is now reviewed, so I look at having
it merged soonish.
Thanks,
--
Anthony PERARD
er series "Consolidate
PIIX..." is fully applied?
Thanks.
> > Testing done:
> > None, because I don't know how to conduct this properly :(
> >
> > Based-on: <20221221170003.2929-1-shen...@gmail.com>
> > "[PATCH v4 00/30] Consolidate PIIX south bridges"
--
Anthony PERARD
t;using slot 2"
when we don't even if slot 2 is actually going to be used could be
confusing, so I guess preventing that message from been logged could be
useful indeed.
So your proposed v7 would be fine.
Cheers,
--
Anthony PERARD
From: Anthony PERARD
With "clang 6.0.0-1ubuntu2" on Ubuntu Bionic, the test with build
fine, but clang still suggest braces around the zero initializer in a
few places, where there is a subobject. Expand test to include a sub
struct which doesn't build on clang 6.0.0-1ubuntu2
y break in the future due to
been uncommon but hopefully that will be ok.
So if no work to fix libxl appear soon, I'm ok with this patch:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
dealing with the technical dept in libxl, that is to
stop using 'xenfv' and use 'pc' instead, then go for it, I can help with
that. Otherwise, if the patch to QEMU only changes the behavior of the
'xenfv' machine then I think I would be ok with it.
I'll do a review of that QEMU patch in another email.
Cheers,
--
Anthony PERARD
On Mon, Dec 19, 2022 at 08:02:01AM -0500, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
`addr` isn't updated in the loop, aren't we going to write bytes to the
wrong place? If for example "emul_mask == 0x00ff00ff" ?
> +write_val >>= emul_len * 8;
> +} else {
> +emul_mask >>= 8;
> +write_val >>= 8;
> +}
> +}
Thanks,
--
Anthony PERARD
;
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1196
Signed-off-by: Aaron Liu
Signed-off-by: Ruili Ji
Message-ID:
Reviewed-by: Paul Durrant
Signed-off-by: Anthony PERARD
---
hw/xen/xen_pt_config_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xen
The following changes since commit 99d6b11b5b44d7dd64f4cb1973184e40a4a174f8:
Merge tag 'pull-target-arm-20220922' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-09-26
13:38:26 -0400)
are available in the Git repository at:
may I change them to:
Signed-off-by: Aaron Lui
Signed-off-by: Ruili Ji
The second line would be the same as the author of the patch (From:).
Thanks,
--
Anthony PERARD
it belongs after
applying this patch.
Signed-off-by: Chuck Zmudzinski
Reviewed-by: Anthony PERARD
Message-Id:
Signed-off-by: Anthony PERARD
---
hw/xen/xen_pt_config_init.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen
alues")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1061
Buglink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988333
Signed-off-by: Chuck Zmudzinski
Reviewed-by: Anthony PERARD
Message-Id:
Signed-off-by: Anthony PERARD
---
hw/xen/xen_pt_config_init.c | 11 ++-
1 file
The following changes since commit 19361471b59441cd6f2aa22d4fbee7a6e9e76586:
Merge tag 'pull-la-20220705' of https://gitlab.com/rth7680/qemu into staging
(2022-07-05 16:30:52 +0530)
are available in the Git repository at:
https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git
mapped into the guest's memory. Also, move the comment
> about trapping 0xfc for the Intel OpRegion where it belongs after
> applying this patch.
>
> Signed-off-by: Chuck Zmudzinski
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
> +s->real_device.vendor_id != PCI_VENDOR_ID_INTEL) {
> +continue;
> + }
> reg_grp_offset = XEN_PCI_INTEL_OPREGION;
> }
Thanks,
--
Anthony PERARD
ing that the Linux guest never completes the boot process.
>
> Fixes: 2e87512eccf3
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1061
> Buglink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988333
>
> Signed-off-by: Chuck Zmudzinski
Reviewed-by: Anthony P
From: Bernhard Beschow
Commit 0f8445820f11a69154309863960328dda3dc1ad4 'xen: piix reuse pci
generic class init function' already resolved redundant code which in
turn rendered piix3-ide-xen redundant.
Signed-off-by: Bernhard Beschow
Reviewed-by: Anthony PERARD
Message-Id
-by: Anthony PERARD
Message-Id: <20220513180957.90514-3-shen...@gmail.com>
Signed-off-by: Anthony PERARD
---
hw/ide/piix.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/hw/ide/piix.c b/hw/ide/piix.c
index 2345fe9e1d..bc1b37512a 100644
--- a/hw/ide/piix.c
+++ b/hw/ide/
1 - 100 of 1252 matches
Mail list logo
