On Thu, Apr 02, 2020 at 03:27:22PM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Anthony PERARD
> > Sent: 02 April 2020 14:08
> > To: qemu-devel@nongnu.org
> > Cc: qemu-sta...@nongnu.org; Anthony PERARD ;
> > Stefano Stabellini
On Thu, Apr 02, 2020 at 02:29:25PM +0200, Igor Mammedov wrote:
> On Mon, 30 Mar 2020 17:52:48 +0100
> Anthony PERARD wrote:
>
> > On Fri, Mar 27, 2020 at 06:48:28AM -0400, Igor Mammedov wrote:
> > > Since bd457782b3b0 ("x86/pc: use memdev for RAM") Xen
to
remove a request from the inflight list and when not.
Fixes: bfd0d6366043 ("xen-block: improve response latency")
Signed-off-by: Anthony PERARD
---
hw/block/dataplane/xen-block.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/block/dataplane/x
ck working, I'd prefer
> not to keep that circular dependency and try to untangle that.
>
> However it doesn't look trivial to fix, so as temporary
> fixup opt out Xen machine from memdev based RAM allocation,
> and let xen_ram_alloc() do its trick for now.
>
> Repo
m?
- keep using something similar to what we have now with
memory_region_init_ram()?
(with accel=xen)
Maybe we need a new hostmem backend which don't allocate any memory but
creates a memory region, to be used by Xen?
Thanks,
--
Anthony PERARD
d-by: Paul Durrant
Hi,
I've added this patch to a pull requests for the xen.
Cheers,
--
Anthony PERARD
annel is always assigned
back to main thread context before it is closed. aio_set_fd_handler()
already deals with all the necessary synchronization when moving an fd
between AioContext-s so no extra code is needed to manage this.
Reported-by: Julien Grall
Signed-off-by: Paul Durrant
Reviewed-by:
From: Philippe Mathieu-Daudé
xen_pt_load_rom.c does not use any of these includes, remove them.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Paul Durrant
Message-Id: <20191014142246.4538-9-phi...@redhat.com>
Signed-off-by: Anthony PERARD
---
hw/xen/xen_pt_load_rom.c | 4
xen-block
* fix in exec.c for migration of xen guest
* one cleanup patch
--------
Anthony PERARD (1):
Memory: Only call ramblock_ptr when needed in qemu_ram_writeback
Paul Durrant (1):
xen-bus/block: explicitly assign event chan
4bc29 ("migration: ram: Switch to
ram block writeback").
Signed-off-by: Anthony PERARD
Reviewed-by: Juan Quintela
Acked-by: Paolo Bonzini
Message-Id: <20191219154323.325255-1-anthony.per...@citrix.com>
---
exec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
On Thu, Dec 19, 2019 at 07:10:24PM +0100, Juan Quintela wrote:
> Anthony PERARD wrote:
> > It is possible that a ramblock doesn't have memory that QEMU can
> > access, this is the case with the Xen hypervisor.
> >
> > In order to avoid to trigger an asser
On Wed, Jan 29, 2020 at 10:22:14PM +, Julien Grall wrote:
> Hi Anthony,
>
> On 19/12/2019 17:11, Anthony PERARD wrote:
> > On Mon, Dec 16, 2019 at 02:34:51PM +, Paul Durrant wrote:
> > > It is not safe to close an event channel from the QEMU main thread when
> &
extra code is needed to manage this.
>
> Reported-by: Julien Grall
> Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
> Tested against an HVM debian guest with a QCOW2 image as system disk, and
> as a hot-plugged/unplgged secondary disk.
And I've run an osstest flight with the patch.
Thanks,
--
Anthony PERARD
4bc29 ("migration: ram: Switch to
ram block writeback").
Signed-off-by: Anthony PERARD
---
exec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index a34c34818404..b11010e0cb4c 100644
--- a/exec.c
+++ b/exec.c
@@ -2166,14 +2166,13 @@ int qemu_ram_
ifiers = {
lh_first = 0x0
},
fd = -1,
page_size = 4096,
bmap = 0x0,
receivedmap = 0x562dc6a24a60,
clear_bmap = 0x0,
clear_bmap_shift = 0 '\000'
}
Cheers,
--
Anthony PERARD
local_err,
> +iothread = xen_block_iothread_create(vdev, errp);
> +if (*errp) {
> +error_prepend(errp,
> "failed to create iothread: ");
These two line could be joined now.
> goto fail;
> }
And there are more indentation issu
On Tue, Oct 01, 2019 at 06:44:39PM -0500, Michael Roth wrote:
> Hi everyone,
Hi Michael,
> Please respond here or CC qemu-sta...@nongnu.org on any patches you
> think should be included in the release.
[...]
> Anthony PERARD (1):
> xen-bus: Fix backend state transition
, which will unblock the backend in these circumstances.
Reported-by: Mark Syms
Signed-off-by: Paul Durrant
Acked-by: Anthony PERARD
Reviewed-by: John Snow
Message-Id: <20190918115702.38959-1-paul.durr...@citrix.com>
Signed-off-by: Anthony PERARD
---
hw/block/xen-block.c | 1 +
1 file c
From: Paul Durrant
My Citrix email address will expire shortly.
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190913122418.848-1-paul.durr...@citrix.com>
Signed-off-by: Anthony PERARD
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
: Anthony Perard
Message-Id: <20190913082159.31338-3-paul.durr...@citrix.com>
Signed-off-by: Anthony PERARD
---
hw/xen/trace-events | 2 ++
hw/xen/xen-bus.c | 72
include/hw/xen/xen-bus.h | 2 ++
3 files changed, 62 insertions(+), 14 del
frontend keys as then
the handshake will stall.
Signed-off-by: Mark Syms
Also avoid creating the frontend area if it already exists.
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190918115745.39006-1-paul.durr...@citrix.com>
Signed-off-by: Anthony PERARD
---
of adding an assertion that a XenWatchList is not
freed whilst its associated NotifierList is still occupied.
Signed-off-by: Paul Durrant
Reviewed-by: Anthony Perard
Message-Id: <20190913082159.31338-2-paul.durr...@citrix.com>
Signed-off-by: Anthony PERARD
---
hw/xen/trace-
a check
(now in a helper function) of 'state', which actually equates to
'xendev->backend_state'.
This patch fixes the mistake.
Fixes: cb3231460747552d70af9d546dc53d8195bcb796
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190910171753.3775-1-paul
ests contained therein only apply to a frontend.
- use 'state' rather then 'xendev->backend_state' in
xen_device_backend_changed() to shorten the code.
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190913082159.31338-4-paul.durr...@citri
The following changes since commit 2f93a3ecdd3bb060bd04f698ccafe66efd98563a:
Merge remote-tracking branch
'remotes/davidhildenbrand/tags/s390x-tcg-2019-09-23' into staging (2019-09-23
15:44:52 +0100)
are available in the Git repository at:
https://xenbits.xen.org/git-http/people/aperard/qe
too early, before
> qemu_add_data_dir() is called, and so qemu_find_file() fails.
>
> To fix that, move init_keyboard_layout() from the class init function to the
> instance init function.
>
> Reported-by: Anthony PERARD
> Fixes: 6105683da35b ("ui: add an embedded Barri
lize = input_barrier_instance_finalize,
> +.interfaces = (InterfaceInfo[]) {
> +{ TYPE_USER_CREATABLE },
> +{ }
> +}
> +};
> +
> +static void register_types(void)
> +{
> +type_register_static(&input_barrier_info);
> +}
> +
> +type_init(register_types);
--
Anthony PERARD
set their state to Closing. If this has occurred then
> device realize must not overwrite the frontend keys as then
> the handshake will stall.
>
> Signed-off-by: Mark Syms
>
> Also avoid creating the frontend area if it already exists.
>
> Signed-off-by: Paul Durr
This patch simply treats a frontend state of XenbusStateUnknown the same
> as XenbusStateClosed, which will unblock the backend in these circumstances.
>
> Reported-by: Mark Syms
> Signed-off-by: Paul Durrant
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
ontext.
> - change xen_device_state_is_active() to
> xen_device_frontend_is_active() (and pass a XenDevice directly)
> since the state tests contained therein only apply to a frontend.
> - use 'state' rather then 'xendev->backend_state' in
; @@ -406,7 +406,7 @@ Guest CPU Cores (Xen)
> X86 Xen CPUs
> M: Stefano Stabellini
> M: Anthony Perard
> -M: Paul Durrant
> +M: Paul Durrant
Reviewed-by: Anthony PERARD
--
Anthony PERARD
* Re-write the state to cause a XenBus backend_watch notification,
> + * resulting in a call to xen_bus_cleanup().
> + */
> +xen_device_backend_printf(xendev, "state", "%u", state);
It kind of feels wrong to rely on xenstore to notify QEMU's xenbus
driver that a device needs cleanup. But that does the job.
With a note about the use of QLIST_NEXT and the few typo fixed, the
patch will be good to go.
Thanks,
--
Anthony PERARD
; subsequent patch.
>
> Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
--
Anthony PERARD
s still occupied.
>
> Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
--
Anthony PERARD
ackend_set_state(xendev, XenbusStateClosed);
> }
>
> mistakenly replaced the check of 'xendev->frontend_state' with a check
> (now in a helper function) of 'state', which actually equates to
> 'xendev->backend_state'.
>
> This pa
p.
* Build fix.
--------
Anthony PERARD (3):
xen: Fix ring.h header
xen-bus: Fix backend state transition on device reset
xen-bus: Avoid rewriting identical values to xenstore
Igor Druzhinin (1):
xen: cleanup IOREQ
losing" the frontend should react and sets its state to
"Closing" then "Closed". The backend should wait for that to happen.
Fixes: b6af8926fb858c4f1426e5acb2cfc1f0580ec98a
Signed-off-by: Anthony PERARD
Reviewed-by: Paul Durrant
Message-Id: <20190823101534.465-2-an
(and maybe the frontend as well). Also QEMU could
potentially write an already old value.
Signed-off-by: Anthony PERARD
Reviewed-by: Paul Durrant
Message-Id: <20190823101534.465-3-anthony.per...@citrix.com>
---
hw/xen/xen-bus.c | 11 +++
1 file changed, 7 insertions(+), 4 deletion
From: Igor Druzhinin
Device model is supposed to destroy IOREQ server for itself.
Signed-off-by: Igor Druzhinin
Acked-by: Paul Durrant
Message-Id: <1564428563-1006-1-git-send-email-igor.druzhi...@citrix.com>
Signed-off-by: Anthony PERARD
---
hw/i386/xen/xen-hvm.c | 2 ++
1 file chan
s leads to:
include/hw/xen/io/ring.h:47:5: error: "__XEN_INTERFACE_VERSION__"
is not defined, evaluates to 0 [-Werror=undef]
Cleanup ring.h. The xen_*mb() macros are already defined in xenctrl.h
which is included in xen_common.h.
Reported-by: Markus Armbruster
Signed-off-by: Anth
losing" the frontend should react and sets its state to
"Closing" then "Closed". The backend should wait for that to happen.
Fixes: b6af8926fb858c4f1426e5acb2cfc1f0580ec98a
Signed-off-by: Anthony PERARD
---
Cc: qemu-sta...@nongnu.org
---
Notes:
v2:
- use a helper
(and maybe the frontend as well). Also QEMU could
potentially write an already old value.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- fix coding style
- only change frontend_set_state() and use 'publish' instead of 'export'.
hw/xen/xen-bus.c | 11 +++
Cheers,
Anthony PERARD (2):
xen-bus: Fix backend state transition on device reset
xen-bus: Avoid rewriting identical values to xenstore
hw/xen/xen-bus.c | 34 +++---
1 file changed, 27 insertions(+), 7 deletions(-)
--
Anthony PERARD
On Thu, Aug 22, 2019 at 10:59:38AM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Anthony PERARD
> > Sent: 22 August 2019 10:51
> > To: Paul Durrant
> > Cc: qemu-devel@nongnu.org; qemu-sta...@nongnu.org; Stefano Stabellini
> > ;
On Thu, Aug 22, 2019 at 12:25:44PM +0100, Paul Durrant wrote:
> > From: Anthony PERARD
> > Sent: 22 August 2019 12:18
> >
> > On Thu, Aug 22, 2019 at 11:36:32AM +0100, Paul Durrant wrote:
> > > But, now I look at the code again without your patch applied I don&
hat behavior might be an issue if the frontend changes the value after
QEMU have read it but before QEMU writes it again.
Also, it's nice to avoid extra work.
--
Anthony PERARD
On Wed, Aug 21, 2019 at 04:40:05PM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Anthony PERARD
> > Sent: 21 August 2019 10:20
> > To: qemu-devel@nongnu.org
> > Cc: Anthony Perard ; Stefano Stabellini
> > ; Paul
> > Durrant ;
the next step, Closed.
frontend might be Initialising, Closed.
But there are also Unknown, Reconfiguring and Reconfigured which
are probably errors.
So, the whitelist with Closed and Initialising is a good start, but what
about the Unknown state? (QEMU doesn't have backends were the state
Reconfigur* is possible, so they can be mapped to Unknown for now).
Cheers,
--
Anthony PERARD
re watch
event which QEMU will process again (and maybe the frontend as well).
Signed-off-by: Anthony PERARD
---
hw/xen/xen-bus.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
index 982eca4533..c83f07
Cheers,
Anthony PERARD (2):
xen-bus: Fix backend state transition on device reset
xen-bus: Avoid rewriting identical values to xenstore
hw/xen/xen-bus.c | 41 +++--
1 file changed, 27 insertions(+), 14 deletions(-)
--
Anthony PERARD
and set
the backend state to "Closed". QEMU should wait for the frontend to
set "Closed" before doing the same.
Before setting "Closed" to the backend_state, we are also going to
check if the frontend was responsible for the transition to "Closing".
Fixes: b6a
s leads to:
include/hw/xen/io/ring.h:47:5: error: "__XEN_INTERFACE_VERSION__"
is not defined, evaluates to 0 [-Werror=undef]
Cleanup ring.h. The xen_*mb() macros are already defined in xenctrl.h
which is included in xen_common.h.
Reported-by: Markus Armbruster
Signed-of
against a recent Windows PV XENVBD
> > driver [2] using a xen-disk device with a 4kB logical block size.
> >
> > [1]
> > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=67e1c050e36b2c9900cca83618e56189effbad98
> > [2] https://winpvdrvbuild.xenproject.org:8080/job
he imported headers are cleaned up a bit while importing them: some
part of the file that QEMU doesn't use are removed (description
of how to make hypercall in grant_table.h have been removed).
Other cleanup:
- xen-mapcache.c and xen-legacy-backend.c don't need grant_table.h.
- xenfb.c doe
[2] https://winpvdrvbuild.xenproject.org:8080/job/XENVBD-master/126
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190409164038.25484-1-paul.durr...@citrix.com>
[Edited error message]
Signed-off-by: Anthony PERARD
---
hw/block/dataplane/xen-block.c | 25 ++
en headers have been imported (by
f65eadb639 "xen: import ring.h from xen") but not all. With the change
in the guards symbole, the ring.h header start to be imported twice.
Signed-off-by: Anthony PERARD
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Paul Durrant
Message-Id: <20190621105441
/close in xen_device_realize/unrealize().
NOTE: This patch does not add an AioContext parameter to
xen_device_bind_event_channel(). That will be done in a subsequent
patch.
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190408151617.13025-2-paul.d
From: Paul Durrant
This patch adds an AioContext parameter to xen_device_bind_event_channel()
and then uses aio_set_fd_handler() to set the callback rather than
qemu_set_fd_handler().
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190408151617.13025-3-paul.d
nough.
(xenctrl.h does include params.h)
Signed-off-by: Anthony PERARD
Reviewed-by: Paul Durrant
Message-Id: <20190618112341.513-4-anthony.per...@citrix.com>
---
hw/i386/xen/xen-hvm.c | 1 -
hw/i386/xen/xen-mapcache.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/hw/i386/xen/
for doing a deferred poll of the shared ring should be because
there were previously insufficient resources to fully complete a previous
poll.
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190408151617.13025-4-paul.durr...@citrix.com>
Signed-off-by: Anthony PERARD
-
ector-size
* xen-block: Support IOThread polling for PV shared rings
* Avoid usage of a VLA
* Cleanup Xen headers usage
--------
Anthony PERARD (4):
xen: Avoid VLA
xen: Drop includes of xen/hvm/params.h
Revert xen/io/ring.h of
Avoid using a variable length array.
We allocate the `dirty_bitmap' buffer only once when we start tracking
for dirty bits.
Signed-off-by: Anthony PERARD
Reviewed-by: Paul Durrant
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20190618112341.513-5-anthony.per...@citrix.com>
---
en headers have been imported (by
f65eadb639 "xen: import ring.h from xen") but not all. With the change
in the guards symbole, the ring.h header start to be imported twice.
Signed-off-by: Anthony PERARD
---
CC: Markus Armbruster
---
Notes:
v3:
- new patch, replace "xen:
he imported headers are cleaned up a bit while importing them: some
part of the file that QEMU doesn't use are removed (description
of how to make hypercall in grant_table.h have been removed).
Other cleanup:
- xen-mapcache.c and xen-legacy-backend.c don't need grant_table.h.
- xenfb.c doe
ranch: xen.next
Thanks.
Anthony PERARD (2):
Revert xen/io/ring.h of "Clean up a few header guard symbols"
xen: Import other xen/io/*.h
hw/9pfs/xen-9pfs.h |4 +-
hw/block/xen_blkif.h |5 +-
hw/char/xen_console.c|2
On Tue, Jun 18, 2019 at 01:14:08PM +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 18, 2019 at 12:23:38PM +0100, Anthony PERARD wrote:
> > Following 37677d7db3 "Clean up a few header guard symbols", QEMU start
> > to fail to build:
> >
> > In file included fro
nough.
(xenctrl.h does include params.h)
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- new patch replacing "xen: Import Xen public headers used by xen-hvm.c"
- only drop includes of params.h, and don't import the other two;
ioreq.h is an interface with Xen; e820.h
Hi,
Fix the build in osstest and some cleanup
For reference:
Recent flight failure:
https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01022.html
Bisect result:
https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01029.html
Thanks.
Anthony PERARD (4):
xen: Fix
leaned up a bit while importing them. The header
guard symbols are changed to match QEMU's coding style, some other
part of the file that QEMU doesn't use are removed.
Signed-off-by: Anthony PERARD
Reviewed-by: Paul Durrant
---
hw/9pfs/xen-9pfs.h |2
" along with blkif.h and
usbif.h as those describe interface (and would allow to also import a
xen.h header if that was necessary).
xen-mapcache.c doesn't needs grant_table.h.
Signed-off-by: Anthony PERARD
Reviewed-by: Paul Durrant
---
hw/9pfs/xen-9pfs.h | 2 +-
h
Avoid using a variable length array.
We allocate the `dirty_bitmap' buffer only once when we start tracking
for dirty bits.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- Allocate the bitmap buffer only once when we start tracking dirty bits.
(instead of at every function
On Tue, Jun 18, 2019 at 08:55:53AM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> >
> > On Mon, Jun 17, 2019 at 05:45:44PM +0100, Anthony PERARD wrote:
> > > On Mon, Jun 17, 2019 at 05:
ree the bitmap when
`log_for_dirtybit' is cleared.
Thanks,
--
Anthony PERARD
On Mon, Jun 17, 2019 at 05:45:44PM +0100, Anthony PERARD wrote:
> On Mon, Jun 17, 2019 at 05:15:51PM +0100, Paul Durrant wrote:
> > AFAICT the only place (apart from legacy code in xen_common.h) that
> > params.h is necessary is in xen_suspend_notifier(). I wonder whether
> >
On Mon, Jun 17, 2019 at 05:15:51PM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> > Sent: 17 June 2019 16:41
> > To: qemu-devel@nongnu.org
> > Cc: xen-de...@lists.xenproject.org; Anthony Pe
leaned up a bit while importing them. The header
guard symbols are changed to match QEMU's coding style, some other
part of the file that QEMU doesn't use are removed.
Signed-off-by: Anthony PERARD
---
hw/9pfs/xen-9pfs.h |2 +-
hw/block/xen_blkif.h
27;t use are removed.
xen-mapcache.c doesn't needs params.h, so remove the include.
Signed-off-by: Anthony PERARD
---
hw/i386/xen/xen-hvm.c | 6 +-
hw/i386/xen/xen-mapcache.c| 2 -
include/hw/xen/interface/hvm/e820.h | 28 +++
include/hw/xen/int
Avoid using a variable length array.
Signed-off-by: Anthony PERARD
---
Notes:
Was suggested by Peter here:
"should we try to stop using variable length arrays?"
hw/i386/xen/xen-hvm.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/i3
Hi,
Fix the build in osstest and some cleanup
For reference:
Recent flight failure:
https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01022.html
Bisect result:
https://lists.xenproject.org/archives/html/xen-devel/2019-06/msg01029.html
Thanks.
Anthony PERARD (4):
xen: Fix
" along with blkif.h and
usbif.h as those describe interface (and would allow to also import a
xen.h header if that was necessary).
xen-mapcache.c doesn't needs grant_table.h.
Signed-off-by: Anthony PERARD
---
hw/9pfs/xen-9pfs.h | 2 +-
hw/block/xen_blkif.h
F: hw/display/xenfb.c
> F: hw/net/xen_nic.c
> @@ -1505,6 +1505,7 @@ virtio-9p
> M: Greg Kurz
> S: Supported
> F: hw/9pfs/
> +X: hw/9pfs/xen-9p*
> F: fsdev/
> F: tests/virtio-9p-test.c
> T: git https://github.com/gkurz/qemu.git 9p-next
>
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
he conditional, so that the header
> can safely be included more than once.
> Guest CPU Cores (Xen):
> ------
>
> X86
> M: Stefano Stabellini
> M: Anthony Perard
> M: Paul Durrant
> include/hw/xen/io/ring.h
That file does have a guard, it's __XEN
or_setg(errp, "logical_block_size != %u not supported",
Maybe add "by frontend" to the error message?
> + XEN_BLKIF_SECTOR_SIZE);
> +return;
> +}
> +
With the question answered:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Wed, Apr 10, 2019 at 04:20:05PM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> > Sent: 10 April 2019 13:57
> > To: Paul Durrant
> > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org;
>
hedule()
> is moved into xen_block_complete_aio(), which is more intuitive since the
> only reason for doing a deferred poll of the shared ring should be because
> there were previously insufficient resources to fully complete a previous
> poll.
>
> Signed-off-by: Paul Durrant
> ---
Revie
xen_device_event, NULL, NULL, channel);
I wonder if the `'is_external' parameter of aio_set_fd_handler shoud be
`true' here, instead. That flag seems to be used when making a snapshot
of a blockdev, for example.
That was introduced by:
dca21ef23ba48f6f1428c59f295a857e5dc203c8^..c07bc2c1658fffeee08eb46402b2f66d55b07586
What do you think?
--
Anthony PERARD
> Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
There are a few places were I would have like to add an assert, but they
can't be compiled-out in QEMU :-(.
Thanks,
--
Anthony PERARD
he
granularity is set to the physical block size.
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190320142825.24565-1-paul.durr...@citrix.com>
Signed-off-by: Anthony PERARD
---
hw/block/xen-block.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
to
fail if logical_block_size is set to anything other than 512.
Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Message-Id: <20190401121719.27208-1-paul.durr...@citrix.com>
Signed-off-by: Anthony PERARD
---
hw/block/dataplane/xen-block.c | 28 +---
hw/block/x
The following changes since commit f4b37171378b0b1782570060c3411a504375d1bc:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190403' into
staging (2019-04-03 13:13:30 +0100)
are available in the Git repository at:
https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git
tags/p
alue of 512 in xenstore and
> scaling 'sectors' accordingly. The realize() method is also modified to
> fail if logical_block_size is set to anything other than 512.
>
> Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
; > Cc: Kevin Wolf ; Stefano Stabellini
> > ; Max Reitz
> > ; Stefan Hajnoczi ; Anthony Perard
> >
> > Subject: Re: [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion
> >
> > On 27/03/2019 17:32, Paul Durrant wrote:
> > > The Xen blkif p
re
> migration_object_init().
>
> Fixes: e60483f2f8498ae08ae79ca4c6fb03a3317f5e1e
> Reported-by: Anthony PERARD
> Signed-off-by: Markus Armbruster
Tested-by: Anthony PERARD
Thanks!
--
Anthony PERARD
ator(current_machine, argv[0]);
> -
> if (!qtest_enabled() && machine_class->deprecation_reason) {
> error_report("Machine type '%s' is deprecated: %s",
> machine_class->name, machine_class->deprecation_reason);
--
Anthony PERARD
On Tue, Mar 26, 2019 at 03:58:52PM +, Anthony PERARD wrote:
> On Wed, Mar 13, 2019 at 09:43:30AM +0100, Markus Armbruster wrote:
> > Recent commit cda4aa9a5a0 moved block backend creation before machine
> > property evaluation. This broke qemu-iotests 055. Turns out we need
&g
migration_object_init();
I think it's because migration_object_init() is now called before
configure_accelerator(). xen_accel_class_init() have some compat_props
for migration.
Any idea how to fix this?
Thanks,
--
Anthony PERARD
ECTOR_SIZE;
That the only thing that the thread [1] is changing.
> XenDevice *xendev = XEN_DEVICE(blockdev);
>
> trace_xen_block_size(type, vdev->disk, vdev->partition, sectors);
Thanks,
--
Anthony PERARD
t; Signed-off-by: Paul Durrant
With the two typos fixed (which I can try to remember to do on commit):
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Tue, Mar 19, 2019 at 07:34:45PM +0100, Markus Armbruster wrote:
> = hw/xenpv/xen_machine_pv.c =
> Stefano Stabellini (supporter:X86)
> Anthony Perard (supporter:X86)
> Paul Durrant (supporter:X86)
> xen-de...@lists.xenproject.org (open list:X86)
That machi
note that at least on FreeBSD using MAP_FIXED will cause mmap to
try harder to honor the passed address.
Signed-off-by: Roger Pau Monné
Reviewed-by: Paul Durrant
Acked-by: Anthony PERARD
Reviewed-by: Igor Druzhinin
Message-Id: <20190318173731.14494-1-roger@citrix.com>
Signed-off-
201 - 300 of 1264 matches
Mail list logo
