ages, pfn,
> +start_gpfn);
> +if (rc) {
> +int saved_errno = errno;
> +
> +error_report("relocate_memory %lu pages from GFN %"HWADDR_PRIx
> + " to GFN %"HWADDR_PRIx" failed: %s",
> + nr_pages, pfn, start_gpfn, strerror(saved_errno));
> +errno = saved_errno;
> +return -1;
> }
>
--
Anthony PERARD
On Tue, Mar 06, 2018 at 12:16:08PM +0800, Haozhong Zhang wrote:
> On 03/02/18 12:03 +0000, Anthony PERARD wrote:
> > On Wed, Feb 28, 2018 at 05:36:59PM +0800, Haozhong Zhang wrote:
> > > On 02/27/18 17:22 +0000, Anthony PERARD wrote:
> > > > On Thu, Dec 07, 2017 at 06
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Alan Robinson
> ---
> hw/block/xen_disk.c| 4 ++--
> hw/xenpv/xen_domainbuild.c | 10 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
dth, fb_page->height, fb_page->depth,
> fb_page->mem_length, 0, fb_page->line_length);
> if (rc != 0)
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
@ -47,7 +47,7 @@
> * From empirical tests I observed that qemu use 75MB more than the
> * max_mcache_size.
> */
> -#define NON_MCACHE_MEMORY_SIZE (80 * 1024 * 1024)
> +#define NON_MCACHE_MEMORY_SIZE (80 * M_BYTE)
>
> typedef struct MapCacheEntry {
> hwaddr paddr_index;
Acked-by: Anthony PERARD
--
Anthony PERARD
On Wed, Feb 28, 2018 at 05:36:59PM +0800, Haozhong Zhang wrote:
> On 02/27/18 17:22 +0000, Anthony PERARD wrote:
> > On Thu, Dec 07, 2017 at 06:18:02PM +0800, Haozhong Zhang wrote:
> > > This is the QEMU part patches that works with the associated Xen
> > > patches to
On Wed, Feb 28, 2018 at 03:56:54PM +0800, Haozhong Zhang wrote:
> On 02/27/18 16:41 +0000, Anthony PERARD wrote:
> > On Thu, Dec 07, 2017 at 06:18:05PM +0800, Haozhong Zhang wrote:
> > > @@ -108,7 +109,10 @@ void pc_dimm_memory_plug(DeviceState *dev,
> > &g
eir
creation with this:
In xenfv_machine_options()
m->rom_file_has_mr = false;
(setting this in xen_hvm_init() would probably be better, but I havn't
try)
If this is possible, libxl would not need to allocate more memory for
the guest (dm_acpi_size).
--
Anthony PERARD
ACPI to Xen. Therefore, we need to initialize fw_cfg when any
> ACPI is going to be built by QEMU.
>
> Signed-off-by: Haozhong Zhang
> ---
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: "Michael S. Tsirkin"
> Cc: Paolo Bonzini
> Cc: Richard Henderson
memory-backend-xen is not backed by RAM. */
> +if (!xen_enabled()) {
Is it possible to have the same condition as the one used in
host_memory_backend_memory_complete? i.e. base on whether the memory
region is mapped or not (backend->mr.ram_block).
> +vmstate_register_ram(vmstate_mr, dev);
> +}
> numa_set_mem_node_id(addr, memory_region_size(mr), dimm->node);
>
> out:
> --
> 2.15.1
>
--
Anthony PERARD
code for pc machine type to create the hotplug memory region for
> Xen HVM domains.
>
> Signed-off-by: Haozhong Zhang
> ---
> Cc: "Michael S. Tsirkin"
> Cc: Paolo Bonzini
> Cc: Richard Henderson
> Cc: Eduardo Habkost
> Cc: Stefano Stabellini
> Cc:
On Sat, Nov 25, 2017 at 01:16:09PM -0200, Eduardo Habkost wrote:
> There's no need to make the machine allow every possible sysbus
> device. We can now just add xen-sysdev to the allowed list.
>
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: xen-de...@lists.xenpr
ut-keymap.c
> +++ b/ui/input-keymap.c
> @@ -6,6 +6,7 @@
> #include "standard-headers/linux/input.h"
>
> #include "ui/input-keymap-linux-to-qcode.c"
> +#include "ui/input-keymap-qcode-to-linux.c"
> #include "ui/input-keymap-qcode-to-qnum.c"
> #include "ui/input-keymap-qnum-to-qcode.c"
--
Anthony PERARD
nge
FYI, I think that is done by <20171103115631.15175-3-owen.sm...@citrix.com>.
([PATCH v5 2/4] xenfb: Use Input Handlers directly)
--
Anthony PERARD
> + * remappable msi.
> + */
> +#define MSI_ADDR_IF_MASK 0x0010
I don't think that is the right place for a define, they also exist
outside of the context of the function.
That define would be better at the top of this file, I think. (There is
probably a better place in the common headers, but I'm not sure were.)
Thanks,
--
Anthony PERARD
nst older version of Xen, but I don't think an
older libxc (like from Xen 4.10) is going to correctly with this new
arguments.
> if (rc) {
> -XEN_PT_ERR(d, "Unbinding of MSI%s failed. (err: %d, pirq: %d,
> gvec: %#x)\n",
> - is_msix ? "-X" : "", errno, pirq, gvec);
> +XEN_PT_ERR(d, "Unbinding of MSI%s failed. (err: %d, pirq: %d, "
> + "addr: %"PRIx64", data: %#x)\n",
> + is_msix ? "-X" : "", errno, pirq, addr, data);
> return rc;
> }
> }
Thanks,
--
Anthony PERARD
b: activate input handlers for raw pointer devices
The patch series looks good to me:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
en-save-devices-state" which
default to true so older version of libxenlight can work with newer
version of QEMU.
Signed-off-by: Anthony PERARD
---
Changes in V2:
- add the live parameter
CC: Kevin Wolf
also CCing libxl maintainers:
CC: Ian Jackson
CC: Wei Liu
---
migration/savevm
move
> it to hw/xen.
>
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: xen-de...@lists.xenproject.org
> Signed-off-by: Paolo Bonzini
> ---
> Xen parts only compile-tested.
>
> docs/qdev-device-use.txt | 12 +-
> hw/i386/M
quot;%s\" doesn't exist (and is not .)\n",
The error message have not been update, I think it should be :
> +optarg);
> exit(1);
> }
> break;
With the error message fix:
Reviewed-by: Anthony PERARD
--
Anthony PERARD
rancis
> Cc: Gerd Hoffmann
> Cc: Andrzej Zaborowski
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: John Snow
> Cc: Aurelien Jarno
> Cc: Yongbok Kim
> Cc: Peter Crosthwaite
> Cc: Stefan Hajnoczi
> Cc: Fam Zheng
> Cc: Juan Quintela
> Cc: "Dr. D
tderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}'
> \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
>
> Some lines where then manually tweaked to pass checkpatch.
>
> xen_pt_log() was left with an fprintf(stderr,
>
> Signed-off-by: Alistair Francis
> Cc: Stefano Stabellini
> Cc: Anthony Perard
Acked-by: Anthony PERARD
--
Anthony PERARD
ck to the problem at hand. Whether
> it is a proper solution, I can't say without investing a lot more time.
--
Anthony PERARD
Hi Ian,
The patches in this v5 appear to be the same the one from the patch
series v4.
--
Anthony PERARD
On Thu, Oct 19, 2017 at 05:38:10PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [PATCH 1/8] xen: link against xentoolcore"):
> > I don't think it is necessary to do anything in qemu. The linker should
> > find on its own the new libxentoolcore as long as
TC_CFLAGS=$(CFLAGS) $(QEMU_CFLAGS)
> DTC_CPPFLAGS=-I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(SRC_PATH)/dtc/libfdt
>
> -subdir-dtc:dtc/libfdt dtc/tests
> +subdir-dtc: .git-submodule-status dtc/libfdt dtc/tests
> $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS)
> CPPFLAGS="$(DTC_CPPFLAGS)" CFLAGS="$(DTC_CFLAGS)" LDFLAGS="$(LDFLAGS)"
> ARFLAGS="$(ARFLAGS)" CC="$(CC)" AR="$(AR)" LD="$(LD)" $(SUBDIR_MAKEFLAGS)
> libfdt/libfdt.a,)
>
> dtc/%:
--
Anthony PERARD
On Wed, Oct 11, 2017 at 01:19:25PM -0700, Stefano Stabellini wrote:
> On Wed, 11 Oct 2017, Anthony PERARD wrote:
> > The only observation I have is that on a Linux guest, when I have
> > usbdevice=tablet, with this series the pv mouse seems to become the
> > primary way of
/hw/i386/pc_q35.c
> index 6c4ec4be4e..da3ea602e1 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -295,7 +295,6 @@ static void pc_q35_machine_options(MachineClass *m)
> {
> m->family = "pc_q35";
> m->desc = "Standard PC (Q35 + ICH9, 2009)";
> -m->hot_add_cpu = pc_hot_add_cpu;
> m->units_per_default_bus = 1;
> m->default_machine_opts = "firmware=bios-256k.bin";
> m->default_display = "std";
--
Anthony PERARD
__, start, nb_pages, errno, strerror(errno));
> }
> }
> }
There is already a patch, not applied yet for it,
https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07541.html
with the only difference is printing the value of rc and not errno (both
patch user errno for strerror).
I guess this patch is better, so
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Tue, Oct 10, 2017 at 04:52:48PM -0700, Stefano Stabellini wrote:
> On Mon, 2 Oct 2017, Anthony PERARD wrote:
> > On Tue, Sep 26, 2017 at 02:43:39PM +, Owen Smith wrote:
> > > Writes "feature-raw-pointer" during init to indicate the backend
> > > can
.c| 1 -
> util/qemu-sockets.c| 1 -
> vl.c | 1 -
> 10 files changed, 12 deletions(-)
>
Reviewed-by: Anthony PERARD
--
Anthony PERARD
rintf(stderr, "Replacing a dummy mapcache entry for "TARGET_FMT_plx \
> -" with "TARGET_FMT_plx"\n", old_phys_addr, new_phys_addr);
> +error_report("Replacing a dummy mapcache entry for "TARGET_FMT_plx \
> + " with "T
orm.c | 1 -
> hw/isa/vt82c686.c | 1 -
> hw/misc/ivshmem.c | 1 -
> hw/misc/sga.c | 1 -
> hw/pci-bridge/pci_expander_bridge.c | 1 -
> monitor.c | 1 -
> 9 files changed, 9 deletion
X86 -> hw/xen and few other changes]
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
t; #include "hw/xen/xen_backend.h"
> @@ -36,7 +37,7 @@ static void xen_init_pv(MachineState *machine)
>
> /* Initialize backend core & drivers */
> if (xen_be_init() != 0) {
> -fprintf(stderr, "%s: xen backend core setup failed\n", __func__);
> +error_report("%s: xen backend core setup failed", __func__);
> exit(1);
> }
>
> @@ -51,18 +52,18 @@ static void xen_init_pv(MachineState *machine)
> const char *initrd_filename = machine->initrd_filename;
> if (xen_domain_build_pv(kernel_filename, initrd_filename,
> kernel_cmdline) < 0) {
> -fprintf(stderr, "xen pv domain creation failed\n");
> +error_report("xen pv domain creation failed");
> exit(1);
> }
> break;
> }
> #endif
> case XEN_EMULATE:
> -fprintf(stderr, "xen emulation not implemented (yet)\n");
> +error_report("xen emulation not implemented (yet)");
> exit(1);
> break;
> default:
> -fprintf(stderr, "unhandled xen_mode %d\n", xen_mode);
> +error_report("unhandled xen_mode %d", xen_mode);
> exit(1);
> break;
> }
The rest of the patch looks good.
Thanks,
--
Anthony PERARD
provide a stub for earlier versions.
>
> Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
--
Anthony PERARD
han after os_setup_post, because
> xen_restrict may need to open /dev/null, and os_setup_post might have
> called chroot.
>
> Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
--
Anthony PERARD
tional change.
>
> Signed-off-by: Ian Jackson
Acked-by: Anthony PERARD
--
Anthony PERARD
er, only. Provide a compatibility stub. And drop the
> compatibility stubs for the old functions.
>
> Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
--
Anthony PERARD
On Mon, Oct 09, 2017 at 05:58:17PM +0100, Ian Jackson wrote:
> (My resend has crossed with your review. Sorry about that.)
>
> Anthony PERARD writes ("Re: [PATCH 3/8] xen: defer call to xen_restrict until
> after os_setup_post"):
> > On Wed, Oct 04, 2017 at 05:18:0
On Mon, Oct 09, 2017 at 05:28:08PM +0100, Ian Jackson wrote:
> Ian Jackson writes ("[PATCH 1/8] xen: link against xentoolcore"):
> > From: Anthony PERARD
> >
> > Xen libraries 4.10 will include a new xentoolcore library, without
> > which xendevicemodel et a
vte_terminal_copy_clipboard() is deprecated in VTE 0.50.
Signed-off-by: Anthony PERARD
---
ui/gtk.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index 5bd87c265a..342e96fbe9 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1702,7 +1702,12 @@ static void gd_menu_copy
xen_hvm_init(PCMachineState *pcms, MemoryRegion
> **ram_memory)
> void qmp_xen_set_global_dirty_log(bool enable, Error **errp)
> {
> }
> +
> +void xen_setup_post(void)
> +{
> +}
> diff --git a/vl.c b/vl.c
> index fb1f05b..9e7d541 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4793,6 +4793,7 @@ int main(int argc, char **argv, char **envp)
> }
>
> os_setup_post();
> +xen_setup_post();
>
> main_loop();
> replay_disable_events();
> --
> 2.1.4
>
--
Anthony PERARD
On Mon, Oct 09, 2017 at 04:02:31PM +0100, Daniel P. Berrange wrote:
> On Mon, Oct 09, 2017 at 03:55:42PM +0100, Anthony PERARD wrote:
> > Hi,
> >
> > Looks like vte_terminal_copy_clipboard() is been deprecated:
> >
> > CC ui/gtk.o
> > ui/gtk.c: In fu
L(1);
^~~
cc1: all warnings being treated as errors
make: *** [/local/home/sheep/work/qemu/rules.mak:66: ui/gtk.o] Error 1
Package version:
$ pacman -Qo /usr/include/vte-2.91/vte/vte.h
/usr/include/vte-2.91/vte/vte.h is owned by vte3 0.50.1-1
Regards,
--
Anthony PERARD
On Tue, Oct 03, 2017 at 12:33:37PM +0100, Roger Pau Monné wrote:
> On Mon, Oct 02, 2017 at 04:30:58PM +0000, Anthony PERARD wrote:
> > When doing a live migration of a Xen guest with libxl, the images for
> > block devices are locked by the original QEMU process, and this prevent
On Wed, Sep 27, 2017 at 05:10:09PM +0100, Wei Liu wrote:
> The error code is encoding in errno, not rc.
^ encoded
I think.
Otherwise,
Reviewed-by: Anthony PERARD
Thanks,
>
> Signed-off-by: Wei Liu
> ---
> Cc: Stefano Stabellini
> Cc: Anthony PERARD
&g
ert "ACPI: don't call acpi_pcihp_device_plug_cb on xen""
There is also two more patches that are not commited yet, so I don't
known if they can be candidate for the stable release:
"xen: add a global indicator for grant copy being available"
"xen: dont try setting max grants multiple times"
Thanks,
--
Anthony PERARD
ing to need a compatibility stub in
xen_common.h.
> +if (!rc)
> +return;
> +perror("xendevicemodel_shutdown failed");
> +/* well, try the old thing then */
> +}
> +
> xc_handle = xc_interface_open(0, 0, 0);
> if (xc_handle == NULL) {
> fprintf(stderr, "Cannot acquire xenctrl handle\n");
--
Anthony PERARD
On Fri, Sep 15, 2017 at 07:09:57PM +0100, Ian Jackson wrote:
> We are going to want to reuse this.
>
> No functional change.
>
> Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
--
Anthony PERARD
(), that's just
a debug printf.
Also, we could remove the compatibility stub for xendevicemodel_restrict
and xenforeignmemory_restrict as there are not used anymore.
--
Anthony PERARD
On Fri, Sep 15, 2017 at 07:09:55PM +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson
Reviewed-by: Anthony PERARD
--
Anthony PERARD
e_libs="-lxenforeignmemory -lxengnttab -lxenevtchn"
> > +xen_stable_libs="-lxenforeignmemory -lxengnttab -lxenevtchn
> > -lxentoolcore"
>
> I don't think this is necessary. libxentoolcore is only available with
> a new Xen, which will always have the xentoolcore.pc file installed.
Only if ! echo $EXTRA_LDFLAGS | grep tools/libxc;
So building qemu via xen.git Makefiles, the pkg-config files are not
taken into account.
--
Anthony PERARD
olcore_restrict_all(0);
return 0;
}
EOF
-compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs"
+compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs
-lxentoolcore"
then
- xen_stable_libs="-lxendevicemodel $xen_stable_libs"
+ xen_stable_libs="-lxendevicemodel $xen_stable_libs -lxentoolcore"
xen_ctrl_version=41000
xen=yes
elif
--
Anthony PERARD
multiple times for a domain, e.g. in case grub-xen is being
> used to boot it.
>
> So instead of letting the generic backend code open the gnttab device
> do it in blk_connect() and close it again in blk_disconnect.
>
> Signed-off-by: Juergen Gross
Acked-by: Anthony PERARD
Tha
.instance_finalize = xen_pci_passthrough_finalize,
> .class_init = xen_pci_passthrough_class_init,
> +.interfaces = (InterfaceInfo[]) {
> +{ INTERFACE_LEGACY_PCI_DEVICE },
> +{ },
> +},
> };
>
> static void xen_pci_passthrough_register_types(void)
Acked-by: Anthony PERARD
--
Anthony PERARD
pus:
QMP command: { "execute": "cpu-add", "id": 2, "arguments": { "id": 2 } }
error message: Device 'qemu32-i386-cpu' does not support hotplugging
I've tested all I could think of that would involve hotplug.
Thanks,
--
Anthony PERARD
+ !xen_feature_grant_copy);
> xenstore_write_be_int(&blkdev->xendev, "info", info);
>
> xenstore_write_be_int(&blkdev->xendev, "max-ring-page-order",
> diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
> index c
vice *xendev)
> @@ -1363,7 +1374,6 @@ static void blk_event(struct XenDevice *xendev)
>
> struct XenDevOps xen_blkdev_ops = {
> .size = sizeof(struct XenBlkDev),
> -.flags = DEVOPS_FLAG_NEED_GNTDEV,
> .alloc = blk_alloc,
> .init = blk_init,
> .initialise= blk_connect,
> --
> 2.12.3
>
--
Anthony PERARD
> Signed-off-by: Jan Beulich
Acked-by: Anthony PERARD
> --- a/hw/block/xen_disk.c
> +++ b/hw/block/xen_disk.c
> @@ -1232,7 +1232,7 @@ static int blk_connect(struct XenDevice
> return -1;
> }
>
> -domids = g_malloc0_n(blkdev->nr_ring_ref, sizeo
6:0: note: this is the location of the previous
definition
#define KEY_F(n) (KEY_F0+(n)) /* Value of function key n */
[...]
And a lot more...
--
Anthony PERARD
patch, the offset
sent via QMP seems to be between the previous value of the guest rtc and
the new one. Other calls to qapi_event_send_rtc_change send the offset
between the new guest RTC and qemu_time().
--
Anthony PERARD
Signed-off-by: Anthony PERARD
---
New patch in V3
---
hw/acpi/pcihp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index c420a388ea..9db3c2eaf2 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -273,7 +273,7 @@ static void pci_write
Adding PCI passthrough before the guest start works fine (broken in 2.9 but now
fixed), but hotplug does not work anymore.
Anthony PERARD (3):
hw/acpi: Limit hotplug to root bus on legacy mode
hw/acpi: Move acpi_set_pci_info to pcihp
Revert "ACPI: don't call acpi_pcihp_device_plug
hotplug to root bus on legacy mode
hw/acpi: Move acpi_set_pci_info to pcihp
Signed-off-by: Anthony PERARD
---
CC: Stefano Stabellini
CC: Bruce Rogers
---
hw/acpi/piix4.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index
BSEL twice"
(f0c9d64a68b776374ec4732424a3e27753ce37b6).
Adding find_i440fx into stubs so that mips-softmmu target can be built.
Reported-by: Sander Eikelenboom
Signed-off-by: Anthony PERARD
---
Changes in V4:
- call acpi_set_pci_info only once
- Add a stub of find_i440fx (for mips_softmmu targ
On Fri, Aug 18, 2017 at 04:19:57PM +0200, Igor Mammedov wrote:
> On Fri, 18 Aug 2017 14:31:07 +0100
> Anthony PERARD wrote:
>
> > On Fri, Aug 18, 2017 at 11:37:34AM +0200, Igor Mammedov wrote:
> > > On Fri, 18 Aug 2017 04:40:02 +0300
> > > "Michael S. Ts
On Fri, Aug 18, 2017 at 11:37:34AM +0200, Igor Mammedov wrote:
> On Fri, 18 Aug 2017 04:40:02 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Thu, Aug 17, 2017 at 05:23:46PM +0100, Anthony PERARD wrote:
> > > This means that the function will be call and the prop
the property starts with commit
"pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice"
(f0c9d64a68b776374ec4732424a3e27753ce37b6).
Reported-by: Sander Eikelenboom
Signed-off-by: Anthony PERARD
---
Changes in V3:
- move acpi_set_pci_info to pcihp instead
Changes in V2:
- check for ac
: Disallow change of hotplug_select on legacy_piix
hw/acpi: Move acpi_set_pci_info to pcihp
Signed-off-by: Anthony PERARD
---
CC: Stefano Stabellini
CC: Bruce Rogers
---
hw/acpi/piix4.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
Signed-off-by: Anthony PERARD
---
New patch in V3
---
hw/acpi/pcihp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index c420a388ea..9db3c2eaf2 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -273,7 +273,7 @@ static void pci_write
Adding PCI passthrough before the guest start works fine (broken in 2.9 but now
fixed), but hotplug does not work anymore.
Anthony PERARD (3):
hw/acpi: Limit hotplug to root bus on legacy mode
hw/acpi: Move acpi_set_pci_info to pcihp
Revert "ACPI: don't call acpi_pcihp_device_plug
On Wed, Aug 16, 2017 at 11:10:46AM +0200, Igor Mammedov wrote:
> On Tue, 15 Aug 2017 22:24:08 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Tue, Aug 15, 2017 at 02:07:51PM +0200, Igor Mammedov wrote:
> > > On Tue, 15 Aug 2017 12:15:48 +0100
> > > Anthon
Adding PCI passthrough before the guest start works fine (broken in 2.9 but now
fixed), but hotplug does not work anymore.
Anthony PERARD (2):
hw/acpi: Call acpi_set_pci_info when no ACPI tables needed
Revert "ACPI: don't call acpi_pcihp_device_plug_cb on xen"
hw/acpi/pi
acpi_set_pci_info when no ACPI tables needed).
Signed-off-by: Anthony PERARD
---
CC: Stefano Stabellini
CC: Bruce Rogers
---
hw/acpi/piix4.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index f276967365..f4fd5907b8 100644
--- a/hw
twice"
(f0c9d64a68b776374ec4732424a3e27753ce37b6).
Set pci info before checking for the needs to build ACPI tables.
Assign bsel=0 property only to the root bus on Xen as there is no
support in the Xen ACPI tables for a different value.
Reported-by: Sander Eikelenboom
Signed-off-by: Anthony PERARD
---
Changes in V2:
-
On Mon, Aug 14, 2017 at 06:53:14PM +0300, Michael S. Tsirkin wrote:
> On Mon, Aug 14, 2017 at 03:55:50PM +0100, Anthony PERARD wrote:
> > On Fri, Aug 11, 2017 at 08:18:28PM +0300, Michael S. Tsirkin wrote:
> > > On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote:
On Fri, Aug 11, 2017 at 08:18:28PM +0300, Michael S. Tsirkin wrote:
> On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote:
> > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be
> > set, but this was done only when ACPI tables are built which is not
is usage. This patch recognizes
> this case and uses new interfaces to bind/unbind msi.
>
> Signed-off-by: Chao Gao
> Signed-off-by: Lan Tianyu
Reviewed-by: Anthony PERARD
That patch series can be applied once the Xen side patches are merged.
Thanks,
--
Anthony PERARD
Adding PCI passthrough before the guest start works fine (broken in 2.9 but now
fixed), but hotplug does not work anymore.
Anthony PERARD (2):
hw/acpi: Call acpi_set_pci_info when no ACPI tables needed
Revert "ACPI: don't call acpi_pcihp_device_plug_cb on xen"
hw/acpi/pi
twice"
(f0c9d64a68b776374ec4732424a3e27753ce37b6).
Set pci info before checking for the needs to build ACPI tables.
Reported-by: Sander Eikelenboom
Tested-by: Sander Eikelenboom
Signed-off-by: Anthony PERARD
---
In this patch rather than always calling acpi_set_pci_info() when
acpi_setup() is called, we could check
acpi_set_pci_info when no ACPI tables needed).
Signed-off-by: Anthony PERARD
---
CC: Stefano Stabellini
CC: Bruce Rogers
---
hw/acpi/piix4.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index f276967365..f4fd5907b8 100644
--- a/hw
The lock parameter make it explicit in which context qemu_ram_ptr_length
is called.
Signed-off-by: Anthony PERARD
---
exec.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/exec.c b/exec.c
index 01ac21e3cd..63508cd35e 100644
--- a/exec.c
+++ b/exec.c
@@ -2203,7 +2203
stall Windows, so without pv driver.)
Thanks,
--
Anthony PERARD
xen_remap_bucket(entry, entry->vaddr_base,
> + cache_size, address_index, false);
> +if (!test_bits(address_offset >> XC_PAGE_SHIFT,
> +test_bit_size >> XC_PAGE_SHIFT,
> +entry->valid_mapping)) {
> +DPRINTF("Unable to update a mapcache entry for %lx!\n",
> old_phys_addr);
> +return NULL;
> +}
> +
> +return entry->vaddr_base + address_offset;
> +}
> +
--
Anthony PERARD
: In function `xen_pt_status_reg_init':
> /root/src/github.com/qemu/qemu/hw/xen/xen_pt_config_init.c:281:
> undefined reference to `xen_shutdown_fatal_error'
> /root/src/github.com/qemu/qemu/hw/xen/xen_pt_config_init.c:275:
> undefined reference to `xen_shutdown_fatal_error'
> hw/xen/xen_pt_graphics.o: In function `get_vgabios':
> /root/src/github.com/qemu/qemu/hw/xen/xen_pt_graphics.c:135: undefined
> reference to `pci_assign_dev_load_option_rom'
> collect2: error: ld returned 1 exit status
Our CI also fail on this merge, QEMU build fine, be it can't be use.
Error message (on arm*):
qemu-system-i386: -xen-domid 1: Option not supported for this target
Full log: http://logs.test-lab.xenproject.org/osstest/logs/111601/
--
Anthony PERARD
rg/gitweb/?p=xen.git;a=commit;h=1096aa02
>
> Signed-off-by: Paul Durrant
> Reviewed-by: Stefano Stabellini
> --
> Cc: Anthony Perard
>
> v3:
> - Updated to reference Xen documentation patch
>
> v2:
> - Fix the commit comment
> ---
> hw/i386/xen/xen_platfor
On Wed, Jul 05, 2017 at 02:56:35PM +0100, Anoob Soman wrote:
> xen_pt_pci_config_access_check checks if addr >= 0xFF. 0xFF is a valid
> address and should not be ignored.
>
> Signed-off-by: Anoob Soman
Acked-by: Anthony PERARD
> ---
> hw/xen/xen_pt.c | 2 +-
> 1 f
that have a PCI device (having
unplug_nic cleanup the peer). But I cannot think of a scenario with xen
where a nic is not also a pci device.
Anyway, this patch works:
Acked-by: Anthony PERARD
--
Anthony PERARD
atch
> avoids wrongly regarding a remappable format interrupt request as
> an interrupt binded with an event channel.
>
> Signed-off-by: Chao Gao
> Signed-off-by: Lan Tianyu
The patch needs to be rebased on top of QEMU upstream.
Beside that:
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
hen
+ xen_stable_libs="-lxendevicemodel $xen_stable_libs"
+ xen_ctrl_version=41000
+ xen=yes
+
+# Xen 4.9
+elif
+cat > $TMPC <
> index 8e1580d..4ba43a8 100644
> --- a/include/hw/xen/xen_common.h
> +++ b/include/hw/xen/xen_common.h
>
;
> Signed-off-by: Chao Gao
> Signed-off-by: Lan Tianyu
Reviewed-by: Anthony PERARD
> ---
> include/hw/i386/apic-msidef.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h
> index 8b4d4
On Wed, Jun 28, 2017 at 10:02:55PM -0300, Philippe Mathieu-Daudé wrote:
> moved in 56e2cd24..28b99f47 to accel/
That is not accurate, files have been moved to hw/i386/xen/ as written
in both commits messages.
Beside that:
Acked-by: Anthony PERARD
> Signed-off-by: Philippe Mathieu
(which you don't depend on anyway).
>
> After careful consideration, I think I'll submit my version of the
> patch, assuming that Anthony is OK with it. (FYI I had to keep your
> signed-off-by line for copyright reasons: you own the copyright on some
> of the changes.)
>
ng down. When net_cleanup() is
called a second time, qemu crash. That probably not a good sign, even if
the guest continue to live after a reboot or a migration.
--
Anthony PERARD
gt; of being in seperate headers.
>
> Signed-off-by: Marc-André Lureau
Thanks, that works for me.
Tested-by: Anthony PERARD
--
Anthony PERARD
is not a valid char driver name
FYI, the full command line used:
/usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 \
-xen-attach -name dom0 -nographic -M xenpv -daemonize \
-monitor /dev/null -serial /dev/null -parallel /dev/null \
-nodefaults -no-user-config \
-pidfile /var/run/xen
e. Only apic_send_msi() and msi_dest_id() use
> the mask
> to get dest apic id. They mask MSI address field with
> MSI_ADDR_DEST_ID_MASK and
> then right-shift 12bit. The low 12bit won't be used.
>
> Anthony, does this make sense?
Yes, it does.
The change to MSI_ADDR_DEST_ID_MASK should probably go in its own patch.
--
Anthony PERARD
32_t msi_data, uint32_t msi_addr_lo)
> {
> +/* If msi address is configurate to remapping format, the msi will not
> + * remapped into a pirq.
What do you think of: "If the MSI address is configured in remappable
format, the MSI will not be remapped into a pirq." ?
> + */
> +if (msi_addr_lo & MSI_ADDR_IF_MASK)
> +return 0;
> /* If vector is 0, the msi is remapped into a pirq, passed as
> * dest_id.
> */
Thanks,
--
Anthony PERARD
, gvec);
> +return rc;
> +}
> }
> }
>
> diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h
> index 8b4d4cc..2c450f9 100644
> --- a/include/hw/i386/apic-msidef.h
> +++ b/include/hw/i386/apic-msidef.h
> @@ -26,6 +26,7 @@
>
> #define MSI_ADDR_DEST_ID_SHIFT 12
> #define MSI_ADDR_DEST_IDX_SHIFT 4
> -#define MSI_ADDR_DEST_ID_MASK 0x000
> +#define MSI_ADDR_DEST_ID_MASK 0x000fff00
The value of MSI_ADDR_DEST_ID_MASK is changed here. I think the patch
should be:
+#define MSI_ADDR_DEST_ID_MASK 0x0000
> +#define MSI_ADDR_IF_MASK 0x0010
>
> #endif /* HW_APIC_MSIDEF_H */
Thanks,
--
Anthony PERARD
501 - 600 of 1264 matches
Mail list logo
