[PATCH v4 2/2] hw/riscv: allow ramfb on virt

Allow ramfb on virt. This lets `-device ramfb' work. Signed-off-by: Asherah Connor Reviewed-by: Bin Meng Reviewed-by: Alistair Francis --- (no changes since v2) Changes in v2: * Add ramfb as allowed on riscv virt machine class. hw/riscv/virt.c | 3 +++ 1 file changed, 3 insertions

[PATCH v4 1/2] hw/riscv: Add fw_cfg support to virt

Provides fw_cfg for the virt machine on riscv. This enables using e.g. ramfb later. Signed-off-by: Asherah Connor Reviewed-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v4: * Adapt for changes made in c65d7080d8 "hw/riscv: migrate fdt field to generic MachineState"

[PATCH v4 0/2] hw/riscv: Add fw_cfg support, allow ramfb

neric MachineState". Changes in v3: * Document why fw_cfg is done when it is. * Move VIRT_FW_CFG before VIRT_FLASH. Changes in v2: * Add DMA support (needed for writes). * Add ramfb as allowed on riscv virt machine class. Asherah Connor (2): hw/riscv: Add fw_cfg support to virt hw/riscv: a

Re: [PATCH v3 1/2] hw/riscv: Add fw_cfg support to virt

Hi Alistair, On 21/03/18 05:03:p, Alistair Francis wrote: > I'm guessing the failure is because of "hw/riscv: migrate fdt field to > generic MachineState" which moved the fdt element to the MachineState. > > The fix should just be to change s->fdt to mc->fdt. Yes, looks like it. I'll fix it up

Re: [PATCH v2 1/2] hw/riscv: Add fw_cfg support to virt

Hi Bin, Thanks very much for your review. On 21/02/28 02:02:p, Bin Meng wrote: > I guess this is put here because riscv_load_fdt() is trying to touch > the device tree, and creating fw_cfg has to be done before that? > Maybe a comment is needed to prevent whoever later wanted to move the > codes

[PATCH v3 2/2] hw/riscv: allow ramfb on virt

Allow ramfb on virt. This lets `-device ramfb' work. Signed-off-by: Asherah Connor Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: * Add ramfb as allowed on riscv virt machine class. hw/riscv/virt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/riscv/virt.c b/hw

[PATCH v3 1/2] hw/riscv: Add fw_cfg support to virt

Provides fw_cfg for the virt machine on riscv. This enables using e.g. ramfb later. Signed-off-by: Asherah Connor --- Changes in v3: * Document why fw_cfg is done when it is. * Move VIRT_FW_CFG before VIRT_FLASH. Changes in v2: * Add DMA support (needed for writes). hw/riscv/Kconfig

[PATCH v3 0/2] hw/riscv: Add fw_cfg support, allow ramfb

DMA support (needed for writes). * Add ramfb as allowed on riscv virt machine class. Asherah Connor (2): hw/riscv: Add fw_cfg support to virt hw/riscv: allow ramfb on virt hw/riscv/Kconfig| 1 + hw/riscv/virt.c | 33 + include/hw/riscv/virt.h

[PATCH v2 2/2] hw/riscv: allow ramfb on virt

Allow ramfb on virt. This lets `-device ramfb' work. Signed-off-by: Asherah Connor --- Changes in v2: * Add DMA interface support. * Add ramfb as allowed on riscv virt machine class. hw/riscv/virt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c

[PATCH v2 1/2] hw/riscv: Add fw_cfg support to virt

Provides fw_cfg for the virt machine on riscv. This enables using e.g. ramfb later. Signed-off-by: Asherah Connor --- Changes in v2: * Add DMA support (needed for writes). hw/riscv/Kconfig| 1 + hw/riscv/virt.c | 27 +++ include/hw/riscv/virt.h | 4

[PATCH v2 0/2] hw/riscv: Add fw_cfg support, allow ramfb

as allowed on riscv virt machine class. Asherah Connor (2): hw/riscv: Add fw_cfg support to virt hw/riscv: allow ramfb on virt hw/riscv/Kconfig| 1 + hw/riscv/virt.c | 30 ++ include/hw/riscv/virt.h | 4 +++- 3 files changed, 34 insertions(+), 1 deletion

Re: [PATCH] hw/riscv: Add basic fw_cfg support to virt

Hi Philippe, On 21/02/25 12:02:p, Philippe Mathieu-Daudé wrote: > Hi Asherah, > > You forgot to Cc the maintainers (doing it now): Ah, my bad. Thank you! > What is missing here is why do you need this, what problem > does this patch solve. I would eventually like to use qemu ramfb on RISC-V

[PATCH] hw/riscv: Add basic fw_cfg support to virt

Provides a minimal fw_cfg for the virt machine on riscv. I've arbitrarily selected an MMIO base for it. This is very rudimentary, so no DMA interface is exposed. Tested as working! (First patch to qemu, so whatever patience you can afford would be appreciated.) Signed-off-by: Asherah Connor