Re: [Qemu-devel] [PATCH v7 17/17] intel_iommu: enable vfio devices

Hi Peter, Thanks, I think that I should receive credit for this patch. Please attribute it under my technion mail: bda...@cs.technion.ac.il. The signed-off line should be: Signed-off-by: Aviv Ben-David Thanks, Aviv. On Thu, Mar 16, 2017 at 6:05 AM, Peter Xu

Re: [Qemu-devel] [PATCH v7 3/5] IOMMU: enable intel_iommu map and unmap notifiers

On Tue, Nov 29, 2016 at 5:23 AM 蓝天宇 <lantianyu1...@gmail.com> wrote: > 2016-11-28 23:51 GMT+08:00 Aviv B.D <bd.a...@gmail.com>: > > From: "Aviv Ben-David" <bd.a...@gmail.com> > > > > Adds a list of registered vtd_as's to intel iommu state to sa

Re: [Qemu-devel] [PATCH v7 5/5] IOMMU: add specific null implementation of iommu_replay to intel_iommu

On Mon, Nov 28, 2016 at 6:36 PM Alex Williamson <alex.william...@redhat.com> wrote: > On Mon, 28 Nov 2016 17:51:55 +0200 > "Aviv B.D" <bd.a...@gmail.com> wrote: > > > From: "Aviv Ben-David" <bd.a...@gmail.com> > > > &

[Qemu-devel] [PATCH v7 3/5] IOMMU: enable intel_iommu map and unmap notifiers

From: "Aviv Ben-David" Adds a list of registered vtd_as's to intel iommu state to save iteration over each PCI device in a search of the corrosponding domain. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 94

[Qemu-devel] [PATCH v7 2/5] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

From: "Aviv Ben-David" Supports translation trials without reporting error to guest on translation failure. Signed-off-by: Aviv Ben-David --- exec.c | 3 ++- hw/alpha/typhoon.c | 2 +- hw/i386/amd_iommu.c | 4 ++--

[Qemu-devel] [PATCH v7 4/5] IOMMU: add specific replay function with default implemenation

From: "Aviv Ben-David" The default implementation scans the address space and try to find translation for each page, if exists. This callback enables effiecent implementation for intel_iommu and other subsystems with large address space. Signed-off-by: Aviv Ben-David

[Qemu-devel] [PATCH v7 1/5] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

From: "Aviv Ben-David" This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 5 +

[Qemu-devel] [PATCH v7 5/5] IOMMU: add specific null implementation of iommu_replay to intel_iommu

From: "Aviv Ben-David" Currently the implementation preventing VFIO to work together with intel_iommu. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/intel_iommu.c

[Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

From: "Aviv Ben-David" * Advertize Cache Mode capability in iommu cap register. This capability is controlled by "cache-mode" property of intel-iommu device. To enable this option call QEMU with "-device intel-iommu,cache-mode=true". * On page cache invalidation in intel

Re: [Qemu-devel] [PATCH v6 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

11:39, Michael S. Tsirkin wrote: >>> >>>> > >On Fri, Nov 11, 2016 at 10:32:42AM +0800, Jason Wang wrote: >>>> >>>>> > > > >>>>> > > >On 2016年11月10日 06:00, Michael S. Tsirkin wrote: >>&g

Re: [Qemu-devel] [PATCH v6 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

ote: >>> >>>> On Wed, Nov 09, 2016 at 03:28:02PM +0800, Jason Wang wrote: >>>> >>>>> >>>>>> On 2016年11月08日 19:04, Aviv B.D wrote: >>>>>> >>>>>>> From: "Aviv Ben-David"<bd.a...

Re: [Qemu-devel] [PATCH v6 0/3] IOMMU: intel_iommu support map and unmap notifications

On Wed, Nov 16, 2016 at 9:57 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Wed, Nov 16, 2016 at 09:50:46PM +0200, Aviv B.D. wrote: > > > > > > On Wed, Nov 16, 2016 at 5:34 PM, Alex Williamson < > alex.william...@redhat.com> > > wrote: >

Re: [Qemu-devel] [PATCH v6 0/3] IOMMU: intel_iommu support map and unmap notifications

ot;Michael S. Tsirkin" <m...@redhat.com> wrote: > > > > > > > > > > > On Thu, Nov 10, 2016 at 08:30:21AM -0700, Alex Williamson wrote: > > > > > > > On Thu, 10 Nov 2016 17:14:24 +0200 > > >

Re: [Qemu-devel] [PATCH v6 0/3] IOMMU: intel_iommu support map and unmap notifications

> On Thu, Nov 10, 2016 at 08:30:21AM -0700, Alex Williamson wrote: > > > > On Thu, 10 Nov 2016 17:14:24 +0200 > > > > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > > > > > > > On Tue, Nov 08, 2016 at 01:04:21PM +0200, Aviv B.D

[Qemu-devel] [PATCH v6 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

From: "Aviv Ben-David" This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 5 +

[Qemu-devel] [PATCH v6 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

From: "Aviv Ben-David" Supports translation trials without reporting error to guest on translation failure. Signed-off-by: Aviv Ben-David --- exec.c | 3 ++- hw/alpha/typhoon.c | 2 +- hw/i386/amd_iommu.c | 4 ++--

[Qemu-devel] [PATCH v6 0/3] IOMMU: intel_iommu support map and unmap notifications

From: "Aviv Ben-David" * Advertize Cache Mode capability in iommu cap register. This capability is controlled by "cache-mode" property of intel-iommu device. To enable this option call QEMU with "-device intel-iommu,cache-mode=true". * On page cache invalidation in intel

[Qemu-devel] [PATCH v6 3/3] IOMMU: enable intel_iommu map and unmap notifiers

From: "Aviv Ben-David" Adds a list of registered vtd_as's to intel iommu state to save iteration over each PCI device in a search of the corrosponding domain. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 96

Re: [Qemu-devel] [PATCH v5 0/3] IOMMU: intel_iommu support map and unmap notifications

I will fix the warning in apb.c... Can you post your qemu build configuration? Thanks, Aviv. On Wed, Oct 26, 2016 at 6:37 PM, Chao Gao <chao@intel.com> wrote: > On Fri, Oct 21, 2016 at 12:07:18AM +0300, Aviv B.D wrote: > >From: "Aviv Ben-David" <bd.a...@gmail.c

Re: [Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

On Mon, Oct 24, 2016 at 11:02 AM, Peter Xu <pet...@redhat.com> wrote: > On Mon, Oct 24, 2016 at 10:53:01AM +0300, Aviv B.D. wrote: > > [...] > > > This was my first algorithm, but VFIO do not support remapping of mapped > > page. > > Before each MAP

Re: [Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

On Fri, Oct 21, 2016 at 6:57 AM, Peter Xu <pet...@redhat.com> wrote: > On Thu, Oct 20, 2016 at 10:11:15PM +0300, Aviv B.D. wrote: > > [...] > > > > > +static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, > > > > +

[Qemu-devel] [PATCH v5 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

From: "Aviv Ben-David" Supports translation trials without reporting error to guest on translation failure. Signed-off-by: Aviv Ben-David --- exec.c| 3 ++- hw/i386/amd_iommu.c | 4 ++-- hw/i386/intel_iommu.c | 59

[Qemu-devel] [PATCH v5 3/3] IOMMU: enable intel_iommu map and unmap notifiers

From: "Aviv Ben-David" Adds a list of registered vtd_as's to intel iommu state to save iteration over each PCI device in a search of the corrosponding domain. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 109

[Qemu-devel] [PATCH v5 0/3] IOMMU: intel_iommu support map and unmap notifications

From: "Aviv Ben-David" * Advertize Cache Mode capability in iommu cap register. This capability is controlled by "cache-mode" property of intel-iommu device. To enable this option call QEMU with "-device intel-iommu,cache-mode=true". * On page cache invalidation in intel

[Qemu-devel] [PATCH v5 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

From: "Aviv Ben-David" This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 5 +

Re: [Qemu-devel] [PATCH v4 RESEND 0/3] IOMMU: intel_iommu support map and unmap notifications

On Mon, Oct 17, 2016 at 7:07 PM, Alex Williamson <alex.william...@redhat.com > wrote: > On Mon, 17 Oct 2016 18:44:21 +0300 > "Aviv B.D" <bd.a...@gmail.com> wrote: > > > From: "Aviv Ben-David" <bd.a...@gmail.com> > >

Re: [Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

On Wed, Oct 19, 2016 at 12:33 PM, Peter Xu <pet...@redhat.com> wrote: > On Mon, Oct 17, 2016 at 06:44:24PM +0300, Aviv B.D wrote: > > From: "Aviv Ben-David" <bd.a...@gmail.com> > > > > Adds a list of registered vtd_as's to intel iommu state to save >

Re: [Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

I will fix all those issues. Thanks, Aviv. On Thu, Oct 20, 2016 at 10:11 PM, Aviv B.D. <bd.a...@gmail.com> wrote: > > > On Wed, Oct 19, 2016 at 12:33 PM, Peter Xu <pet...@redhat.com> wrote: > >> On Mon, Oct 17, 2016 at 06:44:24PM +0300, Aviv B.D wrote: >

Re: [Qemu-devel] [PATCH v4 RESEND 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

Hi, You are right, and I will revert those functions you mentioned. Thanks, Aviv. On Wed, Oct 19, 2016 at 11:35 AM, Peter Xu <pet...@redhat.com> wrote: > On Mon, Oct 17, 2016 at 06:44:23PM +0300, Aviv B.D wrote: > > [...] > > > @@ -364,7 +364,7 @@ static void vtd

[Qemu-devel] [PATCH v4 RESEND 0/3] IOMMU: intel_iommu support map and unmap notifications

From: "Aviv Ben-David" * Advertize Cache Mode capability in iommu cap register. This capability is controlled by "cache-mode" property of intel-iommu device. To enable this option call QEMU with "-device intel-iommu,cache-mode=true". * On page cache invalidation in intel

[Qemu-devel] [PATCH v4 RESEND 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

From: "Aviv Ben-David" Supports translation trials without reporting error to guest on translation failure. Signed-off-by: Aviv Ben-David --- exec.c| 3 ++- hw/i386/amd_iommu.c | 4 +-- hw/i386/intel_iommu.c | 70

[Qemu-devel] [PATCH v4 RESEND 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

From: "Aviv Ben-David" This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 5 +

[Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

From: "Aviv Ben-David" Adds a list of registered vtd_as's to intel iommu state to save iteration over each PCI device in a search of the corrosponding domain. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 102

[Qemu-devel] [PATCH v4 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

From: "Aviv Ben-David" Supports translation trials without reporting error to guest on translation failure. Signed-off-by: Aviv Ben-David --- exec.c| 2 +- hw/i386/amd_iommu.c | 4 ++-- hw/i386/intel_iommu.c | 65

[Qemu-devel] [PATCH v4 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

From: "Aviv Ben-David" This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. This capability only enabled when cache-mode property of the device is true. Signed-off-by: Aviv

[Qemu-devel] [PATCH v4 0/3] IOMMU: intel_iommu support map and unmap notifications

From: "Aviv Ben-David" * Advertize Cache Mode capability in iommu cap register. This capability is controlled by "cache-mode" property of intel-iommu device. To enable this option call QEMU with "-device intel-iommu,cache-mode=true". * On page cache invalidation in intel

[Qemu-devel] [PATCH v4 3/3] IOMMU: enable intel_iommu map and unmap notifiers

From: "Aviv Ben-David" * register notifiers when vtd_iommu_notify_flag_changed is called. * Notify on IOTLB page invalidation about unmap and map operations. Adds a list of registered vtd_as's to intel iommu state to save iterations over each PCI device in a search of the

Re: [Qemu-devel] [PATCH v3 3/3] IOMMU: Integrate between VFIO and vIOMMU to support device assignment

iam...@redhat.com> wrote: > On Sat, 28 May 2016 18:14:18 +0000 > "Aviv B.D." <bd.a...@gmail.com> wrote: > > > Hi, > > As far as I tested the disabled code (call to memory_region_iommu_replay) > > hangup > > QEMU on startup if IOMMU is enabled (scaning 64 bit

Re: [Qemu-devel] [PATCH v3 3/3] IOMMU: Integrate between VFIO and vIOMMU to support device assignment

com> wrote: > On Sat, 28 May 2016 16:10:55 +0000 > "Aviv B.D." <bd.a...@gmail.com> wrote: > > > On Sat, May 28, 2016 at 7:02 PM Alex Williamson < > alex.william...@redhat.com> > > wrote: > > > > > On Sat, 28 May 2016 10:52:58

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

What is the best way to add this configuration option? Aviv. On Tue, May 24, 2016 at 12:25 PM Jan Kiszka <jan.kis...@siemens.com> wrote: > On 2016-05-24 10:14, Jason Wang wrote: > > On 2016年05月22日 00:19, Aviv B.D wrote: > >> From: "Aviv Ben-David" <bd.a...

Re: [Qemu-devel] [PATCH v3 3/3] IOMMU: Integrate between VFIO and vIOMMU to support device assignment

On Sat, May 28, 2016 at 7:02 PM Alex Williamson <alex.william...@redhat.com> wrote: > On Sat, 28 May 2016 10:52:58 +0000 > "Aviv B.D." <bd.a...@gmail.com> wrote: > > > Hi, > > Your idea to search the relevent VTDAddressSpace and call it's notifier >

Re: [Qemu-devel] [PATCH v3 3/3] IOMMU: Integrate between VFIO and vIOMMU to support device assignment

00 > Alex Williamson <alex.william...@redhat.com> wrote: > > > On Sat, 21 May 2016 19:19:50 +0300 > > "Aviv B.D" <bd.a...@gmail.com> wrote: > > > > > From: "Aviv Ben-David" <bd.a...@gmail.com> > > > > > > > Some co

[Qemu-devel] [PATCH v3 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

From: "Aviv Ben-David" Supports translation trials without reporting error to guest on translation failures. Signed-off-by: Aviv Ben-David --- exec.c| 2 +- hw/i386/intel_iommu.c | 65 ---

[Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

From: "Aviv Ben-David" This flag tells the guest to invalidate tlb cache also after unmap operations. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 3 ++- hw/i386/intel_iommu_internal.h | 1 + 2 files changed, 3 insertions(+), 1

[Qemu-devel] [PATCH v3 3/3] IOMMU: Integrate between VFIO and vIOMMU to support device assignment

From: "Aviv Ben-David" Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 69 -- hw/i386/intel_iommu_internal.h | 2 ++ hw/vfio/common.c | 11 +-- include/hw/i386/intel_iommu.h |

[Qemu-devel] [PATCH v3 0/3] IOMMU: Add Support to VFIO devices with vIOMMU present

From: "Aviv Ben-David" * Advertize Cache Mode capability in iommu cap register. * Register every VFIO device with IOMMU state. * On page cache invalidation in vIOMMU, check if the domain belong to VFIO device and mirror the guest requests to host. Changes from v1 to v2: *

Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

See my comments below, Thanks, Aviv. On Mon, Apr 11, 2016 at 11:25 PM, Alex Williamson <alex.william...@redhat.com> wrote: > > Some more detailed comments now that I have some faith that the host > IOMMU domain is working correctly... > > On Sat, 9 Apr 2016 21:03:38 +030

Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

see comments below. Thanks for your inputs, Aviv On Mon, Apr 11, 2016 at 6:40 AM, Peter Xu <pet...@redhat.com> wrote: > Hi, Aviv, > > On Sat, Apr 09, 2016 at 09:03:38PM +0300, Aviv B.D. wrote: > > [...] > >> +static int vtd_get_did_dev(IntelIOMMUState *s, uin

[Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

From: "Aviv Ben-David" Date: Tue, 23 Feb 2016 00:24:54 +0200 Subject: [PATCH] IOMMU: Add Support to VFIO devices with vIOMMU present * Fix bug that prevent qemu from starting up with vIOMMU and VFIO device are present. * Advertize Cache Mode capability in iommu cap register.

Re: [Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

On Wed, Mar 23, 2016 at 5:33 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Sat, Mar 12, 2016 at 06:13:17PM +0200, Aviv B.D. wrote: > > From: "Aviv B.D." <bd.a...@gmail.com> > > > > * Fix bug that prevent qemu from starting up when

Re: [Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

On Mon, Mar 21, 2016 at 4:30 AM, Peter Xu <pet...@redhat.com> wrote: > On Sat, Mar 19, 2016 at 11:40:04AM +0200, Aviv B.D. wrote: > [...] > > As far as I understand the code, currently there is no way to turn off > the > > IOTLB. > > Furthermore. the IOTLB is not

Re: [Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

On Fri, Mar 18, 2016 at 5:06 AM, Peter Xu <pet...@redhat.com> wrote: > On Thu, Mar 17, 2016 at 01:17:30PM +0200, Aviv B.D. wrote: > [...] > > vtd_get_did_dev returns -1 if the device is not mapped to any domain > > (generally, the CE is not present). > > probably a

Re: [Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

On Tue, Mar 15, 2016 at 10:52 AM, Peter Xu <pet...@redhat.com> wrote: > On Mon, Mar 14, 2016 at 08:52:33PM +0200, Marcel Apfelbaum wrote: > > On 03/12/2016 06:13 PM, Aviv B.D. wrote: > > Adding (possibly) interested developers to the thread. > > Thanks CC. > > H

Re: [Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

On Tue, Mar 15, 2016 at 12:53 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Sat, Mar 12, 2016 at 06:13:17PM +0200, Aviv B.D. wrote: > > From: "Aviv B.D." <bd.a...@gmail.com> > > > > * Fix bug that prevent qemu from starting up when

[Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

From: "Aviv B.D." <bd.a...@gmail.com> * Fix bug that prevent qemu from starting up when vIOMMU and VFIO device are present. * Advertise Cache Mode capability in iommu cap register. * Register every VFIO device with IOMMU state. * On page cache invalidation in vIOMMU, che