Re: [Qemu-devel] [QEMU-PPC] [PATCH V3 04/10] target/ppc/POWER9: Direct all instr and data storage interrupts to the hypv

2017-02-20 Thread Balbir Singh
ive, thus > it is no longer necessary to check the vmp0 bit in the LPCR. > > Signed-off-by: Suraj Jitindar Singh <sjitindarsi...@gmail.com> > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> > --- Acked-by: Balbir Singh <bsinghar...@gmail.com>

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 02/10] target/ppc: Fix LPCR DPFD mask define

2017-02-19 Thread Balbir Singh
sjitindarsi...@gmail.com> > --- Acked-by: Balbir Singh <bsinghar...@gmail.com>

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 01/10] target/ppc/POWER9: Add ISAv3.00 MMU definition

2017-02-19 Thread Balbir Singh
+/* Architecture 3.00 variant */ > +POWERPC_MMU_3_00 = POWERPC_MMU_64 | POWERPC_MMU_1TSEG > + | POWERPC_MMU_64K > + | POWERPC_MMU_AMR | 0x00000005, I wonder if we need a POWERPC_MMU_RADIX that we can then attach with future versions Balbir Singh.

[Qemu-devel] [PATCH v2] FU exceptions should carry a cause (IC)

2016-11-09 Thread Balbir Singh
As per the ISA we need a cause and executing a tabort r9 in libc for example causes a EXCP_FU exception, we don't wire up the IC (cause) when we post the exception. The cause is required for the kernel to do the right thing. The fix applies only to 64 bit ppc targets. Signed-off-by: Balbir

Re: [Qemu-devel] [TRIVIAL][RFC][PATCH] FU exceptions should carry a cause (IC)

2016-11-09 Thread Balbir Singh
On 10/11/16 13:46, David Gibson wrote: > On Thu, Nov 10, 2016 at 01:06:17PM +1100, David Gibson wrote: >> On Thu, Nov 10, 2016 at 12:42:37PM +1100, Balbir Singh wrote: >>> >>> >>> As per the ISA we need a cause for FU exceptions.Executing a tabort r9 >&

[Qemu-devel] [TRIVIAL][RFC][PATCH] FU exceptions should carry a cause (IC)

2016-11-09 Thread Balbir Singh
against Cedrics' latest pnv ipmi branch. Signed-off-by: Balbir singh <bsinghar...@gmail.com> --- target-ppc/excp_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c index 808760b..cccea8d 100644 --- a/target-ppc/excp_helper.c +++ b/

Re: [Qemu-devel] [PATCH v2 1/1] KVM: PPC: Introduce KVM_CAP_PPC_HTM

2016-07-19 Thread Balbir Singh
uest's device tree. > > Signed-off-by: Sam Bobroff <sam.bobr...@au1.ibm.com> > --- > Make sense Acked-by: Balbir Singh <bsinghar...@gmail.com>

Re: [Qemu-devel] [PATCH 1/1] KVM: PPC: Introduce KVM_CAP_PPC_HTM

2016-07-06 Thread Balbir Singh
n the > guest's device tree. >  > Signed-off-by: Sam Bobroff <sam.bobr...@au1.ibm.com> > --- Makes sense Acked-by: Balbir Singh <bsinghar...@gmail.com> >  

[Qemu-devel] Re: [RFC][PATCH 1/3] Linux/Guest unmapped page cache control

2010-11-03 Thread Balbir Singh
* Christoph Lameter c...@linux.com [2010-11-03 09:35:33]: On Fri, 29 Oct 2010, Balbir Singh wrote: A lot of the code is borrowed from zone_reclaim_mode logic for __zone_reclaim(). One might argue that the with ballooning and KSM this feature is not very useful, but even with ballooning

[Qemu-devel] [RFC][PATCH 0/3] KVM page cache optimization (v3)

2010-10-28 Thread Balbir Singh
This is version 3 of the page cache control patches From: Balbir Singh bal...@linux.vnet.ibm.com This series has three patches, the first controls the amount of unmapped page cache usage via a boot parameter and sysctl. The second patch controls page and slab cache via the balloon driver. Both

[Qemu-devel] [RFC][PATCH 3/3] QEmu changes to provide balloon hint

2010-10-28 Thread Balbir Singh
Provide memory hint during ballooning From: Balbir Singh bal...@linux.vnet.ibm.com This patch adds an optional hint to the qemu monitor balloon command. The hint tells the guest operating system to consider a class of memory during reclaim. Currently the supported hint is cached memory

[Qemu-devel] [RFC][PATCH 2/3] Linux/Guest cooperative unmapped page cache control

2010-10-28 Thread Balbir Singh
Balloon unmapped page cache pages first From: Balbir Singh bal...@linux.vnet.ibm.com This patch builds on the ballooning infrastructure by ballooning unmapped page cache pages first. It looks for low hanging fruit first and tries to reclaim clean unmapped pages first. This patch brings

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-22 Thread Balbir Singh
gautham.she...@gmail.com Signed-off-by: Sripathi Kodi sripat...@in.ibm.com Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com Acked-by: Balbir Singh bal...@linux.vnet.ibm.com -- Three Cheers, Balbir

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-20 Thread Balbir Singh
* Venkateswararao Jujjuri (JV) jv...@linux.vnet.ibm.com [2010-10-19 20:46:35]: I think this is a lot more fragile. You're relying on the fact that signal will not cause the signalled thread to actually awaken until we release the lock and doing work after signalling that the signalled

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-19 Thread Balbir Singh
* Arun R B a...@linux.vnet.ibm.com [2010-10-19 23:12:45]: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The core idea has been borrowed from the threading framework that is being used by

Re: [Qemu-devel] Re: [PATCH 1/3] Introduce threadlets

2010-10-19 Thread Balbir Singh
* Paolo Bonzini pbonz...@redhat.com [2010-10-19 21:01:03]: On 10/19/2010 08:36 PM, Balbir Singh wrote: Ideally you need s = pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, NULL); But qemu will need to wrap this around as well. Why? QEMU is never using thread cancellation

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-19 Thread Balbir Singh
* Anthony Liguori anth...@codemonkey.ws [2010-10-19 16:36:31]: On 10/19/2010 01:36 PM, Balbir Singh wrote: +qemu_mutex_lock((queue-lock)); +while (1) { +ThreadletWork *work; +int ret = 0; + +while (QTAILQ_EMPTY((queue-request_list)) + (ret

Re: [Qemu-devel] [PATCH 2/3] Make paio subsystem use threadlets

2010-10-19 Thread Balbir Singh
. Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Sripathi Kodi sripat...@in.ibm.com This change seems reasonable to me Acked-by: Balbir Singh bal...@linux.vnet.ibm.com -- Three Cheers, Balbir

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-19 Thread Balbir Singh
* Venkateswararao Jujjuri (JV) jv...@linux.vnet.ibm.com [2010-10-19 14:00:24]: In the case that we just spawned the threadlet, the cond_signal is spurious. If we need predictable scheduling behaviour, qemu_cond_signal needs to happen with queue-lock held. I'd rewrite the function as