Re: Qemu for TC377

2024-04-21 Thread Bastian Koppelmann
Hi Sameer, On Tue, Apr 16, 2024 at 02:26:10PM -0400, Sameer Kalliadan Poyil wrote: > Hi Bastian, > > Thanks for the information. I thought that I can do some prototyping before > the > HW arrives. :) > >  Yes I am interested for your bare metal program boot_to_main run it on TSIM.  >   > Is

Re: Qemu for TC377

2024-04-15 Thread Bastian Koppelmann
Hi Sameer, On Sun, Apr 14, 2024 at 06:15:56PM +0200, Philippe Mathieu-Daudé wrote: > Hi Sameer, > > On 13/4/24 14:52, Sameer Kalliadan Poyil wrote: > > Hello All, > > I see that Latest qemu supports for tricore TC277 and TC377 > > image.png > > But when I downloaded source code and checked for

Re: [PATCH-for-9.1 25/27] target/tricore: Convert to TCGCPUOps::get_cpu_state()

2024-03-24 Thread Bastian Koppelmann
2 files changed, 13 insertions(+), 12 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian

Re: [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill()

2024-03-24 Thread Bastian Koppelmann
y: Philippe Mathieu-Daudé > --- > target/tricore/helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian

Re: [PATCH 04/21] hw/tricore/testboard: Use qdev_new() instead of QOM basic API

2024-02-19 Thread Bastian Koppelmann
| 4 +--- > 2 files changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian

Re: [PATCH 30/33] target/tricore: Populate CPUClass.mmu_index

2024-02-02 Thread Bastian Koppelmann
On Tue, Jan 30, 2024 at 09:30:40AM +1000, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/tricore/cpu.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Bastian Koppelmann Cheers, Bastian

Re: [PATCH v2 21/23] target/tricore: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-28 Thread Bastian Koppelmann
e/cpu.c | 20 > target/tricore/gdbstub.c | 6 ++ > target/tricore/helper.c| 3 +-- > target/tricore/translate.c | 3 +-- > 4 files changed, 8 insertions(+), 24 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian

Re: [PATCH 6/7] target/tricore: Use tcg_gen_*extract_tl

2023-10-20 Thread Bastian Koppelmann
On Thu, Oct 19, 2023 at 11:29:20AM -0700, Richard Henderson wrote: > The EXTR instructions can use the extract opcodes. > > Signed-off-by: Richard Henderson > --- > target/tricore/translate.c | 20 > 1 file changed, 4 insertions(+), 16 deletions(-) Re

[PATCH 5/6] target/tricore: Add open and creat semihosting calls

2023-10-15 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target/tricore/tricore-semi.c | 101 ++ 1 file changed, 101 insertions(+) diff --git a/target/tricore/tricore-semi.c b/target/tricore/tricore-semi.c index 2188ceeed0..34e546c3bf 100644 --- a/target/tricore/tricore-semi.c

[PATCH 2/6] target/tricore: Add read and write semihosting calls

2023-10-15 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target/tricore/tricore-semi.c | 52 +++ 1 file changed, 52 insertions(+) diff --git a/target/tricore/tricore-semi.c b/target/tricore/tricore-semi.c index 27e1bdc59d..ccbeae4bc0 100644 --- a/target/tricore/tricore-semi.c +++ b

[PATCH 3/6] target/tricore: Add lseek semihosting call

2023-10-15 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target/tricore/tricore-semi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target/tricore/tricore-semi.c b/target/tricore/tricore-semi.c index ccbeae4bc0..6f321391ef 100644 --- a/target/tricore/tricore-semi.c +++ b/target/tricore

[PATCH 0/6] TriCore Semihosting

2023-10-15 Thread Bastian Koppelmann
] https://github.com/bkoppelmann/package_940/tree/main/newlib/libgloss/tricore Bastian Koppelmann (6): target/tricore: Add semihosting stub target/tricore: Add read and write semihosting calls target/tricore: Add lseek semihosting call target/tricore: Add close semihosting call target

[PATCH 4/6] target/tricore: Add close semihosting call

2023-10-15 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target/tricore/tricore-semi.c | 16 1 file changed, 16 insertions(+) diff --git a/target/tricore/tricore-semi.c b/target/tricore/tricore-semi.c index 6f321391ef..2188ceeed0 100644 --- a/target/tricore/tricore-semi.c +++ b/target/tricore

[PATCH 6/6] target/tricore: Enable semihosting

2023-10-15 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- configs/devices/tricore-softmmu/default.mak | 1 + docs/about/emulation.rst| 3 +++ qemu-options.hx | 3 ++- target/tricore/translate.c | 13 +++-- 4 files changed, 17 insertions

[PATCH 1/6] target/tricore: Add semihosting stub

2023-10-15 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target/tricore/helper.h | 1 + target/tricore/meson.build| 1 + target/tricore/tricore-semi.c | 197 ++ 3 files changed, 199 insertions(+) create mode 100644 target/tricore/tricore-semi.c diff --git a/target

Re: [RFC PATCH v3 34/78] target/tricore: add fallthrough pseudo-keyword

2023-10-13 Thread Bastian Koppelmann
On Fri, Oct 13, 2023 at 11:46:02AM +0300, Emmanouil Pitsidianakis wrote: > In preparation of raising -Wimplicit-fallthrough to 5, replace all > fall-through comments with the fallthrough attribute pseudo-keyword. > > Signed-off-by: Emmanouil Pitsidianakis > --- Reviewed-by: Bas

[PULL v3 07/16] target/tricore: Implement hptof insn

2023-09-29 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1667 Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-8-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 36 +++ target/tricore/he

[PULL v3 05/16] target/tricore: Clarify special case for FTOUZ insn

2023-09-29 Thread Bastian Koppelmann
this is not something other ISAs do, so clarify it with a comment. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-6-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 5 + 1 file changed, 5 insertions(+) diff

[PULL v3 12/16] tests/tcg/tricore: Extended and non-extened regs now match

2023-09-29 Thread Bastian Koppelmann
RSx for d regs and e regs now use the same numbering. This makes sure that mixing d and e registers in an insn test will not overwrite data between registers. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-2-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/ma

[PULL v3 15/16] target/tricore: Remove CSFRs from cpu.h

2023-09-29 Thread Bastian Koppelmann
these are already defined in 'csfr.h.inc'. We don't need to duplicate these registers. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-10-kbast...@mail.uni-paderborn.de> --- target/tricore/cpu.h | 143 +++ 1 file changed, 9 inse

[PULL v3 04/16] target/tricore: Implement FTOU insn

2023-09-29 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-5-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 32 +++ target/tricore/helper.h | 1 + target/tricore/trans

[PULL v3 16/16] target/tricore: Change effective address (ea) to target_ulong

2023-09-29 Thread Bastian Koppelmann
as this is an effective address and those cannot be signed, it should not be a signed integer. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-11-kbast...@mail.uni-paderborn.de> --- target/tricore/op_helper.c | 16 1 file changed, 8 insertions

[PULL v3 09/16] target/tricore: Swap src and dst reg for RCRR_INSERT

2023-09-29 Thread Bastian Koppelmann
Acked-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-10-kbast...@mail.uni-paderborn.de> --- target/tricore/translate.c | 8 tests/tcg/tricore/asm/macros.h | 9 + tests/tcg/tricore/asm/test_insert.S | 5 + 3

[PULL v3 02/16] target/tricore: Implement CRCN insn

2023-09-29 Thread Bastian Koppelmann
reported in https://gitlab.com/qemu-project/qemu/-/issues/1667 Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-3-kbast...@mail.uni-paderborn.de> --- target/tricore/helper.h | 1 + target/tricore/op_he

[PULL v3 03/16] target/tricore: Correctly handle FPU RM from PSW

2023-09-29 Thread Bastian Koppelmann
riCore is not the one used by softfloat. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-4-kbast...@mail.uni-paderborn.de> --- target/tricore/helper.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/ta

[PULL v3 13/16] hw/tricore: Log failing test in testdevice

2023-09-29 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-3-kbast...@mail.uni-paderborn.de> --- hw/tricore/tricore_testdevice.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/tricore/tricore_testdevice.c b/hw/tricore/tricore_testdevice.c index a1563aa568..9028d970b0

[PULL v3 10/16] target/tricore: Replace cpu_*_code with translator_*

2023-09-29 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-11-kbast...@mail.uni-paderborn.de> --- target/tricore/translate.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/tricore/translate.c b/target/t

[PULL v3 11/16] target/tricore: Fix FTOUZ being ISA v1.3.1 up

2023-09-29 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-12-kbast...@mail.uni-paderborn.de> --- target/tricore/translate.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/tricore/translate.c b/target/tricore/trans

[PULL v3 06/16] target/tricore: Implement ftohp insn

2023-09-29 Thread Bastian Koppelmann
reported in https://gitlab.com/qemu-project/qemu/-/issues/1667 Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-7-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 38 +++ target/t

[PULL v3 14/16] tests/tcg: Reset result register after each test

2023-09-29 Thread Bastian Koppelmann
some insns use the result register implicitly as an input. Thus, we could end up with data from the previous insn spilling over. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-4-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 3 ++- 1 file chan

[PULL v3 00/16] tricore queue

2023-09-29 Thread Bastian Koppelmann
Changes from v2: - Replaced %ld with PRIu64 for patch 13 - Dropped patches 15 - 19, as they require an updated patch series Bastian Koppelmann (16): tests/tcg/tricore: Bump cpu to tc37x target

[PULL v3 01/16] tests/tcg/tricore: Bump cpu to tc37x

2023-09-29 Thread Bastian Koppelmann
we don't want to exclude ISA v1.6.2 insns from our tests. Acked-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-Id: <20230828112651.522058-2-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PULL v3 08/16] target/tricore: Fix RCPW/RRPW_INSERT insns for width = 0

2023-09-29 Thread Bastian Koppelmann
we would crash if width was 0 for these insns, as tcg_gen_deposit() is undefined for that case. For TriCore, width = 0 is a mov from the src reg to the dst reg, so we special case this here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann

Re: [PULL v2 00/21] tricore queue

2023-09-29 Thread Bastian Koppelmann
Hi, On Thu, Sep 28, 2023 at 10:26:18AM -0400, Stefan Hajnoczi wrote: > Please take a look at these CI test failures: > https://gitlab.com/qemu-project/qemu/-/jobs/5185201978 > https://gitlab.com/qemu-project/qemu/-/jobs/5185202098 I'll fix the build failure and drop the patches that fail the

[PULL v2 00/21] tricore queue

2023-09-28 Thread Bastian Koppelmann
Changes from v1: - Removed sas.py file that slipped in patch 15 Bastian Koppelmann (21): tests/tcg/tricore: Bump cpu to tc37x target/tricore: Implement CRCN

[PULL v2 05/21] target/tricore: Clarify special case for FTOUZ insn

2023-09-28 Thread Bastian Koppelmann
this is not something other ISAs do, so clarify it with a comment. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-6-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 5 + 1 file changed, 5 insertions(+) diff

[PULL v2 20/21] target/tricore: Remove CSFRs from cpu.h

2023-09-28 Thread Bastian Koppelmann
these are already defined in 'csfr.h.inc'. We don't need to duplicate these registers. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-10-kbast...@mail.uni-paderborn.de> --- target/tricore/cpu.h | 143 +++ 1 file changed, 9 inse

[PULL v2 12/21] tests/tcg/tricore: Extended and non-extened regs now match

2023-09-28 Thread Bastian Koppelmann
RSx for d regs and e regs now use the same numbering. This makes sure that mixing d and e registers in an insn test will not overwrite data between registers. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-2-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/ma

[PULL v2 14/21] tests/tcg: Reset result register after each test

2023-09-28 Thread Bastian Koppelmann
some insns use the result register implicitly as an input. Thus, we could end up with data from the previous insn spilling over. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-4-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 3 ++- 1 file chan

[PULL v2 18/21] tests/tcg/tricore: Add test from 'max' to 'shas'

2023-09-28 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-8-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 13 tests/tcg/tricore/asm/test_arith.S | 105 + 2 files changed, 118 insertions(+) diff --git a/tests/tcg/trico

[PULL v2 16/21] tests/tcg/tricore: Add test from 'and' to 'csub'

2023-09-28 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-6-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 11 +++ tests/tcg/tricore/asm/test_arith.S | 47 ++ 2 files changed, 58 insertions(+) diff --git a/tests/tcg/trico

[PULL v2 10/21] target/tricore: Replace cpu_*_code with translator_*

2023-09-28 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-11-kbast...@mail.uni-paderborn.de> --- target/tricore/translate.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/tricore/translate.c b/target/t

[PULL v2 07/21] target/tricore: Implement hptof insn

2023-09-28 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1667 Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-8-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 36 +++ target/tricore/he

[PULL v2 15/21] tests/tcg/tricore: Add test for all arith insns up to addx

2023-09-28 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-5-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 3 +- tests/tcg/tricore/asm/macros.h| 50 +++ tests/tcg/tricore/asm/test_arith.S

[PULL v2 04/21] target/tricore: Implement FTOU insn

2023-09-28 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-5-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 32 +++ target/tricore/helper.h | 1 + target/tricore/trans

[PULL v2 06/21] target/tricore: Implement ftohp insn

2023-09-28 Thread Bastian Koppelmann
reported in https://gitlab.com/qemu-project/qemu/-/issues/1667 Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-7-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 38 +++ target/t

[PULL v2 17/21] tests/tcg/tricore: Add test from 'dextr' to 'lt'

2023-09-28 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-7-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 51 ++-- tests/tcg/tricore/asm/test_arith.S | 53 ++ 2 files changed, 102 insertions(+), 2 del

[PULL v2 19/21] tests/tcg/tricore: Add test from 'shuffle' to 'xor.t'

2023-09-28 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-9-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/test_arith.S | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/tcg/tricore/asm/test_arith.S b/tests/tcg/trico

[PULL v2 02/21] target/tricore: Implement CRCN insn

2023-09-28 Thread Bastian Koppelmann
reported in https://gitlab.com/qemu-project/qemu/-/issues/1667 Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-3-kbast...@mail.uni-paderborn.de> --- target/tricore/helper.h | 1 + target/tricore/op_he

[PULL v2 21/21] target/tricore: Change effective address (ea) to target_ulong

2023-09-28 Thread Bastian Koppelmann
as this is an effective address and those cannot be signed, it should not be a signed integer. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-11-kbast...@mail.uni-paderborn.de> --- target/tricore/op_helper.c | 16 1 file changed, 8 insertions

[PULL v2 01/21] tests/tcg/tricore: Bump cpu to tc37x

2023-09-28 Thread Bastian Koppelmann
we don't want to exclude ISA v1.6.2 insns from our tests. Acked-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-Id: <20230828112651.522058-2-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PULL v2 11/21] target/tricore: Fix FTOUZ being ISA v1.3.1 up

2023-09-28 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-12-kbast...@mail.uni-paderborn.de> --- target/tricore/translate.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/tricore/translate.c b/target/tricore/trans

[PULL v2 13/21] hw/tricore: Log failing test in testdevice

2023-09-28 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-3-kbast...@mail.uni-paderborn.de> --- hw/tricore/tricore_testdevice.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/tricore/tricore_testdevice.c b/hw/tricore/tricore_testdevice.c index a1563aa568..d0f8db9089

[PULL v2 08/21] target/tricore: Fix RCPW/RRPW_INSERT insns for width = 0

2023-09-28 Thread Bastian Koppelmann
we would crash if width was 0 for these insns, as tcg_gen_deposit() is undefined for that case. For TriCore, width = 0 is a mov from the src reg to the dst reg, so we special case this here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann

[PULL v2 09/21] target/tricore: Swap src and dst reg for RCRR_INSERT

2023-09-28 Thread Bastian Koppelmann
Acked-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-10-kbast...@mail.uni-paderborn.de> --- target/tricore/translate.c | 8 tests/tcg/tricore/asm/macros.h | 9 + tests/tcg/tricore/asm/test_insert.S | 5 + 3

[PULL v2 03/21] target/tricore: Correctly handle FPU RM from PSW

2023-09-28 Thread Bastian Koppelmann
riCore is not the one used by softfloat. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-4-kbast...@mail.uni-paderborn.de> --- target/tricore/helper.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/ta

Re: [PULL 00/21] tricore queue

2023-09-27 Thread Bastian Koppelmann
On Wed, Sep 27, 2023 at 11:35:31AM +0200, Bastian Koppelmann wrote: > The following changes since commit 11a629d246e4e7785a6f0efb99bd15a32c04feda: > > Merge tag 'pull-nbd-2023-09-25' of https://repo.or.cz/qemu/ericb into > staging (2023-09-26 09:04:23 -0400) > > are av

[PULL 13/21] hw/tricore: Log failing test in testdevice

2023-09-27 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-3-kbast...@mail.uni-paderborn.de> --- hw/tricore/tricore_testdevice.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/tricore/tricore_testdevice.c b/hw/tricore/tricore_testdevice.c index a1563aa568..d0f8db9089

[PULL 10/21] target/tricore: Replace cpu_*_code with translator_*

2023-09-27 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-11-kbast...@mail.uni-paderborn.de> --- target/tricore/translate.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/tricore/translate.c b/target/t

[PULL 08/21] target/tricore: Fix RCPW/RRPW_INSERT insns for width = 0

2023-09-27 Thread Bastian Koppelmann
we would crash if width was 0 for these insns, as tcg_gen_deposit() is undefined for that case. For TriCore, width = 0 is a mov from the src reg to the dst reg, so we special case this here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann

[PULL 07/21] target/tricore: Implement hptof insn

2023-09-27 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1667 Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-8-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 36 +++ target/tricore/he

[PULL 12/21] tests/tcg/tricore: Extended and non-extened regs now match

2023-09-27 Thread Bastian Koppelmann
RSx for d regs and e regs now use the same numbering. This makes sure that mixing d and e registers in an insn test will not overwrite data between registers. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-2-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/ma

[PULL 14/21] tests/tcg: Reset result register after each test

2023-09-27 Thread Bastian Koppelmann
some insns use the result register implicitly as an input. Thus, we could end up with data from the previous insn spilling over. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-4-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 3 ++- 1 file chan

[PULL 05/21] target/tricore: Clarify special case for FTOUZ insn

2023-09-27 Thread Bastian Koppelmann
this is not something other ISAs do, so clarify it with a comment. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-6-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 5 + 1 file changed, 5 insertions(+) diff

[PULL 09/21] target/tricore: Swap src and dst reg for RCRR_INSERT

2023-09-27 Thread Bastian Koppelmann
Acked-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-10-kbast...@mail.uni-paderborn.de> --- target/tricore/translate.c | 8 tests/tcg/tricore/asm/macros.h | 9 + tests/tcg/tricore/asm/test_insert.S | 5 + 3

[PULL 02/21] target/tricore: Implement CRCN insn

2023-09-27 Thread Bastian Koppelmann
reported in https://gitlab.com/qemu-project/qemu/-/issues/1667 Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-3-kbast...@mail.uni-paderborn.de> --- target/tricore/helper.h | 1 + target/tricore/op_he

[PULL 03/21] target/tricore: Correctly handle FPU RM from PSW

2023-09-27 Thread Bastian Koppelmann
riCore is not the one used by softfloat. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-4-kbast...@mail.uni-paderborn.de> --- target/tricore/helper.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/ta

[PULL 04/21] target/tricore: Implement FTOU insn

2023-09-27 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-5-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 32 +++ target/tricore/helper.h | 1 + target/tricore/trans

[PULL 19/21] tests/tcg/tricore: Add test from 'shuffle' to 'xor.t'

2023-09-27 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-9-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/test_arith.S | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/tcg/tricore/asm/test_arith.S b/tests/tcg/trico

[PULL 15/21] tests/tcg/tricore: Add test for all arith insns up to addx

2023-09-27 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-5-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 3 +- tests/tcg/tricore/asm/macros.h| 50 +++ tests/tcg/tricore/asm/sas.py | 21 ++

[PULL 18/21] tests/tcg/tricore: Add test from 'max' to 'shas'

2023-09-27 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-8-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 13 tests/tcg/tricore/asm/test_arith.S | 105 + 2 files changed, 118 insertions(+) diff --git a/tests/tcg/trico

[PULL 06/21] target/tricore: Implement ftohp insn

2023-09-27 Thread Bastian Koppelmann
reported in https://gitlab.com/qemu-project/qemu/-/issues/1667 Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-7-kbast...@mail.uni-paderborn.de> --- target/tricore/fpu_helper.c | 38 +++ target/t

[PULL 17/21] tests/tcg/tricore: Add test from 'dextr' to 'lt'

2023-09-27 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-7-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 51 ++-- tests/tcg/tricore/asm/test_arith.S | 53 ++ 2 files changed, 102 insertions(+), 2 del

[PULL 00/21] tricore queue

2023-09-27 Thread Bastian Koppelmann
TriCore insns Bastian Koppelmann (21): tests/tcg/tricore: Bump cpu to tc37x target/tricore: Implement CRCN insn target/tricore: Correctly handle FPU RM from PSW target/tricore: Implement FTOU insn target

[PULL 11/21] target/tricore: Fix FTOUZ being ISA v1.3.1 up

2023-09-27 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-ID: <20230828112651.522058-12-kbast...@mail.uni-paderborn.de> --- target/tricore/translate.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/tricore/translate.c b/target/tricore/trans

[PULL 20/21] target/tricore: Remove CSFRs from cpu.h

2023-09-27 Thread Bastian Koppelmann
these are already defined in 'csfr.h.inc'. We don't need to duplicate these registers. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-10-kbast...@mail.uni-paderborn.de> --- target/tricore/cpu.h | 143 +++ 1 file changed, 9 inse

[PULL 16/21] tests/tcg/tricore: Add test from 'and' to 'csub'

2023-09-27 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-6-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/asm/macros.h | 11 +++ tests/tcg/tricore/asm/test_arith.S | 47 ++ 2 files changed, 58 insertions(+) diff --git a/tests/tcg/trico

[PULL 21/21] target/tricore: Change effective address (ea) to target_ulong

2023-09-27 Thread Bastian Koppelmann
as this is an effective address and those cannot be signed, it should not be a signed integer. Signed-off-by: Bastian Koppelmann Message-ID: <20230913105326.40832-11-kbast...@mail.uni-paderborn.de> --- target/tricore/op_helper.c | 16 1 file changed, 8 insertions

[PULL 01/21] tests/tcg/tricore: Bump cpu to tc37x

2023-09-27 Thread Bastian Koppelmann
we don't want to exclude ISA v1.6.2 insns from our tests. Acked-by: Richard Henderson Signed-off-by: Bastian Koppelmann Message-Id: <20230828112651.522058-2-kbast...@mail.uni-paderborn.de> --- tests/tcg/tricore/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 00/10] TriCore tests and cleanups

2023-09-13 Thread Bastian Koppelmann
). These are already defined in csfr.h.inc, so I use this definition. I also changed the types of the effective address (ea) in op_helper.c to target_ulong, as it cannot be sign extened. Cheers, Bastian Bastian Koppelmann (10): tests/tcg/tricore: Extended and non-extened regs now match hw/tricore: Log failing

[PATCH 10/10] target/tricore: Change effective address (ea) to target_ulong

2023-09-13 Thread Bastian Koppelmann
as this is an effective address and those cannot be signed, it should not be a signed integed. Signed-off-by: Bastian Koppelmann --- target/tricore/op_helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/tricore/op_helper.c b/target/tricore

[PATCH 07/10] tests/tcg/tricore: Add test from 'max' to 'shas'

2023-09-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/asm/macros.h | 13 tests/tcg/tricore/asm/test_arith.S | 105 + 2 files changed, 118 insertions(+) diff --git a/tests/tcg/tricore/asm/macros.h b/tests/tcg/tricore/asm/macros.h index 92f0f7b22b

[PATCH 01/10] tests/tcg/tricore: Extended and non-extened regs now match

2023-09-13 Thread Bastian Koppelmann
RSx for d regs and e regs now use the same numbering. This makes sure that mixing d and e registers in an insn test will not overwrite data between registers. Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/asm/macros.h | 38 +- 1 file changed, 19

[PATCH 04/10] tests/tcg/tricore: Add test for all arith insns up to addx

2023-09-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile.softmmu-target | 3 +- tests/tcg/tricore/asm/macros.h| 50 +++ tests/tcg/tricore/asm/test_arith.S| 41 +++ 3 files changed, 93 insertions(+), 1 deletion(-) create mode

[PATCH 03/10] tests/tcg: Reset result register after each test

2023-09-13 Thread Bastian Koppelmann
some insns use the result register implicitly as an input. Thus, we could end up with data from the previous insn spilling over. Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/asm/macros.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tcg/tricore/asm

[PATCH 05/10] tests/tcg/tricore: Add test for and to csub

2023-09-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/asm/macros.h | 11 +++ tests/tcg/tricore/asm/test_arith.S | 47 ++ 2 files changed, 58 insertions(+) diff --git a/tests/tcg/tricore/asm/macros.h b/tests/tcg/tricore/asm/macros.h index 8ed2249b0d

[PATCH 09/10] target/tricore: Remove CSFRs from cpu.h

2023-09-13 Thread Bastian Koppelmann
these are already defined in 'csfr.h.inc'. We don't need to duplicate these registers. Signed-off-by: Bastian Koppelmann --- target/tricore/cpu.h | 143 +++ 1 file changed, 9 insertions(+), 134 deletions(-) diff --git a/target/tricore/cpu.h b/target

[PATCH 08/10] tests/tcg/tricore: Add test from 'shuffle' to 'xor.t'

2023-09-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/asm/test_arith.S | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/tcg/tricore/asm/test_arith.S b/tests/tcg/tricore/asm/test_arith.S index 728509cfa9..02637f89f9 100644 --- a/tests/tcg/tricore/asm

[PATCH 02/10] hw/tricore: Log failing test in testdevice

2023-09-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- hw/tricore/tricore_testdevice.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/tricore/tricore_testdevice.c b/hw/tricore/tricore_testdevice.c index a1563aa568..d0f8db9089 100644 --- a/hw/tricore/tricore_testdevice.c +++ b/hw/tricore

[PATCH 06/10] tests/tcg/tricore: Add from dextr to lt

2023-09-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/asm/macros.h | 51 ++-- tests/tcg/tricore/asm/test_arith.S | 53 ++ 2 files changed, 102 insertions(+), 2 deletions(-) diff --git a/tests/tcg/tricore/asm/macros.h b/tests/tcg/tricore

Re: [PATCH v3 17/32] target/tricore: Use generic helper to show CPU model names

2023-09-06 Thread Bastian Koppelmann
lper.c | 13 + > 2 files changed, 10 insertions(+), 12 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian

Re: [PATCH v2 06/22] target/tricore: Clean up local variable shadowing

2023-09-04 Thread Bastian Koppelmann
tant_i32(const9); > | ^~~~ > target/tricore/translate.c:4958:10: note: shadowed declaration is here >4958 | TCGv temp; > | ^~~~ > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/tricore/translate.c | 6 +++--- > 1 file changed, 3 insertion

Re: [PATCH v2 00/48] tcg patch queue

2023-08-29 Thread Bastian Koppelmann
On Mon, Aug 28, 2023 at 06:52:42PM -0400, Stefan Hajnoczi wrote: > On Thu, 24 Aug 2023 at 14:29, Richard Henderson > wrote: > > > > The following changes since commit 50e7a40af372ee5931c99ef7390f5d3d6fbf6ec4: > > > > Merge tag 'pull-target-arm-20230824' of > >

[PATCH v2 05/11] target/tricore: Clarify special case for FTOUZ insn

2023-08-28 Thread Bastian Koppelmann
this is not something other ISAs do, so clarify it with a comment. Signed-off-by: Bastian Koppelmann --- target/tricore/fpu_helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/tricore/fpu_helper.c b/target/tricore/fpu_helper.c index 3aefeb776e..d0c474c5f3 100644

[PATCH v2 08/11] target/tricore: Fix RCPW/RRPW_INSERT insns for width = 0

2023-08-28 Thread Bastian Koppelmann
we would crash if width was 0 for these insns, as tcg_gen_deposit() is undefined for that case. For TriCore, width = 0 is a mov from the src reg to the dst reg, so we special case this here. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c

[PATCH v2 09/11] target/tricore: Swap src and dst reg for RCRR_INSERT

2023-08-28 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 8 tests/tcg/tricore/asm/macros.h | 9 + tests/tcg/tricore/asm/test_insert.S | 5 + 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/target/tricore/translate.c b/target/tricore

[PATCH v2 10/11] target/tricore: Replace cpu_*_code with translator_*

2023-08-28 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/tricore/translate.c b/target/tricore/translate.c index 403533c564..cc2030be14 100644 --- a/target/tricore/translate.c

[PATCH v2 07/11] target/tricore: Implement hptof insn

2023-08-28 Thread Bastian Koppelmann
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1667 Signed-off-by: Bastian Koppelmann --- v1 -> v2: - Removed special case for f_arg being infinity - Clarified, why we need a special case for arg being NAN target/tricore/fpu_helper.c |

[PATCH v2 06/11] target/tricore: Implement ftohp insn

2023-08-28 Thread Bastian Koppelmann
reported in https://gitlab.com/qemu-project/qemu/-/issues/1667 Signed-off-by: Bastian Koppelmann --- v1 -> v2: - Removed special case for f_arg being infinity - Clarified, why we need a special case for arg being NAN target/tricore/fpu_helper.c |

[PATCH v2 00/11] TriCore 1.6.2 insn and bugfixes

2023-08-28 Thread Bastian Koppelmann
e need a special case for arg being NAN (ftohp, hptof) Bastian Koppelmann (11): tests/tcg/tricore: Bump cpu to tc37x target/tricore: Implement CRCN insn target/tricore: Correctly handle FPU RM from PSW target/tricore: Implement FTOU insn target/tricore: Clarify special case for FTOUZ insn

  1   2   3   4   5   6   7   8   9   10   >