PING
On Mon, Aug 19, 2019 at 4:28 PM Bishara AbuHattoum
wrote:
> Network interface name is fetched as an encoded WCHAR array, (wide
> character), then it is decoded using the guest's CP_ACP Windows code
> page, which is the default code page as configure in the guest's
PING
On Mon, Aug 19, 2019 at 4:22 PM Bishara AbuHattoum
wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1733165
>
> Uppon renaming a NIC to a Chinese name and invoking the network get
> interfaces command, guest-network-get-interfaces, the returned name
> field has the
of using the CP_ACP code page for decoding which
is an interchangeable code page, instead CP_UTF8 code page should be
used for decoding the network interface's name.
https://bugzilla.redhat.com/show_bug.cgi?id=1733165
Signed-off-by: Bishara AbuHattoum
---
qga/commands-win32.c | 10 +-
1 file
that the code page does not have the
decoding information for the given character.
The suggested fix is to use the CP_UTF8 code page for decoding the NIC's
name instead of the CP_ACP code page.
Bishara AbuHattoum (1):
qga-win: network-get-interfaces command name field bug fix
qga/commands-win32.c
/true#M859
Signed-off-by: Bishara AbuHattoum
---
qga/commands-win32.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 62e1b51..3985b40 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
This patch of a one commit fixes a bug that has been reported in the bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=1659071
In which the command get-osinfo doesnt work as expected when the ga is running
on a Windows Server 2019 guest.
Bishara AbuHattoum (1):
qga-win: Adding support
for the
qemu-ga to restart.
Signed-off-by: Bishara AbuHattoum
Signed-off-by: Sameeh Jubran
---
qga/main.c | 86 -
qga/service-win32.h | 4 +++
2 files changed, 89 insertions(+), 1 deletion(-)
diff --git a/qga/main.c b/qga/main.c
index
From: Michael Roth
Useful in general, but especially now that errors might occur more
frequently with --retry-path set.
Signed-off-by: Michael Roth
---
qga/channel-win32.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qga/channel-win32.c b/qga/channel-win32.c
index
From: Michael Roth
This adds an option to instruct the agent to periodically attempt
re-opening the communication channel after a channel error has
occurred. The main use-case for this is providing an OS-independent
way of allowing the agent to survive situations like hotplug/unplug of
the
-by: Bishara AbuHattoum
---
qga/main.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 9f4dc0b2c5..23a0a46b84 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -136,6 +136,7 @@ DWORD WINAPI service_ctrl_handler(DWORD ctrl, DWORD
From: Michael Roth
It's nicer from a management perspective that the agent can survive
hotplug/unplug of the channel device, or be started prior to the
installation of the channel device's driver without and still be able
to resume normal function afterward. On linux there are alternatives
like
From: Michael Roth
This patch better separates the init/cleanup routines out into
separate functions to make the start-up procedure a bit easier to
follow. This will be useful when we eventually break out the actual
start/stop of the agent's main loop into separates routines that
can be called
From: Michael Roth
For w32 services we rely on the global GAState to access resources
associated with the agent within service_main(). Currently this is
sufficient for starting the agent since we open the channel once prior
to calling service_main(), and simply start the GMainLoop to start the
/2017-08/msg02401.html
Bishara AbuHattoum (1):
qga-win: changing --retry-path option behavior
Michael Roth (6):
qga: group agent init/cleanup init separate routines
qga: hang GAConfig/socket_activation off of GAState global
qga: move w32 service handling out of run_agent()
qga: add --retry
, 2018 at 11:37 AM Bishara AbuHattoum
> wrote:
> >
> > From: Michael Roth
> >
> > This patch better separates the init/cleanup routines out into
> > separate functions to make make the start-up procedure a bit easier
>
> "make make"
>
> > t
, 2018 at 11:39 AM Bishara AbuHattoum
> wrote:
> >
> > From: Michael Roth
> >
> > Eventually we want a w32 service to be able to restart the qga main
> > loop from within service_main(). To allow for this we move service
> > handling out of run_agent()
Your advice was taken and implemented, sending changes in the next version.
On Thu, Sep 27, 2018 at 2:48 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Thu, Sep 27, 2018 at 11:41 AM Bishara AbuHattoum
> wrote:
> >
> > Currently whenever the
From: Michael Roth
Useful in general, but especially now that errors might occur more
frequently with --retry-path set.
Signed-off-by: Michael Roth
Message-Id: <20171026233054.21133-7-mdr...@linux.vnet.ibm.com>
---
qga/channel-win32.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
From: Michael Roth
For w32 services we rely on the global GAState to access resources
associated with the agent within service_main(). Currently this is
sufficient for starting the agent since we open the channel once prior
to calling service_main(), and simply start the GMainLoop to start the
for the
qemu-ga to restart.
Signed-off-by: Bishara AbuHattoum
Signed-off-by: Sameeh Jubran
---
qga/main.c | 101 +++-
qga/service-win32.h | 4 ++
2 files changed, 104 insertions(+), 1 deletion(-)
diff --git a/qga/main.c b/qga/main.c
index
From: Michael Roth
It's nicer from a management perspective that the agent can survive
hotplug/unplug of the channel device, or be started prior to the
installation of the channel device's driver without and still be able
to resume normal function afterward. On linux there are alternatives
like
From: Michael Roth
Eventually we want a w32 service to be able to restart the qga main
loop from within service_main(). To allow for this we move service
handling out of run_agent() such that service_main() calls
run_agent() instead of the reverse.
Signed-off-by: Michael Roth
Message-Id:
From: Michael Roth
This adds an option to instruct the agent to periodically attempt
re-opening the communication channel after a channel error has
occurred. The main use-case for this is providing an OS-independent
way of allowing the agent to survive situations like hotplug/unplug of
the
-08/msg02401.html
Bishara AbuHattoum (1):
qga-win: changing --retry-path option behavior
Michael Roth (6):
qga: group agent init/cleanup init separate routines
qga: hang GAConfig/socket_activation off of GAState global
qga: move w32 service handling out of run_agent()
qga: add --retry
From: Michael Roth
This patch better separates the init/cleanup routines out into
separate functions to make make the start-up procedure a bit easier
to follow. This will be useful when we eventually break out the
actual start/stop of the agent's main loop into separates routines
that can be
al/v3/howtos/updates/major_upgrade.html
Signed-off-by: Bishara AbuHattoum
---
qga/installer/qemu-ga.wxs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 5af11627f8..f751a7e9f7 100644
--- a/qga/installer/qemu-ga.wxs
+++
At the moment, Windows libraries don't provide a way to access
RTC, so, a workaround is to use the Windows w32tm command to
resync the time.
Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1183874
Signed-off-by: Bishara AbuHattoum <bish...@daynix.com>
---
con
At the moment, Windows libraries don't provide a way to access
RTC, so, a workaround is to use the Windows w32tm command to
resync the time.
Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1183874
Signed-off-by: Bishara AbuHattoum <bish...@daynix.com>
---
con
28 matches
Mail list logo