or_setg_errno() in
vfio_devices_query_dirty_bitmap() and vfio_legacy_query_dirty_bitmap()
- ':' -> '-' in vfio_iommu_map_dirty_notify()
Cédric Le Goater (9):
vfio: Add Error** argument to .set_dirty_page_tracking() handler
vfio: Add Error** argument to vfio_devices_dma_logging_start()
migration: Extend migratio
Let the callers do the reporting. This will be useful in
vfio_iommu_map_dirty_notify().
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
Cc: David Hildenbrand
Reviewed-by: Peter Xu
Reviewed-by: Eric Auger
Reviewed-by: Avihai Horon
Signed-off-by: Cédric Le Goater
---
include/exec/memory.h | 15
We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO. Add documentation while at it.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Avihai Horon
Reviewed-by: Eric Auger
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-container-base.h | 18
and reported.
The vfio_set_migration_error() call becomes redundant in
vfio_listener_log_global_start(). Remove it.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Avihai Horon
Reviewed-by: Eric Auger
Signed-off-by: Cédric Le Goater
---
Changes in v7:
- Commit log improvements (Eric)
hw
Let the callers do the error reporting. Add documentation while at it.
Reviewed-by: Eric Auger
Reviewed-by: Avihai Horon
Signed-off-by: Cédric Le Goater
---
Changes in v7:
- Fixed even more line wrapping of *dirty_bitmap() routines (Avihai)
- vfio_sync_dirty_bitmap()
Fixed return when
under the migration stream if a migration is in
progress.
Reviewed-by: Avihai Horon
Signed-off-by: Cédric Le Goater
---
Changes in v7:
- vfio_migration_set_state() :
Introduced an error prefix to remove redundancy in error messages (Eric)
Commented error_report when setting the device
It will simplify the changes coming after.
Reviewed-by: Avihai Horon
Reviewed-by: Eric Auger
Signed-off-by: Cédric Le Goater
---
hw/vfio/common.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index
Use vmstate_save_state_with_err() to improve error reporting in the
callers and store a reported error under the migration stream. Add
documentation while at it.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Eric Auger
Reviewed-by: Avihai Horon
Signed-off-by: Cédric Le Goater
---
include
On 5/16/24 10:42, Avihai Horon wrote:
On 14/05/2024 18:31, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Let the callers do the error reporting. Add documentation while at it.
Signed-off-by: Cédric Le Goater
---
Changes in v6:
- Fixed the line
On 5/16/24 10:18, Avihai Horon wrote:
On 14/05/2024 18:31, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Add an Error** argument to vfio_migration_set_state() and adjust
callers, including vfio_save_setup(). The error will be propagated up
On 5/15/24 09:20, Eric Auger wrote:
Hi Cédric,
On 5/14/24 17:31, Cédric Le Goater wrote:
Add an Error** argument to vfio_migration_set_state() and adjust
callers, including vfio_save_setup(). The error will be propagated up
to qemu_savevm_state_setup() where the save_setup() handler
On 5/15/24 09:04, Eric Auger wrote:
Hi Cédric,
On 5/14/24 17:31, Cédric Le Goater wrote:
Use it to update the current error of the migration stream if
available and if not, simply print out the error. Next changes will
update with an error to report.
Reviewed-by: Avihai Horon
Acked
On 5/15/24 08:53, Eric Auger wrote:
Hi Cédric,
On 5/14/24 17:31, Cédric Le Goater wrote:
This allows to update the Error argument of the VFIO log_global_start()
handler. Errors for container based logging will also be propagated to
qemu_savevm_state_setup() when the ram save_setup() handler
On 5/15/24 08:40, Eric Auger wrote:
Hi Cédric,
On 5/14/24 17:31, Cédric Le Goater wrote:
We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO. Add documentation while at it.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Avihai Horon
Signed-off
On 5/7/24 09:34, Duan, Zhenzhong wrote:
-Original Message-
From: Cédric Le Goater
Subject: Re: [PATCH v2 03/11] vfio: Make VFIOIOMMUClass::attach_device()
and its wrapper return bool
On 5/7/24 08:42, Zhenzhong Duan wrote:
Make VFIOIOMMUClass::attach_device() and its wrapper
vents", is added so events
can be enabled only for the required devices. It is disabled by default.
Signed-off-by: Avihai Horon
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
include/hw/vfio/vfio-common.h | 1 +
hw/vfio/migration.c | 59 +--
vfio_migration_set_state() fails (covering recover
state and device reset transitions) and in no-op state transitions to
the same state.
Suggested-by: Cédric Le Goater
Signed-off-by: Avihai Horon
Thanks for doing so,
Reviewed-by: Cédric Le Goater
C.
---
hw/vfio/migration.c | 8 ++--
hw/vfio
On 5/15/24 14:38, Richard Henderson wrote:
On 5/14/24 15:17, marcandre.lur...@redhat.com wrote:
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -70,6 +70,7 @@ void gd_egl_draw(VirtualConsole *vc)
QemuDmaBuf *dmabuf = vc->gfx.guest_fb.dmabuf;
#endif
int ww, wh, ws;
+ int fence_fd;
On 5/15/24 14:29, Avihai Horon wrote:
On 15/05/2024 15:25, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/15/24 14:17, Avihai Horon wrote:
On 13/05/2024 19:27, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/13
On 5/15/24 14:17, Avihai Horon wrote:
On 13/05/2024 19:27, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/13/24 15:03, Avihai Horon wrote:
Hi Cedric,
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links
")
Cc: Dongwon Kim
Cc: Marc-André Lureau
Signed-off-by: Cédric Le Goater
---
ui/gtk-egl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index
0473f689c915f8b2303cd9d11bc7d8336c2a85ba..9831c10e1bd58f76d8f803ad0a72d983adc3f490
100644
--- a/ui
On 5/7/24 08:42, Zhenzhong Duan wrote:
This is to follow the coding standand to return bool if 'Error **'
is used to pass error.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
include/hw/vfio/vfio-common.h | 2 +-
hw/vfio
., log through either error interface or trace, not
both.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
include/sysemu/iommufd.h | 6 +++---
backends/iommufd.c | 29 +
hw/vfio/iommufd.c
iommufd_cdev_attach_container
iommufd_cdev_get_info_iova_range
After the change, all functions in hw/vfio/iommufd.c follows the
standand.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/vfio/iommufd.c | 88
On 5/7/24 08:42, Zhenzhong Duan wrote:
This is to follow the coding standand to return bool if 'Error **'
is used to pass error.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/vfio/container.c | 16
On 5/7/24 08:42, Zhenzhong Duan wrote:
This is to follow the coding standand to return bool if 'Error **'
is used to pass error.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/vfio/container.c | 18 +++---
1
On 5/7/24 08:42, Zhenzhong Duan wrote:
This is to follow the coding standand to return bool if 'Error **'
is used to pass error.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/vfio/container.c | 22
On 5/7/24 08:42, Zhenzhong Duan wrote:
Local pointer info is freed before return from
iommufd_cdev_get_info_iova_range().
Use 'g_autofree' to avoid the g_free() calls.
Signed-off-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/vfio/iommufd.c | 4 +---
1 file
On 5/7/24 08:42, Zhenzhong Duan wrote:
Local pointer name is allocated before vfio_attach_device() call
and freed after the call.
Same for tmp when calling realpath().
Use 'g_autofree' to avoid the g_free() calls.
Signed-off-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C
Let the callers do the reporting. This will be useful in
vfio_iommu_map_dirty_notify().
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
Cc: David Hildenbrand
Reviewed-by: Peter Xu
Signed-off-by: Cédric Le Goater
---
Changes in v6:
- Fixed memory_get_xlat_addr documentation (Avihai)
include
rty_bitmap()
- ':' -> '-' in vfio_iommu_map_dirty_notify()
Cédric Le Goater (9):
vfio: Add Error** argument to .set_dirty_page_tracking() handler
vfio: Add Error** argument to vfio_devices_dma_logging_start()
migration: Extend migration_file_set_error() with Error* argument
vfio/m
vfio_save_complete_precopy() currently returns before doing the trace
event. Change that.
Reviewed-by: Avihai Horon
Signed-off-by: Cédric Le Goater
---
hw/vfio/migration.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index
under the migration stream if a migration is in
progress.
Signed-off-by: Cédric Le Goater
---
Changes in v6:
- Commit log improvements (Avihai)
- vfio_migration_set_state() : Dropped the error_setg_errno() change
when setting device in recover state fails (Avihai
in
vfio_listener_log_global_start(). Remove it.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Avihai Horon
Signed-off-by: Cédric Le Goater
---
Changes in v6:
- Commit log improvements (Avihai)
Changes in v5:
- Used error_setg_errno() in vfio_devices_dma_logging_start()
hw/vfio/common.c | 26
Let the callers do the error reporting. Add documentation while at it.
Signed-off-by: Cédric Le Goater
---
Changes in v6:
- Fixed the line wrapping (Avihai)
- Fixed query_dirty_bitmap documentation (Avihai)
Changes in v5:
- Replaced error_setg() by error_setg_errno
It will simplify the changes coming after.
Reviewed-by: Avihai Horon
Signed-off-by: Cédric Le Goater
---
Changes in v6:
- Modified title (Avihai)
- vfio_iommu_map_dirty_notify() : Modified goto label (Avihai)
hw/vfio/common.c | 22 +-
1 file changed, 13 insertions
Use it to update the current error of the migration stream if
available and if not, simply print out the error. Next changes will
update with an error to report.
Reviewed-by: Avihai Horon
Acked-by: Fabiano Rosas
Signed-off-by: Cédric Le Goater
---
Changes in v6:
- Commit log improvements
We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO. Add documentation while at it.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Avihai Horon
Signed-off-by: Cédric Le Goater
---
Changes in v5:
- Fixed typo in set_dirty_page_tracking
Use vmstate_save_state_with_err() to improve error reporting in the
callers and store a reported error under the migration stream. Add
documentation while at it.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Cédric Le Goater
---
Changes in v6:
- Modified title (Avihai
On 5/14/24 13:20, Cédric Le Goater wrote:
On 5/13/24 16:26, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
vfio_set_migration_error() sets the 'return' error on the migration
stream if a migration is in progress
On 5/13/24 16:26, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
vfio_set_migration_error() sets the 'return' error on the migration
stream if a migration is in progress. To improve error reporting, add
a new Error
On 5/13/24 15:51, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Let the callers do the error reporting. Add documentation while at it.
Signed-off-by: Cédric Le Goater
---
Changes in v5:
- Replaced error_setg
On 5/13/24 15:44, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Let the callers do the reporting. This will be useful in
vfio_iommu_map_dirty_notify().
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
On 5/13/24 15:42, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Title should be: Reverse test on vfio_get_xlat_addr()?
It could.
It will simplify the changes coming after.
Signed-off-by: Cédric Le Goater
On 5/13/24 15:30, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Use vmstate_save_state_with_err() to improve error reporting in the
callers and store a reported error under the migration stream. Add
documentation
On 5/13/24 15:21, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Nit: change commit title prefix to vfio/migration (also in other patches that
are closely related to vfio migration)
Plus, maybe change subject
On 5/13/24 15:14, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Change commit title:
vfio: Extend migration_file_set_error() with Error** argument
to:
migration: Extend migration_file_set_error() with Error
On 5/13/24 15:08, Avihai Horon wrote:
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
This allows to update the Error argument of the VFIO log_global_start()
handler. Errors detected when device level logging is started will be
propagated
On 5/13/24 15:03, Avihai Horon wrote:
Hi Cedric,
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO. Add documentation while at it.
First of all
On 5/13/24 16:34, Avihai Horon wrote:
On 13/05/2024 17:01, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/9/24 11:09, Avihai Horon wrote:
Emit VFIO migration QAPI event when a VFIO device changes its migration
state. This can be used by management
state transitions. May be move trace_vfio_migration_set_state()
at the beginning of vfio_migration_set_state() and introduce a new
event for the currently named routine set_state() ?
This can come with followups.
Reviewed-by: Cédric Le Goater
Thanks,
C.
+if (new_state == migration->dev
,
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
MAINTAINERS | 1 +
qapi/qapi-schema.json | 1 +
qapi/vfio.json| 67 +++
qapi/meson.build | 1 +
4 files changed, 70 insertions(+)
create mode 100644 qapi/vfio.json
diff --git
On 5/9/24 11:09, Avihai Horon wrote:
Emit VFIO migration QAPI event when a VFIO device changes its migration
state. This can be used by management applications to get updates on the
current state of the VFIO device for their own purposes.
A new per VFIO device capability, "migration-events", is
Hello Shivaprasad,
On 5/9/24 21:14, Shivaprasad G Bhat wrote:
The commit 6ad359ec29 "(vfio/spapr: Move prereg_listener into
spapr container)" began to use the newly introduced VFIOSpaprContainer
structure.
After several refactors, today the container_of(container,
VFIOSpaprContainer, ABC) is
Hello,
On 5/10/24 16:30, Nicholas Piggin wrote:
The POWER8 LPC ISA device irqs all get combined and reported to the line
connected the PSI LPCHC irq. POWER9 changed this so only internal LPC
host controller irqs use that line, and the device irqs get routed to
4 new lines connected to PSI
in the future.
This looks like a way to work around some other problem, like
avoiding exposing Linux definitions on windows build.
Thanks,
C.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
---
MAINTAINERS| 2 ++
include/sysemu/host_iommu_device.h | 51
to the serial port as it does on real hardware.
This requires a linkage between adu and lpc, which allows adu to
perform memory access in the lpc space.
Signed-off-by: Nicholas Piggin
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
include/hw/ppc/pnv_adu.h | 7 +++
include/hw/ppc/pnv_lpc.h
Le Goater
Thanks,
C.
---
include/hw/ppc/pnv_adu.h | 25 +
include/hw/ppc/pnv_chip.h | 3 +
include/hw/ppc/pnv_xscom.h | 6 ++
hw/ppc/pnv.c | 16 ++
hw/ppc/pnv_adu.c | 111 +
hw/ppc/pnv_xscom.c | 9
Hello Jamin,
To handle the DMA DRAM Side Address High register, we should reintroduce
an "dram-base" property which I removed a while ago. Something like :
diff --git a/include/hw/ssi/aspeed_smc.h b/include/hw/ssi/aspeed_smc.h
index 7f32e43ff6f3..6d8ef6bc968f 100644
---
Hello Jamin
On 4/16/24 11:18, Jamin Lin wrote:
AST2700 interrupt controller(INTC) provides hardware interrupt interfaces
to interrupt of processors PSP, SSP and TSP. In INTC, each interrupt of
INT 128 to INT136 combines 32 interrupts.
Introduce a new aspeed_intc class with instance_init and
Peter,
Could you please look at aspeed_soc_ast2700_gic() when you have some time ?
My GIC knowledge is a bit limited and I would feel more confortable with
your feedback.
The rest looks good to me.
Thanks,
C.
On 4/16/24 11:18, Jamin Lin wrote:
Initial definitions for a simple machine
The 'ref405ep' machine and PPC 405 CPU have no known users, firmware
images are not available, OpenWRT dropped support in 2019, U-Boot in
2017, Linux also is dropping support in 2024. It is time to let go of
this ancient hardware and focus on newer CPUs and platforms.
Signed-off-by: Cédric Le
The 'ref405ep' machine and PPC 405 CPU have no known users, firmware
images are not available, OpenWRT dropped support in 2019, U-Boot in
2017, Linux also is dropping support in 2024. It is time to let go of
this ancient hardware and focus on newer CPUs and platforms.
Signed-off-by: Cédric Le
On 5/7/24 09:48, Duan, Zhenzhong wrote:
Hi Cédric,
-Original Message-
From: Cédric Le Goater
Subject: Re: [PATCH v3 15/19] hw/pci: Introduce
pci_device_[set|unset]_iommu_device()
Hello Zhenzhong,
On 4/29/24 08:50, Zhenzhong Duan wrote:
From: Yi Liu
pci_device_[set|unset
On 5/7/24 11:20, Zhenzhong Duan wrote:
TYPE_HOST_IOMMU_DEVICE_IOMMUFD_VFIO represents a host IOMMU device under
VFIO iommufd backend. It will be created during VFIO device attaching
and passed to vIOMMU.
It will have its own .realize() implementation.
Suggested-by: Cédric Le Goater
Signed-off
On 5/7/24 11:20, Zhenzhong Duan wrote:
Introduce a helper function iommufd_backend_get_device_info() to get
host IOMMU related information through iommufd uAPI.
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/sysemu/iommufd.h | 4
On 5/7/24 11:20, Zhenzhong Duan wrote:
TYPE_HOST_IOMMU_DEVICE_LEGACY_VFIO represents a host IOMMU device under
VFIO legacy container backend.
It will have its own realize implementation.
Suggested-by: Eric Auger
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
---
include/hw
On 5/7/24 11:20, Zhenzhong Duan wrote:
From: Yi Liu
pci_device_[set|unset]_iommu_device() call pci_device_get_iommu_bus_devfn()
to get iommu_bus->iommu_ops and call [set|unset]_iommu_device callback to
set/unset HostIOMMUDevice for a given PCI device.
Signed-off-by: Yi Liu
Signed-off-by: Yi
On 5/7/24 08:42, Zhenzhong Duan wrote:
Make VFIOIOMMUClass::attach_device() and its wrapper function
vfio_attach_device() return bool.
This is to follow the coding standand to return bool if 'Error **'
is used to pass error.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
Hello Zhenzhong,
On 4/29/24 08:50, Zhenzhong Duan wrote:
From: Yi Liu
pci_device_[set|unset]_iommu_device() call pci_device_get_iommu_bus_devfn()
to get iommu_bus->iommu_ops and call [set|unset]_iommu_device callback to
set/unset HostIOMMUDevice for a given PCI device.
Signed-off-by: Yi Liu
()
to check common capabalities of different host platform IOMMUs.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
---
include/sysemu/host_iommu_device.h | 44 ++
backends/host_iommu_device.c | 29
2 files changed, 73
On 5/7/24 04:09, Duan, Zhenzhong wrote:
-Original Message-
From: Cédric Le Goater
Subject: Re: [PATCH 1/3] vfio: Make VFIOIOMMUClass::attach_device() and
its wrapper return bool
On 5/6/24 10:33, Zhenzhong Duan wrote:
Make VFIOIOMMUClass::attach_device() and its wrapper function
Hello Avihai,
On 4/30/24 07:16, Avihai Horon wrote:
When migrating a VFIO device that supports pre-copy, it is transitioned
to STOP_COPY twice: once in vfio_vmstate_change() and second time in
vfio_save_complete_precopy().
The second transition is harmless, as it's a STOP_COPY->STOP_COPY no-op
ine types >= 9.1. The check would be enforced on
older machine types (<= 9.0).
Signed-off-by: Vinayak Kale
Cc: Alex Williamson
Cc: Michael S. Tsirkin
Cc: Cédric Le Goater
LGTM,
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
Version History
v3->v4:
- VSC check is skipped for m
On 5/6/24 10:33, Zhenzhong Duan wrote:
Make VFIOIOMMUClass::add_window() and its wrapper function
vfio_container_add_section_window() return bool.
This is to follow the coding standand to return bool if 'Error **'
is used to pass error.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong
On 5/6/24 10:33, Zhenzhong Duan wrote:
This is to follow the coding standand to return bool if 'Error **'
is used to pass error.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
include/hw/vfio/vfio-container-base.h | 2
On 5/6/24 10:33, Zhenzhong Duan wrote:
Make VFIOIOMMUClass::attach_device() and its wrapper function
vfio_attach_device() return bool.
This is to follow the coding standand to return bool if 'Error **'
is used to pass error.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
Let the callers do the reporting. This will be useful in
vfio_iommu_map_dirty_notify().
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: David Hildenbrand
Reviewed-by: Peter Xu
Signed-off-by: Cédric Le Goater
---
include/exec/memory.h | 15 ++-
hw/vfio/common.c
vfio_save_complete_precopy() currently returns before doing the trace
event. Change that.
Signed-off-by: Cédric Le Goater
---
hw/vfio/migration.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index
87437490bd50321b3eb27770c932078597053746
in
vfio_devices_dma_logging_start(). Remove it.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Cédric Le Goater
---
Changes in v5:
- Used error_setg_errno() in vfio_devices_dma_logging_start()
hw/vfio/common.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions
It will simplify the changes coming after.
Signed-off-by: Cédric Le Goater
---
hw/vfio/common.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index
ed5ee6349ced78b3bde68d2ee506f78ba1a9dd9c
vfio_set_migration_error() sets the 'return' error on the migration
stream if a migration is in progress. To improve error reporting, add
a new Error* argument to also set the Error object on the migration
stream, if a migration is progress.
Signed-off-by: Cédric Le Goater
---
Changes in v5
Let the callers do the error reporting. Add documentation while at it.
Signed-off-by: Cédric Le Goater
---
Changes in v5:
- Replaced error_setg() by error_setg_errno() in
vfio_devices_query_dirty_bitmap() and vfio_legacy_query_dirty_bitmap()
- ':' -> '-' in vfio_iommu_map_dirty_not
Use it to update the current error of the migration stream if
available and if not, simply print out the error. Next changes will
update with an error to report.
Signed-off-by: Cédric Le Goater
---
include/migration/misc.h | 2 +-
hw/vfio/common.c | 2 +-
hw/vfio/migration.c | 4
Use vmstate_save_state_with_err() to improve error reporting in the
callers and store a reported error under the migration stream. Add
documentation while at it.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-common.h | 25
under the migration stream if a migration is in
progress.
Signed-off-by: Cédric Le Goater
---
Changes in v5:
- Replaced error_setg() by error_setg_errno() in vfio_migration_set_state()
- Rebased on 20c64c8a51a4 ("migration: migration_file_set_error")
hw/vfio/migrat
We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO. Add documentation while at it.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Cédric Le Goater
---
Changes in v5:
- Fixed typo in set_dirty_page_tracking documentation
include/hw/vfio/vfio
error_setg() by error_setg_errno() in vfio_migration_set_state()
- Replaced error_setg() by error_setg_errno() in
vfio_devices_query_dirty_bitmap() and vfio_legacy_query_dirty_bitmap()
- ':' -> '-' in vfio_iommu_map_dirty_notify()
Cédric Le Goater (10):
vfio: Add Error** argument to .set_dirty_
On 4/30/24 10:51, Jamin Lin wrote:
Hi Cedric,
On 4/19/24 15:41, Cédric Le Goater wrote:
On 4/16/24 11:18, Jamin Lin wrote:
DMA length is from 1 byte to 32MB for AST2600 and AST10x0 and DMA
length is from 4 bytes to 32MB for AST2500.
In other words, if "R_DMA_LEN" is 0, it s
On 5/3/24 16:10, Jason Gunthorpe wrote:
On Fri, May 03, 2024 at 04:04:25PM +0200, Cédric Le Goater wrote:
However, have you considered another/complementary approach which
would be to create an host IOMMU (iommufd) backend object and a vIOMMU
device object together for each vfio-pci device
Hello Jamin,
On 4/30/24 09:56, Jamin Lin wrote:
Hi Cedric,
-Original Message-
From: Cédric Le Goater
Sent: Tuesday, April 30, 2024 3:26 PM
To: Jamin Lin ; Peter Maydell
; Andrew Jeffery ;
Joel Stanley ; Alistair Francis ; Cleber
Rosa ; Philippe Mathieu-Daudé ;
Wainer dos Santos
On 4/29/24 08:50, Zhenzhong Duan wrote:
Hi,
The most important change in this version is instroducing a common
HostIOMMUDeviceCaps structure in HostIOMMUDevice and a new interface
between vIOMMU and HostIOMMUDevice.
HostIOMMUDeviceClass::realize() is introduced to initialize
ld agree with such a change. The version numbers always confused
me. AFAICT, only QEMU_VERSION_MICRO would need some massaging. It
shouldn't be too complex.
For the series,
Tested-by: Cédric Le Goater
Thanks,
C.
Daniel P. Berrangé (14):
include/hw: add helpers for defining versione
On 5/3/24 06:51, Nicholas Piggin wrote:
On Thu May 2, 2024 at 6:47 PM AEST, Cédric Le Goater wrote:
On 5/1/24 14:39, Nicholas Piggin wrote:
On Wed Apr 17, 2024 at 9:25 PM AEST, Cédric Le Goater wrote:
Hello Nick,
On 4/17/24 13:02, Nicholas Piggin wrote:
This implements a framework
sclp_get_event_facility_bus() scans the whole machine to find a
TYPE_SCLP_EVENTS_BUS object. The SCLPDevice instance is now available
under the machine state, use it to simplify the lookup and adjust the
creation of the consoles.
Signed-off-by: Cédric Le Goater
---
include/hw/s390x/event
get_sclp_device() scans the whole machine to find a TYPE_SCLP object.
Now that the SCLPDevice instance is available under the machine state,
use it to simplify the lookup. While at it, remove the inline to let
the compiler decide on how to optimize.
Signed-off-by: Cédric Le Goater
---
hw/s390x
Initialize directly SCLPDevice from the machine init handler and
remove s390_sclp_init(). We will use the SCLPDevice pointer later to
create the consoles.
Signed-off-by: Cédric Le Goater
---
include/hw/s390x/s390-virtio-ccw.h | 3 +++
include/hw/s390x/sclp.h| 2 --
hw/s390x/s390
Hello,
Here is a little series reworking the SCLPDevice initialization in the
machine to simplify its use.
Applies on top of :
https://lore.kernel.org/qemu-devel/20240430190843.453903-1-th...@redhat.com/
Thanks,
C.
Cédric Le Goater (3):
s390x: Introduce a SCLPDevice pointer under
On 4/30/24 11:58, Duan, Zhenzhong wrote:
-Original Message-
From: Cédric Le Goater
Subject: Re: [PATCH v3 06/19] range: Introduce range_get_last_bit()
On 4/29/24 08:50, Zhenzhong Duan wrote:
This helper get the highest 1 bit position of the upper bound.
If the range is empty
On 5/1/24 14:39, Nicholas Piggin wrote:
On Wed Apr 17, 2024 at 9:25 PM AEST, Cédric Le Goater wrote:
Hello Nick,
On 4/17/24 13:02, Nicholas Piggin wrote:
This implements a framework for an ADU unit model.
The ADU unit actually implements XSCOM, which is the bridge between MMIO
and PIB
101 - 200 of 9368 matches
Mail list logo
