Re: [PATCH v4 1/2] qemu/atomic: Update coding style to make checkpatch.pl happier

2020-09-23 Thread Carlo Marcelo Arenas Belón
ptr, i)) Signed-off-by: Carlo Marcelo Arenas Belón --- include/qemu/atomic.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index 87b85f9f6d..be47e083be 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -14

[PATCH v2] linux-user: detect mismatched ELF ABI in qemu-mips[n32][el]

2020-08-23 Thread Carlo Marcelo Arenas Belón
ive error : Invalid ELF image for this architecture Signed-off-by: Carlo Marcelo Arenas Belón --- Changes since v1: - Use the provided definition from include/elf.h (per Laurent) - Abort instead of warning (per Laurent, not using a custom error though) - Expand the check to all other combinations (

[PATCH] linux-user: warn if trying to use qemu-mipsn32[el] with non n32 ELF

2020-08-21 Thread Carlo Marcelo Arenas Belón
While technically compatible will (depending on the CPU) hopefully fail later with a cryptic error: qemu: Unexpected FPU mode Provide an earlier hint of what the problem might be by detecting if the binary might not be using the n32 ABI and print a warning. Signed-off-by: Carlo Marcelo Arenas

[Bug 1825002] Re: "qemu: Unexpected FPU mode" since 0c1bbedc10e86ea9366b6af8c5520fafa3266b2f

2020-08-11 Thread Carlo Marcelo Arenas Belón
FWIW I am still seeing a similar failure with 5.1.0rc3 (using a "Hello World" like program in Ubuntu 20.04 x86_64 built statically): $ mipsisa32r6el-linux-gnu-gcc --static -o h h.c $ ./qemu-mipsn32el ./h qemu: Unexpected FPU mode big endian also seems to be affected -- You received this bug

[Bug 1821444] Re: qemu-ppc (user) incorrectly translates float32 arithmetics

2020-04-05 Thread Carlo Marcelo Arenas Belón
fix committed with c0e6616b6685ffdb4c5e091bc152e46e14703dd1 and released with 4.2.0 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821444

[Bug 1821515] Re: qemu-ppc (user) incorrectly converts float(nan)->double(non-nan)

2020-03-28 Thread Carlo Marcelo Arenas Belón
*** This bug is a duplicate of bug 1821444 *** https://bugs.launchpad.net/bugs/1821444 ** This bug has been marked a duplicate of bug 1821444 qemu-ppc (user) incorrectly translates float32 arithmetics -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [PATCH] configure: fix sdl detection using sdl2-config

2019-07-10 Thread Carlo Marcelo Arenas Belón
SDL. Fixes: 0015ca5cbabe ("ui: remove support for SDL1.2 in favour of SDL2") Signed-off-by: Carlo Marcelo Arenas Belón --- configure | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 4983c8b533..0f88ba98a6 100755 --- a/confi

[Qemu-devel] [PATCH] configure: remove obsoleted $sparc_cpu variable

2019-07-09 Thread Carlo Marcelo Arenas Belón
9b9c37c364 ("tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode.", 2012-09-21) removed the need for this variable and most of the references to it, but this one. Remove defunct code, no effect or functionality change expected. Signed-off-by: Carlo Marcelo Ar

[Qemu-devel] [PATCH] linux-user: add SO_LINGER to {g,s}etsockopt

2018-08-24 Thread Carlo Marcelo Arenas Belón
Marcelo Arenas Belón Co-Authored-By: Chen Gang --- linux-user/syscall.c | 52 ++- linux-user/syscall_defs.h | 5 2 files changed, 56 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 02fba7606d..43f2839540

[Qemu-devel] [PATCH v2] gitignore: ignore check-qlit test

2017-09-26 Thread Carlo Marcelo Arenas Belón
test introduced in 382176b4d78e070d119af8e0dcd00884c11bbec2 Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> Reviewed-by: Eric Blake <ebl...@redhat.com> --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore inde

[Qemu-devel] [PATCH] gitignore: ignore check-qlit test

2017-09-26 Thread Carlo Marcelo Arenas Belón
Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index cf6d99c91e..53cb2efaee 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -6,6 +6,7 @@ check-qdict chec

[Qemu-devel] [PATCH] linux-user: remove duplicate break in syscall

2017-09-25 Thread Carlo Marcelo Arenas Belón
likely introduced in 3532fa7402cda16f7b95261b0339c58630051f0b Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/syscall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 9b6364a266..3ef4d1c568 100644 --- a/linu

[Qemu-devel] [PATCH v2 6/6] linux_user: consolidate sock_type

2017-09-25 Thread Carlo Marcelo Arenas Belón
remove unnecessary sock_type enum and other unused surrounding code to allow for per arch sockbits to mirror better linux headers for maintenance Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/alpha/sockbits.h | 36 linux-use

[Qemu-devel] [PATCH v2 4/6] linux-user: refactor socket.h for sparc

2017-09-25 Thread Carlo Marcelo Arenas Belón
fixes SOL_SOCKET and SO_LINGER and all other values that didn't match the default (SO_PASSSEC being the exception as it only changed base) TARGET_SOCK_{NONBLOCK,CLOEXEC} updated to match the values for the header: arch/sparc/include/uapi/asm/fcntl.h Signed-off-by: Carlo Marcelo Arenas Belón

[Qemu-devel] [PATCH v2 5/6] linux-user: update default socket.h

2017-09-25 Thread Carlo Marcelo Arenas Belón
enable SO_REUSEPORT as a sideeffect and add SO_GET_FILTER alias Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/socket.h | 59 +++-- 1 file changed, 48 insertions(+), 11 deletions(-) diff --git a/linux-user/sock

[Qemu-devel] [PATCH v2 2/6] linux-user: refactor socket.h for alpha

2017-09-25 Thread Carlo Marcelo Arenas Belón
based on fresh bits from linux 4.14 and therefore enabling SO_REUSEPORT as a side effect to easy on maintenance SO_NONBLOCK updated to match the value from linux headers (in hexadecimal) as seen in arch/alpha/include/asm/socket.h Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.

[Qemu-devel] [PATCH v2 3/6] linux-user: refactor socket.h for mips

2017-09-25 Thread Carlo Marcelo Arenas Belón
Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> Reviewed-by: Laurent Vivier <laur...@vivier.eu> --- linux-user/mips/sockbits.h | 107 + linux-user/socket.h| 103 +-- 2 files

[Qemu-devel] [PATCH v2 1/6] linux-user: update hppa sockbits

2017-09-25 Thread Carlo Marcelo Arenas Belón
updated to match arch/parisc/include/uapi/asm/socket.h from linux 4.14 include in socket.h changed to prefer a local path like all other qemu headers and for consistency and clarity when adding all other arch Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-use

[Qemu-devel] linux-user: refactor socket.h into architecture specific sockbits

2017-09-25 Thread Carlo Marcelo Arenas Belón
the definitions in socket.h are meant to reflect the ones in linux for each respective target, but are sometimes difficult to maintain. hppa (AKA parisc) was initially merged with an independent file that mirrors more closely the corresponding one in linux but hasn't been updated since. this

[Qemu-devel] [RFC 6/6] linux-user: update default socket.h

2017-09-22 Thread Carlo Marcelo Arenas Belón
* enable SO_REUSEPORT as a sideeffect and add SO_GET_FILTER alias * make sure 64bit version for ppc is also supported Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/socket.h | 61 ++--- 1 file changed, 49 inse

[Qemu-devel] [RFC 4/6] linux-user: refactor socket.h for sparc

2017-09-22 Thread Carlo Marcelo Arenas Belón
fixes SOL_SOCKET and SO_LINGER at least Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/socket.h | 46 ++-- linux-user/sparc/sockbits.h | 104 2 files changed, 107 insertions(+), 43 del

[Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc and mips

2017-09-22 Thread Carlo Marcelo Arenas Belón
Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/mips64/sockbits.h | 1 + linux-user/socket.h | 4 ++-- linux-user/sparc64/sockbits.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 linux-user/mips64/sockbits.h create mode

[Qemu-devel] [RFC 3/6] linux-user: refactor socket.h for mips

2017-09-22 Thread Carlo Marcelo Arenas Belón
fresh bits from linux 4.14, redefine SO_STYLE and {SO,SCM}_TIMESTAMP to the target values and enables SO_REUSEPORT Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/mips/sockbits.h | 107 + linux-user/socket.h

[Qemu-devel] [RFC 1/6] linux-user: update hppa sockbits

2017-09-22 Thread Carlo Marcelo Arenas Belón
updated to match arch/parisc/include/uapi/asm/socket.h from linux 4.14 Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/hppa/sockbits.h | 148 +++-- linux-user/socket.h| 2 +- 2 files changed, 78 insertions(

[Qemu-devel] [RFC 2/6] linux-user: refactor socket.h for alpha

2017-09-22 Thread Carlo Marcelo Arenas Belón
based on fresh bits from linux 4.14 and therefore enabling SO_REUSEPORT as a side effect Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/alpha/sockbits.h | 104 linux-user/socket.h

[Qemu-devel] [RFC 0/6] linux-user: refactor socket.h into architecture specific sockbits

2017-09-22 Thread Carlo Marcelo Arenas Belón
the definitions in socket.h are meant to reflect the ones in linux for each respective target, but are sometimes difficult to maintain. hppa (AKA parisc) was initially merged with an independent file that mirrors more closely the corresponding one in linux but hasn't been updated since. while

[Qemu-devel] [PATCH] linux_user: fix TARGET_SOL_SOCKET for sparc

2017-09-20 Thread Carlo Marcelo Arenas Belón
Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/socket.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/linux-user/socket.h b/linux-user/socket.h index 129f9b4713..1db1a184b9 100644 --- a/linux-user/socket.h +++ b/linux-user/so

[Qemu-devel] [PATCH 3/3] linux-user: add SO_LINGER to getsockopt

2017-09-19 Thread Carlo Marcelo Arenas Belón
Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/syscall.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ad689dad50..91bd27c63a 100644 --- a/linux-user/sys

[Qemu-devel] [PATCH 2/3] linux-user: add SO_LINGER to setsockopt

2017-09-19 Thread Carlo Marcelo Arenas Belón
Original implementation by Chen Gang; all bugs mine Signed-off-by: Chen Gang <gang.chen.5...@gmail.com> Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/syscall.c | 15 +++ linux-user/syscall_defs.h | 5 + 2 files changed, 20 inserti

[Qemu-devel] [PATCH 1/3] linux-user: fix TARGET_SO_LINGER for sparc

2017-09-19 Thread Carlo Marcelo Arenas Belón
Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/socket.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/linux-user/socket.h b/linux-user/socket.h index 7051cd2cf4..129f9b4713 100644 --- a/linux-user/socket.h +++ b/linux-user/so

[Qemu-devel] [PATCH v3] linux-user: syscall: Add SO_LINGER for setsockopt

2017-09-19 Thread Carlo Marcelo Arenas Belón
Original implementation from Chen Gang; code moved around as per v2 Signed-off-by: Chen Gang <gang.chen.5...@gmail.com> Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- linux-user/syscall.c | 16 linux-user/syscall_defs.h | 5 + 2 files