Re: [Qemu-devel] [PATCH] vnc: fix option misspelling (non-adapative - non-adaptive)

2012-11-20 Thread Catalin Patulea
On Fri, Nov 9, 2012 at 7:19 PM, Peter Maydell peter.mayd...@linaro.org wrote: If we're gonna do this I guess it should go into 1.3... cc'ing Anthony. Friendly ping for trivial patch :)

Re: [Qemu-devel] Crash on Windows XP startup

2012-11-09 Thread Catalin Patulea
SIGSEGV is in target code: (gdb) bt #0 0x402fd349 in code_gen_buffer () #1 0x0056113b in cpu_x86_exec (env=0x19489f0) at /usr/local/google/home/catalinp/src/qemu/cpu-exec.c:599 #2 0x005625f9 in tcg_cpu_exec (env=0x19489f0) at

Re: [Qemu-devel] Crash on Windows XP startup

2012-11-09 Thread Catalin Patulea
I can post the target code and the code generated by TCG - not sure how helpful that would be. There also seems to be a diff between what is logged by -d out_asm and what I see in gdb with disass, and the segv occurs in one of the diff blocks. On Fri, Nov 9, 2012 at 1:42 PM, Catalin Patulea catal

[Qemu-devel] [PATCH] vnc: fix option misspelling (non-adapative - non-adaptive)

2012-11-09 Thread Catalin Patulea
Signed-off-by: Catalin Patulea catal...@google.com --- A cursory web search shows that this flag doesn't show up much other than in QEMU mailing lists and source. I don't think this will break anything. ui/vnc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b

[Qemu-devel] [PATCH] vnc: fix option misspelling (non-adapative - non-adaptive)

2012-11-09 Thread Catalin Patulea
Signed-off-by: Catalin Patulea catal...@google.com --- D'oh, that was really stupid. Here it is with the correct length. ui/vnc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 61f120e..ba30362 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2945,7

Re: [Qemu-devel] [PATCH] tests/tcg: new test for i386 FPREM and FPREM1

2012-11-04 Thread Catalin Patulea
Ping? Original patch still applies on master. On Mon, Oct 29, 2012 at 4:30 AM, Catalin Patulea catal...@google.com wrote: On Mon, Oct 29, 2012 at 4:04 AM, Peter Maydell peter.mayd...@linaro.org wrote: I'm not fantastically enthused about bitfields, but since this is a test program

[Qemu-devel] [PATCH] tests/tcg: fix unused result warnings

2012-10-29 Thread Catalin Patulea
With i386-linux-user target on x86_64 host, this does not introduce any new test failures. Signed-off-by: Catalin Patulea catal...@google.com --- tests/tcg/test-mmap.c | 15 +++ tests/tcg/testthread.c | 11 +-- 2 files changed, 20 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH] tests/tcg: new test for i386 FPREM and FPREM1

2012-10-29 Thread Catalin Patulea
. The outputs can then be compared between bare metal and QEMU. The 'run-test-i386-fprem' make target does just that. Signed-off-by: Catalin Patulea catal...@google.com --- Here is a refresh of the patch originally sent in back in July: https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02054.html

Re: [Qemu-devel] [PATCH] tests/tcg: new test for i386 FPREM and FPREM1

2012-10-29 Thread Catalin Patulea
On Mon, Oct 29, 2012 at 4:04 AM, Peter Maydell peter.mayd...@linaro.org wrote: I'm not fantastically enthused about bitfields, but since this is a test program and not part of QEMU proper I don't think rewriting to avoid them is justified. I could maybe check some conditions (perhaps

[Qemu-devel] [PATCHv2] tests/tcg: fix unused result warnings

2012-10-29 Thread Catalin Patulea
With i386-linux-user target on x86_64 host, this does not introduce any new test failures. Signed-off-by: Catalin Patulea catal...@google.com --- v2: - Fixes style issues from checkpatch.pl - For some reason, the patch from the list wouldn't apply for me onto master on a different machine

[Qemu-devel] [PATCH] tests/tcg: fix a few warnings

2012-10-22 Thread Catalin Patulea
Signed-off-by: Catalin Patulea catal...@google.com --- This leaves a few of these: warning: ignoring return value of 'write', declared with attribute warn_unused_result How interesting is it to fix these? (Perhaps by asserting that the full write completed?) tests/tcg/hello-i386.c |3

[Qemu-devel] [PATCHv3] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
Sorry this got abandoned.. here is a fresh (and slightly leaner) patch on top of master. Can anyone take a look? --- This broke when the tests were moved from tests/ to tests/tcg/. On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are broken, but at least they build. To

Re: [Qemu-devel] [PATCHv3] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
On Tue, Oct 16, 2012 at 8:50 AM, Peter Maydell peter.mayd...@linaro.org wrote: The compile line for the test-x86_64 target also needs QEMU_INCLUDES added to it. Done. I can't work out how to get a working i386 compiler on my 64-bit Ubuntu system but I think that's an Ubuntu issue :-) Tests

Re: [Qemu-devel] [PATCHv3] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
On Tue, Oct 16, 2012 at 2:47 PM, Peter Maydell peter.mayd...@linaro.org wrote: I have a feeling that precise's mostly-working multiarch support may be the issue... Seems I've got libgcc1:i386 and lib32gcc1 which provide libgcc_s.so* in various forms. Not entirely sure what the 'right' setup is.

[Qemu-devel] [PATCHv4] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
Fixes compile line for test-x86_64 target as well. --- This broke when the tests were moved from tests/ to tests/tcg/. On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are broken, but at least they build. To build/run the tests: $ cd $BUILD_PATH/tests/tcg $

Re: [Qemu-devel] [PATCHv4] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
On Tue, Oct 16, 2012 at 3:54 PM, Peter Maydell peter.mayd...@linaro.org wrote: This patch isn't in the right format to apply, I'm afraid. Major problem: * missing signed-off-by line: we can't accept any patch without one Minor problem: * the actual commit message is below the first

[Qemu-devel] [PATCHv5] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
This broke when the tests were moved from tests/ to tests/tcg/. On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are broken, but at least they build. To build/run the tests: $ cd $BUILD_PATH/tests/tcg $ SRC_PATH=path/to/qemu make target Signed-off-by: Catalin Patulea catal

[Qemu-devel] [PATCH v2] tests/tcg: add test-i386-fprem and make target for comparing QEMU to h/w

2012-07-25 Thread Catalin Patulea
rise to a range of numeric values, NaNs, infinities, and other special values. FPREM raises either no exceptions, invalid or denormal, and these cases are intended to get good code path coverage of the implementation. Signed-off-by: Catalin Patulea catal...@google.com --- tests/tcg/Makefile

Re: [Qemu-devel] [PATCH] tests/tcg: add test-i386-fprem and make target for comparing QEMU to h/w

2012-07-20 Thread Catalin Patulea
On Tue, Jul 17, 2012 at 10:49 AM, Catalin Patulea catal...@google.com wrote: the Windows build would not put the fields 'mantissa' and 'one' in the same 64 bit word, it would insert a padding bit. Since floatx80 is not part of a Windows API (in fact, it's not part of any API, it's in a test

Re: [Qemu-devel] [PATCH v2] Get tests/tcg building and fix an unused variable warning due to wrong extended asm operands.

2012-07-20 Thread Catalin Patulea
On Mon, Jul 16, 2012 at 5:19 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 16 July 2012 21:11, Catalin Patulea catal...@google.com wrote: To build/run the tests: $ cd $BUILD_PATH/tests/tcg $ SRC_PATH=path/to/qemu make target Signed-off-by: Catalin Patulea catal...@google.com

Re: [Qemu-devel] [PATCH] tests/tcg: add test-i386-fprem and make target for comparing QEMU to h/w

2012-07-17 Thread Catalin Patulea
On Tue, Jul 17, 2012 at 8:23 AM, Peter Maydell peter.mayd...@linaro.org wrote: I think our current position is don't use bitfields for anything that has to match an externally defined layout. This is because on Windows we have to compile with -mms-bitfields [for compatibility with Windows

Re: [Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-16 Thread Catalin Patulea
, 2012 at 02:55:13AM -0400, Catalin Patulea wrote: Not all tests pass, but at least they can be run using 'make test'. To build individual tests: $ cd $BUILD_PATH/tests/tcg $ SRC_PATH=path/to/qemu make target [snip] Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute

Re: [Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-16 Thread Catalin Patulea
On Mon, Jul 16, 2012 at 3:08 PM, Peter Maydell peter.mayd...@linaro.org wrote: You need to have the $(LIBS) after the $^. Done. test_path.o: test_path.c + $(CC_I386) $(QEMU_INCLUDES) $(GLIB_CFLAGS) $(CFLAGS) $(LDFLAGS) -c -o $@ $^ Ditto. I don't think I meant to put $(LDFLAGS) in

[Qemu-devel] [PATCH v2] Get tests/tcg building and fix an unused variable warning due to wrong extended asm operands.

2012-07-16 Thread Catalin Patulea
To build/run the tests: $ cd $BUILD_PATH/tests/tcg $ SRC_PATH=path/to/qemu make target Signed-off-by: Catalin Patulea catal...@google.com --- This should also fix the lock nop error. I just peeked at what bytes my gcc (4.4.3) generates. tests/tcg/Makefile| 16 ++-- tests/tcg

Re: [Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-16 Thread Catalin Patulea
On Mon, Jul 16, 2012 at 5:11 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 16 July 2012 21:00, Catalin Patulea catal...@google.com wrote: On Mon, Jul 16, 2012 at 3:08 PM, Peter Maydell peter.mayd...@linaro.org wrote: ccache gcc -m32 -I/home/pm215/src/qemu/qemu/slirp -I. -I/home/pm215

[Qemu-devel] [PATCH] tests/tcg: add test-i386-fprem and make target for comparing QEMU to h/w

2012-07-16 Thread Catalin Patulea
-off-by: Catalin Patulea catal...@google.com --- tests/tcg/Makefile |9 ++ tests/tcg/test-i386-fprem.c | 325 +++ 2 files changed, 334 insertions(+), 0 deletions(-) create mode 100644 tests/tcg/test-i386-fprem.c diff --git a/tests/tcg/Makefile b

Re: [Qemu-devel] [PATCH] tests/tcg: add test-i386-fprem and make target for comparing QEMU to h/w

2012-07-16 Thread Catalin Patulea
On Mon, Jul 16, 2012 at 10:24 PM, Catalin Patulea catal...@google.com wrote: I don't think FPREM can ever lose precision with respect to its operands. Sorry, this should be, FPREM can't _gain_ precision with respect to its operands. Think of the binary representation with infinite precision

[Qemu-devel] [PATCH] Get tests/tcg building, fix unused variable warning due to wrong extended asm operand, fix the 'test' make target.

2012-07-13 Thread Catalin Patulea
Not all tests pass, but at least they can be run using 'make test'. To build individual tests: $ cd $BUILD_PATH/tests/tcg $ SRC_PATH=path/to/qemu make target Signed-off-by: Catalin Patulea catal...@google.com --- tests/tcg/Makefile| 16 ++-- tests/tcg/test-i386.c |3

Re: [Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-07-09 Thread Catalin Patulea
On Mon, Jul 2, 2012 at 11:25 AM, Catalin Patulea catal...@google.com wrote: FPREM1 now passes the TestFloat floatx80_rem suite (and FPREM is implemented very similarly). The code (the bulk of which is remainder_kernel and do_fprem) is derived from Bochs SVN revision 11224 dated 2012-06-21

Re: [Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-07-02 Thread Catalin Patulea
On Fri, Jun 29, 2012 at 9:13 AM, Andreas Färber afaer...@suse.de wrote: Please run scripts/checkpatch.pl for CODING_STYLE issues, I spotted one slightly misplaced if brace, and one empty line at the bottom seemed to have indentation (git-am complains about that, too). Done. The only issue left

[Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-07-02 Thread Catalin Patulea
. as needed. Signed-off-by: Catalin Patulea catal...@google.com --- fpu/softfloat.c | 195 +++ fpu/softfloat.h |4 + target-i386/op_helper.c | 166 3 files changed, 266 insertions(+), 99 deletions

Re: [Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-07-02 Thread Catalin Patulea
On Mon, Jul 2, 2012 at 11:25 AM, Catalin Patulea catal...@google.com wrote: FPREM1 now passes the TestFloat floatx80_rem suite (and FPREM is implemented very similarly). The code (the bulk of which is remainder_kernel and do_fprem) is derived from Bochs SVN revision 11224 dated 2012-06-21

Re: [Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-06-28 Thread Catalin Patulea
On Thu, Jun 28, 2012 at 2:25 PM, Peter Maydell peter.mayd...@linaro.org wrote:  /* +| Returns 1 if the extended double-precision floating-point value `a' is an +| unsupported; otherwise returns 0. an unsupported

[Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-06-27 Thread Catalin Patulea
Hey guys, I've been hacking up the FPREM and FPREM1 i386 instructions (without KVM) to be implemented using SoftFloat only. This was motivated by some correctness issues that we noticed with the current implementation which follows the AMD datasheet.I believe the datasheet explains the