this will allow to remove the kvm stubs.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Reviewed-by: Thomas Huth
---
target/s390x/diag.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/s390x/diag.c b/target/s390x/diag.c
index c17a2498a7..8405f69df0
split sysemu part of cpu models,
also create a tiny _user.c with just the (at least for now),
empty implementation of apply_cpu_model.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Reviewed-by: Thomas Huth
---
MAINTAINERS | 1 +
target/s390x/cpu_models.c
Now that we have moved cpu-dump functionality out of helper.c,
we can make the module sysemu-only.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
Reviewed-by: Thomas Huth
---
target/s390x/helper.c| 9 +
target/s390x/meson.build | 2 +-
2 files
this will allow in later patches to remove unneeded stubs
in target/s390x.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Reviewed-by: Thomas Huth
---
hw/s390x/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1
Splitting this functionality also allows us to make helper.c sysemu-only.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
---
target/s390x/cpu-dump.c | 134 ++
target/s390x/cpu.c | 43 +++
target/s390x/helper.c
The internal.h file is renamed to s390x-internal.h, because of the
risk of collision with other files with the same name.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: David Hildenbrand
Acked-by: Cornelia Huck
---
target/s390x/arch_dump.c | 2
replace general "else" with specific checks for each possible accelerator.
Handle qtest as a NOP, and error out for an unknown accelerator used in
combination with tod.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Reviewed-by: David Hildenbrand
Reviewed-by: Cor
move kvm files into kvm/
After the reshuffling, update MAINTAINERS accordingly.
Make use of the new directory:
target/s390x/kvm/
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Reviewed-by: Cornelia Huck
---
MAINTAINERS| 3 +--
hw/intc/s390_flic_kvm.c
move sysemu-only code out to cpu-sysemu.c
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
Reviewed-by: Thomas Huth
---
target/s390x/cpu-sysemu.c | 309 ++
target/s390x/cpu.c| 285
now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TCG stub anymore.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Reviewed-by: Thomas Huth
---
target/s390x
we stop short of renaming the actual qom object though,
so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu".
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Reviewed-by: Thomas Huth
---
hw/s390x/m
all function calls are protected by kvm_enabled(),
so we do not need the stubs.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Reviewed-by: Cornelia Huck
Reviewed-by: Thomas Huth
---
MAINTAINERS | 1 -
target/s390x/kvm-stub.c | 121
the lack of target_user_arch makes it hard to fully leverage the
build system in order to separate user code from sysemu code.
Provide it, so that we can avoid the proliferation of #ifdef
in target code.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
ront (David)
* "hw/s390x: only build tod-qemu from the CONFIG_TCG build"
- move just after, use "tod-tcg" instead
* "hw/s390x: tod: make explicit checks for accelerators when initializing"
- removed a line break in commit message
* "target/s390x: start moving T
, Yu-Chen
Acked-by: David Hildenbrand
Acked-by: Cornelia Huck
---
MAINTAINERS| 1 +
hw/s390x/tod-tcg.c | 2 +-
include/hw/s390x/tod.h | 2 +-
target/s390x/interrupt.c | 2 +-
target/s390x/machine.c
split sysemu part of cpu models,
also create a tiny _user.c with just the (at least for now),
empty implementation of apply_cpu_model.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
MAINTAINERS | 1 +
target/s390x/cpu_models.c| 417
Splitting this functionality also allows us to make helper.c sysemu-only.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
---
target/s390x/cpu-dump.c | 176 +++
target/s390x/helper.c| 151
move sysemu-only code out to cpu-sysemu.c
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/cpu-sysemu.c | 309 ++
target/s390x/cpu.c| 285 ++-
target/s390x/meson.build | 1 +
target/s390x
MAINTAINERS accordingly.
Make use of the new directory:
target/s390x/tcg/
Signed-off-by: Claudio Fontana
Acked-by: David Hildenbrand
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
---
MAINTAINERS | 1 +
hw/s390x/tod-tcg.c| 2
move kvm files into kvm/
After the reshuffling, update MAINTAINERS accordingly.
Make use of the new directory:
target/s390x/kvm/
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
MAINTAINERS| 3 +--
hw/intc/s390_flic_kvm.c| 2 +-
hw/s390x
replace general "else" with specific checks for each possible accelerator.
Handle qtest as a NOP, and error out for an unknown accelerator used in
combination with tod.
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Ch
this will allow to remove the kvm stubs.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/diag.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/s390x/diag.c b/target/s390x/diag.c
index c17a2498a7..8405f69df0 100644
--- a/target/s390x
all function calls are protected by kvm_enabled(),
so we do not need the stubs.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
MAINTAINERS | 1 -
target/s390x/kvm-stub.c | 121 ---
target/s390x/meson.build | 2 +-
3 files
this will allow in later patches to remove unneeded stubs
in target/s390x.
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Cho, Yu-Chen
---
hw/s390x/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw
now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TCG stub anymore.
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Cho, Yu-Chen
---
target/s390x/meson.build | 2 +-
target/s390x
Now that we have moved cpu-dump functionality out of helper.c,
we can make the module sysemu-only.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
---
target/s390x/helper.c| 9 +
target/s390x/meson.build | 2 +-
2 files changed, 2 insertions
the lack of target_user_arch makes it hard to fully leverage the
build system in order to separate user code from sysemu code.
Provide it, so that we can avoid the proliferation of #ifdef
in target code.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
we stop short of renaming the actual qom object though,
so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu".
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Cho, Yu-Chen
---
hw/s390x/meson.build | 2 +-
hw/
checks for accelerators when initializing"
- removed a line break in commit message
* "target/s390x: start moving TCG-only code to tcg/"
- split the rename s390x-internal.h rename part, do it before the move
* "target/s390x: move kvm files into kvm/"
- fix broken/missing m
split sysemu part of cpu models,
also create a tiny _user.c with just the (at least for now),
empty implementation of apply_cpu_model.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
MAINTAINERS | 1 +
target/s390x/cpu_models.c| 417
move kvm files into kvm/
After the reshuffling, update MAINTAINERS accordingly.
Make use of the new directory:
target/s390x/kvm/
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
MAINTAINERS| 3 +--
hw/intc/s390_flic_kvm.c| 2 +-
hw/s390x
this will allow to remove the kvm stubs.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/diag.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/s390x/diag.c b/target/s390x/diag.c
index c17a2498a7..8405f69df0 100644
--- a/target/s390x
Now that we have moved cpu-dump functionality out of helper.c,
we can make the module sysemu-only.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
---
target/s390x/helper.c| 6 +-
target/s390x/meson.build | 2 +-
2 files changed, 2 insertions(+), 6
Splitting this functionality also allows us to make helper.c sysemu-only.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
---
target/s390x/cpu-dump.c | 131 +++
target/s390x/helper.c| 107
all function calls are protected by kvm_enabled(),
so we do not need the stubs.
For kvm_s390_get_gs(), the last user has likely been removed with
0280b3eb7c ("s390x/kvm: use cpu model for gscb on compat machines").
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
M
move sysemu-only code out to cpu-sysemu.c
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/cpu-sysemu.c | 309 ++
target/s390x/cpu.c| 285 ++-
target/s390x/meson.build | 1 +
target/s390x
now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TCG stub anymore.
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Cho, Yu-Chen
---
target/s390x/meson.build | 2 +-
target/s390x
MAINTAINERS accordingly.
Make use of the new directory:
target/s390x/tcg/
Signed-off-by: Claudio Fontana
Acked-by: David Hildenbrand
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
---
MAINTAINERS | 2 +-
hw/s390x/tod-tcg.c| 2
the lack of target_user_arch makes it hard to fully leverage the
build system in order to separate user code from sysemu code.
Provide it, so that we can avoid the proliferation of #ifdef
in target code.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
Acked-by: Cornelia Huck
replace general "else" with specific checks for each possible accelerator.
Handle qtest as a NOP, and error out for an unknown accelerator used in
combination with tod.
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Ch
this will allow in later patches to remove unneeded stubs
in target/s390x.
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Cho, Yu-Chen
---
hw/s390x/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw
we stop short of renaming the actual qom object though,
so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu".
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Cho, Yu-Chen
---
hw/s390x/meson.build | 2 +-
hw/
qemu from the CONFIG_TCG build"
- move just after, use "tod-tcg" instead
* "hw/s390x: tod: make explicit checks for accelerators when initializing"
- removed a line break in commit message
* "target/s390x: start moving TCG-only code to tcg/"
- split the rename
ERS: update s390x directories"
- new patch
Pre-requisite series (not really needed for now, only in further work down the
line):
https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg07461.html
Motivation and higher level steps:
https://lists.gnu.org/archive/html/qemu-devel/2020-05
I also done a branch for current master from [RFC v3 00/13] s390x cleanup
https://gitlab.com/alcho.tw/qemu/-/tree/s390_cleanup_v4
and it's also built and test success passed through my CI:
https://gitlab.com/alcho.tw/qemu/-/pipelines/307149915
Cheers,
AL
Alex Bennée 於 2021年5月21日
also create a tiny _user.c with just the (at least for now),
empty implementation of apply_cpu_model.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/cpu_models.c| 417 +-
target/s390x/cpu_models_sysemu.c | 426
After the reshuffling, update MAINTAINERS accordingly.
Make use of the new directories:
target/s390x/kvm/
target/s390x/tcg/
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
MAINTAINERS | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b
this will allow to remove the kvm stubs.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/diag.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/s390x/diag.c b/target/s390x/diag.c
index c17a2498a7..8405f69df0 100644
--- a/target/s390x
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
hw/intc/s390_flic_kvm.c| 2 +-
hw/s390x/s390-stattrib-kvm.c | 2 +-
hw/s390x/tod-kvm.c | 2 +-
hw/vfio/ap.c | 2 +-
meson.build| 1 +
target/s390x
Now that we have moved cpu-dump functionality out of helper.c,
we can make the module sysemu-only.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/helper.c| 4
target/s390x/meson.build | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git
all function calls are protected by kvm_enabled(),
so we should not need the stubs.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/kvm-stub.c | 126 ---
target/s390x/meson.build | 2 +-
2 files changed, 1 insertion(+), 127
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/cpu-sysemu.c | 304 ++
target/s390x/cpu.c| 282 ++-
target/s390x/meson.build | 1 +
target/s390x/trace-events | 2 +-
4 files changed, 318
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/cpu-dump.c | 131 +++
target/s390x/helper.c| 107
target/s390x/meson.build | 1 +
3 files changed, 132 insertions(+), 107 deletions(-)
create
Acked-by: David Hildenbrand
Signed-off-by: Cho, Yu-Chen
---
hw/s390x/tod-tcg.c| 2 +-
include/hw/s390x/tod.h| 2 +-
target/s390x/arch_dump.c | 2 +-
target/s390x/cpu.c| 2 +-
target/s390x
this will allow in later patches to remove unneeded stubs
in target/s390x.
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Cho, Yu-Chen
---
hw/s390x/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw
replace general "else" with specific checks for each possible accelerator.
Handle qtest as a NOP, and error out for an unknown accelerator used in
combination with tod.
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Ch
now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TCG stub anymore.
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Cho, Yu-Chen
---
target/s390x/meson.build | 2 +-
target/s390x
the lack of target_user_arch makes it hard to fully leverage the
build system in order to separate user code from sysemu code.
Provide it, so that we can avoid the proliferation of #ifdef
in target code.
Signed-off-by: Claudio Fontana
Signed-off-by: Cho, Yu-Chen
---
target/s390x/meson.build
we stop short of renaming the actual qom object though,
so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu".
Signed-off-by: Claudio Fontana
Reviewed-by: David Hildenbrand
Reviewed-by: Cornelia Huck
Signed-off-by: Cho, Yu-Chen
---
hw/s390x/meson.build | 2 +-
hw/
Add build-system-opensuse jobs and opensuse-leap.docker dockerfile.
Use openSUSE Leap 15.2 container image in the gitlab-CI.
Signed-off-by: Cho, Yu-Chen
---
v4:
Add package tar and fix python3 version from 3.8 to 3.6
Add acceptance-system-opensuse back.
v3:
Drop the "acceptance-system-ope
Add build-system-opensuse jobs and opensuse-leap.docker dockerfile.
Use openSUSE Leap 15.2 container image in the gitlab-CI.
Signed-off-by: Cho, Yu-Chen
---
v3:
Drop the "acceptance-system-opensuse" job part of the
patch for now to get at least the basic compile-coverage
v2:
Drop so
Hi Thomas,
Sorry for late reply,
Thomas Huth 於 2020年12月18日 週五 下午7:14寫道：
>
> On 11/12/2020 14.09, Thomas Huth wrote:
> > On 10/12/2020 10.32, AL Yu-Chen Cho wrote:
> >> Hi Thomas,
> >>
> >> I try to reproduce this failed in my repo, but it seems works fine.
> >> Would you please give it a try
v2:
Drop some package from dockerfile to make docker image more light.
v1:
Add build-system-opensuse jobs and opensuse-leap.docker dockerfile.
Use openSUSE Leap 15.2 container image in the gitlab-CI.
Signed-off-by: Cho, Yu-Chen
---
.gitlab-ci.d/containers.yml | 5 ++
.gitlab
v2:
Drop some package from dockerfile to make docker image more light.
v1:
Add build-system-opensuse jobs and opensuse-leap.docker dockerfile.
Use openSUSE Leap 15.2 container image in the gitlab-CI.
Signed-off-by: Cho, Yu-Chen
---
.gitlab-ci.d/containers.yml | 5 ++
.gitlab
Add build-system-opensuse jobs and add opensuse-leap.docker dockerfile.
Use openSUSE Leap 15.2 container image in the gitlab-CI.
Signed-off-by: Cho, Yu-Chen
---
.gitlab-ci.d/containers.yml | 5 ++
.gitlab-ci.yml| 30 +++
tests/docker
65 matches
Mail list logo
