Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/3] s390x: use a QEMU-style typedef + name for SIGP save area struct

2019-02-22 Thread Christian Borntraeger
On 22.02.2019 09:11, David Hildenbrand wrote: > Convert this to QEMU style. > > Signed-off-by: David Hildenbrand Acked-by: Christian Borntraeger > --- > target/s390x/helper.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target

Re: [Qemu-devel] [PATCH v1 1/3] s390x: Use cpu_to_be64 in SIGP STORE ADDITIONAL STATUS

2019-02-22 Thread Christian Borntraeger
s sane. Reviewed-by: Christian Borntraeger > --- > target/s390x/helper.c | 31 +-- > 1 file changed, 21 insertions(+), 10 deletions(-) > > diff --git a/target/s390x/helper.c b/target/s390x/helper.c > index 3d74836a83..f3fcf96482 100644 > --- a/t

Re: [Qemu-devel] [PATCH v3] s390x/cpumodel: Set up CPU model for AQIC interception

2019-02-15 Thread Christian Borntraeger
On 15.02.2019 10:53, Pierre Morel wrote: > On 14/02/2019 13:14, Pierre Morel wrote: >> A new CPU model facilities is introduced to support AP devices >> interruption interception for a KVM guest. >> >> "APQI" for "AP-Queue Interruption" facility >> >> The S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, CP

Re: [Qemu-devel] [PATCH v3 8/8] RFC iotests: Disable 236 and 238 on OpenBSD

2019-02-13 Thread Christian Borntraeger
FWIW 238 also fails on my s390 box: qemu-iotests]$ ./check -qcow2 238 QEMU -- "/home/cborntra/REPOS/qemu/build/tests/qemu-iotests/../../s390x-softmmu/qemu-system-s390x" -nodefaults -machine accel=qtest QEMU_IMG -- "/home/cborntra/REPOS/qemu/build/tests/qemu-iotests/../../qemu-img"

Re: [Qemu-devel] [PATCH] s390x: upgrade status of KVM cores to "supported"

2019-02-13 Thread Christian Borntraeger
On 13.02.2019 11:35, Cornelia Huck wrote: > We are actually paid to look after this. > > Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINE

Re: [Qemu-devel] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init

2019-02-12 Thread Christian Borntraeger
FEAT_GROUP_INIT for mepochptff down > the s390_feature_groups list so it can be properly indexed with its > generated S390FeatGroup enum. > > Signed-off-by: Collin Walling Looks sane. Reviewed-by: Christian Borntraeger > --- > target/s390x/cpu_features.c | 2 +- > target/

Re: [Qemu-devel] [PATCH] s390x: always provide pci support

2019-02-11 Thread Christian Borntraeger
ncluding compat > handling for older machines etc.) for non-obvious gains, let's > just make CONFIG_PCI something that is always set on s390x. > > Note that you can still fence off pci for the _guest_ if you > provide a cpu model without the zpci feature. > > Signed-off-by: Cornel

Re: [Qemu-devel] [PATCH 1/2] s390x/cpumodel: default enable mepoch for z14 and later

2019-02-11 Thread Christian Borntraeger
On 11.02.2019 09:23, Cornelia Huck wrote: > On Fri, 8 Feb 2019 17:11:10 -0500 > Collin Walling wrote: > >> Latest systems and host kernels support mepoch, which is a >> feature that was meant to be supported for z14 GA1 from the >> get-go. Let's copy it to the z14 GA1 default CPU model. > >

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/2] s390x/cpumodel: add z14 GA2 model

2019-02-11 Thread Christian Borntraeger
On 08.02.2019 23:11, Collin Walling wrote: > Introduce the z14 GA2 cpu model for QEMU. There are no new features > introduced with this model, and will inherit the same feature set as > z14 GA1. > > Signed-off-by: Collin Walling Acked-by: Christian Borntraeger > -

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/2] s390x/cpumodel: default enable mepoch for z14 and later

2019-02-11 Thread Christian Borntraeger
l retain the old CPU > models and will not provide this bit in the default model. > > Signed-off-by: Collin Walling Yes, we missed that back then for the intial z14 version as the kernel and qemu parts were added later. Reviewed-by: Christian Borntraeger > --- > hw/s390x/s390-

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x: Fix the confusing contributions-after-2012 license statements

2019-02-06 Thread Christian Borntraeger
nfusing statements and use the proper GPL > text only. For the IBM-provided parts GPLv2+ is fine. Acked-by: Christian Borntraeger > > Signed-off-by: Thomas Huth > --- > linux-user/s390x/target_cpu.h | 19 --- > target/s390x/cpu.c| 19

Re: [Qemu-devel] [qemu-s390x] [PATCH v1] s390x/pci: Warn when adding PCI devices without the 'zpci' feature

2019-02-04 Thread Christian Borntraeger
On 22.01.2019 16:11, David Hildenbrand wrote: > On 22.01.19 16:03, Christian Borntraeger wrote: >> >> >> On 22.01.2019 13:52, David Hildenbrand wrote: >>> On 22.01.19 13:44, Cornelia Huck wrote: >>>> On Tue, 22 Jan 2019 10:41:43 +0100 >>>&

Re: [Qemu-devel] [PATCH] s390x: remove direct reference to mem_path global form s90x code

2019-01-25 Thread Christian Borntraeger
On 25.01.2019 11:40, Igor Mammedov wrote: > On Fri, 25 Jan 2019 09:03:49 +0100 > David Hildenbrand wrote: > >> On 24.01.19 17:57, Igor Mammedov wrote: >>> I plan to deprecate -mem-path option and replace it with memory-backend, >>> for that it's necessary to get rid of mem_path global variable

Re: [Qemu-devel] [PATCH v2 2/3] s390: cpu feature for diagnose 318 andlimit max VCPUs to 247

2019-01-24 Thread Christian Borntraeger
On 06.12.2018 23:24, Collin Walling wrote: > Diagnose 318 is a new z14.2 CPU feature. Since we are able to emulate > it entirely via KVM, we can add guest support for earlier models. A > new CPU feature for diagnose 318 (shortened to diag318) will be made > available to guests starting with the

Re: [Qemu-devel] [PATCH v1] s390x/pci: Warn when adding PCI devices without the 'zpci' feature

2019-01-22 Thread Christian Borntraeger
On 22.01.2019 13:52, David Hildenbrand wrote: > On 22.01.19 13:44, Cornelia Huck wrote: >> On Tue, 22 Jan 2019 10:41:43 +0100 >> David Hildenbrand wrote: >> >>> We decided to always create the PCI host bridge, even if 'zpci' is not >>> enabled (due to migration compatibility). This however righ

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] configure: Only build the s390-ccw bios if the compiler supports -march=z900

2019-01-15 Thread Christian Borntraeger
390-ccw bios. Thus add a proper test > to the configure script to see whether the compiler is usable. > > Signed-off-by: Thomas Huth Acked-by: Christian Borntraeger > --- > v2: Use compile_prog as suggested by Peter > > configure | 6 +- > 1 file changed, 5 in

Re: [Qemu-devel] [PATCH 2/2] s390x: Return specification exception for unimplemented diag 308 subcodes

2019-01-11 Thread Christian Borntraeger
gt; might call new subcodes to check for new features. This should not > trigger a hw error, instead we return the architectured specification > exception. > > Signed-off-by: Janosch Frank > Cc: qemu-sta...@nongnu.org Yes, PIC06 is definitively the right thing to do. R

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Use proper register names for Clang

2019-01-10 Thread Christian Borntraeger
^ > pc-bios/s390-ccw/start.S:79:12: error: invalid operand for instruction > br 14 >^ > > Let's use proper register names like in the rest of this file to fix it. Sad that this does no longer work, but Reviewed-by: Christian Borntraeger > &g

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Christian Borntraeger
On 14.12.2018 14:23, Thomas Huth wrote: > On 2018-12-14 14:15, Christian Borntraeger wrote: >> >> >> On 14.12.2018 14:08, Thomas Huth wrote: >>> The time2tod() function tries to deal with the 9 uppermost bits in the >>> time value, but uses the wrong m

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Christian Borntraeger
On 14.12.2018 14:08, Thomas Huth wrote: > The time2tod() function tries to deal with the 9 uppermost bits in the > time value, but uses the wrong mask for this: 0xff80 should > be used instead of 0xff10 here. > > Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd Can you a

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-07 Thread Christian Borntraeger
On 07.12.2018 13:29, Cornelia Huck wrote: > On Fri, 7 Dec 2018 13:17:02 +0100 > Christian Borntraeger wrote: > >> On 05.12.2018 15:51, Cornelia Huck wrote: >>> vfio-ap devices do not pin any pages in the host. Therefore, they >>> are belived to be

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-07 Thread Christian Borntraeger
On 05.12.2018 15:51, Cornelia Huck wrote: > vfio-ap devices do not pin any pages in the host. Therefore, they > are belived to be compatible with memory ballooning. > > Flag them as compatible, so both vfio-ap and a balloon can be > used simultaneously. > > Signed-off-by: Cornelia Huck Does it

Re: [Qemu-devel] [qemu-s390x] [PULL 2/2] iotests: simple mirror test with kvm on 1G image

2018-12-06 Thread Christian Borntraeger
On 05.12.2018 17:09, Vladimir Sementsov-Ogievskiy wrote: > 05.12.2018 18:52, Christian Borntraeger wrote: >> >> >> On 05.12.2018 14:39, Vladimir Sementsov-Ogievskiy wrote: >>> 05.12.2018 15:35, Christian Borntraeger wrote: >>>> >>>> >&g

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-05 Thread Christian Borntraeger
On 05.12.2018 17:45, Cornelia Huck wrote: > On Wed, 5 Dec 2018 17:38:22 +0100 > David Hildenbrand wrote: > >> On 05.12.18 15:51, Cornelia Huck wrote: >>> vfio-ap devices do not pin any pages in the host. Therefore, they >>> are belived to be compatible with memory ballooning. >>> >>> Flag them

Re: [Qemu-devel] [qemu-s390x] [PULL 2/2] iotests: simple mirror test with kvm on 1G image

2018-12-05 Thread Christian Borntraeger
On 05.12.2018 17:09, Vladimir Sementsov-Ogievskiy wrote: > 05.12.2018 18:52, Christian Borntraeger wrote: >> >> >> On 05.12.2018 14:39, Vladimir Sementsov-Ogievskiy wrote: >>> 05.12.2018 15:35, Christian Borntraeger wrote: >>>> >>>> >&g

Re: [Qemu-devel] [PATCH RFC] vfio-ap: flag as compatible with balloon

2018-12-05 Thread Christian Borntraeger
off-by: Cornelia Huck > --- > > As briefly discussed on IRC. RFC as I do not have easy access to > hardware I can test this with. Acked-by: Christian Borntraeger vfio-ap is based on the SIE support for AP, which transparently handles host paging. S390_AP_IOMMU has an empty iommu_ops

Re: [Qemu-devel] [qemu-s390x] [PULL 2/2] iotests: simple mirror test with kvm on 1G image

2018-12-05 Thread Christian Borntraeger
On 05.12.2018 14:39, Vladimir Sementsov-Ogievskiy wrote: > 05.12.2018 15:35, Christian Borntraeger wrote: >> >> >> On 05.12.2018 13:00, Vladimir Sementsov-Ogievskiy wrote: >>> 05.12.2018 12:01, Christian Borntraeger wrote: >>>> >>>>

Re: [Qemu-devel] [qemu-s390x] [PULL 2/2] iotests: simple mirror test with kvm on 1G image

2018-12-05 Thread Christian Borntraeger
On 05.12.2018 13:00, Vladimir Sementsov-Ogievskiy wrote: > 05.12.2018 12:01, Christian Borntraeger wrote: >> >> >> On 05.12.2018 09:46, Kevin Wolf wrote: >>> Am 05.12.2018 um 09:23 hat Christian Borntraeger geschrieben: >>>>>>> +

Re: [Qemu-devel] [qemu-s390x] [PULL 2/2] iotests: simple mirror test with kvm on 1G image

2018-12-05 Thread Christian Borntraeger
On 05.12.2018 09:46, Kevin Wolf wrote: > Am 05.12.2018 um 09:23 hat Christian Borntraeger geschrieben: >>>>> +# prepare source image >>>>> +qemu_img_create('-f', iotests.imgfmt, '-o', 'preallocation=metadata', >>>&g

[Qemu-devel] [PATCH 1/1] iotests: make 235 work on s390 (and others)

2018-12-05 Thread Christian Borntraeger
"-machine pc" will not work all architectures. Lets fall back to the default machine by not specifying it. In addition we also need to specify -no-shutdown on s390 as qemu will exit otherwise. Signed-off-by: Christian Borntraeger --- tests/qemu-iotests/235 | 4 +++- 1 file

Re: [Qemu-devel] [PATCH v1] s390: guest support for diagnose 318 and limit max VCPUs to 247

2018-12-05 Thread Christian Borntraeger
You should clearly review your email list. Adding the "new" Conny, removing Carsten. On 04.12.2018 23:18, Collin Walling wrote: > Add migration and reset support for diagnose 318. This is a new z14 GA2 > hardware feature, but we can provide guest support starting with the > zEC12-full CPU

Re: [Qemu-devel] [PATCH v1] s390: guest support for diagnose 318 and limit max VCPUs to 247

2018-12-05 Thread Christian Borntraeger
On 05.12.2018 09:26, David Hildenbrand wrote: > On 04.12.18 23:18, Collin Walling wrote: >> Add migration and reset support for diagnose 318. This is a new z14 GA2 >> hardware feature, but we can provide guest support starting with the >> zEC12-full CPU model. >> >> Because new hardware introdu

Re: [Qemu-devel] [qemu-s390x] [PULL 2/2] iotests: simple mirror test with kvm on 1G image

2018-12-05 Thread Christian Borntraeger
On 04.12.2018 14:49, Christian Borntraeger wrote: > > > On 04.12.2018 14:46, Christian Borntraeger wrote: >> FWIW, this testcase fails with current qemu master on s390: >> >> QEMU -- >> "/home/cborntra/REPOS/qemu/build/tests/qemu-iotests

Re: [Qemu-devel] [for-4.0 PATCH v3.1 8/9] q35/440fx/arm/spapr/ccw: Add QEMU 4.0 machine type

2018-12-04 Thread Christian Borntraeger
On 04.12.2018 20:56, Alex Williamson wrote: > On Tue, 4 Dec 2018 19:29:25 + > Peter Maydell wrote: > >> On Tue, 4 Dec 2018 at 19:26, Alex Williamson >> wrote: >>> >>> On Tue, 4 Dec 2018 20:16:44 +0100 >>> Christian Borntraeger wrote: >

Re: [Qemu-devel] [for-4.0 PATCH v3.1 8/9] q35/440fx/arm/spapr/ccw: Add QEMU 4.0 machine type

2018-12-04 Thread Christian Borntraeger
n > Cc: Marcel Apfelbaum > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: David Hildenbrand > Cc: Cornelia Huck > Cc: Christian Borntraeger > Acked-by: David Gibson > Signed-off-by: Alex Williamson > --- > > Re-spinning just this

[Qemu-devel] [PATCH] s390/MAINTAINERS: Add Halil as kvm and machine maintainer

2018-12-04 Thread Christian Borntraeger
Halil does more work in this area than I do right now. Lets add Halil. Signed-off-by: Christian Borntraeger --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 63effdc473..76fbf1331a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[Qemu-devel] [PATCH v3] s390x/tod: Properly stop the KVM TOD while the guest is not running

2018-12-04 Thread Christian Borntraeger
ly on all clocks to be in sync. For example the dasd I/O will also write time stamps and in an stp complex (synced time across CECs) this can be useful for "classic" mainframe databases and ordering. It is probably the right thing to do as of today as on migration we are also out of sy

Re: [Qemu-devel] [qemu-s390x] [PATCH v3] s390x/tod: Properly stop the KVM TOD while the guest is not running

2018-11-30 Thread Christian Borntraeger
On 30.11.2018 10:49, David Hildenbrand wrote: > Just like on other architectures, we should stop the clock while the guest > is not running. This is already properly done for TCG. Right now, doing an > offline migration (stop, migrate, cont) can easily trigger stalls in the > guest. > > Even do

Re: [Qemu-devel] [PATCH v1] s390x/tod: properly stop the KVM TOD while the guest is not running

2018-11-27 Thread Christian Borntraeger
On 27.11.2018 14:06, Thomas Huth wrote: > On 2018-11-27 13:43, Christian Borntraeger wrote: >> On 27.11.2018 12:41, David Hildenbrand wrote: >>> Just like on other architectures, we should stop the clock while the guest >>> is not running. This is already properly don

Re: [Qemu-devel] [PATCH v1] s390x/tod: properly stop the KVM TOD while the guest is not running

2018-11-27 Thread Christian Borntraeger
On 27.11.2018 12:41, David Hildenbrand wrote: > Just like on other architectures, we should stop the clock while the guest > is not running. This is already properly done for TCG. Right now, doing an > offline migration (stop, migrate, cont) can easily trigger stalls in the > guest. > > Even doing

Re: [Qemu-devel] [PATCH] vmstate: constify VMStateField

2018-11-14 Thread Christian Borntraeger
On 11/14/2018 05:56 PM, Thomas Huth wrote: > On 2018-11-14 17:49, Peter Maydell wrote: >> On 14 November 2018 at 16:39, Philippe Mathieu-Daudé >> wrote: >>> Hi Thomas, >>> >>> On 14/11/18 17:29, Thomas Huth wrote: Please don't. For rationale, see: https://www.kernel.org/doc/html/v4.1

Re: [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge

2018-11-05 Thread Christian Borntraeger
On 11/05/2018 12:37 PM, David Hildenbrand wrote: > On 05.11.18 12:21, Cornelia Huck wrote: >> On Mon, 5 Nov 2018 12:03:11 +0100 >> David Hildenbrand wrote: >> >>> We directly have it in our hands. >>> >>> Signed-off-by: David Hildenbrand >>> --- >>> hw/s390x/s390-pci-bus.c | 4 ++-- >>> 1 fi

[Qemu-devel] [PATCH 2/4] MAINTAINERS: s390/virtio-ccw: drop Christian add Halil

2018-10-29 Thread Christian Borntraeger
Halil does all the work anyway. Signed-off-by: Christian Borntraeger --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 10045b6..cb23555 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1262,7 +1262,7 @@ T: git git://github.com

[Qemu-devel] [PATCH 3/4] MAINTAINERS: s390/pci: add Collin Walling as maintainer for zpci

2018-10-29 Thread Christian Borntraeger
Collin will take over the maintainership from Yi Min. Let us add a separate s390 pci section. Signed-off-by: Christian Borntraeger --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cb23555..e63cfa2 100644 --- a/MAINTAINERS +++ b

[Qemu-devel] [PATCH 4/4] MAINTAINERS: s390/boot: the ipl code and the bios belong together

2018-10-29 Thread Christian Borntraeger
The s390-ccw bios and the ipl code do work in lock-step. Let us merge them in the maintainer file. Signed-off-by: Christian Borntraeger --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e63cfa2..8ce223d 100644 --- a/MAINTAINERS

[Qemu-devel] [PATCH 1/4] MAINTAINERS: s390: more maintainers for vfio-ccw

2018-10-29 Thread Christian Borntraeger
Eric and Farhan will help with maintaining vfio-ccw. Signed-off-by: Christian Borntraeger --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d794bd7..10045b6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1204,6 +1204,8 @@ F: include/hw/vfio

[Qemu-devel] [PATCH 0/4] MAINTAINERS: s390: several updates

2018-10-29 Thread Christian Borntraeger
I discussed the following maintainer updates at the kvm forum with Conny. This is the first set of changes. Can the affected persons please Ack the relevant patches? PS: Alex, do you still want to be listed? Christian Borntraeger (4): MAINTAINERS: s390: more maintainers for vfio-ccw

[Qemu-devel] KVM Forum 2018 BoF Meeting minutes - architecture common code

2018-10-29 Thread Christian Borntraeger
Participants: Christopher Dall, Marc Zyngier, Paolo Bonzini, Suraj Jitindar Singh, Frediano Ziglio, Sean Christopherson, Radim Krcmar, Janosch Frank, Christian Borntraeger +some more - Discussion about common code for different architectures - initiated by my talk https://schd.ws/hosted_files

Re: [Qemu-devel] [libvirt] [PATCH 3/3] cirrus: mark as deprecated

2018-10-26 Thread Christian Borntraeger
On 10/26/2018 11:42 AM, Daniel P. Berrangé wrote: > On Fri, Oct 26, 2018 at 12:33:55PM +0530, P J P wrote: >> Hello Dan, all >> >> +-- On Thu, 25 Oct 2018, Daniel P. Berrangé wrote --+ >> | On Thu, Oct 25, 2018 at 10:52:56AM +0200, Gerd Hoffmann wrote: >> | > While being at it deprecate cirrus

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: report correct error

2018-10-16 Thread Christian Borntraeger
es sense Reviewed-by: Christian Borntraeger > --- > hw/vfio/ap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index 3962bb74e5..65de952f44 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -142,7 +142,7 @@ static

Re: [Qemu-devel] [RFC] Require Python 3 for building QEMU

2018-10-15 Thread Christian Borntraeger
On 10/15/2018 08:33 PM, Eduardo Habkost wrote: > On Mon, Oct 15, 2018 at 08:19:18PM +0200, Christian Borntraeger wrote: [...] >>>> >>>> It's easier to port stuff to Python 3 though than making them work with >>>> both. I think Eduardo's RFC i

Re: [Qemu-devel] [RFC] Require Python 3 for building QEMU

2018-10-15 Thread Christian Borntraeger
On 10/15/2018 06:33 PM, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 15.10.2018 um 12:02 hat Peter Maydell geschrieben: >>> On 15 October 2018 at 10:32, Daniel P. Berrangé wrote: On Sat, Oct 13, 2018 at 02:02:27AM -0300, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkos

Re: [Qemu-devel] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

2018-10-11 Thread Christian Borntraeger
On 10/11/2018 11:48 AM, Cornelia Huck wrote: > On Wed, 10 Oct 2018 20:15:55 +0200 > Christian Borntraeger wrote: > >> On 10/10/2018 07:03 PM, Tony Krowiak wrote: >>> This patch series is the QEMU counterpart to the KVM/kernel support for >>> guest dedicate

Re: [Qemu-devel] [PATCH v11 0/6] s390x: vfio-ap: guest dedicated crypto adapters

2018-10-10 Thread Christian Borntraeger
On 10/10/2018 07:03 PM, Tony Krowiak wrote: > This patch series is the QEMU counterpart to the KVM/kernel support for > guest dedicated crypto adapters. The KVM/kernel model is built on the > VFIO mediated device framework and provides the infrastructure for > granting exclusive guest access t

Re: [Qemu-devel] [PATCH v10 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-10 Thread Christian Borntraeger
t_device(VFIOAPDevice *vapdev) > >  static VFIOGroup *vfio_ap_get_group(VFIOAPDevice *vapdev, Error **errp) >  { > -    GError *gerror; > +    GError *gerror = NULL; > char *symlink, *group_path; > int groupid; With that fix, series Tested-by: Christian Borntraeger Tony, can you fold that fixup from Pierre into your v11?

Re: [Qemu-devel] [qemu-s390x] [PATCH v10 2/6] s390x/cpumodel: Set up CPU model for AP device support

2018-10-10 Thread Christian Borntraeger
On 10/10/2018 10:11 AM, Cornelia Huck wrote: > On Tue, 9 Oct 2018 13:52:22 -0400 > Tony Krowiak wrote: > > (...) > >> Signed-off-by: Tony Krowiak > > This patch (and the others) have a mismatch between the author (address > with vnet), and the s-o-b (address without vnet). While these are

Re: [Qemu-devel] [qemu-s390x] [PATCH v10 3/6] s390x/kvm: enable AP instruction interpretation for guest

2018-10-10 Thread Christian Borntraeger
the AP instructions executed on the guest must be > intercepted; so when the device is realized, it must disable > interpretation. > > Signed-off-by: Tony Krowiak > Tested-by: Pierre Morel Reviewed-by: Christian Borntraeger > --- > target/s390x/kvm.c | 19 ++

Re: [Qemu-devel] [PATCH v10 2/6] s390x/cpumodel: Set up CPU model for AP device support

2018-10-09 Thread Christian Borntraeger
f APFT is installed >on the host. > > Signed-off-by: Tony Krowiak > Tested-by: Pierre Morel Reviewed-by: Christian Borntraeger and as you have moved the one hunk, Davids RB should still count. > --- > target/s390x/cpu_features.c | 3 +++ > target/s390x/cp

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-12 Thread Christian Borntraeger
On 09/13/2018 08:29 AM, Christian Borntraeger wrote: >>> +++ b/hw/s390x/ap-bridge.c >> [...] >>> +void s390_init_ap(void) >>> +{ >>> +DeviceState *dev; >>> + >>> +/* Create bridge device */ >>> +dev =

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-09-12 Thread Christian Borntraeger
On 09/13/2018 07:48 AM, Thomas Huth wrote: > On 2018-09-12 22:08, Tony Krowiak wrote: >> From: Tony Krowiak >> >> Introduces the base object model for virtualizing AP devices. >> >> Signed-off-by: Tony Krowiak >> --- > [...] >> diff --git a/hw/s390x/ap-bridge.c b/hw/s390x/ap-bridge.c >> new fi

Re: [Qemu-devel] [RFD] [s390x] Tweaking the s390x maintainership setup

2018-08-27 Thread Christian Borntraeger
On 08/24/2018 01:37 PM, Cornelia Huck wrote: > Hi all, > > while I think the current s390x maintainership setup is working quite > well, there's probably still room for improvement. In particular, I'd > like to spread out the work a bit more and make it easy to test things > pre-integration in

Re: [Qemu-devel] [PATCH] postcopy: Synchronize usage of the balloon inhibitor

2018-08-23 Thread Christian Borntraeger
it > one vote overall, using the same last-caller-wins approach as previously > implemented at the balloon level. > > Reported-by: Christian Borntraeger > Fixes: 01ccbec7bdf6 ("balloon: Allow multiple inhibit users") This make qemu iotest 169 working again. Tested-by: C

Re: [Qemu-devel] [PULL 1/4] balloon: Allow multiple inhibit users

2018-08-22 Thread Christian Borntraeger
This breaks qemu-io test for me. #0 0x03ff98f3e2d4 in raise () at /lib64/libc.so.6 #1 0x03ff98f239a8 in abort () at /lib64/libc.so.6 #2 0x03ff98f3632e in __assert_fail_base () at /lib64/libc.so.6 #3 0x03ff98f363ac in () at /lib64/libc.so.6 #4 0x0108301a in qemu_balloo

Re: [Qemu-devel] [PATCH 0/2] etoken patch for 3.1

2018-07-31 Thread Christian Borntraeger
On 07/31/2018 01:29 PM, Cornelia Huck wrote: > On Tue, 31 Jul 2018 11:04:46 +0200 > Christian Borntraeger wrote: > >> this depends on the current kvms390/next kernel tree. >> >> Christian Borntraeger (2): >> header sync >> s390x/kvm: add etoken facil

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread Christian Borntraeger
On 07/31/2018 11:37 AM, Cornelia Huck wrote: > On Tue, 31 Jul 2018 11:04:48 +0200 > Christian Borntraeger wrote: > >> Provide the etoken facility. We need to handle cpu model, migration and >> clear reset. >> >> Signed-off-by: Christian Borntr

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread Christian Borntraeger
On 07/31/2018 11:44 AM, Cornelia Huck wrote: > On Tue, 31 Jul 2018 11:04:48 +0200 > Christian Borntraeger wrote: > >> Provide the etoken facility. We need to handle cpu model, migration and >> clear reset. > ^^^ Clear reset is the "strong one&quo

[Qemu-devel] [PATCH 1/2] header sync

2018-07-31 Thread Christian Borntraeger
-> place holder for proper header sync. Signed-off-by: Christian Borntraeger --- linux-headers/asm-s390/kvm.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 11def14301..1ab9901911 100644 --- a/li

[Qemu-devel] [PATCH 0/2] etoken patch for 3.1

2018-07-31 Thread Christian Borntraeger
this depends on the current kvms390/next kernel tree. Christian Borntraeger (2): header sync s390x/kvm: add etoken facility linux-headers/asm-s390/kvm.h| 5 - target/s390x/cpu.h | 3 +++ target/s390x/cpu_features.c | 3 ++- target/s390x/cpu_features_def.h | 3

[Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread Christian Borntraeger
Provide the etoken facility. We need to handle cpu model, migration and clear reset. Signed-off-by: Christian Borntraeger Acked-by: Janosch Frank --- target/s390x/cpu.h | 3 +++ target/s390x/cpu_features.c | 3 ++- target/s390x/cpu_features_def.h | 3 ++- target/s390x/gen

Re: [Qemu-devel] [PATCH 1/1] s390x/sclp: fix maxram calculation

2018-07-30 Thread Christian Borntraeger
Are we still able to get things into 2.12.1 or are we too late? On 07/30/2018 04:09 PM, Christian Borntraeger wrote: > We clamp down ram_size to match the sclp increment size. We do > not do the same for maxram_size, which means for large guests > with some sizes (e.g. -m 5) ma

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] s390x/sclp: fix maxram calculation

2018-07-30 Thread Christian Borntraeger
On 07/30/2018 05:17 PM, David Hildenbrand wrote: > On 30.07.2018 17:00, Christian Borntraeger wrote: >> >> >> On 07/30/2018 04:34 PM, David Hildenbrand wrote: >>> On 30.07.2018 16:09, Christian Borntraeger wrote: >>>> We clamp down ram_size to match

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] s390x/sclp: fix maxram calculation

2018-07-30 Thread Christian Borntraeger
On 07/30/2018 04:34 PM, David Hildenbrand wrote: > On 30.07.2018 16:09, Christian Borntraeger wrote: >> We clamp down ram_size to match the sclp increment size. We do >> not do the same for maxram_size, which means for large guests >> with some sizes (e.g. -m 5) max

[Qemu-devel] [PATCH 1/1] s390x/sclp: fix maxram calculation

2018-07-30 Thread Christian Borntraeger
and then throws some errors. Fixes: 82fab5c5b90e468f3e9d54c ("s390x/sclp: remove memory hotplug support") Signed-off-by: Christian Borntraeger CC: qemu-sta...@nongnu.org CC: David Hildenbrand --- hw/s390x/sclp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/s390x/sclp.c b/hw/s3

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: enum type S390FeatGroup now gets generated

2018-07-25 Thread Christian Borntraeger
Acked-by Christian Borntraeger A quick test seems to indicate that everything is good. On 07/25/2018 04:36 PM, Michael Mueller wrote: > The enumeration type S390FeatGroup is now generated as well. > This shall simplify the definition of new feature groups > without the requirement

Re: [Qemu-devel] [PATCH for-3.1 00/10] Move virtio-ccw devices to separate files

2018-07-25 Thread Christian Borntraeger
Are you planning to do a similar thing for virtio-pci? I think it would be good to keep virtio-ccw similar to virtio-pci when it makes sense. On 07/25/2018 02:20 PM, Thomas Huth wrote: > For more fine-grained control over the build process, it would be good > to have the possibility to disable sin

Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option

2018-07-24 Thread Christian Borntraeger
Acked-by: Christian Borntraeger On 07/24/2018 11:24 AM, Cornelia Huck wrote: > This option has been deprecated for two releases; remove it. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/3270-ccw.c| 2 +- > hw/s390x/css-bridge.c | 1 -

Re: [Qemu-devel] [qemu-s390x] [BUG?] aio_get_linux_aio: Assertion `ctx->linux_aio' failed

2018-07-18 Thread Christian Borntraeger
On 07/18/2018 08:52 PM, Nishanth Aravamudan wrote: > On 18.07.2018 [11:10:27 -0400], Farhan Ali wrote: >> >> >> On 07/18/2018 09:42 AM, Farhan Ali wrote: >>> >>> >>> On 07/17/2018 04:52 PM, Nishanth Aravamudan wrote: iiuc, this possibly implies AIO was not actually used previously on this >

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Christian Borntraeger
t;name": "z14-base", "props": {"esan3" : false}}, > "modelb": { "name": "z14"}} } > > Instead of segfaulting. > > Signed-off-by: David Hildenbrand Acked-by: Christian Borntraeger > --- > tar

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Christian Borntraeger
On 07/18/2018 10:40 AM, David Hildenbrand wrote: > On 18.07.2018 10:39, Christian Borntraeger wrote: >> >> >> On 07/18/2018 10:24 AM, David Hildenbrand wrote: >>> Usually, when baselining two CPU models, whereby one of them has base >>> CPU features disabl

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Christian Borntraeger
On 07/18/2018 10:24 AM, David Hildenbrand wrote: > Usually, when baselining two CPU models, whereby one of them has base > CPU features disabled (e.g. z14-base,msa=off), we fallback to an older > model that did not have these features in the base model. We always try to > create a "sane" CPU mod

Re: [Qemu-devel] [RFC 05/15] s390-bios: Factor finding boot device out of virtio code path

2018-07-09 Thread Christian Borntraeger
On 07/05/2018 07:25 PM, Jason J. Herne wrote: [...] > -IPL_assert(found, "No virtio device found"); Can you also change the boot-serial testcase: this seems to work: diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c index 952a2e7ead..b03b55d182 100644 --- a/tests/boot-serial

Re: [Qemu-devel] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs

2018-07-09 Thread Christian Borntraeger
On 07/05/2018 07:25 PM, Jason J. Herne wrote: Instead of doing this > +void await_io_int(uint16_t sch_no) > +{ > +/* > + * wait_psw and ctl6 must be static to avoid stack allocation as gcc > cannot > + * align stack variables. The stctg, lctlg and lpswe instructions require > +

Re: [Qemu-devel] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs

2018-07-09 Thread Christian Borntraeger
On 07/05/2018 07:25 PM, Jason J. Herne wrote: > From: "Jason J. Herne" > +void await_io_int(uint16_t sch_no) > +{ > +/* > + * wait_psw and ctl6 must be static to avoid stack allocation as gcc > cannot > + * align stack variables. The stctg, lctlg and lpswe instructions require > +

Re: [Qemu-devel] [qemu-s390x] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs

2018-07-06 Thread Christian Borntraeger
On 07/06/2018 09:04 AM, Christian Borntraeger wrote: > > > On 07/05/2018 07:25 PM, Jason J. Herne wrote: >> From: "Jason J. Herne" >> >> Add struct for format-0 ccws. Support executing format-0 channel >> programs and waiting for their completion b

Re: [Qemu-devel] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs

2018-07-06 Thread Christian Borntraeger
On 07/05/2018 07:25 PM, Jason J. Herne wrote: > From: "Jason J. Herne" > > Add struct for format-0 ccws. Support executing format-0 channel > programs and waiting for their completion before continuing execution. > This will be used for real dasd ipl. > > Add cu_type() to channel io library.

Re: [Qemu-devel] [RFC 07/15] s390-bios: Decouple channel i/o logic from virtio

2018-07-05 Thread Christian Borntraeger
On 07/05/2018 07:25 PM, Jason J. Herne wrote: > From: "Jason J. Herne" > > Create a separate library for channel i/o related code. This decouples > channel i/o operations from virtio and allows us to make use of them for > the real dasd boot path. > > Signed-off-by: Jason J. Herne > Signed-o

Re: [Qemu-devel] [RFC 08/15] s390-bios: Map low core memory

2018-07-05 Thread Christian Borntraeger
On 07/05/2018 07:25 PM, Jason J. Herne wrote: > From: "Jason J. Herne" > > Create a new header for basic architecture specific definitions and add a > mapping of low core memory. This mapping will be used by the real dasd boot > process. > > Signed-off-by: Jason J. Herne > Signed-off-by: Jas

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Christian Borntraeger
On 07/04/2018 03:34 PM, Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: >> On Tue, 3 Jul 2018 13:32:29 +0200 >> Kevin Wolf wrote: >> >> Has serial/gemoetry been fixed meanwhile and will it make it into the >> next release? > > I cannot find an archive

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Christian Borntraeger
On 07/03/2018 01:35 PM, Peter Maydell wrote: > On 3 July 2018 at 12:32, Kevin Wolf wrote: >> Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: >>> Just posted latest version here: >>> >>> https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html >>> >>> It will be in the ne

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Christian Borntraeger
0100, Daniel P. Berrangé wrote: >>>>> On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: >>>>>> Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: >> >> [...] >> >>> >>> Thanks! >>> >>> I'

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/2] s390x/kvm: legacy_s390_alloc() only supports one allocation

2018-06-28 Thread Christian Borntraeger
et's just bail out, as there is no need for supporting it > (legacy handling for z/VM). > > Signed-off-by: David Hildenbrand Reviewed-by: Christian Borntraeger > --- > target/s390x/kvm.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff

[Qemu-devel] [PATCH] s390/cpumodel: default enable bpb and ppa15 for z196 and later

2018-06-26 Thread Christian Borntraeger
z13). Older machine types (e.g. s390-ccw-virtio-2.12) will retain the old value and not provide those bits in the default model. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 2 ++ target/s390x/gen-features.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hw

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-26 Thread Christian Borntraeger
On 06/26/2018 10:29 AM, Cornelia Huck wrote: [...] if (ipl->initrd) { ram_addr_t initrd_offset; would put the command line in no matter what the start address is. >>> >>> I'm for putting that one in (and backporting it to qemu-stable). It's a >>

Re: [Qemu-devel] [PATCH] s390/boot: block uncompressed vmlinux booting attempts

2018-06-26 Thread Christian Borntraeger
> > The check relies on s390 linux entry point ABI definition, which is only > present in bzImage and arch/s390/boot/compressed/vmlinux. > > Signed-off-by: Vasily Gorbik Acked-by: Christian Borntraeger some proposals regarding the wording below.. [...] > + > + sclp_ea

Re: [Qemu-devel] [PATCH v3] loader: Check access size when calling rom_ptr() to avoid crashes

2018-06-25 Thread Christian Borntraeger
y to check the size of the ROM area that we want >> to access, thus let's add a size parameter to the rom_ptr() function >> to avoid these problems. >> >> Signed-off-by: Thomas Huth > > Ping! > > Could anybody please pick this patch up? Qemu-trivial seems to

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 10:49 AM, Cornelia Huck wrote: > On Mon, 25 Jun 2018 10:36:33 +0200 > Vasily Gorbik wrote: > >> This change has been done on purpose. Uncompressed image is not going >> to be bootable any more. In future the decompressor phase would get >> more function (early memory detection as

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 10:05 AM, Cornelia Huck wrote: > On Mon, 25 Jun 2018 09:27:59 +0200 > Christian Borntraeger wrote: > >> Also adding QEMU. >> >> On 06/25/2018 09:10 AM, Christian Borntraeger wrote: >>> >>> >>> On 06/22/2018 09:47 PM, Guenter

Re: [Qemu-devel] [qemu-s390x] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 09:27 AM, Christian Borntraeger wrote: > Also adding QEMU. > > On 06/25/2018 09:10 AM, Christian Borntraeger wrote: >> >> >> On 06/22/2018 09:47 PM, Guenter Roeck wrote: >>> Hi, >>> >>> starting with commit 's390/boot:

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
Also adding QEMU. On 06/25/2018 09:10 AM, Christian Borntraeger wrote: > > > On 06/22/2018 09:47 PM, Guenter Roeck wrote: >> Hi, >> >> starting with commit 's390/boot: make head.S and als.c be part of the >> decompressor only' in -next, s390 immages

Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 05:01 PM, Kevin Wolf wrote: > Am 22.06.2018 um 16:38 hat Christian Borntraeger geschrieben: >> >> >> On 06/22/2018 04:25 PM, Kevin Wolf wrote: >>> Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: >>>> >>>> &

<    2   3   4   5   6   7   8   9   10   11   >