On Wednesday, May 22, 2024 2:54:51 PM CEST Thomas Huth wrote:
> On 16/05/2024 14.03, Gerd Hoffmann wrote:
[...]
> > ALSA Audio backend
> > -M: Gerd Hoffmann
> > R: Christian Schoenebeck
> > S: Odd Fixes
> > F: audio/alsaaudio.c
>
> I'd also sugge
On Wednesday, April 17, 2024 1:16:02 AM CEST Daniel Henrique Barboza wrote:
>
> On 4/16/24 16:54, Michael Tokarev wrote:
> > 27.03.2024 17:20, Daniel Henrique Barboza :
> >> Commit 558f5c42ef gated the local tests with g_test_slow() to skip them
> >> in 'make check'. The reported issue back then
istian Schoenebeck
Tested-by: Thomas Huth
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index 0179b3a394..3c8cd235cf 100644
--- a/tests/qtest/virtio-9p-test.c
Message-Id: <20240327142011.805728-2-dbarb...@ventanamicro.com>
Reviewed-by: Greg Kurz
Reviewed-by: Christian Schoenebeck
Tested-by: Thomas Huth
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 23 +++
1 file changed, 11 insertions(+), 12 deletion
The following changes since commit 5012e522aca161be5c141596c66e5cc6082538a9:
Update version for v9.0.0-rc1 release (2024-03-26 19:46:55 +)
are available in the Git repository at:
https://github.com/cschoenebeck/qemu.git tags/pull-9p-20240329
for you to fetch changes up to
On Wednesday, March 27, 2024 3:20:09 PM CET Daniel Henrique Barboza wrote:
> Hi,
>
> In this new version we took a different approach after the discussions
> we had in [1]. The tests are now untouched, and we're addressing the root
> cause directly: the fact that we have a single temp dir for all
):
> qtest/virtio-9p-test.c: create/remove temp dirs after each test
> qtest/virtio-9p-test.c: remove g_test_slow() gate
>
> tests/qtest/virtio-9p-test.c | 32 +++-
> 1 file changed, 11 insertions(+), 21 deletions(-)
>
>
Awesome!
Revie
On Wednesday, March 27, 2024 12:28:17 PM CET Daniel Henrique Barboza wrote:
> On 3/27/24 07:14, Christian Schoenebeck wrote:
> > On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza wrote:
> >> On 3/27/24 05:47, Christian Schoenebeck wrote:
> >>> On T
On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza wrote:
> On 3/27/24 05:47, Christian Schoenebeck wrote:
> > On Tuesday, March 26, 2024 6:47:17 PM CET Daniel Henrique Barboza wrote:
> >> On 3/26/24 14:05, Greg Kurz wrote:
> >>> On Tue, 26 Mar 20
On Tuesday, March 26, 2024 5:07:16 PM CET Daniel Henrique Barboza wrote:
>
> On 3/26/24 12:55, Greg Kurz wrote:
> > Bom dia Daniel !
>
> Bonne après-midi !
>
> >
> > On Tue, 26 Mar 2024 10:26:03 -0300
> > Daniel Henrique Barboza wrote:
> >
> >> Hi,
> >>
> >> Thomas reported in [1] a problem
On Tuesday, March 26, 2024 6:47:17 PM CET Daniel Henrique Barboza wrote:
> On 3/26/24 14:05, Greg Kurz wrote:
> > On Tue, 26 Mar 2024 10:26:04 -0300
> > Daniel Henrique Barboza wrote:
> >
> >> The local 9p driver in virtio-9p-test.c its temporary dir right at the
> >> start of qos-test (via
systems as
reported here:
https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html
This will need to be investigated and addressed later. Let's go for a
workaround in the meantime : mark the "local" tests as "slow" so that
they aren
After removing a file from the file system, we should still be able to
do I/O on the file if we already had it open before removal.
Signed-off-by: Christian Schoenebeck
---
OK, this was a bit surprising to me. I was expecting this test to fail,
but it works!
tests/qtest/virtio-9p-test.c
thieu-Daudé
> ---
Acked-by: Christian Schoenebeck
> hw/9pfs/9p-synth.c | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c
> index 0ac79a500b..419ea69e3a 100644
> --- a/hw/9pfs/9p-synth.c
&
On Monday, November 6, 2023 7:57:36 AM CET Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
Acked-by: Christian Schoenebeck
> hw/9pfs/virtio-9p-device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/virtio-9p-device.c b
it might make
sense to limit that option to 16 channels as well. I mean anything beyond 16th
channel was a dead channel anyway, right?
Probably a separate battle field though:
Reviewed-by: Christian Schoenebeck
> audio/jackaudio.c | 16 +++-
> 1 file changed, 11 insertions(+), 5
? "out" : "in",
> c->opt->client_name ? c->opt->client_name :
> audio_application_name());
Unrelated, but this could be shortened by Elvis operator BTW:
c->opt->client_name ?: audio_application_name()
Anyway:
Reviewed-by: Christian Schoenebeck
Best regards,
Christian Schoenebeck
g of
> - * dev_t is system dependant, we have to convert them for Linux guests if
> + * dev_t is system dependent, we have to convert them for Linux guests if
> * host is not running Linux.
That particular one is American English vs. British English, but OK, patch
LGTM:
Reviewed-by: C
to 'Maintained'.
Christian Schoenebeck (2):
9pfs: deprecate 'proxy' backend
MAINTAINERS: raise status of 9p to 'Maintained'
MAINTAINERS| 11 +--
docs/about/deprecated.rst | 23
Change status of 9p from 'Odd Fixes' to 'Maintained', as this better
reflects current situation. I already take care of 9p patches for a
while, which included new features as well.
Based-on:
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Reviewed-by: Philippe Mathieu-Daudé
, but now it is time to officially deprecate the 'proxy'
backend.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
MAINTAINERS| 9 -
docs/about/deprecated.rst | 23 +++
docs/tools/virtfs-proxy-helper.rst
On Monday, July 3, 2023 4:50:42 PM CEST Greg Kurz wrote:
> On Mon, 3 Jul 2023 16:34:17 +0200
> Christian Schoenebeck wrote:
>
> > Change status of 9p from 'Odd Fixes' to 'Maintained', as this better
> > reflects current situation. I already take care of 9p patches for a
>
Change status of 9p from 'Odd Fixes' to 'Maintained', as this better
reflects current situation. I already take care of 9p patches for a
while, which included new features as well.
Based-on:
Signed-off-by: Christian Schoenebeck
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On Monday, June 26, 2023 1:49:06 PM CEST Christian Schoenebeck wrote:
> As recent CVE-2023-2861 (fixed by f6b0de53fb) once again showed, the 9p
> 'proxy' fs driver is in bad shape. Using the 'proxy' backend was already
> discouraged for safety reasons before and we recommended to use the
, but now it is time to officially deprecate the 'proxy'
backend.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
---
v4 -> v5:
- Eliminate repititve use of word 'instead' in text.
- Commit log: mention exact commit which fixed CVE-2023-2861.
MAINTAIN
On Monday, June 26, 2023 9:27:35 AM CEST Greg Kurz wrote:
> On Fri, 23 Jun 2023 14:41:15 +0200
> Christian Schoenebeck wrote:
>
> > As recent CVE-2023-2861 once again showed, the 9p 'proxy' fs driver is in
> > bad shape. Using the 'proxy' backend was already discouraged f
to officially deprecate the 'proxy' backend.
Signed-off-by: Christian Schoenebeck
---
v3 -> v4:
- MAINTAINERS: also move virtfs-proxy-helper.rst to 'obsolete' section
- deprecated.rst: suggest virtiofsd as alternative.
- deprecated.rst: mention a considerable future reimplementation of
'pr
of
'proxy' or virtiofs"
And that's probably still ambiguous, becauses that might suggest people that
they could simply s/-virtfs proxy/-virtfs virtiofs/.
Low care rate on my end though.
Best regards,
Christian Schoenebeck
On Wednesday, June 21, 2023 3:46:39 PM CEST Daniel P. Berrangé wrote:
> On Sat, Jun 10, 2023 at 03:39:44PM +0200, Christian Schoenebeck wrote:
> > +``-fsdev proxy`` and ``-virtfs proxy`` (since 8.1)
> > +^^
> > +
> > +
On Wednesday, June 21, 2023 3:41:36 PM CEST Greg Kurz wrote:
> On Wed, 21 Jun 2023 15:32:39 +0200
> Christian Schoenebeck wrote:
>
> > On Thursday, June 15, 2023 11:35:05 AM CEST Christian Schoenebeck wrote:
> > > On Saturday, June 10, 2023 3:39:44 PM CEST Chr
On Thursday, June 15, 2023 11:35:05 AM CEST Christian Schoenebeck wrote:
> On Saturday, June 10, 2023 3:39:44 PM CEST Christian Schoenebeck wrote:
> > As recent CVE-2023-2861 once again showed, the 9p 'proxy' fs driver is in
> > bad shape. Using the 'proxy' backend was alre
On Saturday, June 10, 2023 3:39:44 PM CEST Christian Schoenebeck wrote:
> As recent CVE-2023-2861 once again showed, the 9p 'proxy' fs driver is in
> bad shape. Using the 'proxy' backend was already discouraged for safety
> reasons before and we recommended to use the 'local' backen
-by: Christian Schoenebeck
---
v2 -> v3:
* Fix copy wasted typo (-> 'backend').
MAINTAINERS| 7 +++
docs/about/deprecated.rst | 17 +
docs/tools/virtfs-proxy-helper.rst | 3 +++
fsdev/qemu-fsdev.c | 5 +
fsdev/virtfs
On Saturday, June 10, 2023 1:07:27 PM CEST Christian Schoenebeck wrote:
> As recent CVE-2023-2861 once again showed, the 9p 'proxy' fs driver is in
> bad shape. Using the 'proxy' backend was already discouraged for safety
> reasons before and we recommended to use the 'local' backen
-by: Christian Schoenebeck
---
v1 -> v2:
* Add deprecation notice also to virtfs-proxy-helper.rst,
qemu-options.hx and to the 'proxy' source files
(virtfs-proxy-helper.c, 9p-proxy.c, 9p-proxy.h).
MAINTAINERS| 7 +++
docs/about/deprecated.rst |
-by: Christian Schoenebeck
---
MAINTAINERS | 7 +++
docs/about/deprecated.rst | 17 +
fsdev/qemu-fsdev.c| 5 +
meson.build | 2 +-
softmmu/vl.c | 5 +
5 files changed, 35 insertions(+), 1 deletion(-)
diff --git
.
Christian Schoenebeck (1):
9pfs: prevent opening special files (CVE-2023-2861)
fsdev/virtfs-proxy-helper.c | 27 +--
hw/9pfs/9p-util.h | 39 +++
2 files changed, 64 insertions(+), 2 deletions(-)
on this.
Fixes: CVE-2023-2861
Reported-by: Yanwu Shen
Reported-by: Jietao Xiao
Reported-by: Jinku Li
Reported-by: Wenbo Shen
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Reviewed-by: Michael Tokarev
Message-Id:
---
fsdev/virtfs-proxy-helper.c | 27 +++--
hw
on this.
Fixes: CVE-2023-2861
Reported-by: Yanwu Shen
Reported-by: Jietao Xiao
Reported-by: Jinku Li
Reported-by: Wenbo Shen
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
---
v3 -> v4:
- Rename function check_is_regular_file_or_dir() ->
close_if_special_file() and add de
on this.
Fixes: CVE-2023-2861
Reported-by: Yanwu Shen
Reported-by: Jietao Xiao
Reported-by: Jinku Li
Reported-by: Wenbo Shen
Signed-off-by: Christian Schoenebeck
---
v2 -> v3:
- Drop O_CREAT check and its comment.
- Eliminate code duplication.
fsdev/virtfs-proxy-helper.c |
On Wednesday, June 7, 2023 1:02:17 PM CEST Christian Schoenebeck wrote:
> On Tuesday, June 6, 2023 6:00:28 PM CEST Greg Kurz wrote:
> > Hi Christian,
> >
> > On Tue, 06 Jun 2023 15:57:50 +0200
> > Christian Schoenebeck wrote:
> >
> > > The 9p protoc
On Tuesday, June 6, 2023 8:48:49 PM CEST Michael Tokarev wrote:
> 06.06.2023 16:57, Christian Schoenebeck wrote:
[...]
> > +/* CVE-2023-2861: Prohibit opening any special file directly on host
> > + * (especially device files), as a compromised client could potentially
&
On Tuesday, June 6, 2023 6:00:28 PM CEST Greg Kurz wrote:
> Hi Christian,
>
> On Tue, 06 Jun 2023 15:57:50 +0200
> Christian Schoenebeck wrote:
>
> > The 9p protocol does not specifically define how server shall behave when
> > client tries to open a special file
on this.
Fixes: CVE-2023-2861
Reported-by: Yanwu Shen
Reported-by: Jietao Xiao
Reported-by: Jinku Li
Reported-by: Wenbo Shen
Signed-off-by: Christian Schoenebeck
---
v1 -> v2:
- Add equivalent fix for 'proxy' fs driver.
- Minor adjustments on commit log.
fsdev/virtfs-proxy-helper.c |
merge conflict. ]
Signed-off-by: Christian Schoenebeck
---
meson.build | 12 +---
meson_options.txt | 2 ++
scripts/meson-buildoptions.sh | 4
3 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/meson.build b/meson.build
index 25a4
-by: Stefano Stabellini
Message-Id: <20230502143722.15613-1-jandr...@gmail.com>
[C.S.: - Remove redundant return in xen_9pfs_free().
- Add comment to trace-events. ]
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/trace-events | 6 ++
hw/9pfs/xen-9p-backend.
-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
---
tests/qtest/libqos/virtio-9p-client.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/qtest/libqos/virtio-9p-client.c
b/tests/qtest/libqos/virtio-9p-client.c
index e4a368e036..b8adc8d4b9 100644
--- a/tests/qtest/libqos
.
Christian Schoenebeck (2):
tests/9p: fix potential leak in v9fs_rreaddir()
configure: make clear that VirtFS is 9p
Jason Andryuk (1):
9pfs/xen: Fix segfault on shutdown
Peter Foley (1):
Don't require libcap-ng for virtfs support
hw
Add '9P' to the summary output section of 'VirtFS' to avoid being
confused with virtiofs.
Based-on: <20230503130757.863824-1-pefo...@google.com>
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Reviewed-by: Thomas Huth
Message-Id:
---
meson.build | 4 ++--
1 file chan
On Thursday, May 11, 2023 4:12:34 PM CEST Christian Schoenebeck wrote:
> Add '9P' to the summary output section of 'VirtFS' to avoid being
> confused with virtiofs.
>
> Based-on: <20230503130757.863824-1-pefo...@google.com>
> Signed-off-by: Christian Schoenebeck
>
:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
Best regards,
Christian Schoenebeck
Add '9P' to the summary output section of 'VirtFS' to avoid being
confused with virtiofs.
Based-on: <20230503130757.863824-1-pefo...@google.com>
Signed-off-by: Christian Schoenebeck
---
meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson
Hi Jason,
as this is a Xen specific change, I would like Stefano or another Xen
developer to take a look at it, just few things from my side ...
On Tuesday, May 2, 2023 4:37:22 PM CEST Jason Andryuk wrote:
> xen_9pfs_free can't use gnttabdev since it is already closed and NULL-ed
Where exactly
On Saturday, April 29, 2023 11:25:33 AM CEST Christian Schoenebeck wrote:
> Free allocated directory entries in v9fs_rreaddir() if argument
> `entries` was passed as NULL, to avoid a memory leak. It is
> explicitly allowed by design for `entries` to be NULL. [1]
>
> [1] https://
t; ---
LGTM now, queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
Best regards,
Christian Schoenebeck
> meson.build | 12 +---
> meson_options.txt | 2 ++
> scripts/meson-buildoptions.sh | 4
> 3 files ch
On Saturday, April 29, 2023 2:04:30 PM CEST Greg Kurz wrote:
> Hi Christian !
Hi there, it's been a while! :)
> On Sat, 29 Apr 2023 11:25:33 +0200
> Christian Schoenebeck wrote:
>
> > Free allocated directory entries in v9fs_rreaddir() if argument
> > `entries` was
-by: Christian Schoenebeck
---
tests/qtest/libqos/virtio-9p-client.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/qtest/libqos/virtio-9p-client.c
b/tests/qtest/libqos/virtio-9p-client.c
index e4a368e036..b8adc8d4b9 100644
--- a/tests/qtest/libqos/virtio-9p-client.c
+++ b/tests/qtest
9fs_rreaddir.
>
> Reported by Coverity.
That's an old defects report, right? I remember I saw something like this last
year and ignored it as being purely theoretical.
> Cc: Christian Schoenebeck
> Signed-off-by: Paolo Bonzini
> ---
> tests/qtest/libqos/virtio-9p-client.c
On Friday, April 21, 2023 3:53:27 PM CEST Peter Foley wrote:
> It's only required for the proxy helper.
>
> Signed-off-by: Peter Foley
> ---
> meson.build | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index c44d05a13f..1d4888b1c0
c b/hw/9pfs/9p.c
> index 9621ec1341..9bf502c45f 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -741,12 +741,12 @@ static VariLenAffix affixForIndex(uint64_t index)
> /* creative abuse of tb_hash_func7, which is based on xxhash */
I guess this old comment could be dropped then.
On Friday, March 17, 2023 5:36:37 AM CET Shi, Guohuai wrote:
[...]
> > > > > > +do {
> > > > > > +full_dir_entry = get_full_path_win32(hDir,
> > > > > > + dd_data.name);
> > > > > > +
> > > > > > +if (full_dir_entry == NULL) {
> > > > > > +err = ENOMEM;
> > > > > >
On Wednesday, March 15, 2023 8:05:34 PM CET Shi, Guohuai wrote:
>
> > -Original Message-
> > From: Christian Schoenebeck
> > Sent: Wednesday, March 15, 2023 00:06
> > To: Greg Kurz ; qemu-devel@nongnu.org
> > Cc: Shi, Guohuai ; Meng, Bin
> >
&g
On Monday, February 20, 2023 11:08:03 AM CET Bin Meng wrote:
> From: Guohuai Shi
>
> This commit implements Windows specific xxxdir() APIs for safety
> directory access.
That comment is seriously too short for this patch.
1. You should describe the behaviour implementation that you have chosen
On Monday, March 13, 2023 8:06:15 PM CET Dorinda Bassey wrote:
> >
> > Are you sure about sizeof(n_bytes) here? That's 4. ;-)
> >
> my bad!
>
> >
> > Volker's point was that "silence" is the center of the wave range. With
> > signed
> > range that's zero, yes, but with unsigned range that's
On Monday, March 13, 2023 2:42:36 PM CET BALATON Zoltan wrote:
> On Mon, 13 Mar 2023, Christian Schoenebeck wrote:
> > On Monday, February 27, 2023 12:28:02 PM CET Christian Schoenebeck wrote:
> >> On Tuesday, December 27, 2022 5:15:31 PM CET Christian Schoenebeck wrote:
point was that "silence" is the center of the wave range. With signed
range that's zero, yes, but with unsigned range that's 2^(bitdepth) / 2.
So you need to memset() the correct value to generate "silence".
Best regards,
Christian Schoenebeck
On Monday, February 20, 2023 11:08:15 AM CET Bin Meng wrote:
> From: Guohuai Shi
>
> Enable virtfs configuration option for Windows host.
>
> Signed-off-by: Guohuai Shi
> Signed-off-by: Bin Meng
> ---
>
> meson.build | 10 +-
> fsdev/meson.build | 1 +
>
On Monday, February 27, 2023 12:28:02 PM CET Christian Schoenebeck wrote:
> On Tuesday, December 27, 2022 5:15:31 PM CET Christian Schoenebeck wrote:
> > While mouse is grabbed, window title contains a hint for the user what
> > keyboard keys to press to release the mouse. Make
_t
> offset,
> +int32_t maxsize, bool dostat)
You should probably fix wrapping here, as the line exceeds 80 characters.
Except of that:
Reviewed-by: Christian Schoenebeck
> {
> V9fsState *s = pdu->s;
> V9fsString name;
>
On Monday, March 6, 2023 3:56:49 PM CET Bin Meng wrote:
> On Mon, Mar 6, 2023 at 10:15 PM Christian Schoenebeck
> wrote:
> >
> > On Monday, February 20, 2023 11:07:59 AM CET Bin Meng wrote:
> > > At present there is no Windows support for 9p file system.
> > &
plementation
I didn't have the chance to look at this v5 yet.
In general it would help for review to point out in the cover letter which
patch(es) have changed, what decisions you have made and why.
In this case I guess that's patch 4.
Best regards,
Christian Schoenebeck
> Bin Meng (2):
>
On Tuesday, December 27, 2022 5:15:31 PM CET Christian Schoenebeck wrote:
> While mouse is grabbed, window title contains a hint for the user what
> keyboard keys to press to release the mouse. Make that hint text a bit
> more user friendly for a Mac user:
>
> - Replace
llbacks to be called.
> Built a connection to the Pipewire sound system server in the
> qpw_audio_init() method.
>
> Signed-off-by: Dorinda Bassey
Acked-by: Christian Schoenebeck
> ---
> fix typo
> raise version dependency
>
> audio/audio.c |
On Friday, February 17, 2023 8:11:43 AM CET Dorinda Bassey wrote:
> This commit adds a new audiodev backend to allow QEMU to use Pipewire as
> both an audio sink and source. This backend is available on most systems
>
> Add Pipewire entry points for QEMU Pipewire audio backend
> Add wrappers for
On Wednesday, February 15, 2023 4:59:47 PM CET Daniel P. Berrangé wrote:
> On Wed, Feb 15, 2023 at 05:18:50PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote:
> > >
> > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as
On Thursday, February 16, 2023 9:25:44 AM CET Dorinda Bassey wrote:
> This commit adds a new audiodev backend to allow QEMU to use Pipewire as both
> an audio sink and source.
>
Please wrap commit log.
> Signed-off-by: Dorinda Bassey
> ---
> v2:
> * Shorten commit message
> * fix copyright
JACK, another app that only supports PulseAudio,
another that only supports ALSA and so on. So it tries to provide a universal
plug on a system for all.
Best regards,
Christian Schoenebeck
On Monday, February 6, 2023 6:37:16 AM CET Shi, Guohuai wrote:
[...]
> > I know, it's an n-square performance issue and what I already wrote in the
> > summary of the linked original suggestion [1] in v3 before, quote:
> >
> > + Relatively straight-forward to implement.
> >
> > + No (major)
On Friday, February 3, 2023 5:30:35 PM CET Shi, Guohuai wrote:
>
> > -Original Message-
> > From: Christian Schoenebeck
> > Sent: Friday, February 3, 2023 22:41
> > To: Greg Kurz ; qemu-devel@nongnu.org
> > Cc: Meng, Bin ; Marc-André Lureau
&g
On Friday, February 3, 2023 2:34:13 PM CET Shi, Guohuai wrote:
>
> > -Original Message-
> > From: Christian Schoenebeck
> > Sent: Friday, February 3, 2023 20:25
> > To: Greg Kurz ; qemu-devel@nongnu.org
> > Cc: Shi, Guohuai ; Meng, Bin
> > ; Mar
On Monday, January 30, 2023 10:51:50 AM CET Bin Meng wrote:
> From: Guohuai Shi
>
> This commit implements Windows specific xxxdir() APIs for safety
> directory access.
>
This issue deserves a link to either the previous discussion
Link:
On Thursday, January 19, 2023 7:59:57 AM CET Markus Armbruster wrote:
> This commit was created with scripts/clean-includes.
>
> Signed-off-by: Markus Armbruster
> ---
For 9p changes:
Acked-by: Christian Schoenebeck
> backends/tpm/tpm_ioctl.h | 2 --
>
On Thursday, January 19, 2023 11:37:00 AM CET Markus Armbruster wrote:
> Christian Schoenebeck writes:
>
> > On Thursday, January 19, 2023 7:59:58 AM CET Markus Armbruster wrote:
> >> Signed-off-by: Markus Armbruster
> >> ---
> >> hw/9pfs/9p.c |
se version come from? I don't see it anywhere in history.
Last relevant change in context was a136d17590a.
Best regards,
Christian Schoenebeck
On Friday, December 30, 2022 10:01:47 AM CET Volker Rümelin wrote:
> Am 28.12.22 um 14:52 schrieb Christian Schoenebeck:
> > On Monday, December 26, 2022 4:08:37 PM CET Volker Rümelin wrote:
> >> Am 21.12.22 um 12:03 schrieb Christian Schoenebeck:
> >>> On Sunday, De
On Thursday, December 29, 2022 1:31:09 PM CET Philippe Mathieu-Daudé wrote:
> On 27/12/22 17:15, Christian Schoenebeck wrote:
> > While mouse is grabbed, window title contains a hint for the user what
> > keyboard keys to press to release the mouse. Make that hint text a bit
> &g
On Thursday, December 29, 2022 7:03:54 AM CET Shi, Guohuai wrote:
>
> > -Original Message-
> > From: Christian Schoenebeck
> > Sent: Wednesday, December 28, 2022 19:51
> > To: Greg Kurz ; qemu-devel@nongnu.org
> > Cc: Meng, Bin ; Shi, Guohuai
> >
On Monday, December 26, 2022 4:08:37 PM CET Volker Rümelin wrote:
> Am 21.12.22 um 12:03 schrieb Christian Schoenebeck:
> > On Sunday, December 18, 2022 6:15:38 PM CET Volker Rümelin wrote:
> >> The currently used default playback settings in the ALSA audio
> >> ba
On Wednesday, December 21, 2022 7:02:43 PM CET Shi, Guohuai wrote:
>
> > -Original Message-
> > From: Christian Schoenebeck
> > Sent: Wednesday, December 21, 2022 22:48
> > To: Greg Kurz ; qemu-devel@nongnu.org
> > Cc: Shi, Guohuai ; Meng, Bin
> >
dditional space at start and end of key stroke set, to
visually separate the key strokes from the rest of the text.
Signed-off-by: Christian Schoenebeck
---
ui/cocoa.m | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index e915c344a8..289a2b193e 10064
\n", val);
> +open_voice(s, PO_INDEX, val);
> +} else {
> +dolog("Attempt to set front DAC rate to %d, but valid is"
> + "8-48kHZ\n", val);
> +}
Missing space between "i
From: Bin Meng
These are not used anywhere in the source tree. Drop them.
Signed-off-by: Bin Meng
Reviewed-by: Greg Kurz
Message-Id: <20221219102022.2167736-3-bin.m...@windriver.com>
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p-util.h | 11 ---
1 file changed, 11 del
From: Bin Meng
xxxat() APIs are only available on POSIX platforms. For future
extension to Windows, let's replace the direct call to xxxat()
APIs with a wrapper.
Signed-off-by: Bin Meng
Message-Id: <20221219102022.2167736-4-bin.m...@windriver.com>
Signed-off-by: Christian Schoenebeck
-
From: Bin Meng
Windows does not have .
Signed-off-by: Bin Meng
Message-Id: <20221219102022.2167736-2-bin.m...@windriver.com>
Signed-off-by: Christian Schoenebeck
---
include/qemu/xattr.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/qemu/xattr.h b/i
with a wrapper
Christian Schoenebeck (1):
MAINTAINERS: Add 9p test client to section "virtio-9p"
Greg Kurz (1):
9pfs: Fix some return statements in the synth backend
MAINTAINERS | 1 +
hw/9pfs/9p-local.c | 32
hw/9pfs/9p-synt
ed-off-by: Christian Schoenebeck
---
hw/9pfs/9p-synth.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c
index 38d787f494..f62c40b639 100644
--- a/hw/9pfs/9p-synth.c
+++ b/hw/9pfs/9p-synth.c
@@ -75,10 +75,10 @@ int qemu_v9fs_synth
The 9p test cases use a dedicated, lite-weight 9p client implementation
(using virtio transport) under tests/qtest/libqos/ to communicate with
QEMU's 9p server.
It's already there for a long time. Let's officially assign it to 9p
maintainers.
Signed-off-by: Christian Schoenebeck
Reviewed
On Monday, December 19, 2022 11:20:11 AM CET Bin Meng wrote:
> From: Guohuai Shi
>
> On Windows 'struct dirent' does not have current directory offset.
> Update qemu_dirent_off() to support Windows.
>
> While we are here, add a build time check to error out if a new
> host does not implement
a
Queued patches 1..3 for now on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
Best regards,
Christian Schoenebeck
On Sunday, December 18, 2022 6:15:38 PM CET Volker Rümelin wrote:
> The currently used default playback settings in the ALSA audio
> backend are a bit unfortunate. With a few emulated audio devices,
> audio playback does not work properly. Here is a short part of
> the debug log while audio is
1 - 100 of 1403 matches
Mail list logo
