ing the reporter and
details of the coverity report [patch 2].
Christian Schoenebeck (2):
tests/9pfs: fix test dir for parallel tests
tests/9pfs: fix coverity error in create_local_test_dir()
tests/qtest/libqos/virtio-9p.c | 32 +---
1 file changed, 25 inserti
-off-by: Christian Schoenebeck
Tested-by: Greg Kurz
---
tests/qtest/libqos/virtio-9p.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/libqos/virtio-9p.c b/tests/qtest/libqos/virtio-9p.c
index d43647b3b7..6b22fa0e9a 100644
--- a/tests
On Freitag, 30. Oktober 2020 13:09:26 CET Peter Maydell wrote:
> On Fri, 30 Oct 2020 at 12:02, Christian Schoenebeck
>
> wrote:
> > On Freitag, 30. Oktober 2020 12:44:18 CET Greg Kurz wrote:
> > It's not clear to me where this coverity report is accessible online. A
> >
vel message at least, because we
actually only care if the required directory exists and we do have an
existence check for that in place already.
Reported-by: Coverity (CID 1435963)
Signed-off-by: Christian Schoenebeck
---
tests/qtest/libqos/virtio-9p.c | 7 ++-
1 file changed, 6 insertions(+), 1
On Freitag, 30. Oktober 2020 12:44:18 CET Greg Kurz wrote:
> On Fri, 30 Oct 2020 09:19:46 +0100
>
> Christian Schoenebeck wrote:
> > Coverity wants the return value of mkdir() to be checked, so let's
> > pretend to do that. We're actually just making a dummy check and
Signed-off-by: Christian Schoenebeck
---
tests/qtest/libqos/virtio-9p.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/libqos/virtio-9p.c b/tests/qtest/libqos/virtio-9p.c
index 6b22fa0e9a..0a7c0ee5d8 100644
--- a/tests/qtest/libqos/virtio-9p.c
+++ b/tests/qtest
Fixes two bugs with the 9pfs 'local' tests as discussed with latest 9P PR
(2020-10-23). See the discussion of that PR for details.
Christian Schoenebeck (2):
tests/9pfs: fix test dir for parallel tests
tests/9pfs: fix coverity error in create_local_test_dir()
tests/qtest/libqos/virtio-9p.c
-off-by: Christian Schoenebeck
---
tests/qtest/libqos/virtio-9p.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/libqos/virtio-9p.c b/tests/qtest/libqos/virtio-9p.c
index d43647b3b7..6b22fa0e9a 100644
--- a/tests/qtest/libqos/virtio-9p.c
On Donnerstag, 29. Oktober 2020 19:02:34 CET Greg Kurz wrote:
> On Thu, 8 Oct 2020 20:34:56 +0200
>
> Christian Schoenebeck wrote:
> > This patch introduces 9pfs test cases using the 9pfs 'local'
> > filesystem driver which reads/writes/creates/deletes real file
On Donnerstag, 29. Oktober 2020 16:04:03 CET Daniel P. Berrangé wrote:
> On Thu, Oct 29, 2020 at 02:52:16PM +, Peter Maydell wrote:
> > On Thu, 29 Oct 2020 at 14:31, Christian Schoenebeck
> >
> > wrote:
> > > On Donnerstag, 29. Oktober 2020 15:15:19 CET Peter
On Donnerstag, 29. Oktober 2020 15:15:19 CET Peter Maydell wrote:
> On Thu, 29 Oct 2020 at 14:06, Christian Schoenebeck
>
> wrote:
> > Ok, I'll use mkdtemp() instead, that avoids other potential parallel
> > config
> > colissions that I may not have considered
On Donnerstag, 29. Oktober 2020 14:57:45 CET Peter Maydell wrote:
> On Thu, 29 Oct 2020 at 13:48, Christian Schoenebeck
>
> wrote:
> > So I'll append the architecture to the test dir location. To nail it this
> > time, anyting else that would come to your mind regarding te
On Donnerstag, 29. Oktober 2020 14:20:11 CET Peter Maydell wrote:
> On Mon, 26 Oct 2020 at 12:48, Christian Schoenebeck
>
> wrote:
> > On Montag, 26. Oktober 2020 11:33:42 CET Peter Maydell wrote:
> > > I get a 'make check' failure on x86-64 Linux host:
> > >
t; +config_size = ROUND_UP(v->config_size, 4);
> +virtio_init(vdev, "virtio-9p", VIRTIO_ID_9P, config_size);
> v->vq = virtio_add_queue(vdev, MAX_REQ, handle_9p_output);
> }
Shouldn't this config_size correction rather be handled on virtio.c side
instead, i.e. in virtio_init()?
>
> --
> 2.7.4
Best regards,
Christian Schoenebeck
val[0] |
> @@ -4185,6 +4185,6 @@ static void __attribute__((__constructor__))
> v9fs_set_fd_limit(void) error_report("Failed to get the resource limit");
> exit(1);
> }
> -open_fd_hw = rlim.rlim_cur - MIN(400, rlim.rlim_cur/3);
> -open_fd_rc = rlim.rlim_cur/2;
> +open_fd_hw = rlim.rlim_cur - MIN(400, rlim.rlim_cur / 3);
> +open_fd_rc = rlim.rlim_cur / 2;
> }
Best regards,
Christian Schoenebeck
s, test case output, different modes, etc., while catching misusage
and retaining a simple API.
I postpone the colour issue for that reason and drop colour from these patches
for now. I'll probably rather come up with a dedicated series attempt just for
colour at some later point.
Best regards,
Christian Schoenebeck
On Dienstag, 27. Oktober 2020 11:26:53 CET Dr. David Alan Gilbert wrote:
> * Christian Schoenebeck (qemu_...@crudebyte.com) wrote:
> > On Dienstag, 27. Oktober 2020 10:06:53 CET Dr. David Alan Gilbert wrote:
> > > * Greg Kurz (gr...@kaod.org) wrote:
> > > > On M
On Dienstag, 27. Oktober 2020 10:06:53 CET Dr. David Alan Gilbert wrote:
> * Greg Kurz (gr...@kaod.org) wrote:
> > On Mon, 26 Oct 2020 13:48:37 +0100
> >
> > Christian Schoenebeck wrote:
> > > On Montag, 26. Oktober 2020 11:33:42 CET Peter Maydell wrote:
> &
On Montag, 26. Oktober 2020 11:33:42 CET Peter Maydell wrote:
> On Fri, 23 Oct 2020 at 12:46, Christian Schoenebeck
>
> wrote:
> > The following changes since commit 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430:
> > Merge remote-tracking branch
> > 'remotes/kraxel
On Samstag, 24. Oktober 2020 08:01:55 CEST Thomas Huth wrote:
> On 08/10/2020 20.34, Christian Schoenebeck wrote:
> > If qtests were run in verbose mode (i.e. if --verbose CL argument was
> > provided) then dump the generated qos graph (all nodes and edges,
> > along with the
On Samstag, 24. Oktober 2020 08:04:20 CEST Thomas Huth wrote:
> On 08/10/2020 20.34, Christian Schoenebeck wrote:
> > This new function is purely for debugging purposes. It prints the
> > current qos graph to stdout and allows to identify problems in the
> > created qos graph
On Samstag, 24. Oktober 2020 07:56:10 CEST Thomas Huth wrote:
> On 08/10/2020 20.34, Christian Schoenebeck wrote:
> > If qtests are run in verbose mode (i.e. if --verbose CL argument
> > was provided) then print all environment variables to stdout
> > before running the indiv
On Samstag, 24. Oktober 2020 08:08:59 CEST Thomas Huth wrote:
> On 19/10/2020 12.35, Christian Schoenebeck wrote:
> > On Donnerstag, 8. Oktober 2020 20:34:56 CEST Christian Schoenebeck wrote:
> >> Add new member variable 'qemu_name' to struct QOSGraphNode.
> >>
+0200
> Greg Kurz wrote:
>
> ... here.
Yep, I noticed that too late. I'll take care about it next time. Sorry!
Best regards,
Christian Schoenebeck
This test case uses a Tlink request to create a hard link to a regular
file using the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 71
This test case uses a Tunlinkat 9p request with flag AT_REMOVEDIR
(see 'man 2 unlink') to remove a directory from host's test directory.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<3c7c65b476ba44bea6afd0b378b5287e1c671a32.1603285620.git.qemu_...@crudebyte.
This test case uses a Tunlinkat request to remove a previously hard
linked file by using the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<9bec33a7d8f006ef8f80517985d0d6ac48650d53.1603285620.git.qemu_...@crudebyte.com>
Signed-off-by: Chr
This test case uses a Tunlinkat request to remove a symlink using
the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 28
1 file changed, 28
-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<4d7275b2363f122438a443ce079cbb355285e9d6.1603285620.git.qemu_...@crudebyte.com>
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 27 +++
1 file changed, 19 insertions(+), 8 del
This test case uses a Tsymlink 9p request to create a symbolic link using
the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<84ac76937855bf441242372cc3e62df42f0a3dc4.1603285620.git.qemu_...@crudebyte.com>
Signed-off-by: Christian Schoe
This test case uses a Tlcreate 9p request to create a regular file inside
host's test directory.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<269cae0c00af941a3a4ae78f1e319f93462a7eb4.1603285620.git.qemu_...@crudebyte.com>
Signed-off-by: Christian Schoe
This test case uses a Tunlinkat request to remove a regular file using
the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<4eabeed7f662721dd5664cb77fe36ea0aa08b1ec.1603285620.git.qemu_...@crudebyte.com>
Signed-off-by: Christian Schoe
for the following 9p requests: Tunlinkat, Tlcreate, Tsymlink
and Tlink.
Christian Schoenebeck (8):
tests/9pfs: simplify do_mkdir()
tests/9pfs: add local Tunlinkat directory test
tests/9pfs: add local Tlcreate test
be lifted for the 9p export path.
There would be other options as well of course: e.g. detecting on 9pfs side
whether AppArmor and co are enabled, and log a warning to the user a syscall
failed for that reason. But that would be much more complicated and I wonder
whether it would be worth it.
Best regards,
Christian Schoenebeck
On Donnerstag, 22. Oktober 2020 10:51:46 CEST Greg Kurz wrote:
> On Wed, 21 Oct 2020 14:25:33 +0200
>
> Christian Schoenebeck wrote:
> > This test case uses a Tlcreate 9p request to create a regular file inside
> > host's test directory.
> >
> > Sig
On Mittwoch, 21. Oktober 2020 14:51:09 CEST Christian Schoenebeck wrote:
> This test case uses a Tlink request to create a hard link to a regular
> file using the 9pfs 'local' fs driver.
>
> Signed-off-by: Christian Schoenebeck
> ---
> tests/qtest/vir
This test case uses a Tunlinkat request to remove a symlink using
the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 28
1 file changed, 28 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio
This test case uses a Tunlinkat request to remove a previously hard
linked file by using the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/tests/qtest/virtio-9p
This test case uses a Tlink request to create a hard link to a regular
file using the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 71
1 file changed, 71 insertions(+)
diff --git a/tests/qtest/virtio-9p
This test case uses a Tlcreate 9p request to create a regular file inside
host's test directory.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 77
1 file changed, 77 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b/tests
-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index 2ea555fa04..21807037df 100644
--- a/tests/qtest/virtio-9p-test.c
+++ b
This test case uses a Tsymlink 9p request to create a symbolic link using
the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 77
1 file changed, 77 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b
This test case uses a Tunlinkat 9p request with flag AT_REMOVEDIR
(see 'man 2 unlink') to remove a directory from host's test directory.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 71
1 file changed, 71 insertions(+)
diff --git
This test case uses a Tunlinkat request to remove a regular file using
the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 24
1 file changed, 24 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest
nts of utility functions.
* Always do 'alloc = t_alloc;' in toplevel test functions.
* Split out do_hardlink() as utility function [patch 6].
Christian Schoenebeck (8):
tests/9pfs: simplify do_mkdir()
tests/9pfs: add local Tunlinkat directory test
tests/9pfs: add local Tlcreate test
te
On Mittwoch, 21. Oktober 2020 08:15:55 CEST Philippe Mathieu-Daudé wrote:
> Hi Cristian,
>
> On 10/20/20 1:54 PM, Christian Schoenebeck wrote:
> > On Dienstag, 20. Oktober 2020 12:00:57 CEST Greg Kurz wrote:
> >> On Tue, 20 Oct 2020 11:43:18 +0200
> >>
On Dienstag, 20. Oktober 2020 20:03:09 CEST Greg Kurz wrote:
> On Tue, 20 Oct 2020 15:43:21 +0200
>
> Christian Schoenebeck wrote:
> > On Dienstag, 20. Oktober 2020 15:35:36 CEST Greg Kurz wrote:
> > > On Tue, 20 Oct 2020 01:13:23 +0200
> > >
> > > C
rtio-9p-test.c | 62
> +++--- 1 file changed, 34
> insertions(+), 28 deletions(-)
>
> --
> Greg
Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
I just tweaked the order of the patches to prevent intermediate compiler
errors.
Thanks!
Best regards,
Christian Schoenebeck
On Dienstag, 20. Oktober 2020 17:41:56 CEST Greg Kurz wrote:
> On Tue, 20 Oct 2020 17:34:05 +0200
>
> Christian Schoenebeck wrote:
> > On Dienstag, 20. Oktober 2020 17:11:05 CEST Greg Kurz wrote:
> > > fs_version() is a top level test function. Factor out the sugar
&g
functions there. Not that I care too much about the precise prefix, but how
about just do_*() for them instead?
Except of that, your patches look fine to me.
Best regards,
Christian Schoenebeck
On Dienstag, 20. Oktober 2020 15:35:36 CEST Greg Kurz wrote:
> On Tue, 20 Oct 2020 01:13:23 +0200
>
> Christian Schoenebeck wrote:
> > Split out walking a directory path to a separate new utility function
> > fs_walk_fid() and use that function in fs_mkdir().
> >
&g
On Dienstag, 20. Oktober 2020 12:00:57 CEST Greg Kurz wrote:
> On Tue, 20 Oct 2020 11:43:18 +0200
>
> Christian Schoenebeck wrote:
> > On Dienstag, 20. Oktober 2020 09:36:10 CEST Philippe Mathieu-Daudé wrote:
> > > On 10/8/20 8:34 PM, Christian Schoenebeck wrote:
> &
On Dienstag, 20. Oktober 2020 09:36:10 CEST Philippe Mathieu-Daudé wrote:
> On 10/8/20 8:34 PM, Christian Schoenebeck wrote:
> > All existing 9pfs test cases are using the 'synth' fs driver so far, which
> > means they are not accessing real files, but a purely simulated (in RAM
On Dienstag, 20. Oktober 2020 01:13:24 CEST Christian Schoenebeck wrote:
> This test case uses a Tlink request to create a hard link to a regular
> file using the 9pfs 'local' fs driver.
>
> Signed-off-by: Christian Schoenebeck
> ---
> tests/qtest/vir
This test case uses a Tunlinkat request to remove a previously hard
linked file by using the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tests/qtest/virtio
This test case uses a Tlink request to create a hard link to a regular
file using the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 61
1 file changed, 61 insertions(+)
diff --git a/tests/qtest/virtio-9p
This test case uses a Tunlinkat request to remove a regular file using
the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio
This test case uses a Tunlinkat request to remove a symlink using
the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio
This test case uses a Tlcreate 9p request to create a regular file inside
host's test directory.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 78
1 file changed, 78 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b/tests
Just a bunch of more test case using the 9pfs 'local' fs driver backend,
namely for these 9p requests:
* Tunlinkat, Tlcreate, Tsymlink and Tlink.
Christian Schoenebeck (8):
tests/9pfs: simplify fs_mkdir()
tests/9pfs: add local unlinkat directory test
tests/9pfs: add local Tlcreate test
This test case uses a Tsymlink 9p request to create a symbolic link using
the 9pfs 'local' fs driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 78
1 file changed, 78 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b
.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index c15908f27b..dc724bbb1e 100644
--- a/tests/qtest/virtio-9p-test.c
This test case uses a Tunlinkat 9p request with flag AT_REMOVEDIR
(see 'man 2 unlink') to remove a directory from host's test directory.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 72
1 file changed, 72 insertions(+)
diff --git
This new public function virtio_9p_test_path() allows 9pfs
'local' tests to translate a path from guest scope to host
scope. For instance by passing an empty string it would
return the root path on host of the exported 9pfs tree.
Signed-off-by: Christian Schoenebeck
Message-Id:
Signed-off
what files and directories the
9pfs local tests created precisely after the test suite completed.
But fortunately the test directory is not wiped if some test failed.
So it is probably not worth it drilling another hole into libqos
for this issue.
Signed-off-by: Christian Schoenebeck
Message-Id
'local' tests are run, a test directory 'qtest-9p-local'
is created (with world rwx permissions) under the current working
directory. At this point that test directory is not auto deleted yet.
Signed-off-by: Christian Schoenebeck
Message-Id:
<81fc4b3b6b6c9bf7999e79f5e7cbc364a5f09ddb.1602182
. For
that reason g_strsplit() would not be a good alternative, as
it would require additional filter code for reshuffling the
array, and the resulting code would be even more complex than
this split() function.
Signed-off-by: Christian Schoenebeck
Message-Id:
Signed-off-by: Christian Schoenebeck
---
tests
Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p-synth.c | 2 --
hw/9pfs/virtio-9p-device.c | 6 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c
index cec8c0eefc..7eb210ffa8 100644
distinguishable
from upcoming new 9pfs test cases supposed to be using a different fs
driver.
Signed-off-by: Christian Schoenebeck
Message-Id:
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions
/qemu/+bug/1336794
https://bugs.launchpad.net/qemu/+bug/1877384
This patch set for that reason introduces 9pfs test cases using the 9pfs
'local' filesystem driver along to the already existing tests on 'synth'.
Christian Schoenebeck
On Montag, 19. Oktober 2020 13:48:22 CEST Greg Kurz wrote:
> On Mon, 19 Oct 2020 13:10:18 +0200
>
> Christian Schoenebeck wrote:
> > Don't trigger any performance warning if we're just running test cases,
> > because tests intentionally run for edge cases.
> >
>
Don't trigger any performance warning if we're just running test cases,
because tests intentionally run for edge cases.
So far performance warnings were suppressed for the 'synth' fs driver
backend only. This patch suppresses them for all 9p fs driver backends.
Signed-off-by: Christian
On Donnerstag, 8. Oktober 2020 20:34:56 CEST Christian Schoenebeck wrote:
> Add new member variable 'qemu_name' to struct QOSGraphNode.
>
> This new member may be optionally set in case a different
> name for the node (which must always be a unique name) vs.
> its actually assoc
On Montag, 19. Oktober 2020 12:22:47 CEST Peter Maydell wrote:
> On Mon, 19 Oct 2020 at 11:19, Christian Schoenebeck
>
> wrote:
> > On Montag, 19. Oktober 2020 11:52:38 CEST Peter Maydell wrote:
> > > This emits a lot of new warnings during 'make check':
> > >
On Montag, 19. Oktober 2020 11:52:38 CEST Peter Maydell wrote:
> On Sat, 17 Oct 2020 at 15:23, Christian Schoenebeck
>
> wrote:
> > The following changes since commit
e12ce85b2c79d83a340953291912875c30b3af06:
> > Merge remote-tracking branch
> > 'remotes/ehabkost
. For
that reason g_strsplit() would not be a good alternative, as
it would require additional filter code for reshuffling the
array, and the resulting code would be even more complex than
this split() function.
Signed-off-by: Christian Schoenebeck
Message-Id:
Signed-off-by: Christian Schoenebeck
---
tests
/qemu/+bug/1336794
https://bugs.launchpad.net/qemu/+bug/1877384
This patch set for that reason introduces 9pfs test cases using the 9pfs
'local' filesystem driver along to the already existing tests on 'synth'.
Christian Schoenebeck
This new public function virtio_9p_test_path() allows 9pfs
'local' tests to translate a path from guest scope to host
scope. For instance by passing an empty string it would
return the root path on host of the exported 9pfs tree.
Signed-off-by: Christian Schoenebeck
Message-Id:
Signed-off
what files and directories the
9pfs local tests created precisely after the test suite completed.
But fortunately the test directory is not wiped if some test failed.
So it is probably not worth it drilling another hole into libqos
for this issue.
Signed-off-by: Christian Schoenebeck
Message-Id
'local' tests are run, a test directory 'qtest-9p-local'
is created (with world rwx permissions) under the current working
directory. At this point that test directory is not auto deleted yet.
Signed-off-by: Christian Schoenebeck
Message-Id:
<81fc4b3b6b6c9bf7999e79f5e7cbc364a5f09ddb.1602182
distinguishable
from upcoming new 9pfs test cases supposed to be using a different fs
driver.
Signed-off-by: Christian Schoenebeck
Message-Id:
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions
On Samstag, 17. Oktober 2020 12:50:13 CEST Peter Maydell wrote:
> On Thu, 15 Oct 2020 at 22:04, Christian Schoenebeck
>
> wrote:
> > The following changes since commit
57c98ea9acdcef5021f5671efa6475a5794a51c4:
> > Merge remote-tracking branch
> > 'remotes/k
what files and directories the
9pfs local tests created precisely after the test suite completed.
But fortunately the test directory is not wiped if some test failed.
So it is probably not worth it drilling another hole into libqos
for this issue.
Signed-off-by: Christian Schoenebeck
Message-Id
'local' tests are run, a test directory 'qtest-9p-local'
is created (with world rwx permissions) under the current working
directory. At this point that test directory is not auto deleted yet.
Signed-off-by: Christian Schoenebeck
Message-Id:
<81fc4b3b6b6c9bf7999e79f5e7cbc364a5f09ddb.1602182
. For
that reason g_strsplit() would not be a good alternative, as
it would require additional filter code for reshuffling the
array, and the resulting code would be even more complex than
this split() function.
Signed-off-by: Christian Schoenebeck
Message-Id:
Signed-off-by: Christian Schoenebeck
---
tests
distinguishable
from upcoming new 9pfs test cases supposed to be using a different fs
driver.
Signed-off-by: Christian Schoenebeck
Message-Id:
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions
://bugs.launchpad.net/qemu/+bug/1336794
https://bugs.launchpad.net/qemu/+bug/1877384
This patch set for that reason introduces 9pfs test cases using the 9pfs
'local' filesystem driver along to the already existing tests on 'synth'.
Christian Schoenebeck
This new public function virtio_9p_test_path() allows 9pfs
'local' tests to translate a path from guest scope to host
scope. For instance by passing an empty string it would
return the root path on host of the exported 9pfs tree.
Signed-off-by: Christian Schoenebeck
Message-Id:
Signed-off
On Mittwoch, 14. Oktober 2020 21:38:16 CEST Greg Kurz wrote:
> On Wed, 14 Oct 2020 17:25:35 +0200
>
> Christian Schoenebeck wrote:
> > On Donnerstag, 8. Oktober 2020 20:34:56 CEST Christian Schoenebeck wrote:
> > > All existing 9pfs test cases are using the 'synth' fs dr
On Donnerstag, 8. Oktober 2020 20:34:56 CEST Christian Schoenebeck wrote:
> All existing 9pfs test cases are using the 'synth' fs driver so far, which
> means they are not accessing real files, but a purely simulated (in RAM
> only) file system.
>
> Let's make this clear by chan
files and directories the 9pfs local
tests created precisely after the test suite completed. But
fortunately the test directory is not wiped if some test failed.
So it is probably not worth it drilling another hole into libqos
for this issue.
Signed-off-by: Christian Schoenebeck
---
tests/qtest
This new public function virtio_9p_test_path() allows 9pfs
'local' tests to translate a path from guest scope to host
scope. For instance by passing an empty string it would
return the root path on host of the exported 9pfs tree.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/libqos
. For
that reason g_strsplit() would not be a good alternative, as
it would require additional filter code for reshuffling the
array, and the resulting code would be even more complex than
this split() function.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 139
colour.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/libqos/qgraph.c | 56 +
tests/qtest/libqos/qgraph.h | 20 +
2 files changed, 76 insertions(+)
diff --git a/tests/qtest/libqos/qgraph.c b/tests/qtest/libqos/qgraph.c
index 61faf6b27d
there is currently no public glib API available to check
whether TAP output format is enabled. For that reason qos_printf()
simply always prepends a '#' character for now.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/libqos/qgraph_internal.h | 11 +++
1 file changed, 11 insertions
distinguishable
from upcoming new 9pfs test cases supposed to be using a different fs
driver.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/tests/qtest/virtio-9p-test.c b
If qtests were run in verbose mode (i.e. if --verbose CL argument was
provided) then dump the generated qos graph (all nodes and edges,
along with their current individual availability status) to stdout.
See API doc comment on function qos_dump_graph() for details.
Signed-off-by: Christian
If qtests are run in verbose mode (i.e. if --verbose CL argument
was provided) then print the assembled qemu command line for each
test.
Use qos_printf() instead of g_test_message() to avoid the latter
cluttering the output.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/qos-test.c | 3
'qemu_name' field of
QOSGraphNode for that purpose.
Adjust build_driver_cmd_line() and qos_graph_node_set_availability()
to correctly deal with either accessing node name vs. node's
qemu_name correctly.
Signed-off-by: Christian Schoenebeck
---
tests/qtest/libqos/qgraph.c | 53
Add new member variable 'qemu_name' to struct QOSGraphNode.
This new member may be optionally set in case a different
name for the node (which must always be a unique name) vs.
its actually associated QEMU (QMP) device name is required.
Signed-off-by: Christian Schoenebeck
---
tests/qtest
901 - 1000 of 1403 matches
Mail list logo
