[PATCH v3 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-26 Thread Chuck Zmudzinski
When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck Zmudzinski --- v2: Remove From:

[PATCH v3 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2022-10-26 Thread Chuck Zmudzinski
lot 2 was reserved by xen_igd_reserve_slot when the PCI bus was created in hw/i386/pc_piix.c for the case when igd-passthru=on. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on recommendations from Q

[PATCH v3 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD

2022-10-26 Thread Chuck Zmudzinski
No change to this cover letter since v2 Chuck Zmudzinski (2): xen/pt: fix syntax error that causes FTBFS in some configurations xen/pt: reserve PCI slot 2 for Intel igd-passthru hw/i386/pc_piix.c| 3 +++ hw/xen/meson.build | 2 +- hw/xen/xen_pt.c | 25 +++

[PATCH v2 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD

2022-10-26 Thread Chuck Zmudzinski
t; I have used the second patch of the series for the past two years with no problems. Without the patch, the reliability of PCI passthrough of the Intel IGD to a Xen HVM guest is very poor, and in some cases the guest fails to start without the patch. v2: Remove From: tag at top of mess

[PATCH v2 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-26 Thread Chuck Zmudzinski
When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck Zmudzinski --- v2: Remove From:

[PATCH v2 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2022-10-26 Thread Chuck Zmudzinski
lot 2 was reserved by xen_igd_reserve_slot when the PCI bus was created in hw/i386/pc_piix.c for the case when igd-passthru=on. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on recommendations from Q

[PATCH 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2022-10-26 Thread Chuck Zmudzinski
From: Chuck Zmudzinski Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model

[PATCH 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD

2022-10-26 Thread Chuck Zmudzinski
From: Chuck Zmudzinski This is a series of two patches: The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough configure options are set with when building for the linux target os. The second fixes a regression that was introduced many years ago with the upgrade from

[PATCH 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-10-26 Thread Chuck Zmudzinski
From: Chuck Zmudzinski When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by: Chuck Zmudzinsk

[PATCH v5] xen/pass-through: merge emulated bits correctly

2022-06-29 Thread Chuck Zmudzinski
gitlab.com/qemu-project/qemu/-/issues/1061 Buglink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988333 Signed-off-by: Chuck Zmudzinski Reviewed-by: Anthony PERARD --- v2: Edit the commit message to more accurately describe the cause of the error. v3: * Add Reviewed-By: Anthony Perard

[PATCH v3] xen/pass-through: merge emulated bits correctly

2022-06-29 Thread Chuck Zmudzinski
://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988333 Signed-off-by: Chuck Zmudzinski Reviewed-by: Anthony PERARD --- v2: Edit the commit message to more accurately describe the cause of the error. v3: * Add Reviewed-By: Anthony Perard * Add qemu-sta...@nongnu.org to recipients to indicate

[PATCH v3] xen/pass-through: don't create needless register group

2022-06-29 Thread Chuck Zmudzinski
this patch. Signed-off-by: Chuck Zmudzinski Reviewed-by: Anthony PERARD --- v2: * Move the comment to an appropriate place after applying this patch * Mention that the comment is moved in the commit message v2 addresses the comment by Anthony Perard on the original version of this patch. v3

Re: [PATCH] xen/pass-through: don't create needless register group

2022-06-17 Thread Chuck Zmudzinski
On 6/17/22 9:07 AM, Anthony PERARD wrote: On Fri, Jun 10, 2022 at 12:23:35PM -0400, Chuck Zmudzinski wrote: Currently we are creating a register group for the Intel IGD OpRegion for every device we pass through, but the XEN_PCI_INTEL_OPREGION register group is only valid for an Intel IGD. Add

[PATCH v2] xen/pass-through: don't create needless register group

2022-06-17 Thread Chuck Zmudzinski
this patch. Signed-off-by: Chuck Zmudzinski --- v2: * Move the comment to an appropriate place after applying this patch * Mention that the comment is moved in the commit message v2 addresses the comment by Anthony Perard on the original version of this patch. hw/xen/xen_pt_config_init.c

[PATCH v2] xen/pass-through: merge emulated bits correctly

2022-06-11 Thread Chuck Zmudzinski
://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988333 Signed-off-by: Chuck Zmudzinski --- v2: Edit the commit message to more accurately describe the cause of the error. hw/xen/xen_pt_config_init.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt_config_init.c b

[PATCH] xen/pass-through: merge emulated bits correctly

2022-06-10 Thread Chuck Zmudzinski
capability of the device in Linux guests with the end result being that the Linux guest never completes the boot process. Fixes: 2e87512eccf3 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1061 Buglink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988333 Signed-off-by: Chuck Zmudzinski

[PATCH] xen/pass-through: don't create needless register group

2022-06-10 Thread Chuck Zmudzinski
that the vendor be Intel, because only Intel IGD devices have an Intel OpRegion. These are the same checks hvmloader and libxl do to determine if the Intel OpRegion needs to be mapped into the guest's memory. Signed-off-by: Chuck Zmudzinski --- hw/xen/xen_pt_config_init.c | 4 1 file changed, 4

<    1   2