Re: AST2600 support in QEMU

2022-08-14 Thread Dan Zhang
On Tue, Aug 9, 2022 at 10:51 PM Cédric Le Goater wrote: > > Hello, > > On 8/10/22 04:37, Joel Stanley wrote: > > Hello Shivi, > > > > I've added others to cc who may have some input. > > > > On Tue, 9 Aug 2022 at 21:38, Shivi Fotedar wrote: > >> > >> Hello, we are looking for support for few feat

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-04 Thread Dan Zhang
On Thu, Aug 4, 2022 at 4:21 PM Peter Delevoryas wrote: > > On Thu, Aug 04, 2022 at 11:07:10AM -0700, Dan Zhang wrote: > > On Wed, Aug 3, 2022 at 10:30 AM Peter Delevoryas wrote: > > > > > > On Wed, Aug 03, 2022 at 10:52:23AM +0200, Cédric Le Goater wrote: > >

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-04 Thread Dan Zhang
On Wed, Aug 3, 2022 at 10:30 AM Peter Delevoryas wrote: > > On Wed, Aug 03, 2022 at 10:52:23AM +0200, Cédric Le Goater wrote: > > On 8/3/22 04:32, Iris Chen wrote: > > > From: Iris Chen > > > > A commit log telling us about this new device would be good to have. > > > > > > > Signed-off-by: Iris

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-08-04 Thread Dan Zhang
On Tue, Aug 2, 2022 at 7:25 AM Cédric Le Goater wrote: > > On 7/31/22 00:06, Peter Delevoryas wrote: > > On Sat, Jul 30, 2022 at 11:18:33PM +0200, Cédric Le Goater wrote: > >> On 7/29/22 19:30, Peter Delevoryas wrote: > >>> On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: > H

Re: [PATCH v3 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-17 Thread Dan Zhang
On Fri, Jun 17, 2022 at 03:02:45PM -0700, Iris Chen wrote: > Signed-off-by: Iris Chen > --- > Thanks everyone for your comments. This is a v3 patch that addresses all > suggestions (moving write_enable to decode_new_cmd). > I am waiting on some feedback from Dan's (dz4l...@gmail.com) patch > reg

[PATCH] hw:m25p80: Add STATE_STANDBY command state

2022-06-14 Thread Dan Zhang
standby mode, This device's SO pin should be High-Z. ``` Add STATE_STANDBY CMDState and let the device ignore all input and keep SO as HIZ (output 1) Signed-off-by: Dan Zhang --- A usage of this new state can be aborting in HPM checking or unknown command code received. hw/block/m25p80.

Re: [PATCH] hw:w25p80: Add STATE_STANDBY to handle incorrect command

2022-06-14 Thread Dan Zhang
this STATE_STANDBY state, as those code shall be in @iris WP# patch. BRs Dan On Tue, Jun 14, 2022 at 09:02:46AM -0700, Dan Zhang wrote: > --- > hw/block/m25p80.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index b6bd

[PATCH] hw:w25p80: Add STATE_STANDBY to handle incorrect command

2022-06-14 Thread Dan Zhang
--- hw/block/m25p80.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index b6bd430a99..3bb0466dca 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -423,6 +423,7 @@ typedef enum { STATE_COLLECTING_DATA, STATE_COLLECTING_VAR_LEN_DA

Re: [PATCH v2 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-13 Thread Dan Zhang
On Mon, Jun 13, 2022 at 10:45:34PM -0700, Dan Zhang wrote: > Just find out how to use mutt to reply all in the thread. > repeat the previous comments. Add STATE_HIZ to handle decode_new_command > aborting gracefully. > > On Thu, Jun 09, 2022 at 08:06:00PM +, Peter D

Re: [PATCH v2 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-13 Thread Dan Zhang
ified to reset the transfer > state machine after a blocked write command. I can’t remember if > exiting and re-entering user mode is sufficient for that, but something > like that is probably possible. > > Thanks for catching this! > Peter > I am proposing add a CMDState: STAT

Re: [PATCH v2 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-13 Thread Dan Zhang
On Thu, Jun 09, 2022 at 08:06:00PM +, Peter Delevoryas wrote: > > > > On Jun 9, 2022, at 12:22 PM, Francisco Iglesias > > wrote: > > > > Hi Iris, > > > > Looks good some, a couple of comments below. > > > > On [2022 Jun 08] Wed 20:13:19, Iris Chen wrote: > >> From: Iris Chen > >> > >> Signed

[Qemu-devel] Mouse cursor position is un-matched when I use Qemu in VNC mode.

2011-07-17 Thread Dan Zhang
h (with this feature: VNC_FEATURE_POINTER_TYPE_CHANGE). But this feature seems not supported in androidVNC client. So anyone can give me some clues to solve this issue? Thanks a lot! -- Best Regards Dan Zhang