On Thu, May 30, 2024 at 10:03:51AM +0100, Peter Maydell wrote:
> On Thu, 30 May 2024 at 01:52, David Gibson
> wrote:
> >
> > On Wed, May 29, 2024 at 02:07:18PM +0300, Oleg Sviridov wrote:
> > > Pointer, returned from function 'spapr_vio_find_by_reg', may be NULL
;
>
> +if (!dev) {
> +return H_PARAMETER;
> +}
> +
> for (i = 0; i < ETH_ALEN; i++) {
> dev->nicconf.macaddr.a[ETH_ALEN - i - 1] = macaddr & 0xff;
> macaddr >>= 8;
--
David Gibson| I'll have my music ba
> >
> > Cc: Cédric Le Goater
> > Cc: Daniel Henrique Barboza
> > Cc: David Gibson
> > Cc: Frédéric Barrat
> > Cc: Harsh Prateek Bora
> > Cc: Mahesh J Salgaonkar
> > Cc: Madhavan Srinivasan
> > Cc: Nicholas Piggin
> > Signed-off-by:
/* 42: PM, 44: PC RA, 46: SC vec'd */
> 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 42 - 47 */
> /* 48: SIMD, 50: QP BFP, 52: String */
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT
SLB|RUN|DABR|NX, 1: fri[nzpm]|DABRX|SPRG3|SLB0|PP110 */
> -/* 2: VPM|DS205|PPR|DS202|DS206, 3: LSD|URG, SSO, 5: LE|CFAR|EB|LSQ
> */
> -0xf6, 0x1f, 0xc7, 0xc0, 0x80, 0xf0, /* 0 - 5 */
> +/* 2: VPM|DS205|PPR|DS202|DS206, 3: LSD|URG, 5: LE|CFAR|EB|LSQ */
> +0
et_ciabr(PowerPCCPU *cpu,
> > return H_SUCCESS;
> > }
> >
> > -static target_ulong h_set_mode_resource_set_dawr0(PowerPCCPU *cpu,
> > - SpaprMachineState *spapr,
> > -
base = ppc_hash64_hpt_base(cpu);
> @@ -837,9 +831,7 @@ static void ppc_hash64_set_c(PowerPCCPU *cpu, hwaddr
> ptex, uint64_t pte1)
> hwaddr base, offset = ptex * HASH_PTE_SIZE_64 + HPTE64_DW1_C;
>
> if (cpu->vhyp) {
> -PPCVirtualHypervisorClass *vhc =
> -
Odd Fixes
> F: target/ppc/kvm.c
>
> @@ -1502,7 +1500,6 @@ F: tests/avocado/ppc_prep_40p.py
> sPAPR (pseries)
> M: Nicholas Piggin
> R: Daniel Henrique Barboza
> -R: Cédric Le Goater
> R: David Gibson
> R: Harsh Prateek Bora
> L: qemu-...@nongnu.org
t;action is reset because the user never expressed a preference"
> and "action is reset because the user specifically asked for that",
> but I guess in theory we could make that distinction. (Conveniently
> there is no QMP action for "query current watchdog-action state&
On Tue, Jan 23, 2024 at 11:57:56AM +1000, Nicholas Piggin wrote:
> On Fri Jan 19, 2024 at 10:23 AM AEST, David Gibson wrote:
> > On Fri, Jan 19, 2024 at 12:09:36AM +1000, Nicholas Piggin wrote:
> > > SAO is a page table attribute that strengthens the memory ordering of
&g
* academic.
> + */
> +pa_features[4 + 2] &= ~0x80;
Oof.. I see the reasoning but modifying guest visible parameters based
on host capabilities without a cap really worries me nonetheless.
> + }
> +
> if (ppc_hash64_has(cpu, PPC_HASH64_CI_LARGEPAGE
inja: build stopped: subcommand failed.
> > make: *** [Makefile:162: run-ninja] Error 1
> >
> > Signed-off-by: Juan Quintela
>
>
> Reviewed-by: Cédric Le Goater
I think changing the name of one of the functions would be even
better. Making it static means it won'
es(
> - 'spapr_softmmu.c',
> + 'spapr_tcg.c',
> ))
> ppc_ss.add(when: 'CONFIG_SPAPR_RNG', if_true: files('spapr_rng.c'))
> ppc_ss.add(when: ['CONFIG_PSERIES', 'CONFIG_LINUX'], if_true: files(
--
David Gibson| I'll have my music baroque,
{
> -return softmmu_resize_hpt_commit(cpu, spapr, flags, shift);
> +return tcgppc_resize_hpt_commit(cpu, spapr, flags, shift);
> } else {
> g_assert_not_reached();
> }
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
uired knowledge and motivation to drive the boat.
>
> - Greg Kurz is being removed from all qemu-ppc entries. Greg has moved
> to other areas of interest and will retire from qemu-ppc. Thanks Mr
> Kurz for all the years of service.
>
> - David Gibson was removed as 'Review
e don't care about
> KVM, we really want to test for TCG.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Gibson
> ---
> hw/ppc/spapr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index dcb7f
vier
Reviewed-by: David Gibson
> ---
> net/socket.c | 43 +--
> 1 file changed, 17 insertions(+), 26 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index 6b1f0fec3a10..8e3702e1f3a8 100644
> --- a/net/socket.c
> +++ b/net
On Fri, 9 Jun 2023 09:27:47 +0200
Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
Reviewed-by: David Gibson
> ---
> net/socket.c | 28
> 1 file changed, 20 insertions(+), 8 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
&g
s.
Reviewed-by: David Gibson
> ---
> net/socket.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index ba6e5b0b0035..24dcaa55bc46 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -587,7 +587,7 @@ static int
On Wed, Dec 21, 2022 at 10:15:28PM +, Peter Maydell wrote:
> On Wed, 21 Dec 2022 at 16:03, Cédric Le Goater wrote:
> >
> > On 12/21/22 13:33, Peter Maydell wrote:
> > > On Wed, 21 Dec 2022 at 01:35, David Gibson
> > > wrote:
> > >> On Mon, De
code is not consistent in another places :
> >
> > hw/ppc/spapr_tpm_proxy.c uses a uint64_t
> > hw/ppc/spapr_hcall.c, a target_ulong
> > hw/ppc/spapr_rtas.c, a hwaddr
> > hw/ppc/spapr_drc.c, a hwaddr indirectly
> >
> > Should we change ppc64_phys_to_r
On Mon, Dec 19, 2022 at 10:39:40AM +, Peter Maydell wrote:
> On Mon, 19 Dec 2022 at 06:35, David Gibson
> wrote:
> >
> > On Fri, Dec 16, 2022 at 09:39:19PM +, Peter Maydell wrote:
> > > On Fri, 16 Dec 2022 at 19:11, Daniel He
ors. When these
macros were created, an ISA nearly always used the same endianness,
but that's not really true any more - not just for POWER, but for a
bunch of targets. So from that point of view, I think getting rid of
tswap() - particularly one that has compile time semantics, rather
tha
time since the middle
> > of the 7.2 development cycle.
> >
>
> Great thanks Daniel for all your contributions over
> the years, and for being the one steering the vessel
> to the dry dock. This is it.
Seconded.
Reviewed-by: David Gibson
>
> > Change the status of PPC KVM
On Wed, Oct 05, 2022 at 06:20:39PM +0200, Laurent Vivier wrote:
> Embed the setting of info_str in a function.
>
> Signed-off-by: Laurent Vivier
Reviewed-by: David Gibson
> ---
> include/net/net.h | 1 +
> net/l2tpv3.c | 3 +--
> net/net.c | 17 +++
no Brivio
> [lvivier: applied to net/stream.c]
> Signed-off-by: Laurent Vivier
> Reviewed-by: Daniel P. Berrangé
Reviewed-by: David Gibson
> ---
> net/stream.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/stream.c b/net/stream.c
> ind
Brivio
> Signed-off-by: Laurent Vivier
Reviewed-by: David Gibson
> ---
> net/socket.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index ade1ecf38b87..4944bb70d580 100644
> --- a/net/socket.c
> +++
On Wed, Oct 05, 2022 at 12:08:27PM +0200, Laurent Vivier wrote:
> On 9/28/22 07:55, David Gibson wrote:
> > > +static int net_stream_server_init(NetClientState *peer,
> > > + const char *model,
> > > +
On Wed, Oct 05, 2022 at 03:38:09PM +0200, Laurent Vivier wrote:
> On 9/28/22 08:12, David Gibson wrote:
> > > @@ -253,9 +253,27 @@ static void net_stream_accept(void *opaque)
> > > s->fd = fd;
> > > s->nc.link_down = false;
> > >
e I am not
> > funded for this work.
> >
> > Signed-off-by: Cédric Le Goater
> > ---
>
> End of an era. Thank you for all the dedication and accomplishments !
Seconded.
Reviewed-by: David Gibson
>
> Reviewed-by: Greg Kurz
>
> > MAINTAINERS | 10 +-
t;nc.info_str, sizeof(s->nc.info_str), info_str);
> +g_free(info_str);
> +
> +return 0;
> +}
> +
> +int net_init_stream(const Netdev *netdev, const char *name,
> +NetClientState *peer, Error **errp)
> +{
> +const NetdevStreamOpti
On Mon, Sep 26, 2022 at 09:50:33PM +0200, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> Reviewed-by: Stefano Brivio
Reviewed-by: David Gibson
> ---
> include/qemu/sockets.h | 2 ++
> net/net.c | 62 ++
> 2
> Reviewed-by: Markus Armbruster
Reviewed-by: David Gibson
> ---
> include/net/net.h | 2 +-
> net/net.c | 6 ++
> softmmu/vl.c | 12 +++-
> 3 files changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/include/net/net.h b/include/net/ne
n Gilbert
> Reviewed-by: Markus Armbruster
Reviewed-by: David Gibson
> ---
> util/qemu-sockets.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index 9f6f655fd526..a9926af714c4 100644
> --- a/u
On Mon, Sep 26, 2022 at 09:50:43PM +0200, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> Reviewed-by: Stefano Brivio
Reviewed-by: David Gibson
Although one note below.
> ---
> net/dgram.c | 65 ++---
> qapi/net.json
ver socket (default: true)
> #
> -# Only SocketAddress types 'inet' and 'fd' are supported.
> +# Only SocketAddress types 'unix', 'inet' and 'fd' are supported.
> #
> # Since: 7.1
> ##
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 8c765f345da8..7a34022ac651 100644
> ---
uct sockaddr_in laddr_in;
> +struct sockaddr_in laddr_in, raddr_in;
>
> if (convert_host_port(_in, local->u.inet.host,
> local->u.inet.port,
>errp) < 0) {
> @@ -492,9 +503,12 @@ static int net_dgram_init(NetClientState *peer,
> }
} else {
> error_setg_errno(errp, errno, "can't connect socket");
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
s from a string.
>
> Signed-off-by: Laurent Vivier
Reviewed-by: David Gibson
> ---
> include/qemu/sockets.h | 2 +-
> monitor/hmp-cmds.c | 23 +--
> util/qemu-sockets.c| 20
> 3 files changed, 22 insertions(+), 23 deletio
ed.
> #
> # Since: 7.1
> ##
> diff --git a/qemu-options.hx b/qemu-options.hx
> index bb16a61bae8e..8870bcce6bcd 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2733,6 +2733,7 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
> "configure a network backend to connect to another
> network\n"
> "using an UDP tunnel\n"
> "-netdev
> stream,id=str[,server=on|off],addr.type=inet,addr.host=host,addr.port=port\n"
> +"-netdev stream,id=str[,server=on|off],addr.type=unix,addr.path=path\n"
> "-netdev stream,id=str[,server=on|off],addr.type=fd,addr.str=h\n"
> "configure a network backend to connect to another
> network\n"
> "using a socket connection in stream mode.\n"
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
name, fd);
> +return -1;
> +}
> +connected = 1;
> +info_str = g_strdup_printf("connect to fd %d", fd);
> +break;
> +default:
> +error_setg(errp, "only support inet or fd type");
> +return -1;
> +}
>
by: Markus Armbruster
Reviewed-by: David Gibson
> ---
> include/net/net.h | 2 +-
> net/net.c | 20 +++-
> softmmu/vl.c | 2 +-
> 3 files changed, 9 insertions(+), 15 deletions(-)
>
> diff --git a/include/net/net.h b/include/net/net.h
> Reviewed-by: Markus Armbruster
Reviewed-by: David Gibson
> ---
> include/net/net.h | 2 +-
> net/net.c | 6 ++
> softmmu/vl.c | 12 +++-
> 3 files changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/include/net/net.h b/include/net/ne
On Tue, Sep 13, 2022 at 08:39:47AM +0200, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> Reviewed-by: Stefano Brivio
Reviewed-by: David Gibson
Although, if you do respin, an actual commit message would be nice to
have.
> ---
> include/qemu/sockets.h | 2 ++
On Tue, Aug 30, 2022 at 12:43:23PM +0200, Markus Armbruster wrote:
> David Gibson writes:
>
> > On Mon, Aug 29, 2022 at 07:00:55PM -0300, Daniel Henrique Barboza wrote:
> >>
> >>
> >> On 8/29/22 00:34, David Gibson wrote:
> >> > On Fri, Aug 26
On Mon, Aug 22, 2022 at 07:30:36AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/22/22 00:29, Alexey Kardashevskiy wrote:
> >
> >
> > On 22/08/2022 13:05, David Gibson wrote:
> > > On Fri, Aug 19, 2022 at 06:42:34AM -0300, Daniel Henrique Barboza wrote:
On Mon, Aug 29, 2022 at 07:00:55PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/29/22 00:34, David Gibson wrote:
> > On Fri, Aug 26, 2022 at 11:11:44AM -0300, Daniel Henrique Barboza wrote:
> > > Reading the FDT requires that the user saves the fdt_blob and then
4;
> +
> +fdt_for_each_property_offset(property, fdt, node) {
> +prop = fdt_get_property_by_offset(fdt, property, _size);
> +propname = fdt_string(fdt, fdt32_to_cpu(prop->nameoff));
> +
> +g_string_append_printf(buf, "%*s%s;\n", padding, "&q
ifically the boot time DT before guest firmware or OS
does any further mangling of it. That's effectively what it means for
all the other embedded cases, though in those cases the firmware
usually doesn't need to do further modifications, unlike a "full OF"
environment like spapr.
Reviewed-
esting though, was merely to make
ms::fdt accessible as a single bytestring property on the machine QOM
object. Effectively it's just "dumpdtb" but as a property get.
I'm not 100% certain if QOM can safely represent arbitrary bytestrings
as QOM properties,
have additional funtionality in formatting
the contents more helpfully.
> Another thing is that on every HMP dump I'd probably rebuild the entire FDT
> for the reasons David explained. Thanks,
This would require per-machine hooks, however.
--
David Gibson| I'll h
On Mon, Aug 15, 2022 at 07:48:14PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/8/22 01:21, David Gibson wrote:
> > On Fri, Aug 05, 2022 at 06:39:43AM -0300, Daniel Henrique Barboza wrote:
> > > Reading the FDT requires that the user saves the fdt_blob and then
1, ram_high_sz);
> >> +fdt_pack(fdt);
> >> fdt = g_realloc(fdt, fdt_totalsize(fdt));
> >> qemu_fdt_dumpdtb(fdt, fdt_sz);
> >>
> >
> > Why not pack by default in qemu_fdt_dumpdtb()?
>
> qemu_fdt_dumpdtb() i
path_offset(fdt, nodepath);
> if (node < 0) {
> error_setg(errp, "node '%s' not found in FDT", nodepath);
> return NULL;
> }
>
> -fdt_format_node(buf, node, 0, nodepath);
> +if (!has_propname) {
> +fdt_format_node(buf, node, 0, no
em
> directly like that to save some clutter. No functional change intended.
>
> Signed-off-by: Matheus Ferst
Good idea.
Reviewed-by: David Gibson
> ---
> hw/ppc/ppc.c | 10 +++---
> hw/ppc/trace-events | 2 +-
> target/ppc/cpu.h | 40 +++-
= NULL;
> @@ -681,7 +738,12 @@ static void fdt_format_node(GString *buf, int node, int
> depth)
> prop = fdt_get_property_by_offset(fdt, property, _size);
> propname = fdt_string(fdt, fdt32_to_cpu(prop->nameoff));
>
> -g_string_append_printf(buf, "%*s%s;\n", padding, "", propname);
> +if (fdt_prop_is_string_array(prop->data, prop_size)) {
> +fdt_prop_format_string_array(buf, propname, prop->data,
> + prop_size, padding);
> +} else {
> +g_string_append_printf(buf, "%*s%s;\n", padding, "", propname);
> +}
> }
>
> padding -= 4;
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
g_string_append_printf(buf, "%*s}\n", padding, "");
> }
> @@ -821,7 +834,7 @@ HumanReadableText *qemu_fdt_qmp_query_fdt(const char
> *nodepath, Error **errp)
> return NULL;
> }
>
> -fdt_format_node(buf, node, 0);
> +fdt_fo
> +/*
> + * Set the machine->fdt pointer again since we just freed
> + * it above (by freeing spapr->fdt_blob). We set this
> + * pointer to enable support for 'dumpdtb' and 'info fdt'
> + * QMP/HMP commands.
> + */
> +MACHINE(spapr)->fdt = fdt;
> +
>
On Fri, Aug 12, 2022 at 07:23:09PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/8/22 00:26, David Gibson wrote:
> > On Fri, Aug 05, 2022 at 06:39:38AM -0300, Daniel Henrique Barboza wrote:
> > > The pSeries machine never bothered with the common machine->fdt
On Fri, Aug 12, 2022 at 07:03:26PM -0300, Daniel Henrique Barboza wrote:
> David,
>
> On 8/8/22 00:23, David Gibson wrote:
> > On Fri, Aug 05, 2022 at 06:39:29AM -0300, Daniel Henrique Barboza wrote:
> > > At this moment, arm_load_dtb() can free machine->fdt when
> &
On Wed, Aug 10, 2022 at 04:40:18PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/8/22 01:36, David Gibson wrote:
> > On Fri, Aug 05, 2022 at 06:39:44AM -0300, Daniel Henrique Barboza wrote:
> > > To support printing string properties in 'info fdt' we need to determ
quot;);
So, this lists it in dts format... kind of. Because you don't include
the property values, it makes it look like all properties are binary
(either absent or present-but-empty). I think that's misleading. If
you're only going to list properties, I think you'd be better off
using different formatti
t;", propname, prop->data);
If you're going for dts like output, I'd suggest going all the way.
That means \" instead of \' and a ';' at the end of the line.
> +} else {
> +g_string_append_printf(buf, "%*s%s;\n", padding, "", propname);
> +}
> }
>
> padding -= 4;
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
t; +
> if (fdt_prop_is_string(prop->data, prop_size)) {
> g_string_append_printf(buf, "%*s%s = '%s'\n",
> padding, "", propname, prop->data);
> +} else if (fdt_prop_is_uint32_array(prop_size)) {
&g
e if we issue a 'system_reset' via the
> monitor.
Right. I'm not certain about pnv, but on most platforms there's a way
to trigger system_reset from the guest side as well.
> I'll put a g_free(machine->fdt) before the assignment.
>
>
> Daniel
>
>
> >
> > Fred
>
e (reduce) the effective size of the dtb blob,
so returning a 'size' value from above rather than the new value of
fdt_totalsize(fdt) doesn't see right.
I believe some of the other patches in the series have similar concerns.
--
David Gibson| I'll have my music baroque, and
bove (by freeing spapr->fdt_blob). We set this
> + * pointer to enable support for 'dumpdtb' and 'info fdt'
> + * HMP commands.
> + */
> +MACHINE(spapr)->fdt = fdt;
> +
> return H_SUCCESS;
> }
>
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
mu/device_tree.c
> index 6ca3fad285..cd487ddd4d 100644
> --- a/softmmu/device_tree.c
> +++ b/softmmu/device_tree.c
> @@ -643,3 +643,21 @@ out:
> g_free(propcells);
> return ret;
> }
> +
> +void qemu_fdt_qmp_dumpdtb(const char *filename, Error **errp)
> +{
>
osas
Reviewed-by: David Gibson
and, I believe, mea culpa.
> ---
> v2:
> - Skip current and parent directories.
>
> v1:
> https://lore.kernel.org/qemu-devel/20220711193743.51456-1-muri...@linux.ibm.com/
>
> target/ppc/kvm.c | 6 ++
> 1 file changed, 6 insertio
t; > + " DECR " TARGET_FMT_lu
> > #endif
> > - "\n",
> > - cpu_ppc_load_tbu(env), cpu_ppc_load_tbl(env)
> > + "\n",
> > + cpu_ppc_load_tbu(en
now, but it would be technically more
correct to also skip ".", wouldn't it?
> +continue;
> +}
> +
> snprintf(buf, buf_len, "%s%s/clock-frequency", PROC_DEVTREE_CPU,
> dirp->d_name);
> f = fopen(buf, &
On Thu, Apr 14, 2022 at 03:46:59AM -0700, Yi Liu wrote:
> Qomify the VFIOContainer object which acts as a base class for a
> container. This base class is derived into the legacy VFIO container
> and later on, into the new iommufd based container.
You certainly need the abstraction, but I'm not
not find nvdimm device with DRC 0x%u",
> + state->drcidx);
> +return;
> +}
> +
> +s_nvdimm = SPAPR_NVDIMM(drc->dev);
>
> state->hcall_ret = hcall_ret;
> QLIST_REMOVE(state, node);
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
e is running QEMU with KVM enabled
> under valgrind anyway? Valgrind has no way of knowing about
> writes to memory that the guest vCPUs do...
Those should be limited to the guest memory area though, which as
mmap()ed space would already be considered initialized, I believe. If
there's so
bring benefit for its other callers.
>
> This patch uses the memcheck VALGRING_MAKE_MEM_DEFINED() to mark the
> 'target' variable as initialized if the ioctl is successful.
>
> Cc: Paolo Bonzini
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: David Gibson
> ---
> acc
that it
> > covers all kvm hosts. But it's too late to do this for 7.0.
>
> I wasn't planning on pushing these changes for 7.0 since they aren't fixing
> mem
> leaks or anything really bad. It's more of a quality of life improvement when
> using Valgrind.
>
> I also
On Thu, Mar 31, 2022 at 02:17:42PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 3/30/22 22:25, David Gibson wrote:
> > On Wed, Mar 30, 2022 at 09:17:15PM -0300, Daniel Henrique Barboza wrote:
> > > 'lpcr' is used as an input of kvm_get_one_reg(). Valgrind
On Mon, Mar 14, 2022 at 07:10:10PM -0300, Fabiano Rosas wrote:
> David Gibson writes:
>
> > On Tue, Mar 08, 2022 at 10:23:59PM -0300, Fabiano Rosas wrote:
> >> QEMU reports MMU support to the guest via the ibm,architecture-vec-5
> >> property of the /chosen node.
nt64_t lpcr = 0;
>
> kvm_get_one_reg(cs, KVM_REG_PPC_LPCR_64, );
> /* Do we need to modify the LPCR? */
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
at 0xB11F08: kvm_get_one_spr (kvm.c:543)
>
> Initializing 'val' has no impact in the logic and makes Valgrind output
> more bearable.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: David Gibson
> ---
> target/ppc/kvm.c | 3
qdev_realize (qdev.c:333)
> ==636935==
>
> This patch adds a cpu_ppc_tb_free() helper in hw/ppc/ppc.c to allow us
> to free the timebase. This leak is then solved by calling
> cpu_ppc_tb_free() in spapr_unrealize_vcpu().
>
> Fixes: 6f4b5c3ec590 ("spapr: CPU hot unplug suppor
ique Barboza (2):
> hw/ppc/ppc.c: add cpu_ppc_tb_free()
> hw/ppc: free env->tb_env in spapr_unrealize_vcpu()
>
> hw/ppc/ppc.c| 7 +++
> hw/ppc/spapr_cpu_core.c | 3 +++
> include/hw/ppc/ppc.h | 1 +
> 3 files changed, 11 insertions(+)
>
--
Da
;excp_model == POWERPC_EXCP_POWER10) {
> > +attn = !!(env->spr[SPR_HID0] & HID0_POWER9_ATTN);
> > +}
>
> The excp_model is not a CPU identifier. This should ideally be a flag
> set during init_proc. Something like HID0_ATTN_P8/HID0_ATTN_P9.
>
&g
vmsd = _spapr_drc_physical;
> +
> drck->dr_entity_sense = physical_entity_sense;
> drck->isolate = drc_isolate_physical;
> drck->unisolate = drc_unisolate_physical;
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropb
tected when testing migration scenarios with
> hotplug/unplug of devices.
Looks good tome.
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http
On Mon, Mar 21, 2022 at 04:58:47AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 3/21/22 00:55, David Gibson wrote:
> > On Fri, Mar 18, 2022 at 02:33:11PM -0300, Daniel Henrique Barboza wrote:
> > > Hi,
> > >
> > > I decided to make this chang
On Fri, Mar 18, 2022 at 10:41:19AM -0300, Fabiano Rosas wrote:
> David Gibson writes:
>
> > On Thu, Mar 17, 2022 at 02:20:47PM -0300, Fabiano Rosas wrote:
> >> It is possible that nested KVM hypercalls reach QEMU while we're
> >> running KVM. The spapr vir
drc.c | 79 +++---
> hw/ppc/spapr_events.c | 4 +-
> hw/ppc/spapr_nvdimm.c | 10 ++---
> hw/ppc/spapr_pci.c | 5 +--
> include/hw/ppc/spapr_drc.h | 2 +-
> 6 files changed, 48 insertions(+), 70 deletions(-)
>
--
David
On Fri, Mar 18, 2022 at 04:51:10PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 3/18/22 00:43, David Gibson wrote:
> > On Thu, Mar 17, 2022 at 04:29:14PM +, Dr. David Alan Gilbert wrote:
> > > * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > > >
(KVMPPC_H_UPDATE_DT, h_update_dt);
> -
> -spapr_register_hypercall(KVMPPC_H_SET_PARTITION_TABLE, h_set_ptbl);
> -spapr_register_hypercall(KVMPPC_H_ENTER_NESTED, h_enter_nested);
> -spapr_register_hypercall(KVMPPC_H_TLB_INVALIDATE, h_tlb_invalidate);
> -spapr_
named by, then
> the instance_id is used to uniquify them.
Thanks for the information. I remember deciding at the time that just
using vmsd wouldn't work for the DRCs because we needed this fixed
index. At the time either qdev_set_legacy_instance_id() didn't exist,
or I didn't know about it,
led()) {
> + return H_FUNCTION;
> +}
> +
> if (spapr->nested_ptcr == 0) {
> return H_NOT_AVAILABLE;
> }
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
t32_t pvr)
> {
> -if ((pvr & CPU_POWERPC_POWER_SERVER_MASK) == CPU_POWERPC_POWER10_BASE) {
> +uint32_t base = pvr & CPU_POWERPC_POWER_SERVER_MASK;
> +uint32_t pcc_base = pcc->pvr & CPU_POWERPC_POWER_SERVER_MASK;
> +
> +if (base != pcc_base) {
> +
= 0x004E0200,
> CPU_POWERPC_POWER10_BASE = 0x0080,
> CPU_POWERPC_POWER10_DD1 = 0x00800100,
> CPU_POWERPC_POWER10_DD20 = 0x00800200,
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | mi
a/target/ppc/kvm_ppc.h
> +++ b/target/ppc/kvm_ppc.h
> @@ -63,6 +63,7 @@ bool kvmppc_has_cap_fixup_hcalls(void);
> bool kvmppc_has_cap_htm(void);
> bool kvmppc_has_cap_mmu_radix(void);
> bool kvmppc_has_cap_mmu_hash_v3(void);
> +bool kvmppc_has_cap_gtse(void);
> bool kvmppc_has_ca
On Mon, Feb 28, 2022 at 02:49:53PM -0300, Daniel Henrique Barboza wrote:
> And get rid of the 'out' label since it's now used.
s/used/unused/
>
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: David Gibson
> ---
> hw/ppc/spapr_caps.c | 8 +++-
> 1 file changed,
On Mon, Feb 28, 2022 at 02:49:55PM -0300, Daniel Henrique Barboza wrote:
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: David Gibson
> ---
> hw/ppc/spapr_caps.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/ppc/spapr_caps.c b/h
On Mon, Feb 28, 2022 at 02:49:54PM -0300, Daniel Henrique Barboza wrote:
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: David Gibson
> ---
> hw/ppc/spapr_caps.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/hw/ppc/spapr_caps.c b/h
e' pointer.
>
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: David Gibson
> ---
> hw/ppc/spapr.c | 24 +++-
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index c74543ace3..4cc204f90d 1
On Mon, Feb 28, 2022 at 02:49:51PM -0300, Daniel Henrique Barboza wrote:
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: David Gibson
> ---
> hw/ppc/spapr.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/p
1 - 100 of 15362 matches
Mail list logo
