[Qemu-devel] [PATCH v5 04/15] qcow2: cleanup qcow2_co_pwritev_compressed to avoid the recursion

From: Pavel Butsykin <pbutsy...@virtuozzo.com> Since the function became use a vector instead of a buffer there is no sense to use a recursive code. Signed-off-by: Pavel Butsykin <pbutsy...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Jeff Cody <jc...@r

Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

On 06/30/2016 07:40 PM, John Snow wrote: On 06/30/2016 05:12 AM, Denis V. Lunev wrote: On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: After loading bitmap from image and setting IN_USE flag in it's header, corresponding data (bitmap table and data clusters) becomes inconsistent

Re: [Qemu-devel] [PATCH] spec/parallels: fix a mistake

On 06/30/2016 07:43 PM, John Snow wrote: On 06/30/2016 04:15 AM, Vladimir Sementsov-Ogievskiy wrote: We have only one flag for now - Empty Image flag. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/specs/parallels.txt | 2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom

On 06/24/2016 01:49 PM, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required feature words are set in cpuid leaf 4003 t

Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: After loading bitmap from image and setting IN_USE flag in it's header, corresponding data (bitmap table and data clusters) becomes inconsistent and is no longer needed. It is better to free bitmap table and corresponding clusters from

[Qemu-devel] [PATCH 1/1] spec/parallels: fix a mistake

From: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> We have only one flag for now - Empty Image flag. The patch fixes unused bits specification and marks bit 1 as usused. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Signed-off-by: Denis

Re: [Qemu-devel] [PATCH 1/1] mirror: fix request throttling in drive-mirror

On 06/29/2016 07:08 PM, Max Reitz wrote: On 22.06.2016 14:35, Denis V. Lunev wrote: There are 2 deficiencies here: - mirror_iteration could start several requests inside. Thus we could simply have more in_flight requests than MAX_IN_FLIGHT. - keeping this in mind throttling in mirror_run

Re: [Qemu-devel] [PATCH 1/3] block: ignore flush requests when storage is clean

On 06/29/2016 10:36 AM, Paolo Bonzini wrote: On 28/06/2016 23:01, Paolo Bonzini wrote: On 24/06/2016 17:06, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> Some guests (win2008 server for example) do a lot of unnecessary flushing when underlying media has not c

Re: [Qemu-devel] [PATCH v4 1/3] block: ignore flush requests when storage is clean

On 06/29/2016 04:12 AM, Fam Zheng wrote: On Tue, 06/28 12:10, Denis V. Lunev wrote: On 06/28/2016 04:27 AM, Fam Zheng wrote: On Mon, 06/27 17:47, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> Some guests (win2008 server for example) do a lot of unnecessary fl

Re: [Qemu-devel] [PULL 6/8] qemu-img: move common options parsing before commands processing

On 06/29/2016 12:27 AM, Stefan Hajnoczi wrote: From: "Denis V. Lunev" <d...@openvz.org> This is necessary to enable creation of common qemu-img options which will be specified before command. The patch also enables '-V' alias to '--version' (exactly like in other block utilitie

Re: [Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO

On 06/28/2016 05:22 PM, Eric Blake wrote: On 06/28/2016 05:21 AM, Denis V. Lunev wrote: On 06/23/2016 02:37 PM, Denis V. Lunev wrote: Partial write most likely means that there is not space rather than "something wrong happens". Thus it would be more natural to return ENOSPC rather t

Re: [Qemu-devel] [PATCH 1/1] mirror: fix request throttling in drive-mirror

On 06/22/2016 03:35 PM, Denis V. Lunev wrote: There are 2 deficiencies here: - mirror_iteration could start several requests inside. Thus we could simply have more in_flight requests than MAX_IN_FLIGHT. - keeping this in mind throttling in mirror_run which is checking s->in_fli

Re: [Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO

On 06/23/2016 02:37 PM, Denis V. Lunev wrote: Partial write most likely means that there is not space rather than "something wrong happens". Thus it would be more natural to return ENOSPC rather than EINVAL. The problem actually happens with NBD server, which has reported EIN

Re: [Qemu-devel] [PATCH v4 1/3] block: ignore flush requests when storage is clean

On 06/28/2016 04:27 AM, Fam Zheng wrote: On Mon, 06/27 17:47, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> Some guests (win2008 server for example) do a lot of unnecessary flushing when underlying media has not changed. This adds additional overhead on hos

Re: [Qemu-devel] [PATCH v4 3/3] tests: in IDE and AHCI tests perform DMA write before flushing

On 06/28/2016 02:19 AM, John Snow wrote: On 06/27/2016 10:47 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> Due to changes in flush behaviour clean disks stopped generating flush_to_disk events and IDE and AHCI tests that test flush commands started t

[Qemu-devel] [PATCH v4 3/3] tests: in IDE and AHCI tests perform DMA write before flushing

nds so that bdrv_flush actually generates flush_to_disk event. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com>

[Qemu-devel] [PATCH v4 1/3] block: ignore flush requests when storage is clean

0.432 loops/sec. Each loop creates 10^3 directories with 10 files in each. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Stefan Hajnoczi <s

[Qemu-devel] [PATCH v4 2/3] ide: ignore retry_unit check for non-retry operation

s->unit. But s->retry_unit is still -1 after previous DMA completion and flush does not use anything related to retry. This patch restricts retry unit assertion only to ops that actually use retry logic. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d

[Qemu-devel] [PATCH v4 0/3] block: ignore flush requests when storage is clean

and AHCI tests to dirty media for new flush behaviour - Fixed a problem in IDE CMD_FLUSH_CACHE failure handling Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com

[Qemu-devel] [PATCH 3/3] tests: in IDE and AHCI tests perform DMA write before flushing

nds so that bdrv_flush actually generates flush_to_disk event. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.co

[Qemu-devel] [PATCH 1/3] block: ignore flush requests when storage is clean

0.432 loops/sec. Each loop creates 10^3 directories with 10 files in each. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Stefan Hajnoczi <s

[Qemu-devel] [PATCH 0/3] block: ignore flush requests when storage is clean

CMD_FLUSH_CACHE failure handling Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Fam Zheng <f...@redhat.com

[Qemu-devel] [PATCH 2/3] ide: ignore retry_unit check for non-retry operations

s->unit. But s->retry_unit is still -1 after previous DMA completion and flush does not use anything related to retry. This patch restricts retry unit assertion only to ops that actually use retry logic. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d

[Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom

report hyperv feature words which prevents windows guests from starting with libvirt. To avoid conflicting with current hyperv properties all added feature words cannot be set directly with -cpu +feature yet. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis

[Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO

col, which makes report to the user wrong. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Pavel Borzenkov <pborzen...@virtuozzo.com> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> --- block/linux-aio.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [Qemu-devel] [PATCH v9 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

On 06/17/2016 05:44 PM, Denis V. Lunev wrote: Changes from v8: - fixed comment in patch 3 - changed stub for trace_opt_parse() Changes from v7: - added missed qemu-option-trace.texi Changes from v6: - changed order of patches 1 & 2 Changes from v5: - added missed hunk into patch #7 Cha

Re: [Qemu-devel] [PATCH v9 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

On 06/17/2016 05:44 PM, Denis V. Lunev wrote: Changes from v8: - fixed comment in patch 3 - changed stub for trace_opt_parse() Changes from v7: - added missed qemu-option-trace.texi Changes from v6: - changed order of patches 1 & 2 Changes from v5: - added missed hunk into patch #7 Cha

[Qemu-devel] [PATCH 1/1] mirror: fix request throttling in drive-mirror

eck and throttling into mirror_iteration and fixes the check in mirror_run() to be sure. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Jeff Cody <jc...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> --- block/mirror.c | 7 ++- 1 file

[Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration()

trace_mirror_yield_in_flight accepts 2nd arguments in sectors while here we pass chunks instead. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Jeff Cody <jc...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> --- Changes from v1: - pr

Re: [Qemu-devel] [PATCH v9 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

On 06/17/2016 05:44 PM, Denis V. Lunev wrote: Changes from v8: - fixed comment in patch 3 - changed stub for trace_opt_parse() Changes from v7: - added missed qemu-option-trace.texi Changes from v6: - changed order of patches 1 & 2 Changes from v5: - added missed hunk into patch #7 Cha

Re: [Qemu-devel] [PATCH 1/1] block: ignore flush requests when storage is clean

On 06/21/2016 10:32 AM, Paolo Bonzini wrote: On 20/06/2016 17:19, Denis V. Lunev wrote: +/* Check if storage is actually dirty before flushing to disk */ +if (!bs->dirty) { +goto flush_parent; +} +bs->dirty = false; + This should be cleared after the flush is co

Re: [Qemu-devel] [PATCH 1/1] block: ignore flush requests when storage is clean

On 06/21/2016 10:45 AM, Kevin Wolf wrote: Am 21.06.2016 um 09:32 hat Paolo Bonzini geschrieben: On 20/06/2016 17:19, Denis V. Lunev wrote: +/* Check if storage is actually dirty before flushing to disk */ +if (!bs->dirty) { +goto flush_parent; +} +bs->dirty =

[Qemu-devel] [PATCH v2 1/1] cpu: report hyperv feature words through qom

report hyperv feature words which prevents windows guests from starting with libvirt. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Richard Henderson <r...@twiddle.net&

[Qemu-devel] [PATCH 1/1] block: ignore flush requests when storage is clean

0.432 loops/sec. Each loop creates 10^3 directories with 10 files in each. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Stefan Hajnoczi <s

[Qemu-devel] [Bug 1593605] Re: windows2008r2 boot failed with uefi

Actually I can provide you with the patch which makes win2k8 + UEFI working if you willing to accept it for mainstream QEMU. It was quite simple. We have prepared it but not sent. Parallels Server 6/Parallels Desktop have this hack around 3-5 years. I have missed you comment. Closing again. **

[Qemu-devel] [Bug 1593605] Re: windows2008r2 boot failed with uefi

sorry, I meant not QEMU but UEFI above. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1593605 Title: windows2008r2 boot failed with uefi Status in QEMU: Invalid Bug description: I want to

[Qemu-devel] [Bug 1593605] Re: windows2008r2 boot failed with uefi

** Changed in: qemu Status: Invalid => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1593605 Title: windows2008r2 boot failed with uefi Status in QEMU: Confirmed Bug

[Qemu-devel] [Bug 1593605] Re: windows2008r2 boot failed with uefi

you CAN run, but you have to disable HyperV enlightments. This means that these options "hv_time,hv_relaxed,hv_spinlocks=0x2000" must NOT be set. I have not found exact patch, sorry. But something like the following should be done even to start thinking on running win2k8 with EFI if HyperV is

[Qemu-devel] [Bug 1593605] Re: windows2008r2 boot failed with uefi

Win2k8 EFI has a bug under HyperV. This will never work without a specific hack in UEFI. I can dig in my archives to find a patch if you are really interested in. AFAIR some memory in video driver has to be marked not as boot services but differently and will stay permanently. -- You received

[Qemu-devel] [PATCH 7/7] trace: enable tracing in qemu-img

The command will work this way: qemu-img --trace qcow2* create -f qcow2 1.img 64G Signed-off-by: Denis V. Lunev <d...@openvz.org> Suggested by: Daniel P. Berrange <berra...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@

[Qemu-devel] [PATCH v9 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

is V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> Denis V. Lunev (7): doc: sync help descriprion for --trace with man for

[Qemu-devel] [PATCH 2/7] doc: move text describing --trace to specific .texi file

This text will be included to qemu-nbd/qemu-img mans in the next patches. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw..

[Qemu-devel] [PATCH 5/7] trace: enable tracing in qemu-nbd

Please note, trace_init_backends() must be called in the final process, i.e. after daemonization. This is necessary to keep tracing thread in the proper process. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Stefan Haj

[Qemu-devel] [PATCH 6/7] qemu-img: move common options parsing before commands processing

This is necessary to enable creation of common qemu-img options which will be specified before command. The patch also enables '-V' alias to '--version' (exactly like in other block utilities) and documents this change. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blak

[Qemu-devel] [PATCH 3/7] trace: move qemu_trace_opts to trace/control.c

The patch also creates trace_opt_parse() helper in trace/control.c to reuse this code in next patches for qemu-nbd and qemu-io. The patch also makes trace_init_events() static, as this call is not used outside the module anymore. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by

[Qemu-devel] [PATCH 4/7] trace: enable tracing in qemu-io

Moving trace_init_backends() into trace_opt_parse() is not possible. This should be called after daemonize() in vl.c. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> CC: Pa

[Qemu-devel] [PATCH 1/7] doc: sync help descriprion for --trace with man for qemu.1

Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> --- qemu-options.hx | 2 +- 1 file changed, 1 ins

[Qemu-devel] [PATCH 4/7] trace: enable tracing in qemu-io

Moving trace_init_backends() into trace_opt_parse() is not possible. This should be called after daemonize() in vl.c. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Stefan Hajnoczi <st

[Qemu-devel] [PATCH 3/7] trace: move qemu_trace_opts to trace/control.c

The patch also creates trace_opt_parse() helper in trace/control.c to reuse this code in next patches for qemu-nbd and qemu-io. The patch also makes trace_init_events() static, as this call is not used outside the module anymore. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by

[Qemu-devel] [PATCH 6/7] qemu-img: move common options parsing before commands processing

This is necessary to enable creation of common qemu-img options which will be specified before command. The patch also enables '-V' alias to '--version' (exactly like in other block utilities) and documents this change. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blak

[Qemu-devel] [PATCH v8 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

m v2: - tweaked man-pages of qemu-nbd/qemu-img - added support for qemu-img (patches 4-5 as suggested) Changes from v1: - fixed nits found by Eric Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC:

[Qemu-devel] [PATCH 2/7] doc: move text describing --trace to specific .texi file

This text will be included to qemu-nbd/qemu-img mans in the next patches. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw..

[Qemu-devel] [PATCH 1/7] doc: sync help descriprion for --trace with man for qemu.1

Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> --- qemu-options.hx | 2 +- 1 file changed, 1 insertion

[Qemu-devel] [PATCH 7/7] trace: enable tracing in qemu-img

The command will work this way: qemu-img --trace qcow2* create -f qcow2 1.img 64G Signed-off-by: Denis V. Lunev <d...@openvz.org> Suggested by: Daniel P. Berrange <berra...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com

[Qemu-devel] [PATCH 5/7] trace: enable tracing in qemu-nbd

Please note, trace_init_backends() must be called in the final process, i.e. after daemonization. This is necessary to keep tracing thread in the proper process. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...

Re: [Qemu-devel] [PATCH 2/7] doc: move text describing --trace to specific .texi file

On 06/17/2016 04:36 PM, Stefan Hajnoczi wrote: On Thu, Jun 16, 2016 at 10:15:07AM +0300, Denis V. Lunev wrote: This text will be included to qemu-nbd/qemu-img mans in the next patches. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: P

[Qemu-devel] [PATCH 2/3] block: fix race in bdrv_co_discard with drive-mirror

Actually we must set dirty bitmap dirty after we have written all our zeroes for correct processing in drive mirror code. In the other case we can face not zeroes in this area in mirror_iteration. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy&l

[Qemu-devel] [PATCH v2 0/3] potentially broken drive-mirror/drive-backup in bdrv_co_discard

to backup and it also must properly fill tracked request information. Changes from v1: - fixed problem in patch as pointed out by Vova - ported to current (was made on top of active block mirror) - minor spelling changes in commit messages Signed-off-by: Denis V. Lunev <d...@openvz.org> Re

[Qemu-devel] [PATCH 3/3] block: process before_write_notifiers in bdrv_co_discard

This is mandatory for correct backup creation. In the other case the content under this area would be lost. Dirty bits are set exactly like in bdrv_aligned_pwritev, i.e. they are set even if notifier has returned a error. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vl

[Qemu-devel] [PATCH 1/3] block: fixed BdrvTrackedRequest filling in bdrv_co_discard

The request area is specified in bytes, not in sectors. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> Reviewed-by: Fam Zheng <f...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf &l

Re: [Qemu-devel] [PATCH 2/3] block: fix race in bdrv_co_discard with drive-mirror

On 06/16/2016 12:34 PM, Vladimir Sementsov-Ogievskiy wrote: On 16.06.2016 09:58, Denis V. Lunev wrote: Actually we must set dirty bitmap dirty after we have written all our zeroes for correct processing in drive mirror code. In the other case we can face not zeroes in this dirty area

[Qemu-devel] [PATCH 6/7] qemu-img: move common options parsing before commands processing

This is necessary to enable creation of common qemu-img options which will be specified before command. The patch also enables '-V' alias to '--version' (exactly like in other block utilities) and documents this change. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blak

[Qemu-devel] [PATCH 4/7] trace: enable tracing in qemu-io

Moving trace_init_backends() into trace_opt_parse() is not possible. This should be called after daemonize() in vl.c. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Stefan Hajnoczi <st

[Qemu-devel] [PATCH 5/7] trace: enable tracing in qemu-nbd

Please note, trace_init_backends() must be called in the final process, i.e. after daemonization. This is necessary to keep tracing thread in the proper process. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...

[Qemu-devel] [PATCH 7/7] trace: enable tracing in qemu-img

The command will work this way: qemu-img --trace qcow2* create -f qcow2 1.img 64G Signed-off-by: Denis V. Lunev <d...@openvz.org> Suggested by: Daniel P. Berrange <berra...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com

[Qemu-devel] [PATCH 1/7] doc: sync help descriprion for --trace with man for qemu.1

Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> --- qemu-options.hx | 2 +- 1 file changed, 1 insertion

[Qemu-devel] [PATCH 3/7] trace: move qemu_trace_opts to trace/control.c

The patch also creates trace_opt_parse() helper in trace/control.c to reuse this code in next patches for qemu-nbd and qemu-io. The patch also makes trace_init_events() static, as this call is not used outside the module anymore. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by

[Qemu-devel] [PATCH 2/7] doc: move text describing --trace to specific .texi file

This text will be included to qemu-nbd/qemu-img mans in the next patches. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Kevin Wolf <kw..

[Qemu-devel] [PATCH v7 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

m v2: - tweaked man-pages of qemu-nbd/qemu-img - added support for qemu-img (patches 4-5 as suggested) Changes from v1: - fixed nits found by Eric Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC:

[Qemu-devel] [PATCH 1/3] block: fixed BdrvTrackedRequest filling in bdrv_co_discard

The request is area is specified in bytes, not in sectors. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Fam Zheng <f...@redhat.com> CC: Kevin Wolf <kw...@red

[Qemu-devel] [PATCH 3/3] block: process before_write_notifiers in bdrv_co_discard

This is mandatory for correct backup creation. In the other case the content under this area would be lost. Dirty bits are set exactly like in bdrv_aligned_pwritev, i.e. they are set even if notifier has returned a error. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Vladimir Sem

[Qemu-devel] [PATCH 2/3] block: fix race in bdrv_co_discard with drive-mirror

Actually we must set dirty bitmap dirty after we have written all our zeroes for correct processing in drive mirror code. In the other case we can face not zeroes in this dirty area there in mirror_iteration. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Vladimir Sementsov-Ogievskiy&l

[Qemu-devel] [PATCH 0/3] potentially broken drive-mirror/drive-backup in bdrv_co_discard

to backup and it also must properly fill tracked request information. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Fam Zheng <f...@redhat.com> CC: Kevin Wolf <kw..

Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io

On 06/14/2016 11:44 AM, Kevin Wolf wrote: Am 14.06.2016 um 10:34 hat Denis V. Lunev geschrieben: On 06/08/2016 02:23 PM, Kevin Wolf wrote: Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben: From: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Acquire aio context befo

Re: [Qemu-devel] [PATCH 1/1] vnc: remove unused depth argument in set_pixel_format

On 06/15/2016 06:10 PM, Paolo Bonzini wrote: On 15/06/2016 17:07, Denis V. Lunev wrote: On 06/06/2016 12:51 PM, Denis V. Lunev wrote: Spotted by coverity, reported by Paolo. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Gerd H

Re: [Qemu-devel] [PATCH 1/1] vnc: remove unused depth argument in set_pixel_format

On 06/06/2016 12:51 PM, Denis V. Lunev wrote: Spotted by coverity, reported by Paolo. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Gerd Hoffmann <kra...@redhat.com> --- ui/vnc.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[Qemu-devel] [PATCH 1/1] migration: fix inability to save VM after snapshot

in progress The problem is that qemu_savevm_state() calls migrate_init() which sets migration state to MIGRATION_STATUS_SETUP and never cleaned it up. This patch do the job. Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Juan Quintela <quint...@redhat.com> CC: Amit Shah <amit.

Re: [Qemu-devel] [PATCH 4/9] mirror: efficiently zero out target

On 06/15/2016 03:34 PM, Eric Blake wrote: On 06/15/2016 02:46 AM, Denis V. Lunev wrote: On 06/15/2016 06:00 AM, Eric Blake wrote: On 06/14/2016 09:25 AM, Denis V. Lunev wrote: With a bdrv_co_write_zeroes method on a target BDS zeroes will not be placed into the wire. Thus the target could

Re: [Qemu-devel] [PATCH 0/9] major rework of drive-mirror

On 06/15/2016 01:25 PM, Kevin Wolf wrote: Am 15.06.2016 um 11:34 hat Denis V. Lunev geschrieben: On 06/15/2016 12:06 PM, Kevin Wolf wrote: The second big thing is that I don't want to see new users of the notifiers in I/O functions. Let's try if we can't add a filter BlockDriver instead

Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk

On 06/15/2016 12:19 PM, Stefan Hajnoczi wrote: On Tue, Jun 14, 2016 at 09:20:47PM -0600, Eric Blake wrote: On 06/14/2016 09:25 AM, Denis V. Lunev wrote: We should not take into account zero blocks for delay calculations. They are not read and thus IO throttling is not required. In the other

Re: [Qemu-devel] [PATCH 0/9] major rework of drive-mirror

On 06/15/2016 12:06 PM, Kevin Wolf wrote: Am 14.06.2016 um 17:25 hat Denis V. Lunev geschrieben: Block commit of the active image to the backing store on a slow disk could never end. For example with the guest with the following loop inside while true; do dd bs=1k count=1 if=/dev

Re: [Qemu-devel] [PATCH 6/9] block: pass qiov into before_write notifier

On 06/15/2016 12:21 PM, Stefan Hajnoczi wrote: On Tue, Jun 14, 2016 at 06:25:13PM +0300, Denis V. Lunev wrote: Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...@redhat.com>

Re: [Qemu-devel] [PATCH 8/9] mirror: use synch scheme for drive mirror

On 06/15/2016 07:18 AM, Eric Blake wrote: On 06/14/2016 09:25 AM, Denis V. Lunev wrote: Block commit of the active image to the backing store on a slow disk could never end. For example with the guest with the following loop inside while true; do dd bs=1k count=1 if=/dev/zero of=x

Re: [Qemu-devel] [PATCH 4/9] mirror: efficiently zero out target

On 06/15/2016 06:00 AM, Eric Blake wrote: On 06/14/2016 09:25 AM, Denis V. Lunev wrote: With a bdrv_co_write_zeroes method on a target BDS zeroes will not be placed into the wire. Thus the target could be very efficiently zeroed out. This is should be done with the largest chunk possible

Re: [Qemu-devel] [PATCH 3/9] mirror: optimize dirty bitmap filling in mirror_run a bit

On 06/15/2016 05:36 AM, Eric Blake wrote: On 06/14/2016 09:25 AM, Denis V. Lunev wrote: There is no need to scan allocation tables if we have mark_all_dirty flag set. Just mark it all dirty. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy&l

Re: [Qemu-devel] [PATCH 1/1] cpu: report hyperv feature words through qom

On 06/14/2016 11:54 PM, Eduardo Habkost wrote: On Tue, Jun 14, 2016 at 11:45:08PM +0300, Denis V. Lunev wrote: On 06/14/2016 10:59 PM, Eduardo Habkost wrote: On Tue, Jun 14, 2016 at 01:28:40PM +0300, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> This chang

Re: [Qemu-devel] [PATCH 1/1] cpu: report hyperv feature words through qom

On 06/14/2016 10:59 PM, Eduardo Habkost wrote: On Tue, Jun 14, 2016 at 01:28:40PM +0300, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will

[Qemu-devel] [PATCH 0/9] major rework of drive-mirror

hing more intelligent and switch to sync mirroring just after the first pass over the bitmap. Though this could be done relatively easily during discussion. The most difficult things are here. The set also adds some performance improvements dealing with known-to-be-zero areas. Signed-off-by: Deni

[Qemu-devel] [PATCH 8/9] mirror: use synch scheme for drive mirror

back. In this case all data written from the guest is synchnonously written to the mirror target. Though the problem is solved partially. We should switch from bdrv_dirty_bitmap to simple hbitmap. This will be done in the next patch. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: V

[Qemu-devel] [PATCH 9/9] mirror: replace bdrv_dirty_bitmap with plain hbitmap

We have replaced the mechanics of syncing new writes in the previous patch and thus do not need to track dirty changes anymore. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...@redh

[Qemu-devel] [PATCH 1/9] mirror: fix calling of blk_aio_pwritev/blk_aio_preadv

4th argument is flags rather than size. Fortunately flags occupies 5 less significant bits and they are always zero due to alignment. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...

[Qemu-devel] [PATCH 7/9] mirror: allow to save buffer for QEMUIOVector in MirrorOp

Properly cook MirrorOp initialization/deinitialization. The field is not yet used actually. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Fam Zheng <f...@redha

[Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk

We should not take into account zero blocks for delay calculations. They are not read and thus IO throttling is not required. In the other case VM migration with 16 Tb QCOW2 disk with 4 Gb of data takes days. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sem

[Qemu-devel] [PATCH 2/9] mirror: create mirror_dirty_init helper for mirror_run

The code inside the helper will be extended in the next patch. mirror_run itself is overbloated at the moment. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...@redhat.com>

[Qemu-devel] [PATCH 6/9] block: pass qiov into before_write notifier

Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Fam Zheng <f...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com>

[Qemu-devel] [PATCH 4/9] mirror: efficiently zero out target

supports write_zeroes. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Fam Zheng <f...@redhat.com> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre

[Qemu-devel] [PATCH 3/9] mirror: optimize dirty bitmap filling in mirror_run a bit

There is no need to scan allocation tables if we have mark_all_dirty flag set. Just mark it all dirty. Signed-off-by: Denis V. Lunev <d...@openvz.org> Reviewed-by: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Fam Zheng &l

Re: [Qemu-devel] [PATCH v5 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

On 06/14/2016 12:16 PM, Denis V. Lunev wrote: Changes from v4: - synced help descriprion for --trace with man for qemu.1/qemu-img.1/qemu-nbd.8 - moved @findex from qemu-option-trace.texi Changes from v3: - fixed difference in help/man for qemu-img/qemu-nbd - created separate .texi to contain

[Qemu-devel] [PATCH 1/1] cpu: report hyperv feature words through qom

report hyperv feature words which prevents windows guests from starting with libvirt. Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Paolo Bonzini <pbonz...@redhat.com> CC: Richard Henderson <r...@twiddle.net&

[Qemu-devel] [PATCH 7/7] trace: enable tracing in qemu-img

The command will work this way: qemu-img --trace qcow2* create -f qcow2 1.img 64G Signed-off-by: Denis V. Lunev <d...@openvz.org> Suggested by: Daniel P. Berrange <berra...@redhat.com> CC: Eric Blake <ebl...@redhat.com> CC: Paolo Bonzini <pbonz...@redhat.com> CC

<    5   6   7   8   9   10   11   12   13   14   >