Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-19 Thread Didier Pallard
On 02/10/2016 01:15 PM, Daniel P. Berrange wrote: On Wed, Feb 10, 2016 at 01:53:49PM +0200, Michael S. Tsirkin wrote: On Wed, Feb 10, 2016 at 10:35:13AM +0100, Didier Pallard wrote: On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard

Re: [Qemu-devel] [PATCH v5] vhost-user interrupt management fixes

2016-02-19 Thread Didier Pallard
, and processed later. Add an option boolean flag 'use_mask_notifier' to disable the use of guest_notifier_mask in virtio pci. Signed-off-by: Didier Pallard <didier.pall...@6wind.com> Signed-off-by: Victor Kaplansky <vict...@redhat.com> --- v5 changes: - rebased to mst tree. - remov

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-10 Thread Didier Pallard
On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berrange wrote: On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-09 Thread Didier Pallard
On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berrange wrote: On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin wrote: On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: unix_send_msgfds is used by vhost-user

Re: [Qemu-devel] [PATCH 2/3] virtio-pci: add an option to bypass guest_notifier_mask

2016-02-08 Thread Didier Pallard
On 02/04/2016 02:08 PM, Michael S. Tsirkin wrote: On Thu, Dec 03, 2015 at 10:53:18AM +0100, Didier Pallard wrote: Using guest_notifier_mask function in vhost-user case may break interrupt mask paradigm, because mask/unmask is not really done when returning from guest_notifier_mask call, instead

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-08 Thread Didier Pallard
On 02/04/2016 03:10 PM, Michael S. Tsirkin wrote: On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all is used to send a message and retries as long as EAGAIN errno is set, but write_msgfds buffer is freed

Re: [Qemu-devel] Linux vhost-user interrupt management fixes

2016-01-26 Thread Didier Pallard
On 01/25/2016 10:22 AM, Victor Kaplansky wrote: On Thu, Dec 03, 2015 at 10:53:16AM +0100, Didier Pallard wrote: Hi, I recently did some stress tests of a vhost-user interface using an UDP traffic generator. Traffic generator was connected to 2 physical ports that are in turn connected to 2

Re: [Qemu-devel] [RFC PATCH] vhost: fix lost interrupts from slow reacting back-end

2016-01-13 Thread Didier Pallard
On 01/13/2016 04:32 PM, Victor Kaplansky wrote: On Tue, Jan 12, 2016 at 01:05:52PM +0100, Didier Pallard wrote: On 01/12/2016 09:26 AM, Victor Kaplansky wrote: This RFC PATCH tries to solve the problem of lost interrupts >from a slow back-end. Didier could you test it? Thanks, Victor W

Re: [Qemu-devel] [RFC PATCH] vhost: fix lost interrupts from slow reacting back-end

2016-01-12 Thread Didier Pallard
guest_notifier, NULL); } else null handler is set in guest_notifier. And from my understanding, virtio-pci in kvm mode uses irqfd, so when are we entering the virtio_queue_guest_notifier_read? did you also change the qemu configuration? thanks didier -- Didier PALLARD 6WIND Software Engineer Tel:

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-10 Thread Didier Pallard
On 12/10/2015 01:56 PM, Victor Kaplansky wrote: On Wed, Dec 09, 2015 at 06:06:06PM +0100, Didier Pallard wrote: On 12/09/2015 04:59 PM, Victor Kaplansky wrote: On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: Hi On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard <didier.p

Re: [Qemu-devel] [PATCH 2/3] virtio-pci: add an option to bypass guest_notifier_mask

2015-12-09 Thread Didier Pallard
On 12/07/2015 02:59 PM, Marc-André Lureau wrote: Hi On Mon, Dec 7, 2015 at 2:37 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: Hi On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard <didier.pall...@6wind.com> wrote: Using guest_notifier_mask function in vhost-user ca

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-09 Thread Didier Pallard
On 12/09/2015 04:59 PM, Victor Kaplansky wrote: On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: Hi On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard <didier.pall...@6wind.com> wrote: unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all is used t

Re: [Qemu-devel] Linux vhost-user interrupt management fixes

2015-12-04 Thread Didier Pallard
On 12/03/2015 10:53 AM, Didier Pallard wrote: Hi, I recently did some stress tests of a vhost-user interface using an UDP traffic generator. Traffic generator was connected to 2 physical ports that are in turn connected to 2 virtio ports through a linux bridge, VM (running linux) doing routing

[Qemu-devel] Linux vhost-user interrupt management fixes

2015-12-03 Thread Didier Pallard
/unmasking interrupts by taking/giving vring_call fd from/to kernel kvm module). Patches 2 and 3 of the serie propose an implementation of this second option. Didier Didier Pallard (3): char: fix vhost-user socket full virtio-pci: add an option to bypass guest_notifier_mask vhost-net: force

[Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-03 Thread Didier Pallard
is called through qemu_chr_fe_write, it will be user responsability to resend message as is or to free write_msgfds using set_msgfds(0) Signed-off-by: Didier Pallard <didier.pall...@6wind.com> Reviewed-by: Thibaut Collet <thibaut.col...@6wind.com> --- qemu-char.c | 10 ++ 1 file

[Qemu-devel] [PATCH 2/3] virtio-pci: add an option to bypass guest_notifier_mask

2015-12-03 Thread Didier Pallard
of guest_notifier_mask in virtio pci. Signed-off-by: Didier Pallard <didier.pall...@6wind.com> Reviewed-by: Thibaut Collet <thibaut.col...@6wind.com> --- hw/virtio/virtio-pci.c | 29 +++-- hw/virtio/virtio-pci.h | 6 ++ 2 files changed, 29 insertions(+), 6 deletions(-) dif

[Qemu-devel] [PATCH 3/3] vhost-net: force guest_notifier_mask bypass in vhost-user case

2015-12-03 Thread Didier Pallard
Since guest_mask_notifier can not be used in vhost-user mode due to buffering implied by unix control socket, force VIRTIO_PCI_FLAG_USE_NOTIFIERMASK on virtio pci of vhost-user interfaces, and send correct callfd to the guest at vhost start. Signed-off-by: Didier Pallard <didier.pall...@6wind.