roy(>qemu_file_lock);
> -g_free(params->tls_hostname);
> -g_free(params->tls_creds);
So hmm, why is tls-authz special here?
Dave
> qemu_sem_destroy(>wait_unplug_sem);
> qemu_sem_destroy(>rate_limit_sem);
> qemu_sem_destroy(>pause_sem);
> --
> 2.32.0
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
;x-" prefix.
This is actually a 'property' and not a 'Parameter' isn't it?
> Signed-off-by: Peter Xu
Other than the title,
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/migration.c | 2 ++
> migration/migration.h | 7 +++
> migration/ram.c | 7 +++
&g
, TYPE_QIO_CHANNEL_TLS);
> +}
> diff --git a/migration/tls.h b/migration/tls.h
> index de4fe2cafd..a54c1dcec7 100644
> --- a/migration/tls.h
> +++ b/migration/tls.h
> @@ -37,4 +37,8 @@ void migration_tls_channel_connect(MigrationState *s,
> QIOChannel *ioc,
> const char *hostname,
> Error **errp);
> +
> +/* Whether the QIO channel requires further TLS handshake? */
> +bool migrate_channel_requires_tls(QIOChannel *ioc);
> +
> #endif
> --
> 2.32.0
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
opy_pause(). In that
> case if the channel creation failed, we can't fail the migration or we'll
> crash the VM, instead we keep in PAUSED state, waiting for yet another
> recovery.
>
> Signed-off-by: Peter Xu
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/migration
* Juan Quintela (quint...@redhat.com) wrote:
> In this version:
> - document what protects each field in MultiFDRecv/SendParams
> - calcule page_size once when we start the migration, and store it in
> a field
> - Same for page_count.
> - rebase to latest
> - minor improvements here and there
>
* Leonardo Bras Soares Passos (leob...@redhat.com) wrote:
> From a previous thread:
>
> On Thu, Apr 28, 2022 at 1:20 PM Dr. David Alan Gilbert
> wrote:
> >
> > Leo:
> > Unfortunately this is failing a couple of CI tests; the MSG_ZEROCOPY
> > one I guess
memory,
> int smp_cpus,
>
> /* touch pages simultaneously */
> ret = touch_all_pages(area, hpagesize, numpages, smp_cpus,
> - use_madv_populate_write);
> + host_nodes, max_node, use_madv_populate_write);
> if (ret) {
> error_setg_errno(errp, -ret,
> "os_mem_prealloc: preallocating memory failed");
> diff --git a/util/oslib-win32.c b/util/oslib-win32.c
> index dafef4f157..6efd912355 100644
> --- a/util/oslib-win32.c
> +++ b/util/oslib-win32.c
> @@ -314,6 +314,8 @@ int getpagesize(void)
> }
>
> void os_mem_prealloc(int fd, char *area, size_t memory, int smp_cpus,
> + const unsigned long *host_nodes,
> + unsigned long max_node,
> Error **errp)
> {
> int i;
> --
> 2.35.1
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Tue, May 10, 2022 at 10:58:30AM +0100, Dr. David Alan Gilbert wrote:
> > * Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
>
NUMA
> > +g_clear_pointer(, numa_bitmask_free);
> > +#endif
> > g_free(context.threads);
> >
> > return ret;
> > @@ -566,6 +634,8 @@ static bool madv_populate_write_possible(char *area,
> > size_t pagesize)
> > }
> >
> > void os_mem_prealloc(int fd, char *area, size_t memory, int smp_cpus,
> > + const unsigned long *host_nodes,
> > + unsigned long max_node,
> > Error **errp)
> > {
> > static gsize initialized;
> > @@ -608,7 +678,7 @@ void os_mem_prealloc(int fd, char *area, size_t memory,
> > int smp_cpus,
> >
> > /* touch pages simultaneously */
> > ret = touch_all_pages(area, hpagesize, numpages, smp_cpus,
> > - use_madv_populate_write);
> > + host_nodes, max_node, use_madv_populate_write);
> > if (ret) {
> > error_setg_errno(errp, -ret,
> > "os_mem_prealloc: preallocating memory failed");
> > diff --git a/util/oslib-win32.c b/util/oslib-win32.c
> > index dafef4f157..6efd912355 100644
> > --- a/util/oslib-win32.c
> > +++ b/util/oslib-win32.c
> > @@ -314,6 +314,8 @@ int getpagesize(void)
> > }
> >
> > void os_mem_prealloc(int fd, char *area, size_t memory, int smp_cpus,
> > + const unsigned long *host_nodes,
> > + unsigned long max_node,
> > Error **errp)
> > {
> > int i;
> > --
> > 2.35.1
> >
> >
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-https://fstop138.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote:
> From: "Dr. David Alan Gilbert"
>
> The following changes since commit 178bacb66d98d9ee7a702b9f2a4dfcd88b72a9ab:
>
> Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into
> stagin
architectures.
To my mind, qemu-system-arm makes a lot of sense, and I'd rather see the
32 bit guests disappear from qemu-system-aarch64.
It's difficult to justify to someone running their aarch virt stack why
their binary has the security footprint that includes a camera or PDA.
ARM is a lot clea
-by: Juan Quintela
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Message-Id: <20220507015759.840466-5-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/channel.c | 3 +--
migration/migration.c | 9 +
migration/migration.h | 1 +
migration/multifd.c
a mechanism to disable it, so it can still be accessible to less
privileged users.
Signed-off-by: Leonardo Bras
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Message-Id: <20220507015759.840466-3-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
incl
/disable this feature.
On non-Linux builds this parameter is compiled-out.
Signed-off-by: Leonardo Bras
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Acked-by: Markus Armbruster
Message-Id: <20220507015759.840466-4-leob...@redhat.com>
Signed-off-by: Dr.
implementation on new flags.
Signed-off-by: Leonardo Bras
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
Message-Id: <20220507015759.840466-2-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
chardev/char-io.c | 2 +-
hw/remote/mpqemu-
com>
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-helpers.c | 13 +
tests/qtest/migration-helpers.h | 1 +
tests/qtest/migration-test.c| 6 +++---
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/mig
840466-7-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/multifd.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 15fb668e64..2541cd2322 100644
--- a/migration/multifd.c
+++ b/mig
hat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/migration.c | 11 ++-
migration/multifd.c | 37 +++--
migration/multifd.h | 2 ++
migration/socket.c| 5 +++--
4 files changed, 50 insertions(+), 5 deletions(-)
diff --git a/migration/mig
From: Daniel P. Berrangé
This validates that we correctly handle multifd migration success
and failure scenarios when using TLS with pre shared keys.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20220426160048.812266-8-berra...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Dr.
ed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 67 ++--
1 file changed, 25 insertions(+), 42 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 5a3edf2da6..a1dc08a93e 100644
--- a/tests/qtest/migration-test.c
Signed-off-by: Dr. David Alan Gilbert
---
migration/multifd.c | 10 ++
migration/multifd.h | 2 +-
migration/ram.c | 29 ++---
3 files changed, 29 insertions(+), 12 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 2a8c8570c3..15fb668e64
: <20220426160048.812266-5-berra...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Dr. David Alan Gilbert
dgilbert: Manual merge due to ifdef change in 3
---
meson.build | 1 +
tests/qtest/meson.build | 5 +
tests/qtest/migration-test.c | 383
From: Daniel P. Berrangé
This validates that we correctly handle migration success and failure
scenarios when using TLS with pre shared keys.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20220426160048.812266-4-berra...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Dr. Davi
-multifd coverage applies to some extent.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20220426160048.812266-9-berra...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 127 +++
1 file change
Blake
Signed-off-by: Dr. David Alan Gilbert
---
tests/unit/crypto-tls-x509-helpers.h | 53
1 file changed, 53 insertions(+)
diff --git a/tests/unit/crypto-tls-x509-helpers.h
b/tests/unit/crypto-tls-x509-helpers.h
index cf6329e653..247e7160eb 100644
--- a/tests/unit/cryp
-by: Daniel P. Berrangé
Message-Id: <20220426160048.812266-7-berra...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 77 +++-
1 file changed, 40 insertions(+), 37 deletions(-)
diff --git a/tests/qtest/migration-test.c b
From: "Dr. David Alan Gilbert"
The following changes since commit 178bacb66d98d9ee7a702b9f2a4dfcd88b72a9ab:
Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into
staging (2022-05-09 11:07:04 -0700)
are available in the Git repository at:
https://gitlab
by: Dr. David Alan Gilbert
Signed-off-by: Dr. David Alan Gilbert
---
tests/unit/crypto-tls-x509-helpers.c | 16 +---
tests/unit/test-crypto-tlssession.c | 11 +--
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/tests/unit/crypto-tls-x509-helpers.c
b/tests/unit/
* Leonardo Bras Soares Passos (leob...@redhat.com) wrote:
> On Mon, May 9, 2022 at 4:45 PM Richard Henderson
> wrote:
> >
> > On 5/9/22 10:02, Dr. David Alan Gilbert (git) wrote:
> > > diff --git a/roms/skiboot b/roms/skiboot
> > > index 24a7eb3596..820d43
/disable this feature.
On non-Linux builds this parameter is compiled-out.
Signed-off-by: Leonardo Bras
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Acked-by: Markus Armbruster
Message-Id: <20220507015759.840466-4-leob...@redhat.com>
Signed-off-by: Dr.
840466-7-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/multifd.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 15fb668e64..2541cd2322 100644
--- a/migration/multifd.c
+++ b/mig
From: Daniel P. Berrangé
This validates that we correctly handle migration success and failure
scenarios when using TLS with pre shared keys.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20220426160048.812266-4-berra...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Dr. Davi
-multifd coverage applies to some extent.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20220426160048.812266-9-berra...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 127 +++
1 file change
Signed-off-by: Dr. David Alan Gilbert
---
migration/multifd.c | 10 ++
migration/multifd.h | 2 +-
migration/ram.c | 29 ++---
3 files changed, 29 insertions(+), 12 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 2a8c8570c3..15fb668e64
-by: Juan Quintela
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Message-Id: <20220507015759.840466-5-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/channel.c | 3 +--
migration/migration.c | 9 +
migration/migration.h | 1 +
migration/multifd.c
implementation on new flags.
Signed-off-by: Leonardo Bras
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
Message-Id: <20220507015759.840466-2-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
chardev/char-io.c | 2 +-
hw/remote/mpqemu-
From: Daniel P. Berrangé
This validates that we correctly handle multifd migration success
and failure scenarios when using TLS with pre shared keys.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20220426160048.812266-8-berra...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Dr.
hat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/migration.c | 11 ++-
migration/multifd.c | 37 +++--
migration/multifd.h | 2 ++
migration/socket.c| 5 +++--
4 files changed, 50 insertions(+), 5 deletions(-)
diff --git a/migration/mig
a mechanism to disable it, so it can still be accessible to less
privileged users.
Signed-off-by: Leonardo Bras
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Message-Id: <20220507015759.840466-3-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
incl
com>
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-helpers.c | 13 +
tests/qtest/migration-helpers.h | 1 +
tests/qtest/migration-test.c| 6 +++---
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/mig
Blake
Signed-off-by: Dr. David Alan Gilbert
---
tests/unit/crypto-tls-x509-helpers.h | 53
1 file changed, 53 insertions(+)
diff --git a/tests/unit/crypto-tls-x509-helpers.h
b/tests/unit/crypto-tls-x509-helpers.h
index cf6329e653..247e7160eb 100644
--- a/tests/unit/cryp
by: Dr. David Alan Gilbert
Signed-off-by: Dr. David Alan Gilbert
---
tests/unit/crypto-tls-x509-helpers.c | 16 +---
tests/unit/test-crypto-tlssession.c | 11 +--
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/tests/unit/crypto-tls-x509-helpers.c
b/tests/unit/
: <20220426160048.812266-5-berra...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Dr. David Alan Gilbert
dgilbert: Manual merge due to ifdef change in 3
---
meson.build | 1 +
tests/qtest/meson.build | 5 +
tests/qtest/migration-test.c | 383
ed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 67 ++--
1 file changed, 25 insertions(+), 42 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 5a3edf2da6..a1dc08a93e 100644
--- a/tests/qtest/migration-test.c
-by: Daniel P. Berrangé
Message-Id: <20220426160048.812266-7-berra...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 77 +++-
1 file changed, 40 insertions(+), 37 deletions(-)
diff --git a/tests/qtest/migration-test.c b
From: "Dr. David Alan Gilbert"
The following changes since commit 554623226f800acf48a2ed568900c1c968ec9a8b:
Merge tag 'qemu-sparc-20220508' of https://github.com/mcayland/qemu into
staging (2022-05-08 17:03:26 -0500)
are available in the Git repository at:
https://gitlab
& defined(SO_ZEROCOPY))
> > +#define QEMU_MSG_ZEROCOPY
> > +#endif
> > +#endif
> >
> > #define SOCKET_MAX_FDS 16
> >
> > +
>
> This line can be dropped when merge.
Done
> > SocketAddress *
> > qio_channel_socket_get_local_address(Q
> tests/unit/crypto-tls-x509-helpers.h | 53 ++
> tests/unit/test-crypto-tlssession.c | 11 +-
> 10 files changed, 897 insertions(+), 95 deletions(-)
>
> --
> 2.35.1
>
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
;
> > +#endif /* CONFIG_GNUTLS */
> > +
> > +qtest_add_func("/migration/precopy/tcp/plain", test_precopy_tcp_plain);
> > +#ifdef CONFIG_GNUTLS
> > + qtest_add_func("/migration/precopy/tcp/tls/psk/match",
> > + test_precopy_tcp_tls_psk_match);
>
> ...including use of the function.
>
> > +qtest_add_func("/migration/precopy/tcp/tls/psk/mismatch",
> > + test_precopy_tcp_tls_psk_mismatch);
> > +#endif /* CONFIG_GNUTLS */
> > +
>
> With the missing #ifdef added in,
OK, ifdef added in queuing
> Reviewed-by: Eric Blake
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
accept that we're
dealing with another (open) interface which has already gone through
review.
Dave
> There is some appeal in why we want todo that, but it is certainly
> a divergance from our historical approach to QMP, so we shouldn't
> make this decision lightly.
>
> With regards,
>
* Leonardo Bras Soares Passos (lsoar...@redhat.com) wrote:
> Hello Dave,
>
> On Thu, Apr 28, 2022 at 1:20 PM Dr. David Alan Gilbert
> wrote:
> >
> > Leo:
> > Unfortunately this is failing a couple of CI tests; the MSG_ZEROCOPY
> > one I guess is the s
]
> root 38046 0.0 0.0 0 0 ?SApr19 0:00
> [kvm-pit/38032]
> root 38047 0.0 0.0 0 0 ?SApr19 0:02 [vhost-38032]
> [root@os ~]# ps -L -p 38032 | wc -l
> 54
> [root@os ~]# ps -fT -p 38032 | wc -l
> 54
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
for each function it appears in
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote:
> From: Leonardo Bras
>
> For CONFIG_LINUX, implement the new zero copy flag and the optional callback
> io_flush on QIOChannelSocket, but enables it only when MSG_ZEROCOPY
> feature is availa
-by: Juan Quintela
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Message-Id: <20220426230654.637939-5-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/channel.c | 3 +--
migration/migration.c | 9 +
migration/migration.h | 1 +
migration/multifd.c
a mechanism to disable it, so it can still be accessible to less
privileged users.
Signed-off-by: Leonardo Bras
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Message-Id: <20220426230654.637939-3-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
incl
-by: Daniel P. Berrangé
Message-Id: <20220426160048.812266-7-berra...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 77 +++-
1 file changed, 40 insertions(+), 37 deletions(-)
diff --git a/tests/qtest/migration-test.c b
by: Dr. David Alan Gilbert
Signed-off-by: Dr. David Alan Gilbert
---
tests/unit/crypto-tls-x509-helpers.c | 16 +---
tests/unit/test-crypto-tlssession.c | 11 +--
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/tests/unit/crypto-tls-x509-helpers.c
b/tests/unit/
ed-off-by: Dr. David Alan Gilbert
dgilbert: Manual merge since I skipped some of the other patches
---
tests/qtest/migration-test.c | 67 ++--
1 file changed, 25 insertions(+), 42 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
From: "Dr. David Alan Gilbert"
The following changes since commit cf6f26d6f9b2015ee12b4604b79359e76784163a:
Merge tag 'kraxel-20220427-pull-request' of git://git.kraxel.org/qemu into
staging (2022-04-27 10:49:28 -0700)
are available in the Git repository at:
https://gitlab
. Berrangé
Signed-off-by: Dr. David Alan Gilbert
---
migration/migration.c | 11 ++-
migration/multifd.c | 37 +++--
migration/multifd.h | 2 ++
migration/socket.c| 5 +++--
4 files changed, 50 insertions(+), 5 deletions(-)
diff --git a/migration/mig
wed-by: Daniel P. Berrangé
Signed-off-by: Dr. David Alan Gilbert
dgilbert: Removed blank line
---
migration/multifd.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 15fb668e64..2541cd2322 100644
/disable this feature.
On non-Linux builds this parameter is compiled-out.
Signed-off-by: Leonardo Bras
Reviewed-by: Peter Xu
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Message-Id: <20220426230654.637939-4-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
mig
implementation on new flags.
Signed-off-by: Leonardo Bras
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
Message-Id: <20220426230654.637939-2-leob...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
chardev/char-io.c | 2 +-
hw/remote/mpqemu-
com>
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-helpers.c | 13 +
tests/qtest/migration-helpers.h | 1 +
tests/qtest/migration-test.c| 6 +++---
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/mig
Signed-off-by: Dr. David Alan Gilbert
---
migration/multifd.c | 10 ++
migration/multifd.h | 2 +-
migration/ram.c | 29 ++---
3 files changed, 29 insertions(+), 12 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 2a8c8570c3..15fb668e64
| 1 +
> migration/socket.c | 12 ++-
> monitor/hmp-cmds.c | 6 ++
> scsi/pr-manager-helper.c| 2 +-
> tests/unit/test-io-channel-socket.c | 1 +
> 23 files changed, 379 insertions(+), 44 deletions(-)
>
> --
> 2.36.0
> +break;
> > +}
> > +
>
> Extra but useless newline.. but not worth a repost. Looks good here:
I removed that.
> Reviewed-by: Peter Xu
>
> Thanks,
>
> > +} else {
> > +/* Send header using the same writev call */
> > +p->iov[0].iov_len = p->packet_len;
> > +p->iov[0].iov_base = p->packet;
> > +}
> >
> > ret = qio_channel_writev_all(p->c, p->iov, p->iovs_num,
> > _err);
> > --
> > 2.36.0
> >
>
> --
> Peter Xu
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
crypto-tls-x509-helpers.h | 53 ++
> tests/unit/test-crypto-tlssession.c | 11 +-
> 10 files changed, 897 insertions(+), 95 deletions(-)
>
> --
> 2.35.1
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
_new(char, *datalen);
> +memcpy(*data, >sin6_addr, *datalen);
> + } else {
> + g_assert_not_reached();
> +}
> freeaddrinfo(res);
Yes, you could use g_memdup,
Reviewed-by: Dr. David Alan Gilbert
> }
>
> diff --git a/tests/unit/test-crypto-tlsse
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> On 4/27/22 17:16, Dr. David Alan Gilbert wrote:
> > * Paolo Bonzini (pbonz...@redhat.com) wrote:
> > > On 4/27/22 14:34, Dr. David Alan Gilbert wrote:
> > > > If I specify a 'vm' it's not obvious to me whether I'd get
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> On 4/27/22 14:34, Dr. David Alan Gilbert wrote:
> > If I specify a 'vm' it's not obvious to me whether I'd get NICs and
> > block devices in the future?
>
> VM would not get those (it's global statistics), but the size could bal
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> On 4/27/22 14:01, Dr. David Alan Gilbert wrote:
> > > "providers": [
> > >{ "provider": "kvm",
> > > "names": [ "l1d_flush", "exits
; >
>
> Yeah. Fixed that. Thanks.
When you start getting stable machine type versions it'll become harder
and you might have to put dummy entries in to keep compatibility.
Dave
> > r~
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
r == provider) {
> +*p_names = request->value->has_names ? request->value->names :
> NULL;
> return true;
> }
> }
> @@ -490,8 +493,9 @@ StatsResultList *qmp_query_stats(StatsFilter *filter,
> Error **errp)
> StatsCallbacks *entry;
>
> QTAILQ_FOREACH(entry, _callbacks, next) {
> -if (stats_provider_requested(entry->provider, filter)) {
> -entry->stats_cb(_results, filter->target, targets, errp);
> +strList *names = NULL;
> +if (stats_provider_requested(entry->provider, filter, )) {
> +entry->stats_cb(_results, filter->target, names, targets,
> errp);
> }
> }
>
> diff --git a/qapi/stats.json b/qapi/stats.json
> index 33ff6ea7a9..234fbcb7ca 100644
> --- a/qapi/stats.json
> +++ b/qapi/stats.json
> @@ -71,11 +71,14 @@
> # Indicates a set of statistics that should be returned by query-stats.
> #
> # @provider: provider for which to return statistics.
> +
> +# @names: statistics to be returned (all if omitted).
> #
> # Since: 7.1
> ##
> { 'struct': 'StatsRequest',
> - 'data': { 'provider': 'StatsProvider' } }
> + 'data': { 'provider': 'StatsProvider',
> +'*names': [ 'str' ] } }
>
> ##
> # @StatsVCPUFilter:
> --
> 2.35.1
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
'value' : 'StatsValue' } }
> +
> +##
> +# @StatsResult:
> +#
> +# @provider: provider for this set of statistics.
> +# @qom-path: QOM path of the object for which the statistics are returned
> +# @stats: list of statistics.
> +#
> +# Since: 7.1
> +##
> +{ 'struct': 'StatsResult',
> + 'data': { 'provider': 'StatsProvider',
> +'*qom-path': 'str',
> +'stats': [ 'Stats' ] } }
> +
> +##
> +# @query-stats:
> +#
> +# Return runtime-collected statistics for objects such as the
> +# VM or its vCPUs.
> +#
> +# The arguments are a StatsFilter and specify the provider and objects
> +# to return statistics about.
> +#
> +# Returns: a list of StatsResult, one for each provider and object
> +# (e.g., for each vCPU).
> +#
> +# Since: 7.1
> +##
> +{ 'command': 'query-stats',
> + 'data': 'StatsFilter',
> + 'boxed': true,
> + 'returns': [ 'StatsResult' ] }
> +
> +##
> +# @StatsSchemaValue:
> +#
> +# Schema for a single statistic.
> +#
> +# @name: stat name.
> +#
> +# @type: kind of statistic, a @StatType.
> +#
> +# @unit: base unit of measurement for the statistics @StatUnit.
> +#
> +# @base: base for the multiple of @unit that the statistic uses, either 2 or
> 10.
> +#Only present if @exponent is non-zero.
> +#
> +# @exponent: exponent for the multiple of @unit that the statistic uses
> +#
> +# @bucket-size: Used with linear-hist to report the width of each bucket
> +# of the histogram.
> +#
> +# Since: 7.1
> +##
> +{ 'struct': 'StatsSchemaValue',
> + 'data': { 'name': 'str',
> +'type': 'StatsType',
> +'*unit': 'StatsUnit',
> +'*base': 'int8',
> +'exponent': 'int16',
> +'*bucket-size': 'uint32' } }
> +
> +##
> +# @StatsSchema:
> +#
> +# Schema for all available statistics for a provider and target.
> +#
> +# @provider: provider for this set of statistics.
> +#
> +# @target: kind of object that can be queried through this provider.
> +#
> +# @stats: list of statistics.
> +#
> +# Since: 7.1
> +##
> +{ 'struct': 'StatsSchema',
> + 'data': { 'provider': 'StatsProvider',
> +'target': 'StatsTarget',
> +'stats': [ 'StatsSchemaValue' ] } }
> +
> +##
> +# @query-stats-schemas:
> +#
> +# Return the schema for all available runtime-collected statistics.
> +#
> +# Since: 7.1
> +##
> +{ 'command': 'query-stats-schemas',
> + 'data': { },
> + 'returns': [ 'StatsSchema' ] }
> --
> 2.35.1
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
From: "Dr. David Alan Gilbert"
The 'status' field for the migration is updated normally using
an atomic operation from the migration thread.
Most readers of it aren't that careful, and in most cases it doesn't
matter.
In query_migrate->fill_source_migration_info the 'state'
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote:
> From: "Dr. David Alan Gilbert"
>
> The following changes since commit 401d46789410e88e9e90d76a11f46e8e9f358d55:
>
> Merge tag 'pull-target-arm-20220421' of
> https://git.linaro.org/people/pmaydell/qemu-
before we'll jump into migration_incoming_process().
A side benefit is we don't need to pass in QEMUFile* to postcopy_try_recover()
anymore. Remove it.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message-Id: <20220331150857.74406-7-pet...@redhat.com>
Reviewed-by: Da
a new migrate-recover to
release the previous listener transport.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message-Id: <20220331150857.74406-8-pet...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dr. David Alan Gilbert
---
migration/migration.
From: "Dr. David Alan Gilbert"
Clang spotted an & that should have been an &&; fix it.
Reported by: David Binderman / https://gitlab.com/dcb
Fixes: 65dacaa04fa ("migration: introduce save_normal_page()")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/9
From: Peter Xu
This boolean flag shows whether the current page during migration is triggered
by postcopy or not. Then in ram_save_host_page() and deeper stack we'll be
able to have a reference on the priority of this page.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message
it from "multifd" to
"multi_channels" to show its real meaning.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message-Id: <20220331150857.74406-5-pet...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dr. David Alan Gilbert
---
P. Berrangé
Message-Id: <20220310171821.3724080-4-berra...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/libqtest.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 2b9bdb947d..7db7ef3a68
but that's actually not needed.
Keeping the hostname until the cleanup phase of migration.
Cc: Daniel P. Berrange
Signed-off-by: Peter Xu
Message-Id: <20220331150857.74406-2-pet...@redhat.com>
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dr. Davi
-by: Daniel P. Berrangé
Message-Id: <20220310171821.3724080-12-berra...@redhat.com>
Reviewed-by: Peter Xu
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 51 +---
1 file changed, 42 insertions(+), 9 deletions(-)
diff --git a/tests
by: Dr. David Alan Gilbert
---
migration/tls.c | 4
1 file changed, 4 deletions(-)
diff --git a/migration/tls.c b/migration/tls.c
index ca1ea3bbdd..32c384a8b6 100644
--- a/migration/tls.c
+++ b/migration/tls.c
@@ -137,10 +137,6 @@ QIOChannelTLS *migration_tls_client_create(MigrationSta
Signed-off-by: Daniel P. Berrangé
Message-Id: <20220310171821.3724080-5-berra...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/libqtest.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 7db7
com>
Reviewed-by: Peter Xu
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 98 ++--
1 file changed, 49 insertions(+), 49 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 36e5408702..b62869b3af
From: Daniel P. Berrangé
Reviewed-by: Peter Xu
Signed-off-by: Daniel P. Berrangé
Message-Id: <20220310171821.3724080-3-berra...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
tests/unit/crypto-tls-psk-helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
From: Daniel P. Berrangé
The combination of the start and finish hooks allow the FD passing
code to use the precopy helper
Signed-off-by: Daniel P. Berrangé
Message-Id: <20220310171821.3724080-11-berra...@redhat.com>
Reviewed-by: Peter Xu
Signed-off-by: Dr. David Alan Gilbert
---
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 134 +++
1 file changed, 56 insertions(+), 78 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 0870656d82..36e5408702 100644
--- a/tests/qtest/mig
From: Peter Xu
Will be reused in postcopy fast load thread.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message-Id: <20220331150857.74406-6-pet...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dr. David Alan Gilbert
---
migration/ram.c | 2 +-
migration
rra...@redhat.com>
Reviewed-by: Peter Xu
Signed-off-by: Dr. David Alan Gilbert
---
tests/qtest/migration-test.c | 38
1 file changed, 38 insertions(+)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index b62869b3af..ae40429798 100644
--- a
-Id: <20220331150857.74406-3-pet...@redhat.com>
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dr. David Alan Gilbert
---
migration/multifd.c | 10 +++---
migration/multifd.h | 2 --
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/migration/
From: "Dr. David Alan Gilbert"
The following changes since commit 28298069afff3eb696e4995e63b2579b27adf378:
Merge tag 'misc-pull-request' of gitlab.com:marcandre.lureau/qemu into
staging (2022-04-21 09:27:54 -0700)
are available in the Git repository at:
https://gitlab.com/dagr
mon.h
> index d8b565b4da..076b7ab779 100644
> --- a/include/hw/virtio/vhost-vsock-common.h
> +++ b/include/hw/virtio/vhost-vsock-common.h
> @@ -44,7 +44,7 @@ int vhost_vsock_common_start(VirtIODevice *vdev);
> void vhost_vsock_common_stop(VirtIODevice *vdev);
> int vhost_vsock_common_pre_save(void *opaque);
> int vhost_vsock_common_post_load(void *opaque, int version_id);
> -void vhost_vsock_common_realize(VirtIODevice *vdev, const char *name);
> +void vhost_vsock_common_realize(VirtIODevice *vdev);
> void vhost_vsock_common_unrealize(VirtIODevice *vdev);
> uint64_t vhost_vsock_common_get_features(VirtIODevice *vdev, uint64_t
> features,
> Error **errp);
> diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
> index 2179b75703..afff9e158e 100644
> --- a/include/hw/virtio/virtio-gpu.h
> +++ b/include/hw/virtio/virtio-gpu.h
> @@ -22,6 +22,7 @@
> #include "sysemu/vhost-user-backend.h"
>
> #include "standard-headers/linux/virtio_gpu.h"
> +#include "standard-headers/linux/virtio_ids.h"
> #include "qom/object.h"
>
> #define TYPE_VIRTIO_GPU_BASE "virtio-gpu-base"
> @@ -37,8 +38,6 @@ OBJECT_DECLARE_SIMPLE_TYPE(VirtIOGPUGL, VIRTIO_GPU_GL)
> #define TYPE_VHOST_USER_GPU "vhost-user-gpu"
> OBJECT_DECLARE_SIMPLE_TYPE(VhostUserGPU, VHOST_USER_GPU)
>
> -#define VIRTIO_ID_GPU 16
> -
> struct virtio_gpu_simple_resource {
> uint32_t resource_id;
> uint32_t width;
> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> index b31c4507f5..5d774684b1 100644
> --- a/include/hw/virtio/virtio.h
> +++ b/include/hw/virtio/virtio.h
> @@ -165,8 +165,8 @@ struct VirtioDeviceClass {
> void virtio_instance_init_common(Object *proxy_obj, void *data,
> size_t vdev_size, const char *vdev_name);
>
> -void virtio_init(VirtIODevice *vdev, const char *name,
> - uint16_t device_id, size_t config_size);
> +void virtio_init(VirtIODevice *vdev, uint16_t device_id, size_t config_size);
> +
> void virtio_cleanup(VirtIODevice *vdev);
>
> void virtio_error(VirtIODevice *vdev, const char *fmt, ...) G_GNUC_PRINTF(2,
> 3);
> --
> 2.35.1
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
a new migrate-recover to
release the previous listener transport.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message-Id: <20220331150857.74406-8-pet...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dr. David Alan Gilbert
---
migration/migration.
before we'll jump into migration_incoming_process().
A side benefit is we don't need to pass in QEMUFile* to postcopy_try_recover()
anymore. Remove it.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message-Id: <20220331150857.74406-7-pet...@redhat.com>
Reviewed-by: Da
it from "multifd" to
"multi_channels" to show its real meaning.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message-Id: <20220331150857.74406-5-pet...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dr. David Alan Gilbert
---
-Id: <20220331150857.74406-3-pet...@redhat.com>
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Dr. David Alan Gilbert
---
migration/multifd.c | 10 +++---
migration/multifd.h | 2 --
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/migration/
601 - 700 of 11022 matches
Mail list logo
