-by: Max Reitz mre...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Max Reitz mre...@redhat.com
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
hw/scsi/scsi-disk.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c
On 03/02/2015 11:46 AM, Markus Armbruster wrote:
Ekaterina Tumanova tuman...@linux.vnet.ibm.com writes:
check conf.blk before calling blkconf_blocksizes
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
hw/scsi/scsi-disk.c | 4 +++-
1 file changed, 3 insertions(+), 1
for Max Reitz:
Can you please apply this patch and re-test?
Thanks!
Kate
p.s. This is supposed to be merged with patch 5/5 of
Geometry and blocksize detection for backing devices
Ekaterina Tumanova (1):
scsi-hd: fix property unset case
hw/scsi/scsi-disk.c | 4 +++-
1 file changed, 3
check conf.blk before calling blkconf_blocksizes
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
hw/scsi/scsi-disk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 2921728..df5140e 100644
--- a/hw/scsi/scsi
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
---
block/block-backend.c | 10 ++
include/sysemu/block-backend.h | 2 ++
2 files changed, 12 insertions(+)
diff --git
Put it in new probe_logical_blocksize().
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
---
block/raw-posix.c | 51 +++
1 file changed
were initialized with 0. (driver will return 512 if
backing device probing didn't succeed or if driver method is not defined).
2. hd_geometry guess was changed to firstly try to retrieve values via
blk_probe_geometry and if it fails, fallback to the old logic.
Ekaterina Tumanova (5):
block: add bdrv
was introduced. It calls BIODASDINFO2
ioctl and returns its rc.
Blocksizes detection function will probe sizes for DASD devices.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Add driver functions for geometry and blocksize detection
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
---
block.c
it will set default 512 value.
The blkconf_blocksizes call was added to all users of BlkConf.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
---
hw/block/block.c | 24
On 02/13/2015 03:23 PM, Christian Borntraeger wrote:
Am 19.01.2015 um 15:35 schrieb Ekaterina Tumanova:
geometry: hd_geometry_guess function autodetects the drive geometry.
This patch adds a block backend call, that probes the backing device
geometry. If the inner driver method is implemented
On 01/19/2015 05:34 PM, Ekaterina Tumanova wrote:
Updates v5 - v6:
Minor Updates according the last review from Stefan Hajnoczi:
1. Do not change the flow of code, factored out of raw_probe_alignment.
2. added #ifdef __linux__ in 2 places of raw-posix.c, mentioned by reviewer.
3. adjusted
Put it in new probe_logical_blocksize().
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
---
block/raw-posix.c | 51 +++
1 file changed, 35 insertions(+), 16 deletions(-)
diff --git
blk_probe_geometry and if it fails, fallback to the old logic.
Ekaterina Tumanova (5):
block: add bdrv functions for geometry and blocksize
raw-posix: Factor block size detection out of raw_probe_alignment()
block: Add driver methods to probe blocksizes and geometry
block-backend: Add wrappers
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
---
block/block-backend.c | 10 ++
include/sysemu/block-backend.h | 2 ++
2 files changed, 12 insertions(+)
diff --git
Add driver functions for geometry and blocksize detection
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
---
block.c | 36
backend but DASD).
The blkconf_blocksizes call was added to all users of BlkConf.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
---
hw/block/block.c | 20
hw/block/hd-geometry.c | 10
was introduced. It calls BIODASDINFO2
ioctl and returns its rc.
Blocksizes detection function will probe sizes for DASD devices and
set default for other devices.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
---
block/raw-posix.c
On 01/02/2015 02:52 PM, Stefan Hajnoczi wrote:
On Thu, Dec 18, 2014 at 12:18:01PM +0100, Ekaterina Tumanova wrote:
+#if defined(BLKSSZGET)
+# define SECTOR_SIZE BLKSSZGET
+#elif defined(DKIOCGETBLOCKSIZE)
+# define SECTOR_SIZE DKIOCGETBLOCKSIZE
+#elif defined(DIOCGSECTORSIZE)
+# define
On 01/02/2015 02:30 PM, Stefan Hajnoczi wrote:
On Thu, Dec 18, 2014 at 12:17:59PM +0100, Ekaterina Tumanova wrote:
Updates v4 - v5:
Minor Updates according the last review from Markus:
1. update commit message for patch 2
2. fix comment typos
3. fix check_for_dasd to return -1 instead
was introduced. It calls BIODASDINFO2
ioctl and returns its rc.
Blocksizes detection function will probe sizes for DASD devices and
set default for other devices.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
---
block/raw-posix.c
.
Ekaterina Tumanova (5):
block: add bdrv functions for geometry and blocksize
raw-posix: Refactor logical block size detection.
block: Add driver methods to probe blocksizes and geometry
block-backend: Add wrappers for blocksizes and geometry probing
BlockConf: Call backend functions to detect
Add driver functions for geometry and blocksize detection
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
---
block.c | 35
backend but DASD).
The blkconf_blocksizes call was added to all users of BlkConf.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
---
hw/block/block.c | 15 +++
hw/block/hd-geometry.c| 10 +-
hw/block
1. Move block size detection into dedicated function.
2. Select exactly one IOCTL that detects blocksize, specific to the host OS.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
---
block/raw-posix.c | 41
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Markus Armbruster arm...@redhat.com
---
block/block-backend.c | 10 ++
include/sysemu/block-backend.h | 2 ++
2 files changed, 12 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
Put it in new probe_logical_blocksize().
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block/raw-posix.c | 41 -
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index e51293a
,
blocksize properties were initialized with 0. (driver will return 512 if
backing device probing didn't succeed or if driver method is not defined).
2. hd_geometry guess was changed to firstly try to retrieve values via
blk_probe_geometry and if it fails, fallback to the old logic.
Ekaterina
Add driver functions for geometry and blocksize detection
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com
---
block.c | 34 ++
include/block/block.h | 13 +
include
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block/block-backend.c | 10 ++
include/sysemu/block-backend.h | 2 ++
2 files changed, 12 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index ef16d73..4b9ed85 100644
--- a/block/block
was introduced. It calls BIODASDINFO2
ioctl and returns its rc.
Blocksizes detection function will probe sizes for DASD devices and
set default for other devices.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block/raw-posix.c | 97
backend but DASD).
The blkconf_blocksizes call was added to all users of BlkConf.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
hw/block/block.c | 15 +++
hw/block/hd-geometry.c| 10 +-
hw/block/nvme.c | 1 +
hw/block/virtio-blk.c
On 12/15/2014 04:29 PM, Markus Armbruster wrote:
Ekaterina Tumanova tuman...@linux.vnet.ibm.com writes:
This patch introduces driver methods of defining disk blocksizes
(physical and logical) and hard drive geometry.
The method is only implemented for host_device. For raw devices
driver calls
On 12/15/2014 04:50 PM, Markus Armbruster wrote:
Ekaterina Tumanova tuman...@linux.vnet.ibm.com writes:
geometry: hd_geometry_guess function autodetects the drive geometry.
This patch adds a block backend call, that probes the backing device
geometry. If the inner driver method is implemented
On 12/05/2014 08:56 PM, Ekaterina Tumanova wrote:
This 3rd revision of the patch set.
Proper geometry and blocksize information is vital for support of
DASD/ECKD drives in Linux guests. Otherwise things will fail in
certain cases.
The existing geometry and blocksize qemu defaults have no sense
On 12/10/2014 04:14 PM, Thomas Huth wrote:
On Fri, 5 Dec 2014 18:56:19 +0100
Ekaterina Tumanova tuman...@linux.vnet.ibm.com wrote:
This patch introduces driver methods of defining disk blocksizes
(physical and logical) and hard drive geometry.
The method is only implemented for host_device
backend but DASD).
The blkconf_blocksizes call was added to all users of BlkConf.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
hw/block/block.c | 18 ++
hw/block/hd-geometry.c| 12
hw/block/nvme.c | 1 +
hw/block/virtio
that a local check_for_dasd function was introduced,
which calls BIODASDINFO2 ioctl and returns its rc.
Blocksizes detection fuction will probe sizes for DASD devices and
set default for other devices.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block/raw-posix.c | 91
in DEFINE_BLOCK_PROPERTIES. set defaults in
blk_probe_blocksizes (now always succeeds) and call it only if property is 0.
- fix cylinders calculation.
- document blk_probe_geometry call as currently only for DASD.
- anything I forgot :)
Ekaterina Tumanova (5):
block: add bdrv functions for geometry
Add driver functions for geometry and blocksize detection
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block.c | 35 +++
include/block/block.h | 13 +
include/block/block_int.h | 5 +
3 files changed, 53
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block/block-backend.c | 10 ++
include/sysemu/block-backend.h | 2 ++
2 files changed, 12 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index d0692b1..9cd97c6 100644
--- a/block/block
Put it in new probe_logical_blocksize().
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block/raw-posix.c | 44 +++-
1 file changed, 27 insertions(+), 17 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index b1af77e
On 11/28/2014 01:10 PM, Markus Armbruster wrote:
Ekaterina Tumanova tuman...@linux.vnet.ibm.com writes:
hd_geometry_guess function autodetects the drive geometry. This patch
adds a block backend call, that probes the backing device geometry.
If the inner driver method is implemented
Suggest function comment
/**
* Return logical block size, or zero if we can't figure it out
*/
{
-BDRVRawState *s = bs-opaque;
-char *buf;
-unsigned int sector_size;
-
-/* For /dev/sg devices the alignment is not really used.
- With buffered I/O, we
On 11/28/2014 01:35 PM, Stefan Hajnoczi wrote:
On Wed, Nov 26, 2014 at 01:16:48PM +0300, Ekaterina Tumanova wrote:
On 11/25/2014 04:01 PM, Stefan Hajnoczi wrote:
On Wed, Nov 19, 2014 at 11:17:50AM +0100, Ekaterina Tumanova wrote:
3. Why does s390 need to customize hd_geometry_guess()?
Since
On 11/28/2014 03:52 PM, Markus Armbruster wrote:
Ekaterina Tumanova tuman...@linux.vnet.ibm.com writes:
Suggest function comment
/**
* Return logical block size, or zero if we can't figure it out
*/
{
-BDRVRawState *s = bs-opaque;
-char *buf;
-unsigned
On 11/27/2014 05:55 PM, Markus Armbruster wrote:
I'm sorry for the delay. I got the flu and have difficulties thinking
straight for longer than a few minutes.
Ekaterina Tumanova tuman...@linux.vnet.ibm.com writes:
Add driver functions for geometry and blocksize detection
Signed-off
On 11/25/2014 04:01 PM, Stefan Hajnoczi wrote:
On Wed, Nov 19, 2014 at 11:17:50AM +0100, Ekaterina Tumanova wrote:
Hi folks,
I'm sorry for the recent spam. I messed up during code submission last time.
So please ignore any previous notes you received from me and answer only to
this thread
On 11/20/2014 07:18 PM, Kevin Wolf wrote:
Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben:
On Wed, 19 Nov 2014 14:40:07 +
Peter Maydell peter.mayd...@linaro.org wrote:
On 19 November 2014 14:01, Ekaterina Tumanova
tuman...@linux.vnet.ibm.com wrote:
Signed-off-by: Ekaterina Tumanova
by means of
BIODASDINFO2 ioctl.
Original patchset can be found here:
http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg03791.html
Ekaterina Tumanova (6):
geometry: add bdrv functions for geometry and blocksize
geometry: Detect blocksize via ioctls in separate static functions
geometry
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block/block-backend.c | 10 ++
include/sysemu/block-backend.h | 2 ++
2 files changed, 12 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index d0692b1..6717301 100644
--- a/block/block
Move the IOCTL calls that detect logical blocksize from raw_probe_alignment
into separate function (probe_logical_blocksize).
Introduce function which detect physical blocksize via IOCTL
(probe_physical_blocksize).
Both functions will be used in the next patch.
Signed-off-by: Ekaterina Tumanova
-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
hw/block/block.c | 11 +++
hw/block/hd-geometry.c | 9 +
hw/block/virtio-blk.c| 1 +
include/hw/block/block.h | 1 +
4 files changed, 22 insertions(+)
diff --git a/hw/block/block.c b/hw/block/block.c
index
Add driver functions for geometry and blocksize detection
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block.c | 26 ++
include/block/block.h | 20
include/block/block_int.h | 3 +++
3 files changed, 49
simply set in to NONE.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
hw/block/Makefile.objs | 6 +-
hw/block/hd-geometry.c | 36 +++-
2 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/hw/block/Makefile.objs b/hw/block
function was introduced, which calls BIODASDINFO2 ioctl
and returns 0 only if it succeeds.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
block/raw-posix.c | 65 +++
block/raw_bsd.c | 12 ++
2 files changed, 77
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
hw/block/hd-geometry.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/block/hd-geometry.c b/hw/block/hd-geometry.c
index b462225..905d2c6 100644
--- a/hw/block/hd-geometry.c
+++ b/hw/block/hd
copying to mail list
Forwarded Message
Subject: [PATCH v2 1/6] geometry: add bdrv functions for geometry and
blocksize
Date: Tue, 18 Nov 2014 17:09:56 +0100
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com
copying to mail list
Forwarded Message
Subject: [PATCH v2 2/6] geometry: Detect blocksize via ioctls in
separate static functions
Date: Tue, 18 Nov 2014 17:09:57 +0100
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
To: arm...@redhat.com, pbonz...@redhat.com, stefa
copying to mail list
Forwarded Message
Subject: [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes
and geometry
Date: Tue, 18 Nov 2014 17:09:58 +0100
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
To: arm...@redhat.com, pbonz...@redhat.com, stefa
copying to mail list
Forwarded Message
Subject: [PATCH v2 5/6] geometry: Call backend function to detect
geometry and blocksize
Date: Tue, 18 Nov 2014 17:10:00 +0100
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
To: arm...@redhat.com, pbonz...@redhat.com, stefa
copying to mail list
Forwarded Message
Subject: [PATCH v2 4/6] geometry: Add block-backend wrappers for
geometry probing
Date: Tue, 18 Nov 2014 17:09:59 +0100
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com
copying to mail list
Forwarded Message
Subject: [PATCH v2 6/6] geometry: Target specific hook for s390x in
geometry guessing
Date: Tue, 18 Nov 2014 17:10:01 +0100
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
To: arm...@redhat.com, pbonz...@redhat.com, stefa
copying to mail list
Forwarded Message
Subject: [PATCH v2 0/6] Geometry and blocksize support for backing devices
Date: Tue, 18 Nov 2014 17:09:55 +0100
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com,
kw
On 11/07/2014 12:17 PM, Markus Armbruster wrote:
Christian Borntraeger borntrae...@de.ibm.com writes:
Markus, Kevin, Stefan,
here is a (somewhat late) followup of some KVM forum discussions regarding
block size and geometry of pass-through block devices. Let's just do a quick
wrap-up (as of
On 09/03/2014 07:46 PM, Stefan Hajnoczi wrote:
On Tue, Jul 29, 2014 at 02:27:19PM +0200, Ekaterina Tumanova wrote:
This patch add the blkconf_blocksize call to all
devices, which use DEFINE_BLOCK_PROPERTIES.
If the underlying driver function fails, blkconf_blocksizes
will set blocksizes
for raw and
host_device drivers.
(also requested by the reviewers of the original patch)
Ekaterina Tumanova (4):
hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x
blocksize: support auto-sensing of blocksizes
blocksize: Add driver method to get the blocksizes
blocksize: add
moved into
separate function probe_logical_blocksize). For detecting the
physical blocksize it uses BLKPBSZGET ioctl.
For raw devices driver calls the child's method.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Acked
driver. If this does not work 512 is used,
so the default excecution logic is not changed.
Based on 2013 patch from Einar Lueck elelu...@de.ibm.com
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Acked-by: Cornelia Huck
-l in the guest.
Based on 2013 patch from Einar Lueck elelu...@de.ibm.com
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Acked-by: Cornelia Huck cornelia.h...@de.ibm.com
---
hw/block/Makefile.objs | 6 +-
hw/block/hd
This patch add the blkconf_blocksize call to all
devices, which use DEFINE_BLOCK_PROPERTIES.
If the underlying driver function fails, blkconf_blocksizes
will set blocksizes to default (512) value.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: David Hildenbrand d
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
dump.c | 7 +--
target-i386/cpu.h | 2 ++
target-s390x/cpu.h | 1 +
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/dump.c b/dump.c
index 8f64aab..25503bc 100644
--- a/dump.c
+++ b/dump.c
@@ -32,6
You're right about the warning. I removed it. I also added the
cast for the destination argument, which caused a warning as well.
I tested on s390 and i386 laptop.
If you ok with the patch, can you push it on top of this series?
Thank you,
Regards,
Kate.
Ekaterina Tumanova (1):
Define
True! Fixed. Tested.
Can you please put it into push-queue?
Thanks,
Kate.
Ekaterina Tumanova (1):
Define the architecture for compressed dump format.
dump.c | 7 +--
target-i386/cpu.h | 2 ++
target-s390x/cpu.h | 1 +
3 files changed, 8 insertions(+), 2 deletions
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
---
dump.c | 7 +--
target-i386/cpu.h | 2 ++
target-s390x/cpu.h | 1 +
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/dump.c b/dump.c
index 8f64aab..8d85255 100644
--- a/dump.c
+++ b/dump.c
@@ -32,6
If you apply this patch on top of your changes, your patches will work
on s390x as well.
---
dump.c | 8 ++--
target-i386/cpu.h | 2 ++
target-s390x/cpu.h | 1 +
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/dump.c b/dump.c
index 8f64aab..12ad114 100644
---
On 01/28/2014 10:22 AM, qiaonuohan wrote:
the functions are used to write header of kdump-compressed format to vmcore.
Header of kdump-compressed format includes:
1. common header: DiskDumpHeader32 / DiskDumpHeader64
2. sub header: KdumpSubHeader32 / KdumpSubHeader64
3. extra information: only
On 01/28/2014 10:22 AM, qiaonuohan wrote:
the functions are used to write header of kdump-compressed format to vmcore.
Header of kdump-compressed format includes:
1. common header: DiskDumpHeader32 / DiskDumpHeader64
2. sub header: KdumpSubHeader32 / KdumpSubHeader64
3. extra information: only
On 01/28/2014 05:37 PM, Laszlo Ersek wrote:
Hello Ekaterina,
On 01/28/14 12:51, Ekaterina Tumanova wrote:
On 01/28/2014 10:22 AM, qiaonuohan wrote:
the functions are used to write header of kdump-compressed format to
vmcore.
Header of kdump-compressed format includes:
1. common header
On 01/17/2014 11:46 AM, qiaonuohan wrote:
the functions are used to write header of kdump-compressed format to vmcore.
Header of kdump-compressed format includes:
1. common header: DiskDumpHeader32 / DiskDumpHeader64
2. sub header: KdumpSubHeader32 / KdumpSubHeader64
3. extra information: only
On 01/17/2014 11:46 AM, qiaonuohan wrote:
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed
format. The command's usage:
dump [-p] protocol [begin] [length] [format]
'format' is used to specified the format of vmcore and can be:
1. 'elf': ELF format, without
On 04/30/2013 02:02 PM, Alexander Graf wrote:
On 29.04.2013, at 13:39, Ekaterina Tumanova wrote:
On 04/26/2013 09:12 PM, Alexander Graf wrote:
On 23.04.2013, at 17:30, Jens Freimann wrote:
Implement dump-guest-memory support for target s390x.
dump-guest-memory QEMU monitor command didn't
dump.
In order to implement this, the arch-specific part of dump-guest-memory
was added:
target-s390x/arch_dump.c contains the whole set of function for writing
Elf note sections of all types for s390x.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Signed-off-by: Jens Freimann jf
. If -p is specified on a target that doesn't support it,
we will pass an error to the calling code.
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com
---
+++ b/include/qapi/qmp/qerror.h
@@ -249,4 +249,7 @@ void assert_no_error(Error
84 matches
Mail list logo
