OK, looks like I cannot reopen the bug, probably because the bug tracker
moved to gitlab.
If you care about this feature, please file a bug over there:
https://gitlab.com/qemu-project/qemu/-/issues
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
Looks like support for this was not fully added; my apologies for
closing this bug too early.
Adding full support for strong-on-weak emulation would be simple, at
least when it comes to memory ordering. The slowdown would be huge
though, see Figure 12 in
eed a seqlock to avoid races
between readers and the writing vCPU. I see that qemu_plugin_get_hwaddr
does not even take a vCPU index, so this should be OK -- as long as this
is called only from a mem callback, it's in the same vCPU thread and it's
therefore safe.
With the above comments fixed,
Reviewed-by: Emilio G. Cota
Thanks,
Emilio
On Thu, Jul 09, 2020 at 15:13:22 +0100, Alex Bennée wrote:
> While there isn't any easy way to make the inline counts thread safe
Why not? At least in 64-bit hosts TCG will emit a single write to
update the 64-bit counter.
> we can ensure the callback based ones are. While we are at it we can
>
On Fri, Jul 10, 2020 at 14:03:27 -0700, Richard Henderson wrote:
> On 7/9/20 7:13 AM, Alex Bennée wrote:
> > Any write to a device might cause a re-arrangement of memory
> > triggering a TLB flush and potential re-size of the TLB invalidating
> > previous entries. This would cause users of
the warning:
>
> invalid use of qemu_plugin_get_hwaddr
>
> because of the failed tlb_lookup which should always succeed. To
> prevent this we save the IOTLB data in case it is later needed by a
> plugin doing a lookup.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Emilio
On Thu, Jul 09, 2020 at 15:13:16 +0100, Alex Bennée wrote:
> This attempts to bring together my understanding of the requirements
> for icount behaviour into one reference document for our developer
> notes.
>
> Signed-off-by: Alex Bennée
> Reviewed-by: Richard Henderson
Rev
On Thu, Jul 09, 2020 at 15:13:15 +0100, Alex Bennée wrote:
> @@ -92,6 +107,7 @@ including:
>
>- debugging operations (breakpoint insertion/removal)
>- some CPU helper functions
> + - linux-user spawning it's first thread
s/it's/its/
Reviewed-by: Emilio G
You should then find out why libqemu_plugin.dll.a is not working. It is
possible though that your linked is calling the import library something
else, for instance adding a .dll extension to it.
You will have to run a few tests with your linker (I'd just use the
examples from the stackoverflow
You're getting close.
1. From the build directory, find the import library created, e.g. `find
. -name 'libqemu_plugin.dll.a'`. If you're building x86_64-linux-user,
it should be in `x86_64-linux-user/libqemu_plugin.dll.a`.
2. Go back to the `build/tests/plugin` directory.
3. Link the empty
Xiaolei confirmed to me via email that adding -DBUILDING_DLL is not
enough to fix the problem.
I looked into this a bit further and it looks like we need an "import library"
to be created when compiling the QEMU binary. This is accomplished by adding
"-Wl,--out-implib,libqemu_plugin.a" to the
I never built the plugin code on anything other than Linux :(
All I did for Windows is to try to follow https://gcc.gnu.org/wiki/Visibility
Can you please try the following patch (with no other changes)?
The patch applies on top of v4.2.0.
diff --git a/tests/plugin/Makefile
expanded the comment
> in do_threshold.
Reviewed-by: Emilio G. Cota
for the series. Thanks a lot!
E.
Cc'ing Philippe, who authored the fix for this in May as I mention below.
Emilio
On Sun, Jun 21, 2020 at 17:28:25 -0400, Emilio G. Cota wrote:
> On Sat, Jun 20, 2020 at 14:45:51 -0700, Richard Henderson wrote:
> > Use <= comparisons vs the threshold, so that threshol
On Mon, Jun 22, 2020 at 10:02:50 +0100, Alex Bennée wrote:
> Emilio G. Cota writes:
> > On Wed, Jun 10, 2020 at 16:55:06 +0100, Alex Bennée wrote:
(snip)
> >> +#ifdef CONFIG_PLUGIN
> >> +
> >> +typedef struct SavedIOTLB {
> >> +struct rcu_hea
On Sat, Jun 20, 2020 at 14:45:51 -0700, Richard Henderson wrote:
> Use <= comparisons vs the threshold, so that threshold UINT64_MAX
> is always true, corresponding to rate 1.0 being unity. Simplify
> do_threshold scaling to 2**64, with a special case for 1.0.
>
> Cc: Emilio
On Wed, Jun 10, 2020 at 16:55:06 +0100, Alex Bennée wrote:
> Any write to a device might cause a re-arrangement of memory
> triggering a TLB flush and potential re-size of the TLB invalidating
> previous entries. This would cause users of qemu_plugin_get_hwaddr()
> to see the warning:
>
>
On Tue, Jun 09, 2020 at 12:09:54 +0100, Alex Bennée wrote:
> How about a g_intern_string() as a non-freeable const char that can also
> be treated as canonical?
I like it. Didn't know about g_intern_string (I see it's
implemented as an append-only hash table protected by a lock).
Cheers,
On Mon, Jun 08, 2020 at 09:06:17 +0100, Alex Bennée wrote:
> Emilio G. Cota writes:
> > I'd rather use asprintf(3) and strdup(3) here, so that plugins don't
> > have to worry about glib, and on the QEMU side we don't have to worry
> > about plugins calling free() instead of
> the test-char, test-qga, and test-qdev-global-props.
>
> Signed-off-by: Robert Foley
Reviewed-by: Emilio G. Cota
Thanks,
Emilio
On Tue, Jun 02, 2020 at 16:46:22 +0100, Alex Bennée wrote:
> This may well end up being anonymous but it should always be unique.
>
> Signed-off-by: Alex Bennée
> ---
> include/qemu/qemu-plugin.h | 5 +
> plugins/api.c | 18 ++
> 2 files changed, 23
On Fri, May 29, 2020 at 09:23:41 -0400, Robert Foley wrote:
> This allows us to see the name of the thread in tsan
> warning reports such as this:
>
> Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:
>
> Signed-off-by: Robert Foley
Reviewed-by: Emili
quot;qemu/qemu-plugin.h" as a special header that doesn't need
> to be cleaned for "qemu/osdep.h".
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Emilio G. Cota
Thanks,
Emilio
Signed-off-by: Emilio G. Cota
---
include/qemu/qemu-plugin.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index 89ed579f55..bab8b0d4b3 100644
--- a/include/qemu/qemu-plugin.h
+++ b/include/qemu/qemu-plugin.h
@@ -12,6 +12,7
Hi Alex,
On Tue, May 12, 2020 at 21:11:46 +0100, Alex Bennée wrote:
>
> Emilio G. Cota writes:
>
> > On Mon, May 11, 2020 at 18:53:19 +0300, Nikolay Igotti wrote:
> >> Attached to the mail counter.c when running with attached test.c compiled
> >> to Linux stand
On Sat, May 23, 2020 at 13:20:15 -0400, Emilio G. Cota wrote:
> On Fri, May 22, 2020 at 12:07:46 -0400, Robert Foley wrote:
> > These annotations will allow us to give tsan
> > additional hints. For example, we can inform
> > tsan about reads/writes to ignore to silenc
On Fri, May 22, 2020 at 12:07:36 -0400, Robert Foley wrote:
> This patch series continues the work done by Emilio Cota and others to add
> Thread Sanitizer (TSan) support to QEMU.
>
> The starting point for this work was Emilio's branch here:
> https://github.com/cota/qemu/commits/tsan
>
On Fri, May 22, 2020 at 12:07:51 -0400, Robert Foley wrote:
> For example:
> WARNING: ThreadSanitizer: data race (pid=23406)
> Atomic read of size 4 at 0x7b13e3c8 by thread T7:
> #0 __tsan_atomic32_load (qemu-system-aarch64+0x39a36c)
> #1 qht_do_lookup util/qht.c:495:17
On Fri, May 22, 2020 at 12:07:55 -0400, Robert Foley wrote:
> This includes details on how to build and test with TSan
> both inside a docker and outside.
>
> Signed-off-by: Robert Foley
Reviewed-by: Emilio G. Cota
E.
On Fri, May 22, 2020 at 12:07:53 -0400, Robert Foley wrote:
> This allows us to see the name of the thread in tsan
> warning reports such as this:
>
> Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:
>
> Signed-off-by: Robert Foley
Reviewed-
On Fri, May 22, 2020 at 12:07:50 -0400, Robert Foley wrote:
> For example:
> Atomic write of size 8 at 0x7b4800113c28 by main thread (mutexes: write
> M30):
> #0 __tsan_atomic64_exchange (qemu-system-aarch64+0x386f85)
> #1 aio_bh_poll util/async.c:146:5 (qemu-system-aarch64+0xcd1f61)
>
On Fri, May 22, 2020 at 12:07:49 -0400, Robert Foley wrote:
> For example:
> WARNING: ThreadSanitizer: data race (pid=35425)
> Write of size 4 at 0x7bbc00ac by main thread (mutexes: write M875):
> #0 cpu_reset_interrupt hw/core/cpu.c:107:28 (qemu-system-aarch64+0x843790)
> #1
On Fri, May 22, 2020 at 12:07:48 -0400, Robert Foley wrote:
> Initially put several files into blacklist that were
> causing the most problems, namely bitops.c and bitmap.c.
>
> Signed-off-by: Robert Foley
> ---
> configure | 3 ++-
> tests/tsan/blacklist.tsan | 5 +
> 2
#2 qemu_thread_start util/qemu-thread-posix.c:519:9
> (qemu-system-aarch64+0xd431e0)
>
> Location is global 'parallel_cpus' of size 1 at 0x557cd83aee28
> (qemu-system-aarch64+0x01fb3e28)
>
> Cc: Richard Henderson
> Cc: Paolo Bonzini
> Signed-off-by: Robert Foley
Reviewed-by: Emilio G. Cota
E.
thread
> naming shows up in tsan warning results.
>
> Signed-off-by: Robert Foley
Reviewed-by: Emilio G. Cota
E.
On Fri, May 22, 2020 at 23:36:18 +0100, Peter Maydell wrote:
> So is this:
> (a) a TSan false positive, because we've analysed the use
> of this struct field and know it's not a race because
> [details], but which we're choosing to silence in this way
> (b) an actual race for which the
On Mon, May 18, 2020 at 09:46:36 -0400, Robert Foley wrote:
> We re-ran the numbers with the latest re-based series.
>
> We used an aarch64 ubuntu VM image with a host CPU:
> Intel(R) Xeon(R) Silver 4114 CPU @ 2.20GHz, 2 CPUs, 10 cores/CPU,
> 20 Threads/CPU. 40 cores total.
>
> For the bare
On Mon, May 11, 2020 at 18:53:19 +0300, Nikolay Igotti wrote:
> Attached to the mail counter.c when running with attached test.c compiled
> to Linux standalone binary shows failing assert, unless the patch is
> applied.
I didn't get the attachment. Can you paste the code at the end of your
reply?
; "exec/cpu: Poison 'hwaddr' type in user-mode emulation"
>
> Philippe Mathieu-Daudé (3):
> qemu/plugin: Trivial code movement
> qemu/plugin: Move !CONFIG_PLUGIN stubs altogether
> qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument
> const
On Mon, Apr 20, 2020 at 13:04:51 +0300, Nikolay Igotti wrote:
> In linux-user multithreaded scenarious CPU could be inited many times with
> the same id,
> so avoid assertions on already present hashtable entry.
>
> Signed-off-by: Nikolay Igotti
> ---
> plugins/core.c | 5 +
> 1 file
ld = rate * nextafter(0x1p64, 0.0);
Reviewed-by: Emilio G. Cota
Please consider mentioning 25f74087c69 in the commit log -- it clearly
describes the problem.
Thanks,
Emilio
(Apologies if I missed some Cc's; I was not Cc'ed in patch 0
so I'm blindly crafting a reply.)
On Thu, Mar 26, 2020 at 15:30:43 -0400, Robert Foley wrote:
> This is a continuation of the series created by Emilio Cota.
> We are picking up this patch set with the goal to apply
> any fixes or
itly copy vaddr
> before the op to ensure it is live my the time we do the
> instrumentation.
s/my the time/by the time/
Reviewed-by: Emilio G. Cota
E.
parent build hasn't got the bits we need.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Emilio G. Cota
E.
Reported-by: Robert Henry
Signed-off-by: Emilio G. Cota
---
plugins/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/plugins/core.c b/plugins/core.c
index 9e1b9e7a91..ed863011ba 100644
--- a/plugins/core.c
+++ b/plugins/core.c
@@ -286,6 +286,7 @@ static inline uint32_t cb_to_tcg_flags
On Fri, May 10, 2019 at 11:36:33 +0100, Alex Bennée wrote:
> Ping Emilio/Mark
>
> Would you be able to re-run your tests to check there are no other
> regressions? I can then get the PR prepared for merging ;-)
I'll try to run some tests next week, but I am not sure I'll
have time to do so. If I
MFlops
- after:
178.49 MFlops
178.88 MFlops
178.66 MFlops
Signed-off-by: Kito Cheng
Signed-off-by: Emilio G. Cota
---
fpu/softfloat.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 4610738ab1..2ba36ec370 100644
--- a/fpu
On Sat, Mar 23, 2019 at 01:39:26 +0800, Kito Cheng wrote:
> hardfloat fused multiply-add might fallback to softfloat mode in some
> situation, but it might already changed the value of input operands,
> so we must restore those value before fallback.
>
> This bug is catched by running gcc
On Sat, Mar 09, 2019 at 13:53:32 +0800, Li Qiang wrote:
> Hi all,
>
> Today I ‘git clone’ && configure && make && make check
>
> And get following error,
>
> fp-test.c:50:10: fatal error: fail.h: No such file or directory
> #include "fail.h"
> ^~~~
>
> I look at the commit:
>
On Thu, Feb 28, 2019 at 10:05:02 -0800, Richard Henderson wrote:
> On 2/28/19 9:18 AM, Stephen Checkoway wrote:
> > I wonder if it would make sense to maintain a small cache of TLBs. The
> > majority of cases are likely to involving setting segment registers to one
> > of a handful of segments
On Wed, Mar 06, 2019 at 11:40:57 -0800, Richard Henderson wrote:
> Peter reported to me a hang on the x86_64
> bios-tables-test with an arm32 host. I have been able to replicate this.
(snip)
I reproduced this on a power7 machine (gcc110). However, after a few
git checkout->build cycles I was not
On Tue, Mar 05, 2019 at 16:01:45 +, Peter Maydell wrote:
> On Tue, 5 Mar 2019 at 15:01, Richard Henderson
> wrote:
> >
> > This is Emilio's v7, unchanged, so I'm not re-posting the 73 patches.
> >
> > I also didn't want to add Signed-off-by to 73 patches, so I verified
> > that there was
Cc: David Gibson
Cc: qemu-...@nongnu.org
Reviewed-by: Richard Henderson
Acked-by: David Gibson
Signed-off-by: Emilio G. Cota
---
hw/ppc/ppc.c| 2 +-
target/ppc/kvm.c| 4 ++--
target/ppc/translate_init.inc.c | 14 +++---
3 files changed, 10
Soon we will call cpu_has_work without the BQL.
Cc: Cornelia Huck
Cc: David Hildenbrand
Cc: qemu-s3...@nongnu.org
Reviewed-by: Richard Henderson
Reviewed-by: Cornelia Huck
Signed-off-by: Emilio G. Cota
---
target/s390x/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
Cc: Guan Xuetao
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/unicore32/cpu.c | 2 +-
target/unicore32/softmmu.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/unicore32/cpu.c b/target/unicore32/cpu.c
index
Cc: "Edgar E. Iglesias"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/cris/cpu.c| 2 +-
target/cris/helper.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/cris/cpu.c b/target/cris/cpu.c
index
Cc: Anthony Green
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/moxie/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/moxie/cpu.c b/target/moxie/cpu.c
index 46434e65ba..72206a03ee 100644
--- a/target/moxie
Cc: Laurent Vivier
Reviewed-by: Richard Henderson
Reviewed-by: Laurent Vivier
Signed-off-by: Emilio G. Cota
---
target/m68k/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c
index 582e3a73b3..99a7eb4340 100644
--- a/target/m68k
Cc: Cornelia Huck
Cc: Christian Borntraeger
Cc: David Hildenbrand
Cc: qemu-s3...@nongnu.org
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Cornelia Huck
Signed-off-by: Emilio G. Cota
---
hw/intc/s390_flic.c | 2 +-
target/s390x/cpu.c | 2 +-
2 files changed, 2
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
accel/tcg/cpu-exec.c | 15 ---
accel/tcg/tcg-all.c | 12 +---
accel/tcg/translate-all.c | 2 +-
3 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/accel/tcg
This finishes the conversion to interrupt_request.
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
---
qom/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qom/cpu.c b/qom/cpu.c
index 00add81a7f..f2695be9b2 100644
--- a/qom
After completing the conversion to per-CPU locks, there is no need
to release the BQL after having called cpu_kick.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
cpus-common.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions
Cc: Aurelien Jarno
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/sh4/cpu.c| 2 +-
target/sh4/helper.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c
index b9f393b7c7..58ea212f53
Soon we will call cpu_has_work without the BQL.
Cc: Mark Cave-Ayland
Cc: Artyom Tarasenko
Reviewed-by: Richard Henderson
Acked-by: Mark Cave-Ayland
Signed-off-by: Emilio G. Cota
---
target/sparc/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/sparc/cpu.c
Cc: Michael Walle
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/lm32/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/lm32/cpu.c b/target/lm32/cpu.c
index b7499cb627..1508bb6199 100644
--- a/target/lm32/cpu.c
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/i386/kvm.c | 58 ---
1 file changed, 35 insertions(+), 23 deletions(-)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index f2e187e40f..44a9e3d243
Cc: Chris Wulff
Cc: Marek Vasut
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/nios2/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c
index fbfaa2ce26..49a75414d3 100644
Soon we will call cpu_has_work without the BQL.
Cc: David Gibson
Cc: qemu-...@nongnu.org
Reviewed-by: Richard Henderson
Acked-by: David Gibson
Signed-off-by: Emilio G. Cota
---
target/ppc/translate_init.inc.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git
From: Paolo Bonzini
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Paolo Bonzini
Signed-off-by: Emilio G. Cota
---
target/i386/hax-all.c| 4 ++--
target/i386/hvf/x86hvf.c | 8
target/i386/kvm.c| 14 +++---
target/i386/seg_helper.c | 13
It will gain some users soon.
Suggested-by: Paolo Bonzini
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
include/qom/cpu.h | 37 ++---
1 file changed, 34 insertions(+), 3 deletions(-)
diff --git a/include/qom/cpu.h b
Cc: "Edgar E. Iglesias"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/microblaze/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c
index 5596cd5485..0cdd7fe
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/i386/cpu.c| 2 +-
target/i386/helper.c | 4 ++--
target/i386/svm_helper.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index 518064530b..5ed64e274b 100644
--- a/exec.c
+++ b/exec.c
@@ -779,7 +779,7 @@ static int cpu_common_post_load
This function is only called from TCG rr mode, so add
a prefix to mark this as well as an assertion.
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
---
cpus.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/cpus.c b/cpus.c
off-by: Emilio G. Cota
---
include/qom/cpu.h | 20 ++--
cpus.c| 281 ++
qom/cpu.c | 29 +
3 files changed, 225 insertions(+), 105 deletions(-)
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index fc768bbe00..44e6e83ecd 100
s complete,
cpu_interrupt_request will be simple again.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
include/qom/cpu.h | 37 +
qom/cpu.c | 27 +--
2 files changed, 58 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
---
target/i386/hvf/hvf.c| 8 +---
target/i386/hvf/x86hvf.c | 26 +++---
2 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
index 7dc1d721ff
Some async jobs do not need the BQL.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
include/qom/cpu.h | 14 ++
cpus-common.c | 39 ++-
2 files changed, 48 insertions(+), 5 deletions(-)
diff --git
Cc: Stafford Horne
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
hw/openrisc/cputimer.c | 2 +-
target/openrisc/cpu.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c
index
id Gibson
Cc: qemu-...@nongnu.org
Reviewed-by: Richard Henderson
Acked-by: David Gibson
Signed-off-by: Emilio G. Cota
---
target/ppc/helper_regs.h| 2 +-
hw/ppc/e500.c | 4 ++--
hw/ppc/ppc.c| 10 +-
hw/ppc/ppce500_spin.c | 6 -
Cc: Peter Maydell
Cc: qemu-...@nongnu.org
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/arm/cpu.c | 6 +++---
target/arm/helper.c | 16 +++-
target/arm/machine.c | 2 +-
3 files changed, 11 insertions(+), 13 deletions
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/hppa/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c
index 00bf444620..1ab4e62850 100644
--- a/target/hppa/cpu.c
+++ b/target/hppa
conds time elapsed
( +- 0.13% )
That is, a 1.37% slowdown.
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Tested-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
accel/tcg/cputlb.c | 10 +-
1 file changed, 5 insertions(+), 5 deletion
Cc: Fabien Chouteau
Cc: Mark Cave-Ayland
Cc: Artyom Tarasenko
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Mark Cave-Ayland
Signed-off-by: Emilio G. Cota
---
hw/sparc/leon3.c | 2 +-
hw/sparc/sun4m.c | 8
hw/sparc64/sparc64.c | 4 ++--
target
Soon we will call cpu_has_work without the BQL.
Cc: Max Filippov
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
---
target/xtensa/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c
index d4ca35e6cc..5f3b4a70b0
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/alpha/cpu.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c
index 1fd95d6c0f..cebd459251 100644
--- a/target/alpha/cpu.c
+++ b
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
---
target/i386/whpx-all.c | 41 -
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c
index 9673bdc219..0d8cfa3a19 100644
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
gdbstub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index bc774ae992..569b504552 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1664,13 +1664,13 @@ static
Cc: Mark Cave-Ayland
Cc: Artyom Tarasenko
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Mark Cave-Ayland
Signed-off-by: Emilio G. Cota
---
hw/sparc64/sparc64.c | 4 ++--
target/sparc/cpu.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw
From: Paolo Bonzini
Cc: Cornelia Huck
Cc: David Hildenbrand
Cc: qemu-s3...@nongnu.org
Reviewed-by: David Hildenbrand
Reviewed-by: Richard Henderson
Reviewed-by: Cornelia Huck
Reviewed-by: Alex Bennée
Signed-off-by: Paolo Bonzini
Signed-off-by: Emilio G. Cota
---
target/s390x
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/i386/hax-all.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
index 518c6ff103..18da1808c6 100644
From: Paolo Bonzini
Cc: Stafford Horne
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Paolo Bonzini
Signed-off-by: Emilio G. Cota
---
target/openrisc/sys_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Cc: Eduardo Habkost
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/i386/cpu.h | 2 +-
target/i386/cpu.c | 2 +-
target/i386/hax-all.c | 4 ++--
target/i386/helper.c | 4 ++--
target/i386/hvf/hvf.c | 4
Cc: Cornelia Huck
Cc: Christian Borntraeger
Cc: David Hildenbrand
Cc: qemu-s3...@nongnu.org
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Cornelia Huck
Signed-off-by: Emilio G. Cota
---
hw/intc/s390_flic.c| 2 +-
target/s390x/cpu.c | 22
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
include/qom/cpu.h | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index c92a8c544a..651e1ab4d8 100644
--- a/include/qom/cpu.h
+++ b
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
accel/tcg/cpu-exec.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 45ef41ebb2..78dca325ba 100644
Cc: Andrzej Zaborowski
Cc: Peter Maydell
Cc: qemu-...@nongnu.org
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
hw/arm/omap1.c| 4 ++--
hw/arm/pxa2xx_gpio.c | 2 +-
hw/arm/pxa2xx_pic.c | 2 +-
target/arm/arm-powerctl.c | 6
Soon we will call cpu_has_work without the BQL.
Cc: Palmer Dabbelt
Cc: Sagar Karandikar
Cc: Bastian Koppelmann
Reviewed-by: Palmer Dabbelt
Reviewed-by: Richard Henderson
Reviewed-by: Alistair Francis
Signed-off-by: Emilio G. Cota
---
target/riscv/cpu.c | 5 -
1 file changed, 4
cpu->halted will soon be protected by cpu->lock.
We will use these helpers to ease the transition,
since right now cpu->halted has many direct callers.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
include/qom/cpu.h | 24 ++
Cc: Laurent Vivier
Reviewed-by: Richard Henderson
Reviewed-by: Laurent Vivier
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
target/m68k/op_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c
index
1 - 100 of 2303 matches
Mail list logo
